[jira] [Closed] (FLINK-25347) Replace deprecated TableSchema with Schema in MergeTableLikeUtil

2023-03-12 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu closed FLINK-25347. --- Fix Version/s: 1.18.0 Resolution: Fixed Fixed in master: d4a9a749310f33618b942dd0258855642001e0d3

[GitHub] [flink] wuchong closed pull request #22158: [FLINK-25347][table] Replace deprecated TableSchema with Schema in MergeTableLikeUtil

2023-03-12 Thread via GitHub
wuchong closed pull request #22158: [FLINK-25347][table] Replace deprecated TableSchema with Schema in MergeTableLikeUtil URL: https://github.com/apache/flink/pull/22158 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [flink] wuchong commented on pull request #22158: [FLINK-25347][table] Replace deprecated TableSchema with Schema in MergeTableLikeUtil

2023-03-12 Thread via GitHub
wuchong commented on PR #22158: URL: https://github.com/apache/flink/pull/22158#issuecomment-146061 Thank you for the reviewing @Aitozi , merging... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [flink] wuchong commented on a diff in pull request #22158: [FLINK-25347][table] Replace deprecated TableSchema with Schema in MergeTableLikeUtil

2023-03-12 Thread via GitHub
wuchong commented on code in PR #22158: URL: https://github.com/apache/flink/pull/22158#discussion_r1133467836 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/SqlCreateTableConverter.java: ## @@ -193,10 +179,7 @@ private CatalogTable

[jira] [Commented] (FLINK-31095) FileSink doesn't work with s3a on EKS

2023-03-12 Thread Sylvia Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699451#comment-17699451 ] Sylvia Lin commented on FLINK-31095: Hey [~martijnvisser] , Thanks for reply! I tried above configs

[GitHub] [flink] slfan1989 commented on pull request #22028: [FLINK-31230] Improve YarnClusterDescriptor memory unit display.

2023-03-12 Thread via GitHub
slfan1989 commented on PR #22028: URL: https://github.com/apache/flink/pull/22028#issuecomment-1465524698 @1996fanrui Can you help review this PR again? Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [flink] flinkbot commented on pull request #22166: Flink 31409

2023-03-12 Thread via GitHub
flinkbot commented on PR #22166: URL: https://github.com/apache/flink/pull/22166#issuecomment-1465522290 ## CI report: * 4a155eddd403c0357572ecf20ec329f52be1ea0f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] luoyuxia opened a new pull request, #22166: Flink 31409

2023-03-12 Thread via GitHub
luoyuxia opened a new pull request, #22166: URL: https://github.com/apache/flink/pull/22166 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them

[GitHub] [flink] TaoZex closed pull request #21688: [FLINK-30699][core] Improved getRandomString method code format in the StringUtils class

2023-03-12 Thread via GitHub
TaoZex closed pull request #21688: [FLINK-30699][core] Improved getRandomString method code format in the StringUtils class URL: https://github.com/apache/flink/pull/21688 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [flink] liyubin117 commented on pull request #21521: [FLINK-30435][table] `SHOW CREATE TABLE` statement shows column comment

2023-03-12 Thread via GitHub
liyubin117 commented on PR #21521: URL: https://github.com/apache/flink/pull/21521#issuecomment-1465504616 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #218: [FLINK-31306] Add Servable for PipelineModel

2023-03-12 Thread via GitHub
zhipeng93 commented on code in PR #218: URL: https://github.com/apache/flink-ml/pull/218#discussion_r1133434653 ## flink-ml-core/src/test/java/org/apache/flink/ml/api/PipelineTest.java: ## @@ -95,4 +109,59 @@ public void testPipeline() throws Exception { // Executes

[GitHub] [flink-table-store] zhangjun0x01 commented on a diff in pull request #584: [FLINK-31338] support infer parallelism for flink table store

2023-03-12 Thread via GitHub
zhangjun0x01 commented on code in PR #584: URL: https://github.com/apache/flink-table-store/pull/584#discussion_r1133432370 ## flink-table-store-flink/flink-table-store-flink-common/src/main/java/org/apache/flink/table/store/connector/source/TableStoreSource.java: ## @@ -162,15

[jira] [Updated] (FLINK-31410) ListStateWithCache Should support incremental snapshot

2023-03-12 Thread Zhipeng Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhipeng Zhang updated FLINK-31410: -- Description: In Flink ML, we use ListStateWithCache [2] to enable caching data in memory and

[jira] [Created] (FLINK-31410) ListStateWithCache Should support incremental snapshot

2023-03-12 Thread Zhipeng Zhang (Jira)
Zhipeng Zhang created FLINK-31410: - Summary: ListStateWithCache Should support incremental snapshot Key: FLINK-31410 URL: https://issues.apache.org/jira/browse/FLINK-31410 Project: Flink

[jira] [Updated] (FLINK-31410) ListStateWithCache Should support incremental snapshot

2023-03-12 Thread Zhipeng Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhipeng Zhang updated FLINK-31410: -- Issue Type: Improvement (was: Bug) > ListStateWithCache Should support incremental snapshot

[GitHub] [flink] reswqa commented on pull request #22090: [Flink 31170] [docs]The spelling error of the document word causes sql to fail to execute

2023-03-12 Thread via GitHub
reswqa commented on PR #22090: URL: https://github.com/apache/flink/pull/22090#issuecomment-1465467327 Thanks @BoYiZhang, would you mind referring [Apache Flink development guidelines](https://cwiki.apache.org/confluence/display/FLINK/Apache+Flink+development+guidelines) to modify the

[GitHub] [flink] flinkbot commented on pull request #22165: Bump snakeyaml from 1.33 to 2.0

2023-03-12 Thread via GitHub
flinkbot commented on PR #22165: URL: https://github.com/apache/flink/pull/22165#issuecomment-1465417685 ## CI report: * a03ab237ca9271fac2f7be53026d6719b29147fc UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] dependabot[bot] opened a new pull request, #22165: Bump snakeyaml from 1.33 to 2.0

2023-03-12 Thread via GitHub
dependabot[bot] opened a new pull request, #22165: URL: https://github.com/apache/flink/pull/22165 Bumps [snakeyaml](https://bitbucket.org/snakeyaml/snakeyaml) from 1.33 to 2.0. Commits

[GitHub] [flink] Aitozi commented on a diff in pull request #22158: [FLINK-25347][table] Replace deprecated TableSchema with Schema in MergeTableLikeUtil

2023-03-12 Thread via GitHub
Aitozi commented on code in PR #22158: URL: https://github.com/apache/flink/pull/22158#discussion_r1133379496 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/SqlCreateTableConverter.java: ## @@ -193,10 +179,7 @@ private CatalogTable

[jira] [Created] (FLINK-31409) Hive connector should use public interfaces for Hive dialct

2023-03-12 Thread luoyuxia (Jira)
luoyuxia created FLINK-31409: Summary: Hive connector should use public interfaces for Hive dialct Key: FLINK-31409 URL: https://issues.apache.org/jira/browse/FLINK-31409 Project: Flink Issue

[jira] [Resolved] (FLINK-30658) remove flink-sql-parser-hive dependency in table-planner

2023-03-12 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia resolved FLINK-30658. -- Resolution: Fixed > remove flink-sql-parser-hive dependency in table-planner >

[jira] [Closed] (FLINK-30659) drop flink-sql-parser-hive

2023-03-12 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia closed FLINK-30659. Fix Version/s: 1.18.0 (was: 1.17.0) Resolution: Fixed master:

[GitHub] [flink] luoyuxia merged pull request #22106: [FLINK-30659][hive] Drop flink-sql-parser-hive module

2023-03-12 Thread via GitHub
luoyuxia merged PR #22106: URL: https://github.com/apache/flink/pull/22106 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] luoyuxia commented on pull request #22106: [FLINK-30659][hive] Drop flink-sql-parser-hive module

2023-03-12 Thread via GitHub
luoyuxia commented on PR #22106: URL: https://github.com/apache/flink/pull/22106#issuecomment-146539 Merging -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink-table-store] FangYongs commented on pull request #569: [FLINK-31269] Split hive connector to each module of each version

2023-03-12 Thread via GitHub
FangYongs commented on PR #569: URL: https://github.com/apache/flink-table-store/pull/569#issuecomment-1465398573 Thanks @tsreaper Updated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] BoYiZhang commented on pull request #22090: [Flink 31170] [docs]The spelling error of the document word causes sql to fail to execute

2023-03-12 Thread via GitHub
BoYiZhang commented on PR #22090: URL: https://github.com/apache/flink/pull/22090#issuecomment-1465395588 What's wrong with this PR? @reswqa @healchow -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [flink] flinkbot commented on pull request #22164: [FLINK-30025][table][test] remove same amount of "-" and " " after no…

2023-03-12 Thread via GitHub
flinkbot commented on PR #22164: URL: https://github.com/apache/flink/pull/22164#issuecomment-1465390923 ## CI report: * 1838619bdc3585768ded050e17b8abcfdbf5811c UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] fsk119 opened a new pull request, #22164: [FLINK-30025][table][test] remove same amount of "-" and " " after no…

2023-03-12 Thread via GitHub
fsk119 opened a new pull request, #22164: URL: https://github.com/apache/flink/pull/22164 …de ids have been removed because the ids might have different length in different envs. ## What is the purpose of the change *Fix unstable tests because of the different border

[jira] [Commented] (FLINK-31403) CliClientITCase print unexpected border when printing explain results

2023-03-12 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699420#comment-17699420 ] Shengkai Fang commented on FLINK-31403: --- I think it has been fixed by the

[jira] [Commented] (FLINK-26603) [Umbrella] Decouple Hive with Flink planner

2023-03-12 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699419#comment-17699419 ] luoyuxia commented on FLINK-26603: -- [~martijnvisser] I believe in 1.18.  I do hope it can be finished

[jira] [Commented] (FLINK-31395) AbstractPartitionDiscoverer.discoverPartitions calls remove on immutable collection

2023-03-12 Thread xzw0223 (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699418#comment-17699418 ] xzw0223 commented on FLINK-31395: - [~mapohl] I think this is a test bug. >

[GitHub] [flink-ml] jiangxin369 commented on a diff in pull request #218: [FLINK-31306] Add Servable for PipelineModel

2023-03-12 Thread via GitHub
jiangxin369 commented on code in PR #218: URL: https://github.com/apache/flink-ml/pull/218#discussion_r1133364498 ## flink-ml-core/src/test/java/org/apache/flink/ml/api/PipelineTest.java: ## @@ -95,4 +109,59 @@ public void testPipeline() throws Exception { // Executes

[jira] [Assigned] (FLINK-31408) Add EXACTLY_ONCE support to upsert-kafka

2023-03-12 Thread Tzu-Li (Gordon) Tai (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai reassigned FLINK-31408: --- Assignee: Alex Sorokoumov > Add EXACTLY_ONCE support to upsert-kafka >

[jira] [Updated] (FLINK-31408) Add EXACTLY_ONCE support to upsert-kafka

2023-03-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31408: --- Labels: pull-request-available (was: ) > Add EXACTLY_ONCE support to upsert-kafka >

[GitHub] [flink-connector-kafka] boring-cyborg[bot] commented on pull request #7: [FLINK-31408] Add support for EOS delivery-guarantee in upsert-kafka

2023-03-12 Thread via GitHub
boring-cyborg[bot] commented on PR #7: URL: https://github.com/apache/flink-connector-kafka/pull/7#issuecomment-1465294234 Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) -- This is an

[GitHub] [flink-connector-kafka] Gerrrr opened a new pull request, #7: [FLINK-31408] Add support for EOS delivery-guarantee in upsert-kafka

2023-03-12 Thread via GitHub
Ge opened a new pull request, #7: URL: https://github.com/apache/flink-connector-kafka/pull/7 * add sink.delivery-guarantee and sink.transactional-id-prefix options to upsert-kafka * fix the default isolation.level in kafka connector documentation * add update upsert-kafka

[jira] [Created] (FLINK-31408) Add EXACTLY_ONCE support to upsert-kafka

2023-03-12 Thread Alex Sorokoumov (Jira)
Alex Sorokoumov created FLINK-31408: --- Summary: Add EXACTLY_ONCE support to upsert-kafka Key: FLINK-31408 URL: https://issues.apache.org/jira/browse/FLINK-31408 Project: Flink Issue Type:

[jira] [Created] (FLINK-31407) Upgrade Fabric8 version to 6.5.0

2023-03-12 Thread Gyula Fora (Jira)
Gyula Fora created FLINK-31407: -- Summary: Upgrade Fabric8 version to 6.5.0 Key: FLINK-31407 URL: https://issues.apache.org/jira/browse/FLINK-31407 Project: Flink Issue Type: Improvement

[jira] [Created] (FLINK-31406) Do not delete jobgraph on scale only last-state upgrades

2023-03-12 Thread Gyula Fora (Jira)
Gyula Fora created FLINK-31406: -- Summary: Do not delete jobgraph on scale only last-state upgrades Key: FLINK-31406 URL: https://issues.apache.org/jira/browse/FLINK-31406 Project: Flink Issue

[jira] [Closed] (FLINK-31401) testTransformationSetParallelism fails on 10 core machines

2023-03-12 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-31401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Márton Balassi closed FLINK-31401. -- Fix Version/s: 1.18.0 Resolution: Fixed 64d5f54 in master >

[jira] [Commented] (FLINK-31401) testTransformationSetParallelism fails on 10 core machines

2023-03-12 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-31401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699385#comment-17699385 ] Márton Balassi commented on FLINK-31401: Sure, thanks for the quick confirmation. >

[GitHub] [flink] mbalassi merged pull request #22157: [FLINK-31401][streaming][tests] Make parallelism assumption explicit in StreamingJobGraphGeneratorTest

2023-03-12 Thread via GitHub
mbalassi merged PR #22157: URL: https://github.com/apache/flink/pull/22157 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] mbalassi commented on pull request #22157: [FLINK-31401][streaming][tests] Make parallelism assumption explicit in StreamingJobGraphGeneratorTest

2023-03-12 Thread via GitHub
mbalassi commented on PR #22157: URL: https://github.com/apache/flink/pull/22157#issuecomment-1465271790 Sure.  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] liyubin117 commented on pull request #21521: [FLINK-30435][table] `SHOW CREATE TABLE` statement shows column comment

2023-03-12 Thread via GitHub
liyubin117 commented on PR #21521: URL: https://github.com/apache/flink/pull/21521#issuecomment-1465244925 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Closed] (FLINK-31330) Batch shuffle may deadlock for operator with priority input

2023-03-12 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo closed FLINK-31330. -- Resolution: Not A Problem After some investigation and debugging, it is finally found that the

[jira] [Comment Edited] (FLINK-31393) HsFileDataManager use an incorrect default timeout

2023-03-12 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699217#comment-17699217 ] Weijie Guo edited comment on FLINK-31393 at 3/12/23 3:02 PM: - master(1.18)

[jira] [Closed] (FLINK-31393) HsFileDataManager use an incorrect default timeout

2023-03-12 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo closed FLINK-31393. -- Resolution: Fixed > HsFileDataManager use an incorrect default timeout >

[GitHub] [flink] reswqa merged pull request #22162: [BP-1.16][FLINK-31393] Fix the bug that HsFileDataManager use an incorrect default timeout.

2023-03-12 Thread via GitHub
reswqa merged PR #22162: URL: https://github.com/apache/flink/pull/22162 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] liyubin117 commented on pull request #21521: [FLINK-30435][table] `SHOW CREATE TABLE` statement shows column comment

2023-03-12 Thread via GitHub
liyubin117 commented on PR #21521: URL: https://github.com/apache/flink/pull/21521#issuecomment-1465209883 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Closed] (FLINK-31404) Support extracting all mapping of Calc node's input references

2023-03-12 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee closed FLINK-31404. --- Resolution: Fixed fixed in master: a43a63c165ccb37cf0feb5c948943abc73c6f423 > Support extracting

[jira] [Updated] (FLINK-31404) Support extracting all mapping of Calc node's input references

2023-03-12 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee updated FLINK-31404: Fix Version/s: 1.18.0 > Support extracting all mapping of Calc node's input references >

[jira] [Assigned] (FLINK-31404) Support extracting all mapping of Calc node's input references

2023-03-12 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee reassigned FLINK-31404: --- Assignee: Jane Chan > Support extracting all mapping of Calc node's input references >

[GitHub] [flink] lincoln-lil merged pull request #22160: [FLINK-31404][table-planner] Support extracting all mapping of Calc node's input references for StreamNonDeterminisiticUpdatePlanVsitior

2023-03-12 Thread via GitHub
lincoln-lil merged PR #22160: URL: https://github.com/apache/flink/pull/22160 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] liyubin117 commented on a diff in pull request #21521: [FLINK-30435][table] `SHOW CREATE TABLE` statement shows column comment

2023-03-12 Thread via GitHub
liyubin117 commented on code in PR #21521: URL: https://github.com/apache/flink/pull/21521#discussion_r1133253512 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/ShowCreateUtil.java: ## @@ -82,7 +82,11 @@ static String

[GitHub] [flink] flinkbot commented on pull request #22163: [FLINK-31378] fix the Overview markdown file

2023-03-12 Thread via GitHub
flinkbot commented on PR #22163: URL: https://github.com/apache/flink/pull/22163#issuecomment-1465189973 ## CI report: * 0d25f316cd9e6e715bfa149d21147b350105190e UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-31378) Documentation fails to build due to lack of package

2023-03-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31378: --- Labels: pull-request-available (was: ) > Documentation fails to build due to lack of

[GitHub] [flink] WencongLiu opened a new pull request, #22163: [FLINK-31378] fix the Overview markdown file

2023-03-12 Thread via GitHub
WencongLiu opened a new pull request, #22163: URL: https://github.com/apache/flink/pull/22163 ## What is the purpose of the change *fix the Overview markdown file* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [flink] rkhachatryan commented on a diff in pull request #22153: [FLINK-31317] Introduce JobResourceRequirements and JobVertexResourceRequirements data structures.

2023-03-12 Thread via GitHub
rkhachatryan commented on code in PR #22153: URL: https://github.com/apache/flink/pull/22153#discussion_r1133248430 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobResourceRequirements.java: ## @@ -0,0 +1,204 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink] rkhachatryan commented on a diff in pull request #22153: [FLINK-31317] Introduce JobResourceRequirements and JobVertexResourceRequirements data structures.

2023-03-12 Thread via GitHub
rkhachatryan commented on code in PR #22153: URL: https://github.com/apache/flink/pull/22153#discussion_r1133248204 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobResourceRequirements.java: ## @@ -0,0 +1,204 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #218: [FLINK-31306] Add Servable for PipelineModel

2023-03-12 Thread via GitHub
lindong28 commented on code in PR #218: URL: https://github.com/apache/flink-ml/pull/218#discussion_r1133236486 ## flink-ml-core/src/test/java/org/apache/flink/ml/api/PipelineTest.java: ## @@ -95,4 +109,59 @@ public void testPipeline() throws Exception { // Executes

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #218: [FLINK-31306] Add Servable for PipelineModel

2023-03-12 Thread via GitHub
lindong28 commented on code in PR #218: URL: https://github.com/apache/flink-ml/pull/218#discussion_r1133237792 ## flink-ml-core/src/test/java/org/apache/flink/ml/api/PipelineTest.java: ## @@ -95,4 +109,59 @@ public void testPipeline() throws Exception { // Executes

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #218: [FLINK-31306] Add Servable for PipelineModel

2023-03-12 Thread via GitHub
lindong28 commented on code in PR #218: URL: https://github.com/apache/flink-ml/pull/218#discussion_r1133237792 ## flink-ml-core/src/test/java/org/apache/flink/ml/api/PipelineTest.java: ## @@ -95,4 +109,59 @@ public void testPipeline() throws Exception { // Executes

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #218: [FLINK-31306] Add Servable for PipelineModel

2023-03-12 Thread via GitHub
lindong28 commented on code in PR #218: URL: https://github.com/apache/flink-ml/pull/218#discussion_r1133236486 ## flink-ml-core/src/test/java/org/apache/flink/ml/api/PipelineTest.java: ## @@ -95,4 +109,59 @@ public void testPipeline() throws Exception { // Executes

[GitHub] [flink-ml] jiangxin369 commented on a diff in pull request #218: [FLINK-31306] Add Servable for PipelineModel

2023-03-12 Thread via GitHub
jiangxin369 commented on code in PR #218: URL: https://github.com/apache/flink-ml/pull/218#discussion_r1133223131 ## flink-ml-core/src/test/java/org/apache/flink/ml/api/PipelineTest.java: ## @@ -95,4 +109,59 @@ public void testPipeline() throws Exception { // Executes

[GitHub] [flink-ml] jiangxin369 commented on a diff in pull request #218: [FLINK-31306] Add Servable for PipelineModel

2023-03-12 Thread via GitHub
jiangxin369 commented on code in PR #218: URL: https://github.com/apache/flink-ml/pull/218#discussion_r1133222401 ## flink-ml-core/src/test/java/org/apache/flink/ml/api/PipelineTest.java: ## @@ -95,4 +109,59 @@ public void testPipeline() throws Exception { // Executes

[GitHub] [flink-ml] jiangxin369 commented on a diff in pull request #218: [FLINK-31306] Add Servable for PipelineModel

2023-03-12 Thread via GitHub
jiangxin369 commented on code in PR #218: URL: https://github.com/apache/flink-ml/pull/218#discussion_r1133223131 ## flink-ml-core/src/test/java/org/apache/flink/ml/api/PipelineTest.java: ## @@ -95,4 +109,59 @@ public void testPipeline() throws Exception { // Executes

[GitHub] [flink-ml] jiangxin369 commented on a diff in pull request #218: [FLINK-31306] Add Servable for PipelineModel

2023-03-12 Thread via GitHub
jiangxin369 commented on code in PR #218: URL: https://github.com/apache/flink-ml/pull/218#discussion_r1133222401 ## flink-ml-core/src/test/java/org/apache/flink/ml/api/PipelineTest.java: ## @@ -95,4 +109,59 @@ public void testPipeline() throws Exception { // Executes

[jira] [Assigned] (FLINK-30959) Improve the documentation of UNIX_TIMESTAMP for different argument format

2023-03-12 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu reassigned FLINK-30959: -- Assignee: ruanhang1993 > Improve the documentation of UNIX_TIMESTAMP for different argument

[jira] [Assigned] (FLINK-30959) Improve the documentation of UNIX_TIMESTAMP for different argument format

2023-03-12 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu reassigned FLINK-30959: -- Assignee: Hang Ruan (was: ruanhang1993) > Improve the documentation of UNIX_TIMESTAMP for

[GitHub] [flink] dmvk commented on a diff in pull request #22153: [FLINK-31317] Introduce JobResourceRequirements and JobVertexResourceRequirements data structures.

2023-03-12 Thread via GitHub
dmvk commented on code in PR #22153: URL: https://github.com/apache/flink/pull/22153#discussion_r1133209170 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobResourceRequirements.java: ## @@ -0,0 +1,204 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [flink] dmvk commented on a diff in pull request #22153: [FLINK-31317] Introduce JobResourceRequirements and JobVertexResourceRequirements data structures.

2023-03-12 Thread via GitHub
dmvk commented on code in PR #22153: URL: https://github.com/apache/flink/pull/22153#discussion_r1133209170 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobResourceRequirements.java: ## @@ -0,0 +1,204 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [flink] dmvk commented on a diff in pull request #22153: [FLINK-31317] Introduce JobResourceRequirements and JobVertexResourceRequirements data structures.

2023-03-12 Thread via GitHub
dmvk commented on code in PR #22153: URL: https://github.com/apache/flink/pull/22153#discussion_r1133208929 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobResourceRequirements.java: ## @@ -0,0 +1,204 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [flink] dmvk commented on a diff in pull request #22153: [FLINK-31317] Introduce JobResourceRequirements and JobVertexResourceRequirements data structures.

2023-03-12 Thread via GitHub
dmvk commented on code in PR #22153: URL: https://github.com/apache/flink/pull/22153#discussion_r1133207805 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobResourceRequirements.java: ## @@ -0,0 +1,204 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Commented] (FLINK-30959) Improve the documentation of UNIX_TIMESTAMP for different argument format

2023-03-12 Thread Hang Ruan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699319#comment-17699319 ] Hang Ruan commented on FLINK-30959: --- Hi, all, I would like to help to improve the document. Please