[GitHub] [flink] luoyuxia commented on a diff in pull request #21522: [FLINK-29585][hive] Migrate TableSchema to Schema for Hive connector

2023-03-15 Thread via GitHub
luoyuxia commented on code in PR #21522: URL: https://github.com/apache/flink/pull/21522#discussion_r1138195773 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveLookupTableSource.java: ## @@ -258,8 +256,12 @@ private TableFunction getLo

[jira] [Assigned] (FLINK-31480) Fix Typo in YarnClusterDescriptor

2023-03-15 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo reassigned FLINK-31480: -- Assignee: Shilun Fan > Fix Typo in YarnClusterDescriptor > -

[jira] [Comment Edited] (FLINK-30863) Register local recovery files of changelog before notifyCheckpointComplete()

2023-03-15 Thread Yanfei Lei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17701000#comment-17701000 ] Yanfei Lei edited comment on FLINK-30863 at 3/16/23 6:38 AM: -

[GitHub] [flink-table-store] zhangjun0x01 commented on a diff in pull request #603: [FLINK-31459]add UPDATE COLUMN POSITION for flink table store

2023-03-15 Thread via GitHub
zhangjun0x01 commented on code in PR #603: URL: https://github.com/apache/flink-table-store/pull/603#discussion_r1137247002 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/schema/SchemaManager.java: ## @@ -310,6 +311,27 @@ public TableSchema commitChang

[GitHub] [flink] flinkbot commented on pull request #22190: [FLINK-31478][python] Fix ds.execute_and_collect to support nested tuple

2023-03-15 Thread via GitHub
flinkbot commented on PR #22190: URL: https://github.com/apache/flink/pull/22190#issuecomment-1471400741 ## CI report: * 58d08db1cc4de4450c0979b9d54e89f27079a415 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-30863) Register local recovery files of changelog before notifyCheckpointComplete()

2023-03-15 Thread Yanfei Lei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17701000#comment-17701000 ] Yanfei Lei commented on FLINK-30863: [~assassinj] Thanks for your investigation and

[GitHub] [flink-table-store] zhangjun0x01 commented on a diff in pull request #584: [FLINK-31338] support infer parallelism for flink table store

2023-03-15 Thread via GitHub
zhangjun0x01 commented on code in PR #584: URL: https://github.com/apache/flink-table-store/pull/584#discussion_r1138183538 ## flink-table-store-flink/flink-table-store-flink-common/src/main/java/org/apache/flink/table/store/connector/FlinkConnectorOptions.java: ## @@ -82,6 +82,

[jira] [Updated] (FLINK-31478) TypeError: a bytes-like object is required, not 'JavaList' is thrown when ds.execute_and_collect() is called on a KeyedStream

2023-03-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31478: --- Labels: pull-request-available (was: ) > TypeError: a bytes-like object is required, not 'J

[GitHub] [flink] dianfu opened a new pull request, #22190: [FLINK-31478][python] Fix ds.execute_and_collect to support nested tuple

2023-03-15 Thread via GitHub
dianfu opened a new pull request, #22190: URL: https://github.com/apache/flink/pull/22190 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on

[jira] [Updated] (FLINK-31483) Implement Split Deletion Support in Flink Kafka Connector

2023-03-15 Thread Ruibin Xing (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ruibin Xing updated FLINK-31483: Description: Currently, the Flink Kafka Connector does not support split deletion and is left as

[jira] [Commented] (FLINK-30490) Deleted topic from KafkaSource is still included in subsequent restart from savepoint

2023-03-15 Thread Ruibin Xing (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17700992#comment-17700992 ] Ruibin Xing commented on FLINK-30490: - [~hilmialf] I created a new ticket for the pr

[jira] [Created] (FLINK-31483) Implement Split Deletion Support in Flink Kafka Connector

2023-03-15 Thread Ruibin Xing (Jira)
Ruibin Xing created FLINK-31483: --- Summary: Implement Split Deletion Support in Flink Kafka Connector Key: FLINK-31483 URL: https://issues.apache.org/jira/browse/FLINK-31483 Project: Flink Issue

[jira] [Assigned] (FLINK-31477) NestedLoopJoinTest.testLeftOuterJoinWithFilter failed on azure

2023-03-15 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo reassigned FLINK-31477: -- Assignee: Yunhong Zheng > NestedLoopJoinTest.testLeftOuterJoinWithFilter failed on azure > -

[GitHub] [flink-web] leonardBang commented on a diff in pull request #618: Announcement blogpost for the 1.17 release

2023-03-15 Thread via GitHub
leonardBang commented on code in PR #618: URL: https://github.com/apache/flink-web/pull/618#discussion_r1138168840 ## docs/content/posts/2023-03-09-release-1.17.0.md: ## @@ -0,0 +1,487 @@ +--- +authors: +- LeonardXu: + name: "Leonard Xu" + twitter: Leonardxbj +date: "2023-03-0

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #608: [FLINK-31467] Support time travel for Spark 3.3

2023-03-15 Thread via GitHub
JingsongLi commented on code in PR #608: URL: https://github.com/apache/flink-table-store/pull/608#discussion_r1138155760 ## flink-table-store-spark/flink-table-store-spark-common/src/main/java/org/apache/flink/table/store/spark/SparkCatalog.java: ## @@ -18,354 +18,7 @@ packa

[jira] [Created] (FLINK-31482) support count jobmanager-failed failover times

2023-03-15 Thread Fei Feng (Jira)
Fei Feng created FLINK-31482: Summary: support count jobmanager-failed failover times Key: FLINK-31482 URL: https://issues.apache.org/jira/browse/FLINK-31482 Project: Flink Issue Type: Improvemen

[GitHub] [flink-table-store] zhangjun0x01 commented on a diff in pull request #584: [FLINK-31338] support infer parallelism for flink table store

2023-03-15 Thread via GitHub
zhangjun0x01 commented on code in PR #584: URL: https://github.com/apache/flink-table-store/pull/584#discussion_r1138150614 ## flink-table-store-flink/flink-table-store-flink-common/src/main/java/org/apache/flink/table/store/connector/FlinkConnectorOptions.java: ## @@ -82,6 +82,

[jira] [Comment Edited] (FLINK-26945) Add DATE_SUB supported in SQL & Table API

2023-03-15 Thread jackylau (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17700971#comment-17700971 ] jackylau edited comment on FLINK-26945 at 3/16/23 5:34 AM: --- hi

[jira] [Comment Edited] (FLINK-26945) Add DATE_SUB supported in SQL & Table API

2023-03-15 Thread jackylau (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17700971#comment-17700971 ] jackylau edited comment on FLINK-26945 at 3/16/23 4:34 AM: --- hi

[GitHub] [flink] felixzh2020 commented on pull request #22118: [FLINK-31335][sql-gateway] When submit job to yarn, support kerberos

2023-03-15 Thread via GitHub
felixzh2020 commented on PR #22118: URL: https://github.com/apache/flink/pull/22118#issuecomment-1471291964 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [flink] felixzh2020 commented on a diff in pull request #22118: [FLINK-31335][sql-gateway] When submit job to yarn, support kerberos

2023-03-15 Thread via GitHub
felixzh2020 commented on code in PR #22118: URL: https://github.com/apache/flink/pull/22118#discussion_r1138105578 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/SqlGateway.java: ## @@ -109,16 +113,20 @@ static void startSqlGateway(PrintStream stre

[jira] [Commented] (FLINK-26945) Add DATE_SUB supported in SQL & Table API

2023-03-15 Thread jackylau (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17700971#comment-17700971 ] jackylau commented on FLINK-26945: -- hi [~jark] [~twalthr] , when i implement the date_s

[GitHub] [flink] TanYuxin-tyx commented on a diff in pull request #22161: [FLINK-31405] Refactor tests to git rid of timeout of CompletableFuture assertions.

2023-03-15 Thread via GitHub
TanYuxin-tyx commented on code in PR #22161: URL: https://github.com/apache/flink/pull/22161#discussion_r1138090110 ## flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveSchedulerTest.java: ## @@ -1311,11 +1312,10 @@ public void testTriggerSavepointF

[jira] [Created] (FLINK-31481) Add filter support for ShowDatabases

2023-03-15 Thread Ran Tao (Jira)
Ran Tao created FLINK-31481: --- Summary: Add filter support for ShowDatabases Key: FLINK-31481 URL: https://issues.apache.org/jira/browse/FLINK-31481 Project: Flink Issue Type: Sub-task Com

[jira] [Closed] (FLINK-31473) Add new show operations docs

2023-03-15 Thread Ran Tao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ran Tao closed FLINK-31473. --- Resolution: Invalid > Add new show operations docs > > > Key: F

[GitHub] [flink] flinkbot commented on pull request #22189: [FLINK-31480] Fix Typo in YarnClusterDescriptor.

2023-03-15 Thread via GitHub
flinkbot commented on PR #22189: URL: https://github.com/apache/flink/pull/22189#issuecomment-1471286506 ## CI report: * a2ee925f508ed1f47a7cfc7357889f7c6f64d025 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-31464) Move SqlNode conversion logic out from SqlToOperationConverter

2023-03-15 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17700968#comment-17700968 ] Jark Wu commented on FLINK-31464: - I would suggest using Timo's approach proposed in FLI

[jira] [Updated] (FLINK-31480) Fix Typo in YarnClusterDescriptor

2023-03-15 Thread Shilun Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shilun Fan updated FLINK-31480: --- Issue Type: Improvement (was: Bug) > Fix Typo in YarnClusterDescriptor > --

[jira] [Updated] (FLINK-31480) Fix Typo in YarnClusterDescriptor

2023-03-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31480: --- Labels: pull-request-available (was: ) > Fix Typo in YarnClusterDescriptor > --

[GitHub] [flink] slfan1989 opened a new pull request, #22189: [FLINK-31480] Fix Typo in YarnClusterDescriptor.

2023-03-15 Thread via GitHub
slfan1989 opened a new pull request, #22189: URL: https://github.com/apache/flink/pull/22189 ## What is the purpose of the change JIRA: FLINK-31480. Fix Typo in YarnClusterDescriptor. ## Brief change log Fix Typo. ## Verifying this change Man

[GitHub] [flink-connector-aws] Samrat002 commented on a diff in pull request #47: [FLINK-30481][FLIP-277] GlueCatalog Implementation

2023-03-15 Thread via GitHub
Samrat002 commented on code in PR #47: URL: https://github.com/apache/flink-connector-aws/pull/47#discussion_r1138096146 ## flink-catalog-aws-glue/src/main/java/org/apache/flink/table/catalog/glue/GlueCatalog.java: ## @@ -0,0 +1,1029 @@ +/* + * Licensed to the Apache Software F

[GitHub] [flink-table-store] yuzelin commented on a diff in pull request #608: [FLINK-31467] Support time travel for Spark 3.3

2023-03-15 Thread via GitHub
yuzelin commented on code in PR #608: URL: https://github.com/apache/flink-table-store/pull/608#discussion_r1138095443 ## flink-table-store-spark/flink-table-store-spark-common/src/main/java/org/apache/flink/table/store/spark/SparkCatalog.java: ## @@ -18,354 +18,7 @@ package

[jira] [Created] (FLINK-31480) Fix Typo in YarnClusterDescriptor

2023-03-15 Thread Shilun Fan (Jira)
Shilun Fan created FLINK-31480: -- Summary: Fix Typo in YarnClusterDescriptor Key: FLINK-31480 URL: https://issues.apache.org/jira/browse/FLINK-31480 Project: Flink Issue Type: Bug Compo

[GitHub] [flink] reswqa commented on pull request #22176: [FLINK-31441][runtime]FineGrainedSlotManager support evenly slot selection.

2023-03-15 Thread via GitHub
reswqa commented on PR #22176: URL: https://github.com/apache/flink/pull/22176#issuecomment-1471277022 Thanks @huwh for the update, I only left some comments about testing, please take a look again. -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [flink] reswqa commented on a diff in pull request #22176: [FLINK-31441][runtime]FineGrainedSlotManager support evenly slot selection.

2023-03-15 Thread via GitHub
reswqa commented on code in PR #22176: URL: https://github.com/apache/flink/pull/22176#discussion_r1138092444 ## flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/LeastUtilizationSlotMatchingStrategy.java: ## @@ -79,4 +94,19 @@ private static doubl

[GitHub] [flink] wuchong commented on a diff in pull request #22175: [FLINK-31450][table] Introduce ExecutableOperation for operations to execute

2023-03-15 Thread via GitHub
wuchong commented on code in PR #22175: URL: https://github.com/apache/flink/pull/22175#discussion_r1138092220 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/ExecutableOperation.java: ## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [flink] wuchong commented on a diff in pull request #22175: [FLINK-31450][table] Introduce ExecutableOperation for operations to execute

2023-03-15 Thread via GitHub
wuchong commented on code in PR #22175: URL: https://github.com/apache/flink/pull/22175#discussion_r1138090941 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/UseModulesOperation.java: ## @@ -37,4 +41,16 @@ public List getModuleNames() {

[jira] [Updated] (FLINK-31380) Add filter support for ShowCatalogs

2023-03-15 Thread Ran Tao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ran Tao updated FLINK-31380: Summary: Add filter support for ShowCatalogs (was: Add filter support for ShowCatalog) > Add filter supp

[jira] [Updated] (FLINK-31380) Add filter support for ShowCatalogs

2023-03-15 Thread Ran Tao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ran Tao updated FLINK-31380: Description: As FLIP discussed. We will support new syntax for some show operations. To avoid bloat, this

[jira] [Comment Edited] (FLINK-31380) Add filter support for ShowCatalog and ShowDatabases

2023-03-15 Thread Ran Tao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17700498#comment-17700498 ] Ran Tao edited comment on FLINK-31380 at 3/16/23 3:57 AM: -- show

[jira] [Updated] (FLINK-31380) Add filter support for ShowCatalog

2023-03-15 Thread Ran Tao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ran Tao updated FLINK-31380: Summary: Add filter support for ShowCatalog (was: Add filter support for ShowCatalog and ShowDatabases)

[GitHub] [flink] flinkbot commented on pull request #22188: [FLINK-31477][table-planner] Fix NestedLoopJoinTest.testLeftOuterJoin failed with unexpected plan after cherry-pick FLINK-31273 from release

2023-03-15 Thread via GitHub
flinkbot commented on PR #22188: URL: https://github.com/apache/flink/pull/22188#issuecomment-1471261639 ## CI report: * eb94718c4750b3e40e7f299c043d2ec7d77fd6ef UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-31477) NestedLoopJoinTest.testLeftOuterJoinWithFilter failed on azure

2023-03-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31477: --- Labels: pull-request-available (was: ) > NestedLoopJoinTest.testLeftOuterJoinWithFilter fai

[GitHub] [flink] swuferhong opened a new pull request, #22188: [FLINK-31477][table-planner] Fix NestedLoopJoinTest.testLeftOuterJoin failed with unexpected plan after cherry-pick FLINK-31273 from rele

2023-03-15 Thread via GitHub
swuferhong opened a new pull request, #22188: URL: https://github.com/apache/flink/pull/22188 ## What is the purpose of the change This pr is aims to fix NestedLoopJoinTest.testLeftOuterJoin failed in Flink-1.16.2 with unexpected plan after cherry-pick FLINK-31273 from

[GitHub] [flink] reswqa commented on a diff in pull request #22176: [FLINK-31441][runtime]FineGrainedSlotManager support evenly slot selection.

2023-03-15 Thread via GitHub
reswqa commented on code in PR #22176: URL: https://github.com/apache/flink/pull/22176#discussion_r1138084307 ## flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/slotmanager/LeastUtilizationSlotMatchingStrategyTest.java: ## @@ -71,8 +69,63 @@ public void fin

[GitHub] [flink] felixzh2020 commented on a diff in pull request #22119: [FLINK-31321][Deployment/YARN] Yarn-session mode, securityConfiguration supports dynamic configuration

2023-03-15 Thread via GitHub
felixzh2020 commented on code in PR #22119: URL: https://github.com/apache/flink/pull/22119#discussion_r1138083328 ## flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java: ## @@ -853,6 +855,9 @@ public static void main(final String[] args) {

[GitHub] [flink] reswqa commented on a diff in pull request #22176: [FLINK-31441][runtime]FineGrainedSlotManager support evenly slot selection.

2023-03-15 Thread via GitHub
reswqa commented on code in PR #22176: URL: https://github.com/apache/flink/pull/22176#discussion_r1138082978 ## flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/slotmanager/LeastUtilizationSlotMatchingStrategyTest.java: ## @@ -71,8 +69,63 @@ public void fin

[jira] [Commented] (FLINK-31457) Support waiting for required resources in DefaultScheduler during job restart

2023-03-15 Thread Weihua Hu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17700961#comment-17700961 ] Weihua Hu commented on FLINK-31457: --- [~a.pilipenko] IIUC, this issue is caused by "slo

[GitHub] [flink] reswqa commented on a diff in pull request #22176: [FLINK-31441][runtime]FineGrainedSlotManager support evenly slot selection.

2023-03-15 Thread via GitHub
reswqa commented on code in PR #22176: URL: https://github.com/apache/flink/pull/22176#discussion_r1138082853 ## flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/slotmanager/LeastUtilizationSlotMatchingStrategyTest.java: ## @@ -71,8 +69,63 @@ public void fin

[GitHub] [flink] reswqa commented on a diff in pull request #22176: [FLINK-31441][runtime]FineGrainedSlotManager support evenly slot selection.

2023-03-15 Thread via GitHub
reswqa commented on code in PR #22176: URL: https://github.com/apache/flink/pull/22176#discussion_r1138082595 ## flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/slotmanager/LeastUtilizationSlotMatchingStrategyTest.java: ## @@ -71,8 +69,63 @@ public void fin

[GitHub] [flink] lindong28 commented on a diff in pull request #22146: [FLINK-31157][release] Add release note for version 1.17

2023-03-15 Thread via GitHub
lindong28 commented on code in PR #22146: URL: https://github.com/apache/flink/pull/22146#discussion_r1138082345 ## docs/content.zh/release-notes/flink-1.17.md: ## @@ -0,0 +1,203 @@ +--- +title: "Release Notes - Flink 1.17" +--- + + +# Release notes - Flink 1.17 + +These release

[GitHub] [flink] reswqa commented on a diff in pull request #22176: [FLINK-31441][runtime]FineGrainedSlotManager support evenly slot selection.

2023-03-15 Thread via GitHub
reswqa commented on code in PR #22176: URL: https://github.com/apache/flink/pull/22176#discussion_r1138082305 ## flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/slotmanager/LeastUtilizationSlotMatchingStrategyTest.java: ## @@ -24,17 +24,15 @@ import org.a

[GitHub] [flink] reswqa commented on a diff in pull request #22176: [FLINK-31441][runtime]FineGrainedSlotManager support evenly slot selection.

2023-03-15 Thread via GitHub
reswqa commented on code in PR #22176: URL: https://github.com/apache/flink/pull/22176#discussion_r1138082037 ## flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/slotmanager/LeastUtilizationSlotMatchingStrategyTest.java: ## @@ -71,8 +69,63 @@ public void fin

[GitHub] [flink] reswqa commented on a diff in pull request #22176: [FLINK-31441][runtime]FineGrainedSlotManager support evenly slot selection.

2023-03-15 Thread via GitHub
reswqa commented on code in PR #22176: URL: https://github.com/apache/flink/pull/22176#discussion_r1138081798 ## flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/slotmanager/LeastUtilizationSlotMatchingStrategyTest.java: ## @@ -71,8 +69,63 @@ public void fin

[GitHub] [flink] code-dm commented on a diff in pull request #22118: [FLINK-31335][sql-gateway] When submit job to yarn, support kerberos

2023-03-15 Thread via GitHub
code-dm commented on code in PR #22118: URL: https://github.com/apache/flink/pull/22118#discussion_r1138081208 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/SqlGateway.java: ## @@ -109,16 +113,20 @@ static void startSqlGateway(PrintStream stream,

[jira] [Commented] (FLINK-30490) Deleted topic from KafkaSource is still included in subsequent restart from savepoint

2023-03-15 Thread Hilmi Al Fatih (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17700951#comment-17700951 ] Hilmi Al Fatih commented on FLINK-30490: Hi [~ruibin]. Thanks for reply. I wonde

[jira] [Created] (FLINK-31479) Close blocking iterators in tests

2023-03-15 Thread Guojun Li (Jira)
Guojun Li created FLINK-31479: - Summary: Close blocking iterators in tests Key: FLINK-31479 URL: https://issues.apache.org/jira/browse/FLINK-31479 Project: Flink Issue Type: Bug Compone

[jira] [Comment Edited] (FLINK-30490) Deleted topic from KafkaSource is still included in subsequent restart from savepoint

2023-03-15 Thread Ruibin Xing (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17700942#comment-17700942 ] Ruibin Xing edited comment on FLINK-30490 at 3/16/23 3:05 AM:

[jira] [Commented] (FLINK-30490) Deleted topic from KafkaSource is still included in subsequent restart from savepoint

2023-03-15 Thread Ruibin Xing (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17700942#comment-17700942 ] Ruibin Xing commented on FLINK-30490: - hi, we are encountering the same issue and ar

[GitHub] [flink-web] PatrickRen commented on a diff in pull request #618: Announcement blogpost for the 1.17 release

2023-03-15 Thread via GitHub
PatrickRen commented on code in PR #618: URL: https://github.com/apache/flink-web/pull/618#discussion_r1138028192 ## docs/content/posts/2023-03-09-release-1.17.0.md: ## @@ -0,0 +1,487 @@ +--- +authors: +- LeonardXu: + name: "Leonard Xu" + twitter: Leonardxbj +date: "2023-03-09

[GitHub] [flink] luoyuxia commented on pull request #21645: [FLINK-30556] Improve the logic for enumerating splits for Hive source to avoid potential OOM

2023-03-15 Thread via GitHub
luoyuxia commented on PR #21645: URL: https://github.com/apache/flink/pull/21645#issuecomment-1471204585 Here, I would like to shard my idea for it. First of all, we can pass a iterator to `SimpleSplitAssigner`, then in method `SimpleSplitAssigner#getNext`, we advance the iterator and the

[GitHub] [flink] PatrickRen commented on a diff in pull request #22146: [FLINK-31157][release] Add release note for version 1.17

2023-03-15 Thread via GitHub
PatrickRen commented on code in PR #22146: URL: https://github.com/apache/flink/pull/22146#discussion_r1138025355 ## docs/content.zh/release-notes/flink-1.17.md: ## @@ -0,0 +1,203 @@ +--- +title: "Release Notes - Flink 1.17" +--- + + +# Release notes - Flink 1.17 + +These releas

[jira] [Updated] (FLINK-31478) TypeError: a bytes-like object is required, not 'JavaList' is thrown when ds.execute_and_collect() is called on a KeyedStream

2023-03-15 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu updated FLINK-31478: Description: {code} # Li

[jira] [Created] (FLINK-31478) TypeError: a bytes-like object is required, not 'JavaList' is thrown when ds.execute_and_collect() is called on a KeyedStream

2023-03-15 Thread Dian Fu (Jira)
Dian Fu created FLINK-31478: --- Summary: TypeError: a bytes-like object is required, not 'JavaList' is thrown when ds.execute_and_collect() is called on a KeyedStream Key: FLINK-31478 URL: https://issues.apache.org/jira/b

[GitHub] [flink] luoyuxia commented on a diff in pull request #21645: [FLINK-30556] Improve the logic for enumerating splits for Hive source to avoid potential OOM

2023-03-15 Thread via GitHub
luoyuxia commented on code in PR #21645: URL: https://github.com/apache/flink/pull/21645#discussion_r1138014049 ## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/src/assigners/LocalityAwareSplitAssigner.java: ## @@ -69,9 +70,10 @@ public cla

[GitHub] [flink-ml] jiangxin369 commented on pull request #219: [FLINK-31422] Add Servable for Logistic Regression Model

2023-03-15 Thread via GitHub
jiangxin369 commented on PR #219: URL: https://github.com/apache/flink-ml/pull/219#issuecomment-1471180452 @lindong28 The PR is updated, could you have another look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [flink-table-store] yuzelin commented on a diff in pull request #608: [FLINK-31467] Support time travel for Spark 3.3

2023-03-15 Thread via GitHub
yuzelin commented on code in PR #608: URL: https://github.com/apache/flink-table-store/pull/608#discussion_r1138005883 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/table/AbstractFileStoreTable.java: ## @@ -179,4 +188,25 @@ public TableCommitImpl newCommit

[jira] [Commented] (FLINK-31472) AsyncSinkWriterThrottlingTest failed with Illegal mailbox thread

2023-03-15 Thread Ran Tao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17700929#comment-17700929 ] Ran Tao commented on FLINK-31472: - Yes. I've found this failure to occur occasionally, n

[jira] [Created] (FLINK-31477) NestedLoopJoinTest.testLeftOuterJoinWithFilter failed on azure

2023-03-15 Thread Leonard Xu (Jira)
Leonard Xu created FLINK-31477: -- Summary: NestedLoopJoinTest.testLeftOuterJoinWithFilter failed on azure Key: FLINK-31477 URL: https://issues.apache.org/jira/browse/FLINK-31477 Project: Flink

[GitHub] [flink-connector-pulsar] nlu90 commented on a diff in pull request #35: [FLINK-31427][Table] Initial Catalog implementation with a new config model and schema conversion.

2023-03-15 Thread via GitHub
nlu90 commented on code in PR #35: URL: https://github.com/apache/flink-connector-pulsar/pull/35#discussion_r1137779253 ## flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/table/catalog/PulsarCatalog.java: ## @@ -0,0 +1,522 @@ +/* + * Licensed to the Apach

[GitHub] [flink] rkhachatryan commented on a diff in pull request #22169: [FLINK-31399] AdaptiveScheduler is able to handle changes in job resource requirements.

2023-03-15 Thread via GitHub
rkhachatryan commented on code in PR #22169: URL: https://github.com/apache/flink/pull/22169#discussion_r1137480959 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SchedulerNG.java: ## @@ -185,4 +187,28 @@ void deliverOperatorEventToCoordinator( */ C

[GitHub] [flink] pgaref commented on a diff in pull request #22153: [FLINK-31317] Introduce JobResourceRequirements and JobVertexResourceRequirements data structures.

2023-03-15 Thread via GitHub
pgaref commented on code in PR #22153: URL: https://github.com/apache/flink/pull/22153#discussion_r1137472453 ## flink-core/src/main/java/org/apache/flink/util/InstantiationUtil.java: ## @@ -466,6 +468,7 @@ public static String checkForInstantiationError(Class clazz) {

[GitHub] [flink] rkhachatryan commented on a diff in pull request #22169: [FLINK-31399] AdaptiveScheduler is able to handle changes in job resource requirements.

2023-03-15 Thread via GitHub
rkhachatryan commented on code in PR #22169: URL: https://github.com/apache/flink/pull/22169#discussion_r1137469695 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveScheduler.java: ## @@ -730,15 +748,49 @@ public CompletableFuture deliverCoordi

[GitHub] [flink] rkhachatryan commented on a diff in pull request #22169: [FLINK-31399] AdaptiveScheduler is able to handle changes in job resource requirements.

2023-03-15 Thread via GitHub
rkhachatryan commented on code in PR #22169: URL: https://github.com/apache/flink/pull/22169#discussion_r1137468692 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveScheduler.java: ## @@ -730,15 +748,49 @@ public CompletableFuture deliverCoordi

[GitHub] [flink] snuyanzin commented on pull request #21847: [FLINK-30896][table] Reduce usage of CatalogViewImpl in table-planner

2023-03-15 Thread via GitHub
snuyanzin commented on PR #21847: URL: https://github.com/apache/flink/pull/21847#issuecomment-1470416556 Sorry, seems I missed your comment. Thanks for taking a look. >BTW, do we plan to remove the CatalogViewImpl after all the module do not rely on this ? I would vote

[GitHub] [flink] dmvk commented on a diff in pull request #22169: [FLINK-31399] AdaptiveScheduler is able to handle changes in job resource requirements.

2023-03-15 Thread via GitHub
dmvk commented on code in PR #22169: URL: https://github.com/apache/flink/pull/22169#discussion_r1137422867 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SchedulerNG.java: ## @@ -185,4 +187,28 @@ void deliverOperatorEventToCoordinator( */ Completab

[GitHub] [flink] dmvk commented on a diff in pull request #22169: [FLINK-31399] AdaptiveScheduler is able to handle changes in job resource requirements.

2023-03-15 Thread via GitHub
dmvk commented on code in PR #22169: URL: https://github.com/apache/flink/pull/22169#discussion_r1137415230 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultVertexParallelismStore.java: ## @@ -18,14 +18,51 @@ package org.apache.flink.runtime.scheduler;

[GitHub] [flink] mas-chen commented on a diff in pull request #22150: [FLINK-31305] Propagate producer exceptions outside of mailbox execut…

2023-03-15 Thread via GitHub
mas-chen commented on code in PR #22150: URL: https://github.com/apache/flink/pull/22150#discussion_r1137413489 ## flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaWriter.java: ## @@ -397,36 +409,57 @@ private void registerMetricSyn

[GitHub] [flink] mas-chen commented on a diff in pull request #22150: [FLINK-31305] Propagate producer exceptions outside of mailbox execut…

2023-03-15 Thread via GitHub
mas-chen commented on code in PR #22150: URL: https://github.com/apache/flink/pull/22150#discussion_r1137413902 ## flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaWriter.java: ## @@ -241,6 +246,8 @@ public void close() throws Excep

[GitHub] [flink] dmvk commented on a diff in pull request #22169: [FLINK-31399] AdaptiveScheduler is able to handle changes in job resource requirements.

2023-03-15 Thread via GitHub
dmvk commented on code in PR #22169: URL: https://github.com/apache/flink/pull/22169#discussion_r1137411839 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveScheduler.java: ## @@ -1255,4 +1268,17 @@ T transitionToState(StateFactory targetState

[GitHub] [flink] dmvk commented on a diff in pull request #22169: [FLINK-31399] AdaptiveScheduler is able to handle changes in job resource requirements.

2023-03-15 Thread via GitHub
dmvk commented on code in PR #22169: URL: https://github.com/apache/flink/pull/22169#discussion_r1137408672 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveScheduler.java: ## @@ -730,15 +748,49 @@ public CompletableFuture deliverCoordinationRe

[jira] [Created] (FLINK-31476) AdaptiveScheduler should take lower bound parallelism settings into account

2023-03-15 Thread Jira
David Morávek created FLINK-31476: - Summary: AdaptiveScheduler should take lower bound parallelism settings into account Key: FLINK-31476 URL: https://issues.apache.org/jira/browse/FLINK-31476 Project

[GitHub] [flink-web] dannycranmer merged pull request #611: Flink 1.15.4

2023-03-15 Thread via GitHub
dannycranmer merged PR #611: URL: https://github.com/apache/flink-web/pull/611 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.

[GitHub] [flink-connector-cassandra] zentol commented on a diff in pull request #3: [FLINK-26822] Add Cassandra Source

2023-03-15 Thread via GitHub
zentol commented on code in PR #3: URL: https://github.com/apache/flink-connector-cassandra/pull/3#discussion_r1137369940 ## flink-connector-cassandra/src/main/java/org/apache/flink/connector/cassandra/source/split/SplitsGenerator.java: ## @@ -0,0 +1,237 @@ +/* + * Licensed to

[GitHub] [flink-connector-cassandra] echauchot commented on a diff in pull request #3: [FLINK-26822] Add Cassandra Source

2023-03-15 Thread via GitHub
echauchot commented on code in PR #3: URL: https://github.com/apache/flink-connector-cassandra/pull/3#discussion_r1137367392 ## flink-connector-cassandra/src/test/java/org/apache/flink/connector/cassandra/source/reader/CassandraQueryTest.java: ## @@ -0,0 +1,108 @@ +/* + * Licen

[GitHub] [flink] dmvk commented on a diff in pull request #22169: [FLINK-31399] AdaptiveScheduler is able to handle changes in job resource requirements.

2023-03-15 Thread via GitHub
dmvk commented on code in PR #22169: URL: https://github.com/apache/flink/pull/22169#discussion_r1137368094 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveScheduler.java: ## @@ -730,15 +748,49 @@ public CompletableFuture deliverCoordinationRe

[GitHub] [flink-connector-cassandra] echauchot commented on a diff in pull request #3: [FLINK-26822] Add Cassandra Source

2023-03-15 Thread via GitHub
echauchot commented on code in PR #3: URL: https://github.com/apache/flink-connector-cassandra/pull/3#discussion_r1137367392 ## flink-connector-cassandra/src/test/java/org/apache/flink/connector/cassandra/source/reader/CassandraQueryTest.java: ## @@ -0,0 +1,108 @@ +/* + * Licen

[GitHub] [flink-connector-cassandra] zentol commented on a diff in pull request #3: [FLINK-26822] Add Cassandra Source

2023-03-15 Thread via GitHub
zentol commented on code in PR #3: URL: https://github.com/apache/flink-connector-cassandra/pull/3#discussion_r1137361425 ## flink-connector-cassandra/src/test/java/org/apache/flink/connector/cassandra/source/reader/CassandraQueryTest.java: ## @@ -0,0 +1,108 @@ +/* + * Licensed

[jira] [Commented] (FLINK-31317) Introduce data structures for managing resource requirements of a job

2023-03-15 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-31317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17700762#comment-17700762 ] David Morávek commented on FLINK-31317: --- master: a84de2ca4a9239bccb0d28c9bb6f841de

[GitHub] [flink-connector-cassandra] echauchot commented on a diff in pull request #3: [FLINK-26822] Add Cassandra Source

2023-03-15 Thread via GitHub
echauchot commented on code in PR #3: URL: https://github.com/apache/flink-connector-cassandra/pull/3#discussion_r1137359449 ## flink-connector-cassandra/src/main/java/org/apache/flink/connector/cassandra/source/split/SplitsGenerator.java: ## @@ -0,0 +1,237 @@ +/* + * Licensed

[GitHub] [flink-connector-cassandra] zentol commented on a diff in pull request #3: [FLINK-26822] Add Cassandra Source

2023-03-15 Thread via GitHub
zentol commented on code in PR #3: URL: https://github.com/apache/flink-connector-cassandra/pull/3#discussion_r1137359264 ## flink-connector-cassandra/src/test/java/org/apache/flink/connector/cassandra/source/CassandraTestEnvironment.java: ## @@ -0,0 +1,192 @@ +/* + * Licensed

[jira] [Resolved] (FLINK-31317) Introduce data structures for managing resource requirements of a job

2023-03-15 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-31317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Morávek resolved FLINK-31317. --- Fix Version/s: 1.18.0 Resolution: Fixed > Introduce data structures for managing reso

[jira] [Assigned] (FLINK-31317) Introduce data structures for managing resource requirements of a job

2023-03-15 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-31317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Morávek reassigned FLINK-31317: - Assignee: David Morávek > Introduce data structures for managing resource requirements

[GitHub] [flink-connector-cassandra] echauchot commented on a diff in pull request #3: [FLINK-26822] Add Cassandra Source

2023-03-15 Thread via GitHub
echauchot commented on code in PR #3: URL: https://github.com/apache/flink-connector-cassandra/pull/3#discussion_r1137317001 ## flink-connector-cassandra/src/test/java/org/apache/flink/connector/cassandra/source/CassandraSourceITCase.java: ## @@ -0,0 +1,239 @@ +/* + * Licensed

[GitHub] [flink] dmvk merged pull request #22153: [FLINK-31317] Introduce JobResourceRequirements and JobVertexResourceRequirements data structures.

2023-03-15 Thread via GitHub
dmvk merged PR #22153: URL: https://github.com/apache/flink/pull/22153 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.o

[GitHub] [flink-connector-cassandra] echauchot commented on a diff in pull request #3: [FLINK-26822] Add Cassandra Source

2023-03-15 Thread via GitHub
echauchot commented on code in PR #3: URL: https://github.com/apache/flink-connector-cassandra/pull/3#discussion_r1137154417 ## flink-connector-cassandra/src/test/java/org/apache/flink/connector/cassandra/source/CassandraSourceITCase.java: ## @@ -0,0 +1,239 @@ +/* + * Licensed

[jira] [Closed] (FLINK-31475) Allow project to be user-defined in release scripts

2023-03-15 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-31475. Resolution: Fixed release_utils: 9995aec5d314351c190fbed9e9a1b439fdba217f > Allow project

[GitHub] [flink-connector-cassandra] echauchot commented on a diff in pull request #3: [FLINK-26822] Add Cassandra Source

2023-03-15 Thread via GitHub
echauchot commented on code in PR #3: URL: https://github.com/apache/flink-connector-cassandra/pull/3#discussion_r1137350771 ## flink-connector-cassandra/src/test/java/org/apache/flink/connector/cassandra/source/CassandraTestEnvironment.java: ## @@ -0,0 +1,192 @@ +/* + * Licens

[GitHub] [flink-connector-shared-utils] zentol merged pull request #13: [FLINK-31475] Allow project to be overridden

2023-03-15 Thread via GitHub
zentol merged PR #13: URL: https://github.com/apache/flink-connector-shared-utils/pull/13 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubsc

[GitHub] [flink-connector-cassandra] zentol commented on a diff in pull request #3: [FLINK-26822] Add Cassandra Source

2023-03-15 Thread via GitHub
zentol commented on code in PR #3: URL: https://github.com/apache/flink-connector-cassandra/pull/3#discussion_r1137346895 ## flink-connector-cassandra/src/main/java/org/apache/flink/connector/cassandra/source/split/SplitsGenerator.java: ## @@ -0,0 +1,237 @@ +/* + * Licensed to

  1   2   3   >