[jira] [Created] (FLINK-31668) Gateway should close select query when session is timeout

2023-03-29 Thread Fang Yong (Jira)
Fang Yong created FLINK-31668: - Summary: Gateway should close select query when session is timeout Key: FLINK-31668 URL: https://issues.apache.org/jira/browse/FLINK-31668 Project: Flink Issue

[jira] [Commented] (FLINK-30321) Upgrade ZLIB of FRocksDB to 1.2.13

2023-03-29 Thread Yanfei Lei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17706701#comment-17706701 ] Yanfei Lei commented on FLINK-30321: By upgrading the version of ZLIB. > Upgrade ZLIB of FRocksDB

[GitHub] [flink] flinkbot commented on pull request #22306: [FLINK-31447][runtime] Aligning unit tests of FineGrainedSlotManager with DeclarativeSlotManager

2023-03-29 Thread via GitHub
flinkbot commented on PR #22306: URL: https://github.com/apache/flink/pull/22306#issuecomment-1489728144 ## CI report: * 8cd10bb37f4a41f9c5522f4db1543c4f8c43adda UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-31447) Aligning unit tests of FineGrainedSlotManager with DeclarativeSlotManager

2023-03-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31447: --- Labels: pull-request-available (was: ) > Aligning unit tests of FineGrainedSlotManager

[GitHub] [flink] huwh opened a new pull request, #22306: [FLINK-31447][runtime] Aligning unit tests of FineGrainedSlotManager with DeclarativeSlotManager

2023-03-29 Thread via GitHub
huwh opened a new pull request, #22306: URL: https://github.com/apache/flink/pull/22306 ## What is the purpose of the change Aligning unit tests of FineGrainedSlotManager with DeclarativeSlotManager The unit test diff between FGSM and DSM are list in :

[GitHub] [flink] flinkbot commented on pull request #22305: [FLINK-31443][runtime] Maintain redundant taskmanagers to speed up failover

2023-03-29 Thread via GitHub
flinkbot commented on PR #22305: URL: https://github.com/apache/flink/pull/22305#issuecomment-148975 ## CI report: * f84a771b4186acb7a41a82e9554681fe802ed651 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Created] (FLINK-31667) Should not enforce attached mode in RemoteEnvironment & RemoteStreamEnvironment

2023-03-29 Thread Jeff Zhang (Jira)
Jeff Zhang created FLINK-31667: -- Summary: Should not enforce attached mode in RemoteEnvironment & RemoteStreamEnvironment Key: FLINK-31667 URL: https://issues.apache.org/jira/browse/FLINK-31667 Project:

[jira] [Updated] (FLINK-31443) FineGrainedSlotManager maintain some redundant task managers

2023-03-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31443: --- Labels: pull-request-available (was: ) > FineGrainedSlotManager maintain some redundant

[GitHub] [flink] liuyongvs commented on a diff in pull request #22267: [FLINK-31602][table] Add built-in ARRAY_POSITION function.

2023-03-29 Thread via GitHub
liuyongvs commented on code in PR #22267: URL: https://github.com/apache/flink/pull/22267#discussion_r1152691246 ## docs/data/sql_functions.yml: ## @@ -634,6 +634,9 @@ collection: - sql: ARRAY_DISTINCT(haystack) table: haystack.arrayDistinct() description: Returns

[GitHub] [flink] huwh opened a new pull request, #22305: [FLINK-31443][runtime] Maintain redundant taskmanagers to speed up failover

2023-03-29 Thread via GitHub
huwh opened a new pull request, #22305: URL: https://github.com/apache/flink/pull/22305 ## What is the purpose of the change implementation of [FLINK-18625](https://issues.apache.org/jira/browse/FLINK-18625) in FineGrainedSlotManager. ## Brief change log - *check that

[jira] [Commented] (FLINK-31663) Add ARRAY_EXCEPT supported in SQL & Table API

2023-03-29 Thread jackylau (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17706693#comment-17706693 ] jackylau commented on FLINK-31663: -- should links to https://issues.apache.org/jira/browse/FLINK-22484

[jira] [Updated] (FLINK-31118) Add ARRAY_UNION supported in SQL & Table API

2023-03-29 Thread jackylau (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jackylau updated FLINK-31118: - Description: Remove all elements that equal to element from array. Syntax: array_union(array)

[jira] [Created] (FLINK-31666) Add ARRAY_OVERLAP supported in SQL & Table API

2023-03-29 Thread jackylau (Jira)
jackylau created FLINK-31666: Summary: Add ARRAY_OVERLAP supported in SQL & Table API Key: FLINK-31666 URL: https://issues.apache.org/jira/browse/FLINK-31666 Project: Flink Issue Type:

[jira] [Created] (FLINK-31665) Add ARRAY_CONCAT supported in SQL & Table API

2023-03-29 Thread jackylau (Jira)
jackylau created FLINK-31665: Summary: Add ARRAY_CONCAT supported in SQL & Table API Key: FLINK-31665 URL: https://issues.apache.org/jira/browse/FLINK-31665 Project: Flink Issue Type:

[jira] [Created] (FLINK-31664) Add ARRAY_INTERSECT supported in SQL & Table API

2023-03-29 Thread jackylau (Jira)
jackylau created FLINK-31664: Summary: Add ARRAY_INTERSECT supported in SQL & Table API Key: FLINK-31664 URL: https://issues.apache.org/jira/browse/FLINK-31664 Project: Flink Issue Type:

[GitHub] [flink-ml] zhipeng93 merged pull request #228: [hotfix][doc] Update website doc to avoid space in the feature engineering algorithm names

2023-03-29 Thread via GitHub
zhipeng93 merged PR #228: URL: https://github.com/apache/flink-ml/pull/228 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink-ml] zhipeng93 commented on pull request #228: [hotfix][doc] Update website doc to avoid space in the feature engineering algorithm names

2023-03-29 Thread via GitHub
zhipeng93 commented on PR #228: URL: https://github.com/apache/flink-ml/pull/228#issuecomment-1489672277 Thanks for the PR. LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (FLINK-31593) Update reference data for Migration Tests

2023-03-29 Thread Yanfei Lei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17706679#comment-17706679 ] Yanfei Lei commented on FLINK-31593: > But it still leaves question marks on why this issue didn't

[jira] [Updated] (FLINK-31240) Reduce the overhead of conversion between DataStream and Table

2023-03-29 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated FLINK-31240: - Description: In some cases, users may need to convert the underlying DataStream to Table and then

[GitHub] [flink] JLY2015 closed pull request #22304: fix space

2023-03-29 Thread via GitHub
JLY2015 closed pull request #22304: fix space URL: https://github.com/apache/flink/pull/22304 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] JLY2015 opened a new pull request, #22304: fix space

2023-03-29 Thread via GitHub
JLY2015 opened a new pull request, #22304: URL: https://github.com/apache/flink/pull/22304 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them

[jira] [Commented] (FLINK-31240) Reduce the overhead of conversion between DataStream and Table

2023-03-29 Thread Yunfeng Zhou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17706673#comment-17706673 ] Yunfeng Zhou commented on FLINK-31240: -- It seems that I do not have permission to modify this

[GitHub] [flink] liuyongvs commented on a diff in pull request #22267: [FLINK-31602][table] Add built-in ARRAY_POSITION function.

2023-03-29 Thread via GitHub
liuyongvs commented on code in PR #22267: URL: https://github.com/apache/flink/pull/22267#discussion_r1152691246 ## docs/data/sql_functions.yml: ## @@ -634,6 +634,9 @@ collection: - sql: ARRAY_DISTINCT(haystack) table: haystack.arrayDistinct() description: Returns

[GitHub] [flink] liuyongvs commented on pull request #22267: [FLINK-31602][table] Add built-in ARRAY_POSITION function.

2023-03-29 Thread via GitHub
liuyongvs commented on PR #22267: URL: https://github.com/apache/flink/pull/22267#issuecomment-1489627172 @luoyuxia fix your review and rebase master to verify whether it is affected by others. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [flink] liuyongvs commented on a diff in pull request #22267: [FLINK-31602][table] Add built-in ARRAY_POSITION function.

2023-03-29 Thread via GitHub
liuyongvs commented on code in PR #22267: URL: https://github.com/apache/flink/pull/22267#discussion_r1152687435 ## docs/data/sql_functions.yml: ## @@ -634,6 +634,9 @@ collection: - sql: ARRAY_DISTINCT(haystack) table: haystack.arrayDistinct() description: Returns

[GitHub] [flink] liuyongvs commented on a diff in pull request #22267: [FLINK-31602][table] Add built-in ARRAY_POSITION function.

2023-03-29 Thread via GitHub
liuyongvs commented on code in PR #22267: URL: https://github.com/apache/flink/pull/22267#discussion_r1152685125 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArrayPositionFunction.java: ## @@ -0,0 +1,91 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-30321) Upgrade ZLIB of FRocksDB to 1.2.13

2023-03-29 Thread songwenbin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17706669#comment-17706669 ] songwenbin commented on FLINK-30321: How do you solve the problem with cve-2018-25032 in Flink

[GitHub] [flink] liuyongvs commented on a diff in pull request #22267: [FLINK-31602][table] Add built-in ARRAY_POSITION function.

2023-03-29 Thread via GitHub
liuyongvs commented on code in PR #22267: URL: https://github.com/apache/flink/pull/22267#discussion_r1152684875 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArrayPositionFunction.java: ## @@ -0,0 +1,91 @@ +/* + * Licensed to

[GitHub] [flink] mas-chen commented on a diff in pull request #22303: [FLINK-31305] fix error propagation bug in WriterCallback and use Tes…

2023-03-29 Thread via GitHub
mas-chen commented on code in PR #22303: URL: https://github.com/apache/flink/pull/22303#discussion_r1152683101 ## flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaWriter.java: ## @@ -420,6 +420,7 @@ private void

[GitHub] [flink] mas-chen commented on a diff in pull request #22303: [FLINK-31305] fix error propagation bug in WriterCallback and use Tes…

2023-03-29 Thread via GitHub
mas-chen commented on code in PR #22303: URL: https://github.com/apache/flink/pull/22303#discussion_r1152683101 ## flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaWriter.java: ## @@ -420,6 +420,7 @@ private void

[GitHub] [flink] luoyuxia commented on a diff in pull request #22301: [FLINK-31426][table] Upgrade the deprecated UniqueConstraint to the n…

2023-03-29 Thread via GitHub
luoyuxia commented on code in PR #22301: URL: https://github.com/apache/flink/pull/22301#discussion_r1152682771 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/api/constraints/UniqueConstraint.java: ## @@ -1,111 +0,0 @@ -/* - * Licensed to the Apache

[GitHub] [flink] mas-chen commented on a diff in pull request #22303: [FLINK-31305] fix error propagation bug in WriterCallback and use Tes…

2023-03-29 Thread via GitHub
mas-chen commented on code in PR #22303: URL: https://github.com/apache/flink/pull/22303#discussion_r1152679757 ## flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaWriter.java: ## @@ -420,6 +420,7 @@ private void

[GitHub] [flink] mas-chen commented on a diff in pull request #22303: [FLINK-31305] fix error propagation bug in WriterCallback and use Tes…

2023-03-29 Thread via GitHub
mas-chen commented on code in PR #22303: URL: https://github.com/apache/flink/pull/22303#discussion_r1152679757 ## flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaWriter.java: ## @@ -420,6 +420,7 @@ private void

[GitHub] [flink-connector-kafka] chucheng92 commented on a diff in pull request #10: [FLINK-30935][connector/kafka] Add kafka serializers version check when using SimpleVersionedSerializer

2023-03-29 Thread via GitHub
chucheng92 commented on code in PR #10: URL: https://github.com/apache/flink-connector-kafka/pull/10#discussion_r1152677881 ## flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaCommittableSerializer.java: ## @@ -46,6 +46,15 @@ public byte[]

[jira] [Created] (FLINK-31663) Add ARRAY_EXCEPT supported in SQL & Table API

2023-03-29 Thread luoyuxia (Jira)
luoyuxia created FLINK-31663: Summary: Add ARRAY_EXCEPT supported in SQL & Table API Key: FLINK-31663 URL: https://issues.apache.org/jira/browse/FLINK-31663 Project: Flink Issue Type: Sub-task

[GitHub] [flink] tzulitai commented on a diff in pull request #22303: [FLINK-31305] fix error propagation bug in WriterCallback and use Tes…

2023-03-29 Thread via GitHub
tzulitai commented on code in PR #22303: URL: https://github.com/apache/flink/pull/22303#discussion_r1152666515 ## flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaWriter.java: ## @@ -420,6 +420,7 @@ private void

[GitHub] [flink] tzulitai commented on a diff in pull request #22303: [FLINK-31305] fix error propagation bug in WriterCallback and use Tes…

2023-03-29 Thread via GitHub
tzulitai commented on code in PR #22303: URL: https://github.com/apache/flink/pull/22303#discussion_r1152666515 ## flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaWriter.java: ## @@ -420,6 +420,7 @@ private void

[GitHub] [flink] tzulitai commented on a diff in pull request #22303: [FLINK-31305] fix error propagation bug in WriterCallback and use Tes…

2023-03-29 Thread via GitHub
tzulitai commented on code in PR #22303: URL: https://github.com/apache/flink/pull/22303#discussion_r1152668428 ## flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaWriter.java: ## @@ -420,6 +420,7 @@ private void

[GitHub] [flink] luoyuxia commented on a diff in pull request #22267: [FLINK-31602][table] Add built-in ARRAY_POSITION function.

2023-03-29 Thread via GitHub
luoyuxia commented on code in PR #22267: URL: https://github.com/apache/flink/pull/22267#discussion_r1152666906 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArrayPositionFunction.java: ## @@ -0,0 +1,91 @@ +/* + * Licensed to

[GitHub] [flink] tzulitai commented on a diff in pull request #22303: [FLINK-31305] fix error propagation bug in WriterCallback and use Tes…

2023-03-29 Thread via GitHub
tzulitai commented on code in PR #22303: URL: https://github.com/apache/flink/pull/22303#discussion_r1152666515 ## flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaWriter.java: ## @@ -420,6 +420,7 @@ private void

[GitHub] [flink] luoyuxia commented on a diff in pull request #22267: [FLINK-31602][table] Add built-in ARRAY_POSITION function.

2023-03-29 Thread via GitHub
luoyuxia commented on code in PR #22267: URL: https://github.com/apache/flink/pull/22267#discussion_r1152667003 ## docs/data/sql_functions.yml: ## @@ -634,6 +634,9 @@ collection: - sql: ARRAY_DISTINCT(haystack) table: haystack.arrayDistinct() description: Returns

[GitHub] [flink] luoyuxia commented on a diff in pull request #22267: [FLINK-31602][table] Add built-in ARRAY_POSITION function.

2023-03-29 Thread via GitHub
luoyuxia commented on code in PR #22267: URL: https://github.com/apache/flink/pull/22267#discussion_r1152666906 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArrayPositionFunction.java: ## @@ -0,0 +1,91 @@ +/* + * Licensed to

[GitHub] [flink] reswqa closed pull request #22280: [FLINK-31626] HsSubpartitionFileReaderImpl should recycle skipped read buffers.

2023-03-29 Thread via GitHub
reswqa closed pull request #22280: [FLINK-31626] HsSubpartitionFileReaderImpl should recycle skipped read buffers. URL: https://github.com/apache/flink/pull/22280 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink] reswqa commented on pull request #22280: [FLINK-31626] HsSubpartitionFileReaderImpl should recycle skipped read buffers.

2023-03-29 Thread via GitHub
reswqa commented on PR #22280: URL: https://github.com/apache/flink/pull/22280#issuecomment-1489595913 merged via 59462197. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] liuyongvs commented on a diff in pull request #19873: [FLINK-27891][Table] Add ARRAY_APPEND and ARRAY_PREPEND functions

2023-03-29 Thread via GitHub
liuyongvs commented on code in PR #19873: URL: https://github.com/apache/flink/pull/19873#discussion_r1152663147 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java: ## @@ -178,6 +179,35 @@ ANY,

[GitHub] [flink] liuyongvs commented on a diff in pull request #19873: [FLINK-27891][Table] Add ARRAY_APPEND and ARRAY_PREPEND functions

2023-03-29 Thread via GitHub
liuyongvs commented on code in PR #19873: URL: https://github.com/apache/flink/pull/19873#discussion_r1152662832 ## docs/data/sql_functions.yml: ## @@ -617,6 +617,12 @@ collection: - sql: ARRAY_DISTINCT(haystack) table: haystack.arrayDistinct() description: Returns

[GitHub] [flink] lincoln-lil commented on pull request #22300: [FLINK-31165][table-planner] Improve the error message for order by clause

2023-03-29 Thread via GitHub
lincoln-lil commented on PR #22300: URL: https://github.com/apache/flink/pull/22300#issuecomment-1489577548 @LadyForest could you also backport this to 1.17 branch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Resolved] (FLINK-31165) Over Agg: The window rank function without order by error in top N query

2023-03-29 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee resolved FLINK-31165. - Resolution: Fixed fixed in master: eeb446c0ed07c38175efdadf7e2e21702ff02b70 > Over Agg: The

[GitHub] [flink] liuyongvs commented on pull request #22277: [FLINK-31621][table] Add built-in ARRAY_REVERSE function.

2023-03-29 Thread via GitHub
liuyongvs commented on PR #22277: URL: https://github.com/apache/flink/pull/22277#issuecomment-1489576769 fetch and rebase master and push, waiting for ci passed. thanks @fsk119 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink] Aitozi commented on a diff in pull request #22301: [FLINK-31426][table] Upgrade the deprecated UniqueConstraint to the n…

2023-03-29 Thread via GitHub
Aitozi commented on code in PR #22301: URL: https://github.com/apache/flink/pull/22301#discussion_r1152652365 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/api/constraints/UniqueConstraint.java: ## @@ -1,111 +0,0 @@ -/* - * Licensed to the Apache

[GitHub] [flink] lincoln-lil merged pull request #22300: [FLINK-31165][table-planner] Improve the error message for order by clause

2023-03-29 Thread via GitHub
lincoln-lil merged PR #22300: URL: https://github.com/apache/flink/pull/22300 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] liuyongvs commented on a diff in pull request #22277: [FLINK-31621][table] Add built-in ARRAY_REVERSE function.

2023-03-29 Thread via GitHub
liuyongvs commented on code in PR #22277: URL: https://github.com/apache/flink/pull/22277#discussion_r1152653663 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArrayReverseFunction.java: ## @@ -0,0 +1,61 @@ +/* + * Licensed to

[GitHub] [flink] liuyongvs commented on a diff in pull request #22277: [FLINK-31621][table] Add built-in ARRAY_REVERSE function.

2023-03-29 Thread via GitHub
liuyongvs commented on code in PR #22277: URL: https://github.com/apache/flink/pull/22277#discussion_r1152651153 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArrayReverseFunction.java: ## @@ -0,0 +1,61 @@ +/* + * Licensed to

[GitHub] [flink] fsk119 commented on a diff in pull request #22277: [FLINK-31621][table] Add built-in ARRAY_REVERSE function.

2023-03-29 Thread via GitHub
fsk119 commented on code in PR #22277: URL: https://github.com/apache/flink/pull/22277#discussion_r1152647480 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArrayReverseFunction.java: ## @@ -0,0 +1,61 @@ +/* + * Licensed to the

[jira] [Assigned] (FLINK-31652) Flink should handle the delete event if the pod was deleted while pending

2023-03-29 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song reassigned FLINK-31652: Assignee: xingbe > Flink should handle the delete event if the pod was deleted while

[jira] [Commented] (FLINK-31652) Flink should handle the delete event if the pod was deleted while pending

2023-03-29 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17706651#comment-17706651 ] Xintong Song commented on FLINK-31652: -- [~xiasun] You are assigned. Please go ahead. > Flink

[GitHub] [flink] mas-chen commented on pull request #22303: [FLINK-31305] fix error propagation bug in WriterCallback and use Tes…

2023-03-29 Thread via GitHub
mas-chen commented on PR #22303: URL: https://github.com/apache/flink/pull/22303#issuecomment-1489514747 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] mas-chen commented on a diff in pull request #22303: [FLINK-31305] fix error propagation bug in WriterCallback and use Tes…

2023-03-29 Thread via GitHub
mas-chen commented on code in PR #22303: URL: https://github.com/apache/flink/pull/22303#discussion_r1152609858 ## flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaWriter.java: ## @@ -420,6 +420,7 @@ private void

[GitHub] [flink] tzulitai commented on a diff in pull request #22303: [FLINK-31305] fix error propagation bug in WriterCallback and use Tes…

2023-03-29 Thread via GitHub
tzulitai commented on code in PR #22303: URL: https://github.com/apache/flink/pull/22303#discussion_r1152597944 ## flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaWriter.java: ## @@ -420,6 +420,7 @@ private void

[GitHub] [flink] flinkbot commented on pull request #22303: [FLINK-31305] fix error propagation bug in WriterCallback and use Tes…

2023-03-29 Thread via GitHub
flinkbot commented on PR #22303: URL: https://github.com/apache/flink/pull/22303#issuecomment-1489485422 ## CI report: * 40f41cfd6c48e484746e5cd8e1ebd126ca6c6a01 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] mas-chen commented on a diff in pull request #22303: [FLINK-31305] fix error propagation bug in WriterCallback and use Tes…

2023-03-29 Thread via GitHub
mas-chen commented on code in PR #22303: URL: https://github.com/apache/flink/pull/22303#discussion_r1152594238 ## flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaWriterITCase.java: ## @@ -480,11 +478,6 @@ public

[GitHub] [flink] mas-chen commented on a diff in pull request #22303: [FLINK-31305] fix error propagation bug in WriterCallback and use Tes…

2023-03-29 Thread via GitHub
mas-chen commented on code in PR #22303: URL: https://github.com/apache/flink/pull/22303#discussion_r1152594080 ## flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaWriterITCase.java: ## @@ -224,10 +223,9 @@ void

[GitHub] [flink] mas-chen commented on a diff in pull request #22303: [FLINK-31305] fix error propagation bug in WriterCallback and use Tes…

2023-03-29 Thread via GitHub
mas-chen commented on code in PR #22303: URL: https://github.com/apache/flink/pull/22303#discussion_r1152593857 ## flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaWriter.java: ## @@ -447,15 +448,14 @@ public void

[GitHub] [flink] mas-chen opened a new pull request, #22303: [FLINK-31305] fix error propagation bug in WriterCallback and use Tes…

2023-03-29 Thread via GitHub
mas-chen opened a new pull request, #22303: URL: https://github.com/apache/flink/pull/22303 …tSinkInitContext general purpose sink testing tool ## What is the purpose of the change Fixes a regression of a fix to properly propagate the error from WriterCallback. Also improve

[jira] [Commented] (FLINK-31660) flink-connectors-kafka ITCases are not runnable in the IDE

2023-03-29 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17706608#comment-17706608 ] Timo Walther commented on FLINK-31660: -- [~dwysakowicz] You also ran into this problem recently, how

[jira] [Commented] (FLINK-31660) flink-connectors-kafka ITCases are not runnable in the IDE

2023-03-29 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17706607#comment-17706607 ] Timo Walther commented on FLINK-31660: -- This is a very annoying issue but iirc should not be a

[GitHub] [flink-connector-kafka] tzulitai closed pull request #15: [FLINK-31363] Do not checkpoint a KafkaCommittable if the transaction was empty

2023-03-29 Thread via GitHub
tzulitai closed pull request #15: [FLINK-31363] Do not checkpoint a KafkaCommittable if the transaction was empty URL: https://github.com/apache/flink-connector-kafka/pull/15 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [flink-connector-kafka] tzulitai commented on pull request #5: [FLINK-25916][connector-kafka] Using upsert-kafka with a flush buffer…

2023-03-29 Thread via GitHub
tzulitai commented on PR #5: URL: https://github.com/apache/flink-connector-kafka/pull/5#issuecomment-1489307778 @paul8263 I think you can just go to the CI job page and re-run the job. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [flink-connector-kafka] tzulitai commented on pull request #15: [FLINK-31363] Do not checkpoint a KafkaCommittable if the transaction was empty

2023-03-29 Thread via GitHub
tzulitai commented on PR #15: URL: https://github.com/apache/flink-connector-kafka/pull/15#issuecomment-1489305429 thanks for the review @RamanVerma, merging this now! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [flink-connector-kafka] tzulitai closed pull request #19: [Sync apache/flink:master][FLINK-31305] Propagate producer exceptions outside of mailbox execut…

2023-03-29 Thread via GitHub
tzulitai closed pull request #19: [Sync apache/flink:master][FLINK-31305] Propagate producer exceptions outside of mailbox execut… URL: https://github.com/apache/flink-connector-kafka/pull/19 -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [flink] tzulitai commented on pull request #22124: [FLINK-30805] Ask for a new split when one has finished in SourceReader default implementation

2023-03-29 Thread via GitHub
tzulitai commented on PR #22124: URL: https://github.com/apache/flink/pull/22124#issuecomment-1489271591 @echauchot thanks for opening the PR. I think I agree with @mas-chen that this default implementation doesn't seem like a good idea. > the question can be reduced to "'what

[GitHub] [flink] snuyanzin commented on pull request #19873: [FLINK-27891][Table] Add ARRAY_APPEND and ARRAY_PREPEND functions

2023-03-29 Thread via GitHub
snuyanzin commented on PR #19873: URL: https://github.com/apache/flink/pull/19873#issuecomment-1489254376 yes i will -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] snuyanzin commented on a diff in pull request #19873: [FLINK-27891][Table] Add ARRAY_APPEND and ARRAY_PREPEND functions

2023-03-29 Thread via GitHub
snuyanzin commented on code in PR #19873: URL: https://github.com/apache/flink/pull/19873#discussion_r1152441866 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java: ## @@ -178,6 +179,35 @@ ANY,

[GitHub] [flink] snuyanzin commented on a diff in pull request #19873: [FLINK-27891][Table] Add ARRAY_APPEND and ARRAY_PREPEND functions

2023-03-29 Thread via GitHub
snuyanzin commented on code in PR #19873: URL: https://github.com/apache/flink/pull/19873#discussion_r1152440929 ## docs/data/sql_functions.yml: ## @@ -617,6 +617,12 @@ collection: - sql: ARRAY_DISTINCT(haystack) table: haystack.arrayDistinct() description: Returns

[jira] [Updated] (FLINK-27891) Add ARRAY_APPEND and ARRAY_PREPEND supported in SQL & Table API

2023-03-29 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-27891: Description: {{ARRAY_APPEND}} - adds element to the end of the array and returns the

[jira] [Updated] (FLINK-31662) Migrate flink-connectors-aws to new structure

2023-03-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31662: --- Labels: pull-request-available (was: ) > Migrate flink-connectors-aws to new structure >

[GitHub] [flink-connector-aws] hlteoh37 opened a new pull request, #62: [FLINK-31662][connectors][aws] Restructure repository to account for …

2023-03-29 Thread via GitHub
hlteoh37 opened a new pull request, #62: URL: https://github.com/apache/flink-connector-aws/pull/62 …flink-formats-aws ## Purpose of the change Restructure the flink-connector-aws repository to better account for flink-formats-aws ## Verifying this change This change is

[GitHub] [flink] snuyanzin commented on pull request #22266: [FLINK-31525][tests] Stabilize JdbcExactlyOnceSinkE2eTest

2023-03-29 Thread via GitHub
snuyanzin commented on PR #22266: URL: https://github.com/apache/flink/pull/22266#issuecomment-1489194393 based on exception this should help https://github.com/apache/flink/commit/36f39712d289b6b7b0b957a33bd1891266e3f992 probably need to rebase -- This is an automated message

[jira] [Closed] (FLINK-31658) Failed to receive dependency in Hive module

2023-03-29 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin closed FLINK-31658. --- Resolution: Duplicate I close it as a duplicate since originally PR was done under

[jira] [Updated] (FLINK-27640) Flink not compiling, flink-connector-hive_2.12 is missing jhyde pentaho-aggdesigner-algorithm:jar:5.1.5-jhyde

2023-03-29 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-27640: Fix Version/s: 1.16.2 > Flink not compiling, flink-connector-hive_2.12 is missing jhyde

[jira] [Commented] (FLINK-27640) Flink not compiling, flink-connector-hive_2.12 is missing jhyde pentaho-aggdesigner-algorithm:jar:5.1.5-jhyde

2023-03-29 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17706578#comment-17706578 ] Sergey Nuyanzin commented on FLINK-27640: - Fixed in 1.16:

[GitHub] [flink] snuyanzin commented on pull request #22299: [BP-1.16][FLINK-27640][Connector/Hive][SQL Client] Exclude Pentaho dependency from Hive to avoid build problems with newer Maven versions.

2023-03-29 Thread via GitHub
snuyanzin commented on PR #22299: URL: https://github.com/apache/flink/pull/22299#issuecomment-1489185062 Thanks for having a look! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] snuyanzin merged pull request #22299: [BP-1.16][FLINK-27640][Connector/Hive][SQL Client] Exclude Pentaho dependency from Hive to avoid build problems with newer Maven versions. Newer

2023-03-29 Thread via GitHub
snuyanzin merged PR #22299: URL: https://github.com/apache/flink/pull/22299 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Created] (FLINK-31662) Migrate flink-connectors-aws to new structure

2023-03-29 Thread Hong Liang Teoh (Jira)
Hong Liang Teoh created FLINK-31662: --- Summary: Migrate flink-connectors-aws to new structure Key: FLINK-31662 URL: https://issues.apache.org/jira/browse/FLINK-31662 Project: Flink Issue

[jira] [Assigned] (FLINK-31660) flink-connectors-kafka ITCases are not runnable in the IDE

2023-03-29 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski reassigned FLINK-31660: -- Assignee: Natea Eshetu Beshada > flink-connectors-kafka ITCases are not runnable in

[jira] [Updated] (FLINK-31660) flink-connectors-kafka ITCases are not runnable in the IDE

2023-03-29 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-31660: --- Affects Version/s: 1.18.0 > flink-connectors-kafka ITCases are not runnable in the IDE >

[jira] [Updated] (FLINK-31660) flink-connectors-kafka ITCases are not runnable in the IDE

2023-03-29 Thread Natea Eshetu Beshada (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Natea Eshetu Beshada updated FLINK-31660: - Description: The following exception is thrown when trying to run

[jira] [Updated] (FLINK-31661) Add parity between `ROW` value function and it's type declaration

2023-03-29 Thread Mohsen Rezaei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohsen Rezaei updated FLINK-31661: -- Description: Currently the [{{ROW}} table

[jira] [Updated] (FLINK-31660) flink-connectors-kafka ITCases are not runnable in the IDE

2023-03-29 Thread Natea Eshetu Beshada (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Natea Eshetu Beshada updated FLINK-31660: - Summary: flink-connectors-kafka ITCases are not runnable in the IDE (was:

[jira] [Created] (FLINK-31661) Add parity between `ROW` value function and it's type declaration

2023-03-29 Thread Mohsen Rezaei (Jira)
Mohsen Rezaei created FLINK-31661: - Summary: Add parity between `ROW` value function and it's type declaration Key: FLINK-31661 URL: https://issues.apache.org/jira/browse/FLINK-31661 Project: Flink

[GitHub] [flink] gaborgsomogyi commented on a diff in pull request #22298: [FLINK-31656][runtime][security] Obtain delegation tokens early to support external file system usage in blob server

2023-03-29 Thread via GitHub
gaborgsomogyi commented on code in PR #22298: URL: https://github.com/apache/flink/pull/22298#discussion_r1152340630 ## flink-runtime/src/main/java/org/apache/flink/runtime/security/token/DefaultDelegationTokenManager.java: ## @@ -213,6 +213,20 @@ public void

[GitHub] [flink] HuangZhenQiu commented on a diff in pull request #22298: [FLINK-31656][runtime][security] Obtain delegation tokens early to support external file system usage in blob server

2023-03-29 Thread via GitHub
HuangZhenQiu commented on code in PR #22298: URL: https://github.com/apache/flink/pull/22298#discussion_r1152336876 ## flink-runtime/src/main/java/org/apache/flink/runtime/security/token/DefaultDelegationTokenManager.java: ## @@ -213,6 +213,20 @@ public void

[GitHub] [flink] flinkbot commented on pull request #22302: [hotfix] [docs] Fix `ROW()` decleration syntax

2023-03-29 Thread via GitHub
flinkbot commented on PR #22302: URL: https://github.com/apache/flink/pull/22302#issuecomment-1489098892 ## CI report: * 5faed83382a1cff1905d84177becd3c6a70acce9 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] mohsenrezaeithe opened a new pull request, #22302: [hotfix] [docs] Fix `ROW()` decleration syntax

2023-03-29 Thread via GitHub
mohsenrezaeithe opened a new pull request, #22302: URL: https://github.com/apache/flink/pull/22302 Fixes typo in the documentation for declaring a `ROW` with the parethesis. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [flink-connector-opensearch] reta commented on pull request #5: [FLINK-30488] OpenSearch implementation of Async Sink

2023-03-29 Thread via GitHub
reta commented on PR #5: URL: https://github.com/apache/flink-connector-opensearch/pull/5#issuecomment-1489036967 > I am reluctant to introduce a new Sink API based on the internal implementation unless there is a really good/semantic reason. Thanks @dannycranmer , I understand your

[GitHub] [flink-connector-kafka] tzulitai commented on a diff in pull request #10: [FLINK-30935][connector/kafka] Add kafka serializers version check when using SimpleVersionedSerializer

2023-03-29 Thread via GitHub
tzulitai commented on code in PR #10: URL: https://github.com/apache/flink-connector-kafka/pull/10#discussion_r1152287033 ## flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaCommittableSerializer.java: ## @@ -46,6 +46,15 @@ public byte[]

[GitHub] [flink-connector-kafka] tzulitai commented on a diff in pull request #10: [FLINK-30935][connector/kafka] Add kafka serializers version check when using SimpleVersionedSerializer

2023-03-29 Thread via GitHub
tzulitai commented on code in PR #10: URL: https://github.com/apache/flink-connector-kafka/pull/10#discussion_r1152287033 ## flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaCommittableSerializer.java: ## @@ -46,6 +46,15 @@ public byte[]

[jira] [Created] (FLINK-31660) flink-connectors-kafka is not runnable in the IDE

2023-03-29 Thread Natea Eshetu Beshada (Jira)
Natea Eshetu Beshada created FLINK-31660: Summary: flink-connectors-kafka is not runnable in the IDE Key: FLINK-31660 URL: https://issues.apache.org/jira/browse/FLINK-31660 Project: Flink

[GitHub] [flink-connector-kafka] tzulitai commented on pull request #19: [Sync apache/flink:master][FLINK-31305] Propagate producer exceptions outside of mailbox execut…

2023-03-29 Thread via GitHub
tzulitai commented on PR #19: URL: https://github.com/apache/flink-connector-kafka/pull/19#issuecomment-1488989738 Thanks @mas-chen for porting this over. Will merge once CI is green. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [flink] clownxc commented on pull request #22301: [FLINK-31426][table] Upgrade the deprecated UniqueConstraint to the n…

2023-03-29 Thread via GitHub
clownxc commented on PR #22301: URL: https://github.com/apache/flink/pull/22301#issuecomment-1488903242 can you spare some precious time to review? Thanks very much @Aitozi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

  1   2   3   >