[GitHub] [flink] whjshj opened a new pull request, #22649: [FLINK-31967][table-runner] Solving the Initial Value Problem of LagA…

2023-05-24 Thread via GitHub
whjshj opened a new pull request, #22649: URL: https://github.com/apache/flink/pull/22649 ## What is the purpose of the change Slove the Initial Value Problem of LagAggregation ## Brief change log dermine if the default value needs to be converted from non-null t

[GitHub] [flink] whjshj closed pull request #22648: Test

2023-05-24 Thread via GitHub
whjshj closed pull request #22648: Test URL: https://github.com/apache/flink/pull/22648 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[GitHub] [flink] whjshj commented on pull request #22648: Test

2023-05-24 Thread via GitHub
whjshj commented on PR #22648: URL: https://github.com/apache/flink/pull/22648#issuecomment-1562375143 > ## What is the purpose of the change > _(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring the

[GitHub] [flink] whjshj commented on pull request #22648: Test

2023-05-24 Thread via GitHub
whjshj commented on PR #22648: URL: https://github.com/apache/flink/pull/22648#issuecomment-1562374590 > ## What is the purpose of the change > _(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring the

[GitHub] [flink] whjshj opened a new pull request, #22648: Test

2023-05-24 Thread via GitHub
whjshj opened a new pull request, #22648: URL: https://github.com/apache/flink/pull/22648 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #210: [FLINK-31010] Add Transformer and Estimator for GBTClassifier and GBTRegressor

2023-05-24 Thread via GitHub
zhipeng93 commented on code in PR #210: URL: https://github.com/apache/flink-ml/pull/210#discussion_r1205036234 ## flink-ml-lib/src/main/java/org/apache/flink/ml/common/gbt/GBTRunner.java: ## @@ -0,0 +1,304 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] [flink] flinkbot commented on pull request #22647: [FLINK-31967][table-runner] Solving the Initial Value Problem of LagA…

2023-05-24 Thread via GitHub
flinkbot commented on PR #22647: URL: https://github.com/apache/flink/pull/22647#issuecomment-1562359926 ## CI report: * 033924a9d536b810005b701d730bcfd450efab34 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] whjshj opened a new pull request, #22647: [FLINK-31967][table-runner] Solving the Initial Value Problem of LagA…

2023-05-24 Thread via GitHub
whjshj opened a new pull request, #22647: URL: https://github.com/apache/flink/pull/22647 ## What is the purpose of the change *Slove the Initial Value Problem of LagAggregation ## Brief change log dermine if the default value needs to be converted from non-null

[GitHub] [flink-benchmarks] wanglijie95 commented on a diff in pull request #68: [FLINK-31832] Add benchmarks for end to end restarting tasks.

2023-05-24 Thread via GitHub
wanglijie95 commented on code in PR #68: URL: https://github.com/apache/flink-benchmarks/pull/68#discussion_r1205050377 ## src/main/java/org/apache/flink/scheduler/benchmark/e2e/HandleGlobalFailureAndRestartAllTasksBenchmarkExecutor.java: ## @@ -0,0 +1,62 @@ +/* + * Licensed to

[GitHub] [flink] flinkbot commented on pull request #22646: [FLINK-31896][runtime] Extend web interface to support failure labels

2023-05-24 Thread via GitHub
flinkbot commented on PR #22646: URL: https://github.com/apache/flink/pull/22646#issuecomment-1562320298 ## CI report: * 1cde25a1734471f27308493b1992ed6b645f581d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink-connector-jdbc] snuyanzin commented on pull request #9: [FLINK-30431][Connector/JDBC] JDBC Connector fails to reestablish the lost DB connect

2023-05-24 Thread via GitHub
snuyanzin commented on PR #9: URL: https://github.com/apache/flink-connector-jdbc/pull/9#issuecomment-1562313350 thanks for pointing to javadoc, I've checked the javadoc for `java.sql.Statement#close` method as well e.g. [1] and there is such statement >Calling the method close on

[GitHub] [flink-connector-jdbc] GOODBOY008 commented on pull request #8: [FLINK-14102] Introduce DB2Dialect.

2023-05-24 Thread via GitHub
GOODBOY008 commented on PR #8: URL: https://github.com/apache/flink-connector-jdbc/pull/8#issuecomment-1562295024 > @GOODBOY008 Can you please rebase and take the latest changes into account that @eskabetxe has provided via #22 @MartijnVisser I rebase to latest branch `main` , Pleas

[jira] [Assigned] (FLINK-32180) Move error handling into MultipleComponentLeaderElectionDriverFactory

2023-05-24 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl reassigned FLINK-32180: - Assignee: Matthias Pohl > Move error handling into MultipleComponentLeaderElectionDrive

[GitHub] [flink-kubernetes-operator] tchin25 commented on a diff in pull request #604: [FLINK-32041] - Allow operator to manage leases when using watchNamespaces

2023-05-24 Thread via GitHub
tchin25 commented on code in PR #604: URL: https://github.com/apache/flink-kubernetes-operator/pull/604#discussion_r1205009047 ## helm/flink-kubernetes-operator/templates/rbac.yaml: ## @@ -71,13 +71,18 @@ rules: - ingresses verbs: - "*" +{{/* +watchNamespaces

[GitHub] [flink-kubernetes-operator] xccui opened a new pull request, #609: [FLINK-32171] Add PostStart hook to flink k8s operator helm

2023-05-24 Thread via GitHub
xccui opened a new pull request, #609: URL: https://github.com/apache/flink-kubernetes-operator/pull/609 ## What is the purpose of the change Introduce postStart hook to allow users to initialize the main container with some commands. For instance, users can download flink-fs-s3-hadoo

[GitHub] [flink-connector-jdbc] Jiabao-Sun commented on pull request #9: [FLINK-30431][Connector/JDBC] JDBC Connector fails to reestablish the lost DB connect

2023-05-24 Thread via GitHub
Jiabao-Sun commented on PR #9: URL: https://github.com/apache/flink-connector-jdbc/pull/9#issuecomment-1562233471 > I would rather go with check if preparedstatment is closed or not rather than wrapping it in `try`...`catch`. Is there anything blocking here to go that way? Thanks @s

[GitHub] [flink-connector-jdbc] Jiabao-Sun commented on pull request #9: [FLINK-30431][Connector/JDBC] JDBC Connector fails to reestablish the lost DB connect

2023-05-24 Thread via GitHub
Jiabao-Sun commented on PR #9: URL: https://github.com/apache/flink-connector-jdbc/pull/9#issuecomment-1562211533 > @Jiabao-Sun Can you rebase and use the new testing setup? @snuyanzin any thoughts on the actual PR fix itself? Sorry for the late reply. @MartijnVisser can you help

[jira] [Commented] (FLINK-31967) SQL with LAG function NullPointerException

2023-05-24 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17726029#comment-17726029 ] Shengkai Fang commented on FLINK-31967: --- Merged into master: ac6aedbf0f35ba9734108

[GitHub] [flink] fsk119 merged pull request #22599: [FLINK-31967][table-runner] Solving the Initial Value Problem of LagA…

2023-05-24 Thread via GitHub
fsk119 merged PR #22599: URL: https://github.com/apache/flink/pull/22599 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

[GitHub] [flink] reswqa commented on pull request #22632: [FLINK-32161][test] Migrate and remove some legacy ExternalResource

2023-05-24 Thread via GitHub
reswqa commented on PR #22632: URL: https://github.com/apache/flink/pull/22632#issuecomment-1562187287 Thanks for the feedback. That's really interesting, I'll try installing this plugin 😆 -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [flink] flinkbot commented on pull request #22645: [hotfix][doc]Fix typo in analyze.md

2023-05-24 Thread via GitHub
flinkbot commented on PR #22645: URL: https://github.com/apache/flink/pull/22645#issuecomment-1562172610 ## CI report: * bb088cbc1ae22f1a5d0e689a5c51774606cd6792 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] jasonyuan-cn commented on pull request #22645: [hotfix][doc]Fix typo in analyze.md

2023-05-24 Thread via GitHub
jasonyuan-cn commented on PR #22645: URL: https://github.com/apache/flink/pull/22645#issuecomment-1562172078 @reswqa PTAL and if there is anything inappropriate please point it out to me. Thanks again. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink] flinkbot commented on pull request #22644: [FLINK-32043][sql-gateway] Fix Sql Gateway doesn't validate set state…

2023-05-24 Thread via GitHub
flinkbot commented on PR #22644: URL: https://github.com/apache/flink/pull/22644#issuecomment-1562167603 ## CI report: * 0df65e91acb7132825d4d72c1932d608ddaf2bf4 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-32043) SqlClient session unrecoverable once one wrong setting occurred

2023-05-24 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang updated FLINK-32043: -- Affects Version/s: 1.18.0 > SqlClient session unrecoverable once one wrong setting occurred >

[jira] [Commented] (FLINK-32043) SqlClient session unrecoverable once one wrong setting occurred

2023-05-24 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17726023#comment-17726023 ] Shengkai Fang commented on FLINK-32043: --- Merged into release-1.17: 23030f6546a5f58

[GitHub] [flink] fsk119 opened a new pull request, #22644: [FLINK-32043][sql-gateway] Fix Sql Gateway doesn't validate set state…

2023-05-24 Thread via GitHub
fsk119 opened a new pull request, #22644: URL: https://github.com/apache/flink/pull/22644 Cherry pick the fix #22633 to master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [flink] xuzhiwen1255 commented on a diff in pull request #22010: [FLINK-31192][connectors/dataGen] Fix dataGen takes too long to initi…

2023-05-24 Thread via GitHub
xuzhiwen1255 commented on code in PR #22010: URL: https://github.com/apache/flink/pull/22010#discussion_r1204923081 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/datagen/SequenceGenerator.java: ## @@ -65,33 +71,46 @@ public void open(

[GitHub] [flink] fsk119 merged pull request #22633: [FLINK-32043][sql-gateway] Fix Sql Gateway doesn't validate set state…

2023-05-24 Thread via GitHub
fsk119 merged PR #22633: URL: https://github.com/apache/flink/pull/22633 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

[jira] [Updated] (FLINK-29913) Shared state would be discarded by mistake when maxConcurrentCheckpoint>1

2023-05-24 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song updated FLINK-29913: - Fix Version/s: 1.16.3 (was: 1.16.2) > Shared state would be discarded by

[GitHub] [flink] xuzhiwen1255 commented on a diff in pull request #22010: [FLINK-31192][connectors/dataGen] Fix dataGen takes too long to initi…

2023-05-24 Thread via GitHub
xuzhiwen1255 commented on code in PR #22010: URL: https://github.com/apache/flink/pull/22010#discussion_r1204911414 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/datagen/SequenceGenerator.java: ## @@ -65,33 +71,46 @@ public void open(

[GitHub] [flink] xuzhiwen1255 commented on a diff in pull request #22010: [FLINK-31192][connectors/dataGen] Fix dataGen takes too long to initi…

2023-05-24 Thread via GitHub
xuzhiwen1255 commented on code in PR #22010: URL: https://github.com/apache/flink/pull/22010#discussion_r1204910922 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/datagen/SequenceGenerator.java: ## @@ -65,33 +71,46 @@ public void open(

[GitHub] [flink-connector-jdbc] liuml07 commented on pull request #4: [FLINK-29750][Connector/JDBC] Improve PostgresCatalog#listTables() by reusing resources

2023-05-24 Thread via GitHub
liuml07 commented on PR #4: URL: https://github.com/apache/flink-connector-jdbc/pull/4#issuecomment-1561993108 Tests seem to pass in Azure. I checked PR #22 which adds test extension and is a very good improvement. I think that is orthogonal to this change. The test extension is for improv

[GitHub] [flink] flinkbot commented on pull request #22643: [FLINK-31894][runtime] ExceptionHistory and REST API failure label integration

2023-05-24 Thread via GitHub
flinkbot commented on PR #22643: URL: https://github.com/apache/flink/pull/22643#issuecomment-1561965176 ## CI report: * 0a00af46d0951e5077365ce4a4caaa992c05d879 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] pgaref opened a new pull request, #22643: [FLINK-31894][runtime] ExceptionHistory and REST API failure label integration

2023-05-24 Thread via GitHub
pgaref opened a new pull request, #22643: URL: https://github.com/apache/flink/pull/22643 https://issues.apache.org/jira/browse/FLINK-31894 * Add support for failure labels on JobExceptionsInfoWithHistory * Extend JobExceptionsHandler to support failure label filters * Extend Job

[GitHub] [flink] snuyanzin commented on pull request #22632: [FLINK-32161][test] Migrate and remove some legacy ExternalResource

2023-05-24 Thread via GitHub
snuyanzin commented on PR #22632: URL: https://github.com/apache/flink/pull/22632#issuecomment-1561939935 No worries, everything is ok thanks a lot for addressing my comments. It looks ok from my side P.S. about assertions: there is Concise AssertJ Optimizing Nitpicker plugin

[jira] [Created] (FLINK-32185) Remove M2_HOME usages

2023-05-24 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-32185: Summary: Remove M2_HOME usages Key: FLINK-32185 URL: https://issues.apache.org/jira/browse/FLINK-32185 Project: Flink Issue Type: Sub-task

[GitHub] [flink-connector-jdbc] eskabetxe commented on pull request #20: [FLINK-29750][Connector/JDBC]Support to write data to jdbc when disable flush-interval and max-rows

2023-05-24 Thread via GitHub
eskabetxe commented on PR #20: URL: https://github.com/apache/flink-connector-jdbc/pull/20#issuecomment-1561845474 @MartijnVisser for me is the expected behavior, so yes we can close it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Assigned] (FLINK-32181) Drop support for Maven 3.2.5

2023-05-24 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler reassigned FLINK-32181: Assignee: Chesnay Schepler > Drop support for Maven 3.2.5 > -

[jira] [Updated] (FLINK-32181) Drop support for Maven 3.2.5

2023-05-24 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-32181: - Description: Collection of improvements we can make when dropping support for Maven 3.2.

[jira] [Created] (FLINK-32184) Use revision version property

2023-05-24 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-32184: Summary: Use revision version property Key: FLINK-32184 URL: https://issues.apache.org/jira/browse/FLINK-32184 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-32183) Use maven.multiModuleProjectDirectory property instead of rootDir plugin

2023-05-24 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-32183: Summary: Use maven.multiModuleProjectDirectory property instead of rootDir plugin Key: FLINK-32183 URL: https://issues.apache.org/jira/browse/FLINK-32183 Proj

[jira] [Created] (FLINK-32182) Use original japicmp plugin

2023-05-24 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-32182: Summary: Use original japicmp plugin Key: FLINK-32182 URL: https://issues.apache.org/jira/browse/FLINK-32182 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-32181) Drop support for Maven 3.2.5

2023-05-24 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-32181: Summary: Drop support for Maven 3.2.5 Key: FLINK-32181 URL: https://issues.apache.org/jira/browse/FLINK-32181 Project: Flink Issue Type: Technical De

[jira] [Created] (FLINK-32180) Move error handling into MultipleComponentLeaderElectionDriverFactory

2023-05-24 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-32180: - Summary: Move error handling into MultipleComponentLeaderElectionDriverFactory Key: FLINK-32180 URL: https://issues.apache.org/jira/browse/FLINK-32180 Project: Flin

[jira] [Created] (FLINK-32179) Handle more repo names for automatic dist discovery

2023-05-24 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-32179: Summary: Handle more repo names for automatic dist discovery Key: FLINK-32179 URL: https://issues.apache.org/jira/browse/FLINK-32179 Project: Flink I

[jira] [Assigned] (FLINK-31783) Replace LeaderElectionDriver in DefaultLeaderElectionService with MultipleComponentLeaderElectionDriver

2023-05-24 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl reassigned FLINK-31783: - Assignee: Matthias Pohl > Replace LeaderElectionDriver in DefaultLeaderElectionService

[jira] [Updated] (FLINK-31783) Replace LeaderElectionDriver in DefaultLeaderElectionService with MultipleComponentLeaderElectionDriver

2023-05-24 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-31783: -- Summary: Replace LeaderElectionDriver in DefaultLeaderElectionService with MultipleComponentLe

[GitHub] [flink-connector-jdbc] MartijnVisser commented on pull request #5: [FLINK-30371][Connector/JDBC] Fix the problem of JdbcOutputFormat database connection leak

2023-05-24 Thread via GitHub
MartijnVisser commented on PR #5: URL: https://github.com/apache/flink-connector-jdbc/pull/5#issuecomment-1561750113 @EchoLee5 Can you please rebase and use the new testing setup? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [flink-connector-jdbc] MartijnVisser commented on pull request #20: [FLINK-29750][Connector/JDBC]Support to write data to jdbc when disable flush-interval and max-rows

2023-05-24 Thread via GitHub
MartijnVisser commented on PR #20: URL: https://github.com/apache/flink-connector-jdbc/pull/20#issuecomment-1561749542 @hehuiyuan @eskabetxe Should we close the ticket and PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [flink-connector-jdbc] MartijnVisser commented on pull request #43: [FLINK-31530] support oracle catalog

2023-05-24 Thread via GitHub
MartijnVisser commented on PR #43: URL: https://github.com/apache/flink-connector-jdbc/pull/43#issuecomment-1561748903 @complone Are you still planning to work on this PR, given that CI has failed? -- This is an automated message from the Apache Git Service. To respond to the message, pl

[jira] [Resolved] (FLINK-31684) Autoscaler metrics are only visible after metric window is full

2023-05-24 Thread Maximilian Michels (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels resolved FLINK-31684. Fix Version/s: kubernetes-operator-1.6.0 kubernetes-operator-1.5

[GitHub] [flink-kubernetes-operator] mxm merged pull request #606: [FLINK-31684] Report autoscaling metrics before metric window is full

2023-05-24 Thread via GitHub
mxm merged PR #606: URL: https://github.com/apache/flink-kubernetes-operator/pull/606 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[jira] [Closed] (FLINK-31616) Add user docs for canary resources

2023-05-24 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-31616. -- Resolution: Fixed > Add user docs for canary resources > -- > >

[GitHub] [flink] reswqa commented on a diff in pull request #22632: [FLINK-32161][test] Migrate and remove some legacy ExternalResource

2023-05-24 Thread via GitHub
reswqa commented on code in PR #22632: URL: https://github.com/apache/flink/pull/22632#discussion_r1204542727 ## flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/runner/ZooKeeperDefaultDispatcherRunnerTest.java: ## @@ -153,15 +154,17 @@ void testResourceCleanupUnd

[GitHub] [flink-connector-jdbc] WenDing-Y commented on pull request #49: [FLINK-32068] connector jdbc support clickhouse

2023-05-24 Thread via GitHub
WenDing-Y commented on PR #49: URL: https://github.com/apache/flink-connector-jdbc/pull/49#issuecomment-1561651398 Okay, I have rebased, but I found that there were quite a few modifications in the testing section. I have already submitted some code, but the unit test cannot pass now. I am

[GitHub] [flink] reswqa commented on pull request #22632: [FLINK-32161][test] Migrate and remove some legacy ExternalResource

2023-05-24 Thread via GitHub
reswqa commented on PR #22632: URL: https://github.com/apache/flink/pull/22632#issuecomment-1561642654 @snuyanzin Thank you for reviewing this so carefully! I have to admit that I was not in a good state when doing this, so many assertion rewrites made me feel a bit dizzy 😵. I am very sorry

[GitHub] [flink] reswqa commented on a diff in pull request #22632: [FLINK-32161][test] Migrate and remove some legacy ExternalResource

2023-05-24 Thread via GitHub
reswqa commented on code in PR #22632: URL: https://github.com/apache/flink/pull/22632#discussion_r1204491318 ## flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/runner/DefaultDispatcherRunnerITCase.java: ## @@ -173,8 +175,7 @@ private DispatcherGateway electLead

[GitHub] [flink] reswqa commented on a diff in pull request #22632: [FLINK-32161][test] Migrate and remove some legacy ExternalResource

2023-05-24 Thread via GitHub
reswqa commented on code in PR #22632: URL: https://github.com/apache/flink/pull/22632#discussion_r1204491318 ## flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/runner/DefaultDispatcherRunnerITCase.java: ## @@ -173,8 +175,7 @@ private DispatcherGateway electLead

[GitHub] [flink] reswqa commented on a diff in pull request #22632: [FLINK-32161][test] Migrate and remove some legacy ExternalResource

2023-05-24 Thread via GitHub
reswqa commented on code in PR #22632: URL: https://github.com/apache/flink/pull/22632#discussion_r1204219892 ## flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/runner/DefaultDispatcherRunnerITCase.java: ## @@ -121,18 +120,20 @@ public void setup() { par

[GitHub] [flink-connector-jdbc] snuyanzin commented on pull request #3: [FLINK-15462][connectors] Add Trino dialect

2023-05-24 Thread via GitHub
snuyanzin commented on PR #3: URL: https://github.com/apache/flink-connector-jdbc/pull/3#issuecomment-1561540897 thanks @eskabetxe in general it looks ok from my side i have a question about `FLOAT`/`REAL` in comments and some comments about tests also can you please upd

[GitHub] [flink] reswqa commented on a diff in pull request #22632: [FLINK-32161][test] Migrate and remove some legacy ExternalResource

2023-05-24 Thread via GitHub
reswqa commented on code in PR #22632: URL: https://github.com/apache/flink/pull/22632#discussion_r1204479824 ## flink-runtime/src/test/java/org/apache/flink/runtime/rest/MultipartUploadExtension.java: ## @@ -63,18 +64,18 @@ import java.util.List; import java.util.Objects; im

[GitHub] [flink] reswqa commented on a diff in pull request #22632: [FLINK-32161][test] Migrate and remove some legacy ExternalResource

2023-05-24 Thread via GitHub
reswqa commented on code in PR #22632: URL: https://github.com/apache/flink/pull/22632#discussion_r1204472915 ## flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/NettyLeakDetectionExtension.java: ## @@ -85,7 +87,7 @@ protected synchronized void after() {

[GitHub] [flink] XComp commented on a diff in pull request #22010: [FLINK-31192][connectors/dataGen] Fix dataGen takes too long to initi…

2023-05-24 Thread via GitHub
XComp commented on code in PR #22010: URL: https://github.com/apache/flink/pull/22010#discussion_r1204467390 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/datagen/SequenceGenerator.java: ## @@ -65,33 +71,46 @@ public void open(

[GitHub] [flink] XComp commented on a diff in pull request #22010: [FLINK-31192][connectors/dataGen] Fix dataGen takes too long to initi…

2023-05-24 Thread via GitHub
XComp commented on code in PR #22010: URL: https://github.com/apache/flink/pull/22010#discussion_r1204355579 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/datagen/SequenceGenerator.java: ## @@ -65,33 +71,46 @@ public void open(

[GitHub] [flink-connector-jdbc] matriv commented on pull request #29: [FLINK-31551] Add support for CrateDB

2023-05-24 Thread via GitHub
matriv commented on PR #29: URL: https://github.com/apache/flink-connector-jdbc/pull/29#issuecomment-1561465152 thx @snuyanzin, excluded the `jna` dependency from `crate-jdbc`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [flink] reswqa commented on a diff in pull request #22632: [FLINK-32161][test] Migrate and remove some legacy ExternalResource

2023-05-24 Thread via GitHub
reswqa commented on code in PR #22632: URL: https://github.com/apache/flink/pull/22632#discussion_r1204424892 ## flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/ZooKeeperCompletedCheckpointStoreTest.java: ## @@ -101,13 +102,11 @@ public void testRecoverFailsIfDow

[GitHub] [flink-web] reswqa commented on pull request #652: [FLINK-32051] Fix broken documentation links in Flink blogs

2023-05-24 Thread via GitHub
reswqa commented on PR #652: URL: https://github.com/apache/flink-web/pull/652#issuecomment-1561419772 > How about in [this page](https://flink.apache.org/how-to-contribute/improve-website/)? I think this is a good place, would you mind adding this in a hotfix commit. -- This is an

[GitHub] [flink-connector-jdbc] matriv commented on pull request #29: [FLINK-31551] Add support for CrateDB

2023-05-24 Thread via GitHub
matriv commented on PR #29: URL: https://github.com/apache/flink-connector-jdbc/pull/29#issuecomment-1561417404 > do we need crate's dependency on jna or can we exclude it? We can exclude it. -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [flink] lzshlzsh commented on a diff in pull request #22612: [FLINK-32139][connector/hbase] Using strongly increasing nanosecond timestamp and DeleteColumn type to fix data accidental deletio

2023-05-24 Thread via GitHub
lzshlzsh commented on code in PR #22612: URL: https://github.com/apache/flink/pull/22612#discussion_r1204404313 ## flink-connectors/flink-connector-hbase-base/src/main/java/org/apache/flink/connector/hbase/util/HBaseTimestampGenerator.java: ## @@ -0,0 +1,54 @@ +/* + * Licensed t

[GitHub] [flink] lzshlzsh commented on a diff in pull request #22612: [FLINK-32139][connector/hbase] Using strongly increasing nanosecond timestamp and DeleteColumn type to fix data accidental deletio

2023-05-24 Thread via GitHub
lzshlzsh commented on code in PR #22612: URL: https://github.com/apache/flink/pull/22612#discussion_r1204404313 ## flink-connectors/flink-connector-hbase-base/src/main/java/org/apache/flink/connector/hbase/util/HBaseTimestampGenerator.java: ## @@ -0,0 +1,54 @@ +/* + * Licensed t

[GitHub] [flink-connector-jdbc] snuyanzin commented on a diff in pull request #3: [FLINK-15462][connectors] Add Trino dialect

2023-05-24 Thread via GitHub
snuyanzin commented on code in PR #3: URL: https://github.com/apache/flink-connector-jdbc/pull/3#discussion_r1204401370 ## flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/dialect/trino/TrinoTableSinkITCase.java: ## @@ -0,0 +1,476 @@ +/* + * Licensed to the Ap

[GitHub] [flink-connector-jdbc] snuyanzin commented on a diff in pull request #3: [FLINK-15462][connectors] Add Trino dialect

2023-05-24 Thread via GitHub
snuyanzin commented on code in PR #3: URL: https://github.com/apache/flink-connector-jdbc/pull/3#discussion_r1204400124 ## flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/dialect/trino/TrinoPreparedStatementTest.java: ## @@ -0,0 +1,153 @@ +/* + * Licensed to

[GitHub] [flink-connector-jdbc] snuyanzin commented on a diff in pull request #3: [FLINK-15462][connectors] Add Trino dialect

2023-05-24 Thread via GitHub
snuyanzin commented on code in PR #3: URL: https://github.com/apache/flink-connector-jdbc/pull/3#discussion_r1204399015 ## flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/dialect/trino/TrinoDialectTypeTest.java: ## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apa

[GitHub] [flink-web] Thesharing commented on pull request #652: [FLINK-32051] Fix broken documentation links in Flink blogs

2023-05-24 Thread via GitHub
Thesharing commented on PR #652: URL: https://github.com/apache/flink-web/pull/652#issuecomment-1561376675 > This is indeed a good suggestion, but I haven't found where to place this prompt. 🤔 How about in [this page](https://flink.apache.org/how-to-contribute/improve-website/)? Its

[jira] [Comment Edited] (FLINK-32139) Data accidentally deleted and not deleted when upsert sink to hbase

2023-05-24 Thread LiuZeshan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17725853#comment-17725853 ] LiuZeshan edited comment on FLINK-32139 at 5/24/23 3:27 PM:

[GitHub] [flink-web] reswqa commented on pull request #652: [FLINK-32051] Fix broken documentation links in Flink blogs

2023-05-24 Thread via GitHub
reswqa commented on PR #652: URL: https://github.com/apache/flink-web/pull/652#issuecomment-1561370805 > However, currently there are 500+ usages of DocsBaseUrl in the blog posts. It's a bit exhausting to validate and review all these usages. Fair enough, only change `docs_link` is al

[jira] [Comment Edited] (FLINK-32139) Data accidentally deleted and not deleted when upsert sink to hbase

2023-05-24 Thread LiuZeshan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17725853#comment-17725853 ] LiuZeshan edited comment on FLINK-32139 at 5/24/23 3:25 PM:

[jira] [Commented] (FLINK-32139) Data accidentally deleted and not deleted when upsert sink to hbase

2023-05-24 Thread LiuZeshan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17725853#comment-17725853 ] LiuZeshan commented on FLINK-32139: --- By adding logs to HBase, the root cause of unexpe

[GitHub] [flink-connector-jdbc] snuyanzin commented on a diff in pull request #3: [FLINK-15462][connectors] Add Trino dialect

2023-05-24 Thread via GitHub
snuyanzin commented on code in PR #3: URL: https://github.com/apache/flink-connector-jdbc/pull/3#discussion_r1204377091 ## flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/dialect/trino/TrinoTableSourceITCase.java: ## @@ -0,0 +1,268 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-24257) Using Stateful Blue/Green Deployment to handle Application Evolvement

2023-05-24 Thread Kevin Lam (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17725851#comment-17725851 ] Kevin Lam commented on FLINK-24257: --- Hi! Interested in this, and blue-green deployment

[GitHub] [flink-connector-jdbc] snuyanzin commented on pull request #29: [FLINK-31551] Add support for CrateDB

2023-05-24 Thread via GitHub
snuyanzin commented on PR #29: URL: https://github.com/apache/flink-connector-jdbc/pull/29#issuecomment-1561356070 looks like different jna versions do not pass convergence check this command fails locally ``` mvn clean install -DskipTests -Dflink.convergence.phase=install -Pcheck-

[jira] [Updated] (FLINK-32139) Data accidentally deleted and not deleted when upsert sink to hbase

2023-05-24 Thread LiuZeshan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] LiuZeshan updated FLINK-32139: -- Attachment: image-2023-05-24-23-16-59-508.png > Data accidentally deleted and not deleted when upsert

[jira] [Updated] (FLINK-32139) Data accidentally deleted and not deleted when upsert sink to hbase

2023-05-24 Thread LiuZeshan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] LiuZeshan updated FLINK-32139: -- Attachment: aa.log > Data accidentally deleted and not deleted when upsert sink to hbase > ---

[jira] [Updated] (FLINK-32178) Proposal to set a WEB UI PATH for using AWS ALB INGRESS

2023-05-24 Thread Tan Kim (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tan Kim updated FLINK-32178: Summary: Proposal to set a WEB UI PATH for using AWS ALB INGRESS (was: Proposal to add the ability to set

[GitHub] [flink-connector-jdbc] matriv commented on pull request #29: [FLINK-31551] Add support for CrateDB

2023-05-24 Thread via GitHub
matriv commented on PR #29: URL: https://github.com/apache/flink-connector-jdbc/pull/29#issuecomment-1561343935 Any hints? locally I don't get such error. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Updated] (FLINK-32178) Proposal to add the ability to set a WEB UI PATH for using AWS ALB INGRESS

2023-05-24 Thread Tan Kim (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tan Kim updated FLINK-32178: Summary: Proposal to add the ability to set a WEB UI PATH for using AWS ALB INGRESS (was: AWS ALB INGRESS

[GitHub] [flink-connector-jdbc] snuyanzin commented on a diff in pull request #3: [FLINK-15462][connectors] Add Trino dialect

2023-05-24 Thread via GitHub
snuyanzin commented on code in PR #3: URL: https://github.com/apache/flink-connector-jdbc/pull/3#discussion_r1204347791 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/dialect/trino/TrinoDialect.java: ## @@ -0,0 +1,112 @@ +/* + * Licensed to the Apache Sof

[jira] [Updated] (FLINK-32139) Data accidentally deleted and not deleted when upsert sink to hbase

2023-05-24 Thread LiuZeshan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] LiuZeshan updated FLINK-32139: -- Attachment: image-2023-05-24-23-07-23-978.png > Data accidentally deleted and not deleted when upsert

[jira] [Updated] (FLINK-32178) AWS ALB INGRESS Support

2023-05-24 Thread Tan Kim (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tan Kim updated FLINK-32178: Description: Currently, the flink kubernetes operator only supports nginx ingress. [https://nightlies.apa

[jira] [Updated] (FLINK-32178) AWS ALB INGRESS Support

2023-05-24 Thread Tan Kim (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tan Kim updated FLINK-32178: Description: Currently, the flink kubernetes operator only supports nginx ingress. [https://nightlies.apa

[jira] [Updated] (FLINK-32178) AWS ALB INGRESS Support

2023-05-24 Thread Tan Kim (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tan Kim updated FLINK-32178: Component/s: Runtime / Web Frontend > AWS ALB INGRESS Support > --- > >

[jira] [Created] (FLINK-32178) AWS ALB INGRESS Support

2023-05-24 Thread Tan Kim (Jira)
Tan Kim created FLINK-32178: --- Summary: AWS ALB INGRESS Support Key: FLINK-32178 URL: https://issues.apache.org/jira/browse/FLINK-32178 Project: Flink Issue Type: Improvement Components: K

[jira] [Updated] (FLINK-32024) Short code related to externalized connector retrieve version from its own data yaml

2023-05-24 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-32024: --- Fix Version/s: jdbc-3.1.1 > Short code related to externalized connector retrieve version fr

[jira] [Updated] (FLINK-31793) Remove dependency on flink-shaded for flink-connector-jdbc

2023-05-24 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-31793: --- Fix Version/s: jdbc-3.2.0 > Remove dependency on flink-shaded for flink-connector-jdbc > ---

[GitHub] [flink] liuyongvs commented on pull request #22629: [FLINK-31664][table] Add ARRAY_INTERSECT function

2023-05-24 Thread via GitHub
liuyongvs commented on PR #22629: URL: https://github.com/apache/flink/pull/22629#issuecomment-1561317115 hi @dawidwys do you also help review it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Updated] (FLINK-31759) Update some external connectors to use sql_connector_download_table and connector_artifact shortcode

2023-05-24 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-31759: --- Fix Version/s: jdbc-3.1.1 > Update some external connectors to use sql_connector_download_ta

[GitHub] [flink] snuyanzin commented on a diff in pull request #22632: [FLINK-32161][test] Migrate and remove some legacy ExternalResource

2023-05-24 Thread via GitHub
snuyanzin commented on code in PR #22632: URL: https://github.com/apache/flink/pull/22632#discussion_r1204316795 ## flink-runtime/src/test/java/org/apache/flink/runtime/state/heap/HeapPriorityQueueTest.java: ## @@ -61,25 +62,25 @@ public void testToArray() { HeapP

[GitHub] [flink] reswqa commented on a diff in pull request #22632: [FLINK-32161][test] Migrate and remove some legacy ExternalResource

2023-05-24 Thread via GitHub
reswqa commented on code in PR #22632: URL: https://github.com/apache/flink/pull/22632#discussion_r1204306753 ## flink-tests/src/test/java/org/apache/flink/test/recovery/ProcessFailureCancelingITCase.java: ## @@ -214,12 +217,14 @@ public Long map(Long value) throws Exception {

[GitHub] [flink] reswqa commented on a diff in pull request #22632: [FLINK-32161][test] Migrate and remove some legacy ExternalResource

2023-05-24 Thread via GitHub
reswqa commented on code in PR #22632: URL: https://github.com/apache/flink/pull/22632#discussion_r1204305746 ## flink-runtime/src/test/java/org/apache/flink/runtime/state/TaskExecutorLocalStateStoresManagerTest.java: ## @@ -53,25 +53,26 @@ import static org.assertj.core.api.As

[GitHub] [flink] snuyanzin commented on a diff in pull request #22632: [FLINK-32161][test] Migrate and remove some legacy ExternalResource

2023-05-24 Thread via GitHub
snuyanzin commented on code in PR #22632: URL: https://github.com/apache/flink/pull/22632#discussion_r1204296614 ## flink-tests/src/test/java/org/apache/flink/test/recovery/ProcessFailureCancelingITCase.java: ## @@ -214,12 +217,14 @@ public Long map(Long value) throws Exception

  1   2   3   >