[GitHub] [flink] flinkbot commented on pull request #22878: [hotfix] [flink-parquet] Print stacktrace when reporting statistics failed

2023-06-26 Thread via GitHub
flinkbot commented on PR #22878: URL: https://github.com/apache/flink/pull/22878#issuecomment-1608903404 ## CI report: * dc4b8748c6ef7a58d50311fbc1335b5921dc3efb UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] jiaoqingbo commented on pull request #22878: [hotfix] [flink-parquet] Print stacktrace when reporting statistics failed

2023-06-26 Thread via GitHub
jiaoqingbo commented on PR #22878: URL: https://github.com/apache/flink/pull/22878#issuecomment-1608894779 @wanglijie95 very minor changes, please cc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink] jiaoqingbo opened a new pull request, #22878: [hotfix] [flink-parquet] Print stacktrace when reporting statistics failed

2023-06-26 Thread via GitHub
jiaoqingbo opened a new pull request, #22878: URL: https://github.com/apache/flink/pull/22878 ## What is the purpose of the change Print stacktrace when reporting statistics failed ## Brief change log Print stacktrace when reporting statistics failed

[GitHub] [flink] flinkbot commented on pull request #22877: Bump socket.io-parser and socket.io in /flink-runtime-web/web-dashboard

2023-06-26 Thread via GitHub
flinkbot commented on PR #22877: URL: https://github.com/apache/flink/pull/22877#issuecomment-160623 ## CI report: * d6b1bb85ba0d7f322e99ac87ab6c9f5a0d913e0d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-30859) Remove flink-connector-kafka from master branch

2023-06-26 Thread Tzu-Li (Gordon) Tai (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737472#comment-17737472 ] Tzu-Li (Gordon) Tai commented on FLINK-30859: - Merged via apache/flink:149a5

[jira] [Closed] (FLINK-30859) Remove flink-connector-kafka from master branch

2023-06-26 Thread Tzu-Li (Gordon) Tai (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai closed FLINK-30859. --- Fix Version/s: 1.18.0 Resolution: Fixed > Remove flink-connector-kafka from m

[GitHub] [flink] tzulitai commented on pull request #22797: [FLINK-30859] Remove all Kafka connector code from main repo

2023-06-26 Thread via GitHub
tzulitai commented on PR #22797: URL: https://github.com/apache/flink/pull/22797#issuecomment-1608881906 Merged via 149a5e34c1ed8d8943c901a98c65c70693915811 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [flink] dependabot[bot] closed pull request #22631: Bump socket.io-parser and socket.io in /flink-runtime-web/web-dashboard

2023-06-26 Thread via GitHub
dependabot[bot] closed pull request #22631: Bump socket.io-parser and socket.io in /flink-runtime-web/web-dashboard URL: https://github.com/apache/flink/pull/22631 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [flink] dependabot[bot] commented on pull request #22631: Bump socket.io-parser and socket.io in /flink-runtime-web/web-dashboard

2023-06-26 Thread via GitHub
dependabot[bot] commented on PR #22631: URL: https://github.com/apache/flink/pull/22631#issuecomment-1608881623 Superseded by #22877. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] dependabot[bot] opened a new pull request, #22877: Bump socket.io-parser and socket.io in /flink-runtime-web/web-dashboard

2023-06-26 Thread via GitHub
dependabot[bot] opened a new pull request, #22877: URL: https://github.com/apache/flink/pull/22877 Bumps [socket.io-parser](https://github.com/socketio/socket.io-parser) and [socket.io](https://github.com/socketio/socket.io). These dependencies needed to be updated together. Updates `soc

[jira] [Commented] (FLINK-32370) JDBC SQl gateway e2e test is unstable

2023-06-26 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737469#comment-17737469 ] Sergey Nuyanzin commented on FLINK-32370: - [~zjureel] , [~libenchao] could you p

[jira] [Commented] (FLINK-32444) Enable object reuse for Flink SQL jobs by default

2023-06-26 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737470#comment-17737470 ] Jark Wu commented on FLINK-32444: - cc [~lincoln.86xy], [~lsy], [~twalthr] what do you th

[jira] [Commented] (FLINK-32370) JDBC SQl gateway e2e test is unstable

2023-06-26 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737468#comment-17737468 ] Sergey Nuyanzin commented on FLINK-32370: - https://dev.azure.com/apache-flink/ap

[jira] [Created] (FLINK-32444) Enable object reuse for Flink SQL jobs by default

2023-06-26 Thread Jark Wu (Jira)
Jark Wu created FLINK-32444: --- Summary: Enable object reuse for Flink SQL jobs by default Key: FLINK-32444 URL: https://issues.apache.org/jira/browse/FLINK-32444 Project: Flink Issue Type: New Featu

[jira] [Commented] (FLINK-32441) DefaultSchedulerTest#testTriggerCheckpointAndCompletedAfterStore fails with timeout on AZP

2023-06-26 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737466#comment-17737466 ] Sergey Nuyanzin commented on FLINK-32441: - https://dev.azure.com/apache-flink/ap

[jira] [Commented] (FLINK-30774) Introduce flink-utils module

2023-06-26 Thread Alokh P (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737462#comment-17737462 ] Alokh P commented on FLINK-30774: - Hi folks. Would love to work on this in case we want

[jira] [Updated] (FLINK-30629) ClientHeartbeatTest.testJobRunningIfClientReportHeartbeat is unstable

2023-06-26 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-30629: Fix Version/s: 1.18.0 1.17.2 (was: 1.17.0) > Cli

[jira] [Resolved] (FLINK-30629) ClientHeartbeatTest.testJobRunningIfClientReportHeartbeat is unstable

2023-06-26 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin resolved FLINK-30629. - Resolution: Fixed Thanks [~Jiangang]  the pr merged, a couple of weeks ago and there is

[jira] [Assigned] (FLINK-30629) ClientHeartbeatTest.testJobRunningIfClientReportHeartbeat is unstable

2023-06-26 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin reassigned FLINK-30629: --- Assignee: Liu (was: Weijie Guo) > ClientHeartbeatTest.testJobRunningIfClientReport

[GitHub] [flink] snuyanzin commented on pull request #22834: [FLINK-32260]-table-Add-ARRAY_SLICE-function

2023-06-26 Thread via GitHub
snuyanzin commented on PR #22834: URL: https://github.com/apache/flink/pull/22834#issuecomment-1608860964 This is not complete e2e test to reproduce: 1. build the project e.g. `mvn clean install -DskipTests` from the project root folder 2. got to build-target `cd build-target`

[GitHub] [flink] wangyang0918 commented on a diff in pull request #22509: [FLINK-31983] Add yarn Acls capability to Flink containers

2023-06-26 Thread via GitHub
wangyang0918 commented on code in PR #22509: URL: https://github.com/apache/flink/pull/22509#discussion_r1243187163 ## flink-yarn/src/main/java/org/apache/flink/yarn/configuration/YarnConfigOptions.java: ## @@ -231,6 +231,31 @@ public class YarnConfigOptions {

[GitHub] [flink] 1996fanrui commented on a diff in pull request #22852: [FLINK-32420][connectors/common] Improve the watermark aggregation performance

2023-06-26 Thread via GitHub
1996fanrui commented on code in PR #22852: URL: https://github.com/apache/flink/pull/22852#discussion_r1243183753 ## flink-runtime/src/main/java/org/apache/flink/runtime/source/coordinator/SourceCoordinator.java: ## @@ -642,7 +643,32 @@ private static class WatermarkAggregator {

[GitHub] [flink] 1996fanrui commented on a diff in pull request #22845: [FLINK-32411][connector/common] Fix the bug about SourceCoordinator thread leaks

2023-06-26 Thread via GitHub
1996fanrui commented on code in PR #22845: URL: https://github.com/apache/flink/pull/22845#discussion_r1243180040 ## flink-runtime/src/main/java/org/apache/flink/runtime/source/coordinator/SourceCoordinator.java: ## @@ -270,8 +269,9 @@ public void start() throws Exception {

[GitHub] [flink] FangYongs commented on a diff in pull request #22832: [FLINK-32396][jdbc-driver] Support timestamp and timestamp_ltz for jdbc driver and sql gateway

2023-06-26 Thread via GitHub
FangYongs commented on code in PR #22832: URL: https://github.com/apache/flink/pull/22832#discussion_r1243176991 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/rest/serde/ResultInfo.java: ## @@ -57,19 +58,24 @@ public class ResultInfo { privat

[GitHub] [flink] wangyang0918 commented on pull request #22509: [FLINK-31983] Add yarn Acls capability to Flink containers

2023-06-26 Thread via GitHub
wangyang0918 commented on PR #22509: URL: https://github.com/apache/flink/pull/22509#issuecomment-1608825216 > Based on the [documentation](https://docs.cloudera.com/documentation/enterprise/6/6.3/topics/cm_mc_yarn_acl.html#concept_activate_yarn_ACLs) here, it looks like yarn.acl.enable sho

[jira] [Commented] (FLINK-32260) Add SLICE support in SQL & Table API

2023-06-26 Thread Hanyu Zheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737443#comment-17737443 ] Hanyu Zheng commented on FLINK-32260: - [~Sergey Nuyanzin] thank you for your suggest

[jira] [Commented] (FLINK-32263) Add ELT support in SQL & Table API

2023-06-26 Thread Hanyu Zheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737441#comment-17737441 ] Hanyu Zheng commented on FLINK-32263: - [~jark] Thank you but how f0 stand for mixed

[GitHub] [flink] PatrickRen commented on pull request #22867: [BP-1.16][FLINK-32392][ci] Invalidate Maven repo cache on Azure every year to reduce its disk usage

2023-06-26 Thread via GitHub
PatrickRen commented on PR #22867: URL: https://github.com/apache/flink/pull/22867#issuecomment-1608790353 @snuyanzin I don't think adding -U could help, as the root cause is actually ``` Could not transfer artifact org.opentest4j:opentest4j:jar:1.1.1 from/to google-maven-central

[jira] [Created] (FLINK-32443) Translate "State Processor API" page into Chinese

2023-06-26 Thread Yanfei Lei (Jira)
Yanfei Lei created FLINK-32443: -- Summary: Translate "State Processor API" page into Chinese Key: FLINK-32443 URL: https://issues.apache.org/jira/browse/FLINK-32443 Project: Flink Issue Type: Imp

[jira] [Assigned] (FLINK-32443) Translate "State Processor API" page into Chinese

2023-06-26 Thread Yanfei Lei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yanfei Lei reassigned FLINK-32443: -- Assignee: Yanfei Lei > Translate "State Processor API" page into Chinese > --

[GitHub] [flink] luoyuxia commented on a diff in pull request #22831: [FLINK-32388]Add the ability to pass parameters to CUSTOM PartitionCommitPolicy

2023-06-26 Thread via GitHub
luoyuxia commented on code in PR #22831: URL: https://github.com/apache/flink/pull/22831#discussion_r1243092293 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveTableSink.java: ## @@ -456,7 +456,8 @@ private DataStreamSink createBatchCo

[GitHub] [flink] hanyuzheng7 commented on pull request #22834: [FLINK-32260]-table-Add-ARRAY_SLICE-function

2023-06-26 Thread via GitHub
hanyuzheng7 commented on PR #22834: URL: https://github.com/apache/flink/pull/22834#issuecomment-1608743900 @snuyanzin for this two test cases ``` SELECT array_slice(array[1, 2, 3], -5, 1); SELECT array_slice(array[1, 2, 3], 1, -1); ``` I test it, it not fail with exception, th

[jira] [Assigned] (FLINK-28706) FLIP-248: Introduce dynamic partition pruning

2023-06-26 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin reassigned FLINK-28706: Assignee: godfrey he > FLIP-248: Introduce dynamic partition pruning > --

[jira] [Commented] (FLINK-19830) Properly implements processing-time temporal table join

2023-06-26 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737424#comment-17737424 ] Dong Lin commented on FLINK-19830: -- Hi [~rmetzger] [~jark] , FYI, FLIP-326 [https://cw

[jira] [Closed] (FLINK-32276) After adding the where condition to the flink lookup left join, the joinType becomes innerJoin

2023-06-26 Thread Xianxun Ye (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xianxun Ye closed FLINK-32276. -- Resolution: Not A Bug [~jark]  Thanks for your response. Make sense to me. > After adding the where c

[jira] [Commented] (FLINK-23190) Make task-slot allocation much more evenly

2023-06-26 Thread loyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737413#comment-17737413 ] loyi commented on FLINK-23190: -- [~heigebupahei]   Looking forward to your feedback. :)  

[GitHub] [flink] KarmaGYZ commented on a diff in pull request #22836: [FLINK-32191][netty] support set keepalive options to NettyClient.

2023-06-26 Thread via GitHub
KarmaGYZ commented on code in PR #22836: URL: https://github.com/apache/flink/pull/22836#discussion_r1243040416 ## flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/NettyClientTest.java: ## @@ -0,0 +1,115 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [flink] hanyuzheng7 commented on pull request #22785: [FLINK-32259]-table-Add-ARRAY_JOIN-function

2023-06-26 Thread via GitHub
hanyuzheng7 commented on PR #22785: URL: https://github.com/apache/flink/pull/22785#issuecomment-1608538200 @dawidwys I have already fixed all comments. You can do the second pass. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22785: [FLINK-32259]-table-Add-ARRAY_JOIN-function

2023-06-26 Thread via GitHub
hanyuzheng7 commented on code in PR #22785: URL: https://github.com/apache/flink/pull/22785#discussion_r1242997039 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/ArrayOfStringArgumentTypeStrategy.java: ## @@ -0,0 +1,84 @@ +/* +

[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22785: [FLINK-32259]-table-Add-ARRAY_JOIN-function

2023-06-26 Thread via GitHub
hanyuzheng7 commented on code in PR #22785: URL: https://github.com/apache/flink/pull/22785#discussion_r1242996736 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/BaseExpressions.java: ## @@ -1408,6 +1409,24 @@ public OutType arrayUnion(InTy

[GitHub] [flink] hanyuzheng7 commented on pull request #22730: [FLINK-32257]-table-Add-ARRAY_MAX-function

2023-06-26 Thread via GitHub
hanyuzheng7 commented on PR #22730: URL: https://github.com/apache/flink/pull/22730#issuecomment-1608534943 @dawidwys I have already fixed all comments. You can do the second pass. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [flink-web] snuyanzin commented on a diff in pull request #654: Add JDBC v3.1.1 for Flink 1.16.x and Flink 1.17.x

2023-06-26 Thread via GitHub
snuyanzin commented on code in PR #654: URL: https://github.com/apache/flink-web/pull/654#discussion_r1242939069 ## docs/data/release_archive.yml: ## @@ -482,6 +482,11 @@ release_archive: version: 3.0.1 release_date: 2023-05-09 filename: "gcp-pubsub" +-

[GitHub] [flink] snuyanzin commented on a diff in pull request #22558: [FLINK-28744][table] Upgrade Calcite to 1.31.0

2023-06-26 Thread via GitHub
snuyanzin commented on code in PR #22558: URL: https://github.com/apache/flink/pull/22558#discussion_r1242932736 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CastFunctionITCase.java: ## @@ -469,10 +469,10 @@ private static List allTyp

[jira] [Updated] (FLINK-28744) Upgrade Calcite version to 1.31

2023-06-26 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-28744: Release Note: Since in Calcite 1.31.0 there was fixed issue https://issues.apache.org/jir

[GitHub] [flink] snuyanzin commented on a diff in pull request #22558: [FLINK-28744][table] Upgrade Calcite to 1.31.0

2023-06-26 Thread via GitHub
snuyanzin commented on code in PR #22558: URL: https://github.com/apache/flink/pull/22558#discussion_r1242916945 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CastFunctionITCase.java: ## @@ -1132,22 +1132,14 @@ private static List nume

[GitHub] [flink] snuyanzin commented on a diff in pull request #22558: [FLINK-28744][table] Upgrade Calcite to 1.31.0

2023-06-26 Thread via GitHub
snuyanzin commented on code in PR #22558: URL: https://github.com/apache/flink/pull/22558#discussion_r1242916945 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CastFunctionITCase.java: ## @@ -1132,22 +1132,14 @@ private static List nume

[jira] [Commented] (FLINK-30719) flink-runtime-web failed due to a corrupted

2023-06-26 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737379#comment-17737379 ] Sergey Nuyanzin commented on FLINK-30719: - it looks like a maven-frontend-plugin

[jira] [Commented] (FLINK-30719) flink-runtime-web failed due to a corrupted

2023-06-26 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737376#comment-17737376 ] Sergey Nuyanzin commented on FLINK-30719: - https://dev.azure.com/apache-flink/ap

[jira] [Updated] (FLINK-30719) flink-runtime-web failed due to a corrupted

2023-06-26 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-30719: Affects Version/s: 1.18.0 > flink-runtime-web failed due to a corrupted > ---

[jira] [Updated] (FLINK-32442) DownloadPipelineArtifact fails on AZP

2023-06-26 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-32442: Description: DownloadPipelineArtifact fails on AZP {noformat} Starting: DownloadPipelineAr

[jira] [Created] (FLINK-32442) DownloadPipelineArtifact fails on AZP

2023-06-26 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-32442: --- Summary: DownloadPipelineArtifact fails on AZP Key: FLINK-32442 URL: https://issues.apache.org/jira/browse/FLINK-32442 Project: Flink Issue Type: Bug

[jira] [Commented] (FLINK-18356) flink-table-planner Exit code 137 returned from process

2023-06-26 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737371#comment-17737371 ] Sergey Nuyanzin commented on FLINK-18356: - https://dev.azure.com/apache-flink/ap

[jira] [Commented] (FLINK-32370) JDBC SQl gateway e2e test is unstable

2023-06-26 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737369#comment-17737369 ] Sergey Nuyanzin commented on FLINK-32370: - https://dev.azure.com/apache-flink/ap

[jira] [Commented] (FLINK-32370) JDBC SQl gateway e2e test is unstable

2023-06-26 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737368#comment-17737368 ] Sergey Nuyanzin commented on FLINK-32370: - https://dev.azure.com/apache-flink/ap

[jira] [Commented] (FLINK-32379) Skip archunit tests in java1X-target profiles

2023-06-26 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737367#comment-17737367 ] Sergey Nuyanzin commented on FLINK-32379: - [~chesnay] are you ok with {{@ArchTag

[jira] [Updated] (FLINK-32379) Skip archunit tests in java1X-target profiles

2023-06-26 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-32379: Labels: test-stability (was: ) > Skip archunit tests in java1X-target profiles >

[jira] [Commented] (FLINK-32379) Skip archunit tests in java1X-target profiles

2023-06-26 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737366#comment-17737366 ] Sergey Nuyanzin commented on FLINK-32379: - since it's failing ci builds on mirro

[jira] [Updated] (FLINK-32379) Skip archunit tests in java1X-target profiles

2023-06-26 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-32379: Priority: Critical (was: Major) > Skip archunit tests in java1X-target profiles > ---

[jira] [Commented] (FLINK-32370) JDBC SQl gateway e2e test is unstable

2023-06-26 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737365#comment-17737365 ] Sergey Nuyanzin commented on FLINK-32370: - https://dev.azure.com/apache-flink/ap

[jira] [Commented] (FLINK-32392) Several jobs failed on AZP with No space left on device

2023-06-26 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737364#comment-17737364 ] Sergey Nuyanzin commented on FLINK-32392: - 1.17.x: https://dev.azure.com/apache

[jira] [Created] (FLINK-32441) DefaultSchedulerTest#testTriggerCheckpointAndCompletedAfterStore fails with timeout on AZP

2023-06-26 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-32441: --- Summary: DefaultSchedulerTest#testTriggerCheckpointAndCompletedAfterStore fails with timeout on AZP Key: FLINK-32441 URL: https://issues.apache.org/jira/browse/FLINK-32441

[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22842: [FLINK-32261]-table-Add-MAP_UNION-function

2023-06-26 Thread via GitHub
hanyuzheng7 commented on code in PR #22842: URL: https://github.com/apache/flink/pull/22842#discussion_r1242874089 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/MapUnionFunction.java: ## @@ -0,0 +1,100 @@ +/* + * Licensed to the

[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22842: [FLINK-32261]-table-Add-MAP_UNION-function

2023-06-26 Thread via GitHub
hanyuzheng7 commented on code in PR #22842: URL: https://github.com/apache/flink/pull/22842#discussion_r1242867857 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/MapUnionFunction.java: ## @@ -0,0 +1,100 @@ +/* + * Licensed to the

[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22842: [FLINK-32261]-table-Add-MAP_UNION-function

2023-06-26 Thread via GitHub
hanyuzheng7 commented on code in PR #22842: URL: https://github.com/apache/flink/pull/22842#discussion_r1242867857 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/MapUnionFunction.java: ## @@ -0,0 +1,100 @@ +/* + * Licensed to the

[GitHub] [flink] snuyanzin commented on a diff in pull request #22842: [FLINK-32261]-table-Add-MAP_UNION-function

2023-06-26 Thread via GitHub
snuyanzin commented on code in PR #22842: URL: https://github.com/apache/flink/pull/22842#discussion_r1242863699 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/MapUnionFunction.java: ## @@ -0,0 +1,100 @@ +/* + * Licensed to the A

[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22842: [FLINK-32261]-table-Add-MAP_UNION-function

2023-06-26 Thread via GitHub
hanyuzheng7 commented on code in PR #22842: URL: https://github.com/apache/flink/pull/22842#discussion_r1242856919 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/MapUnionFunction.java: ## @@ -0,0 +1,100 @@ +/* + * Licensed to the

[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22842: [FLINK-32261]-table-Add-MAP_UNION-function

2023-06-26 Thread via GitHub
hanyuzheng7 commented on code in PR #22842: URL: https://github.com/apache/flink/pull/22842#discussion_r1242850416 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/MapUnionFunction.java: ## @@ -0,0 +1,100 @@ +/* + * Licensed to the

[GitHub] [flink] snuyanzin commented on a diff in pull request #22842: [FLINK-32261]-table-Add-MAP_UNION-function

2023-06-26 Thread via GitHub
snuyanzin commented on code in PR #22842: URL: https://github.com/apache/flink/pull/22842#discussion_r1242849867 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/MapUnionFunction.java: ## @@ -0,0 +1,100 @@ +/* + * Licensed to the A

[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22842: [FLINK-32261]-table-Add-MAP_UNION-function

2023-06-26 Thread via GitHub
hanyuzheng7 commented on code in PR #22842: URL: https://github.com/apache/flink/pull/22842#discussion_r1242838442 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/BaseExpressions.java: ## @@ -1423,6 +1424,16 @@ public OutType mapEntries() {

[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22842: [FLINK-32261]-table-Add-MAP_UNION-function

2023-06-26 Thread via GitHub
hanyuzheng7 commented on code in PR #22842: URL: https://github.com/apache/flink/pull/22842#discussion_r1242839050 ## docs/data/sql_functions.yml: ## @@ -649,6 +649,9 @@ collection: - sql: MAP_KEYS(map) table: MAP.mapKeys() description: Returns the keys of the map a

[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22842: [FLINK-32261]-table-Add-MAP_UNION-function

2023-06-26 Thread via GitHub
hanyuzheng7 commented on code in PR #22842: URL: https://github.com/apache/flink/pull/22842#discussion_r1242836983 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/MapUnionFunction.java: ## @@ -0,0 +1,100 @@ +/* + * Licensed to the

[GitHub] [flink] snuyanzin commented on a diff in pull request #22842: [FLINK-32261]-table-Add-MAP_UNION-function

2023-06-26 Thread via GitHub
snuyanzin commented on code in PR #22842: URL: https://github.com/apache/flink/pull/22842#discussion_r1242829756 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/MapUnionFunction.java: ## @@ -0,0 +1,100 @@ +/* + * Licensed to the A

[GitHub] [flink] snuyanzin commented on a diff in pull request #22842: [FLINK-32261]-table-Add-MAP_UNION-function

2023-06-26 Thread via GitHub
snuyanzin commented on code in PR #22842: URL: https://github.com/apache/flink/pull/22842#discussion_r1242829756 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/MapUnionFunction.java: ## @@ -0,0 +1,100 @@ +/* + * Licensed to the A

[jira] [Updated] (FLINK-32370) JDBC SQl gateway e2e test is unstable

2023-06-26 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-32370: Priority: Critical (was: Major) > JDBC SQl gateway e2e test is unstable > ---

[jira] [Updated] (FLINK-32370) JDBC SQl gateway e2e test is unstable

2023-06-26 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-32370: Labels: pull-request-available test-stability (was: pull-request-available) > JDBC SQl ga

[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22842: [FLINK-32261]-table-Add-MAP_UNION-function

2023-06-26 Thread via GitHub
hanyuzheng7 commented on code in PR #22842: URL: https://github.com/apache/flink/pull/22842#discussion_r1242823684 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/MapUnionFunction.java: ## @@ -0,0 +1,100 @@ +/* + * Licensed to the

[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22842: [FLINK-32261]-table-Add-MAP_UNION-function

2023-06-26 Thread via GitHub
hanyuzheng7 commented on code in PR #22842: URL: https://github.com/apache/flink/pull/22842#discussion_r1242823684 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/MapUnionFunction.java: ## @@ -0,0 +1,100 @@ +/* + * Licensed to the

[jira] [Reopened] (FLINK-32370) JDBC SQl gateway e2e test is unstable

2023-06-26 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin reopened FLINK-32370: - It seems the issue is still present mirror build is failing with it https://dev.azure.com/a

[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22842: [FLINK-32261]-table-Add-MAP_UNION-function

2023-06-26 Thread via GitHub
hanyuzheng7 commented on code in PR #22842: URL: https://github.com/apache/flink/pull/22842#discussion_r1242809920 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/CommonMapInputTypeStrategy.java: ## @@ -0,0 +1,113 @@ +/* + * Lice

[GitHub] [flink] snuyanzin commented on a diff in pull request #22842: [FLINK-32261]-table-Add-MAP_UNION-function

2023-06-26 Thread via GitHub
snuyanzin commented on code in PR #22842: URL: https://github.com/apache/flink/pull/22842#discussion_r1242783033 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/MapUnionFunction.java: ## @@ -0,0 +1,100 @@ +/* + * Licensed to the A

[GitHub] [flink] snuyanzin commented on a diff in pull request #22842: [FLINK-32261]-table-Add-MAP_UNION-function

2023-06-26 Thread via GitHub
snuyanzin commented on code in PR #22842: URL: https://github.com/apache/flink/pull/22842#discussion_r1242773854 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/CommonMapInputTypeStrategy.java: ## @@ -0,0 +1,113 @@ +/* + * Licens

[GitHub] [flink] snuyanzin commented on a diff in pull request #22842: [FLINK-32261]-table-Add-MAP_UNION-function

2023-06-26 Thread via GitHub
snuyanzin commented on code in PR #22842: URL: https://github.com/apache/flink/pull/22842#discussion_r1242769137 ## docs/data/sql_functions.yml: ## @@ -649,6 +649,9 @@ collection: - sql: MAP_KEYS(map) table: MAP.mapKeys() description: Returns the keys of the map as

[GitHub] [flink] snuyanzin commented on a diff in pull request #22842: [FLINK-32261]-table-Add-MAP_UNION-function

2023-06-26 Thread via GitHub
snuyanzin commented on code in PR #22842: URL: https://github.com/apache/flink/pull/22842#discussion_r1242768691 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/BaseExpressions.java: ## @@ -1423,6 +1424,16 @@ public OutType mapEntries() {

[GitHub] [flink] snuyanzin commented on a diff in pull request #22842: [FLINK-32261]-table-Add-MAP_UNION-function

2023-06-26 Thread via GitHub
snuyanzin commented on code in PR #22842: URL: https://github.com/apache/flink/pull/22842#discussion_r1242769137 ## docs/data/sql_functions.yml: ## @@ -649,6 +649,9 @@ collection: - sql: MAP_KEYS(map) table: MAP.mapKeys() description: Returns the keys of the map as

[GitHub] [flink] snuyanzin commented on a diff in pull request #22842: [FLINK-32261]-table-Add-MAP_UNION-function

2023-06-26 Thread via GitHub
snuyanzin commented on code in PR #22842: URL: https://github.com/apache/flink/pull/22842#discussion_r1242767973 ## flink-python/pyflink/table/expression.py: ## @@ -1528,6 +1528,18 @@ def map_keys(self) -> 'Expression': """ return _unary_op("mapKeys")(self) +

[GitHub] [flink] snuyanzin commented on a diff in pull request #22842: [FLINK-32261]-table-Add-MAP_UNION-function

2023-06-26 Thread via GitHub
snuyanzin commented on code in PR #22842: URL: https://github.com/apache/flink/pull/22842#discussion_r1242766634 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/MapUnionFunction.java: ## @@ -0,0 +1,100 @@ +/* + * Licensed to the A

[GitHub] [flink] snuyanzin commented on a diff in pull request #22842: [FLINK-32261]-table-Add-MAP_UNION-function

2023-06-26 Thread via GitHub
snuyanzin commented on code in PR #22842: URL: https://github.com/apache/flink/pull/22842#discussion_r1242765635 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/MapUnionFunction.java: ## @@ -0,0 +1,100 @@ +/* + * Licensed to the A

[GitHub] [flink] snuyanzin commented on a diff in pull request #22842: [FLINK-32261]-table-Add-MAP_UNION-function

2023-06-26 Thread via GitHub
snuyanzin commented on code in PR #22842: URL: https://github.com/apache/flink/pull/22842#discussion_r1242763657 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/MapUnionFunction.java: ## @@ -0,0 +1,100 @@ +/* + * Licensed to the A

[GitHub] [flink] afedulov commented on a diff in pull request #22850: [FLINK-28229][streaming-java] Source API alternatives for StreamExecutionEnvironment#fromCollection() methods

2023-06-26 Thread via GitHub
afedulov commented on code in PR #22850: URL: https://github.com/apache/flink/pull/22850#discussion_r1242728328 ## flink-connectors/flink-connector-datagen-test/pom.xml: ## @@ -0,0 +1,89 @@ + + +http://maven.apache.org/POM/4.0.0"; +xmlns:xsi="http://www.w3.org/20

[GitHub] [flink] flinkbot commented on pull request #22876: [FLINK-24911][table] Enable line numbers in SQL Client

2023-06-26 Thread via GitHub
flinkbot commented on PR #22876: URL: https://github.com/apache/flink/pull/22876#issuecomment-1608194141 ## CI report: * 0947cee642edb4e04f01db7797bacedd21878b55 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-24911) Enable line numbers in SQL Client

2023-06-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-24911: --- Labels: pull-request-available (was: ) > Enable line numbers in SQL Client > --

[GitHub] [flink] snuyanzin opened a new pull request, #22876: [FLINK-24911][table] Enable line numbers in SQL Client

2023-06-26 Thread via GitHub
snuyanzin opened a new pull request, #22876: URL: https://github.com/apache/flink/pull/22876 ## What is the purpose of the change The PR allows to have line numbers in SQL Client for multiline SQL. In fact line numbers are already implemented in JLine and the only thing the PR does

[GitHub] [flink] snuyanzin commented on pull request #22834: [FLINK-32260]-table-Add-ARRAY_SLICE-function

2023-06-26 Thread via GitHub
snuyanzin commented on PR #22834: URL: https://github.com/apache/flink/pull/22834#issuecomment-1608174310 Thanks for your contribution @hanyuzheng7 i left some comments besides that 1. There should be added doc to chinese version of doc 2. The PR should be rebased to resolve con

[jira] [Comment Edited] (FLINK-32260) Add SLICE support in SQL & Table API

2023-06-26 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737329#comment-17737329 ] Sergey Nuyanzin edited comment on FLINK-32260 at 6/26/23 8:08 PM:

[jira] [Comment Edited] (FLINK-32260) Add SLICE support in SQL & Table API

2023-06-26 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737329#comment-17737329 ] Sergey Nuyanzin edited comment on FLINK-32260 at 6/26/23 8:05 PM:

[jira] [Comment Edited] (FLINK-32260) Add SLICE support in SQL & Table API

2023-06-26 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737329#comment-17737329 ] Sergey Nuyanzin edited comment on FLINK-32260 at 6/26/23 8:04 PM:

[jira] [Comment Edited] (FLINK-32260) Add SLICE support in SQL & Table API

2023-06-26 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737329#comment-17737329 ] Sergey Nuyanzin edited comment on FLINK-32260 at 6/26/23 8:02 PM:

[jira] [Commented] (FLINK-32260) Add SLICE support in SQL & Table API

2023-06-26 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737329#comment-17737329 ] Sergey Nuyanzin commented on FLINK-32260: - I would suggest to change behavior of

[GitHub] [flink] snuyanzin commented on a diff in pull request #22834: [FLINK-32260]-table-Add-ARRAY_SLICE-function

2023-06-26 Thread via GitHub
snuyanzin commented on code in PR #22834: URL: https://github.com/apache/flink/pull/22834#discussion_r1242654328 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArraySliceFunction.java: ## @@ -0,0 +1,77 @@ +/* + * Licensed to the

[GitHub] [flink] snuyanzin commented on a diff in pull request #22834: [FLINK-32260]-table-Add-ARRAY_SLICE-function

2023-06-26 Thread via GitHub
snuyanzin commented on code in PR #22834: URL: https://github.com/apache/flink/pull/22834#discussion_r1242650686 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CollectionFunctionsITCase.java: ## @@ -417,6 +418,173 @@ private Stream arra

  1   2   3   >