wanglijie95 commented on code in PR #22674:
URL: https://github.com/apache/flink/pull/22674#discussion_r1246130385
##
flink-core/src/main/java/org/apache/flink/configuration/JobManagerOptions.java:
##
@@ -717,6 +717,18 @@ public boolean isOnlyConsumeFinishedPartition() {
[
https://issues.apache.org/jira/browse/FLINK-32447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738359#comment-17738359
]
lincoln lee commented on FLINK-32447:
-
fixed in 1.17: 8da3785d798cc6111f463ee1665ff62a42098274
>
[
https://issues.apache.org/jira/browse/FLINK-32447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
lincoln lee closed FLINK-32447.
---
> table hints lost when they inside a view referenced by an external query
>
lincoln-lil merged PR #22896:
URL: https://github.com/apache/flink/pull/22896
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
flinkbot commented on PR #22899:
URL: https://github.com/apache/flink/pull/22899#issuecomment-1612406491
## CI report:
* 0c19bafde27a471d3d72cfdd30eae9efe435cbba UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
flinkbot commented on PR #22898:
URL: https://github.com/apache/flink/pull/22898#issuecomment-1612406045
## CI report:
* 10c6617d03fccd44144d1d80ddc58ca0d52fc733 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
[
https://issues.apache.org/jira/browse/FLINK-30596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738358#comment-17738358
]
Mohsen Rezaei edited comment on FLINK-30596 at 6/29/23 4:12 AM:
I've
[
https://issues.apache.org/jira/browse/FLINK-30596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738358#comment-17738358
]
Mohsen Rezaei commented on FLINK-30596:
---
I've backported the fix for 1.17 and 1.16 are posted.
mohsenrezaeithe commented on PR #22899:
URL: https://github.com/apache/flink/pull/22899#issuecomment-1612404438
@zentol PTAL for 1.16 backport.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
mohsenrezaeithe opened a new pull request, #22899:
URL: https://github.com/apache/flink/pull/22899
Related to https://github.com/apache/flink/pull/22898, backporting to Flink
1.16 release.
(cherry picked from commit b528d9b81c03345c0415490fc41e27968313e5f0)
## What is the purpose
mohsenrezaeithe commented on PR #22898:
URL: https://github.com/apache/flink/pull/22898#issuecomment-1612401870
@zentol PTAL for 1.17 backport.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
mohsenrezaeithe opened a new pull request, #22898:
URL: https://github.com/apache/flink/pull/22898
Related to https://github.com/apache/flink/pull/21849, backporting to Flink
1.17 release.
(cherry picked from commit b528d9b81c03345c0415490fc41e27968313e5f0)
## What is the purpose
TanYuxin-tyx commented on PR #22833:
URL: https://github.com/apache/flink/pull/22833#issuecomment-1612392096
@xintongsong @reswqa Thanks for the careful review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
LoveHeat commented on code in PR #22806:
URL: https://github.com/apache/flink/pull/22806#discussion_r1246058742
##
flink-runtime/src/main/java/org/apache/flink/runtime/source/coordinator/SourceCoordinator.java:
##
@@ -195,9 +195,19 @@ void announceCombinedWatermark() {
zoltar9264 commented on code in PR #22669:
URL: https://github.com/apache/flink/pull/22669#discussion_r1246058692
##
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/snapshot/RocksNativeFullSnapshotStrategy.java:
##
@@
[
https://issues.apache.org/jira/browse/FLINK-17398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
luoyuxia closed FLINK-17398.
Resolution: Fixed
master:
ccb8e9f291dd3fa8cab845d2dc6dc78a761a6cb6
Thanks [~ruanhang1993] for thr pr.
[
https://issues.apache.org/jira/browse/FLINK-17398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
luoyuxia updated FLINK-17398:
-
Summary: Filesystem support regex path reading (was: Filesystem support
flexible path reading)
>
luoyuxia commented on PR #22249:
URL: https://github.com/apache/flink/pull/22249#issuecomment-1612381479
Thanks all. Merge it now. Feel free to left comment if you have other
concern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
[
https://issues.apache.org/jira/browse/FLINK-32234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
luoyuxia closed FLINK-32234.
Resolution: Fixed
master:
300902016bd41961f28dacdd9b5fd028b8edb925
zoltar9264 commented on code in PR #22669:
URL: https://github.com/apache/flink/pull/22669#discussion_r1246048717
##
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/snapshot/RocksDBSnapshotStrategyBase.java:
##
@@ -390,23
flinkbot commented on PR #22897:
URL: https://github.com/apache/flink/pull/22897#issuecomment-1612374730
## CI report:
* 96a57bc9a2afa4e8af42fdcb9a454b96dfef6055 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
FangYongs commented on code in PR #22882:
URL: https://github.com/apache/flink/pull/22882#discussion_r1246045200
##
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/AbstractHandler.java:
##
@@ -268,10 +266,7 @@ private CompletableFuture handleException(
chucheng92 commented on PR #21442:
URL: https://github.com/apache/flink/pull/21442#issuecomment-1612372450
@MartijnVisser hi, Martijn,
https://issues.apache.org/jira/browse/FLINK-30859 has been resolved. Can you
help me to check this pr?
--
This is an automated message from the Apache
[
https://issues.apache.org/jira/browse/FLINK-32477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-32477:
---
Labels: pull-request-available (was: )
> flink-connector-jdbc Fixed missing words in
baxinyu closed pull request #65: [FLINK-32477] Fixed missing words in
documentation
URL: https://github.com/apache/flink-connector-jdbc/pull/65
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/FLINK-32476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-32476:
---
Labels: pull-request-available (was: )
> Support configuring object-reuse for internal
Sxnan opened a new pull request, #22897:
URL: https://github.com/apache/flink/pull/22897
## What is the purpose of the change
This PR allows the internal operators to report whether the operators will
modify the input so that Flink can decide whether to enable object-reuse for
the
luoyuxia commented on PR #22696:
URL: https://github.com/apache/flink/pull/22696#issuecomment-1612369534
@Tartarus0zm Thanks for reviewing...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
luoyuxia closed pull request #22696: [FLINK-32234][table] Support execute
truncate table statement
URL: https://github.com/apache/flink/pull/22696
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
zoltar9264 commented on code in PR #22669:
URL: https://github.com/apache/flink/pull/22669#discussion_r1246040024
##
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/snapshot/RocksIncrementalSnapshotStrategy.java:
##
@@
zoltar9264 commented on code in PR #22669:
URL: https://github.com/apache/flink/pull/22669#discussion_r1246040024
##
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/snapshot/RocksIncrementalSnapshotStrategy.java:
##
@@
zoltar9264 commented on code in PR #22669:
URL: https://github.com/apache/flink/pull/22669#discussion_r1246033453
##
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/snapshot/RocksIncrementalSnapshotStrategy.java:
##
@@
zoltar9264 commented on code in PR #22669:
URL: https://github.com/apache/flink/pull/22669#discussion_r1246032593
##
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/snapshot/RocksDBSnapshotStrategyBase.java:
##
@@ -390,23
zoltar9264 commented on code in PR #22669:
URL: https://github.com/apache/flink/pull/22669#discussion_r1246031733
##
flink-runtime/src/main/java/org/apache/flink/runtime/state/IncrementalKeyedStateHandle.java:
##
@@ -32,9 +36,62 @@ public interface IncrementalKeyedStateHandle
[
https://issues.apache.org/jira/browse/FLINK-32283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Weijie Guo closed FLINK-32283.
--
Resolution: Done
master(1.18) via 7466df0c3c52851b7b1b9bca9c441dda22d66d2f.
> Implement
reswqa merged PR #22833:
URL: https://github.com/apache/flink/pull/22833
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
zoltar9264 commented on code in PR #22669:
URL: https://github.com/apache/flink/pull/22669#discussion_r1246030055
##
flink-runtime/src/main/java/org/apache/flink/runtime/state/SharedStateRegistryImpl.java:
##
@@ -122,37 +121,20 @@ public StreamStateHandle registerReference(
zoltar9264 commented on code in PR #22669:
URL: https://github.com/apache/flink/pull/22669#discussion_r1246030055
##
flink-runtime/src/main/java/org/apache/flink/runtime/state/SharedStateRegistryImpl.java:
##
@@ -122,37 +121,20 @@ public StreamStateHandle registerReference(
LoveHeat commented on code in PR #22806:
URL: https://github.com/apache/flink/pull/22806#discussion_r1246023522
##
flink-runtime/src/test/java/org/apache/flink/runtime/source/coordinator/SourceCoordinatorAlignmentTest.java:
##
@@ -131,6 +133,34 @@ void
baxinyu created FLINK-32477:
---
Summary: flink-connector-jdbc Fixed missing words in documentation
Key: FLINK-32477
URL: https://issues.apache.org/jira/browse/FLINK-32477
Project: Flink
Issue Type:
Xuannan Su created FLINK-32476:
--
Summary: Support configuring object-reuse for internal operators
Key: FLINK-32476
URL: https://issues.apache.org/jira/browse/FLINK-32476
Project: Flink
Issue
luoyuxia commented on PR #22821:
URL: https://github.com/apache/flink/pull/22821#issuecomment-1612350519
@LadyForest Thanks for your reviewing. I have addressed you comments. PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
[
https://issues.apache.org/jira/browse/FLINK-32411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rui Fan resolved FLINK-32411.
-
Fix Version/s: 1.18.0
1.16.3
1.17.2
Resolution: Fixed
>
[
https://issues.apache.org/jira/browse/FLINK-32411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738344#comment-17738344
]
Rui Fan commented on FLINK-32411:
-
Merged
876b1ec262f6c442e4bf87c9a5f83811e90e2805
1.17:
luoyuxia commented on code in PR #22821:
URL: https://github.com/apache/flink/pull/22821#discussion_r1246020576
##
flink-table/flink-table-common/src/main/java/org/apache/flink/table/annotation/ProcedureHint.java:
##
@@ -0,0 +1,149 @@
+/*
+ * Licensed to the Apache Software
fredia commented on code in PR #22801:
URL: https://github.com/apache/flink/pull/22801#discussion_r1246014010
##
flink-test-utils-parent/flink-test-utils/pom.xml:
##
@@ -133,6 +133,19 @@ under the License.
+
+
luoyuxia commented on code in PR #22821:
URL: https://github.com/apache/flink/pull/22821#discussion_r1246019486
##
flink-table/flink-table-common/src/main/java/org/apache/flink/table/procedures/Procedure.java:
##
@@ -0,0 +1,117 @@
+/*
+ * Licensed to the Apache Software
1996fanrui merged PR #22845:
URL: https://github.com/apache/flink/pull/22845
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
1996fanrui commented on PR #22845:
URL: https://github.com/apache/flink/pull/22845#issuecomment-1612345898
Thanks @pnowojski and @RocMarshal 's review, merging~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
TanYuxin-tyx commented on PR #22833:
URL: https://github.com/apache/flink/pull/22833#issuecomment-1612313953
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
[
https://issues.apache.org/jira/browse/FLINK-32457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
lincoln lee updated FLINK-32457:
Fix Version/s: 1.18.0
> update current documentation of JSON_OBJECTAGG/JSON_ARRAYAGG to clarify
liuyongvs commented on PR #22745:
URL: https://github.com/apache/flink/pull/22745#issuecomment-1612310881
@snuyanzin fix your reviews, thanks for your review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
[
https://issues.apache.org/jira/browse/FLINK-32473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
luoyuxia reassigned FLINK-32473:
Assignee: Feng Jin
> Introduce base interfaces for time travel
>
hanyuzheng7 commented on PR #22730:
URL: https://github.com/apache/flink/pull/22730#issuecomment-1612263031
@dawidwys, I have address the two minor comments and rebase on top of the
current master. It's ready to merge. Thank you.
--
This is an automated message from the Apache Git
snuyanzin commented on code in PR #22745:
URL: https://github.com/apache/flink/pull/22745#discussion_r1245830466
##
docs/data/sql_functions.yml:
##
@@ -658,6 +658,9 @@ collection:
- sql: MAP_FROM_ARRAYS(array_of_keys, array_of_values)
table: mapFromArrays(array_of_keys,
snuyanzin commented on code in PR #22745:
URL: https://github.com/apache/flink/pull/22745#discussion_r1245789357
##
docs/data/sql_functions.yml:
##
@@ -658,6 +658,9 @@ collection:
- sql: MAP_FROM_ARRAYS(array_of_keys, array_of_values)
table: mapFromArrays(array_of_keys,
[
https://issues.apache.org/jira/browse/FLINK-32261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738294#comment-17738294
]
Hanyu Zheng commented on FLINK-32261:
-
[~Sergey Nuyanzin] I have already updated the map_union
snuyanzin commented on PR #22834:
URL: https://github.com/apache/flink/pull/22834#issuecomment-1612077473
thanks I will have a look tomorrow
from the changed fileset it seems that this comment was missed
>There should be added doc to chinese version of doc
--
This is an
hanyuzheng7 commented on PR #22834:
URL: https://github.com/apache/flink/pull/22834#issuecomment-1612074689
@snuyanzin I have already solve all the comments, could you please do the
second code review. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to
snuyanzin commented on PR #22624:
URL: https://github.com/apache/flink/pull/22624#issuecomment-1612073732
@zhougit86 sorry for the late response
I have a question: could you please clarify it
it seems your change is inside condition
```scala
if
snuyanzin merged PR #22876:
URL: https://github.com/apache/flink/pull/22876
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/FLINK-32260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hanyu Zheng updated FLINK-32260:
Description:
Implement the array_slice function to extract a subset of elements from an
array.
snuyanzin commented on PR #22876:
URL: https://github.com/apache/flink/pull/22876#issuecomment-1612017197
Thanks for taking a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
[
https://issues.apache.org/jira/browse/FLINK-32260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hanyu Zheng updated FLINK-32260:
Description:
Implement the array_slice function to extract a subset of elements from an
array.
[
https://issues.apache.org/jira/browse/FLINK-32260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hanyu Zheng updated FLINK-32260:
Description:
Implement the array_slice function to extract a subset of elements from an
array.
snuyanzin commented on PR #22892:
URL: https://github.com/apache/flink/pull/22892#issuecomment-1611983845
thanks for notifying.
I checked it against our internal projects, also checked it against
flink-connectors (cherry-picked to 1.15 where most of connectors still were in
same repo).
1996fanrui commented on code in PR #22852:
URL: https://github.com/apache/flink/pull/22852#discussion_r1245546244
##
flink-runtime/src/main/java/org/apache/flink/runtime/source/coordinator/SourceCoordinator.java:
##
@@ -631,8 +631,9 @@ private void ensureStarted() {
}
1996fanrui commented on code in PR #22852:
URL: https://github.com/apache/flink/pull/22852#discussion_r1245546244
##
flink-runtime/src/main/java/org/apache/flink/runtime/source/coordinator/SourceCoordinator.java:
##
@@ -631,8 +631,9 @@ private void ensureStarted() {
}
pnowojski commented on code in PR #22806:
URL: https://github.com/apache/flink/pull/22806#discussion_r1245507575
##
flink-runtime/src/main/java/org/apache/flink/runtime/source/coordinator/SourceCoordinator.java:
##
@@ -195,9 +195,19 @@ void announceCombinedWatermark() {
[
https://issues.apache.org/jira/browse/FLINK-32428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738208#comment-17738208
]
Feng Jin commented on FLINK-32428:
--
[~Leonard] I would like to take this, please assign this task to me
[
https://issues.apache.org/jira/browse/FLINK-32473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738207#comment-17738207
]
Feng Jin commented on FLINK-32473:
--
[~luoyuxia] I would like to take this, please assign this task to
Feng Jin created FLINK-32475:
Summary: Add doc for time travel
Key: FLINK-32475
URL: https://issues.apache.org/jira/browse/FLINK-32475
Project: Flink
Issue Type: Sub-task
Reporter:
Feng Jin created FLINK-32474:
Summary: Support time travel in table planner
Key: FLINK-32474
URL: https://issues.apache.org/jira/browse/FLINK-32474
Project: Flink
Issue Type: Sub-task
Feng Jin created FLINK-32473:
Summary: Introduce base interfaces for time travel
Key: FLINK-32473
URL: https://issues.apache.org/jira/browse/FLINK-32473
Project: Flink
Issue Type: Sub-task
Feng Jin created FLINK-32472:
Summary: FLIP-308: Support Time Travel
Key: FLINK-32472
URL: https://issues.apache.org/jira/browse/FLINK-32472
Project: Flink
Issue Type: New Feature
[
https://issues.apache.org/jira/browse/FLINK-32260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738199#comment-17738199
]
Hanyu Zheng commented on FLINK-32260:
-
Google cloud's array_slice is 0-base, so our start_offset and
hanyuzheng7 commented on code in PR #22785:
URL: https://github.com/apache/flink/pull/22785#discussion_r1245458862
##
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArrayJoinFunction.java:
##
@@ -0,0 +1,104 @@
+/*
+ * Licensed to
hanyuzheng7 commented on code in PR #22785:
URL: https://github.com/apache/flink/pull/22785#discussion_r1245439050
##
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/ArrayOfStringArgumentTypeStrategy.java:
##
@@ -0,0 +1,72 @@
+/*
+
[
https://issues.apache.org/jira/browse/FLINK-32465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gabor Somogyi closed FLINK-32465.
-
Fix Version/s: 1.18.0
1.17.2
Resolution: Fixed
>
[
https://issues.apache.org/jira/browse/FLINK-32465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738124#comment-17738124
]
Gabor Somogyi edited comment on FLINK-32465 at 6/28/23 3:51 PM:
e33875e
gaborgsomogyi merged PR #22889:
URL: https://github.com/apache/flink/pull/22889
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/FLINK-30596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738183#comment-17738183
]
Chesnay Schepler edited comment on FLINK-30596 at 6/28/23 3:46 PM:
---
[
https://issues.apache.org/jira/browse/FLINK-30596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738183#comment-17738183
]
Chesnay Schepler commented on FLINK-30596:
--
master: b528d9b81c03345c0415490fc41e27968313e5f0
>
zentol merged PR #21849:
URL: https://github.com/apache/flink/pull/21849
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
hanyuzheng7 commented on code in PR #22730:
URL: https://github.com/apache/flink/pull/22730#discussion_r1245417236
##
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/ArrayComparableElementTypeStrategy.java:
##
@@ -0,0 +1,147 @@
+/*
hanyuzheng7 commented on code in PR #22730:
URL: https://github.com/apache/flink/pull/22730#discussion_r1245392043
##
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/ComparabilityUtils.java:
##
@@ -0,0 +1,67 @@
+/*
+ * Licensed to
hanyuzheng7 commented on code in PR #22730:
URL: https://github.com/apache/flink/pull/22730#discussion_r1245391760
##
flink-table/flink-table-common/src/test/java/org/apache/flink/table/types/inference/strategies/ArrayElementOutputTypeStrategyTest.java:
##
@@ -0,0 +1,43 @@
+/*
[
https://issues.apache.org/jira/browse/FLINK-32260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738170#comment-17738170
]
Sergey Nuyanzin commented on FLINK-32260:
-
if it's clearly mentioned in doc i'm ok with that
>
zentol commented on code in PR #22883:
URL: https://github.com/apache/flink/pull/22883#discussion_r1245368209
##
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/allocator/SlotSharingSlotAllocator.java:
##
@@ -78,31 +80,54 @@ public ResourceCounter
XComp commented on code in PR #22661:
URL: https://github.com/apache/flink/pull/22661#discussion_r1245365276
##
flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/TestingLeaderElectionDriver.java:
##
@@ -19,147 +19,347 @@
package
LadyForest commented on code in PR #22821:
URL: https://github.com/apache/flink/pull/22821#discussion_r1245293108
##
flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/exceptions/ProcedureNotExistException.java:
##
@@ -0,0 +1,37 @@
+/*
+ * Licensed to
[
https://issues.apache.org/jira/browse/FLINK-32260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738158#comment-17738158
]
Hanyu Zheng edited comment on FLINK-32260 at 6/28/23 2:53 PM:
--
[~Sergey
[
https://issues.apache.org/jira/browse/FLINK-32260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738158#comment-17738158
]
Hanyu Zheng edited comment on FLINK-32260 at 6/28/23 2:52 PM:
--
[~Sergey
[
https://issues.apache.org/jira/browse/FLINK-32260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738158#comment-17738158
]
Hanyu Zheng edited comment on FLINK-32260 at 6/28/23 2:51 PM:
--
[~Sergey
XComp commented on code in PR #22661:
URL: https://github.com/apache/flink/pull/22661#discussion_r1245351965
##
flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/TestingLeaderElectionDriver.java:
##
@@ -19,147 +19,347 @@
package
dawidwys commented on code in PR #22785:
URL: https://github.com/apache/flink/pull/22785#discussion_r1245352800
##
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArrayJoinFunction.java:
##
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the
dawidwys commented on code in PR #22785:
URL: https://github.com/apache/flink/pull/22785#discussion_r1245352800
##
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArrayJoinFunction.java:
##
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the
XComp commented on code in PR #22661:
URL: https://github.com/apache/flink/pull/22661#discussion_r1245352257
##
flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/TestingLeaderElectionDriver.java:
##
@@ -19,147 +19,347 @@
package
XComp commented on code in PR #22661:
URL: https://github.com/apache/flink/pull/22661#discussion_r1245351965
##
flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/TestingLeaderElectionDriver.java:
##
@@ -19,147 +19,347 @@
package
[
https://issues.apache.org/jira/browse/FLINK-32260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738158#comment-17738158
]
Hanyu Zheng commented on FLINK-32260:
-
[~Sergey Nuyanzin] I think we can treat 0 as 1 to achieve our
1 - 100 of 286 matches
Mail list logo
