[GitHub] [flink] XComp commented on a diff in pull request #23296: [FLINK-32751][collect] Fixes race condition between close and request handling processes in CollectSinkOperatorCoordinator

2023-08-28 Thread via GitHub
XComp commented on code in PR #23296: URL: https://github.com/apache/flink/pull/23296#discussion_r1308291020 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/collect/CollectSinkOperatorCoordinator.java: ## @@ -152,9 +176,11 @@ private CoordinationRe

[GitHub] [flink] XComp commented on a diff in pull request #23296: [FLINK-32751][collect] Fixes race condition between close and request handling processes in CollectSinkOperatorCoordinator

2023-08-28 Thread via GitHub
XComp commented on code in PR #23296: URL: https://github.com/apache/flink/pull/23296#discussion_r1308278198 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/collect/CollectSinkOperatorCoordinator.java: ## @@ -83,7 +104,10 @@ public void start() thr

[GitHub] [flink] XComp commented on a diff in pull request #23296: [FLINK-32751][collect] Fixes race condition between close and request handling processes in CollectSinkOperatorCoordinator

2023-08-28 Thread via GitHub
XComp commented on code in PR #23296: URL: https://github.com/apache/flink/pull/23296#discussion_r1308288979 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/collect/CollectSinkOperatorCoordinatorTest.java: ## @@ -173,72 +174,192 @@ private static v

[GitHub] [flink] XComp commented on a diff in pull request #23296: [FLINK-32751][collect] Fixes race condition between close and request handling processes in CollectSinkOperatorCoordinator

2023-08-28 Thread via GitHub
XComp commented on code in PR #23296: URL: https://github.com/apache/flink/pull/23296#discussion_r1308287200 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/collect/CollectSinkOperatorCoordinatorTest.java: ## @@ -105,54 +102,147 @@ void testCloseAf

[GitHub] [flink] XComp commented on a diff in pull request #23296: [FLINK-32751][collect] Fixes race condition between close and request handling processes in CollectSinkOperatorCoordinator

2023-08-28 Thread via GitHub
XComp commented on code in PR #23296: URL: https://github.com/apache/flink/pull/23296#discussion_r1308286524 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/collect/CollectSinkOperatorCoordinatorTest.java: ## @@ -105,54 +102,147 @@ void testCloseAf

[jira] [Commented] (FLINK-32488) Introduce configuration to control ExecutionGraph cache in REST API

2023-08-28 Thread Yangze Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759841#comment-17759841 ] Yangze Guo commented on FLINK-32488: I reassign it to [~xiangyu0xf] since there is n

[jira] [Assigned] (FLINK-32488) Introduce configuration to control ExecutionGraph cache in REST API

2023-08-28 Thread Yangze Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yangze Guo reassigned FLINK-32488: -- Assignee: xiangyu feng > Introduce configuration to control ExecutionGraph cache in REST API

[GitHub] [flink] XComp commented on a diff in pull request #23296: [FLINK-32751][collect] Fixes race condition between close and request handling processes in CollectSinkOperatorCoordinator

2023-08-28 Thread via GitHub
XComp commented on code in PR #23296: URL: https://github.com/apache/flink/pull/23296#discussion_r1308284339 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/collect/CollectSinkOperatorCoordinatorTest.java: ## @@ -105,54 +102,147 @@ void testCloseAf

[GitHub] [flink] luoyuxia closed pull request #22824: Flink 32352

2023-08-28 Thread via GitHub
luoyuxia closed pull request #22824: Flink 32352 URL: https://github.com/apache/flink/pull/22824 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-

[GitHub] [flink] luoyuxia closed pull request #22885: Flink 31575 hive 3

2023-08-28 Thread via GitHub
luoyuxia closed pull request #22885: Flink 31575 hive 3 URL: https://github.com/apache/flink/pull/22885 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] XComp commented on a diff in pull request #23296: [FLINK-32751][collect] Fixes race condition between close and request handling processes in CollectSinkOperatorCoordinator

2023-08-28 Thread via GitHub
XComp commented on code in PR #23296: URL: https://github.com/apache/flink/pull/23296#discussion_r1308281432 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/collect/CollectSinkOperatorCoordinatorTest.java: ## @@ -105,54 +102,147 @@ void testCloseAf

[GitHub] [flink] XComp commented on a diff in pull request #23296: [FLINK-32751][collect] Fixes race condition between close and request handling processes in CollectSinkOperatorCoordinator

2023-08-28 Thread via GitHub
XComp commented on code in PR #23296: URL: https://github.com/apache/flink/pull/23296#discussion_r1308280794 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/collect/CollectSinkOperatorCoordinatorTest.java: ## @@ -105,54 +102,147 @@ void testCloseAf

[GitHub] [flink] XComp commented on a diff in pull request #23296: [FLINK-32751][collect] Fixes race condition between close and request handling processes in CollectSinkOperatorCoordinator

2023-08-28 Thread via GitHub
XComp commented on code in PR #23296: URL: https://github.com/apache/flink/pull/23296#discussion_r1308279128 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/collect/CollectSinkOperatorCoordinator.java: ## @@ -152,9 +176,11 @@ private CoordinationRe

[jira] [Commented] (FLINK-32955) Support state compatibility between enabling TTL and disabling TTL

2023-08-28 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759840#comment-17759840 ] Yun Tang commented on FLINK-32955: -- +1 for this improvement, especially for setting the

[jira] [Updated] (FLINK-32955) Support state compatibility between enabling TTL and disabling TTL

2023-08-28 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang updated FLINK-32955: - Priority: Major (was: Minor) > Support state compatibility between enabling TTL and disabling TTL > ---

[GitHub] [flink] XComp commented on a diff in pull request #23296: [FLINK-32751][collect] Fixes race condition between close and request handling processes in CollectSinkOperatorCoordinator

2023-08-28 Thread via GitHub
XComp commented on code in PR #23296: URL: https://github.com/apache/flink/pull/23296#discussion_r1308278198 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/collect/CollectSinkOperatorCoordinator.java: ## @@ -83,7 +104,10 @@ public void start() thr

[GitHub] [flink] flinkbot commented on pull request #23317: [FLINK-32749][gateway] Support config default catalog for catalog store in gateway

2023-08-28 Thread via GitHub
flinkbot commented on PR #23317: URL: https://github.com/apache/flink/pull/23317#issuecomment-1696850102 ## CI report: * dff6f77de6706edc4dd5e246d118f51d93f2394d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Assigned] (FLINK-32749) Sql gateway supports default catalog loaded by CatalogStore

2023-08-28 Thread Fang Yong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fang Yong reassigned FLINK-32749: - Assignee: Fang Yong > Sql gateway supports default catalog loaded by CatalogStore > ---

[jira] [Updated] (FLINK-32749) Sql gateway supports default catalog loaded by CatalogStore

2023-08-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32749: --- Labels: pull-request-available (was: ) > Sql gateway supports default catalog loaded by Cat

[GitHub] [flink] FangYongs opened a new pull request, #23317: [FLINK-32749][gateway] Support config default catalog for catalog store in gateway

2023-08-28 Thread via GitHub
FangYongs opened a new pull request, #23317: URL: https://github.com/apache/flink/pull/23317 ## What is the purpose of the change This PR aims to support default catalog which is loaded by catalog store in sql-gateway ## Brief change log - Get default catalog from catalog

[jira] [Comment Edited] (FLINK-32678) Release Testing: Stress-Test to cover multiple low-level changes in Flink

2023-08-28 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759570#comment-17759570 ] Yang Wang edited comment on FLINK-32678 at 8/29/23 6:13 AM:

[jira] [Resolved] (FLINK-32805) Release Testing: Verify Support Java 17 (LTS)

2023-08-28 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qingsheng Ren resolved FLINK-32805. --- Resolution: Done > Release Testing: Verify Support Java 17 (LTS) >

[GitHub] [flink] JunRuiLee commented on pull request #23181: W.I.P only used to run ci.

2023-08-28 Thread via GitHub
JunRuiLee commented on PR #23181: URL: https://github.com/apache/flink/pull/23181#issuecomment-1696796786 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Comment Edited] (FLINK-32678) Release Testing: Stress-Test to cover multiple low-level changes in Flink

2023-08-28 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759570#comment-17759570 ] Yang Wang edited comment on FLINK-32678 at 8/29/23 5:20 AM:

[jira] [Comment Edited] (FLINK-32678) Release Testing: Stress-Test to cover multiple low-level changes in Flink

2023-08-28 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759570#comment-17759570 ] Yang Wang edited comment on FLINK-32678 at 8/29/23 5:20 AM:

[jira] [Comment Edited] (FLINK-32678) Release Testing: Stress-Test to cover multiple low-level changes in Flink

2023-08-28 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759570#comment-17759570 ] Yang Wang edited comment on FLINK-32678 at 8/29/23 5:15 AM:

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #648: [FLINK-32700] Support job drain for Savepoint upgrade mode

2023-08-28 Thread via GitHub
gyfora commented on code in PR #648: URL: https://github.com/apache/flink-kubernetes-operator/pull/648#discussion_r1308206545 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkOperatorConfiguration.java: ## @@ -185,6 +186,9 @@ public st

[jira] [Updated] (FLINK-32678) Release Testing: Stress-Test to cover multiple low-level changes in Flink

2023-08-28 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yang Wang updated FLINK-32678: -- Attachment: (was: qos-configmap-get-115.png) > Release Testing: Stress-Test to cover multiple low-

[jira] [Updated] (FLINK-32678) Release Testing: Stress-Test to cover multiple low-level changes in Flink

2023-08-28 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yang Wang updated FLINK-32678: -- Attachment: (was: qos-configmap-put-115.png) > Release Testing: Stress-Test to cover multiple low-

[jira] [Updated] (FLINK-32678) Release Testing: Stress-Test to cover multiple low-level changes in Flink

2023-08-28 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yang Wang updated FLINK-32678: -- Attachment: qps-configmap-get-118.png qps-configmap-get-115.png qps-con

[jira] [Updated] (FLINK-32678) Release Testing: Stress-Test to cover multiple low-level changes in Flink

2023-08-28 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yang Wang updated FLINK-32678: -- Attachment: (was: qos-configmap-patch-118.png) > Release Testing: Stress-Test to cover multiple lo

[jira] [Updated] (FLINK-32678) Release Testing: Stress-Test to cover multiple low-level changes in Flink

2023-08-28 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yang Wang updated FLINK-32678: -- Attachment: (was: qos-configmap-get-118.png) > Release Testing: Stress-Test to cover multiple low-

[GitHub] [flink] lsyldliu commented on a diff in pull request #23282: [FlINK-32865][table-planner] Add ExecutionOrderEnforcer to exec plan and put it into BatchExecMultipleInput

2023-08-28 Thread via GitHub
lsyldliu commented on code in PR #23282: URL: https://github.com/apache/flink/pull/23282#discussion_r1308172368 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/processor/DynamicFilteringDependencyProcessor.java: ## @@ -52,50 +55,91

[GitHub] [flink] WencongLiu closed pull request #23314: Test

2023-08-28 Thread via GitHub
WencongLiu closed pull request #23314: Test URL: https://github.com/apache/flink/pull/23314 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsub

[GitHub] [flink] 1996fanrui commented on a diff in pull request #23219: [FLINK-20681][yarn] Support specifying the hdfs path when ship archives or files

2023-08-28 Thread via GitHub
1996fanrui commented on code in PR #23219: URL: https://github.com/apache/flink/pull/23219#discussion_r1308166223 ## flink-yarn/src/test/java/org/apache/flink/yarn/YarnClusterDescriptorTest.java: ## @@ -543,22 +546,62 @@ void testExplicitFileShipping() throws Exception {

[jira] [Closed] (FLINK-32824) Port Calcite's fix for the sql like operator

2023-08-28 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee closed FLINK-32824. --- Resolution: Fixed > Port Calcite's fix for the sql like operator > -

[jira] [Commented] (FLINK-32824) Port Calcite's fix for the sql like operator

2023-08-28 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759797#comment-17759797 ] lincoln lee commented on FLINK-32824: - fixed in release-1.18: e9566267639a33adfd6ced

[GitHub] [flink] lincoln-lil merged pull request #23312: [FLINK-32824] Port Calcite's fix for the sql like operator.

2023-08-28 Thread via GitHub
lincoln-lil merged PR #23312: URL: https://github.com/apache/flink/pull/23312 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.a

[GitHub] [flink] flinkbot commented on pull request #23316: [FLINK-18445][table] Add pre-filter optimization for lookup join

2023-08-28 Thread via GitHub
flinkbot commented on PR #23316: URL: https://github.com/apache/flink/pull/23316#issuecomment-1696726227 ## CI report: * f282ba755b54d24ef35730755918ecc9b8e169a2 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-18445) Short circuit join condition for lookup join

2023-08-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-18445: --- Labels: auto-deprioritized-major auto-deprioritized-minor pull-request-available (was: auto

[GitHub] [flink] lincoln-lil opened a new pull request, #23316: [FLINK-18445][table] Add pre-filter optimization for lookup join

2023-08-28 Thread via GitHub
lincoln-lil opened a new pull request, #23316: URL: https://github.com/apache/flink/pull/23316 ## What is the purpose of the change As the issue shows there's some chance for optimizing the lookup join when do a left join (maybe full outer join as well in future) which has filter conditi

[GitHub] [flink] flinkbot commented on pull request #23315: [FLINK-32945][runtime] Fix NPE when task reached end-of-data but checkpoint failed

2023-08-28 Thread via GitHub
flinkbot commented on PR #23315: URL: https://github.com/apache/flink/pull/23315#issuecomment-1696717433 ## CI report: * b84a51e67193e892c87fb8458d028abc22d4f57f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] jiangxin369 opened a new pull request, #23315: [FLINK-32945][runtime] Fix NPE when task reached end-of-data but checkpoint failed

2023-08-28 Thread via GitHub
jiangxin369 opened a new pull request, #23315: URL: https://github.com/apache/flink/pull/23315 ## What is the purpose of the change Fix NullPointerException when executing TopSpeedWindowing example with checkpointing enabled. The bug happens when some vertices have rea

[GitHub] [flink] hackergin commented on a diff in pull request #23307: [FLINK-32968][table] Fix doc for catalog modification listener

2023-08-28 Thread via GitHub
hackergin commented on code in PR #23307: URL: https://github.com/apache/flink/pull/23307#discussion_r1308135813 ## docs/content/docs/dev/table/catalogs.md: ## @@ -801,10 +806,9 @@ env.executeSql("CREATE TABLE ...").wait(); ``` For sql-gateway, you can add the option `table.

[jira] [Commented] (FLINK-31650) Incorrect busyMsTimePerSecond metric value for FINISHED task

2023-08-28 Thread Zhanghao Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759786#comment-17759786 ] Zhanghao Chen commented on FLINK-31650: --- Hi [~JunRuiLi], we encountered the same p

[jira] [Closed] (FLINK-32984) Display the host port information on the suttasks page of SubtaskExecution

2023-08-28 Thread Weihua Hu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weihua Hu closed FLINK-32984. - Resolution: Duplicate > Display the host port information on the suttasks page of SubtaskExecution > ---

[jira] [Updated] (FLINK-32980) Support env.java.opts.all & env.java.opts.cli config for starting Session cluster CLIs

2023-08-28 Thread Weihua Hu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weihua Hu updated FLINK-32980: -- Release Note: (was: Resolved in master: 6dbb9b8d3fcfe88a85b22e2f177e8fea7585702e) > Support env.jav

[jira] [Commented] (FLINK-32980) Support env.java.opts.all & env.java.opts.cli config for starting Session cluster CLIs

2023-08-28 Thread Weihua Hu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759785#comment-17759785 ] Weihua Hu commented on FLINK-32980: --- Resolved in master: 6dbb9b8d3fcfe88a85b22e2f177e8

[jira] [Resolved] (FLINK-32980) Support env.java.opts.all & env.java.opts.cli config for starting Session cluster CLIs

2023-08-28 Thread Weihua Hu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weihua Hu resolved FLINK-32980. --- Release Note: Resolved in master: 6dbb9b8d3fcfe88a85b22e2f177e8fea7585702e Resolution: Fixed >

[GitHub] [flink] huwh merged pull request #23308: [FLINK-32980][scripts] Support env.java.opts.all & env.java.opts.cli config for starting Session cluster CLIs

2023-08-28 Thread via GitHub
huwh merged PR #23308: URL: https://github.com/apache/flink/pull/23308 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.o

[jira] [Comment Edited] (FLINK-32780) Release Testing: Verify FLIP-324: Introduce Runtime Filter for Flink Batch Jobs

2023-08-28 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759578#comment-17759578 ] dalongliu edited comment on FLINK-32780 at 8/29/23 2:40 AM:

[jira] [Created] (FLINK-32986) The new createTemporaryFunction has some regression of type inference compare to the deprecated registerFunction

2023-08-28 Thread lincoln lee (Jira)
lincoln lee created FLINK-32986: --- Summary: The new createTemporaryFunction has some regression of type inference compare to the deprecated registerFunction Key: FLINK-32986 URL: https://issues.apache.org/jira/browse

[GitHub] [flink] hackergin commented on pull request #23109: [FLINK-32475][docs] Add doc for time travel

2023-08-28 Thread via GitHub
hackergin commented on PR #23109: URL: https://github.com/apache/flink/pull/23109#issuecomment-1696677420 @luoyuxia Thanks for the review, sorry for the late update, PTAL when your are free. -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [flink] fredia commented on pull request #22890: [FLINK-32072][checkpoint] Create and wire FileMergingSnapshotManager with TaskManagerServices

2023-08-28 Thread via GitHub
fredia commented on PR #22890: URL: https://github.com/apache/flink/pull/22890#issuecomment-1696673932 @Zakelly Thanks for the review, I moved the initialization of file merging into `initializeBaseLocationsForCheckpoint()` to address some failing tests, file merging will only take effect i

[jira] [Commented] (FLINK-32758) PyFlink bounds are overly restrictive and outdated

2023-08-28 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759777#comment-17759777 ] Dian Fu commented on FLINK-32758: - [~deepyaman] Actually the tests have passed on the CI

[jira] [Updated] (FLINK-32758) PyFlink bounds are overly restrictive and outdated

2023-08-28 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu updated FLINK-32758: Attachment: image-2023-08-29-10-19-37-977.png > PyFlink bounds are overly restrictive and outdated > -

[GitHub] [flink] fredia commented on a diff in pull request #22890: [FLINK-32072][checkpoint] Create and wire FileMergingSnapshotManager with TaskManagerServices

2023-08-28 Thread via GitHub
fredia commented on code in PR #22890: URL: https://github.com/apache/flink/pull/22890#discussion_r1308123867 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/TaskExecutorFileMergingManager.java: ## @@ -0,0 +1,163 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] [flink] jiexray commented on a diff in pull request #21410: [FLINK-29776][flink-statebackend-changelog][JUnit5 Migration]Module: flink-statebackend-changelog.

2023-08-28 Thread via GitHub
jiexray commented on code in PR #21410: URL: https://github.com/apache/flink/pull/21410#discussion_r1308122484 ## flink-state-backends/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/EmbeddedRocksDBStateBackendTest.java: ## @@ -46,18 +46,17 @@

[GitHub] [flink] jiexray commented on pull request #23305: [FLINK-32975][state/changelog] Enhance equal() for ChangelogMapState's iterator

2023-08-28 Thread via GitHub
jiexray commented on PR #23305: URL: https://github.com/apache/flink/pull/23305#issuecomment-1696665750 @masteryhx Thank you for the review. I have added a new test in `ChangelogMapStateTest`. In the test, I try to assert the following: ``` state1.iterate().next() equals expected; // a

[jira] [Updated] (FLINK-32965) Remove the deprecated MutableObjectMode

2023-08-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32965: --- Labels: pull-request-available (was: ) > Remove the deprecated MutableObjectMode >

[GitHub] [flink] 1996fanrui merged pull request #23303: [FLINK-32965][flink-runtime] Removing the deprecated MutableObjectMode and restore related tests

2023-08-28 Thread via GitHub
1996fanrui merged PR #23303: URL: https://github.com/apache/flink/pull/23303 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.ap

[jira] [Commented] (FLINK-32758) PyFlink bounds are overly restrictive and outdated

2023-08-28 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759774#comment-17759774 ] Dian Fu commented on FLINK-32758: - [~Sergey Nuyanzin] [~deepyaman]  I have submitted a h

[jira] [Resolved] (FLINK-32965) Remove the deprecated MutableObjectMode

2023-08-28 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan resolved FLINK-32965. - Fix Version/s: 1.19.0 Resolution: Fixed > Remove the deprecated MutableObjectMode > -

[jira] [Commented] (FLINK-32965) Remove the deprecated MutableObjectMode

2023-08-28 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759773#comment-17759773 ] Rui Fan commented on FLINK-32965: - Merged via 3fa046ef7c461554b50d2d791dc4846cd8ff75b7

[GitHub] [flink] flinkbot commented on pull request #23314: Test

2023-08-28 Thread via GitHub
flinkbot commented on PR #23314: URL: https://github.com/apache/flink/pull/23314#issuecomment-1696659499 ## CI report: * 4e7859ec86f75ec9187a89210460c0d3b9782ffc UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] WencongLiu opened a new pull request, #23314: Test

2023-08-28 Thread via GitHub
WencongLiu opened a new pull request, #23314: URL: https://github.com/apache/flink/pull/23314 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them

[GitHub] [flink] xintongsong commented on pull request #23292: [FLINK-32817] Harnessing Jackson for Secure Serialization of YarnLocalResourceDescriptor

2023-08-28 Thread via GitHub
xintongsong commented on PR #23292: URL: https://github.com/apache/flink/pull/23292#issuecomment-1696654555 @YesOrNo828, please take a look into the CI failures. The failures are all from the Yarn deployment, which are likely related to the changes of this PR. -- This is an automated mess

[GitHub] [flink] flinkbot commented on pull request #23313: [FLINK-20767][table planner] Support filter push down on nested fields

2023-08-28 Thread via GitHub
flinkbot commented on PR #23313: URL: https://github.com/apache/flink/pull/23313#issuecomment-1696630993 ## CI report: * 5470431742bf63292142aaa7c96b4c894b3a7c82 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-20767) add nested field support for SupportsFilterPushDown

2023-08-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-20767: --- Labels: pull-request-available (was: ) > add nested field support for SupportsFilterPushDow

[GitHub] [flink] venkata91 opened a new pull request, #23313: [FLINK-20767][table planner] Support filter push down on nested fields

2023-08-28 Thread via GitHub
venkata91 opened a new pull request, #23313: URL: https://github.com/apache/flink/pull/23313 ## What is the purpose of the change Support filter push down on nested fields For example: `SELECT * FROM users WHERE user.age > 18` In the above SQL, `user.age > 18` filter

[jira] [Updated] (FLINK-30630) Python: BatchModeDataStreamTests.test_keyed_map failed

2023-08-28 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-30630: --- Labels: auto-deprioritized-critical test-stability (was: stale-critical test-stability)

[jira] [Updated] (FLINK-32476) Support configuring object-reuse for internal operators

2023-08-28 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-32476: --- Labels: pull-request-available stale-major (was: pull-request-available) I am the [Flink Ji

[jira] [Updated] (FLINK-32396) Support timestamp for jdbc driver and gateway

2023-08-28 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-32396: --- Labels: pull-request-available stale-major (was: pull-request-available) I am the [Flink Ji

[GitHub] [flink-kubernetes-operator] mananmangal commented on a diff in pull request #648: [FLINK-32700] Support job drain for Savepoint upgrade mode

2023-08-28 Thread via GitHub
mananmangal commented on code in PR #648: URL: https://github.com/apache/flink-kubernetes-operator/pull/648#discussion_r1291624743 ## flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/reconciler/deployment/ApplicationReconcilerTest.java: ## @@ -1070,4

[jira] [Commented] (FLINK-32758) PyFlink bounds are overly restrictive and outdated

2023-08-28 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759693#comment-17759693 ] Sergey Nuyanzin commented on FLINK-32758: - > I'm not sure how I can verify that

[jira] [Comment Edited] (FLINK-32976) NullPointException when starting flink cluster

2023-08-28 Thread Feng Jin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759670#comment-17759670 ] Feng Jin edited comment on FLINK-32976 at 8/28/23 5:41 PM: --- [~

[jira] [Commented] (FLINK-32976) NullPointException when starting flink cluster

2023-08-28 Thread Feng Jin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759670#comment-17759670 ] Feng Jin commented on FLINK-32976: -- [~martijnvisser]  Sorry for the not clearly descrip

[jira] [Updated] (FLINK-32976) NullPointException when starting flink cluster

2023-08-28 Thread Feng Jin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Jin updated FLINK-32976: - Description: It can be reproduced when starting flink cluster with hadoop configuration.    {code:java}

[GitHub] [flink] Jiabao-Sun commented on pull request #23218: [FLINK-32854][flink-runtime][JUnit5 Migration] The state package of flink-runtime module

2023-08-28 Thread via GitHub
Jiabao-Sun commented on PR #23218: URL: https://github.com/apache/flink/pull/23218#issuecomment-1696047403 Thanks @1996fanrui for the hard review and sorry for the oversight. Please help review it again when you have time. -- This is an automated message from the Apache Git Service. To

[GitHub] [flink] flinkbot commented on pull request #23312: [FLINK-32824] Port Calcite's fix for the sql like operator.

2023-08-28 Thread via GitHub
flinkbot commented on PR #23312: URL: https://github.com/apache/flink/pull/23312#issuecomment-1695987276 ## CI report: * 4505846115102c1e09ae495076f7d270f53f3da5 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] xishuaidelin opened a new pull request, #23312: [FLINK-32824] Port Calcite's fix for the sql like operator.

2023-08-28 Thread via GitHub
xishuaidelin opened a new pull request, #23312: URL: https://github.com/apache/flink/pull/23312 ## What is the purpose of the change This pull request aims to port Calcite's fix for the sql like operator and relates to FLINK-32824. ## Brief change log Modifi

[GitHub] [flink-connector-aws] hlteoh37 opened a new pull request, #92: [hotfix] Add MiniClusterExtension to ITCase tests

2023-08-28 Thread via GitHub
hlteoh37 opened a new pull request, #92: URL: https://github.com/apache/flink-connector-aws/pull/92 ## Purpose of the change * [Text for ITCase MiniCluster ArchUnitTest has been changed for Flink 1.18](https://github.com/apache/flink/pull/22399). This PR removes the need for this exc

[jira] [Updated] (FLINK-32976) NullpointException when starting flink cluster

2023-08-28 Thread Feng Jin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Jin updated FLINK-32976: - Description: The error message as follows:      {code:java} //代码占位符 Caused by: java.ang.NullPointerExc

[jira] [Updated] (FLINK-32976) NullPointException when starting flink cluster

2023-08-28 Thread Feng Jin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Jin updated FLINK-32976: - Summary: NullPointException when starting flink cluster (was: NullpointException when starting flink cl

[GitHub] [flink] 1996fanrui commented on a diff in pull request #22985: [FLINK-21883][scheduler] Implement cooldown period for adaptive scheduler

2023-08-28 Thread via GitHub
1996fanrui commented on code in PR #22985: URL: https://github.com/apache/flink/pull/22985#discussion_r1307539956 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/Executing.java: ## @@ -144,6 +188,17 @@ private void maybeRescale() { } }

[GitHub] [flink] echauchot commented on a diff in pull request #22985: [FLINK-21883][scheduler] Implement cooldown period for adaptive scheduler

2023-08-28 Thread via GitHub
echauchot commented on code in PR #22985: URL: https://github.com/apache/flink/pull/22985#discussion_r1307494302 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/Executing.java: ## @@ -144,6 +188,17 @@ private void maybeRescale() { } } +

[GitHub] [flink] 1996fanrui commented on a diff in pull request #23218: [FLINK-32854][flink-runtime][JUnit5 Migration] The state package of flink-runtime module

2023-08-28 Thread via GitHub
1996fanrui commented on code in PR #23218: URL: https://github.com/apache/flink/pull/23218#discussion_r1307500363 ## flink-runtime/src/test/java/org/apache/flink/runtime/state/OperatorStateOutputCheckpointStreamTest.java: ## @@ -54,41 +55,40 @@ private OperatorStateHandle writeA

[GitHub] [flink] echauchot commented on a diff in pull request #22985: [FLINK-21883][scheduler] Implement cooldown period for adaptive scheduler

2023-08-28 Thread via GitHub
echauchot commented on code in PR #22985: URL: https://github.com/apache/flink/pull/22985#discussion_r1307494302 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/Executing.java: ## @@ -144,6 +188,17 @@ private void maybeRescale() { } } +

[GitHub] [flink] echauchot commented on a diff in pull request #22985: [FLINK-21883][scheduler] Implement cooldown period for adaptive scheduler

2023-08-28 Thread via GitHub
echauchot commented on code in PR #22985: URL: https://github.com/apache/flink/pull/22985#discussion_r1307494302 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/Executing.java: ## @@ -144,6 +188,17 @@ private void maybeRescale() { } } +

[GitHub] [flink] zentol commented on a diff in pull request #23296: [FLINK-32751][collect] Fixes race condition between close and request handling processes in CollectSinkOperatorCoordinator

2023-08-28 Thread via GitHub
zentol commented on code in PR #23296: URL: https://github.com/apache/flink/pull/23296#discussion_r1307474170 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/collect/CollectSinkOperatorCoordinator.java: ## @@ -83,7 +104,10 @@ public void start() th

[jira] [Updated] (FLINK-32961) A new FileSystemFactory that support two high available hdfs

2023-08-28 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-32961: --- Fix Version/s: (was: 1.18.0) > A new FileSystemFactory that support two high available h

[jira] [Commented] (FLINK-32970) could not load external class using "-C" option

2023-08-28 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759602#comment-17759602 ] Martijn Visser commented on FLINK-32970: [~SpongebobZ] Can you please try this w

[jira] [Closed] (FLINK-32976) NullpointException when starting flink cluster

2023-08-28 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-32976. -- Resolution: Cannot Reproduce [~hackergin] Please provide info on what you've tried and how to

[GitHub] [flink] echauchot commented on a diff in pull request #22985: [FLINK-21883][scheduler] Implement cooldown period for adaptive scheduler

2023-08-28 Thread via GitHub
echauchot commented on code in PR #22985: URL: https://github.com/apache/flink/pull/22985#discussion_r1307494302 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/Executing.java: ## @@ -144,6 +188,17 @@ private void maybeRescale() { } } +

[jira] [Closed] (FLINK-32981) Add python dynamic Flink home detection

2023-08-28 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-32981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Márton Balassi closed FLINK-32981. -- Fix Version/s: 1.19.0 Resolution: Fixed 63a4db2 in master > Add python dynamic Flink h

[GitHub] [flink] echauchot commented on a diff in pull request #22985: [FLINK-21883][scheduler] Implement cooldown period for adaptive scheduler

2023-08-28 Thread via GitHub
echauchot commented on code in PR #22985: URL: https://github.com/apache/flink/pull/22985#discussion_r1307486764 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/Executing.java: ## @@ -210,6 +265,15 @@ interface Context * @return a ScheduledFu

[GitHub] [flink] X-czh commented on a diff in pull request #23302: [FLINK-32848][tests][JUnit5 migration] Migrate flink-runtime/shuffle tests to JUnit5

2023-08-28 Thread via GitHub
X-czh commented on code in PR #23302: URL: https://github.com/apache/flink/pull/23302#discussion_r1307486343 ## flink-runtime/src/test/java/org/apache/flink/runtime/shuffle/ShuffleMasterTest.java: ## @@ -99,7 +95,7 @@ public void testStopTrackingPartition() throws Exception {

[jira] [Closed] (FLINK-32971) Add pyflink proper development version support

2023-08-28 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-32971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Márton Balassi closed FLINK-32971. -- Fix Version/s: 1.19.0 Resolution: Fixed 171524f in master > Add pyflink proper develop

[GitHub] [flink] mbalassi merged pull request #23304: [FLINK-32971][PYTHON] Add pyflink proper development version support

2023-08-28 Thread via GitHub
mbalassi merged PR #23304: URL: https://github.com/apache/flink/pull/23304 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

[GitHub] [flink] ferenc-csaky commented on pull request #23304: [FLINK-32971][PYTHON] Add pyflink proper development version support

2023-08-28 Thread via GitHub
ferenc-csaky commented on PR #23304: URL: https://github.com/apache/flink/pull/23304#issuecomment-1695757103 > > Any specific reason to be more lenient and not use \d+ instead? > > I personally don't think that Flink must re-implement the versioning standard. I know this case it's jus

  1   2   3   >