Re: [PR] [FLINK-24150][k8s] Support to configure cpu resource request and limit in pod template [flink]

2023-12-04 Thread via GitHub
flinkbot commented on PR #23872: URL: https://github.com/apache/flink/pull/23872#issuecomment-1840195715 ## CI report: * 7e0432a8fb1b2d6edfb46806d5ed75f5cd181a04 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-24150) Support to configure cpu resource request and limit in pod template

2023-12-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-24150: --- Labels: pull-request-available (was: ) > Support to configure cpu resource request and limi

[PR] [FLINK-24150][k8s] Support to configure cpu resource request and limit in pod template [flink]

2023-12-04 Thread via GitHub
Sucran opened a new pull request, #23872: URL: https://github.com/apache/flink/pull/23872 ## What is the purpose of the change When we use the Flink operator and configure the PodTemplate, and the resource configuration of the PodTemplate is different from the resources c

Re: [PR] [FLINK-33541][table-planner] function RAND and RAND_INTEGER should return type nullable if the arguments are nullable [flink]

2023-12-04 Thread via GitHub
libenchao commented on code in PR #23779: URL: https://github.com/apache/flink/pull/23779#discussion_r1415033772 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/expressions/ScalarFunctionsTest.scala: ## @@ -2661,6 +2665,37 @@ class ScalarFunction

Re: [PR] [FLINK-33266][sql-gateway] Support plan cache for DQL in SQL Gateway [flink]

2023-12-04 Thread via GitHub
libenchao commented on code in PR #23849: URL: https://github.com/apache/flink/pull/23849#discussion_r1414825282 ## flink-table/flink-sql-gateway/src/test/resources/sql/repeated_dql.q: ## @@ -0,0 +1,220 @@ +# statement-set.q - BEGIN STATEMENT SET, END Review Comment: You for

[jira] [Updated] (FLINK-33750) Remove deprecated config options.

2023-12-04 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-33750: --- Labels: 2.0-related (was: ) > Remove deprecated config options. > -

[jira] [Assigned] (FLINK-33750) Remove deprecated config options.

2023-12-04 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo reassigned FLINK-33750: -- Assignee: Junrui Li > Remove deprecated config options. > - >

[jira] [Assigned] (FLINK-33743) Support consuming multiple subpartitions on a single channel

2023-12-04 Thread Yuxin Tan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuxin Tan reassigned FLINK-33743: - Assignee: (was: Yuxin Tan) > Support consuming multiple subpartitions on a single channel >

[jira] [Created] (FLINK-33750) Remove deprecated config options.

2023-12-04 Thread Junrui Li (Jira)
Junrui Li created FLINK-33750: - Summary: Remove deprecated config options. Key: FLINK-33750 URL: https://issues.apache.org/jira/browse/FLINK-33750 Project: Flink Issue Type: Sub-task Co

[jira] [Assigned] (FLINK-33743) Support consuming multiple subpartitions on a single channel

2023-12-04 Thread Yuxin Tan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuxin Tan reassigned FLINK-33743: - Assignee: Yunfeng Zhou > Support consuming multiple subpartitions on a single channel > ---

[jira] [Assigned] (FLINK-33749) Remove deprecated getter method in Configuration.

2023-12-04 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo reassigned FLINK-33749: -- Assignee: Junrui Li > Remove deprecated getter method in Configuration. > ---

[jira] [Assigned] (FLINK-33743) Support consuming multiple subpartitions on a single channel

2023-12-04 Thread Yuxin Tan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuxin Tan reassigned FLINK-33743: - Assignee: Yuxin Tan > Support consuming multiple subpartitions on a single channel > --

[jira] [Updated] (FLINK-33749) Remove deprecated getter method in Configuration.

2023-12-04 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-33749: --- Labels: 2.0-related (was: ) > Remove deprecated getter method in Configuration. > -

[jira] [Created] (FLINK-33749) Remove deprecated getter method in Configuration.

2023-12-04 Thread Junrui Li (Jira)
Junrui Li created FLINK-33749: - Summary: Remove deprecated getter method in Configuration. Key: FLINK-33749 URL: https://issues.apache.org/jira/browse/FLINK-33749 Project: Flink Issue Type: Sub-t

[jira] [Updated] (FLINK-33743) Support consuming multiple subpartitions on a single channel

2023-12-04 Thread Yuxin Tan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuxin Tan updated FLINK-33743: -- Description: In Flink jobs that use the AdaptiveBatchScheduler and enable adaptive parallelism, a down

Re: [PR] [FLINK-33502][network] Prevent DiskTierProducerAgent#getSegmentIdByIndexOfFirstBufferInSegment from throwing NPE when the task is released [flink]

2023-12-04 Thread via GitHub
reswqa commented on code in PR #23863: URL: https://github.com/apache/flink/pull/23863#discussion_r1414966335 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/tier/disk/DiskTierProducerAgent.java: ## @@ -223,9 +228,16 @@ private void rel

Re: [PR] [FLINK-33502][network] Prevent DiskTierProducerAgent#getSegmentIdByIndexOfFirstBufferInSegment from throwing NPE when the task is released [flink]

2023-12-04 Thread via GitHub
reswqa commented on code in PR #23863: URL: https://github.com/apache/flink/pull/23863#discussion_r1414966335 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/tier/disk/DiskTierProducerAgent.java: ## @@ -223,9 +228,16 @@ private void rel

[jira] [Updated] (FLINK-33730) Update the compatibility table to only include last two released versions

2023-12-04 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Ge updated FLINK-33730: Summary: Update the compatibility table to only include last two released versions (was: Update the compa

[jira] [Updated] (FLINK-33730) Update the compatibility table to only include last two versions

2023-12-04 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Ge updated FLINK-33730: Summary: Update the compatibility table to only include last two versions (was: Update the compatibility

[jira] [Updated] (FLINK-7957) Add MetricGroup#getLogicalScope

2023-12-04 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-7957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-7957: -- Labels: 2.0-related auto-deprioritized-minor auto-unassigned (was: auto-deprioritized-minor auto-unass

[jira] [Updated] (FLINK-6053) Gauge should only take subclasses of Number, rather than everything

2023-12-04 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-6053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-6053: -- Labels: 2.0-related pull-request-available (was: pull-request-available) > Gauge should only take subc

[jira] [Updated] (FLINK-32198) Enforce single maxExceptions query parameter

2023-12-04 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-32198: --- Labels: 2.0-related pull-request-available (was: pull-request-available) > Enforce single maxExcept

[jira] [Updated] (FLINK-14350) Introduce dedicated MetricScope

2023-12-04 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-14350: --- Labels: 2.0-related auto-deprioritized-major auto-deprioritized-minor auto-unassigned pull-request-a

[jira] [Updated] (FLINK-15787) Upgrade REST API response to remove '-' from key names.

2023-12-04 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-15787: --- Labels: 2.0-related auto-deprioritized-major auto-deprioritized-minor auto-unassigned (was: auto-de

[jira] [Updated] (FLINK-32688) Remove deprecated exception history fields

2023-12-04 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-32688: --- Labels: 2.0-related (was: ) > Remove deprecated exception history fields >

[jira] [Updated] (FLINK-32597) Drop Yarn specific get rest endpoints

2023-12-04 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-32597: --- Labels: 2.0-related (was: ) > Drop Yarn specific get rest endpoints >

[jira] [Updated] (FLINK-24078) Remove brackets around variables

2023-12-04 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-24078: --- Labels: 2.0-related (was: ) > Remove brackets around variables > >

[jira] [Updated] (FLINK-29863) Properly handle NaN/Infinity in OpenAPI spec

2023-12-04 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-29863: --- Labels: 2.0-related (was: ) > Properly handle NaN/Infinity in OpenAPI spec > --

[jira] [Commented] (FLINK-32684) Renaming AkkaOptions into PekkoOptions

2023-12-04 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793156#comment-17793156 ] Weijie Guo commented on FLINK-32684: I'm +1 for introducing {{PekkoOptions}} to depr

[jira] [Updated] (FLINK-32684) Renaming AkkaOptions into PekkoOptions

2023-12-04 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-32684: --- Labels: 2.0-related (was: ) > Renaming AkkaOptions into PekkoOptions >

[jira] [Updated] (FLINK-33677) Remove flink-conf.yaml from flink dist

2023-12-04 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-33677: --- Labels: 2.0-related (was: ) > Remove flink-conf.yaml from flink dist >

[jira] [Updated] (FLINK-33678) Remove configuration getters/setters that return/set complex Java objects

2023-12-04 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-33678: --- Labels: 2.0-related (was: ) > Remove configuration getters/setters that return/set complex Java obj

[jira] [Updated] (FLINK-32384) Remove deprecated configuration keys which violate YAML spec

2023-12-04 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-32384: --- Labels: 2.0-related (was: ) > Remove deprecated configuration keys which violate YAML spec > --

[jira] [Updated] (FLINK-14068) Use Java's Duration instead of Flink's Time

2023-12-04 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-14068: --- Labels: 2.0-related (was: ) > Use Java's Duration instead of Flink's Time > ---

[jira] [Updated] (FLINK-33748) Remove legacy TableSource/TableSink API in 2.0

2023-12-04 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-33748: --- Description: {{TableSource}} and {{TableSink}} already marked as deprecated in FLINK-19453, and can

[jira] [Updated] (FLINK-33748) Remove legacy TableSource/TableSink API in 2.0

2023-12-04 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-33748: --- Labels: 2.0-related (was: ) > Remove legacy TableSource/TableSink API in 2.0 >

[jira] [Created] (FLINK-33748) Remove legacy TableSource/TableSink API in 2.0

2023-12-04 Thread Weijie Guo (Jira)
Weijie Guo created FLINK-33748: -- Summary: Remove legacy TableSource/TableSink API in 2.0 Key: FLINK-33748 URL: https://issues.apache.org/jira/browse/FLINK-33748 Project: Flink Issue Type: Techni

[jira] [Updated] (FLINK-33747) Remove Sink V1 API in 2.0

2023-12-04 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-33747: --- Description: We have already mark sink v1 related API to `@deprecated` in 1.15. They can be removed

[jira] [Updated] (FLINK-33747) Remove Sink V1 API in 2.0

2023-12-04 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-33747: --- Fix Version/s: 2.0.0 > Remove Sink V1 API in 2.0 > - > > Key

[jira] [Created] (FLINK-33747) Remove Sink V1 API in 2.0

2023-12-04 Thread Weijie Guo (Jira)
Weijie Guo created FLINK-33747: -- Summary: Remove Sink V1 API in 2.0 Key: FLINK-33747 URL: https://issues.apache.org/jira/browse/FLINK-33747 Project: Flink Issue Type: Technical Debt Co

[jira] [Updated] (FLINK-33747) Remove Sink V1 API in 2.0

2023-12-04 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-33747: --- Labels: 2.0-related (was: ) > Remove Sink V1 API in 2.0 > - > >

[jira] [Updated] (FLINK-29739) [FLIP-265] Deprecate and remove Scala API support

2023-12-04 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-29739: --- Labels: 2.0-related (was: ) > [FLIP-265] Deprecate and remove Scala API support > -

[jira] [Updated] (FLINK-29740) [FLIP-265] Deprecate all customer-facing Scala APIs

2023-12-04 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-29740: --- Labels: 2.0-related pull-request-available (was: pull-request-available) > [FLIP-265] Deprecate all

[jira] [Commented] (FLINK-33548) Replace taskManager/jobmanager.resource with resources conforming to ResourceRequirements

2023-12-04 Thread chaoran.su (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793143#comment-17793143 ] chaoran.su commented on FLINK-33548: [~gyfora] Hi Gyula, may I ask if there has been

[jira] [Comment Edited] (FLINK-24150) Support to configure cpu resource request and limit in pod template

2023-12-04 Thread chaoran.su (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793137#comment-17793137 ] chaoran.su edited comment on FLINK-24150 at 12/5/23 5:49 AM: -

Re: [PR] [FLINK-33502][network] Make DiskTierProducerAgent#getSegmentIdByIndexOfFirstBufferInSegment return null when the task is released [flink]

2023-12-04 Thread via GitHub
WencongLiu commented on PR #23863: URL: https://github.com/apache/flink/pull/23863#issuecomment-1840056894 If you have some free time, could you please take a look? Thank you 😊 @reswqa -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[jira] [Commented] (FLINK-24150) Support to configure cpu resource request and limit in pod template

2023-12-04 Thread chaoran.su (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793137#comment-17793137 ] chaoran.su commented on FLINK-24150: [~surendralilhore] Sorry, this pr couldn't help

[jira] [Resolved] (FLINK-33702) Add IncrementalDelayRetryStrategy implementation of RetryStrategy

2023-12-04 Thread Weihua Hu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weihua Hu resolved FLINK-33702. --- Fix Version/s: 1.19.0 Resolution: Fixed resolved in master: 0acfc1a51e8802ebd0eb1ab5c00bbfab5

Re: [PR] [FLINK-33702][core] Add the IncrementalDelayRetryStrategy implementation of RetryStrategy [flink]

2023-12-04 Thread via GitHub
huwh merged PR #23834: URL: https://github.com/apache/flink/pull/23834 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.o

[jira] [Created] (FLINK-33746) More precise dynamic selection of Hybrid Shuffle or AQE

2023-12-04 Thread Yuxin Tan (Jira)
Yuxin Tan created FLINK-33746: - Summary: More precise dynamic selection of Hybrid Shuffle or AQE Key: FLINK-33746 URL: https://issues.apache.org/jira/browse/FLINK-33746 Project: Flink Issue Type:

[jira] [Created] (FLINK-33745) Dynamically choose hybrid shuffle or AQE in a job level

2023-12-04 Thread Yuxin Tan (Jira)
Yuxin Tan created FLINK-33745: - Summary: Dynamically choose hybrid shuffle or AQE in a job level Key: FLINK-33745 URL: https://issues.apache.org/jira/browse/FLINK-33745 Project: Flink Issue Type:

[jira] [Created] (FLINK-33744) Hybrid shuffle avoids restarting the whole job when failover

2023-12-04 Thread Yuxin Tan (Jira)
Yuxin Tan created FLINK-33744: - Summary: Hybrid shuffle avoids restarting the whole job when failover Key: FLINK-33744 URL: https://issues.apache.org/jira/browse/FLINK-33744 Project: Flink Issue

[jira] [Updated] (FLINK-33742) Hybrid Shuffle should work well with Adaptive Query Execution

2023-12-04 Thread Yuxin Tan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuxin Tan updated FLINK-33742: -- Description: At present, Hybrid Shuffle and Adaptive Query Execution (AQE), which includes features s

[jira] [Created] (FLINK-33743) Support consuming multiple subpartitions on a single channel

2023-12-04 Thread Yuxin Tan (Jira)
Yuxin Tan created FLINK-33743: - Summary: Support consuming multiple subpartitions on a single channel Key: FLINK-33743 URL: https://issues.apache.org/jira/browse/FLINK-33743 Project: Flink Issue

[jira] [Commented] (FLINK-24150) Support to configure cpu resource request and limit in pod template

2023-12-04 Thread Surendra Singh Lilhore (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793128#comment-17793128 ] Surendra Singh Lilhore commented on FLINK-24150: [~richard.su] , I have

[jira] [Created] (FLINK-33742) Hybrid Shuffle should work well with Adaptive Query Execution

2023-12-04 Thread Yuxin Tan (Jira)
Yuxin Tan created FLINK-33742: - Summary: Hybrid Shuffle should work well with Adaptive Query Execution Key: FLINK-33742 URL: https://issues.apache.org/jira/browse/FLINK-33742 Project: Flink Issu

[jira] [Commented] (FLINK-24150) Support to configure cpu resource request and limit in pod template

2023-12-04 Thread Alexis Sarda-Espinosa (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793105#comment-17793105 ] Alexis Sarda-Espinosa commented on FLINK-24150: --- Sorry, I don't follow. An

[jira] [Created] (FLINK-33741) introduce stat dump period and statsLevel configuration

2023-12-04 Thread xiaogang zhou (Jira)
xiaogang zhou created FLINK-33741: - Summary: introduce stat dump period and statsLevel configuration Key: FLINK-33741 URL: https://issues.apache.org/jira/browse/FLINK-33741 Project: Flink Iss

[jira] [Comment Edited] (FLINK-24150) Support to configure cpu resource request and limit in pod template

2023-12-04 Thread chaoran.su (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793103#comment-17793103 ] chaoran.su edited comment on FLINK-24150 at 12/5/23 3:47 AM: -

[jira] [Commented] (FLINK-24150) Support to configure cpu resource request and limit in pod template

2023-12-04 Thread chaoran.su (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793103#comment-17793103 ] chaoran.su commented on FLINK-24150: [~asardaes] this is not the same, if we need fl

[jira] [Comment Edited] (FLINK-24150) Support to configure cpu resource request and limit in pod template

2023-12-04 Thread chaoran.su (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793103#comment-17793103 ] chaoran.su edited comment on FLINK-24150 at 12/5/23 3:44 AM: -

[jira] [Commented] (FLINK-33728) do not rewatch when KubernetesResourceManagerDriver watch fail

2023-12-04 Thread xiaogang zhou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793092#comment-17793092 ] xiaogang zhou commented on FLINK-33728: --- [~wangyang0918] [~mapohl] [~gyfora] Would

Re: [PR] [FLINK-33490][table-planner] Validate the column name conflicts in view when creating view [flink]

2023-12-04 Thread via GitHub
xuyangzhong commented on PR #23760: URL: https://github.com/apache/flink/pull/23760#issuecomment-1839930471 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] [FLINK-32881][checkpoint] Support triggering savepoint in detach mode for CLI and dumping all pending savepoint ids by rest api [flink]

2023-12-04 Thread via GitHub
xiangforever2014 commented on PR #23253: URL: https://github.com/apache/flink/pull/23253#issuecomment-1839926426 @masteryhx Kindly remind, hope to get your reply, many thanks ^_^ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Updated] (FLINK-33728) do not rewatch when KubernetesResourceManagerDriver watch fail

2023-12-04 Thread xiaogang zhou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xiaogang zhou updated FLINK-33728: -- Description: I met massive production problem when kubernetes ETCD slow responding happen. Af

[jira] [Resolved] (FLINK-27529) HybridSourceSplitEnumerator sourceIndex using error Integer check

2023-12-04 Thread Thomas Weise (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Weise resolved FLINK-27529. -- Resolution: Fixed > HybridSourceSplitEnumerator sourceIndex using error Integer check > --

[jira] [Updated] (FLINK-27529) HybridSourceSplitEnumerator sourceIndex using error Integer check

2023-12-04 Thread Thomas Weise (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Weise updated FLINK-27529: - Fix Version/s: 1.19.0 > HybridSourceSplitEnumerator sourceIndex using error Integer check >

Re: [PR] [FLINK-27529] [connector/common] Fix Integer Comparison For HybridSource sourceIndex [flink]

2023-12-04 Thread via GitHub
tweise merged PR #23703: URL: https://github.com/apache/flink/pull/23703 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

Re: [PR] [FLINK-33702][core] Add the IncrementalDelayRetryStrategy implementation of RetryStrategy [flink]

2023-12-04 Thread via GitHub
xiangyuf commented on code in PR #23834: URL: https://github.com/apache/flink/pull/23834#discussion_r1414779221 ## flink-core/src/test/java/org/apache/flink/util/concurrent/FixedRetryStrategyTest.java: ## @@ -49,6 +49,5 @@ public void testRetryFailure() {

Re: [PR] [FLINK-32993][table] Datagen connector handles length-constrained fields according to the schema definition by default [flink]

2023-12-04 Thread via GitHub
liyubin117 commented on PR #23678: URL: https://github.com/apache/flink/pull/23678#issuecomment-1839898221 @LadyForest I have updated commits and rebased on the latest branch, now CI passed, PLAL, thanks! -- This is an automated message from the Apache Git Service. To respond to the messa

Re: [PR] [DRAFT] Experiment of bulk sync task states [flink]

2023-12-04 Thread via GitHub
flinkbot commented on PR #23871: URL: https://github.com/apache/flink/pull/23871#issuecomment-1839894419 ## CI report: * df74296cceaecbec9a8252b18762b04e9029f8c1 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [DRAFT] Experiment of bulk sync task states [flink]

2023-12-04 Thread via GitHub
KarmaGYZ opened a new pull request, #23871: URL: https://github.com/apache/flink/pull/23871 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

Re: [PR] [FLINK-33702][core] Add the IncrementalDelayRetryStrategy implementation of RetryStrategy [flink]

2023-12-04 Thread via GitHub
huwh commented on code in PR #23834: URL: https://github.com/apache/flink/pull/23834#discussion_r1414760052 ## flink-core/src/test/java/org/apache/flink/util/concurrent/FixedRetryStrategyTest.java: ## @@ -49,6 +49,5 @@ public void testRetryFailure() {

Re: [PR] [FLINK-33500][Runtime] Run storing the JobGraph an asynchronous operation [flink]

2023-12-04 Thread via GitHub
zhengzhili333 closed pull request #23866: [FLINK-33500][Runtime] Run storing the JobGraph an asynchronous operation URL: https://github.com/apache/flink/pull/23866 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] [FLINK-32949][core]collect tm port binding with TaskManagerOptions [flink]

2023-12-04 Thread via GitHub
flinkbot commented on PR #23870: URL: https://github.com/apache/flink/pull/23870#issuecomment-1839718853 ## CI report: * bafa44ff546c1b700477451f19e6bf924ac1d8ec UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLIP-321] Update the docs to add migration periods for deprecated APIs. [flink]

2023-12-04 Thread via GitHub
becketqin commented on PR #23865: URL: https://github.com/apache/flink/pull/23865#issuecomment-1839717057 @pvary @mbalassi @gaborgsomogyi @JingGe Thanks a lot for the reviews. From what I understand, FLIP-321 does not change the API stability guarantee, it only specifies a migration p

Re: [PR] [FLINK-27529] Fix Integer Comparison For Source Index in Hybrid Source [flink]

2023-12-04 Thread via GitHub
tweise commented on PR #23703: URL: https://github.com/apache/flink/pull/23703#issuecomment-1839716810 @varun1729DD whoops, it appears the CI already run for the most recent commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] [FLINK-27529] Fix Integer Comparison For Source Index in Hybrid Source [flink]

2023-12-04 Thread via GitHub
tweise commented on PR #23703: URL: https://github.com/apache/flink/pull/23703#issuecomment-1839715321 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[jira] [Updated] (FLINK-32949) Allow specifying the ServerSocket port for the collect function when accessing the TaskManager from the client.

2023-12-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32949: --- Labels: pull-request-available (was: ) > Allow specifying the ServerSocket port for the col

[PR] [FLINK-32949][core]collect tm port binding with TaskManagerOptions [flink]

2023-12-04 Thread via GitHub
JingGe opened a new pull request, #23870: URL: https://github.com/apache/flink/pull/23870 ## What is the purpose of the change CollectSinkFunction$ServerThread uses configured port ## Brief change log - Add new TaskManagerOptions#COLLECT_PORT - CollectSink

[jira] [Assigned] (FLINK-32949) Allow specifying the ServerSocket port for the collect function when accessing the TaskManager from the client.

2023-12-04 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Ge reassigned FLINK-32949: --- Assignee: Jing Ge > Allow specifying the ServerSocket port for the collect function when > accessi

Re: [PR] [FLINK-33500][Runtime] Run storing the JobGraph an asynchronous operation [flink]

2023-12-04 Thread via GitHub
zhengzhili333 commented on PR #23866: URL: https://github.com/apache/flink/pull/23866#issuecomment-1839406526 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] [FLINK-27529] Fix Intger Comparison For Source Index in Hybrid Source [flink]

2023-12-04 Thread via GitHub
varun1729DD commented on PR #23703: URL: https://github.com/apache/flink/pull/23703#issuecomment-1839249495 @tweise can you help me run the CI/CD please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [FLINK-33470] Implement restore tests for Join node [flink]

2023-12-04 Thread via GitHub
flinkbot commented on PR #23869: URL: https://github.com/apache/flink/pull/23869#issuecomment-1839167824 ## CI report: * e31e886a9f79fb413cffc74e685356d5d8e6ea7c UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33470] Implement restore tests for Join node [flink]

2023-12-04 Thread via GitHub
jnh5y commented on PR #23869: URL: https://github.com/apache/flink/pull/23869#issuecomment-1839158522 This PR adds back the JoinRestore tests (https://github.com/apache/flink/pull/23680) which were reverted (https://github.com/apache/flink/pull/23861) after CI failures. The issues

[PR] [FLINK-33470] Implement restore tests for Join node [flink]

2023-12-04 Thread via GitHub
jnh5y opened a new pull request, #23869: URL: https://github.com/apache/flink/pull/23869 ## What is the purpose of the change Implement restore tests for Join node * Adds a clearData method to clean up the TestValuesFactory between RestoreTests. ## Verifying this change

Re: [PR] [FLINK-32986][test] Fix createTemporaryFunction type inference error [flink]

2023-12-04 Thread via GitHub
snuyanzin commented on PR #23586: URL: https://github.com/apache/flink/pull/23586#issuecomment-1839102748 does it really make sense if for each test in `@BeforeEach` there a new `tEnv` is created like ``` this.tEnv = StreamTableEnvironment.create(env, setting) ``` ? -- This is

[jira] [Commented] (FLINK-33305) Allow to customize arg line for connector's surefire plugin

2023-12-04 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792948#comment-17792948 ] Sergey Nuyanzin commented on FLINK-33305: - Merged as [ac09d18d874691f00629c9072

[jira] [Updated] (FLINK-33305) Allow to customize arg line for connector's surefire plugin

2023-12-04 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-33305: Fix Version/s: connector-parent-1.1.0 > Allow to customize arg line for connector's surefi

[jira] [Closed] (FLINK-33305) Allow to customize arg line for connector's surefire plugin

2023-12-04 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin closed FLINK-33305. --- > Allow to customize arg line for connector's surefire plugin >

[jira] [Resolved] (FLINK-33305) Allow to customize arg line for connector's surefire plugin

2023-12-04 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin resolved FLINK-33305. - Resolution: Fixed > Allow to customize arg line for connector's surefire plugin > --

Re: [PR] [FLINK-33305] Allow to customize arg line for connector's surefire plugin [flink-connector-shared-utils]

2023-12-04 Thread via GitHub
echauchot merged PR #25: URL: https://github.com/apache/flink-connector-shared-utils/pull/25 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsu

Re: [PR] [FLINK-33726][sql-client] print time cost for streaming queries [flink]

2023-12-04 Thread via GitHub
flinkbot commented on PR #23868: URL: https://github.com/apache/flink/pull/23868#issuecomment-1838941902 ## CI report: * 7ee560b4b3fb9b365eb672e63b13062a49dcceb4 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLIP-321] Update the docs to add migration periods for deprecated APIs. [flink]

2023-12-04 Thread via GitHub
gaborgsomogyi commented on PR #23865: URL: https://github.com/apache/flink/pull/23865#issuecomment-1838941714 I've had an in-depth look on the compatibility guarantee matrix together with the deprecation policy and here are my findings: * The doc basically looks good from content perspect

[jira] [Updated] (FLINK-33726) Print cost time for stream queries in SQL Client

2023-12-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33726: --- Labels: pull-request-available (was: ) > Print cost time for stream queries in SQL Client >

[PR] [FLINK-33726][sql-client] print time cost for streaming queries [flink]

2023-12-04 Thread via GitHub
JingGe opened a new pull request, #23868: URL: https://github.com/apache/flink/pull/23868 ## What is the purpose of the change print time cost for streaming queries ## Verifying this change New test cases have been added and are covered by CliTableauResultViewTest.

Re: [PR] [FLINK-32986][test] Fix createTemporaryFunction type inference error [flink]

2023-12-04 Thread via GitHub
jeyhunkarimov commented on PR #23586: URL: https://github.com/apache/flink/pull/23586#issuecomment-1838902148 > > Mainly because of this comment: https://github.com/apache/flink/blob/7eaa5db30244b8b5d9cdc6ab0cb327e255d6fadc/flink-table/flink-table-planner/src/test/scala/org/apache/flink/tabl

Re: [PR] [FLINK-33710] Prevent triggering cluster upgrades for permutations of the same overrides [flink-kubernetes-operator]

2023-12-04 Thread via GitHub
mxm commented on code in PR #721: URL: https://github.com/apache/flink-kubernetes-operator/pull/721#discussion_r1414078197 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/AbstractFlinkResourceReconciler.java: ## @@ -186,7 +1

Re: [PR] [FLINK-33710] Prevent triggering cluster upgrades for permutations of the same overrides [flink-kubernetes-operator]

2023-12-04 Thread via GitHub
mxm commented on code in PR #721: URL: https://github.com/apache/flink-kubernetes-operator/pull/721#discussion_r1414076122 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/AbstractFlinkResourceReconciler.java: ## @@ -186,7 +1

[jira] [Updated] (FLINK-33645) Env vars in config not added to Taskmanagers in Standalone mode

2023-12-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33645: --- Labels: pull-request-available (was: ) > Env vars in config not added to Taskmanagers in St

  1   2   >