Re: [PR] [FLINK-33645] Taskmanager env vars in config not given to taskmanager [flink-kubernetes-operator]

2023-12-07 Thread via GitHub
gyfora merged PR #722: URL: https://github.com/apache/flink-kubernetes-operator/pull/722 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

Re: [PR] [FLINK-33763] Support savepoint redeployment through a nonce [flink-kubernetes-operator]

2023-12-07 Thread via GitHub
gyfora commented on code in PR #724: URL: https://github.com/apache/flink-kubernetes-operator/pull/724#discussion_r1418551584 ## docs/content/docs/custom-resource/reference.md: ## @@ -125,6 +125,7 @@ This page serves as a full reference for FlinkDeployment custom resource defi

Re: [PR] [Flink 31966] Flink Kubernetes operator lacks TLS support [flink-kubernetes-operator]

2023-12-07 Thread via GitHub
gaborgsomogyi commented on code in PR #712: URL: https://github.com/apache/flink-kubernetes-operator/pull/712#discussion_r1418562000 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/AbstractFlinkService.java: ## @@ -199,6 +202,10 @@ public

[jira] [Commented] (FLINK-33666) MergeTableLikeUtil uses different constraint name than Schema

2023-12-07 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794086#comment-17794086 ] Timo Walther commented on FLINK-33666: -- Thanks [~jeyhunkarimov] for working on this

[jira] [Assigned] (FLINK-33666) MergeTableLikeUtil uses different constraint name than Schema

2023-12-07 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther reassigned FLINK-33666: Assignee: Jeyhun Karimov > MergeTableLikeUtil uses different constraint name than Schema

Re: [PR] [FLINK-33556] Test infrastructure for externalized python code [flink]

2023-12-07 Thread via GitHub
gaborgsomogyi merged PR #23843: URL: https://github.com/apache/flink/pull/23843 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink

[jira] [Commented] (FLINK-33556) Test infrastructure for externalized python code

2023-12-07 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794087#comment-17794087 ] Gabor Somogyi commented on FLINK-33556: --- e4f3898 on master > Test infrastructure

Re: [PR] [FLINK-33666][table] Use the same constraint name in MergeTableLikeUtil and Schema [flink]

2023-12-07 Thread via GitHub
twalthr merged PR #23877: URL: https://github.com/apache/flink/pull/23877 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apach

[jira] [Closed] (FLINK-33666) MergeTableLikeUtil uses different constraint name than Schema

2023-12-07 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther closed FLINK-33666. Fix Version/s: 1.19.0 Resolution: Fixed Fixed in master: ca1c7ce48127472a7c7965099f8a722754

Re: [PR] [FLINK-33556][CI] Test infrastructure for externalized python code [flink-connector-shared-utils]

2023-12-07 Thread via GitHub
gaborgsomogyi commented on code in PR #27: URL: https://github.com/apache/flink-connector-shared-utils/pull/27#discussion_r1418597424 ## python/build-wheels.sh: ## @@ -0,0 +1,52 @@ +#!/usr/bin/env bash +# Licensed to the Apache Software Foundation (ASF) under one or more +# con

Re: [PR] [FLINK-33556][CI] Test infrastructure for externalized python code [flink-connector-shared-utils]

2023-12-07 Thread via GitHub
gaborgsomogyi commented on code in PR #27: URL: https://github.com/apache/flink-connector-shared-utils/pull/27#discussion_r1418597424 ## python/build-wheels.sh: ## @@ -0,0 +1,52 @@ +#!/usr/bin/env bash +# Licensed to the Apache Software Foundation (ASF) under one or more +# con

[jira] [Commented] (FLINK-33734) Merge unaligned checkpoint state handle

2023-12-07 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794090#comment-17794090 ] Piotr Nowojski commented on FLINK-33734: Recovery times are very often important

[jira] [Updated] (FLINK-33693) Force aligned barrier logic doesn't work when the aligned checkpoint timeout is enabled

2023-12-07 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-33693: --- Priority: Critical (was: Major) > Force aligned barrier logic doesn't work when the aligned

Re: [PR] [FLINK-33556][CI] Test infrastructure for externalized python code [flink-connector-shared-utils]

2023-12-07 Thread via GitHub
pvary commented on code in PR #27: URL: https://github.com/apache/flink-connector-shared-utils/pull/27#discussion_r1418653139 ## python/build-wheels.sh: ## @@ -0,0 +1,52 @@ +#!/usr/bin/env bash +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

Re: [PR] [FLINK-33556][CI] Test infrastructure for externalized python code [flink-connector-shared-utils]

2023-12-07 Thread via GitHub
gaborgsomogyi commented on code in PR #27: URL: https://github.com/apache/flink-connector-shared-utils/pull/27#discussion_r1418665568 ## python/build-wheels.sh: ## @@ -0,0 +1,52 @@ +#!/usr/bin/env bash +# Licensed to the Apache Software Foundation (ASF) under one or more +# con

[jira] [Resolved] (FLINK-33556) Test infrastructure for externalized python code

2023-12-07 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Somogyi resolved FLINK-33556. --- Resolution: Fixed > Test infrastructure for externalized python code > -

[jira] [Commented] (FLINK-33556) Test infrastructure for externalized python code

2023-12-07 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794102#comment-17794102 ] Gabor Somogyi commented on FLINK-33556: --- 7691962 on ci_utils > Test infrastructur

Re: [PR] [FLINK-33556][CI] Test infrastructure for externalized python code [flink-connector-shared-utils]

2023-12-07 Thread via GitHub
gaborgsomogyi merged PR #27: URL: https://github.com/apache/flink-connector-shared-utils/pull/27 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-

[jira] [Closed] (FLINK-33556) Test infrastructure for externalized python code

2023-12-07 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Somogyi closed FLINK-33556. - > Test infrastructure for externalized python code > ---

Re: [PR] [FLINK-33693][checkpoint] Force aligned barrier works with timeoutable aligned checkpoint barrier [flink]

2023-12-07 Thread via GitHub
pnowojski commented on PR #23850: URL: https://github.com/apache/flink/pull/23850#issuecomment-1845016221 Ops, that's a dangerous bug. Thanks for fixing it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [FLINK-32894] Use 3.5.1 for maven-shade-plugin to support Java 17 [flink-connector-shared-utils]

2023-12-07 Thread via GitHub
snuyanzin merged PR #20: URL: https://github.com/apache/flink-connector-shared-utils/pull/20 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsu

[jira] [Closed] (FLINK-32894) flink-connector-parent should use maven-shade-plugin 3.3.0+ for Java 17

2023-12-07 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin closed FLINK-32894. --- > flink-connector-parent should use maven-shade-plugin 3.3.0+ for Java 17 >

[jira] [Assigned] (FLINK-32894) flink-connector-parent should use maven-shade-plugin 3.3.0+ for Java 17

2023-12-07 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin reassigned FLINK-32894: --- Assignee: Qingsheng Ren > flink-connector-parent should use maven-shade-plugin 3.3.

[jira] [Resolved] (FLINK-32894) flink-connector-parent should use maven-shade-plugin 3.3.0+ for Java 17

2023-12-07 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin resolved FLINK-32894. - Fix Version/s: connector-parent-1.1.0 Resolution: Fixed > flink-connector-parent

[jira] [Commented] (FLINK-32894) flink-connector-parent should use maven-shade-plugin 3.3.0+ for Java 17

2023-12-07 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794107#comment-17794107 ] Sergey Nuyanzin commented on FLINK-32894: - Merged as [7c2745af777c6681b9eb14f0

Re: [PR] [FLINK-33708][FLINK-33709] Introduce TraceReporter and use it to create checkpointing traces [flink]

2023-12-07 Thread via GitHub
pnowojski commented on code in PR #23845: URL: https://github.com/apache/flink/pull/23845#discussion_r1418691746 ## docs/content/docs/deployment/config.md: ## @@ -289,6 +289,15 @@ Enabling RocksDB's native metrics may cause degraded performance and should be s +#

Re: [PR] [FLINK-33708][FLINK-33709] Introduce TraceReporter and use it to create checkpointing traces [flink]

2023-12-07 Thread via GitHub
pnowojski commented on code in PR #23845: URL: https://github.com/apache/flink/pull/23845#discussion_r1418691746 ## docs/content/docs/deployment/config.md: ## @@ -289,6 +289,15 @@ Enabling RocksDB's native metrics may cause degraded performance and should be s +#

Re: [PR] [FLINK-33708][FLINK-33709] Introduce TraceReporter and use it to create checkpointing traces [flink]

2023-12-07 Thread via GitHub
pnowojski commented on code in PR #23845: URL: https://github.com/apache/flink/pull/23845#discussion_r1418691746 ## docs/content/docs/deployment/config.md: ## @@ -289,6 +289,15 @@ Enabling RocksDB's native metrics may cause degraded performance and should be s +#

Re: [PR] [FLINK-32881][checkpoint] Support triggering savepoint in detach mode for CLI and dumping all pending savepoint ids by rest api [flink]

2023-12-07 Thread via GitHub
xiangforever2014 commented on PR #23253: URL: https://github.com/apache/flink/pull/23253#issuecomment-1845053733 @masteryhx Hello, I have updated the code according to your comment, PTAL~ Here are the test results: 1. trigger the normal savepoint, the client gets a timeout exception:

[jira] [Created] (FLINK-33769) ExternalSorter hits "java.lang.RuntimeException: Error obtaining the sorted input: Thread 'SortMerger Reading Thread' terminated due to an exception: java.io.EOFExceptio

2023-12-07 Thread Vishal Palla (Jira)
Vishal Palla created FLINK-33769: Summary: ExternalSorter hits "java.lang.RuntimeException: Error obtaining the sorted input: Thread 'SortMerger Reading Thread' terminated due to an exception: java.io.EOFException: Can't collect further: memorySo

[jira] [Updated] (FLINK-33769) ExternalSorter hits "java.lang.RuntimeException: Error obtaining the sorted input: Thread 'SortMerger Reading Thread' terminated due to an exception: java.io.EOFExceptio

2023-12-07 Thread Vishal Palla (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vishal Palla updated FLINK-33769: - Description: The [NormalizedKeySorter library|https://github.com/twitter-forks/flink/blob/maste

[jira] [Updated] (FLINK-33769) ExternalSorter hits "java.lang.RuntimeException: Error obtaining the sorted input: Thread 'SortMerger Reading Thread' terminated due to an exception: java.io.EOFExceptio

2023-12-07 Thread Vishal Palla (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vishal Palla updated FLINK-33769: - Description: The [NormalizedKeySorter library|https://github.com/twitter-forks/flink/blob/maste

[jira] [Updated] (FLINK-33769) ExternalSorter hits "java.lang.RuntimeException: Error obtaining the sorted input: Thread 'SortMerger Reading Thread' terminated due to an exception: java.io.EOFExceptio

2023-12-07 Thread Vishal Palla (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vishal Palla updated FLINK-33769: - Description: The [NormalizedKeySorter library|https://github.com/twitter-forks/flink/blob/maste

[jira] [Updated] (FLINK-33769) ExternalSorter hits "java.lang.RuntimeException: Error obtaining the sorted input: Thread 'SortMerger Reading Thread' terminated due to an exception: java.io.EOFExceptio

2023-12-07 Thread Vishal Palla (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vishal Palla updated FLINK-33769: - Description: The [NormalizedKeySorter library|https://github.com/twitter-forks/flink/blob/maste

[jira] [Updated] (FLINK-33769) ExternalSorter hits "java.lang.RuntimeException: Error obtaining the sorted input: Thread 'SortMerger Reading Thread' terminated due to an exception: java.io.EOFExceptio

2023-12-07 Thread Vishal Palla (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vishal Palla updated FLINK-33769: - Description: The [NormalizedKeySorter library|https://github.com/twitter-forks/flink/blob/maste

[jira] [Updated] (FLINK-33769) ExternalSorter hits "java.lang.RuntimeException: Error obtaining the sorted input: Thread 'SortMerger Reading Thread' terminated due to an exception: java.io.EOFExceptio

2023-12-07 Thread Vishal Palla (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vishal Palla updated FLINK-33769: - Description: The [NormalizedKeySorter library|https://github.com/twitter-forks/flink/blob/maste

Re: [PR] [Flink 31966] Flink Kubernetes operator lacks TLS support [flink-kubernetes-operator]

2023-12-07 Thread via GitHub
tagarr commented on code in PR #712: URL: https://github.com/apache/flink-kubernetes-operator/pull/712#discussion_r1418729320 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/AbstractFlinkService.java: ## @@ -199,6 +202,10 @@ public void s

Re: [PR] [FLINK-25857] Add committer metrics to track the status of committables - non-breaking [flink]

2023-12-07 Thread via GitHub
gyfora commented on PR #23876: URL: https://github.com/apache/flink/pull/23876#issuecomment-1845098469 @reswqa I suggest we focus on reviewing and merging this quickly instead of putting extra work on @pvary . -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [FLINK-33693][checkpoint] Force aligned barrier works with timeoutable aligned checkpoint barrier [flink]

2023-12-07 Thread via GitHub
1996fanrui merged PR #23850: URL: https://github.com/apache/flink/pull/23850 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.ap

[PR] [FLINK-33693][checkpoint] Force aligned barrier works with timeoutable aligned checkpoint barrier [flink]

2023-12-07 Thread via GitHub
1996fanrui opened a new pull request, #23888: URL: https://github.com/apache/flink/pull/23888 Backporting the #23850 to 1.18 [FLINK-33693][checkpoint] Force aligned barrier works with timeoutable aligned checkpoint barrier -- This is an automated message from the Apache Git Ser

[PR] [FLINK-33693][checkpoint] Force aligned barrier works with timeoutable aligned checkpoint barrier [flink]

2023-12-07 Thread via GitHub
1996fanrui opened a new pull request, #23889: URL: https://github.com/apache/flink/pull/23889 Backporting the https://github.com/apache/flink/pull/23850 to 1.17 [FLINK-33693][checkpoint] Force aligned barrier works with timeoutable aligned checkpoint barrier -- This is an automated

Re: [PR] [FLINK-33693][checkpoint] Force aligned barrier works with timeoutable aligned checkpoint barrier [flink]

2023-12-07 Thread via GitHub
flinkbot commented on PR #23888: URL: https://github.com/apache/flink/pull/23888#issuecomment-1845120307 ## CI report: * a44abf97e89e4a4939e6bdd5c5f2a45fcc846100 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-33523) DataType ARRAY fails to cast into Object[]

2023-12-07 Thread Peter Vary (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794128#comment-17794128 ] Peter Vary commented on FLINK-33523: Created a thread about this topic on the mailin

Re: [PR] [FLINK-33693][checkpoint] Force aligned barrier works with timeoutable aligned checkpoint barrier [flink]

2023-12-07 Thread via GitHub
flinkbot commented on PR #23889: URL: https://github.com/apache/flink/pull/23889#issuecomment-1845128895 ## CI report: * 5ca3dae2742b9f6d671f7c481d3380b3ac57c3fc UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33708][FLINK-33709] Introduce TraceReporter and use it to create checkpointing traces [flink]

2023-12-07 Thread via GitHub
zentol commented on code in PR #23845: URL: https://github.com/apache/flink/pull/23845#discussion_r1418790359 ## docs/content/docs/deployment/config.md: ## @@ -289,6 +289,15 @@ Enabling RocksDB's native metrics may cause degraded performance and should be s +# Tra

Re: [PR] [FLINK-33708][FLINK-33709] Introduce TraceReporter and use it to create checkpointing traces [flink]

2023-12-07 Thread via GitHub
zentol commented on code in PR #23845: URL: https://github.com/apache/flink/pull/23845#discussion_r1418790359 ## docs/content/docs/deployment/config.md: ## @@ -289,6 +289,15 @@ Enabling RocksDB's native metrics may cause degraded performance and should be s +# Tra

Re: [PR] [FLINK-33708][FLINK-33709] Introduce TraceReporter and use it to create checkpointing traces [flink]

2023-12-07 Thread via GitHub
zentol commented on code in PR #23845: URL: https://github.com/apache/flink/pull/23845#discussion_r1418790359 ## docs/content/docs/deployment/config.md: ## @@ -289,6 +289,15 @@ Enabling RocksDB's native metrics may cause degraded performance and should be s +# Tra

Re: [PR] [FLINK-32073][checkpoint] Implement file merging in snapshot [flink]

2023-12-07 Thread via GitHub
AlexYinHan commented on code in PR #23514: URL: https://github.com/apache/flink/pull/23514#discussion_r1418795527 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/filesystem/FileMergingCheckpointStateOutputStream.java: ## @@ -0,0 +1,255 @@ +/* + * Licensed to the Ap

Re: [PR] [FLINK-25857] Add committer metrics to track the status of committables - non-breaking [flink]

2023-12-07 Thread via GitHub
pvary commented on PR #23876: URL: https://github.com/apache/flink/pull/23876#issuecomment-1845155479 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Add Java client library update process to the Upgrade page [flink-kubernetes-operator]

2023-12-07 Thread via GitHub
mxm merged PR #723: URL: https://github.com/apache/flink-kubernetes-operator/pull/723 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

Re: [PR] [FLINK-32073][checkpoint] Implement file merging in snapshot [flink]

2023-12-07 Thread via GitHub
AlexYinHan commented on code in PR #23514: URL: https://github.com/apache/flink/pull/23514#discussion_r1418798290 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/filesystem/FileMergingCheckpointStateOutputStream.java: ## @@ -0,0 +1,255 @@ +/* + * Licensed to the Ap

Re: [PR] [FLINK-33763] Support savepoint redeployment through a nonce [flink-kubernetes-operator]

2023-12-07 Thread via GitHub
mxm commented on code in PR #724: URL: https://github.com/apache/flink-kubernetes-operator/pull/724#discussion_r1418806188 ## docs/content/docs/custom-resource/job-management.md: ## @@ -288,12 +288,33 @@ Rollback is currently only supported for `FlinkDeployments`. ## Manual

Re: [PR] [FLINK-33708][FLINK-33709] Introduce TraceReporter and use it to create checkpointing traces [flink]

2023-12-07 Thread via GitHub
pnowojski commented on code in PR #23845: URL: https://github.com/apache/flink/pull/23845#discussion_r1418813358 ## docs/content/docs/deployment/config.md: ## @@ -289,6 +289,15 @@ Enabling RocksDB's native metrics may cause degraded performance and should be s +#

Re: [PR] [FLINK-33708][FLINK-33709] Introduce TraceReporter and use it to create checkpointing traces [flink]

2023-12-07 Thread via GitHub
pnowojski commented on code in PR #23845: URL: https://github.com/apache/flink/pull/23845#discussion_r1418813358 ## docs/content/docs/deployment/config.md: ## @@ -289,6 +289,15 @@ Enabling RocksDB's native metrics may cause degraded performance and should be s +#

Re: [PR] [FLINK-33708][FLINK-33709] Introduce TraceReporter and use it to create checkpointing traces [flink]

2023-12-07 Thread via GitHub
pnowojski commented on code in PR #23845: URL: https://github.com/apache/flink/pull/23845#discussion_r1418813358 ## docs/content/docs/deployment/config.md: ## @@ -289,6 +289,15 @@ Enabling RocksDB's native metrics may cause degraded performance and should be s +#

Re: [PR] [FLINK-33708][FLINK-33709] Introduce TraceReporter and use it to create checkpointing traces [flink]

2023-12-07 Thread via GitHub
pnowojski commented on code in PR #23845: URL: https://github.com/apache/flink/pull/23845#discussion_r1418813358 ## docs/content/docs/deployment/config.md: ## @@ -289,6 +289,15 @@ Enabling RocksDB's native metrics may cause degraded performance and should be s +#

Re: [PR] [FLINK-33708][FLINK-33709] Introduce TraceReporter and use it to create checkpointing traces [flink]

2023-12-07 Thread via GitHub
pnowojski commented on code in PR #23845: URL: https://github.com/apache/flink/pull/23845#discussion_r1418813358 ## docs/content/docs/deployment/config.md: ## @@ -289,6 +289,15 @@ Enabling RocksDB's native metrics may cause degraded performance and should be s +#

Re: [PR] [FLINK-33708][FLINK-33709] Introduce TraceReporter and use it to create checkpointing traces [flink]

2023-12-07 Thread via GitHub
pnowojski commented on code in PR #23845: URL: https://github.com/apache/flink/pull/23845#discussion_r1418813358 ## docs/content/docs/deployment/config.md: ## @@ -289,6 +289,15 @@ Enabling RocksDB's native metrics may cause degraded performance and should be s +#

Re: [PR] [FLINK-33708][FLINK-33709] Introduce TraceReporter and use it to create checkpointing traces [flink]

2023-12-07 Thread via GitHub
pnowojski commented on code in PR #23845: URL: https://github.com/apache/flink/pull/23845#discussion_r1418813358 ## docs/content/docs/deployment/config.md: ## @@ -289,6 +289,15 @@ Enabling RocksDB's native metrics may cause degraded performance and should be s +#

Re: [PR] [FLINK-25857] Add committer metrics to track the status of committables - non-breaking [flink]

2023-12-07 Thread via GitHub
gyfora commented on code in PR #23876: URL: https://github.com/apache/flink/pull/23876#discussion_r1418837627 ## flink-python/pyflink/datastream/connectors/tests/test_pulsar.py: ## @@ -253,7 +250,6 @@ def test_pulsar_sink(self): .long_type() .no

Re: [PR] [FLINK-33763] Support savepoint redeployment through a nonce [flink-kubernetes-operator]

2023-12-07 Thread via GitHub
gyfora commented on code in PR #724: URL: https://github.com/apache/flink-kubernetes-operator/pull/724#discussion_r1418846318 ## flink-kubernetes-operator-api/src/main/java/org/apache/flink/kubernetes/operator/api/diff/DiffType.java: ## @@ -28,7 +28,9 @@ public enum DiffType {

Re: [PR] [FLINK-33763] Support savepoint redeployment through a nonce [flink-kubernetes-operator]

2023-12-07 Thread via GitHub
gyfora commented on code in PR #724: URL: https://github.com/apache/flink-kubernetes-operator/pull/724#discussion_r1418847581 ## docs/content/docs/custom-resource/job-management.md: ## @@ -288,12 +288,33 @@ Rollback is currently only supported for `FlinkDeployments`. ## Man

Re: [PR] [FLINK-33763] Support savepoint redeployment through a nonce [flink-kubernetes-operator]

2023-12-07 Thread via GitHub
gyfora commented on code in PR #724: URL: https://github.com/apache/flink-kubernetes-operator/pull/724#discussion_r1418852248 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/AbstractJobReconciler.java: ## @@ -306,6 +319,40 @

[jira] [Commented] (FLINK-33734) Merge unaligned checkpoint state handle

2023-12-07 Thread Feifan Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794146#comment-17794146 ] Feifan Wang commented on FLINK-33734: - We do also want to improve the speed of recov

Re: [PR] [FLINK-33763] Support savepoint redeployment through a nonce [flink-kubernetes-operator]

2023-12-07 Thread via GitHub
gyfora commented on code in PR #724: URL: https://github.com/apache/flink-kubernetes-operator/pull/724#discussion_r1418855770 ## flink-kubernetes-operator-api/src/main/java/org/apache/flink/kubernetes/operator/api/diff/DiffType.java: ## @@ -28,7 +28,9 @@ public enum DiffType {

Re: [PR] [FLINK-33763] Support savepoint redeployment through a nonce [flink-kubernetes-operator]

2023-12-07 Thread via GitHub
gyfora commented on code in PR #724: URL: https://github.com/apache/flink-kubernetes-operator/pull/724#discussion_r1418865579 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/AbstractJobReconciler.java: ## @@ -306,6 +319,40 @

[jira] [Updated] (FLINK-33523) DataType ARRAY fails to cast into Object[]

2023-12-07 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-33523: --- Priority: Blocker (was: Major) > DataType ARRAY fails to cast into Object[] > -

Re: [PR] [FLINK-33713][core] Deprecate RuntimeContext#getExecutionConfig [flink]

2023-12-07 Thread via GitHub
JunRuiLee commented on PR #23848: URL: https://github.com/apache/flink/pull/23848#issuecomment-1845235972 > The usages of the deprecated interface should also be removed from `CepRuntimeContextTest` and `RichAsyncFunctionTest`. Thanks for pointing that out. I have updated the pull req

Re: [PR] [Flink 31966] Flink Kubernetes operator lacks TLS support [flink-kubernetes-operator]

2023-12-07 Thread via GitHub
gyfora merged PR #712: URL: https://github.com/apache/flink-kubernetes-operator/pull/712 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

[jira] [Closed] (FLINK-33645) Env vars in config not added to Taskmanagers in Standalone mode

2023-12-07 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-33645. -- Assignee: Tony Garrard Resolution: Fixed merged to main e4528260be78dabeb6552afda10e78802021984d

[jira] [Closed] (FLINK-31966) Flink Kubernetes operator lacks TLS support

2023-12-07 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-31966. -- Fix Version/s: kubernetes-operator-1.8.0 Resolution: Fixed merged to main 30566ed7390a4fce1dc3e

Re: [PR] [FLINK-30064] Move existing Hive connector code from Flink repo to dedicated Hive repo [flink-connector-hive]

2023-12-07 Thread via GitHub
MartijnVisser commented on PR #5: URL: https://github.com/apache/flink-connector-hive/pull/5#issuecomment-1845250800 > I want to make sure we can have a chance to test & verify it with hive3. Good point. I actually think we should consider running them both for each PR, that should b

[jira] [Commented] (FLINK-31275) Flink supports reporting and storage of source/sink tables relationship

2023-12-07 Thread Maciej Obuchowski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794165#comment-17794165 ] Maciej Obuchowski commented on FLINK-31275: --- Hey [~zjureel]. Had additional id

Re: [PR] [FLINK-30064] Move existing Hive connector code from Flink repo to dedicated Hive repo [flink-connector-hive]

2023-12-07 Thread via GitHub
MartijnVisser commented on PR #5: URL: https://github.com/apache/flink-connector-hive/pull/5#issuecomment-1845282371 > I will see if it could be supported on a generic way since same functionality would be nice to have for OpenSearch connector We could consider adding `optional_maven

[jira] [Commented] (FLINK-33523) DataType ARRAY fails to cast into Object[]

2023-12-07 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794170#comment-17794170 ] Timo Walther commented on FLINK-33523: -- Thanks for reporting this issue [~prabhujos

Re: [PR] [FLINK-33703] Use maven 3.8.6 for release profile [flink-shaded]

2023-12-07 Thread via GitHub
XComp commented on code in PR #131: URL: https://github.com/apache/flink-shaded/pull/131#discussion_r1418913528 ## pom.xml: ## @@ -133,8 +133,7 @@ under the License. 1.8.0

[jira] [Updated] (FLINK-33523) DataType ARRAY fails to cast into Object[]

2023-12-07 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-33523: --- Fix Version/s: 1.18.1 > DataType ARRAY fails to cast into Object[] > ---

Re: [PR] [FLINK-33758] Implement restore tests for TemporalSort node [flink]

2023-12-07 Thread via GitHub
dawidwys merged PR #23879: URL: https://github.com/apache/flink/pull/23879 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

[jira] [Closed] (FLINK-33758) Implement restore tests for TemporalSort node

2023-12-07 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz closed FLINK-33758. Resolution: Implemented Implemented in f751a00fd6f0e70187d2a9ae2ccd6a728d9a2c64 > Impleme

[jira] [Commented] (FLINK-31835) DataTypeHint don't support Row>

2023-12-07 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794179#comment-17794179 ] Timo Walther commented on FLINK-31835: -- {quote} My only concern is the compatibilit

[jira] [Updated] (FLINK-33488) Implement restore tests for Deduplicate node

2023-12-07 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz updated FLINK-33488: - Fix Version/s: 1.19.0 > Implement restore tests for Deduplicate node > -

Re: [PR] [FLINK-33480] Implement restore tests for GroupAggregate node [flink]

2023-12-07 Thread via GitHub
dawidwys merged PR #23681: URL: https://github.com/apache/flink/pull/23681 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

[jira] [Closed] (FLINK-33480) Implement restore tests for GroupAggregate node

2023-12-07 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz closed FLINK-33480. Resolution: Implemented Implemented in 193b1c68976cdfbd66147278f23d7d427d9b5562..fac3ac78

[jira] [Updated] (FLINK-33480) Implement restore tests for GroupAggregate node

2023-12-07 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz updated FLINK-33480: - Fix Version/s: 1.19.0 > Implement restore tests for GroupAggregate node > --

[jira] [Updated] (FLINK-33758) Implement restore tests for TemporalSort node

2023-12-07 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz updated FLINK-33758: - Fix Version/s: 1.19.0 > Implement restore tests for TemporalSort node >

[jira] [Updated] (FLINK-33667) Implement restore tests for MatchRecognize node

2023-12-07 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz updated FLINK-33667: - Fix Version/s: 1.19.0 > Implement restore tests for MatchRecognize node > --

[PR] [hotfix] Set version to 1.1.0 and not 1.0.1 [flink-connector-shared-utils]

2023-12-07 Thread via GitHub
echauchot opened a new pull request, #28: URL: https://github.com/apache/flink-connector-shared-utils/pull/28 @snuyanzin I realised that the version label in jira was 1.1.0 and not 1.0.1 hence this update. Are the recent changes considered patches of the 1.0 version or a new minor v

[jira] [Commented] (FLINK-27681) Improve the availability of Flink when the RocksDB file is corrupted.

2023-12-07 Thread Hangxiang Yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794190#comment-17794190 ] Hangxiang Yu commented on FLINK-27681: -- {quote}Yes, I think we don't need any extra

Re: [PR] [hotfix] Set version to 1.1.0 and not 1.0.1 [flink-connector-shared-utils]

2023-12-07 Thread via GitHub
snuyanzin commented on PR #28: URL: https://github.com/apache/flink-connector-shared-utils/pull/28#issuecomment-1845318521 That's a good question... frankly I don't know the answer, in jira i selected the only available one... I didn't participate in 1.0.0 release, may be @MartijnV

Re: [PR] [FLINK-33757] Implement restore tests for Rank node [flink]

2023-12-07 Thread via GitHub
jnh5y commented on PR #23878: URL: https://github.com/apache/flink/pull/23878#issuecomment-1845326404 > lgtm > > Yes, it would be really nice if you could rebase it on top of current master. Cool. I've rebased the commits on to master. > My personal take is we should n

Re: [PR] [FLINK-33763] Support savepoint redeployment through a nonce [flink-kubernetes-operator]

2023-12-07 Thread via GitHub
mxm commented on code in PR #724: URL: https://github.com/apache/flink-kubernetes-operator/pull/724#discussion_r1418956894 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/AbstractJobReconciler.java: ## @@ -306,6 +319,40 @@ p

Re: [PR] [FLINK-33763] Support savepoint redeployment through a nonce [flink-kubernetes-operator]

2023-12-07 Thread via GitHub
mxm commented on code in PR #724: URL: https://github.com/apache/flink-kubernetes-operator/pull/724#discussion_r1418958103 ## flink-kubernetes-operator-api/src/main/java/org/apache/flink/kubernetes/operator/api/diff/DiffType.java: ## @@ -28,7 +28,9 @@ public enum DiffType {

Re: [PR] [FLINK-33763] Support savepoint redeployment through a nonce [flink-kubernetes-operator]

2023-12-07 Thread via GitHub
mxm commented on code in PR #724: URL: https://github.com/apache/flink-kubernetes-operator/pull/724#discussion_r1418959147 ## docs/content/docs/custom-resource/job-management.md: ## @@ -288,12 +288,33 @@ Rollback is currently only supported for `FlinkDeployments`. ## Manual

Re: [PR] [FLINK-33763] Support savepoint redeployment through a nonce [flink-kubernetes-operator]

2023-12-07 Thread via GitHub
mxm commented on code in PR #724: URL: https://github.com/apache/flink-kubernetes-operator/pull/724#discussion_r1418960497 ## docs/content/docs/custom-resource/job-management.md: ## @@ -288,12 +288,33 @@ Rollback is currently only supported for `FlinkDeployments`. ## Manual

Re: [PR] [FLINK-33763] Support savepoint redeployment through a nonce [flink-kubernetes-operator]

2023-12-07 Thread via GitHub
mxm commented on code in PR #724: URL: https://github.com/apache/flink-kubernetes-operator/pull/724#discussion_r1418965408 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/diff/DiffResult.java: ## @@ -101,14 +101,7 @@ public String toSt

Re: [PR] [FLINK-33763] Support savepoint redeployment through a nonce [flink-kubernetes-operator]

2023-12-07 Thread via GitHub
mxm commented on code in PR #724: URL: https://github.com/apache/flink-kubernetes-operator/pull/724#discussion_r1418970683 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/AbstractJobReconciler.java: ## @@ -306,6 +319,40 @@ p

Re: [PR] [FLINK-30064] Move existing Hive connector code from Flink repo to dedicated Hive repo [flink-connector-hive]

2023-12-07 Thread via GitHub
snuyanzin commented on PR #5: URL: https://github.com/apache/flink-connector-hive/pull/5#issuecomment-1845350918 yep, that exactly the idea i'm testing right now =) thanks for confirmation :+1: -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] [FLINK-32028][connectors/elasticsearch] Allow customising bulk failure handling [flink-connector-elasticsearch]

2023-12-07 Thread via GitHub
schulzp commented on PR #83: URL: https://github.com/apache/flink-connector-elasticsearch/pull/83#issuecomment-1845356753 @reswqa, I overrode the missing methods required by 1.18.0's `Sink.InitContext`. -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [PR] [FLINK-33541][table-planner] function RAND and RAND_INTEGER should return type nullable if the arguments are nullable [flink]

2023-12-07 Thread via GitHub
xuyangzhong commented on code in PR #23779: URL: https://github.com/apache/flink/pull/23779#discussion_r1418977594 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/expressions/ScalarFunctionsTest.scala: ## @@ -2661,6 +2665,37 @@ class ScalarFuncti

Re: [PR] [FLINK-33763] Support savepoint redeployment through a nonce [flink-kubernetes-operator]

2023-12-07 Thread via GitHub
gyfora commented on code in PR #724: URL: https://github.com/apache/flink-kubernetes-operator/pull/724#discussion_r1418985847 ## docs/content/docs/custom-resource/job-management.md: ## @@ -288,12 +288,33 @@ Rollback is currently only supported for `FlinkDeployments`. ## Man

  1   2   3   >