[jira] [Updated] (FLINK-33778) Cleanup usage of deprecated TableConfig#setIdleStateRetentionTime(Time, Time)

2023-12-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33778: --- Labels: pull-request-available (was: ) > Cleanup usage of deprecated TableConfig#setIdleSta

[PR] [FLINK-33778][table] Cleanup usage of deprecated TableConfig#setIdleS… [flink]

2023-12-07 Thread via GitHub
liuyongvs opened a new pull request, #23894: URL: https://github.com/apache/flink/pull/23894 …tateRetentionTime ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we a

[jira] [Created] (FLINK-33778) Cleanup usage of deprecated TableConfig#setIdleStateRetentionTime(Time, Time)

2023-12-07 Thread Jacky Lau (Jira)
Jacky Lau created FLINK-33778: - Summary: Cleanup usage of deprecated TableConfig#setIdleStateRetentionTime(Time, Time) Key: FLINK-33778 URL: https://issues.apache.org/jira/browse/FLINK-33778 Project: Flin

Re: [PR] [FLINK-25857] Add committer metrics to track the status of committables - non-breaking [flink]

2023-12-07 Thread via GitHub
pvary commented on PR #23876: URL: https://github.com/apache/flink/pull/23876#issuecomment-1846629590 > @pvary Thanks for the patch. I am wondering if you have compared this approach with the alternative I mentioned in the mailing list. [..] > The alternative approach has less changes

Re: [PR] [FLINK-25857] Add committer metrics to track the status of committables - non-breaking [flink]

2023-12-07 Thread via GitHub
gyfora commented on PR #23876: URL: https://github.com/apache/flink/pull/23876#issuecomment-1846625747 The alternative approach would be to deprecate the current interfaces completely (stateful / twophase) and replace them, in which case it is also much better to fix the class structure. No

Re: [PR] [FLINK-25857] Add committer metrics to track the status of committables - non-breaking [flink]

2023-12-07 Thread via GitHub
gyfora commented on PR #23876: URL: https://github.com/apache/flink/pull/23876#issuecomment-1846623532 @becketqin if I understand correctly, we do not need to replace the current interfaces in order to make them mixin. We only need to "deprecate" the inherited methods. And the chang

Re: [PR] [FLINK-33313][table] fix RexNodeExtractor#extractConjunctiveConditions throws an Exception when handle binary literal [flink]

2023-12-07 Thread via GitHub
libenchao commented on PR #23567: URL: https://github.com/apache/flink/pull/23567#issuecomment-1846557698 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-33313][table] fix RexNodeExtractor#extractConjunctiveConditions throws an Exception when handle binary literal [flink]

2023-12-07 Thread via GitHub
libenchao commented on PR #23566: URL: https://github.com/apache/flink/pull/23566#issuecomment-1846557469 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (FLINK-33338) Bump FRocksDB version

2023-12-07 Thread Yue Ma (Jira)
[ https://issues.apache.org/jira/browse/FLINK-8?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794507#comment-17794507 ] Yue Ma commented on FLINK-8: [~Yanfei Lei] Thank you very much for your help. What I

[jira] [Commented] (FLINK-27681) Improve the availability of Flink when the RocksDB file is corrupted.

2023-12-07 Thread Yue Ma (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794505#comment-17794505 ] Yue Ma commented on FLINK-27681: {quote}And the corrupted file maybe just uploaded to re

[jira] [Commented] (FLINK-33751) use modules correctly when deserializing json plan

2023-12-07 Thread shuaiqi.guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794501#comment-17794501 ] shuaiqi.guo commented on FLINK-33751: - Hi, [~libenchao] , could you have a review fo

Re: [PR] [FLINK-33647] Implement restore tests for LookupJoin node [flink]

2023-12-07 Thread via GitHub
bvarghese1 commented on code in PR #23814: URL: https://github.com/apache/flink/pull/23814#discussion_r1419886852 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/stream/LookupJoinJsonPlanTest.java: ## @@ -1,273 +0,0 @@ -/* - * Lice

Re: [PR] [FLINK-33647] Implement restore tests for LookupJoin node [flink]

2023-12-07 Thread via GitHub
bvarghese1 commented on code in PR #23814: URL: https://github.com/apache/flink/pull/23814#discussion_r1419886732 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/stream/LookupJoinJsonPlanTest.java: ## @@ -1,273 +0,0 @@ -/* - * Lice

[jira] [Commented] (FLINK-24533) Flink SQL Upsert To Hbase Appear data loss

2023-12-07 Thread tanjialiang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794492#comment-17794492 ] tanjialiang commented on FLINK-24533: - Hi [~licp], sorry for late to notice this tic

[jira] [Commented] (FLINK-29770) hbase connector supports out-of-order data

2023-12-07 Thread tanjialiang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794489#comment-17794489 ] tanjialiang commented on FLINK-29770: - [~Bo Cui] Thanks for reporting this issue, bu

Re: [PR] [FLINK-30064] Move existing Hive connector code from Flink repo to dedicated Hive repo [flink-connector-hive]

2023-12-07 Thread via GitHub
luoyuxia commented on PR #5: URL: https://github.com/apache/flink-connector-hive/pull/5#issuecomment-1846421674 @snuyanzin Cool! Thanks for your work. It sounds good to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [FLINK-25857] Add committer metrics to track the status of committables - non-breaking [flink]

2023-12-07 Thread via GitHub
becketqin commented on PR #23876: URL: https://github.com/apache/flink/pull/23876#issuecomment-1846311079 @pvary Thanks for the patch. I am wondering if you have compared this approach with the alternative I mentioned in the mailing list. > Option 1: >1. On top of the the current s

[jira] [Updated] (FLINK-33466) Bounded Kafka source never finishes after restore from savepoint

2023-12-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33466: --- Labels: pull-request-available (was: ) > Bounded Kafka source never finishes after restore

[PR] [FLINK-33466][Connectors/Kafka]: snapshot the noMoreNewPartitionSplits variable [flink-connector-kafka]

2023-12-07 Thread via GitHub
jwtryg opened a new pull request, #71: URL: https://github.com/apache/flink-connector-kafka/pull/71 This fix snapshots the noMoreNewPartitionSplits variable. This is done to make sure that the signalNoMoreSplits signal is sent after restoring from a snapshot. At the current state, a

Re: [PR] [FLINK-33466][Connectors/Kafka]: snapshot the noMoreNewPartitionSplits variable [flink-connector-kafka]

2023-12-07 Thread via GitHub
boring-cyborg[bot] commented on PR #71: URL: https://github.com/apache/flink-connector-kafka/pull/71#issuecomment-1846236616 Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) -- This is a

[jira] [Created] (FLINK-33777) ParquetTimestampITCase>FsStreamingSinkITCaseBase failing in CI

2023-12-07 Thread Jim Hughes (Jira)
Jim Hughes created FLINK-33777: -- Summary: ParquetTimestampITCase>FsStreamingSinkITCaseBase failing in CI Key: FLINK-33777 URL: https://issues.apache.org/jira/browse/FLINK-33777 Project: Flink I

[jira] [Commented] (FLINK-33666) MergeTableLikeUtil uses different constraint name than Schema

2023-12-07 Thread Jim Hughes (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794460#comment-17794460 ] Jim Hughes commented on FLINK-33666: This change seems to prevent `org.apache.flink

Re: [PR] [FLINK-33588][Flink-Runtime] Fix NullArgumentException in DescriptiveStatisticsHistogramStatistics [flink]

2023-12-07 Thread via GitHub
JingGe commented on PR #23749: URL: https://github.com/apache/flink/pull/23749#issuecomment-1846196456 @zhutong6688 would you like to fix the checkstyle issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] [FLINK-33480] Fix GroupAggregate restore tests [flink]

2023-12-07 Thread via GitHub
flinkbot commented on PR #23893: URL: https://github.com/apache/flink/pull/23893#issuecomment-1846095660 ## CI report: * a3637ef98ee225a6ebab4bd4f1cd4e7cb0ecfb84 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-33480] Fix GroupAggregate restore tests [flink]

2023-12-07 Thread via GitHub
bvarghese1 opened a new pull request, #23893: URL: https://github.com/apache/flink/pull/23893 ## What is the purpose of the change *Fix GroupAggregate Restore Test* - This commit ca1c7ce48127472a7c7965099f8a7227549f09df has updated the logic to generate the primary key name whi

Re: [PR] [FLINK-25857] Add committer metrics to track the status of committables - non-breaking [flink]

2023-12-07 Thread via GitHub
pvary commented on PR #23876: URL: https://github.com/apache/flink/pull/23876#issuecomment-1846082401 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [FLINK-30064] Move existing Hive connector code from Flink repo to dedicated Hive repo [flink-connector-hive]

2023-12-07 Thread via GitHub
snuyanzin commented on PR #5: URL: https://github.com/apache/flink-connector-hive/pull/5#issuecomment-1846072081 Currently it works for hive2 and hive3 (without e2e for jdk11) as |hive version |flink 1.18 + jdk 8 | flink 1.19-snapshot + jdk8 | flink 1.18 + jdk 11

[jira] [Updated] (FLINK-33776) Allow to specify optional profile for connectors

2023-12-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33776: --- Labels: pull-request-available (was: ) > Allow to specify optional profile for connectors >

[PR] [FLINK-33776] Allow to specify optional profile for connectors [flink-connector-shared-utils]

2023-12-07 Thread via GitHub
snuyanzin opened a new pull request, #29: URL: https://github.com/apache/flink-connector-shared-utils/pull/29 The issue is that sometimes the connector should be tested against several versions of sinks/sources e.g. hive connector should be tested against hive 2 and hive3, ope

[jira] [Assigned] (FLINK-33776) Allow to specify optional profile for connectors

2023-12-07 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin reassigned FLINK-33776: --- Assignee: Sergey Nuyanzin > Allow to specify optional profile for connectors >

[jira] [Updated] (FLINK-33776) Allow to specify optional profile for connectors

2023-12-07 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-33776: Description: The issue is that sometimes the connector should be tested against several v

[jira] [Created] (FLINK-33776) Allow to specify optional profile for connectors

2023-12-07 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-33776: --- Summary: Allow to specify optional profile for connectors Key: FLINK-33776 URL: https://issues.apache.org/jira/browse/FLINK-33776 Project: Flink Issue

Re: [PR] [FLINK-33470] Moving (Join|Expand)TestPrograms and RestoreTests to th… [flink]

2023-12-07 Thread via GitHub
flinkbot commented on PR #23892: URL: https://github.com/apache/flink/pull/23892#issuecomment-1846030246 ## CI report: * dd8237a51810769231efbef7949a52c5d93ba0ac UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-33470] Moving (Join|Expand)TestPrograms and RestoreTests to th… [flink]

2023-12-07 Thread via GitHub
jnh5y opened a new pull request, #23892: URL: https://github.com/apache/flink/pull/23892 ## What is the purpose of the change Move the Join and Expand TestPrograms and RestoreTests to the desired package. ## Verifying this change There should be no external changes; CI s

[jira] [Resolved] (FLINK-33718) Cleanup the usage of deprecated StreamTableEnvironment#toAppendStream

2023-12-07 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin resolved FLINK-33718. - Resolution: Fixed > Cleanup the usage of deprecated StreamTableEnvironment#toAppendStrea

[jira] [Commented] (FLINK-33718) Cleanup the usage of deprecated StreamTableEnvironment#toAppendStream

2023-12-07 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794391#comment-17794391 ] Sergey Nuyanzin commented on FLINK-33718: - Merged as [a3ee78767e228898a5d5133a4

[jira] [Closed] (FLINK-33718) Cleanup the usage of deprecated StreamTableEnvironment#toAppendStream

2023-12-07 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin closed FLINK-33718. --- > Cleanup the usage of deprecated StreamTableEnvironment#toAppendStream > --

Re: [PR] [FLINK-33718][table] Cleanup the usage of deprecated StreamTableEnvironment#toAppendStream [flink]

2023-12-07 Thread via GitHub
snuyanzin merged PR #23885: URL: https://github.com/apache/flink/pull/23885 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

Re: [PR] [FLINK-33647] Implement restore tests for LookupJoin node [flink]

2023-12-07 Thread via GitHub
bvarghese1 commented on code in PR #23814: URL: https://github.com/apache/flink/pull/23814#discussion_r1419461565 ## flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/test/program/TableTestStep.java: ## @@ -56,7 +56,7 @@ public TableResult apply(TableEnvironm

Re: [PR] [FLINK-33647] Implement restore tests for LookupJoin node [flink]

2023-12-07 Thread via GitHub
bvarghese1 commented on code in PR #23814: URL: https://github.com/apache/flink/pull/23814#discussion_r1419461234 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/stream/LookupJoinTestPrograms.java: ## @@ -0,0 +1,287 @@ +/* + * Lice

[jira] [Created] (FLINK-33775) Report JobInitialization traces

2023-12-07 Thread Piotr Nowojski (Jira)
Piotr Nowojski created FLINK-33775: -- Summary: Report JobInitialization traces Key: FLINK-33775 URL: https://issues.apache.org/jira/browse/FLINK-33775 Project: Flink Issue Type: Sub-task

Re: [PR] [FLINK-25857] Add committer metrics to track the status of committables - non-breaking [flink]

2023-12-07 Thread via GitHub
pvary commented on PR #23876: URL: https://github.com/apache/flink/pull/23876#issuecomment-1845736781 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [FLINK-33559] Externalize Kafka Python connector code [flink-connector-kafka]

2023-12-07 Thread via GitHub
pvary commented on code in PR #69: URL: https://github.com/apache/flink-connector-kafka/pull/69#discussion_r1419267756 ## flink-python/setup.py: ## @@ -0,0 +1,158 @@ + +# Licensed to the Apache Sof

Re: [PR] [FLINK-33770] Promote deprecated autoscaler keys to fallback keys [flink-kubernetes-operator]

2023-12-07 Thread via GitHub
mxm commented on code in PR #725: URL: https://github.com/apache/flink-kubernetes-operator/pull/725#discussion_r1419228903 ## flink-autoscaler/src/test/java/org/apache/flink/autoscaler/config/AutoScalerOptionsTest.java: ## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Softwar

[jira] [Updated] (FLINK-33770) Autoscaler logs are full of deprecated key warnings

2023-12-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33770: --- Labels: pull-request-available (was: ) > Autoscaler logs are full of deprecated key warning

Re: [PR] [FLINK-25857] Add committer metrics to track the status of committables - non-breaking [flink]

2023-12-07 Thread via GitHub
pvary commented on code in PR #23876: URL: https://github.com/apache/flink/pull/23876#discussion_r1419179801 ## flink-python/pyflink/datastream/connectors/tests/test_pulsar.py: ## @@ -253,7 +250,6 @@ def test_pulsar_sink(self): .long_type() .no_

Re: [PR] [FLINK-33523][table-planner] Revert [FLINK-31835] Fix the array type that can't be converted from the external primitive array [flink]

2023-12-07 Thread via GitHub
flinkbot commented on PR #23890: URL: https://github.com/apache/flink/pull/23890#issuecomment-1845591977 ## CI report: * b634af39ea8285b87c86c0bc49797ff4847ef525 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33523][BP 1.18][table-planner] Revert [FLINK-31835] Fix the array type that can't be converted from the external primitive array [flink]

2023-12-07 Thread via GitHub
flinkbot commented on PR #23891: URL: https://github.com/apache/flink/pull/23891#issuecomment-1845592248 ## CI report: * 1443033f03ba318465b9b0df07a083069baf8e4b UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-33523][BP 1.18][table-planner] Revert [FLINK-31835] Fix the array type that can't be converted from the external primitive array [flink]

2023-12-07 Thread via GitHub
MartijnVisser opened a new pull request, #23891: URL: https://github.com/apache/flink/pull/23891 This reverts commit a6adbdda0cdf90635f0cd7a3427486bced301fbd. This is the unchanged reversion of https://github.com/apache/flink/pull/22485/files - The equivalent for `master` can be foun

[jira] [Updated] (FLINK-33523) DataType ARRAY fails to cast into Object[]

2023-12-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33523: --- Labels: pull-request-available (was: ) > DataType ARRAY fails to cast into Object[] > -

[PR] [FLINK-33523][table-planner] Revert [FLINK-31835] Fix the array type that can't be converted from the external primitive array [flink]

2023-12-07 Thread via GitHub
MartijnVisser opened a new pull request, #23890: URL: https://github.com/apache/flink/pull/23890 This reverts https://github.com/apache/flink/pull/22485 as discussed in https://lists.apache.org/thread/m4c879y8mb7hbn2kkjh9h3d8g1jphh3j ## What is the purpose of the change * Rever

[jira] [Assigned] (FLINK-33523) DataType ARRAY fails to cast into Object[]

2023-12-07 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser reassigned FLINK-33523: -- Assignee: Martijn Visser > DataType ARRAY fails to cast into Object[] > -

[jira] [Assigned] (FLINK-31400) Add autoscaler integration for Iceberg source

2023-12-07 Thread Maximilian Michels (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels reassigned FLINK-31400: -- Assignee: Mason Chen > Add autoscaler integration for Iceberg source > --

[jira] [Updated] (FLINK-31502) Limit the number of concurrent scale operations to reduce cluster churn

2023-12-07 Thread Maximilian Michels (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels updated FLINK-31502: --- Fix Version/s: kubernetes-operator-1.8.0 (was: kubernetes-oper

Re: [PR] [FLINK-25565][Formats][Parquet] write and read parquet int64 timestamp [flink]

2023-12-07 Thread via GitHub
mxm commented on code in PR #23887: URL: https://github.com/apache/flink/pull/23887#discussion_r1419139910 ## flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/vector/reader/TimestampColumnReader.java: ## @@ -109,6 +157,37 @@ public static TimestampData

Re: [PR] [FLINK-21949][table] Support ARRAY_AGG aggregate function [flink]

2023-12-07 Thread via GitHub
snuyanzin commented on PR #23411: URL: https://github.com/apache/flink/pull/23411#issuecomment-1845527082 yes, sorry was not clear enough >to compare when merging and retracting lists? yes -- This is an automated message from the Apache Git Service. To respond to the message, ple

[jira] [Commented] (FLINK-25565) Write and Read Parquet INT64 Timestamp

2023-12-07 Thread Thomas Weise (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794287#comment-17794287 ] Thomas Weise commented on FLINK-25565: -- [~martijnvisser] the default behavior did n

Re: [PR] [FLINK-33763] Support savepoint redeployment through a nonce [flink-kubernetes-operator]

2023-12-07 Thread via GitHub
gyfora commented on PR #724: URL: https://github.com/apache/flink-kubernetes-operator/pull/724#issuecomment-1845511538 thanks for the thorough review @mxm I will add validation for the path and improve the comments/docs as discussed tomorrow -- This is an automated message from the Apach

[jira] [Commented] (FLINK-25565) Write and Read Parquet INT64 Timestamp

2023-12-07 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794281#comment-17794281 ] Martijn Visser commented on FLINK-25565: [~thw] Shouldn't we then also update th

[jira] [Created] (FLINK-33774) StreamTaskSelectiveReadingTest.testReadFinishedInput(StreamTaskSelectiveReadingTest timed out

2023-12-07 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-33774: - Summary: StreamTaskSelectiveReadingTest.testReadFinishedInput(StreamTaskSelectiveReadingTest timed out Key: FLINK-33774 URL: https://issues.apache.org/jira/browse/FLINK-33774

[jira] [Commented] (FLINK-33693) Force aligned barrier logic doesn't work when the aligned checkpoint timeout is enabled

2023-12-07 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794275#comment-17794275 ] Rui Fan commented on FLINK-33693: - Merged to master<1.19> via : a4d14ec224bbaf498ca2e91

[jira] [Resolved] (FLINK-33693) Force aligned barrier logic doesn't work when the aligned checkpoint timeout is enabled

2023-12-07 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan resolved FLINK-33693. - Fix Version/s: 1.19.0 1.18.1 1.17.3 Resolution: Fixed > For

Re: [PR] [FLINK-25857] Add committer metrics to track the status of committables - non-breaking [flink]

2023-12-07 Thread via GitHub
mbalassi commented on code in PR #23876: URL: https://github.com/apache/flink/pull/23876#discussion_r1419100843 ## flink-python/pyflink/datastream/connectors/tests/test_pulsar.py: ## @@ -253,7 +250,6 @@ def test_pulsar_sink(self): .long_type() .

[jira] [Commented] (FLINK-22765) ExceptionUtilsITCase.testIsMetaspaceOutOfMemoryError is unstable

2023-12-07 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794274#comment-17794274 ] Matthias Pohl commented on FLINK-22765: --- https://github.com/XComp/flink/actions/ru

[jira] [Commented] (FLINK-27681) Improve the availability of Flink when the RocksDB file is corrupted.

2023-12-07 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794272#comment-17794272 ] Piotr Nowojski commented on FLINK-27681: [~masteryhx] , yes that would require a

[jira] [Commented] (FLINK-26515) RetryingExecutorTest. testDiscardOnTimeout failed on azure

2023-12-07 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794273#comment-17794273 ] Matthias Pohl commented on FLINK-26515: --- https://github.com/XComp/flink/actions/ru

Re: [PR] [FLINK-33693][checkpoint] Force aligned barrier works with timeoutable aligned checkpoint barrier [flink]

2023-12-07 Thread via GitHub
1996fanrui merged PR #23889: URL: https://github.com/apache/flink/pull/23889 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.ap

[jira] [Commented] (FLINK-33770) Autoscaler logs are full of deprecated key warnings

2023-12-07 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794268#comment-17794268 ] Gyula Fora commented on FLINK-33770: Good idea! > Autoscaler logs are full of depre

Re: [PR] [FLINK-33693][checkpoint] Force aligned barrier works with timeoutable aligned checkpoint barrier [flink]

2023-12-07 Thread via GitHub
1996fanrui merged PR #23888: URL: https://github.com/apache/flink/pull/23888 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.ap

[jira] [Commented] (FLINK-33771) Add cluster capacity awareness to Autoscaler

2023-12-07 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794271#comment-17794271 ] Gyula Fora commented on FLINK-33771: cc [~gsomogyi] this is somewhat related to the

[jira] [Comment Edited] (FLINK-18476) PythonEnvUtilsTest#testStartPythonProcess fails

2023-12-07 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794263#comment-17794263 ] Matthias Pohl edited comment on FLINK-18476 at 12/7/23 2:53 PM: --

[jira] [Commented] (FLINK-33414) MiniClusterITCase.testHandleStreamingJobsWhenNotEnoughSlot fails due to unexpected TimeoutException

2023-12-07 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794267#comment-17794267 ] Matthias Pohl commented on FLINK-33414: --- https://github.com/XComp/flink/actions/ru

[jira] [Comment Edited] (FLINK-28440) EventTimeWindowCheckpointingITCase failed with restore

2023-12-07 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794261#comment-17794261 ] Matthias Pohl edited comment on FLINK-28440 at 12/7/23 2:51 PM: --

[jira] [Updated] (FLINK-33771) Add cluster capacity awareness to Autoscaler

2023-12-07 Thread Maximilian Michels (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels updated FLINK-33771: --- Description: To avoid starvation of pipelines when the Kubernetes cluster runs out o

[jira] [Created] (FLINK-33773) Add fairness to scaling decisions

2023-12-07 Thread Maximilian Michels (Jira)
Maximilian Michels created FLINK-33773: -- Summary: Add fairness to scaling decisions Key: FLINK-33773 URL: https://issues.apache.org/jira/browse/FLINK-33773 Project: Flink Issue Type: New

[jira] [Comment Edited] (FLINK-18476) PythonEnvUtilsTest#testStartPythonProcess fails

2023-12-07 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794263#comment-17794263 ] Matthias Pohl edited comment on FLINK-18476 at 12/7/23 2:49 PM: --

[jira] [Commented] (FLINK-18476) PythonEnvUtilsTest#testStartPythonProcess fails

2023-12-07 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794263#comment-17794263 ] Matthias Pohl commented on FLINK-18476: --- FLINK-27075-related workflow: https://gi

[jira] [Commented] (FLINK-28440) EventTimeWindowCheckpointingITCase failed with restore

2023-12-07 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794261#comment-17794261 ] Matthias Pohl commented on FLINK-28440: --- Related to the FLINK-27075 GHA migration

[jira] [Comment Edited] (FLINK-28440) EventTimeWindowCheckpointingITCase failed with restore

2023-12-07 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794261#comment-17794261 ] Matthias Pohl edited comment on FLINK-28440 at 12/7/23 2:48 PM: --

[jira] [Created] (FLINK-33772) Python e2e test fails with exit code 1

2023-12-07 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-33772: - Summary: Python e2e test fails with exit code 1 Key: FLINK-33772 URL: https://issues.apache.org/jira/browse/FLINK-33772 Project: Flink Issue Type: Sub-task

Re: [PR] [FLINK-21949][table] Support ARRAY_AGG aggregate function [flink]

2023-12-07 Thread via GitHub
Jiabao-Sun commented on PR #23411: URL: https://github.com/apache/flink/pull/23411#issuecomment-1845473679 Do you mean using equalityEvaluator to compare when merging and retracting lists? -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[jira] [Created] (FLINK-33771) Add cluster capacity awareness to Autoscaler

2023-12-07 Thread Maximilian Michels (Jira)
Maximilian Michels created FLINK-33771: -- Summary: Add cluster capacity awareness to Autoscaler Key: FLINK-33771 URL: https://issues.apache.org/jira/browse/FLINK-33771 Project: Flink Issu

[jira] [Commented] (FLINK-26644) python StreamExecutionEnvironmentTests.test_generate_stream_graph_with_dependencies failed on azure

2023-12-07 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794257#comment-17794257 ] Matthias Pohl commented on FLINK-26644: --- https://github.com/XComp/flink/actions/ru

[jira] [Commented] (FLINK-22765) ExceptionUtilsITCase.testIsMetaspaceOutOfMemoryError is unstable

2023-12-07 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794250#comment-17794250 ] Matthias Pohl commented on FLINK-22765: --- https://github.com/XComp/flink/actions/ru

[jira] [Commented] (FLINK-33641) JUnit5 fails to delete a directory on AZP for various table-planner tests

2023-12-07 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794247#comment-17794247 ] Matthias Pohl commented on FLINK-33641: --- https://dev.azure.com/apache-flink/apache

[jira] [Commented] (FLINK-28440) EventTimeWindowCheckpointingITCase failed with restore

2023-12-07 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794246#comment-17794246 ] Matthias Pohl commented on FLINK-28440: --- https://dev.azure.com/apache-flink/apache

[jira] [Commented] (FLINK-22765) ExceptionUtilsITCase.testIsMetaspaceOutOfMemoryError is unstable

2023-12-07 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794245#comment-17794245 ] Matthias Pohl commented on FLINK-22765: --- https://dev.azure.com/apache-flink/apache

Re: [PR] [FLINK-32850][flink-runtime][JUnit5 Migration] The io.network.netty package of flink-runtime module [flink]

2023-12-07 Thread via GitHub
Jiabao-Sun commented on PR #23607: URL: https://github.com/apache/flink/pull/23607#issuecomment-1845453539 Thanks @JingGe for the review. Sorry for the delay in resolving the PR conflicts. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Commented] (FLINK-28440) EventTimeWindowCheckpointingITCase failed with restore

2023-12-07 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794243#comment-17794243 ] Matthias Pohl commented on FLINK-28440: --- https://dev.azure.com/apache-flink/apache

[jira] [Comment Edited] (FLINK-33641) JUnit5 fails to delete a directory on AZP for various table-planner tests

2023-12-07 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794242#comment-17794242 ] Matthias Pohl edited comment on FLINK-33641 at 12/7/23 2:33 PM: --

[jira] [Commented] (FLINK-33641) JUnit5 fails to delete a directory on AZP for various table-planner tests

2023-12-07 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794242#comment-17794242 ] Matthias Pohl commented on FLINK-33641: --- https://dev.azure.com/apache-flink/apache

[jira] [Commented] (FLINK-33727) JoinRestoreTest is failing on AZP

2023-12-07 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794241#comment-17794241 ] Matthias Pohl commented on FLINK-33727: --- The following build failed before the rev

[jira] [Commented] (FLINK-33641) JUnit5 fails to delete a directory on AZP for various table-planner tests

2023-12-07 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794240#comment-17794240 ] Matthias Pohl commented on FLINK-33641: --- https://dev.azure.com/apache-flink/apache

[jira] [Reopened] (FLINK-31502) Limit the number of concurrent scale operations to reduce cluster churn

2023-12-07 Thread Maximilian Michels (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels reopened FLINK-31502: Reopening because this is an actual issue. > Limit the number of concurrent scale ope

[jira] [Comment Edited] (FLINK-33641) JUnit5 fails to delete a directory on AZP for various table-planner tests

2023-12-07 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794235#comment-17794235 ] Matthias Pohl edited comment on FLINK-33641 at 12/7/23 2:26 PM: --

[jira] [Commented] (FLINK-25565) Write and Read Parquet INT64 Timestamp

2023-12-07 Thread Thomas Weise (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794237#comment-17794237 ] Thomas Weise commented on FLINK-25565: -- It turns out that without this option, tabl

[jira] [Commented] (FLINK-33641) JUnit5 fails to delete a directory on AZP for various table-planner tests

2023-12-07 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794235#comment-17794235 ] Matthias Pohl commented on FLINK-33641: --- [https://dev.azure.com/apache-flink/apach

[jira] [Created] (FLINK-33770) Autoscaler logs are full of deprecated key warnings

2023-12-07 Thread Maximilian Michels (Jira)
Maximilian Michels created FLINK-33770: -- Summary: Autoscaler logs are full of deprecated key warnings Key: FLINK-33770 URL: https://issues.apache.org/jira/browse/FLINK-33770 Project: Flink

Re: [PR] [FLINK-25565][Formats][Parquet] write and read parquet int64 timestamp [flink]

2023-12-07 Thread via GitHub
tweise commented on PR #23887: URL: https://github.com/apache/flink/pull/23887#issuecomment-1845429843 @MartijnVisser good point - strictly speaking it is a bug, let me add a comment to the ticket. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[jira] [Commented] (FLINK-30719) flink-runtime-web failed due to a corrupted nodejs dependency

2023-12-07 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794232#comment-17794232 ] Matthias Pohl commented on FLINK-30719: --- https://dev.azure.com/apache-flink/apache

  1   2   3   >