Re: [PR] [FLINK-33776] [Test] only close the cluster once to make the test `ClientHeartbeatTest` faster [flink]

2023-12-11 Thread via GitHub
TestBoost commented on PR #23910: URL: https://github.com/apache/flink/pull/23910#issuecomment-1851472434 Hi reswqa, Thank you so much for your reply! I just changed the title but I don't know if it's suitable. Yes, right now the test cluster is started before every test method

Re: [PR] [FLINK-33057] Add options to disable creating job-id subdirectories under the checkpoint directory [flink]

2023-12-11 Thread via GitHub
Myasuka commented on code in PR #23509: URL: https://github.com/apache/flink/pull/23509#discussion_r1423537299 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/memory/MemoryBackendCheckpointStorageAccess.java: ## @@ -72,6 +73,7 @@ public MemoryBackendCheckpointStora

Re: [PR] [FLINK-33736][Scheduler] Update default value of exponential-delay.max-backoff and exponential-delay.backoff-multiplier [flink]

2023-12-11 Thread via GitHub
flinkbot commented on PR #23911: URL: https://github.com/apache/flink/pull/23911#issuecomment-1851449909 ## CI report: * 4f20956497f2d5b1255419eb5f31d03737c9a597 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-32895][Scheduler] Introduce the max attempts for Exponential Delay Restart Strategy [flink]

2023-12-11 Thread via GitHub
1996fanrui commented on code in PR #23247: URL: https://github.com/apache/flink/pull/23247#discussion_r1423553344 ## flink-core/src/main/java/org/apache/flink/configuration/RestartStrategyOptions.java: ## @@ -184,7 +184,7 @@ public class RestartStrategyOptions { public stat

[jira] [Updated] (FLINK-33736) Update default value of exponential-delay.max-backoff and exponential-delay.backoff-multiplier

2023-12-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33736: --- Labels: pull-request-available (was: ) > Update default value of exponential-delay.max-back

[jira] [Closed] (FLINK-33714) Update documentation about the usage of RuntimeContext#getExecutionConfig

2023-12-11 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo closed FLINK-33714. -- Resolution: Fixed master(1.19) via 3531998adad20f3904d1421a35a69fef44b2b69f. > Update documentation a

[PR] [FLINK-33736][Scheduler] Update default value of exponential-delay.max-backoff and exponential-delay.backoff-multiplier [flink]

2023-12-11 Thread via GitHub
1996fanrui opened a new pull request, #23911: URL: https://github.com/apache/flink/pull/23911 ## What is the purpose of the change See [FLIP-364: Improve the exponential-delay restart-strategy](https://cwiki.apache.org/confluence/x/uJqzDw) . This PR includes the subtask1 of FLIP-364

[jira] [Updated] (FLINK-33714) Update documentation about the usage of RuntimeContext#getExecutionConfig

2023-12-11 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-33714: --- Affects Version/s: 1.19.0 > Update documentation about the usage of RuntimeContext#getExecutionConfi

[jira] [Updated] (FLINK-33714) Update documentation about the usage of RuntimeContext#getExecutionConfig

2023-12-11 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-33714: --- Fix Version/s: 1.19.0 > Update documentation about the usage of RuntimeContext#getExecutionConfig >

Re: [PR] [FLINK-33714][doc] Update the documentation about the usage of RuntimeContext#getExecutionConfig. [flink]

2023-12-11 Thread via GitHub
reswqa merged PR #23906: URL: https://github.com/apache/flink/pull/23906 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

Re: [PR] [FLINK-32895][Scheduler] Introduce the max attempts for Exponential Delay Restart Strategy [flink]

2023-12-11 Thread via GitHub
1996fanrui commented on code in PR #23247: URL: https://github.com/apache/flink/pull/23247#discussion_r1423542955 ## flink-core/src/main/java/org/apache/flink/configuration/RestartStrategyOptions.java: ## @@ -184,7 +184,7 @@ public class RestartStrategyOptions { public stat

[jira] [Commented] (FLINK-26585) State Processor API: Loading a state set buffers the whole state set in memory before starting to process

2023-12-11 Thread Hangxiang Yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17795627#comment-17795627 ] Hangxiang Yu commented on FLINK-26585: -- [~jingge] I saw 1.18.1 is releasing. Could

Re: [PR] [FLINK-33764] Track Heap usage and GC pressure to avoid unnecessary scaling [flink-kubernetes-operator]

2023-12-11 Thread via GitHub
gyfora commented on code in PR #726: URL: https://github.com/apache/flink-kubernetes-operator/pull/726#discussion_r1423504221 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/config/AutoScalerOptions.java: ## @@ -222,6 +222,18 @@ private static ConfigOptions.Option

Re: [PR] [FLINK-30702] Add Elasticsearch dialect [flink-connector-jdbc]

2023-12-11 Thread via GitHub
grzegorz8 commented on code in PR #67: URL: https://github.com/apache/flink-connector-jdbc/pull/67#discussion_r1420783379 ## flink-connector-jdbc/pom.xml: ## @@ -38,10 +38,12 @@ under the License. 2.12 2.12.7 3.23.1 +

Re: [PR] [FLINK-32993][table] Datagen connector handles length-constrained fields according to the schema definition by default [flink]

2023-12-11 Thread via GitHub
liyubin117 commented on code in PR #23678: URL: https://github.com/apache/flink/pull/23678#discussion_r1423393030 ## flink-table/flink-table-api-java-bridge/src/test/java/org/apache/flink/table/factories/DataGenTableSourceFactoryTest.java: ## @@ -297,10 +295,104 @@ void testVari

Re: [PR] [FLINK-32895][Scheduler] Introduce the max attempts for Exponential Delay Restart Strategy [flink]

2023-12-11 Thread via GitHub
zhuzhurk commented on code in PR #23247: URL: https://github.com/apache/flink/pull/23247#discussion_r1423468479 ## flink-core/src/main/java/org/apache/flink/configuration/RestartStrategyOptions.java: ## @@ -184,7 +184,7 @@ public class RestartStrategyOptions { public static

Re: [PR] [FLINK-32895][Scheduler] Introduce the max attempts for Exponential Delay Restart Strategy [flink]

2023-12-11 Thread via GitHub
zhuzhurk commented on code in PR #23247: URL: https://github.com/apache/flink/pull/23247#discussion_r1423468479 ## flink-core/src/main/java/org/apache/flink/configuration/RestartStrategyOptions.java: ## @@ -184,7 +184,7 @@ public class RestartStrategyOptions { public static

Re: [PR] [FLINK-33676] Implement RestoreTests for WindowAggregate [flink]

2023-12-11 Thread via GitHub
xuyangzhong commented on code in PR #23886: URL: https://github.com/apache/flink/pull/23886#discussion_r1423461099 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/stream/WindowAggregateEventTimeRestoreTest.java: ## @@ -0,0 +1,60 @@

[jira] [Comment Edited] (FLINK-33780) Support to store default catalog in CatalogStore

2023-12-11 Thread Yubin Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17795574#comment-17795574 ] Yubin Li edited comment on FLINK-33780 at 12/12/23 5:42 AM:

Re: [PR] only close the cluster once to make the tests faster [flink]

2023-12-11 Thread via GitHub
flinkbot commented on PR #23910: URL: https://github.com/apache/flink/pull/23910#issuecomment-1851322851 ## CI report: * b0fd64a2a24dc1cd50ea2fb5ae4f3d4036e2b85a UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] only close the cluster once to make the tests faster [flink]

2023-12-11 Thread via GitHub
TestBoost opened a new pull request, #23910: URL: https://github.com/apache/flink/pull/23910 ## What is the purpose of the change This change is to make `miniCluster.close()` run only once after all tests finish and make the tests in test class `ClientHeartbeatTest` run faster

Re: [PR] [FLINK-32895][Scheduler] Introduce the max attempts for Exponential Delay Restart Strategy [flink]

2023-12-11 Thread via GitHub
1996fanrui commented on code in PR #23247: URL: https://github.com/apache/flink/pull/23247#discussion_r1423360642 ## flink-core/src/main/java/org/apache/flink/configuration/RestartStrategyOptions.java: ## @@ -184,7 +184,7 @@ public class RestartStrategyOptions { public stat

Re: [PR] [FLINK-32993][table] Datagen connector handles length-constrained fields according to the schema definition by default [flink]

2023-12-11 Thread via GitHub
liyubin117 commented on code in PR #23678: URL: https://github.com/apache/flink/pull/23678#discussion_r1423393030 ## flink-table/flink-table-api-java-bridge/src/test/java/org/apache/flink/table/factories/DataGenTableSourceFactoryTest.java: ## @@ -297,10 +295,104 @@ void testVari

Re: [PR] [hotfix][build] Release branch should use SNAPSHOT version [flink-connector-pulsar]

2023-12-11 Thread via GitHub
leonardBang merged PR #66: URL: https://github.com/apache/flink-connector-pulsar/pull/66 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

Re: [PR] [hotfix][build] Release branch should use SNAPSHOT version [flink-connector-pulsar]

2023-12-11 Thread via GitHub
leonardBang commented on PR #66: URL: https://github.com/apache/flink-connector-pulsar/pull/66#issuecomment-1851280119 CI passed, merging... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] [FLINK-32993][table] Datagen connector handles length-constrained fields according to the schema definition by default [flink]

2023-12-11 Thread via GitHub
liyubin117 commented on code in PR #23678: URL: https://github.com/apache/flink/pull/23678#discussion_r1423385053 ## flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/connector/datagen/table/DataGenTableSourceFactory.java: ## @@ -141,15 +143,15 @@ private Da

Re: [PR] [FLINK-32993][table] Datagen connector handles length-constrained fields according to the schema definition by default [flink]

2023-12-11 Thread via GitHub
LadyForest commented on code in PR #23678: URL: https://github.com/apache/flink/pull/23678#discussion_r1423376727 ## flink-table/flink-table-api-java-bridge/src/test/java/org/apache/flink/table/factories/DataGenTableSourceFactoryTest.java: ## @@ -297,10 +295,104 @@ void testVari

Re: [PR] [FLINK-33781][table] Cleanup usage of deprecated TableConfig#ctor [flink]

2023-12-11 Thread via GitHub
liuyongvs commented on PR #23897: URL: https://github.com/apache/flink/pull/23897#issuecomment-1851260132 > LGTM, I have a minor comment: do we need to remove the deprecated constructor method `public TableConfig() {}` now? i think we should not remove it now, may some users or connec

Re: [PR] [FLINK-32895][Scheduler] Introduce the max attempts for Exponential Delay Restart Strategy [flink]

2023-12-11 Thread via GitHub
1996fanrui commented on code in PR #23247: URL: https://github.com/apache/flink/pull/23247#discussion_r1423367354 ## flink-core/src/main/java/org/apache/flink/configuration/RestartStrategyOptions.java: ## @@ -222,6 +223,19 @@ public class RestartStrategyOptions {

Re: [PR] [FLINK-32028][connectors/elasticsearch] Allow customising bulk failure handling [flink-connector-elasticsearch]

2023-12-11 Thread via GitHub
reswqa commented on PR #83: URL: https://github.com/apache/flink-connector-elasticsearch/pull/83#issuecomment-1851249351 We should waiting for https://github.com/apache/flink/pull/23876 to be merged(This won't take long as it has already been approved by 3 votes). After that, CI should be

Re: [PR] [FLINK-33672] Use MapState.entries() instead of keys() and get() in over window [flink]

2023-12-11 Thread via GitHub
Zakelly commented on PR #23855: URL: https://github.com/apache/flink/pull/23855#issuecomment-1851243905 Thanks @fsk119 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[jira] [Commented] (FLINK-26586) FileSystem uses unbuffered read I/O

2023-12-11 Thread Hangxiang Yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17795577#comment-17795577 ] Hangxiang Yu commented on FLINK-26586: -- [~Matthias Schwalbe] Sure. Just feel free t

[jira] [Assigned] (FLINK-26586) FileSystem uses unbuffered read I/O

2023-12-11 Thread Hangxiang Yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hangxiang Yu reassigned FLINK-26586: Assignee: Matthias Schwalbe > FileSystem uses unbuffered read I/O > -

[jira] [Commented] (FLINK-33798) Automatically clean up rocksdb logs when the task failover.

2023-12-11 Thread Hangxiang Yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17795576#comment-17795576 ] Hangxiang Yu commented on FLINK-33798: -- Thanks [~fanrui] pinging me here. I think

Re: [PR] [FLINK-32895][Scheduler] Introduce the max attempts for Exponential Delay Restart Strategy [flink]

2023-12-11 Thread via GitHub
1996fanrui commented on code in PR #23247: URL: https://github.com/apache/flink/pull/23247#discussion_r1423360642 ## flink-core/src/main/java/org/apache/flink/configuration/RestartStrategyOptions.java: ## @@ -184,7 +184,7 @@ public class RestartStrategyOptions { public stat

[jira] [Comment Edited] (FLINK-33780) Support to store default catalog in CatalogStore

2023-12-11 Thread Yubin Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17795574#comment-17795574 ] Yubin Li edited comment on FLINK-33780 at 12/12/23 3:22 AM:

[jira] [Comment Edited] (FLINK-33780) Support to store default catalog in CatalogStore

2023-12-11 Thread Yubin Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17795574#comment-17795574 ] Yubin Li edited comment on FLINK-33780 at 12/12/23 3:21 AM:

[jira] [Commented] (FLINK-33780) Support to store default catalog in CatalogStore

2023-12-11 Thread Yubin Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17795574#comment-17795574 ] Yubin Li commented on FLINK-33780: -- [~hackergin] Hi, we could make modifitions in the `

[jira] [Assigned] (FLINK-33716) Cleanup the usage of deprecated StreamTableEnvironment#createTemporaryView

2023-12-11 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan reassigned FLINK-33716: - Assignee: Jacky Lau > Cleanup the usage of deprecated StreamTableEnvironment#createTemporaryVie

[jira] [Commented] (FLINK-33716) Cleanup the usage of deprecated StreamTableEnvironment#createTemporaryView

2023-12-11 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17795573#comment-17795573 ] Jane Chan commented on FLINK-33716: --- [~jackylau] assigned to you. > Cleanup the usage

[jira] [Assigned] (FLINK-33717) Cleanup the usage of deprecated StreamTableEnvironment#fromDataStream

2023-12-11 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan reassigned FLINK-33717: - Assignee: Jacky Lau > Cleanup the usage of deprecated StreamTableEnvironment#fromDataStream > -

[jira] [Commented] (FLINK-33717) Cleanup the usage of deprecated StreamTableEnvironment#fromDataStream

2023-12-11 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17795572#comment-17795572 ] Jane Chan commented on FLINK-33717: --- Hi, [~jackylau]. Thanks for the interest, assigne

[jira] [Updated] (FLINK-33780) Support to store default catalog in CatalogStore

2023-12-11 Thread Yubin Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yubin Li updated FLINK-33780: - Attachment: image-2023-12-12-11-09-53-075.png > Support to store default catalog in CatalogStore > -

Re: [PR] [FLINK-33764] Track Heap usage and GC pressure to avoid unnecessary scaling [flink-kubernetes-operator]

2023-12-11 Thread via GitHub
1996fanrui commented on code in PR #726: URL: https://github.com/apache/flink-kubernetes-operator/pull/726#discussion_r1423346604 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/config/AutoScalerOptions.java: ## @@ -222,6 +222,18 @@ private static ConfigOptions.Op

[jira] [Commented] (FLINK-33728) do not rewatch when KubernetesResourceManagerDriver watch fail

2023-12-11 Thread xiaogang zhou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17795571#comment-17795571 ] xiaogang zhou commented on FLINK-33728: --- Hi [~mapohl] , thanks for the comment abo

Re: [PR] [hotfix][test] Migrate JsonRowDeserializationSchemaTest/JsonRowSerializationSchemaTest to Junit5 and Assertj [flink]

2023-12-11 Thread via GitHub
fsk119 merged PR #23882: URL: https://github.com/apache/flink/pull/23882 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

[jira] [Closed] (FLINK-33672) Use MapState.entries() instead of keys() and get() in over window

2023-12-11 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang closed FLINK-33672. - Fix Version/s: 1.19.0 Resolution: Fixed > Use MapState.entries() instead of keys() and ge

[jira] [Commented] (FLINK-33672) Use MapState.entries() instead of keys() and get() in over window

2023-12-11 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17795569#comment-17795569 ] Shengkai Fang commented on FLINK-33672: --- Merged into master: 080119cca53d989025798

Re: [PR] [FLINK-33672] Use MapState.entries() instead of keys() and get() in over window [flink]

2023-12-11 Thread via GitHub
fsk119 merged PR #23855: URL: https://github.com/apache/flink/pull/23855 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

Re: [PR] [FLINK-33612][table-planner] Hybrid shuffle mode avoids unnecessary blocking edges in the plan [flink]

2023-12-11 Thread via GitHub
TanYuxin-tyx commented on PR #23771: URL: https://github.com/apache/flink/pull/23771#issuecomment-1851182058 @lsyldliu Thanks for helping review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[jira] [Commented] (FLINK-33612) The table plan of hybrid shuffle may introduce additional blocking edges occasionally

2023-12-11 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17795564#comment-17795564 ] dalongliu commented on FLINK-33612: --- merged via master branch: 9cac80be18c6aff0cebdfe7

Re: [PR] [FLINK-33612][table-planner] Hybrid shuffle mode avoids unnecessary blocking edges in the plan [flink]

2023-12-11 Thread via GitHub
lsyldliu merged PR #23771: URL: https://github.com/apache/flink/pull/23771 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

Re: [PR] Bump org.apache.commons:commons-compress from 1.22 to 1.24.0 [flink-connector-pulsar]

2023-12-11 Thread via GitHub
tisonkun merged PR #65: URL: https://github.com/apache/flink-connector-pulsar/pull/65 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

Re: [PR] [hotfix][build] Bump version to 4.2-SNAPSHOT [flink-connector-pulsar]

2023-12-11 Thread via GitHub
tisonkun merged PR #67: URL: https://github.com/apache/flink-connector-pulsar/pull/67 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

Re: [PR] [hotfix][build] Bump version to 4.2-SNAPSHOT [flink-connector-pulsar]

2023-12-11 Thread via GitHub
boring-cyborg[bot] commented on PR #67: URL: https://github.com/apache/flink-connector-pulsar/pull/67#issuecomment-1851152475 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] [build] Bump version to 4.2-SNAPSHOT [flink-connector-pulsar]

2023-12-11 Thread via GitHub
tisonkun commented on code in PR #67: URL: https://github.com/apache/flink-connector-pulsar/pull/67#discussion_r1423296836 ## flink-connector-pulsar-e2e-tests/pom.xml: ## @@ -23,7 +23,7 @@ under the License. org.apache.flink flink-connec

Re: [PR] [hotfix][build] Release branch should use SNAPSHOT version [flink-connector-pulsar]

2023-12-11 Thread via GitHub
tisonkun commented on code in PR #66: URL: https://github.com/apache/flink-connector-pulsar/pull/66#discussion_r1423296026 ## docs/data/pulsar.yml: ## @@ -16,7 +16,7 @@ # limitations under the License. #

Re: [PR] [build][hotfix] Release branch should use SNAPSHOT version [flink-connector-pulsar]

2023-12-11 Thread via GitHub
tisonkun commented on code in PR #66: URL: https://github.com/apache/flink-connector-pulsar/pull/66#discussion_r1423293161 ## docs/data/pulsar.yml: ## @@ -16,7 +16,7 @@ # limitations under the License. #

Re: [PR] [hotfix][docs] config key for parquet int64 option [flink]

2023-12-11 Thread via GitHub
flinkbot commented on PR #23909: URL: https://github.com/apache/flink/pull/23909#issuecomment-1851138706 ## CI report: * b72dd38e4c835667830025114edd647c40224429 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [hotfix][docs] config key for parquet int64 option [flink]

2023-12-11 Thread via GitHub
tweise opened a new pull request, #23909: URL: https://github.com/apache/flink/pull/23909 Corrects error from https://github.com/apache/flink/pull/23900 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Closed] (FLINK-33361) Add Java 17 compatibility to Flink Kafka connector

2023-12-11 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin closed FLINK-33361. --- > Add Java 17 compatibility to Flink Kafka connector > -

[jira] [Commented] (FLINK-33361) Add Java 17 compatibility to Flink Kafka connector

2023-12-11 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17795516#comment-17795516 ] Sergey Nuyanzin commented on FLINK-33361: - Merged as [825052f55754e401176083c12

[jira] [Assigned] (FLINK-33361) Add Java 17 compatibility to Flink Kafka connector

2023-12-11 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin reassigned FLINK-33361: --- Assignee: Sergey Nuyanzin > Add Java 17 compatibility to Flink Kafka connector > --

[jira] [Resolved] (FLINK-33361) Add Java 17 compatibility to Flink Kafka connector

2023-12-11 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin resolved FLINK-33361. - Fix Version/s: kafka-3.1.0 Resolution: Fixed > Add Java 17 compatibility to Flink

Re: [PR] [FLINK-33361][Connectors/Kafka] Add Java 17 compatibility to Flink Kafka connector [flink-connector-kafka]

2023-12-11 Thread via GitHub
boring-cyborg[bot] commented on PR #68: URL: https://github.com/apache/flink-connector-kafka/pull/68#issuecomment-1850970248 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] [FLINK-33361][Connectors/Kafka] Add Java 17 compatibility to Flink Kafka connector [flink-connector-kafka]

2023-12-11 Thread via GitHub
snuyanzin merged PR #68: URL: https://github.com/apache/flink-connector-kafka/pull/68 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

Re: [PR] [FLINK-33361][Connectors/Kafka] Add Java 17 compatibility to Flink Kafka connector [flink-connector-kafka]

2023-12-11 Thread via GitHub
snuyanzin commented on code in PR #68: URL: https://github.com/apache/flink-connector-kafka/pull/68#discussion_r1423178960 ## pom.xml: ## @@ -78,6 +78,13 @@ under the License. 2.17.1 flink-connector-kafka-parent + + + +-XX:+UseG1GC -

[jira] [Updated] (FLINK-33800) Allow passing parameters to database via jdbc url

2023-12-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33800: --- Labels: pull-request-available (was: ) > Allow passing parameters to database via jdbc url

[PR] [FLINK-33800][JDBC/Connector] Allow passing parameters to database via jdbc url [flink-connector-jdbc]

2023-12-11 Thread via GitHub
snuyanzin opened a new pull request, #83: URL: https://github.com/apache/flink-connector-jdbc/pull/83 The idea is pretty straightforward: from one side there is a jdbc url which is normally is provided by most of the dbs providers to connect to. From the other side for some, probably hi

Re: [PR] [FLINK-33454] [Operator] Add IngressTlsSpec to support TLS within the managed Ingress, also add Label Passthrough [flink-kubernetes-operator]

2023-12-11 Thread via GitHub
ryanvanhuuksloot commented on code in PR #727: URL: https://github.com/apache/flink-kubernetes-operator/pull/727#discussion_r1423102408 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/IngressUtils.java: ## @@ -93,24 +96,45 @@ private static

Re: [PR] [FLINK-33454] [Operator] Add IngressTlsSpec to support TLS within the managed Ingress, also add Label Passthrough [flink-kubernetes-operator]

2023-12-11 Thread via GitHub
ryanvanhuuksloot commented on code in PR #727: URL: https://github.com/apache/flink-kubernetes-operator/pull/727#discussion_r1423103105 ## flink-kubernetes-operator-api/src/main/java/org/apache/flink/kubernetes/operator/api/spec/IngressTlsSpec.java: ## @@ -0,0 +1,44 @@ +/* + *

Re: [PR] [FLINK-33454] [Operator] Add IngressTlsSpec to support TLS within the managed Ingress, also add Label Passthrough [flink-kubernetes-operator]

2023-12-11 Thread via GitHub
ryanvanhuuksloot commented on code in PR #727: URL: https://github.com/apache/flink-kubernetes-operator/pull/727#discussion_r1423102408 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/IngressUtils.java: ## @@ -93,24 +96,45 @@ private static

Re: [PR] [FLINK-33454] [Operator] Add IngressTlsSpec to support TLS within the managed Ingress, also add Label Passthrough [flink-kubernetes-operator]

2023-12-11 Thread via GitHub
ryanvanhuuksloot commented on code in PR #727: URL: https://github.com/apache/flink-kubernetes-operator/pull/727#discussion_r1423102109 ## docs/content/docs/custom-resource/reference.md: ## @@ -96,6 +96,8 @@ This page serves as a full reference for FlinkDeployment custom resou

[jira] [Created] (FLINK-33800) Allow passing parameters to database via jdbc url

2023-12-11 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-33800: --- Summary: Allow passing parameters to database via jdbc url Key: FLINK-33800 URL: https://issues.apache.org/jira/browse/FLINK-33800 Project: Flink Issue

Re: [PR] [FLINK-33764] Track Heap usage and GC pressure to avoid unnecessary scaling [flink-kubernetes-operator]

2023-12-11 Thread via GitHub
gyfora commented on code in PR #726: URL: https://github.com/apache/flink-kubernetes-operator/pull/726#discussion_r1423061343 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingMetricEvaluator.java: ## @@ -297,6 +301,28 @@ private void computeTargetDataRate(

Re: [PR] [FLINK-33764] Track Heap usage and GC pressure to avoid unnecessary scaling [flink-kubernetes-operator]

2023-12-11 Thread via GitHub
gyfora commented on code in PR #726: URL: https://github.com/apache/flink-kubernetes-operator/pull/726#discussion_r1423061010 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/config/AutoScalerOptions.java: ## @@ -222,6 +222,18 @@ private static ConfigOptions.Option

Re: [PR] [FLINK-33764] Track Heap usage and GC pressure to avoid unnecessary scaling [flink-kubernetes-operator]

2023-12-11 Thread via GitHub
gyfora commented on code in PR #726: URL: https://github.com/apache/flink-kubernetes-operator/pull/726#discussion_r1423057412 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/RestApiMetricsCollector.java: ## @@ -78,19 +91,87 @@ protected Map queryAggregatedVertexM

Re: [PR] [FLINK-33764] Track Heap usage and GC pressure to avoid unnecessary scaling [flink-kubernetes-operator]

2023-12-11 Thread via GitHub
gyfora commented on code in PR #726: URL: https://github.com/apache/flink-kubernetes-operator/pull/726#discussion_r1423056535 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/metrics/ScalingMetric.java: ## @@ -65,7 +65,16 @@ public enum ScalingMetric { SCALE_D

Re: [PR] [FLINK-33795] Add new config to forbid autoscaling in certain periods of a day [flink-kubernetes-operator]

2023-12-11 Thread via GitHub
mxm commented on code in PR #728: URL: https://github.com/apache/flink-kubernetes-operator/pull/728#discussion_r1422946292 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/config/AutoScalerOptions.java: ## @@ -72,6 +72,15 @@ private static ConfigOptions.OptionBuild

[jira] [Commented] (FLINK-33373) Capture build scans on ge.apache.org to benefit from deep build insights

2023-12-11 Thread Clay Johnson (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17795475#comment-17795475 ] Clay Johnson commented on FLINK-33373: -- Hi [~mapohl], it was nice to connect with y

[PR] [FLINK-33770] Migrate legacy autoscaler config keys [flink-kubernetes-operator]

2023-12-11 Thread via GitHub
mxm opened a new pull request, #729: URL: https://github.com/apache/flink-kubernetes-operator/pull/729 The previous PR in #725 made the legacy autoscaler config keys "fallback" keys to prevent logging a deprecation WARN message on every reconciliation loop in the operator. Turns out, fallba

[jira] [Commented] (FLINK-33793) java.lang.NoSuchMethodError when checkpointing in Google Cloud Storage

2023-12-11 Thread Chris Nauroth (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17795464#comment-17795464 ] Chris Nauroth commented on FLINK-33793: --- I expect this will be fixed by FLINK-3360

Re: [PR] [FLINK-31631][FileSystems] Upgrade GCS connector to 2.2.11. [flink]

2023-12-11 Thread via GitHub
cnauroth commented on PR #22281: URL: https://github.com/apache/flink/pull/22281#issuecomment-1850568860 > > There is now a patch available here at #23469. > > will it fix this issue? @yigress and @czchen , my apologies, I think I referenced the wrong pull request in my last co

[jira] [Created] (FLINK-33799) Add e2e's for tls enabled operator

2023-12-11 Thread Tony Garrard (Jira)
Tony Garrard created FLINK-33799: Summary: Add e2e's for tls enabled operator Key: FLINK-33799 URL: https://issues.apache.org/jira/browse/FLINK-33799 Project: Flink Issue Type: Technical Debt

[jira] [Commented] (FLINK-33633) Automatic creation of RBAC for instances of Flink Deployments

2023-12-11 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17795454#comment-17795454 ] Gyula Fora commented on FLINK-33633: In my personal opinion, creating the role witho

[jira] [Commented] (FLINK-33633) Automatic creation of RBAC for instances of Flink Deployments

2023-12-11 Thread Ryan van Huuksloot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17795452#comment-17795452 ] Ryan van Huuksloot commented on FLINK-33633: Would there be any appetite to

[jira] [Commented] (FLINK-33728) do not rewatch when KubernetesResourceManagerDriver watch fail

2023-12-11 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17795451#comment-17795451 ] Matthias Pohl commented on FLINK-33728: --- Thanks for creating this Jira issue, [~zh

Re: [PR] [FLINK-33796] Add ability to customize java version for python ci in connectors [flink-connector-shared-utils]

2023-12-11 Thread via GitHub
snuyanzin commented on PR #30: URL: https://github.com/apache/flink-connector-shared-utils/pull/30#issuecomment-1850502662 @pvary yep, sure here it is a link https://github.com/snuyanzin/flink-connector-kafka/actions/runs/7170817788 sorry I didn't put earlier -- This is an auto

[jira] [Updated] (FLINK-33697) FLIP-386: Support adding custom metrics in Recovery Spans

2023-12-11 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-33697: --- Description: h1. Motivation [FLIP-386|https://cwiki.apache.org/confluence/x/VAuZE] is build

Re: [PR] [FLINK-33796] Add ability to customize java version for python ci in connectors [flink-connector-shared-utils]

2023-12-11 Thread via GitHub
pvary commented on PR #30: URL: https://github.com/apache/flink-connector-shared-utils/pull/30#issuecomment-1850450046 @snuyanzin: Do we have a PR where this job has been tried out, and working? For testing my changes I started using the changes on my own repo to verify that everything is

Re: [PR] [FLINK-33454] [Operator] Add IngressTlsSpec to support TLS within the managed Ingress, also add Label Passthrough [flink-kubernetes-operator]

2023-12-11 Thread via GitHub
gyfora commented on code in PR #727: URL: https://github.com/apache/flink-kubernetes-operator/pull/727#discussion_r1422763184 ## flink-kubernetes-operator-api/src/main/java/org/apache/flink/kubernetes/operator/api/spec/IngressTlsSpec.java: ## @@ -0,0 +1,44 @@ +/* + * Licensed t

Re: [PR] [FLINK-33795] Add new config to forbid autoscaling in certain periods of a day [flink-kubernetes-operator]

2023-12-11 Thread via GitHub
gyfora commented on code in PR #728: URL: https://github.com/apache/flink-kubernetes-operator/pull/728#discussion_r1422702163 ## flink-autoscaler/src/test/java/org/apache/flink/autoscaler/utils/AutoScalerUtilsTest.java: ## @@ -56,4 +60,30 @@ public void testVertexExclusion() {

Re: [PR] [FLINK-31631][FileSystems] Upgrade GCS connector to 2.2.11. [flink]

2023-12-11 Thread via GitHub
czchen commented on PR #22281: URL: https://github.com/apache/flink/pull/22281#issuecomment-1850343759 @cnauroth The `java.lang.NoSuchMethodError` issue [remains in 1.18.0](https://issues.apache.org/jira/browse/FLINK-33793). Any change it can be fixed in 1.18 series? -- This is a

[jira] [Commented] (FLINK-26586) FileSystem uses unbuffered read I/O

2023-12-11 Thread Matthias Schwalbe (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17795416#comment-17795416 ] Matthias Schwalbe commented on FLINK-26586: --- Hi [~masteryhx] I've reached agre

[jira] [Updated] (FLINK-33793) java.lang.NoSuchMethodError when checkpointing in Google Cloud Storage

2023-12-11 Thread 陳昌倬
[ https://issues.apache.org/jira/browse/FLINK-33793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ChangZhuo Chen (陳昌倬) updated FLINK-33793: - Description: We have the following exception when checkpointing in Flink 1.18 +

Re: [PR] [FLINK-33500][Runtime] Run storing the JobGraph an asynchronous operation [flink]

2023-12-11 Thread via GitHub
XComp commented on code in PR #23880: URL: https://github.com/apache/flink/pull/23880#discussion_r1422663705 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/JobGraphWriter.java: ## @@ -37,6 +38,18 @@ public interface JobGraphWriter extends LocallyCleanableRes

[jira] [Closed] (FLINK-28215) Bump Maven Surefire plugin to 3.2.2

2023-12-11 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-28215. -- Fix Version/s: 1.19.0 Resolution: Fixed Fixed in apache/flink:master ea4cdc28651ad91def

Re: [PR] [FLINK-28215][Buildsystem] Update Maven Surefire plugin to 3.2.2 [flink]

2023-12-11 Thread via GitHub
MartijnVisser merged PR #22502: URL: https://github.com/apache/flink/pull/22502 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink

Re: [PR] [FLINK-28215][Buildsystem] Update Maven Surefire plugin to 3.2.2 [flink]

2023-12-11 Thread via GitHub
MartijnVisser commented on PR #22502: URL: https://github.com/apache/flink/pull/22502#issuecomment-1850303930 > Was there a specific reason that made us wanting to upgrade the surefire plugin? Nothing more then I always prefer to run on stable version over milestone releases :) --

Re: [PR] [FLINK-32895][Scheduler] Introduce the max attempts for Exponential Delay Restart Strategy [flink]

2023-12-11 Thread via GitHub
mxm commented on code in PR #23247: URL: https://github.com/apache/flink/pull/23247#discussion_r1422626734 ## flink-core/src/main/java/org/apache/flink/configuration/RestartStrategyOptions.java: ## @@ -184,7 +184,7 @@ public class RestartStrategyOptions { public static fina

  1   2   3   >