Re: [PR] [ FLINK-33603][FileSystems] shade guava in gs-fs filesystem [flink]

2023-12-15 Thread via GitHub
MartijnVisser commented on PR #23489: URL: https://github.com/apache/flink/pull/23489#issuecomment-1857706468 @snuyanzin I'm also looping you in here > I'm currently testing if my patch would also work when backported to 1.18. Newsflash: I didn't work  Which in hindsight, is

[jira] [Commented] (FLINK-33704) Update GCS filesystems to latest available versions

2023-12-15 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17797143#comment-17797143 ] Martijn Visser commented on FLINK-33704: Fixed in apache/flink:master

[jira] [Updated] (FLINK-33704) Update GCS filesystems to latest available versions

2023-12-15 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-33704: --- Fix Version/s: 1.19.0 > Update GCS filesystems to latest available versions >

Re: [PR] test request [flink]

2023-12-15 Thread via GitHub
singhravidutt commented on PR #23933: URL: https://github.com/apache/flink/pull/23933#issuecomment-1857693176 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Updated] (FLINK-32394) Init.pos is partially stored in connector state

2023-12-15 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer updated FLINK-32394: -- Description: The Init.pos is partially stored in connector state which can lead to

Re: [PR] [ FLINK-33603][FileSystems] shade guava in gs-fs filesystem [flink]

2023-12-15 Thread via GitHub
MartijnVisser commented on PR #23489: URL: https://github.com/apache/flink/pull/23489#issuecomment-1857672990 @JingGe @singhravidutt I think I've cracked it :) 1. I've setup a GCS bucket and created a checkpointing test job in order to reproduce the error that's happening in Flink

[jira] [Commented] (FLINK-33644) FLIP-393: Make QueryOperations SQL serializable

2023-12-15 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17797131#comment-17797131 ] Timo Walther commented on FLINK-33644: -- [~fsk119] QueryOperations are intended to be put into a

Re: [PR] test request [flink]

2023-12-15 Thread via GitHub
singhravidutt commented on PR #23933: URL: https://github.com/apache/flink/pull/23933#issuecomment-1857622904 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Resolved] (FLINK-20772) RocksDBValueState with TTL occurs NullPointerException when calling update(null) method

2023-12-15 Thread Hangxiang Yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hangxiang Yu resolved FLINK-20772. -- Fix Version/s: 1.19.0 Resolution: Fixed merged ac1ed6b6 and 9aa7a3cd into master >

Re: [PR] [FLINK-30613] Improve resolving schema compatibility -- Milestone one [flink]

2023-12-15 Thread via GitHub
1996fanrui commented on code in PR #21635: URL: https://github.com/apache/flink/pull/21635#discussion_r1427799403 ## flink-core/src/main/java/org/apache/flink/api/common/typeutils/TypeSerializerSnapshot.java: ## @@ -124,11 +124,40 @@ void readSnapshot(int readVersion,

Re: [PR] [FLINK-20772][State] Make TtlValueState#update follow the description of interface about null values [flink]

2023-12-15 Thread via GitHub
masteryhx closed pull request #23928: [FLINK-20772][State] Make TtlValueState#update follow the description of interface about null values URL: https://github.com/apache/flink/pull/23928 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [FLINK-30613] Improve resolving schema compatibility -- Milestone one [flink]

2023-12-15 Thread via GitHub
1996fanrui commented on code in PR #21635: URL: https://github.com/apache/flink/pull/21635#discussion_r1427798414 ## flink-core/src/main/java/org/apache/flink/api/common/typeutils/TypeSerializerSnapshot.java: ## @@ -124,11 +124,40 @@ void readSnapshot(int readVersion,

Re: [PR] [FLINK-33807] Update JUnit to 5.10.1 [flink]

2023-12-15 Thread via GitHub
snuyanzin commented on PR #23917: URL: https://github.com/apache/flink/pull/23917#issuecomment-1857613116 @Jiabao-Sun can you please have a look one more time PS. I started to use ```scala val baseCheckpointPath = Files.createTempDirectory(getClass.getCanonicalName)

Re: [PR] test request [flink]

2023-12-15 Thread via GitHub
flinkbot commented on PR #23933: URL: https://github.com/apache/flink/pull/23933#issuecomment-1857603025 ## CI report: * 91a51e2aff2503eada9f86122a868dc4d1b091c7 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Closed] (FLINK-33767) Implement restore tests for TemporalJoin node

2023-12-15 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz closed FLINK-33767. Fix Version/s: 1.19.0 Resolution: Implemented Implemented in

[jira] [Updated] (FLINK-33825) Create a new version in JIRA

2023-12-15 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-33825: --- Affects Version/s: 1.18.1 > Create a new version in JIRA > > >

Re: [PR] [FLINK-33767] Implement restore tests for TemporalJoin node [flink]

2023-12-15 Thread via GitHub
dawidwys closed pull request #23916: [FLINK-33767] Implement restore tests for TemporalJoin node URL: https://github.com/apache/flink/pull/23916 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Resolved] (FLINK-33825) Create a new version in JIRA

2023-12-15 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu resolved FLINK-33825. Resolution: Resolved 1.18.2 version created

[jira] [Updated] (FLINK-33825) Create a new version in JIRA

2023-12-15 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-33825: --- Fix Version/s: 1.18.1 > Create a new version in JIRA > > >

[jira] [Assigned] (FLINK-33825) Create a new version in JIRA

2023-12-15 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu reassigned FLINK-33825: -- Assignee: Leonard Xu > Create a new version in JIRA > > >

Re: [PR] test request [flink]

2023-12-15 Thread via GitHub
singhravidutt commented on PR #23933: URL: https://github.com/apache/flink/pull/23933#issuecomment-1857591912 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] test request [flink]

2023-12-15 Thread via GitHub
singhravidutt opened a new pull request, #23933: URL: https://github.com/apache/flink/pull/23933 ## What is the purpose of the change Shade the guava version required specifically by google-cloud-storage. ## Brief change log Introduced dependency on guava version(`31.1-jre`)

Re: [PR] [FLINK-33779][table] Cleanup usage of deprecated BaseExpressions#cast [flink]

2023-12-15 Thread via GitHub
liuyongvs commented on PR #23895: URL: https://github.com/apache/flink/pull/23895#issuecomment-1857589699 @xuyangzhong thanks for your rewiew and modify the description of this pr -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (FLINK-31615) Fix some parts forgot to translate in "Table API" page of "Table API & SQL"

2023-12-15 Thread Hang Ruan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17797117#comment-17797117 ] Hang Ruan commented on FLINK-31615: --- [~Wencong Liu] Sorry for the late reply.  I have raised a PR to

Re: [PR] [FLINK-33778][table] Cleanup usage of deprecated TableConfig#setIdleS… [flink]

2023-12-15 Thread via GitHub
liuyongvs commented on PR #23894: URL: https://github.com/apache/flink/pull/23894#issuecomment-1857586748 @xuyangzhong thanks for your review and fix the description of pr -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [FLINK-33787][jdbc] Java 17 support for jdbc connector [flink-connector-jdbc]

2023-12-15 Thread via GitHub
snuyanzin commented on code in PR #82: URL: https://github.com/apache/flink-connector-jdbc/pull/82#discussion_r1427768216 ## .github/workflows/weekly.yml: ## @@ -45,6 +45,14 @@ jobs: flink: 1.18.0, branch: v3.1 }] +jdk: [ 8, 11 ] +

Re: [PR] [FLINK-32949][core]collect tm port binding with TaskManagerOptions [flink]

2023-12-15 Thread via GitHub
JingGe commented on PR #23870: URL: https://github.com/apache/flink/pull/23870#issuecomment-1857569661 Thanks @xintongsong for your review and comments. I have addressed all of them. Once you confirmed the PR, I will rebase it and squash all commits into one. -- This is an automated

[jira] [Closed] (FLINK-32028) Error handling for the new Elasticsearch sink

2023-12-15 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo closed FLINK-32028. -- Resolution: Fixed > Error handling for the new Elasticsearch sink >

[jira] [Commented] (FLINK-32028) Error handling for the new Elasticsearch sink

2023-12-15 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17797103#comment-17797103 ] Weijie Guo commented on FLINK-32028: main via 40774fad0f4ecd1a0d104dcb339e6bb860b0a4bf. > Error

[jira] [Updated] (FLINK-32028) Error handling for the new Elasticsearch sink

2023-12-15 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-32028: --- Fix Version/s: elasticsearch-3.1.0 > Error handling for the new Elasticsearch sink >

[jira] [Updated] (FLINK-32028) Error handling for the new Elasticsearch sink

2023-12-15 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-32028: --- Affects Version/s: elasticsearch-3.0.0 (was: 1.16.1) > Error handling

Re: [PR] [FLINK-32028][connectors/elasticsearch] Allow customising bulk failure handling [flink-connector-elasticsearch]

2023-12-15 Thread via GitHub
reswqa commented on PR #83: URL: https://github.com/apache/flink-connector-elasticsearch/pull/83#issuecomment-1857562853 Thanks @schulzp, nice one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [FLINK-32028][connectors/elasticsearch] Allow customising bulk failure handling [flink-connector-elasticsearch]

2023-12-15 Thread via GitHub
boring-cyborg[bot] commented on PR #83: URL: https://github.com/apache/flink-connector-elasticsearch/pull/83#issuecomment-1857562560 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [FLINK-32028][connectors/elasticsearch] Allow customising bulk failure handling [flink-connector-elasticsearch]

2023-12-15 Thread via GitHub
reswqa merged PR #83: URL: https://github.com/apache/flink-connector-elasticsearch/pull/83 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-33853][runtime][JUnit5 Migration] Migrate Junit5 for DeclarativeSlotPoolBridge test classes of runtime module [flink]

2023-12-15 Thread via GitHub
1996fanrui commented on code in PR #23932: URL: https://github.com/apache/flink/pull/23932#discussion_r1427755866 ## flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/slotpool/DeclarativeSlotPoolBridgeRequestCompletionTest.java: ## @@ -43,27 +44,24 @@ import

[jira] [Updated] (FLINK-33856) Add metrics to monitor the interaction performance between task and external storage system in the process of checkpoint making

2023-12-15 Thread Jufang He (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jufang He updated FLINK-33856: -- Description: When Flink makes a Checkpoint, the interaction performance with the external file

[jira] [Created] (FLINK-33856) Add metrics to monitor the interaction performance between task and external storage system in the process of checkpoint making

2023-12-15 Thread Jufang He (Jira)
Jufang He created FLINK-33856: - Summary: Add metrics to monitor the interaction performance between task and external storage system in the process of checkpoint making Key: FLINK-33856 URL:

Re: [PR] [FLINK-33719][table] Cleanup the usage of deprecated StreamTableEnvir… [flink]

2023-12-15 Thread via GitHub
xuyangzhong commented on code in PR #23898: URL: https://github.com/apache/flink/pull/23898#discussion_r1427704155 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/utils/RowToTuple2.scala: ## @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache

[jira] [Created] (FLINK-33855) send flag message like checkpoint barrier

2023-12-15 Thread Spongebob (Jira)
Spongebob created FLINK-33855: - Summary: send flag message like checkpoint barrier Key: FLINK-33855 URL: https://issues.apache.org/jira/browse/FLINK-33855 Project: Flink Issue Type: Technical

Re: [PR] [FLINK-33853][runtime][JUnit5 Migration] Migrate Junit5 for DeclarativeSlotPoolBridge test classes of runtime module [flink]

2023-12-15 Thread via GitHub
RocMarshal commented on PR #23932: URL: https://github.com/apache/flink/pull/23932#issuecomment-1857550752 Hi, @1996fanrui Could you help review this pr if you're in the free time? Thank you~ -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Commented] (FLINK-15571) Create a Redis Streams Connector for Flink

2023-12-15 Thread Jinsui Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17797097#comment-17797097 ] Jinsui Chen commented on FLINK-15571: - In addition to Redis stream, is it possible for other Redis

Re: [PR] [FLINK-33800][JDBC/Connector] Allow passing parameters to database via jdbc url [flink-connector-jdbc]

2023-12-15 Thread via GitHub
eskabetxe commented on PR #83: URL: https://github.com/apache/flink-connector-jdbc/pull/83#issuecomment-1857538260 this is also related with this: https://github.com/apache/flink-connector-jdbc/pull/74 -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [FLINK-33787][jdbc] Java 17 support for jdbc connector [flink-connector-jdbc]

2023-12-15 Thread via GitHub
eskabetxe commented on code in PR #82: URL: https://github.com/apache/flink-connector-jdbc/pull/82#discussion_r1427735877 ## .github/workflows/weekly.yml: ## @@ -45,6 +45,14 @@ jobs: flink: 1.18.0, branch: v3.1 }] +jdk: [ 8, 11 ] +

Re: [PR] [FLINK-33800][JDBC/Connector] Allow passing parameters to database via jdbc url [flink-connector-jdbc]

2023-12-15 Thread via GitHub
eskabetxe commented on PR #83: URL: https://github.com/apache/flink-connector-jdbc/pull/83#issuecomment-1857519079 Hi @snuyanzin, I can imagine that the intention would be to have all the db's with a single catalog, but being mandatory the default-database my assumption can be wrong..

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

2023-12-15 Thread via GitHub
RocMarshal commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1427717395 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/DeclarativeSlotPoolBridge.java: ## @@ -200,10 +226,45 @@ protected void

[jira] [Created] (FLINK-33854) YARNSessionCapacitySchedulerITCase.testVCoresAreSetCorrectlyAndJobManagerHostnameAreShownInWebInterfaceAndDynamicPropertiesAndYarnApplicationNameAndTaskManagerSlots time

2023-12-15 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-33854: - Summary: YARNSessionCapacitySchedulerITCase.testVCoresAreSetCorrectlyAndJobManagerHostnameAreShownInWebInterfaceAndDynamicPropertiesAndYarnApplicationNameAndTaskManagerSlots times out Key:

[jira] [Commented] (FLINK-33414) MiniClusterITCase.testHandleStreamingJobsWhenNotEnoughSlot fails due to unexpected TimeoutException

2023-12-15 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17797082#comment-17797082 ] Matthias Pohl commented on FLINK-33414: ---

[jira] [Resolved] (FLINK-33733) [FLIP-321] Update the stability docs to add the migration periods.

2023-12-15 Thread Jiangjie Qin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin resolved FLINK-33733. -- Fix Version/s: 1.19.0 Resolution: Fixed > [FLIP-321] Update the stability docs to add

Re: [PR] [ FLINK-33603][FileSystems] shade guava in gs-fs filesystem [flink]

2023-12-15 Thread via GitHub
MartijnVisser commented on PR #23489: URL: https://github.com/apache/flink/pull/23489#issuecomment-1857461633 @JingGe Thanks for the comments. I've been looking at different options to shade the artifacts, and also try that with a local application that writes to GCS. Unfortunately, I

[jira] [Commented] (FLINK-33733) [FLIP-321] Update the stability docs to add the migration periods.

2023-12-15 Thread Jiangjie Qin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17797081#comment-17797081 ] Jiangjie Qin commented on FLINK-33733: -- Just realized that I forgot to make the PR title start with

Re: [PR] [FLINK-33641][test] Suppress the DirectoryNotEmptyException in StreamingWithStateTestBase to prevent test failures [flink]

2023-12-15 Thread via GitHub
Jiabao-Sun commented on PR #23914: URL: https://github.com/apache/flink/pull/23914#issuecomment-1857456731 Thanks @snuyanzin, it makes sense to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [FLIP-321] Update the docs to add migration periods for deprecated APIs. [flink]

2023-12-15 Thread via GitHub
becketqin merged PR #23865: URL: https://github.com/apache/flink/pull/23865 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-33641][test] Suppress the DirectoryNotEmptyException in StreamingWithStateTestBase to prevent test failures [flink]

2023-12-15 Thread via GitHub
snuyanzin commented on PR #23914: URL: https://github.com/apache/flink/pull/23914#issuecomment-1857452824 ArchUnit does not suport scala, it is mentioned in readme

<    1   2