RocMarshal commented on code in PR #23635:
URL: https://github.com/apache/flink/pull/23635#discussion_r1427717395
##########
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/DeclarativeSlotPoolBridge.java:
##########
@@ -200,10 +226,45 @@ protected void onReleaseTaskManager(ResourceCounter
previouslyFulfilledRequireme
@VisibleForTesting
void newSlotsAreAvailable(Collection<? extends PhysicalSlot> newSlots) {
+ if (!globalSlotsViewable) {
+ final Collection<RequestSlotMatchingStrategy.RequestSlotMatch>
requestSlotMatches =
+ requestSlotMatchingStrategy.matchRequestsAndSlots(
+ newSlots, pendingRequests.values());
+ reserveMatchedFreeSlots(requestSlotMatches);
+ fulfillMatchedSlots(requestSlotMatches);
+ return;
+ }
+
+ receivedSlots.addAll(newSlots);
+ if (receivedSlots.size() < pendingRequests.size()) {
+ return;
+ }
final Collection<RequestSlotMatchingStrategy.RequestSlotMatch>
requestSlotMatches =
requestSlotMatchingStrategy.matchRequestsAndSlots(
newSlots, pendingRequests.values());
+ if (requestSlotMatches.size() == pendingRequests.size()) {
+ reserveMatchedFreeSlots(requestSlotMatches);
+ fulfillMatchedSlots(requestSlotMatches);
+ }
+ receivedSlots.clear();
Review Comment:
IIUC, Batched resource requests are sent to RM, and generally, all slots on
each TM are provided to the `DeclarativeSlotPoolBridge` in a batch, with each
call triggered `newAvailableSlots` once. So we need to cache it here, right ?
I'd appreciate it with your opinion or confirmation .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
