Re: [PR] [FLINK-34055][table] Introduce a new annotation for named parameters [flink]

2024-01-22 Thread via GitHub
hackergin commented on PR #24106: URL: https://github.com/apache/flink/pull/24106#issuecomment-1905479204 @xuyangzhong Thank you for the review. I have already updated the code. Please take a look when you have time. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] [FLINK-33403] Bump flink version to 1.18.1 for flink-kubernetes-operator [flink-kubernetes-operator]

2024-01-22 Thread via GitHub
1996fanrui merged PR #697: URL: https://github.com/apache/flink-kubernetes-operator/pull/697 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsu

Re: [PR] [FLINK-33403] Bump flink version to 1.18.1 for flink-kubernetes-operator [flink-kubernetes-operator]

2024-01-22 Thread via GitHub
1996fanrui commented on PR #697: URL: https://github.com/apache/flink-kubernetes-operator/pull/697#issuecomment-1905478305 Thanks for the quick review, merging~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Closed] (FLINK-34141) Bash exited with code '143'

2024-01-22 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl closed FLINK-34141. - Resolution: Cannot Reproduce Thanks for reporting the issues [~xuyangzhong]. We experienced CI

[jira] [Updated] (FLINK-34207) org.apache.flink:flink-shaded-jackson:jar:2.15.3-18.0 couldn't be downloaded

2024-01-22 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-34207: -- Priority: Critical (was: Major) > org.apache.flink:flink-shaded-jackson:jar:2.15.3-18.0 could

[jira] [Commented] (FLINK-34115) TableAggregateITCase.testFlagAggregateWithOrWithoutIncrementalUpdate fails

2024-01-22 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809781#comment-17809781 ] Matthias Pohl commented on FLINK-34115: --- 1.18: https://dev.azure.com/apache-flink

Re: [PR] E2E for minibatch join [flink]

2024-01-22 Thread via GitHub
lsyldliu commented on code in PR #24161: URL: https://github.com/apache/flink/pull/24161#discussion_r1462830909 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/JoinUtil.scala: ## @@ -95,6 +105,18 @@ object JoinUtil { } } + /

[jira] [Commented] (FLINK-34202) python tests take suspiciously long in some of the cases

2024-01-22 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809780#comment-17809780 ] Matthias Pohl commented on FLINK-34202: --- https://dev.azure.com/apache-flink/apache

[jira] [Created] (FLINK-34207) org.apache.flink:flink-shaded-jackson:jar:2.15.3-18.0 couldn't be downloaded

2024-01-22 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-34207: - Summary: org.apache.flink:flink-shaded-jackson:jar:2.15.3-18.0 couldn't be downloaded Key: FLINK-34207 URL: https://issues.apache.org/jira/browse/FLINK-34207 Projec

[jira] [Created] (FLINK-34206) CacheITCase.testRetryOnCorruptedClusterDataset(Path) failed

2024-01-22 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-34206: - Summary: CacheITCase.testRetryOnCorruptedClusterDataset(Path) failed Key: FLINK-34206 URL: https://issues.apache.org/jira/browse/FLINK-34206 Project: Flink

Re: [PR] [FLINK-33403] Bump flink version to 1.18.1 for flink-kubernetes-operator [flink-kubernetes-operator]

2024-01-22 Thread via GitHub
1996fanrui commented on PR #697: URL: https://github.com/apache/flink-kubernetes-operator/pull/697#issuecomment-1905451248 Hi @gyfora , this PR is done for now due to 1.18.1 is released. Please help take a look in your free time, thanks~ -- This is an automated message from the A

Re: [PR] [FLINK-33263][table-planner] Implement ParallelismProvider for sources in the table planner [flink]

2024-01-22 Thread via GitHub
BIOINSu commented on PR #24128: URL: https://github.com/apache/flink/pull/24128#issuecomment-1905451090 @libenchao Thanks for the review comments. In fact, the "Deal with changelog messages" is necessary. In the previous version of the code, since consuming the changelog stream will

[jira] [Commented] (FLINK-34202) python tests take suspiciously long in some of the cases

2024-01-22 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809774#comment-17809774 ] Matthias Pohl commented on FLINK-34202: --- https://dev.azure.com/apache-flink/apache

Re: [PR] [FLINK-34115][table-planner] Fix unstable TableAggregateITCase.testFlagAggregateWithOrWithoutIncrementalUpdate [flink]

2024-01-22 Thread via GitHub
flinkbot commented on PR #24172: URL: https://github.com/apache/flink/pull/24172#issuecomment-1905449499 ## CI report: * a3e56a0fb526c8c410a45ab3e6d30fd26a28bd45 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-34143] Modify the effective strategy of `execution.batch.adaptive.auto-parallelism.default-source-parallelism` [flink]

2024-01-22 Thread via GitHub
SinBex commented on PR #24170: URL: https://github.com/apache/flink/pull/24170#issuecomment-1905438404 @zhuzhurk Thanks for reviewing! I have fixed the problems you commented. PTAL~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[jira] [Updated] (FLINK-34115) TableAggregateITCase.testFlagAggregateWithOrWithoutIncrementalUpdate fails

2024-01-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34115: --- Labels: pull-request-available test-stability (was: test-stability) > TableAggregateITCase.

[PR] [FLINK-34115][table-planner] Fix unstable TableAggregateITCase.testFlagAggregateWithOrWithoutIncrementalUpdate [flink]

2024-01-22 Thread via GitHub
LadyForest opened a new pull request, #24172: URL: https://github.com/apache/flink/pull/24172 ## What is the purpose of the change This PR fixes the unstable test case `TableAggregateITCase.testFlagAggregateWithOrWithoutIncrementalUpdate`. I attempted to reproduce the failure, but

Re: [PR] [FLINK-33263][table-planner] Implement ParallelismProvider for sources in the table planner [flink]

2024-01-22 Thread via GitHub
BIOINSu commented on code in PR #24128: URL: https://github.com/apache/flink/pull/24128#discussion_r1462820066 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/TableSourceITCase.scala: ## @@ -421,4 +424,81 @@ class TableSourceIT

Re: [PR] [FLINK-33263][table-planner] Implement ParallelismProvider for sources in the table planner [flink]

2024-01-22 Thread via GitHub
BIOINSu commented on code in PR #24128: URL: https://github.com/apache/flink/pull/24128#discussion_r1462818847 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecTableSourceScan.java: ## @@ -105,54 +112,92 @@ protecte

[jira] [Commented] (FLINK-34115) TableAggregateITCase.testFlagAggregateWithOrWithoutIncrementalUpdate fails

2024-01-22 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809769#comment-17809769 ] Jane Chan commented on FLINK-34115: --- Sorry for the late update. I attempted to reprod

Re: [PR] [FLINK-34165][1.15] update the apache download url for asc [flink-docker]

2024-01-22 Thread via GitHub
JingGe merged PR #173: URL: https://github.com/apache/flink-docker/pull/173 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

Re: [PR] [FLINK-34165][1.16] update the apache download url for asc [flink-docker]

2024-01-22 Thread via GitHub
JingGe merged PR #172: URL: https://github.com/apache/flink-docker/pull/172 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

Re: [PR] [FLINK-33263][table-planner] Implement ParallelismProvider for sources in the table planner [flink]

2024-01-22 Thread via GitHub
BIOINSu commented on code in PR #24128: URL: https://github.com/apache/flink/pull/24128#discussion_r1462814218 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/transformations/SourceTransformationWrapper.java: ## @@ -0,0 +1,70 @@ +/* +Licensed to the Apache S

[jira] [Updated] (FLINK-34205) Update flink-docker's Dockerfile and docker-entrypoint.sh to use BashJavaUtils for Flink configuration management

2024-01-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34205: --- Labels: pull-request-available (was: ) > Update flink-docker's Dockerfile and docker-entryp

Re: [PR] [FLINK-33263][table-planner] Implement ParallelismProvider for sources in the table planner [flink]

2024-01-22 Thread via GitHub
BIOINSu commented on code in PR #24128: URL: https://github.com/apache/flink/pull/24128#discussion_r1462815202 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecTableSourceScan.java: ## @@ -72,6 +76,8 @@ public abstr

[PR] [FLINK-34205] Use BashJavaUtils for Flink configuration management [flink-docker]

2024-01-22 Thread via GitHub
JunRuiLee opened a new pull request, #175: URL: https://github.com/apache/flink-docker/pull/175 The flink-docker's Dockerfile and docker-entrypoint.sh currently use shell scripting techniques with grep and sed for configuration reading and modification. This method is not suitable for the s

Re: [PR] [FLINK-33263][table-planner] Implement ParallelismProvider for sources in the table planner [flink]

2024-01-22 Thread via GitHub
BIOINSu commented on code in PR #24128: URL: https://github.com/apache/flink/pull/24128#discussion_r1462814919 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/transformations/SourceTransformationWrapper.java: ## @@ -0,0 +1,70 @@ +/* +Licensed to the Apache S

Re: [PR] [FLINK-34165] update the apache download url for asc in the dockerfiles [flink-docker]

2024-01-22 Thread via GitHub
JingGe merged PR #174: URL: https://github.com/apache/flink-docker/pull/174 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

Re: [PR] [FLINK-34165][1.17] update the apache download url for asc [flink-docker]

2024-01-22 Thread via GitHub
JingGe merged PR #171: URL: https://github.com/apache/flink-docker/pull/171 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

[jira] [Closed] (FLINK-33721) Extend BashJavaUtils to Support Reading and Writing Standard YAML Files

2024-01-22 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu closed FLINK-33721. --- Fix Version/s: 1.19.0 Resolution: Done master/release-1.19: 1f7622d4d23bfcb76f466469ec36585054864f04

Re: [PR] [FLINK-33721][core] Extend BashJavaUtils to support reading and writing standard yaml file. [flink]

2024-01-22 Thread via GitHub
zhuzhurk closed pull request #24091: [FLINK-33721][core] Extend BashJavaUtils to support reading and writing standard yaml file. URL: https://github.com/apache/flink/pull/24091 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [FLINK-34048][table] Support session window agg in table runtime instead of using legacy group window agg op [flink]

2024-01-22 Thread via GitHub
xuyangzhong commented on code in PR #24150: URL: https://github.com/apache/flink/pull/24150#discussion_r1462774754 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/window/tvf/unslicing/UnslicingTriggerContextBase.java: ## @@ -0,0 +1,163 @

Re: [PR] [FLINK-34048][table] Support session window agg in table runtime instead of using legacy group window agg op [flink]

2024-01-22 Thread via GitHub
xuyangzhong commented on code in PR #24150: URL: https://github.com/apache/flink/pull/24150#discussion_r1462774306 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/aggregate/window/processors/UnsliceWindowAggProcessor.java: ## @@ -0,0 +1,

Re: [PR] [FLINK-34196][FLIP-389] Annotate SingleThreadFetcherManager as PublicEvolving. [flink]

2024-01-22 Thread via GitHub
flinkbot commented on PR #24171: URL: https://github.com/apache/flink/pull/24171#issuecomment-1905362841 ## CI report: * 508fae68f3527c21dab98fd4dc8da6252aa775b6 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-34196][FLIP-389] Annotate SingleThreadFetcherManager as PublicEvolving. [flink]

2024-01-22 Thread via GitHub
loserwang1024 commented on PR #24171: URL: https://github.com/apache/flink/pull/24171#issuecomment-1905353388 @PatrickRen , @leonardBang , CC, WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[jira] [Updated] (FLINK-34196) FLIP-389 Annotate SingleThreadFetcherManager as PublicEvolving.

2024-01-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34196: --- Labels: pull-request-available (was: ) > FLIP-389 Annotate SingleThreadFetcherManager as Pu

[PR] [FLINK-34196][FLIP-389] Annotate SingleThreadFetcherManager as PublicEvolving. [flink]

2024-01-22 Thread via GitHub
loserwang1024 opened a new pull request, #24171: URL: https://github.com/apache/flink/pull/24171 ## What is the purpose of the change As shown in [FLIP-389](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=278465498), this PR has 2 goals: - To expose the SplitFetch

[jira] [Updated] (FLINK-33325) FLIP-375: Built-in cross-platform powerful java profiler

2024-01-22 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang updated FLINK-33325: - Fix Version/s: 1.19.0 > FLIP-375: Built-in cross-platform powerful java profiler > -

[jira] [Updated] (FLINK-34196) FLIP-389 Annotate SingleThreadFetcherManager as PublicEvolving.

2024-01-22 Thread Hongshun Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hongshun Wang updated FLINK-34196: -- Description: This improvement implements [FLIP-389](https://cwiki.apache.org/confluence/pages

[jira] [Resolved] (FLINK-34029) Support different profiling mode on Flink WEB

2024-01-22 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang resolved FLINK-34029. -- Fix Version/s: 1.19.0 Assignee: Yu Chen Resolution: Fixed merged in master: 4db6e72ed7

Re: [PR] [FLINK-34029][runtime-web] Support different profiling mode on Flink WEB [flink]

2024-01-22 Thread via GitHub
Myasuka merged PR #24130: URL: https://github.com/apache/flink/pull/24130 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apach

Re: [PR] [FLINK-34143] Modify the effective strategy of `execution.batch.adaptive.auto-parallelism.default-source-parallelism` [flink]

2024-01-22 Thread via GitHub
zhuzhurk commented on code in PR #24170: URL: https://github.com/apache/flink/pull/24170#discussion_r1462752170 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptivebatch/DefaultVertexParallelismAndInputInfosDecider.java: ## @@ -559,7 +559,7 @@ static Defaul

Re: [PR] [FLINK-34143] Modify the effective strategy of `execution.batch.adaptive.auto-parallelism.default-source-parallelism` [flink]

2024-01-22 Thread via GitHub
zhuzhurk commented on code in PR #24170: URL: https://github.com/apache/flink/pull/24170#discussion_r1462747422 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptivebatch/DefaultVertexParallelismAndInputInfosDecider.java: ## @@ -559,7 +559,7 @@ static Defaul

Re: [PR] [FLINK-33865][runtime] Adding an ITCase to ensure `exponential-delay.attempts-before-reset-backoff` works well [flink]

2024-01-22 Thread via GitHub
1996fanrui commented on code in PR #23942: URL: https://github.com/apache/flink/pull/23942#discussion_r1462744107 ## flink-core/src/main/java/org/apache/flink/configuration/RestartStrategyOptions.java: ## @@ -55,6 +64,54 @@ public class RestartStrategyOptions { @Internal

[jira] [Comment Edited] (FLINK-33365) Missing filter condition in execution plan containing lookup join with mysql jdbc connector

2024-01-22 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809712#comment-17809712 ] Benchao Li edited comment on FLINK-33365 at 1/23/24 5:18 AM: -

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2024-01-22 Thread via GitHub
libenchao commented on PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#issuecomment-1905255051 @davidradl @snuyanzin I reviewed, and added a few cosmetic changes in [commit](https://github.com/libenchao/flink-connector-jdbc/commit/24caa99cd97e86afb1836886d51007775ed95ddc

[jira] [Commented] (FLINK-34183) Add NOTICE files for Flink CDC project

2024-01-22 Thread Zhongqiang Gong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809727#comment-17809727 ] Zhongqiang Gong commented on FLINK-34183: - [~leonard]  I'm willing to take this.

Re: [PR] [FLINK-33728] Do not rewatch when KubernetesResourceManagerDriver wat… [flink]

2024-01-22 Thread via GitHub
xintongsong commented on code in PR #24163: URL: https://github.com/apache/flink/pull/24163#discussion_r1462693554 ## flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/Fabric8FlinkKubeClient.java: ## @@ -102,6 +109,14 @@ public Fabric8FlinkKubeClient(

[jira] [Commented] (FLINK-34187) Setup CI for Flink CDC project

2024-01-22 Thread Zhongqiang Gong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809725#comment-17809725 ] Zhongqiang Gong commented on FLINK-34187: - [~leonard] Here is the pr https://gi

[jira] [Created] (FLINK-34205) Update flink-docker's Dockerfile and docker-entrypoint.sh to use BashJavaUtils for Flink configuration management

2024-01-22 Thread Junrui Li (Jira)
Junrui Li created FLINK-34205: - Summary: Update flink-docker's Dockerfile and docker-entrypoint.sh to use BashJavaUtils for Flink configuration management Key: FLINK-34205 URL: https://issues.apache.org/jira/browse/FL

[jira] [Commented] (FLINK-34182) Migrate doc website from ververica to flink

2024-01-22 Thread Zhongqiang Gong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809724#comment-17809724 ] Zhongqiang Gong commented on FLINK-34182: - [~leonard] Here is the pr https://gi

Re: [PR] [FLINK-25509][connector/kafka] Add RecordEvaluator to dynamically stop source based on de-serialized records [flink-connector-kafka]

2024-01-22 Thread via GitHub
ruanhang1993 commented on PR #76: URL: https://github.com/apache/flink-connector-kafka/pull/76#issuecomment-1905241938 Hi, @MartijnVisser. You are right. As the comments in [FLINK-25509](https://issues.apache.org/jira/browse/FLINK-25509), I need to put this feature to a version which on

[jira] [Updated] (FLINK-34181) Migrate repo from ververica to apache

2024-01-22 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qingsheng Ren updated FLINK-34181: -- Summary: Migrate repo from ververica to apache (was: Migrate repo from ververica to apche) >

Re: [PR] [FLINK-34048][table] Support session window agg in table runtime instead of using legacy group window agg op [flink]

2024-01-22 Thread via GitHub
xuyangzhong commented on code in PR #24150: URL: https://github.com/apache/flink/pull/24150#discussion_r1462680838 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/window/tvf/unslicing/UnslicingWindowProcessor.java: ## @@ -0,0 +1,26 @@ +/

[jira] [Commented] (FLINK-34187) Setup CI for Flink CDC project

2024-01-22 Thread Zhongqiang Gong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809719#comment-17809719 ] Zhongqiang Gong commented on FLINK-34187: - [~leonard] I'm willing to take this,

[jira] [Commented] (FLINK-34182) Migrate doc website from ververica to flink

2024-01-22 Thread Zhongqiang Gong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809718#comment-17809718 ] Zhongqiang Gong commented on FLINK-34182: - [~leonard] I'm willing to take this,

[jira] [Created] (FLINK-34204) Dispatch legacy serializer related methods in ExecutionConfig to SerializerConfig

2024-01-22 Thread Weijie Guo (Jira)
Weijie Guo created FLINK-34204: -- Summary: Dispatch legacy serializer related methods in ExecutionConfig to SerializerConfig Key: FLINK-34204 URL: https://issues.apache.org/jira/browse/FLINK-34204 Project

Re: [PR] [FLINK-33668] Decoupling Shuffle network memory and job topology [flink]

2024-01-22 Thread via GitHub
xintongsong commented on code in PR #23851: URL: https://github.com/apache/flink/pull/23851#discussion_r1461707655 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/metrics/CreditBasedInputBuffersUsageGauge.java: ## @@ -28,27 +31,35 @@ */ public class CreditB

Re: [PR] [FLINK-33565][Scheduler] ConcurrentExceptions works with exception merging [flink]

2024-01-22 Thread via GitHub
1996fanrui commented on PR #24003: URL: https://github.com/apache/flink/pull/24003#issuecomment-1905208562 > Fair enough. What about squashing the [FLINK-33565](https://issues.apache.org/jira/browse/FLINK-33565)-related commits into a single one? Hi @XComp , it's fine for me. Let me

Re: [PR] [FLINK-34048][table] Support session window agg in table runtime instead of using legacy group window agg op [flink]

2024-01-22 Thread via GitHub
xuyangzhong commented on code in PR #24150: URL: https://github.com/apache/flink/pull/24150#discussion_r1462666042 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/aggregate/window/processors/UnsliceWindowAggProcessor.java: ## @@ -0,0 +1,

Re: [PR] [FLINK-34143] Modify the effective strategy of `execution.batch.adaptive.auto-parallelism.default-source-parallelism` [flink]

2024-01-22 Thread via GitHub
flinkbot commented on PR #24170: URL: https://github.com/apache/flink/pull/24170#issuecomment-1905196229 ## CI report: * 183c088f87286b2d0234c42a50e1e694ee5a0119 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-34048][table] Support session window agg in table runtime instead of using legacy group window agg op [flink]

2024-01-22 Thread via GitHub
xuyangzhong commented on code in PR #24150: URL: https://github.com/apache/flink/pull/24150#discussion_r1462662596 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/aggregate/window/processors/UnsliceWindowAggProcessor.java: ## @@ -0,0 +1,

Re: [PR] [FLINK-34048][table] Support session window agg in table runtime instead of using legacy group window agg op [flink]

2024-01-22 Thread via GitHub
xuyangzhong commented on code in PR #24150: URL: https://github.com/apache/flink/pull/24150#discussion_r1462661935 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/window/tvf/unslicing/UnslicingTriggerContextBase.java: ## @@ -0,0 +1,163 @

Re: [PR] [FLINK-34048][table] Support session window agg in table runtime instead of using legacy group window agg op [flink]

2024-01-22 Thread via GitHub
xuyangzhong commented on code in PR #24150: URL: https://github.com/apache/flink/pull/24150#discussion_r1462661705 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/aggregate/window/processors/UnsliceWindowAggProcessor.java: ## @@ -0,0 +1,

[jira] [Updated] (FLINK-34143) Modify the effective strategy of `execution.batch.adaptive.auto-parallelism.default-source-parallelism`

2024-01-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34143: --- Labels: pull-request-available (was: ) > Modify the effective strategy of > `execution.bat

[PR] [FLINK-34143] Modify the effective strategy of `execution.batch.adaptive.auto-parallelism.default-source-parallelism` [flink]

2024-01-22 Thread via GitHub
SinBex opened a new pull request, #24170: URL: https://github.com/apache/flink/pull/24170 ## What is the purpose of the change Currently, if users do not set the `execution.batch.adaptive.auto-parallelism.default-source-parallelism` configuration option, the AdaptiveBatchScheduler de

Re: [PR] [FLINK-23687][table-planner] Introduce partitioned lookup join to enforce input of LookupJoin to hash shuffle by lookup keys [flink]

2024-01-22 Thread via GitHub
yunfan123 commented on code in PR #24104: URL: https://github.com/apache/flink/pull/24104#discussion_r1462659082 ## docs/content/docs/dev/table/sql/queries/joins.md: ## @@ -326,6 +326,17 @@ FROM Orders AS o In the example above, the Orders table is enriched with data from the

Re: [PR] [FLINK-33865][runtime] Adding an ITCase to ensure `exponential-delay.attempts-before-reset-backoff` works well [flink]

2024-01-22 Thread via GitHub
qinf commented on code in PR #23942: URL: https://github.com/apache/flink/pull/23942#discussion_r1462656608 ## flink-core/src/main/java/org/apache/flink/configuration/RestartStrategyOptions.java: ## @@ -55,6 +64,54 @@ public class RestartStrategyOptions { @Internal public

[jira] [Updated] (FLINK-34155) Recurring SqlExecutionException

2024-01-22 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang updated FLINK-34155: -- Priority: Major (was: Blocker) > Recurring SqlExecutionException > --

[jira] [Commented] (FLINK-34155) Recurring SqlExecutionException

2024-01-22 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809713#comment-17809713 ] Shengkai Fang commented on FLINK-34155: --- Hi [~jeyhunkarimov].  The exception ment

[jira] [Commented] (FLINK-33365) Missing filter condition in execution plan containing lookup join with mysql jdbc connector

2024-01-22 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809712#comment-17809712 ] Benchao Li commented on FLINK-33365: [~martijnvisser]  The PR is very close to merge

Re: [PR] [FLINK-24024][table-planner] support session window tvf in plan [flink]

2024-01-22 Thread via GitHub
xuyangzhong commented on code in PR #23505: URL: https://github.com/apache/flink/pull/23505#discussion_r1462653816 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/WindowUtil.scala: ## @@ -317,11 +352,17 @@ object WindowUtil { /**

Re: [PR] [FLINK-24024][table-planner] support session window tvf in plan [flink]

2024-01-22 Thread via GitHub
xuyangzhong commented on code in PR #23505: URL: https://github.com/apache/flink/pull/23505#discussion_r1462653012 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/calcite/FlinkConvertletTable.java: ## @@ -88,4 +106,106 @@ private RexNode convertTr

Re: [PR] [FLINK-24024][table-planner] support session window tvf in plan [flink]

2024-01-22 Thread via GitHub
xuyangzhong commented on code in PR #23505: URL: https://github.com/apache/flink/pull/23505#discussion_r1462652354 ## flink-table/flink-table-planner/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java: ## @@ -5335,6 +5364,11 @@ public RexNode convertExpression(SqlNo

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2024-01-22 Thread via GitHub
libenchao commented on PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#issuecomment-1905174734 > @libenchao @snuyanzin I have updated the code in line with your feedback - please could you review again. Many thanks @davidradl One small suggestion, please do not s

[jira] [Updated] (FLINK-34155) Recurring SqlExecutionException

2024-01-22 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang updated FLINK-34155: -- Affects Version/s: 1.19.0 (was: 1.8.0) > Recurring SqlExecutionExce

[jira] [Assigned] (FLINK-33846) Remove outdated versions (need PMC role)

2024-01-22 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qingsheng Ren reassigned FLINK-33846: - Assignee: Qingsheng Ren > Remove outdated versions (need PMC role) > --

[jira] [Commented] (FLINK-33846) Remove outdated versions (need PMC role)

2024-01-22 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809701#comment-17809701 ] Qingsheng Ren commented on FLINK-33846: --- Flink 1.18.0 has been removed from SVN.

[jira] [Updated] (FLINK-34090) Introduce SerializerConfig for serialization

2024-01-22 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-34090: --- Fix Version/s: 1.19.0 > Introduce SerializerConfig for serialization > -

[jira] [Resolved] (FLINK-33846) Remove outdated versions (need PMC role)

2024-01-22 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qingsheng Ren resolved FLINK-33846. --- Fix Version/s: 1.18.1 Resolution: Done > Remove outdated versions (need PMC role) > -

[jira] [Closed] (FLINK-34090) Introduce SerializerConfig for serialization

2024-01-22 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo closed FLINK-34090. -- Resolution: Fixed master(1.19) via 7336788a9c3495745cb4b3eda7bc00d396a14b18. > Introduce SerializerCo

Re: [PR] [FLINK-34090][core] Introduce SerializerConfig [flink]

2024-01-22 Thread via GitHub
reswqa closed pull request #24127: [FLINK-34090][core] Introduce SerializerConfig URL: https://github.com/apache/flink/pull/24127 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] [FLINK-34090][core] Introduce SerializerConfig [flink]

2024-01-22 Thread via GitHub
reswqa commented on PR #24127: URL: https://github.com/apache/flink/pull/24127#issuecomment-1905150931 closed in 7336788a9c3495745cb4b3eda7bc00d396a14b18. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[jira] [Assigned] (FLINK-34196) FLIP-389 Annotate SingleThreadFetcherManager as PublicEvolving.

2024-01-22 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qingsheng Ren reassigned FLINK-34196: - Assignee: Hongshun Wang > FLIP-389 Annotate SingleThreadFetcherManager as PublicEvolvin

Re: [PR] [FLINK-24024][table-planner] support session window tvf in plan [flink]

2024-01-22 Thread via GitHub
xuyangzhong commented on code in PR #23505: URL: https://github.com/apache/flink/pull/23505#discussion_r1462632191 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/metadata/FlinkRelMdWindowProperties.scala: ## @@ -92,13 +93,57 @@ class FlinkR

[jira] [Assigned] (FLINK-27331) Support Avro microsecond precision for TIME

2024-01-22 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu reassigned FLINK-27331: --- Assignee: Peter Huang > Support Avro microsecond precision for TIME > -

Re: [PR] [FLINK-24024][table-planner] support session window tvf in plan [flink]

2024-01-22 Thread via GitHub
xuyangzhong commented on code in PR #23505: URL: https://github.com/apache/flink/pull/23505#discussion_r1462628799 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/WindowUtil.scala: ## @@ -392,4 +433,54 @@ object WindowUtil { }

Re: [PR] [FLINK-24024][table-planner] support session window tvf in plan [flink]

2024-01-22 Thread via GitHub
xuyangzhong commented on code in PR #23505: URL: https://github.com/apache/flink/pull/23505#discussion_r1462628183 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/WindowUtil.scala: ## @@ -234,11 +235,45 @@ object WindowUtil {

Re: [PR] [FLINK-33006] add e2e for Flink operator HA [flink-kubernetes-operator]

2024-01-22 Thread via GitHub
HuangZhenQiu commented on PR #756: URL: https://github.com/apache/flink-kubernetes-operator/pull/756#issuecomment-1905043266 @gyfora After enable HA, there are two operator pods. Takes 2 days to fix the shell scripts step by step. Currently the build is green, please review it at your most

Re: [PR] [FLINK-34111][table] Add JSON_QUOTE and JSON_UNQUOTE function [flink]

2024-01-22 Thread via GitHub
jeyhunkarimov commented on PR #24156: URL: https://github.com/apache/flink/pull/24156#issuecomment-1904869427 Hi @MartijnVisser could you please review the PR in your available time? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2024-01-22 Thread via GitHub
davidradl commented on PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#issuecomment-1904779201 @libenchao @snuyanzin I have updated the code in line with your feedback - please could you review again. Many thanks -- This is an automated message from the Apache Git Ser

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2024-01-22 Thread via GitHub
davidradl commented on code in PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#discussion_r1462396444 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcRowDataLookupFunction.java: ## @@ -63,6 +64,9 @@ public class JdbcRowDataLoo

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2024-01-22 Thread via GitHub
davidradl commented on code in PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#discussion_r1462392709 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcRowDataLookupFunction.java: ## @@ -116,6 +124,15 @@ public void open(Functio

[PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2024-01-22 Thread via GitHub
davidradl opened a new pull request, #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79 Allow lookup joins to honour supplied filters, where the lookup source is JDBC. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2024-01-22 Thread via GitHub
davidradl closed pull request #79: [FLINK-33365] include filters with Lookup joins URL: https://github.com/apache/flink-connector-jdbc/pull/79 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[jira] [Resolved] (FLINK-33824) Prepare Flink 1.18.1 Release

2024-01-22 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Ge resolved FLINK-33824. - Resolution: Fixed > Prepare Flink 1.18.1 Release > > > Key:

[jira] [Updated] (FLINK-34152) Tune memory of autoscaled jobs

2024-01-22 Thread Maximilian Michels (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels updated FLINK-34152: --- Description: The current autoscaling algorithm adjusts the parallelism of the job ta

[jira] [Created] (FLINK-34203) PyFlink `get_field_data_types()` supports only `precision = 3` for `TimestampType`

2024-01-22 Thread Mehmet Aktas (Jira)
Mehmet Aktas created FLINK-34203: Summary: PyFlink `get_field_data_types()` supports only `precision = 3` for `TimestampType` Key: FLINK-34203 URL: https://issues.apache.org/jira/browse/FLINK-34203 Pr

[jira] [Commented] (FLINK-34171) Cannot restore from savepoint when increasing parallelism of operator using reinterpretAsKeyedStream and RichAsyncFunction

2024-01-22 Thread Ken Burford (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809586#comment-17809586 ] Ken Burford commented on FLINK-34171: - It's intermittently reproducible in 1.17.0 wi

[PR] Bump org.apache.derby:derby from 10.10.2.0 to 10.17.1.0 in /flink-connector-hive [flink-connector-hive]

2024-01-22 Thread via GitHub
dependabot[bot] opened a new pull request, #16: URL: https://github.com/apache/flink-connector-hive/pull/16 Bumps org.apache.derby:derby from 10.10.2.0 to 10.17.1.0. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-na

  1   2   3   >