Re: [PR] [FLINK-31192][connectors/dataGen] Fix dataGen takes too long to initi… [flink]

2024-02-25 Thread via GitHub
xuzhiwen1255 commented on PR #22010: URL: https://github.com/apache/flink/pull/22010#issuecomment-1962898978 Hi @XComp I have solved the problem, please check again, thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [FLINK-34504][autoscaler] Avoid the parallelism adjustment when the upstream shuffle type doesn't have keyBy [flink-kubernetes-operator]

2024-02-25 Thread via GitHub
1996fanrui commented on code in PR #783: URL: https://github.com/apache/flink-kubernetes-operator/pull/783#discussion_r1501819614 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingExecutor.java: ## @@ -229,13 +229,14 @@ Map computeScalingSummary(

Re: [PR] [FLINK-34504][autoscaler] Avoid the parallelism adjustment when the upstream shuffle type doesn't have keyBy [flink-kubernetes-operator]

2024-02-25 Thread via GitHub
1996fanrui commented on code in PR #783: URL: https://github.com/apache/flink-kubernetes-operator/pull/783#discussion_r1501819781 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingExecutor.java: ## @@ -229,13 +229,14 @@ Map computeScalingSummary(

[jira] [Commented] (FLINK-34354) Release Testing: Verify FLINK-34037 Improve Serialization Configuration and Usage in Flink

2024-02-25 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17820492#comment-17820492 ] Zakelly Lan commented on FLINK-34354: - Verified by: * Checked all the UTs. * Confi

Re: [PR] [FLINK-33817][flink-protobuf] Set ReadDefaultValues=False by default in proto3 for performance improvement [flink]

2024-02-25 Thread via GitHub
sharath1709 commented on PR #24035: URL: https://github.com/apache/flink/pull/24035#issuecomment-1963020797 > > ## What is the purpose of the change > > **Background** > > The current Protobuf format [implementation](https://github.com/apache/flink/blob/c3e2d163a637dca5f49522721109161b

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-25 Thread via GitHub
z3d1k commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1501895815 ## prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/PrometheusRemoteWriteHttpRequestBuilder.java: ## @@ -0,0 +1,76 @@ +/* + *

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-25 Thread via GitHub
z3d1k commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1501896202 ## prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/PrometheusSinkBuilder.java: ## @@ -0,0 +1,246 @@ +/* + * Licensed to the A

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-25 Thread via GitHub
z3d1k commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1501896859 ## prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/PrometheusRemoteWriteHttpRequestBuilder.java: ## @@ -0,0 +1,76 @@ +/* + *

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-25 Thread via GitHub
z3d1k commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1501897234 ## prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/PrometheusSinkBuilder.java: ## @@ -0,0 +1,246 @@ +/* + * Licensed to the A

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-25 Thread via GitHub
z3d1k commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1501897480 ## prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/PrometheusSinkWriter.java: ## @@ -0,0 +1,189 @@ +/* + * Licensed to the Ap

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-25 Thread via GitHub
z3d1k commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1501897616 ## prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/PrometheusStateSerializer.java: ## @@ -0,0 +1,154 @@ +/* + * Licensed to t

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-25 Thread via GitHub
z3d1k commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1501897657 ## prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/PrometheusStateSerializer.java: ## @@ -0,0 +1,154 @@ +/* + * Licensed to t

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-25 Thread via GitHub
z3d1k commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1501897750 ## prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/PrometheusStateSerializer.java: ## @@ -0,0 +1,154 @@ +/* + * Licensed to t

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-25 Thread via GitHub
z3d1k commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1501898533 ## prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/PrometheusSinkWriter.java: ## @@ -0,0 +1,189 @@ +/* + * Licensed to the Ap

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-25 Thread via GitHub
z3d1k commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1501900305 ## prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/RequestEntrySizeUtils.java: ## @@ -0,0 +1,61 @@ +/* + * Licensed to the Ap

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-25 Thread via GitHub
z3d1k commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1501900684 ## prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/SinkMetrics.java: ## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Softw

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-25 Thread via GitHub
z3d1k commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1501901955 ## prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/http/PrometheusAsyncHttpClientBuilder.java: ## @@ -0,0 +1,92 @@ +/* + * Li

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-25 Thread via GitHub
z3d1k commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1501901973 ## prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/http/PrometheusAsyncHttpClientBuilder.java: ## @@ -0,0 +1,92 @@ +/* + * Li

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-25 Thread via GitHub
z3d1k commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1501902624 ## prometheus-connector/src/test/java/org/apache/flink/connector/prometheus/sink/HttpResponseHandlingBehaviourIT.java: ## @@ -0,0 +1,304 @@ +/* + * License

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-25 Thread via GitHub
z3d1k commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1501903046 ## amp-request-signer/src/main/java/org/apache/flink/connector/prometheus/sink/aws/AWS4SignerBase.java: ## @@ -0,0 +1,288 @@ +/* + * Licensed to the Apache

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-25 Thread via GitHub
z3d1k commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1501903046 ## amp-request-signer/src/main/java/org/apache/flink/connector/prometheus/sink/aws/AWS4SignerBase.java: ## @@ -0,0 +1,288 @@ +/* + * Licensed to the Apache

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-25 Thread via GitHub
z3d1k commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1501903310 ## prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/PrometheusSinkWriter.java: ## @@ -0,0 +1,189 @@ +/* + * Licensed to the Ap

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-25 Thread via GitHub
z3d1k commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1501903943 ## prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/http/RemoteWriteRetryStrategy.java: ## @@ -0,0 +1,106 @@ +/* + * Licensed

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-25 Thread via GitHub
z3d1k commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1501904332 ## prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/http/RemoteWriteRetryStrategy.java: ## @@ -0,0 +1,106 @@ +/* + * Licensed

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-25 Thread via GitHub
z3d1k commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1501904332 ## prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/http/RemoteWriteRetryStrategy.java: ## @@ -0,0 +1,106 @@ +/* + * Licensed

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-25 Thread via GitHub
z3d1k commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1501905509 ## amp-request-signer/src/main/java/org/apache/flink/connector/prometheus/sink/aws/AWS4SignerBase.java: ## @@ -0,0 +1,290 @@ +/* + * Licensed to the Apache

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-25 Thread via GitHub
z3d1k commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1501905941 ## amp-request-signer/pom.xml: ## @@ -0,0 +1,58 @@ + + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-25 Thread via GitHub
z3d1k commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1501906772 ## amp-request-signer/pom.xml: ## @@ -0,0 +1,58 @@ + + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";

Re: [PR] [FLINK-32261][table] Add built-in MAP_UNION function. [flink]

2024-02-25 Thread via GitHub
snuyanzin commented on PR #22842: URL: https://github.com/apache/flink/pull/22842#issuecomment-1963080316 I will try to have a look this week -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] [FLINK-33817][flink-protobuf] Set ReadDefaultValues=False by default in proto3 for performance improvement [flink]

2024-02-25 Thread via GitHub
snuyanzin commented on PR #24035: URL: https://github.com/apache/flink/pull/24035#issuecomment-1963080520 thanks for addressing comments, lgtm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [FLINK-34363] Set artifact version to $project_version if $FLINK_VERSION is not set [flink-connector-shared-utils]

2024-02-25 Thread via GitHub
echauchot commented on code in PR #38: URL: https://github.com/apache/flink-connector-shared-utils/pull/38#discussion_r1499408610 ## _utils.sh: ## @@ -68,4 +68,15 @@ function set_pom_version { new_version=$1 ${MVN} org.codehaus.mojo:versions-maven-plugin:2.8.1:set -Dne

Re: [PR] [FLINK-34362][docs] Add argument to skip integrate connector docs in setup_docs.sh to improve build times [flink]

2024-02-25 Thread via GitHub
swuferhong commented on code in PR #24271: URL: https://github.com/apache/flink/pull/24271#discussion_r1501952578 ## docs/README.md: ## @@ -37,6 +37,14 @@ Then build the docs from source: $ ./build_docs.sh ``` +The shell `./build_docs.sh` will integrate external connector do

Re: [PR] [FLINK-34265][doc] Add the doc of named parameters [flink]

2024-02-25 Thread via GitHub
hackergin commented on PR #24260: URL: https://github.com/apache/flink/pull/24260#issuecomment-1963166090 @xuyangzhong Thank you for reviewing the document. I have updated it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [PR] [FLINK-33784][table] Support Configuring CatalogStoreFactory via StreamExecutionEnvironment [flink]

2024-02-25 Thread via GitHub
hackergin commented on PR #23990: URL: https://github.com/apache/flink/pull/23990#issuecomment-1963168629 @twalthr @fsk119 Please help review when you have time, thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [FLINK-34362][docs] Add argument to skip integrate connector docs in setup_docs.sh to improve build times [flink]

2024-02-25 Thread via GitHub
swuferhong commented on code in PR #24271: URL: https://github.com/apache/flink/pull/24271#discussion_r1501959629 ## docs/setup_docs.sh: ## @@ -36,24 +36,33 @@ function integrate_connector_docs { } +SKIP_INTEGRATE_CONNECTOR_DOCS=false +for arg in "$@"; do + if [ "$arg" ==

Re: [PR] [FLINK-33936][table] Outputting Identical Results in Mini-Batch Aggregation with Set TTL [flink]

2024-02-25 Thread via GitHub
hackergin commented on PR #24290: URL: https://github.com/apache/flink/pull/24290#issuecomment-1963171195 @xuyangzhong @fsk119 Please help review when you have time, thank you. @jeyhunkarimov Do you have any other suggestions for this PR? -- This is an automated message from the

Re: [PR] [FLINK-33936][table] Outputting Identical Results in Mini-Batch Aggregation with Set TTL [flink]

2024-02-25 Thread via GitHub
hackergin commented on PR #24290: URL: https://github.com/apache/flink/pull/24290#issuecomment-1963175680 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-34250] add config docs for formats [flink]

2024-02-25 Thread via GitHub
wuchong commented on PR #24265: URL: https://github.com/apache/flink/pull/24265#issuecomment-1963187767 @leonardBang do you have time to help review this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] [FLINK-34456][configuration]Move all checkpoint-related options into CheckpointingOptions [flink]

2024-02-25 Thread via GitHub
spoon-lz commented on PR #24374: URL: https://github.com/apache/flink/pull/24374#issuecomment-1963202302 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] [Draft][bugfix] Move the deserialization of shuffleDescriptor to a separate … [flink]

2024-02-25 Thread via GitHub
caodizhou commented on PR #24115: URL: https://github.com/apache/flink/pull/24115#issuecomment-1963208307 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-34371][runtime] Support EndOfStreamTrigger and isOutputOnlyAfterEndOfStream operator attribute to optimize task deployment [flink]

2024-02-25 Thread via GitHub
xintongsong commented on code in PR #24272: URL: https://github.com/apache/flink/pull/24272#discussion_r1501806777 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/OperatorAttributesBuilder.java: ## @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache So

Re: [PR] [FLINK-33817][flink-protobuf] Set ReadDefaultValues=False by default in proto3 for performance improvement [flink]

2024-02-25 Thread via GitHub
libenchao commented on PR #24035: URL: https://github.com/apache/flink/pull/24035#issuecomment-1963235399 @maosuhan @snuyanzin Thanks for the review. Since you both have approved the PR, I'm merging now. -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [PR] [FLINK-33668] Decoupling Shuffle network memory and job topology [flink]

2024-02-25 Thread via GitHub
xintongsong commented on code in PR #23851: URL: https://github.com/apache/flink/pull/23851#discussion_r1501757320 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/NetworkBufferPool.java: ## @@ -600,73 +605,138 @@ private void redistributeBuffers() {

Re: [PR] [FLINK-32714] Add dialect for OceanBase database [flink-connector-jdbc]

2024-02-25 Thread via GitHub
whhe commented on PR #72: URL: https://github.com/apache/flink-connector-jdbc/pull/72#issuecomment-1963261767 Hi @MartijnVisser @eskabetxe can we continue the review when you have time? -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [PR] [FLINK-34456][configuration]Move all checkpoint-related options into CheckpointingOptions [flink]

2024-02-25 Thread via GitHub
spoon-lz commented on PR #24374: URL: https://github.com/apache/flink/pull/24374#issuecomment-1963307462 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-33817][flink-protobuf] Set ReadDefaultValues=False by default in proto3 for performance improvement [flink]

2024-02-25 Thread via GitHub
libenchao closed pull request #24035: [FLINK-33817][flink-protobuf] Set ReadDefaultValues=False by default in proto3 for performance improvement URL: https://github.com/apache/flink/pull/24035 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[jira] [Resolved] (FLINK-33817) Allow ReadDefaultValues = False for non primitive types on Proto3

2024-02-25 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benchao Li resolved FLINK-33817. Fix Version/s: 1.20.0 Release Note: Protobuf format now supports set 'protobuf.read-default-v

Re: [PR] [FLINK-34265][doc] Add the doc of named parameters [flink]

2024-02-25 Thread via GitHub
fsk119 merged PR #24260: URL: https://github.com/apache/flink/pull/24260 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

[jira] [Commented] (FLINK-34265) Add the doc of named parameters

2024-02-25 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17820543#comment-17820543 ] Shengkai Fang commented on FLINK-34265: --- Merged into master: 26b1d1bbff590589c72af

[jira] [Commented] (FLINK-34356) Release Testing: Verify FLINK-33768 Support dynamic source parallelism inference for batch jobs

2024-02-25 Thread Junrui Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17820544#comment-17820544 ] Junrui Li commented on FLINK-34356: --- I have conducted tests for both scenarios as inst

[jira] [Commented] (FLINK-34377) Release Testing: Verify FLINK-33297 Support standard YAML for FLINK configuration

2024-02-25 Thread xingbe (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17820549#comment-17820549 ] xingbe commented on FLINK-34377: I'd like to take this ticket. [~zhuzh] Could you help t

Re: [PR] [FLINK-34265][doc] Add the doc of named parameters [flink]

2024-02-25 Thread via GitHub
lincoln-lil commented on PR #24260: URL: https://github.com/apache/flink/pull/24260#issuecomment-1963375230 @hackergin since this is one of the new features for 1.19, could you also create a backport pr to 1.19 branch? -- This is an automated message from the Apache Git Service. To respon

[jira] [Closed] (FLINK-34356) Release Testing: Verify FLINK-33768 Support dynamic source parallelism inference for batch jobs

2024-02-25 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee closed FLINK-34356. --- Resolution: Fixed [~JunRuiLi]Thanks for your testing! > Release Testing: Verify FLINK-33768 Suppor

[jira] [Assigned] (FLINK-34377) Release Testing: Verify FLINK-33297 Support standard YAML for FLINK configuration

2024-02-25 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu reassigned FLINK-34377: --- Assignee: xingbe > Release Testing: Verify FLINK-33297 Support standard YAML for FLINK > configura

Re: [PR] [FLINK-34362][docs] Add argument to skip integrate connector docs in setup_docs.sh to improve build times [flink]

2024-02-25 Thread via GitHub
LadyForest merged PR #24271: URL: https://github.com/apache/flink/pull/24271 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.ap

[jira] [Commented] (FLINK-34362) Add argument to reuse connector docs cache in setup_docs.sh to improve build times

2024-02-25 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17820552#comment-17820552 ] Jane Chan commented on FLINK-34362: --- Fixed in master a95b0fb75b6acc57e8cbde2847f26a1c8

[jira] [Commented] (FLINK-34377) Release Testing: Verify FLINK-33297 Support standard YAML for FLINK configuration

2024-02-25 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17820553#comment-17820553 ] Zhu Zhu commented on FLINK-34377: - Thanks for volunteering! [~xiasun] I have assigned yo

[jira] [Closed] (FLINK-34362) Add argument to reuse connector docs cache in setup_docs.sh to improve build times

2024-02-25 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan closed FLINK-34362. - > Add argument to reuse connector docs cache in setup_docs.sh to improve build > times > --

[jira] [Resolved] (FLINK-34362) Add argument to reuse connector docs cache in setup_docs.sh to improve build times

2024-02-25 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan resolved FLINK-34362. --- Fix Version/s: 1.19.0 Resolution: Fixed > Add argument to reuse connector docs cache in setup

[PR] [FLINK-34495][e2e] Enable incremental checkpoint for stop-with-savepoint tests [flink]

2024-02-25 Thread via GitHub
Zakelly opened a new pull request, #24376: URL: https://github.com/apache/flink/pull/24376 ## What is the purpose of the change Fix the unstable e2e tests related with stop-with-savepoint. See FLINK-34495. ## Brief change log - Enable incremental cp for rocksdb in relate

[jira] [Updated] (FLINK-34495) Resuming Savepoint (rocks, scale up, heap timers) end-to-end test failure due to FileNotFoundException

2024-02-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34495: --- Labels: pull-request-available test-stability (was: test-stability) > Resuming Savepoint (r

[jira] [Commented] (FLINK-34495) Resuming Savepoint (rocks, scale up, heap timers) end-to-end test failure due to FileNotFoundException

2024-02-25 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17820557#comment-17820557 ] Zakelly Lan commented on FLINK-34495: - Well, the exception is shown in the descripti

Re: [PR] [FLINK-34495][e2e] Enable incremental checkpoint for stop-with-savepoint tests [flink]

2024-02-25 Thread via GitHub
flinkbot commented on PR #24376: URL: https://github.com/apache/flink/pull/24376#issuecomment-1963405525 ## CI report: * c3074e59ce13ae44ee24144066f072b7e6fc0762 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Closed] (FLINK-34399) Release Testing: Verify FLINK-33644 Make QueryOperations SQL serializable

2024-02-25 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee closed FLINK-34399. --- Resolution: Fixed [~ferenc-csaky]Thanks for your testing work! > Release Testing: Verify FLINK-3364

[jira] [Updated] (FLINK-34456) Move all checkpoint-related options into CheckpointingOptions

2024-02-25 Thread liuzhuo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liuzhuo updated FLINK-34456: Attachment: (was: image-2024-02-26-14-34-05-555.png) > Move all checkpoint-related options into Checkp

[jira] [Commented] (FLINK-34456) Move all checkpoint-related options into CheckpointingOptions

2024-02-25 Thread liuzhuo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17820566#comment-17820566 ] liuzhuo commented on FLINK-34456: - [~Zakelly] This PR has been submitted, please check i

[jira] [Updated] (FLINK-34456) Move all checkpoint-related options into CheckpointingOptions

2024-02-25 Thread liuzhuo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liuzhuo updated FLINK-34456: Attachment: image-2024-02-26-14-34-05-555.png > Move all checkpoint-related options into CheckpointingOpti

[PR] [BP-1.19][FLINK-34265][doc] Add the doc of named parameters (#24260) [flink]

2024-02-25 Thread via GitHub
hackergin opened a new pull request, #24377: URL: https://github.com/apache/flink/pull/24377 ## What is the purpose of the change *Add doc of named parameters* ## Brief change log - *Add doc of named parameters* ## Verifying this change Add doc , n

Re: [PR] [BP-1.19][FLINK-34265][doc] Add the doc of named parameters (#24260) [flink]

2024-02-25 Thread via GitHub
flinkbot commented on PR #24377: URL: https://github.com/apache/flink/pull/24377#issuecomment-1963432712 ## CI report: * dbfc316e7e2fb136c28bee7564f37c8f8b145810 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Created] (FLINK-34510) Flink 2.0: Rename RestoreMode to RecoveryClaimMode

2024-02-25 Thread Zakelly Lan (Jira)
Zakelly Lan created FLINK-34510: --- Summary: Flink 2.0: Rename RestoreMode to RecoveryClaimMode Key: FLINK-34510 URL: https://issues.apache.org/jira/browse/FLINK-34510 Project: Flink Issue Type:

[jira] [Created] (FLINK-34511) Flink 2.0: Deprecate legacy State&Checkpointing&Recovery options

2024-02-25 Thread Zakelly Lan (Jira)
Zakelly Lan created FLINK-34511: --- Summary: Flink 2.0: Deprecate legacy State&Checkpointing&Recovery options Key: FLINK-34511 URL: https://issues.apache.org/jira/browse/FLINK-34511 Project: Flink

[jira] [Commented] (FLINK-17274) Maven: Premature end of Content-Length delimited message body

2024-02-25 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17820579#comment-17820579 ] Matthias Pohl commented on FLINK-17274: --- https://dev.azure.com/apache-flink/apache

[jira] [Created] (FLINK-34512) Thrown root cause for  HandlerRequestException

2024-02-25 Thread Hangxiang Yu (Jira)
Hangxiang Yu created FLINK-34512: Summary: Thrown root cause for  HandlerRequestException Key: FLINK-34512 URL: https://issues.apache.org/jira/browse/FLINK-34512 Project: Flink Issue Type: Im

[jira] [Commented] (FLINK-18476) PythonEnvUtilsTest#testStartPythonProcess fails

2024-02-25 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17820580#comment-17820580 ] Matthias Pohl commented on FLINK-18476: --- https://dev.azure.com/apache-flink/apache

[PR] [FLINK-34512][rest] Thrown root cause for HandlerRequestException [flink]

2024-02-25 Thread via GitHub
masteryhx opened a new pull request, #24378: URL: https://github.com/apache/flink/pull/24378 ## What is the purpose of the change My Flink job only thrown below exception without the root cause: `org.apache.flink.runtime.rest.handler.HandlerRequestException: Cannot reso

[jira] [Created] (FLINK-34513) GroupAggregateRestoreTest.testRestore fails

2024-02-25 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-34513: - Summary: GroupAggregateRestoreTest.testRestore fails Key: FLINK-34513 URL: https://issues.apache.org/jira/browse/FLINK-34513 Project: Flink Issue Type: Bug

[jira] [Updated] (FLINK-34512) Thrown root cause for  HandlerRequestException

2024-02-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34512: --- Labels: pull-request-available (was: ) > Thrown root cause for  HandlerRequestException > -

[jira] [Commented] (FLINK-34513) GroupAggregateRestoreTest.testRestore fails

2024-02-25 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17820585#comment-17820585 ] Matthias Pohl commented on FLINK-34513: --- [~bvarghese] can you have a look at this?

[jira] [Commented] (FLINK-25442) HBaseConnectorITCase.testTableSink failed on azure

2024-02-25 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17820586#comment-17820586 ] Matthias Pohl commented on FLINK-25442: --- https://dev.azure.com/apache-flink/apache

[jira] [Commented] (FLINK-31472) AsyncSinkWriterThrottlingTest failed with Illegal mailbox thread

2024-02-25 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17820588#comment-17820588 ] Matthias Pohl commented on FLINK-31472: --- https://github.com/apache/flink/actions/r

Re: [PR] [FLINK-34512][rest] Thrown root cause for HandlerRequestException [flink]

2024-02-25 Thread via GitHub
flinkbot commented on PR #24378: URL: https://github.com/apache/flink/pull/24378#issuecomment-1963462456 ## CI report: * e3b6d323db9d2bb1bcd19a83d116a73cce18242a UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-34274) AdaptiveSchedulerTest.testRequirementLowerBoundDecreaseAfterResourceScarcityBelowAvailableSlots times out

2024-02-25 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17820589#comment-17820589 ] Matthias Pohl commented on FLINK-34274: --- https://github.com/apache/flink/actions/r

[jira] [Commented] (FLINK-34361) PyFlink end-to-end test fails in GHA

2024-02-25 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17820594#comment-17820594 ] Matthias Pohl commented on FLINK-34361: --- Looks like it still appears: https://git

[jira] [Created] (FLINK-34514) e2e (1) times out because of an error that's most likely caused by a networking issue

2024-02-25 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-34514: - Summary: e2e (1) times out because of an error that's most likely caused by a networking issue Key: FLINK-34514 URL: https://issues.apache.org/jira/browse/FLINK-34514

[jira] [Updated] (FLINK-34514) e2e (1) times out because of an error that's most likely caused by a networking issue

2024-02-25 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-34514: -- Description: https://github.com/apache/flink/actions/runs/8027473891/job/21931649433 {code} S

[jira] [Commented] (FLINK-34514) e2e (1) times out because of an error that's most likely caused by a networking issue

2024-02-25 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17820599#comment-17820599 ] Matthias Pohl commented on FLINK-34514: --- Similar warning observed (w/o failure):

[jira] [Commented] (FLINK-33186) CheckpointAfterAllTasksFinishedITCase.testRestoreAfterSomeTasksFinished fails on AZP

2024-02-25 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17820600#comment-17820600 ] Matthias Pohl commented on FLINK-33186: --- https://github.com/apache/flink/actions/r

[jira] [Commented] (FLINK-34514) e2e (1) times out because of an error that's most likely caused by a networking issue

2024-02-25 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17820601#comment-17820601 ] Matthias Pohl commented on FLINK-34514: --- https://github.com/apache/flink/actions/r

[jira] [Comment Edited] (FLINK-34514) e2e (1) times out because of an error that's most likely caused by a networking issue

2024-02-25 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17820601#comment-17820601 ] Matthias Pohl edited comment on FLINK-34514 at 2/26/24 7:34 AM: --

[jira] [Commented] (FLINK-24333) StreamArrowPythonGroupWindowAggregateFunctionOperatorTest.testFinishBundleTriggeredOnCheckpoint fails on azure

2024-02-25 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17820602#comment-17820602 ] Matthias Pohl commented on FLINK-24333: --- https://github.com/apache/flink/actions/r

[jira] [Commented] (FLINK-31472) AsyncSinkWriterThrottlingTest failed with Illegal mailbox thread

2024-02-25 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17820603#comment-17820603 ] Matthias Pohl commented on FLINK-31472: --- https://github.com/apache/flink/actions/r

[jira] [Commented] (FLINK-34451) [Kubernetes Operator] Job with restarting TaskManagers uses wrong/misleading fallback approach

2024-02-25 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17820604#comment-17820604 ] Gyula Fora commented on FLINK-34451: I took a closer look at this and it also happen

[jira] [Commented] (FLINK-18476) PythonEnvUtilsTest#testStartPythonProcess fails

2024-02-25 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17820606#comment-17820606 ] Matthias Pohl commented on FLINK-18476: --- https://github.com/apache/flink/actions/r

[jira] [Commented] (FLINK-29114) TableSourceITCase#testTableHintWithLogicalTableScanReuse sometimes fails with result mismatch

2024-02-25 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17820607#comment-17820607 ] Matthias Pohl commented on FLINK-29114: --- * https://github.com/apache/flink/action

[jira] [Comment Edited] (FLINK-29114) TableSourceITCase#testTableHintWithLogicalTableScanReuse sometimes fails with result mismatch

2024-02-25 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17820607#comment-17820607 ] Matthias Pohl edited comment on FLINK-29114 at 2/26/24 7:39 AM: --

[jira] [Commented] (FLINK-29114) TableSourceITCase#testTableHintWithLogicalTableScanReuse sometimes fails with result mismatch

2024-02-25 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17820609#comment-17820609 ] Matthias Pohl commented on FLINK-29114: --- Hi [~qingyue], any updates? Or are you bu

[jira] [Commented] (FLINK-33856) Add metrics to monitor the interaction performance between task and external storage system in the process of checkpoint making

2024-02-25 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17820619#comment-17820619 ] Piotr Nowojski commented on FLINK-33856: Hey [~hejufang001]! The new processes h