[jira] [Commented] (FLINK-30467) Improve the accuracy of estimating the row count of LocalHashAgg to make more two-phase HashAgg operators effective

2024-04-09 Thread Kevin Mingtarja (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835617#comment-17835617 ] Kevin Mingtarja commented on FLINK-30467: - Hi, is this done yet? If not I'm inte

Re: [PR] [FLINK-34690] Cast decimal to VARCHAR as primary key in starrocks sink [flink-cdc]

2024-04-09 Thread via GitHub
loserwang1024 commented on PR #3150: URL: https://github.com/apache/flink-cdc/pull/3150#issuecomment-2046657935 @PatrickRen , CC -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[PR] chore: fix typo [flink-kubernetes-operator]

2024-04-09 Thread via GitHub
drgnchan opened a new pull request, #812: URL: https://github.com/apache/flink-kubernetes-operator/pull/812 ## What is the purpose of the change *(For example: This pull request adds a new feature to periodically create and maintain savepoints through the `FlinkDeployment` cus

[jira] [Updated] (FLINK-35071) Remove dependency on flink-shaded from cdc source connector

2024-04-09 Thread Hongshun Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hongshun Wang updated FLINK-35071: -- Component/s: Flink CDC > Remove dependency on flink-shaded from cdc source connector > ---

[jira] [Updated] (FLINK-35071) Remove dependency on flink-shaded from cdc source connector

2024-04-09 Thread Hongshun Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hongshun Wang updated FLINK-35071: -- Fix Version/s: 3.1.0 > Remove dependency on flink-shaded from cdc source connector > -

[jira] [Updated] (FLINK-35071) Remove dependency on flink-shaded from cdc source connector

2024-04-09 Thread Hongshun Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hongshun Wang updated FLINK-35071: -- Affects Version/s: (was: cdc-3.1.0) > Remove dependency on flink-shaded from cdc source co

[jira] [Updated] (FLINK-35071) Remove dependency on flink-shaded from cdc source connector

2024-04-09 Thread Hongshun Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hongshun Wang updated FLINK-35071: -- Affects Version/s: cdc-3.1.0 > Remove dependency on flink-shaded from cdc source connector > -

[jira] [Updated] (FLINK-35071) Remove dependency on flink-shaded from cdc source connector

2024-04-09 Thread Hongshun Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hongshun Wang updated FLINK-35071: -- Description: Like what flink-connector-aws does in FLINK-32208, the flink cdc source connecto

Re: [PR] [pipeline-connector][paimon] add paimon pipeline data sink connector. [flink-cdc]

2024-04-09 Thread via GitHub
melin commented on PR #2916: URL: https://github.com/apache/flink-cdc/pull/2916#issuecomment-2046629679 Does kafka header set constant values? For example, if data from multiple data centers is written to the same kafka topic, add a region key to the kafka header. -- This is an automate

[jira] [Updated] (FLINK-35071) Remove dependency on flink-shaded from cdc source connector

2024-04-09 Thread Hongshun Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hongshun Wang updated FLINK-35071: -- Description: The flink cdc source connectors depend on flink-shaded-guava. With the externali

[jira] [Commented] (FLINK-35071) Remove dependency on flink-shaded from cdc source connector

2024-04-09 Thread Hongshun Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835612#comment-17835612 ] Hongshun Wang commented on FLINK-35071: --- [~renqs] I would like to do it. > Remove

[jira] [Created] (FLINK-35071) Remove dependency on flink-shaded from cdc source connector

2024-04-09 Thread Hongshun Wang (Jira)
Hongshun Wang created FLINK-35071: - Summary: Remove dependency on flink-shaded from cdc source connector Key: FLINK-35071 URL: https://issues.apache.org/jira/browse/FLINK-35071 Project: Flink

Re: [PR] [FLINK-35060][Test/Connector] Provide compatibility of old CheckpointMode for connector testing framework [flink]

2024-04-09 Thread via GitHub
snuyanzin commented on PR #24636: URL: https://github.com/apache/flink/pull/24636#issuecomment-2046603866 I didn't get this... We already have `@Public` annotation showing that it is used by other projects. It seems the main issue is that ideally there should be check that all existi

[jira] [Commented] (FLINK-34694) Delete num of associations for streaming outer join

2024-04-09 Thread Roman Boyko (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835599#comment-17835599 ] Roman Boyko commented on FLINK-34694: - [~martijnvisser] , could you please help with

Re: [PR] [hotfix][doc] Generate and use docs of RpcOptions instead of AkkaOptions [flink]

2024-04-09 Thread via GitHub
zoltar9264 commented on PR #24629: URL: https://github.com/apache/flink/pull/24629#issuecomment-2046536179 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

Re: [PR] [hotfix][doc] Generate and use docs of RpcOptions instead of AkkaOptions [flink]

2024-04-09 Thread via GitHub
Zakelly commented on PR #24629: URL: https://github.com/apache/flink/pull/24629#issuecomment-2046482349 > Hi @Zakelly , it seems that we should delete the file `docs/layouts/shortcodes/generated/akka_configuration.html` ? Yes, I forgot to delete it manually. Done & pushed. -- This

Re: [PR] [hotfix][doc] Generate and use docs of RpcOptions instead of AkkaOptions [flink]

2024-04-09 Thread via GitHub
zoltar9264 commented on PR #24629: URL: https://github.com/apache/flink/pull/24629#issuecomment-2046468783 Hi @Zakelly , it seems that we should delete the file `docs/layouts/shortcodes/generated/akka_configuration.html` ? -- This is an automated message from the Apache Git Service. To re

[jira] [Commented] (FLINK-35009) Change on getTransitivePredecessors breaks connectors

2024-04-09 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835577#comment-17835577 ] Zhu Zhu commented on FLINK-35009: - [~martijnvisser] Thanks for monitoring the kafka conn

Re: [PR] [FLINK-35062][table] Migrate RewriteMultiJoinConditionRule to java [flink]

2024-04-09 Thread via GitHub
flinkbot commented on PR #24648: URL: https://github.com/apache/flink/pull/24648#issuecomment-2046446805 ## CI report: * 0507bb8bb896a725ce3a2f8f79bdd28eeb628d70 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-35024][Runtime/State] Implement the record buffer of AsyncExecutionController [flink]

2024-04-09 Thread via GitHub
Zakelly commented on code in PR #24633: URL: https://github.com/apache/flink/pull/24633#discussion_r1558754305 ## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/AsyncExecutionController.java: ## @@ -0,0 +1,241 @@ +/* + * Licensed to the Apache Software Foun

Re: [PR] [FLINK-35062][table] Migrate RewriteMultiJoinConditionRule to java [flink]

2024-04-09 Thread via GitHub
liuyongvs commented on PR #24642: URL: https://github.com/apache/flink/pull/24642#issuecomment-2046440061 we can solve it two ways: 1. using scala map in the java code, new pr here https://github.com/apache/flink/pull/24648 ``` scala.collection.mutable.Map> equiJoinFilterMap =

[PR] [FLINK-35062][table] Migrate RewriteMultiJoinConditionRule to java [flink]

2024-04-09 Thread via GitHub
liuyongvs opened a new pull request, #24648: URL: https://github.com/apache/flink/pull/24648 ## What is the purpose of the change A bit reasoning for the change The reason is that since 1.28.0 ( [CALCITE-4787](https://issues.apache.org/jira/browse/CALCITE-4787) - Move core to

Re: [PR] [FLINK-35062][table] Migrate RewriteMultiJoinConditionRule to java [flink]

2024-04-09 Thread via GitHub
liuyongvs commented on PR #24642: URL: https://github.com/apache/flink/pull/24642#issuecomment-2046414515 the reason of ci failed is the scala map hashcode is different with java. make the 'map.value' (to list) order different. -- This is an automated message from the Apache Git Service.

Re: [PR] [FLINK-35066] Fix the unwrap from IterationRecord during keyBy [flink-ml]

2024-04-09 Thread via GitHub
zhipeng93 merged PR #260: URL: https://github.com/apache/flink-ml/pull/260 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

Re: [PR] [FLINK-35060][Test/Connector] Provide compatibility of old CheckpointMode for connector testing framework [flink]

2024-04-09 Thread via GitHub
Zakelly commented on PR #24636: URL: https://github.com/apache/flink/pull/24636#issuecomment-2046391224 > Thanks for the PR. Overall LGTM. I am thinking maybe we should Introduce a new annotation to mark some interfaces or classes used by some other community projects, e.g. all connectors,

[jira] [Comment Edited] (FLINK-35035) Reduce job pause time when cluster resources are expanded in adaptive mode

2024-04-09 Thread yuanfenghu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835564#comment-17835564 ] yuanfenghu edited comment on FLINK-35035 at 4/10/24 2:19 AM: -

[jira] [Resolved] (FLINK-35044) Introduce statebackend-forst module

2024-04-09 Thread Hangxiang Yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hangxiang Yu resolved FLINK-35044. -- Fix Version/s: 1.20.0 Resolution: Fixed merged ee81c79f into master > Introduce stateb

[jira] [Resolved] (FLINK-35043) Release beta version of ForSt

2024-04-09 Thread Hangxiang Yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hangxiang Yu resolved FLINK-35043. -- Resolution: Fixed The beta version could be found in: https://mvnrepository.com/artifact/com.

Re: [PR] [FLINK-35044][state] Init flink-statebackend-forst module [flink]

2024-04-09 Thread via GitHub
masteryhx closed pull request #24631: [FLINK-35044][state] Init flink-statebackend-forst module URL: https://github.com/apache/flink/pull/24631 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] [pipeline-connector][kafka] add kafka pipeline data sink connector. [flink-cdc]

2024-04-09 Thread via GitHub
lvyanquan commented on PR #2938: URL: https://github.com/apache/flink-cdc/pull/2938#issuecomment-2046335007 Rebased to master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[jira] [Comment Edited] (FLINK-35035) Reduce job pause time when cluster resources are expanded in adaptive mode

2024-04-09 Thread yuanfenghu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835564#comment-17835564 ] yuanfenghu edited comment on FLINK-35035 at 4/10/24 2:08 AM: -

[jira] [Commented] (FLINK-35035) Reduce job pause time when cluster resources are expanded in adaptive mode

2024-04-09 Thread yuanfenghu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835564#comment-17835564 ] yuanfenghu commented on FLINK-35035: [~echauchot]  Thank you for your reply, but I h

Re: [PR] [FLINK-28440][State/changelog] Hotfix! Increase the materialization Interval of ChangelogRecoveryITCase#testMaterialization [flink]

2024-04-09 Thread via GitHub
fredia merged PR #24639: URL: https://github.com/apache/flink/pull/24639 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

Re: [PR] [FLINK-34986][Runtime/State] Basic framework of async execution for state [flink]

2024-04-09 Thread via GitHub
masteryhx commented on code in PR #24614: URL: https://github.com/apache/flink/pull/24614#discussion_r1558680967 ## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/StateRequest.java: ## @@ -0,0 +1,99 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[jira] [Comment Edited] (FLINK-34887) Data lost after rename table

2024-04-09 Thread Vallari Rastogi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835541#comment-17835541 ] Vallari Rastogi edited comment on FLINK-34887 at 4/9/24 10:43 PM:

[jira] [Commented] (FLINK-35067) Support metadata 'op_type' virtual column for Postgres CDC Connector.

2024-04-09 Thread Vallari Rastogi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835547#comment-17835547 ] Vallari Rastogi commented on FLINK-35067: - [~renqs] Can I take this up? > Supp

[jira] [Commented] (FLINK-34887) Data lost after rename table

2024-04-09 Thread Vallari Rastogi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835541#comment-17835541 ] Vallari Rastogi commented on FLINK-34887: - I am looking into this. Can someone a

[jira] [Comment Edited] (FLINK-28693) Codegen failed if the watermark is defined on a columnByExpression

2024-04-09 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835457#comment-17835457 ] Sergey Nuyanzin edited comment on FLINK-28693 at 4/9/24 6:02 PM: -

[jira] [Updated] (FLINK-28693) Codegen failed if the watermark is defined on a columnByExpression

2024-04-09 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-28693: Fix Version/s: 1.18.2 > Codegen failed if the watermark is defined on a columnByExpression

Re: [PR] [BP-1.19][FLINK-28693][table] Janino compile failed because of the generated code refers a class in table-planner [flink]

2024-04-09 Thread via GitHub
snuyanzin merged PR #24645: URL: https://github.com/apache/flink/pull/24645 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

Re: [PR] [FLINK-35060][Test/Connector] Provide compatibility of old CheckpointMode for connector testing framework [flink]

2024-04-09 Thread via GitHub
snuyanzin commented on code in PR #24636: URL: https://github.com/apache/flink/pull/24636#discussion_r1558013841 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/CheckpointingMode.java: ## @@ -90,4 +90,16 @@ public static org.apache.flink.core.execution.Chec

Re: [PR] [FLINK-35060][Test/Connector] Provide compatibility of old CheckpointMode for connector testing framework [flink]

2024-04-09 Thread via GitHub
Zakelly commented on code in PR #24636: URL: https://github.com/apache/flink/pull/24636#discussion_r1557986099 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/CheckpointingMode.java: ## @@ -90,4 +90,16 @@ public static org.apache.flink.core.execution.Checkp

Re: [PR] [FLINK-35060][Test/Connector] Provide compatibility of old CheckpointMode for connector testing framework [flink]

2024-04-09 Thread via GitHub
snuyanzin commented on PR #24636: URL: https://github.com/apache/flink/pull/24636#issuecomment-2045626362 yep, you're right, posted thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] [FLINK-35060][Test/Connector] Provide compatibility of old CheckpointMode for connector testing framework [flink]

2024-04-09 Thread via GitHub
snuyanzin commented on code in PR #24636: URL: https://github.com/apache/flink/pull/24636#discussion_r1557974822 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/CheckpointingMode.java: ## @@ -90,4 +90,16 @@ public static org.apache.flink.core.execution.Chec

Re: [PR] [FLINK-35060][Test/Connector] Provide compatibility of old CheckpointMode for connector testing framework [flink]

2024-04-09 Thread via GitHub
Zakelly commented on PR #24636: URL: https://github.com/apache/flink/pull/24636#issuecomment-2045562446 @snuyanzin Thanks for reviewing! And did you forget to post your comment 😄 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[jira] [Closed] (FLINK-35065) Add numFiredTimers and numFiredTimersPerSecond metrics

2024-04-09 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski closed FLINK-35065. -- Resolution: Fixed Merged to master as 98bd2659f5b > Add numFiredTimers and numFiredTimersPerS

Re: [PR] [FLINK-35065][metrics] Add numFiredTimers and numFiredTimersPerSecond [flink]

2024-04-09 Thread via GitHub
pnowojski merged PR #24643: URL: https://github.com/apache/flink/pull/24643 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

Re: [PR] [FLINK-34962] Remove unnecessary call Pulsar API: LookupService.getPrtitionedTopicMetadata [flink-connector-pulsar]

2024-04-09 Thread via GitHub
shibd commented on PR #86: URL: https://github.com/apache/flink-connector-pulsar/pull/86#issuecomment-2045446289 It seems we can't remove `LookupService.getPrtitionedTopicMetadata` directly. Because this test will get stuck: ![image](https://github.com/apache/flink-connector-p

[jira] [Updated] (FLINK-28693) Codegen failed if the watermark is defined on a columnByExpression

2024-04-09 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-28693: Fix Version/s: 1.19.1 > Codegen failed if the watermark is defined on a columnByExpression

[jira] [Commented] (FLINK-28693) Codegen failed if the watermark is defined on a columnByExpression

2024-04-09 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835457#comment-17835457 ] Sergey Nuyanzin commented on FLINK-28693: - 1.18: [f5c62abf7475ea8bc976de2a2079b

Re: [PR] [BP-1.18][FLINK-28693][table] Janino compile failed because of the generated code refers a class in table-planner [flink]

2024-04-09 Thread via GitHub
snuyanzin commented on PR #24646: URL: https://github.com/apache/flink/pull/24646#issuecomment-2045424574 going to merge since it is just a cherry-pick -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] [BP-1.18][FLINK-28693][table] Janino compile failed because of the generated code refers a class in table-planner [flink]

2024-04-09 Thread via GitHub
snuyanzin merged PR #24646: URL: https://github.com/apache/flink/pull/24646 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

Re: [PR] [FLINK-34953][ci] Add github ci for flink-web to auto commit build files [flink-web]

2024-04-09 Thread via GitHub
GOODBOY008 commented on PR #732: URL: https://github.com/apache/flink-web/pull/732#issuecomment-2045410302 The Action result: https://github.com/GOODBOY008/flink-web/commits/asf-site/ ![DEAY~2J7}9_@ZN)225X5FAV](https://github.com/apache/flink-web/assets/13617900/d9e9c993-42b9-4b7c-97c

Re: [PR] [FLINK-34953][ci] Add github ci for flink-web to auto commit build files [flink-web]

2024-04-09 Thread via GitHub
GOODBOY008 commented on PR #732: URL: https://github.com/apache/flink-web/pull/732#issuecomment-2045401191 Hi @MartijnVisser, This repo github action is disabled. Can you help enable github action? -- This is an automated message from the Apache Git Service. To respond to the message, ple

[jira] [Commented] (FLINK-35035) Reduce job pause time when cluster resources are expanded in adaptive mode

2024-04-09 Thread Etienne Chauchot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835434#comment-17835434 ] Etienne Chauchot commented on FLINK-35035: -- FLINK-21883 cooldown period was mai

Re: [PR] [FLINK-34986][Runtime/State] Basic framework of async execution for state [flink]

2024-04-09 Thread via GitHub
jiexray commented on code in PR #24614: URL: https://github.com/apache/flink/pull/24614#discussion_r1557717884 ## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/AsyncExecutionController.java: ## @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Software Foun

[jira] [Updated] (FLINK-34953) Add github ci for flink-web to auto commit build files

2024-04-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34953: --- Labels: pull-request-available website (was: website) > Add github ci for flink-web to auto

[PR] [FLINK-34953][ci] Add github ci for flink-web to auto commit build files [flink-web]

2024-04-09 Thread via GitHub
GOODBOY008 opened a new pull request, #732: URL: https://github.com/apache/flink-web/pull/732 Changes: - Add github ci for flink-web to auto commit build files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [FLINK-34986][Runtime/State] Basic framework of async execution for state [flink]

2024-04-09 Thread via GitHub
Zakelly commented on code in PR #24614: URL: https://github.com/apache/flink/pull/24614#discussion_r1557607902 ## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/AsyncExecutionController.java: ## @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Software Foun

Re: [PR] Flk 1380 [flink-training]

2024-04-09 Thread via GitHub
LaviniaMaria closed pull request #76: Flk 1380 URL: https://github.com/apache/flink-training/pull/76 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: iss

Re: [PR] Flk 1380 [flink-training]

2024-04-09 Thread via GitHub
LaviniaMaria commented on PR #76: URL: https://github.com/apache/flink-training/pull/76#issuecomment-2045146261 by mistake -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] [FLINK-35060][Test/Connector] Provide compatibility of old CheckpointMode for connector testing framework [flink]

2024-04-09 Thread via GitHub
snuyanzin commented on PR #24636: URL: https://github.com/apache/flink/pull/24636#issuecomment-2045133251 yep, I've also faced this issue with elasticsearch connector thanks for working on it LGTM I left a minor comment -- This is an automated message from the Apache Git S

Re: [PR] [FLINK-34986][Runtime/State] Basic framework of async execution for state [flink]

2024-04-09 Thread via GitHub
Zakelly commented on code in PR #24614: URL: https://github.com/apache/flink/pull/24614#discussion_r1557595222 ## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/AsyncExecutionController.java: ## @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Software Foun

[jira] [Comment Edited] (FLINK-35069) ContinuousProcessingTimeTrigger continuously registers timers in a loop at the end of the window

2024-04-09 Thread Jinzhong Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835406#comment-17835406 ] Jinzhong Li edited comment on FLINK-35069 at 4/9/24 12:51 PM:

Re: [PR] [FLINK-35023][tests] Use surefire.module.config in yarn-test [flink]

2024-04-09 Thread via GitHub
RyanSkraba commented on PR #24641: URL: https://github.com/apache/flink/pull/24641#issuecomment-2045111969 > Thanks for the contribution @RyanSkraba > > I would suggest to move the change under `createDefaultConfiguration` method to have setting up of the configuration in one place

[jira] [Commented] (FLINK-35069) ContinuousProcessingTimeTrigger continuously registers timers in a loop at the end of the window

2024-04-09 Thread Jinzhong Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835406#comment-17835406 ] Jinzhong Li commented on FLINK-35069: - cc [~guoweijie]  Could you please take a look

Re: [PR] [FLINK-35069][API/DataStream]ContinuousProcessingTimeTrigger avoids registering timers at the end of the window [flink]

2024-04-09 Thread via GitHub
flinkbot commented on PR #24647: URL: https://github.com/apache/flink/pull/24647#issuecomment-2045101879 ## CI report: * 8e80ff889701ed1abbb5c15cd3943b254f1fb5cc UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-35069) ContinuousProcessingTimeTrigger continuously registers timers in a loop at the end of the window

2024-04-09 Thread Jinzhong Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jinzhong Li updated FLINK-35069: Description: In our production environment,  when TumblingEventTimeWindows and ContinuousProcessi

[jira] [Updated] (FLINK-35069) ContinuousProcessingTimeTrigger continuously registers timers in a loop at the end of the window

2024-04-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35069: --- Labels: pull-request-available (was: ) > ContinuousProcessingTimeTrigger continuously regis

[PR] [FLINK-35069][API/DataStream]ContinuousProcessingTimeTrigger avoids registering timers at the end of the window [flink]

2024-04-09 Thread via GitHub
ljz2051 opened a new pull request, #24647: URL: https://github.com/apache/flink/pull/24647 ## What is the purpose of the change This pull request avoids registering times in a loop at the end of the window for ContinuousProcessingTimeTrigger ## Brief change log -

[jira] [Updated] (FLINK-35069) ContinuousProcessingTimeTrigger continuously registers timers in a loop at the end of the window

2024-04-09 Thread Jinzhong Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jinzhong Li updated FLINK-35069: Affects Version/s: 1.17.0 (was: 1.7.2) > ContinuousProcessingTimeTrigge

Re: [PR] [BP-1.18][FLINK-28693][table] Janino compile failed because of the generated code refers a class in table-planner [flink]

2024-04-09 Thread via GitHub
flinkbot commented on PR #24646: URL: https://github.com/apache/flink/pull/24646#issuecomment-2045082827 ## CI report: * 545df3657631eb38fb72f10fd696f22baac8e254 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-35069) ContinuousProcessingTimeTrigger continuously registers timers in a loop at the end of the window

2024-04-09 Thread Jinzhong Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jinzhong Li updated FLINK-35069: Affects Version/s: 1.7.2 > ContinuousProcessingTimeTrigger continuously registers timers in a loop

Re: [PR] [BP-1.19][FLINK-28693][table] Janino compile failed because of the generated code refers a class in table-planner [flink]

2024-04-09 Thread via GitHub
flinkbot commented on PR #24645: URL: https://github.com/apache/flink/pull/24645#issuecomment-2045082464 ## CI report: * 04e411a0493d4d5829144a9be9b053e0361caafb UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-34549][API] Introduce config, context and processingTimerService for DataStream API V2 [flink]

2024-04-09 Thread via GitHub
reswqa commented on PR #24541: URL: https://github.com/apache/flink/pull/24541#issuecomment-2045077406 I have rebased this on master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (FLINK-35070) remove unused duplicate code

2024-04-09 Thread niliushall (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835398#comment-17835398 ] niliushall commented on FLINK-35070: @[~mapohl], hi~, please have a look at this iss

Re: [PR] [FLINK-34936][Checkpointing] Register reused shared state handle to FileMergingSnapshotManager [flink]

2024-04-09 Thread via GitHub
flinkbot commented on PR #24644: URL: https://github.com/apache/flink/pull/24644#issuecomment-2045072093 ## CI report: * be934f9e818e19f1511933f82034918a68618a29 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-30371) JdbcOutputFormat is at risk of database connection leaks

2024-04-09 Thread Jan Kevin Dick (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835397#comment-17835397 ] Jan Kevin Dick commented on FLINK-30371: Hello [~Echo Lee] [~martijnvisser] any

[PR] [BP-1.18][FLINK-28693][table] Janino compile failed because of the generated code refers a class in table-planner [flink]

2024-04-09 Thread via GitHub
snuyanzin opened a new pull request, #24646: URL: https://github.com/apache/flink/pull/24646 This is a cherry-pick backport of https://github.com/apache/flink/pull/24280 to 1.18 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[PR] [BP-1.19][FLINK-28693][table] Janino compile failed because of the generated code refers a class in table-planner [flink]

2024-04-09 Thread via GitHub
snuyanzin opened a new pull request, #24645: URL: https://github.com/apache/flink/pull/24645 This is a cherry-pick backport of https://github.com/apache/flink/pull/24280 to 1.19 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Created] (FLINK-35070) remove unused duplicate code

2024-04-09 Thread niliushall (Jira)
niliushall created FLINK-35070: -- Summary: remove unused duplicate code Key: FLINK-35070 URL: https://issues.apache.org/jira/browse/FLINK-35070 Project: Flink Issue Type: Improvement Co

Re: [PR] [FLINK-34986][Runtime/State] Basic framework of async execution for state [flink]

2024-04-09 Thread via GitHub
jiexray commented on code in PR #24614: URL: https://github.com/apache/flink/pull/24614#discussion_r1557546908 ## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/AsyncExecutionController.java: ## @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Software Foun

[jira] [Updated] (FLINK-34936) Register reused state handles to FileMergingSnapshotManager

2024-04-09 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zakelly Lan updated FLINK-34936: Summary: Register reused state handles to FileMergingSnapshotManager (was: Register shared state

[jira] [Assigned] (FLINK-34936) Register shared state files to FileMergingSnapshotManager

2024-04-09 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zakelly Lan reassigned FLINK-34936: --- Assignee: Zakelly Lan (was: Jinzhong Li) > Register shared state files to FileMergingSnaps

[jira] [Created] (FLINK-35069) ContinuousProcessingTimeTrigger continuously registers timers in a loop at the end of the window

2024-04-09 Thread Jinzhong Li (Jira)
Jinzhong Li created FLINK-35069: --- Summary: ContinuousProcessingTimeTrigger continuously registers timers in a loop at the end of the window Key: FLINK-35069 URL: https://issues.apache.org/jira/browse/FLINK-35069

[jira] [Commented] (FLINK-34936) Register shared state files to FileMergingSnapshotManager

2024-04-09 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835375#comment-17835375 ] Zakelly Lan commented on FLINK-34936: - Since [~lijinzhong] is kind of busy recently,

[jira] [Updated] (FLINK-34936) Register shared state files to FileMergingSnapshotManager

2024-04-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34936: --- Labels: pull-request-available (was: ) > Register shared state files to FileMergingSnapshot

[PR] [FLINK-34936][Checkpointing] Register reused shared state handle to FileMergingSnapshotManager [flink]

2024-04-09 Thread via GitHub
Zakelly opened a new pull request, #24644: URL: https://github.com/apache/flink/pull/24644 ## What is the purpose of the change This is a sub-task of FLIP-306. The life-cycle maintenance of underlying files in file merging manager needs the info of state handle reusing. This PR provi

Re: [PR] [FLINK-32080][FLIP-306][checkpoint] Restoration of FileMergingSnapshotManager [flink]

2024-04-09 Thread via GitHub
fredia commented on code in PR #24640: URL: https://github.com/apache/flink/pull/24640#discussion_r1557536559 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/FileMergingSnapshotManagerBase.java: ## @@ -547,4 +548,43 @@ private void createManagedDir

Re: [PR] [FLINK-34986][Runtime/State] Basic framework of async execution for state [flink]

2024-04-09 Thread via GitHub
jiexray commented on code in PR #24614: URL: https://github.com/apache/flink/pull/24614#discussion_r1557531709 ## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/AsyncExecutionController.java: ## @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Software Foun

[jira] [Commented] (FLINK-35068) Introduce built-in serialization support for Set

2024-04-09 Thread Zhanghao Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835353#comment-17835353 ] Zhanghao Chen commented on FLINK-35068: --- [~fangyong] May I take this task? > Intr

[jira] [Created] (FLINK-35068) Introduce built-in serialization support for Set

2024-04-09 Thread Zhanghao Chen (Jira)
Zhanghao Chen created FLINK-35068: - Summary: Introduce built-in serialization support for Set Key: FLINK-35068 URL: https://issues.apache.org/jira/browse/FLINK-35068 Project: Flink Issue Type

[jira] [Updated] (FLINK-34123) Introduce built-in serialization support for Map and List

2024-04-09 Thread Zhanghao Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhanghao Chen updated FLINK-34123: -- Fix Version/s: 1.20.0 Affects Version/s: 1.20.0 (was: 1.19.0

Re: [PR] [FLINK-34239][core] Add copy() method for SerializerConfig [flink]

2024-04-09 Thread via GitHub
X-czh commented on PR #24544: URL: https://github.com/apache/flink/pull/24544#issuecomment-2044854644 Pinging @FangYongs and @reswqa. Could you help take a look when you have time? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] [FLINK-35065][metrics] Add numFiredTimers and numFiredTimersPerSecond [flink]

2024-04-09 Thread via GitHub
flinkbot commented on PR #24643: URL: https://github.com/apache/flink/pull/24643#issuecomment-2044842285 ## CI report: * 796f8e4a35e3c583472dadc0b27ea52f812749b2 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-35065) Add numFiredTimers and numFiredTimersPerSecond metrics

2024-04-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35065: --- Labels: pull-request-available (was: ) > Add numFiredTimers and numFiredTimersPerSecond met

[PR] [FLINK-35065][metrics] Add numFiredTimers and numFiredTimersPerSecond [flink]

2024-04-09 Thread via GitHub
pnowojski opened a new pull request, #24643: URL: https://github.com/apache/flink/pull/24643 ## Brief change log This PR adds numFiredTimers and numFiredTimersPerSecond metrics ## Verifying this change - ## Does this pull request potentially affect one of the follo

Re: [PR] [FLINK-35062][table] Migrate RewriteMultiJoinConditionRule to java [flink]

2024-04-09 Thread via GitHub
flinkbot commented on PR #24642: URL: https://github.com/apache/flink/pull/24642#issuecomment-2044794801 ## CI report: * 617267343d1be461104994c10bc4fd43e3018977 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-35062) Migrate RewriteMultiJoinConditionRule

2024-04-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35062: --- Labels: pull-request-available (was: ) > Migrate RewriteMultiJoinConditionRule > --

[PR] [FLINK-35062][table] Migrate RewriteMultiJoinConditionRule to java [flink]

2024-04-09 Thread via GitHub
liuyongvs opened a new pull request, #24642: URL: https://github.com/apache/flink/pull/24642 ## What is the purpose of the change A bit reasoning for the change The reason is that since 1.28.0 ( [CALCITE-4787](https://issues.apache.org/jira/browse/CALCITE-4787) - Move core to

  1   2   >