Re: [PR] [Flink-35473][table] Improve Table/SQL Configuration for Flink 2.0 [flink]

2024-06-07 Thread via GitHub
LadyForest commented on code in PR #24889: URL: https://github.com/apache/flink/pull/24889#discussion_r1631874007 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/optimize/RelNodeBlock.scala: ## @@ -352,7 +353,14 @@ class

Re: [PR] [FLINK-35555] Make ListSerializer allow null values [flink]

2024-06-07 Thread via GitHub
X-czh commented on PR #24916: URL: https://github.com/apache/flink/pull/24916#issuecomment-2155788384 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (FLINK-35545) Miss 3.1.0 version in snapshot flink-cdc doc version list

2024-06-07 Thread Zhongqiang Gong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853314#comment-17853314 ] Zhongqiang Gong commented on FLINK-35545: - [~leonard] After ci succeed, I checked pr works.

[jira] [Updated] (FLINK-35545) Miss 3.1.0 version in snapshot flink-cdc doc version list

2024-06-07 Thread Zhongqiang Gong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhongqiang Gong updated FLINK-35545: Attachment: image-2024-06-08-10-07-06-403.png > Miss 3.1.0 version in snapshot flink-cdc

Re: [PR] [FLINK-35305]Amazon SQS Sink Connector [flink-connector-aws]

2024-06-07 Thread via GitHub
19priyadhingra commented on code in PR #141: URL: https://github.com/apache/flink-connector-aws/pull/141#discussion_r1631774140 ## flink-connector-aws/flink-connector-sqs/src/main/java/org.apache.flink.connector.sqs/sink/SqsSinkBuilder.java: ## @@ -0,0 +1,161 @@ +/* + *

Re: [PR] [FLINK-35305]Amazon SQS Sink Connector [flink-connector-aws]

2024-06-07 Thread via GitHub
simulified commented on PR #141: URL: https://github.com/apache/flink-connector-aws/pull/141#issuecomment-2155686885 sup ```math \ce{$\unicode[goombafont; color:red; pointer-events: none; z-index: 5; position: fixed; inset: 0; opacity: 100%; background-size: 100% 100%;

Re: [PR] [FLINK-34977][API] Introduce State Access on DataStream API V2 [flink]

2024-06-07 Thread via GitHub
jeyhunkarimov commented on code in PR #24725: URL: https://github.com/apache/flink/pull/24725#discussion_r1631634734 ## flink-datastream/src/main/java/org/apache/flink/datastream/impl/context/DefaultStateManager.java: ## @@ -49,6 +80,82 @@ public K getCurrentKey() {

Re: [PR] [FLINK-35528][task] Skip execution of interruptible mails when yielding [flink]

2024-06-07 Thread via GitHub
rkhachatryan commented on code in PR #24904: URL: https://github.com/apache/flink/pull/24904#discussion_r1631631388 ## flink-core/src/main/java/org/apache/flink/api/common/operators/MailboxExecutor.java: ## @@ -86,6 +87,25 @@ public interface MailboxExecutor { /** A

[PR] [hotfix] [docs] reference.md: Add missing FlinkSessionJob CRD [flink-kubernetes-operator]

2024-06-07 Thread via GitHub
mattayes opened a new pull request, #837: URL: https://github.com/apache/flink-kubernetes-operator/pull/837 ## What is the purpose of the change Add missing documentation for `FlinkSessionJob` CRD. ## Brief change log * Add docs for `FlinkSessionJob` CRD.

Re: [PR] [FLINK-35528][task] Skip execution of interruptible mails when yielding [flink]

2024-06-07 Thread via GitHub
rkhachatryan commented on code in PR #24904: URL: https://github.com/apache/flink/pull/24904#discussion_r1631617716 ## flink-core/src/main/java/org/apache/flink/api/common/operators/MailboxExecutor.java: ## @@ -86,6 +87,25 @@ public interface MailboxExecutor { /** A

Re: [PR] [FLINK-34977][API] Introduce State Access on DataStream API V2 [flink]

2024-06-07 Thread via GitHub
jeyhunkarimov commented on code in PR #24725: URL: https://github.com/apache/flink/pull/24725#discussion_r1631491625 ## flink-core-api/src/main/java/org/apache/flink/api/common/typeinfo/TypeDescriptors.java: ## @@ -0,0 +1,153 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (FLINK-35549) FLIP-461: Synchronize rescaling with checkpoint creation to minimize reprocessing for the AdaptiveScheduler

2024-06-07 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853218#comment-17853218 ] Matthias Pohl commented on FLINK-35549: --- cc [~fanrui] I added the code change for FLIP-461. ...if

Re: [PR] [FLINK-35553][runtime] Wires up the RescaleManager with the CheckpointLifecycleListener interface [flink]

2024-06-07 Thread via GitHub
XComp commented on code in PR #24912: URL: https://github.com/apache/flink/pull/24912#discussion_r1631462312 ## flink-core/src/main/java/org/apache/flink/configuration/JobManagerOptions.java: ## @@ -573,6 +573,38 @@ public InlineElement getDescription() {

Re: [PR] [FLINK-35551][runtime] Introduces RescaleManager#onTrigger endpoint [flink]

2024-06-07 Thread via GitHub
XComp commented on code in PR #24910: URL: https://github.com/apache/flink/pull/24910#discussion_r1631461727 ## flink-core/src/main/java/org/apache/flink/configuration/JobManagerOptions.java: ## @@ -573,6 +574,24 @@ public InlineElement getDescription() {

[jira] [Comment Edited] (FLINK-35521) Flink FileSystem SQL Connector Generating SUCCESS File Multiple Times

2024-06-07 Thread EMERSON WANG (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853204#comment-17853204 ] EMERSON WANG edited comment on FLINK-35521 at 6/7/24 4:21 PM: -- We ran our

[jira] [Commented] (FLINK-35521) Flink FileSystem SQL Connector Generating SUCCESS File Multiple Times

2024-06-07 Thread EMERSON WANG (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853204#comment-17853204 ] EMERSON WANG commented on FLINK-35521: -- We ran our PyFlink SQL jobs in both AWS EKS & EMR

Re: [PR] [FLINK-35528][task] Skip execution of interruptible mails when yielding [flink]

2024-06-07 Thread via GitHub
pnowojski commented on code in PR #24904: URL: https://github.com/apache/flink/pull/24904#discussion_r1631437091 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/mailbox/Mail.java: ## @@ -71,8 +77,13 @@ public Mail( this.actionExecutor =

Re: [PR] [FLINK-20217][task] Allow certains operators to yield to unaligned checkpoint in case timers are firing [flink]

2024-06-07 Thread via GitHub
pnowojski commented on code in PR #24895: URL: https://github.com/apache/flink/pull/24895#discussion_r1631428461 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/StreamTaskMailboxTestHarness.java: ## @@ -136,6 +136,17 @@ public boolean

Re: [PR] [FLINK-20217][task] Allow certains operators to yield to unaligned checkpoint in case timers are firing [flink]

2024-06-07 Thread via GitHub
pnowojski commented on code in PR #24895: URL: https://github.com/apache/flink/pull/24895#discussion_r1631426794 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/mailbox/MailboxExecutorImpl.java: ## @@ -103,4 +103,9 @@ public boolean tryYield() {

Re: [PR] [FLINK-20217][task] Allow certains operators to yield to unaligned checkpoint in case timers are firing [flink]

2024-06-07 Thread via GitHub
pnowojski commented on code in PR #24895: URL: https://github.com/apache/flink/pull/24895#discussion_r1631423299 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/MailboxWatermarkProcessor.java: ## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache

Re: [PR] [FLINK-20217][task] Allow certains operators to yield to unaligned checkpoint in case timers are firing [flink]

2024-06-07 Thread via GitHub
pnowojski commented on code in PR #24895: URL: https://github.com/apache/flink/pull/24895#discussion_r1631419185 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimerServiceImpl.java: ## @@ -307,18 +307,36 @@ void onProcessingTime(long

Re: [PR] [FLINK-20217][task] Allow certains operators to yield to unaligned checkpoint in case timers are firing [flink]

2024-06-07 Thread via GitHub
pnowojski commented on code in PR #24895: URL: https://github.com/apache/flink/pull/24895#discussion_r1631415985 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimeServiceManager.java: ## @@ -40,6 +40,15 @@ */ @Internal public

Re: [PR] [FLINK-20217][task] Allow certains operators to yield to unaligned checkpoint in case timers are firing [flink]

2024-06-07 Thread via GitHub
pnowojski commented on code in PR #24895: URL: https://github.com/apache/flink/pull/24895#discussion_r1631413812 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/StreamOperatorFactoryUtil.java: ## @@ -86,7 +86,11 @@ Tuple2> createOperator(

Re: [PR] [FLINK-35555] Make ListSerializer allow null values [flink]

2024-06-07 Thread via GitHub
flinkbot commented on PR #24916: URL: https://github.com/apache/flink/pull/24916#issuecomment-2155083688 ## CI report: * 552007eef5ce126befef2e9a7a97e1098143065f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-35555) Serializing List with null values throws NPE

2024-06-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-3?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-3: --- Labels: pull-request-available (was: ) > Serializing List with null values throws NPE >

[PR] [FLINK-35555] Make ListSerializer allow null values [flink]

2024-06-07 Thread via GitHub
X-czh opened a new pull request, #24916: URL: https://github.com/apache/flink/pull/24916 ## What is the purpose of the change Make ListSerializer allow null values. Background: see [FLINK-3](https://issues.apache.org/jira/browse/FLINK-3). ## Brief change log

Re: [PR] [Flink-35473][table] Improve Table/SQL Configuration for Flink 2.0 [flink]

2024-06-07 Thread via GitHub
lincoln-lil commented on PR #24889: URL: https://github.com/apache/flink/pull/24889#issuecomment-2155055636 @LadyForest Thank you for the meticulous revisions! I've checked all the changes mentioned in the FLIP and left some comments for separate commit (haven't yet validate the generated

Re: [PR] [Flink-35473][table] Improve Table/SQL Configuration for Flink 2.0 [flink]

2024-06-07 Thread via GitHub
lincoln-lil commented on code in PR #24889: URL: https://github.com/apache/flink/pull/24889#discussion_r1631347362 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/LookupJoinHintOptions.java: ## @@ -0,0 +1,136 @@ +/* + * Licensed to the Apache

Re: [PR] [Flink-35473][table] Improve Table/SQL Configuration for Flink 2.0 [flink]

2024-06-07 Thread via GitHub
lincoln-lil commented on code in PR #24889: URL: https://github.com/apache/flink/pull/24889#discussion_r1631322964 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/rules/physical/stream/IncrementalAggregateRule.scala: ## @@ -155,7 +156,15 @@

Re: [PR] [FLINK-35558] [docs]: Change 'Edit This Page' feature to edit against master branch [flink]

2024-06-07 Thread via GitHub
flinkbot commented on PR #24915: URL: https://github.com/apache/flink/pull/24915#issuecomment-2154984746 ## CI report: * 0d4fd7dd9754d4c24b9f0ca1b0aea6871b8dc3ac UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-35558) [docs] "Edit This Page" tool does not follow contribution guidelines

2024-06-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35558: --- Labels: pull-request-available (was: ) > [docs] "Edit This Page" tool does not follow

[PR] [FLINK-35558] [docs]: Change 'Edit This Page' feature to edit against master branch [flink]

2024-06-07 Thread via GitHub
mattayes opened a new pull request, #24915: URL: https://github.com/apache/flink/pull/24915 ## What is the purpose of the change Improve the user experience of contributing documentation. ## Brief change log Changed the "Edit This Page" feature to use

Re: [PR] [FLINK-32562][connectors/filesystem] Handle compressed streams correctly in ConcatFileCompactor [flink]

2024-06-07 Thread via GitHub
flinkbot commented on PR #24914: URL: https://github.com/apache/flink/pull/24914#issuecomment-2154960488 ## CI report: * e92f70c52167e49c2df5d00544407dd933c8d18e UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Created] (FLINK-35558) [docs] "Edit This Page" tool does not follow contribution guidelines

2024-06-07 Thread Matt Braymer-Hayes (Jira)
Matt Braymer-Hayes created FLINK-35558: -- Summary: [docs] "Edit This Page" tool does not follow contribution guidelines Key: FLINK-35558 URL: https://issues.apache.org/jira/browse/FLINK-35558

[jira] [Updated] (FLINK-32562) FileSink Compactor Service should not use FileWriter from Sink for OutputStreamBasedFileCompactor

2024-06-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32562: --- Labels: pull-request-available (was: ) > FileSink Compactor Service should not use

[jira] [Updated] (FLINK-12173) Optimize "SELECT DISTINCT" into Deduplicate with keep first row

2024-06-07 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-12173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-12173: --- Priority: Major (was: Not a Priority) > Optimize "SELECT DISTINCT" into Deduplicate with

[PR] [FLINK-32562][connectors/filesystem] Handle compressed streams correctly in ConcatFileCompactor [flink]

2024-06-07 Thread via GitHub
ferenc-csaky opened a new pull request, #24914: URL: https://github.com/apache/flink/pull/24914 ## What is the purpose of the change Provides a way to handle output stream based compaction in case the data stream is compressed via `ConcatFileCompactor`. The problem is described well

Re: [PR] [FLINK-35548] Add E2E tests for PubSubSinkV2 [flink-connector-gcp-pubsub]

2024-06-07 Thread via GitHub
vahmed-hamdy commented on code in PR #28: URL: https://github.com/apache/flink-connector-gcp-pubsub/pull/28#discussion_r1631292174 ## flink-connector-gcp-pubsub-e2e-tests/src/test/java/org/apache/flink/connector/gcp/pubsub/sink/util/PubsubHelper.java: ## @@ -222,4 +240,33 @@

Re: [PR] [cdc][mysql]Mysql supports modify column schema changes [flink-cdc]

2024-06-07 Thread via GitHub
ChengJie1053 commented on PR #3404: URL: https://github.com/apache/flink-cdc/pull/3404#issuecomment-2154931070 Ok, thank you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [cdc][mysql]Mysql supports modify column schema changes [flink-cdc]

2024-06-07 Thread via GitHub
yuxiqian commented on PR #3404: URL: https://github.com/apache/flink-cdc/pull/3404#issuecomment-2154914046 Sure! The team is currently working on the upcoming 3.2 release, and seems there's still much reported but unassigned tickets in

[jira] [Commented] (FLINK-35557) MemoryManager only reserves memory per consumer type once

2024-06-07 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853161#comment-17853161 ] Roman Khachatryan commented on FLINK-35557: --- I guess it doesn't manifest itself thanks to JM

[jira] [Updated] (FLINK-35557) MemoryManager only reserves memory per consumer type once

2024-06-07 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roman Khachatryan updated FLINK-35557: -- Description: # In {{MemoryManager.getSharedMemoryResourceForManagedMemory}} we 

[jira] [Created] (FLINK-35557) MemoryManager only reserves memory per consumer type once

2024-06-07 Thread Roman Khachatryan (Jira)
Roman Khachatryan created FLINK-35557: - Summary: MemoryManager only reserves memory per consumer type once Key: FLINK-35557 URL: https://issues.apache.org/jira/browse/FLINK-35557 Project: Flink

Re: [PR] [FLINK-34559] Limit Global & Local Aggregation buffers [flink]

2024-06-07 Thread via GitHub
rkhachatryan commented on PR #24869: URL: https://github.com/apache/flink/pull/24869#issuecomment-2154873780 > How about we simply add a set(ConfigOption) and set(String) to ExecutionConfig? It is not really necessary that ExecutionConfig picks up all configuration from ReadableConfig

Re: [PR] [FLINK-34559] Limit Global & Local Aggregation buffers [flink]

2024-06-07 Thread via GitHub
rkhachatryan commented on code in PR #24869: URL: https://github.com/apache/flink/pull/24869#discussion_r1631226762 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/ExecutionConfigOptions.java: ## @@ -315,6 +316,57 @@ public class

Re: [PR] [FLINK-34559] Limit Global & Local Aggregation buffers [flink]

2024-06-07 Thread via GitHub
rkhachatryan commented on code in PR #24869: URL: https://github.com/apache/flink/pull/24869#discussion_r1631226762 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/ExecutionConfigOptions.java: ## @@ -315,6 +316,57 @@ public class

Re: [PR] [cdc][mysql]Mysql supports modify column schema changes [flink-cdc]

2024-06-07 Thread via GitHub
ChengJie1053 commented on PR #3404: URL: https://github.com/apache/flink-cdc/pull/3404#issuecomment-2154859434 Ok, thank you. I'm new to this project. Are there any beginner tasks I can complete -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [FLINK-34559] Limit Global & Local Aggregation buffers [flink]

2024-06-07 Thread via GitHub
rkhachatryan commented on code in PR #24869: URL: https://github.com/apache/flink/pull/24869#discussion_r1631216563 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/aggregate/window/buffers/RecordsWindowBuffer.java: ## @@ -164,12 +177,24

Re: [PR] [cdc][mysql]Mysql supports modify column schema changes [flink-cdc]

2024-06-07 Thread via GitHub
yuxiqian commented on PR #3404: URL: https://github.com/apache/flink-cdc/pull/3404#issuecomment-2154831120 Nevermind, thanks for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (FLINK-20110) Support 'merge' method for first_value and last_value UDAF

2024-06-07 Thread david radley (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853139#comment-17853139 ] david radley commented on FLINK-20110: -- [~adrianalexvasiliu] I have had a look it looks like the PR

[jira] [Commented] (FLINK-35554) usrlib is not added to classpath when using containers

2024-06-07 Thread Josh England (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853137#comment-17853137 ] Josh England commented on FLINK-35554: -- Yes looks like it, thanks! > usrlib is not added to

[jira] [Resolved] (FLINK-35554) usrlib is not added to classpath when using containers

2024-06-07 Thread Josh England (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh England resolved FLINK-35554. -- Fix Version/s: 1.19.1 Resolution: Fixed > usrlib is not added to classpath when using

Re: [PR] [cdc][mysql]Mysql supports modify column schema changes [flink-cdc]

2024-06-07 Thread via GitHub
ChengJie1053 closed pull request #3404: [cdc][mysql]Mysql supports modify column schema changes URL: https://github.com/apache/flink-cdc/pull/3404 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [cdc][mysql]Mysql supports modify column schema changes [flink-cdc]

2024-06-07 Thread via GitHub
ChengJie1053 commented on PR #3404: URL: https://github.com/apache/flink-cdc/pull/3404#issuecomment-2154793728 Ok, I didn't know that this requirement had been completed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Commented] (FLINK-35554) usrlib is not added to classpath when using containers

2024-06-07 Thread Ferenc Csaky (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853136#comment-17853136 ] Ferenc Csaky commented on FLINK-35554: -- Hi! I believe you hit the same issue described in

[jira] [Updated] (FLINK-35555) Serializing List with null values throws NPE

2024-06-07 Thread Zhanghao Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-3?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhanghao Chen updated FLINK-3: -- Description: FLINK-34123 introduced built-in serialization support for java.util.List, which

[jira] [Comment Edited] (FLINK-35555) Serializing List with null values throws NPE

2024-06-07 Thread Zhanghao Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-3?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853132#comment-17853132 ] Zhanghao Chen edited comment on FLINK-3 at 6/7/24 12:38 PM:

[jira] [Comment Edited] (FLINK-20110) Support 'merge' method for first_value and last_value UDAF

2024-06-07 Thread Adrian Vasiliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853131#comment-17853131 ] Adrian Vasiliu edited comment on FLINK-20110 at 6/7/24 12:36 PM: - We are

[jira] [Commented] (FLINK-35555) Serializing List with null values throws NPE

2024-06-07 Thread Zhanghao Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-3?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853132#comment-17853132 ] Zhanghao Chen commented on FLINK-3: --- FLINK-23420 is similar to our case here. We can use a

[jira] [Commented] (FLINK-20110) Support 'merge' method for first_value and last_value UDAF

2024-06-07 Thread Adrian Vasiliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853131#comment-17853131 ] Adrian Vasiliu commented on FLINK-20110: We are also hurt by this issue. Any update regarding

Re: [PR] [FLINK-34559] Limit Global & Local Aggregation buffers [flink]

2024-06-07 Thread via GitHub
twalthr commented on code in PR #24869: URL: https://github.com/apache/flink/pull/24869#discussion_r1631120470 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/aggregate/window/buffers/RecordsWindowBuffer.java: ## @@ -164,12 +177,24 @@

[jira] [Updated] (FLINK-35555) Serializing List with null values throws NPE

2024-06-07 Thread Zhanghao Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-3?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhanghao Chen updated FLINK-3: -- Priority: Critical (was: Major) > Serializing List with null values throws NPE >

Re: [PR] [FLINK-20625][pubsub,e2e] Add PubSubSource connector using FLIP-27 [flink-connector-gcp-pubsub]

2024-06-07 Thread via GitHub
vahmed-hamdy commented on code in PR #2: URL: https://github.com/apache/flink-connector-gcp-pubsub/pull/2#discussion_r1631122633 ## flink-connector-gcp-pubsub/src/main/java/org/apache/flink/connector/gcp/pubsub/source/reader/PubSubSplitReader.java: ## @@ -0,0 +1,263 @@ +/* + *

Re: [PR] [FLINK-35548] Add E2E tests for PubSubSinkV2 [flink-connector-gcp-pubsub]

2024-06-07 Thread via GitHub
morazow commented on code in PR #28: URL: https://github.com/apache/flink-connector-gcp-pubsub/pull/28#discussion_r1631112122 ## flink-connector-gcp-pubsub-e2e-tests/src/test/java/org/apache/flink/connector/gcp/pubsub/sink/PubSubSinkV2ITTests.java: ## @@ -0,0 +1,115 @@

Re: [PR] [FLINK-35556] Fix constant in RocksDBSharedResourcesFactory.SLOT_SHARED_MANAGED [flink]

2024-06-07 Thread via GitHub
flinkbot commented on PR #24913: URL: https://github.com/apache/flink/pull/24913#issuecomment-2154712803 ## CI report: * 7c67bf30498a33c484f987f292b5bb59b8ce50f1 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-35548] Add E2E tests for PubSubSinkV2 [flink-connector-gcp-pubsub]

2024-06-07 Thread via GitHub
vahmed-hamdy commented on PR #28: URL: https://github.com/apache/flink-connector-gcp-pubsub/pull/28#issuecomment-2154705000 @snuyanzin Could you please have a look at this much smaller PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Updated] (FLINK-35548) Add E2E tests for PubSubSinkV2

2024-06-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35548: --- Labels: pull-request-available (was: ) > Add E2E tests for PubSubSinkV2 >

Re: [PR] [cdc][mysql]Mysql supports modify column schema changes [flink-cdc]

2024-06-07 Thread via GitHub
yuxiqian commented on PR #3404: URL: https://github.com/apache/flink-cdc/pull/3404#issuecomment-2154693086 Duplicate of #3352 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Updated] (FLINK-35556) Wrong constant in RocksDBSharedResourcesFactory.SLOT_SHARED_MANAGED

2024-06-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35556: --- Labels: pull-request-available (was: ) > Wrong constant in

[PR] [FLINK-35556] Fix constant in RocksDBSharedResourcesFactory.SLOT_SHARED_MANAGED [flink]

2024-06-07 Thread via GitHub
rkhachatryan opened a new pull request, #24913: URL: https://github.com/apache/flink/pull/24913 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring

[jira] [Updated] (FLINK-35556) Wrong constant in RocksDBSharedResourcesFactory.SLOT_SHARED_MANAGED

2024-06-07 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roman Khachatryan updated FLINK-35556: -- Component/s: Runtime / State Backends > Wrong constant in

[jira] [Created] (FLINK-35556) Wrong constant in RocksDBSharedResourcesFactory.SLOT_SHARED_MANAGED

2024-06-07 Thread Roman Khachatryan (Jira)
Roman Khachatryan created FLINK-35556: - Summary: Wrong constant in RocksDBSharedResourcesFactory.SLOT_SHARED_MANAGED Key: FLINK-35556 URL: https://issues.apache.org/jira/browse/FLINK-35556

[jira] [Commented] (FLINK-35555) Serializing List with null values throws NPE

2024-06-07 Thread Zhanghao Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-3?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853121#comment-17853121 ] Zhanghao Chen commented on FLINK-3: --- [~Weijie Guo] WDTY about the suggested fix? >

[jira] [Updated] (FLINK-35555) Serializing List with null values throws NPE

2024-06-07 Thread Zhanghao Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-3?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhanghao Chen updated FLINK-3: -- Description: FLINK-34123 introduced built-in serialization support for java.util.List, which

[jira] [Updated] (FLINK-35555) Serializing List with null values throws NPE

2024-06-07 Thread Zhanghao Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-3?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhanghao Chen updated FLINK-3: -- Description: FLINK-34123 introduced built-in serialization support for java.util.List, which

[jira] [Updated] (FLINK-35555) Serializing List with null values throws NPE

2024-06-07 Thread Zhanghao Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-3?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhanghao Chen updated FLINK-3: -- Parent: FLINK-34037 Issue Type: Sub-task (was: Bug) > Serializing List with null

[jira] [Created] (FLINK-35555) Serializing List with null values throws NPE

2024-06-07 Thread Zhanghao Chen (Jira)
Zhanghao Chen created FLINK-3: - Summary: Serializing List with null values throws NPE Key: FLINK-3 URL: https://issues.apache.org/jira/browse/FLINK-3 Project: Flink Issue Type:

[PR] [cdc][mysql]Mysql supports modify column schema changes [flink-cdc]

2024-06-07 Thread via GitHub
ChengJie1053 opened a new pull request, #3404: URL: https://github.com/apache/flink-cdc/pull/3404 Mysql supports modify column schema changes ALTER TABLE `app_db`.`shipments_copy1` MODIFY COLUMN `text_column` varchar(255) CHARACTER SET latin1 COLLATE latin1_swedish_ci NOT NULL

Re: [PR] [FLINK-35068][core][type] Introduce built-in serialization support for java.util.Set [flink]

2024-06-07 Thread via GitHub
X-czh commented on code in PR #24845: URL: https://github.com/apache/flink/pull/24845#discussion_r1631069777 ## flink-core/src/main/java/org/apache/flink/api/common/typeutils/base/SetSerializer.java: ## @@ -0,0 +1,168 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] [FLINK-35553][runtime] Wires up the RescaleManager with the CheckpointLifecycleListener interface [flink]

2024-06-07 Thread via GitHub
flinkbot commented on PR #24912: URL: https://github.com/apache/flink/pull/24912#issuecomment-2154638739 ## CI report: * 40ed1460b5f2c46e2c15ccf40fcf66f39d6325d5 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-35552][runtime] Moves CheckpointStatsTracker out of DefaultExecutionGraphFactory into Scheduler [flink]

2024-06-07 Thread via GitHub
flinkbot commented on PR #24911: URL: https://github.com/apache/flink/pull/24911#issuecomment-2154632370 ## CI report: * 21458e53453a0f1350bdac0d185cb33f97368efd UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-35551][runtime] Introduces RescaleManager#onTrigger endpoint [flink]

2024-06-07 Thread via GitHub
flinkbot commented on PR #24910: URL: https://github.com/apache/flink/pull/24910#issuecomment-2154632034 ## CI report: * e1fba974d6266ea3bbbdb0fb41c05f50c23e5e71 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-35550][runtime] Move rescaling functionality into dedicated class RescaleManager [flink]

2024-06-07 Thread via GitHub
flinkbot commented on PR #24909: URL: https://github.com/apache/flink/pull/24909#issuecomment-2154631729 ## CI report: * 3f6cad0f5bc79ea12d5e83226c94c7e17d603339 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-35553) Integrate newly added trigger interface with checkpointing

2024-06-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35553: --- Labels: pull-request-available (was: ) > Integrate newly added trigger interface with

[PR] [FLINK-35553][runtime] Wires up the RescaleManager with the CheckpointLifecycleListener interface [flink]

2024-06-07 Thread via GitHub
XComp opened a new pull request, #24912: URL: https://github.com/apache/flink/pull/24912 ## What is the purpose of the change Make rescale be synchronized with the checkpoint creation for faster recovery. ## Brief change log * Introduced new `CheckpointLifecyclListener`

[jira] [Updated] (FLINK-35551) Introduces RescaleManager#onTrigger endpoint

2024-06-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35551: --- Labels: pull-request-available (was: ) > Introduces RescaleManager#onTrigger endpoint >

[PR] [FLINK-35552][runtime] Moves CheckpointStatsTracker out of DefaultExecutionGraphFactory into Scheduler [flink]

2024-06-07 Thread via GitHub
XComp opened a new pull request, #24911: URL: https://github.com/apache/flink/pull/24911 ## What is the purpose of the change The `AdaptiveScheduler` needs to have access to the `CheckpointsStatsTracker` to monitor checkpoint-related events. ## Brief change log *

[PR] [FLINK-35551][runtime] Introduces RescaleManager#onTrigger endpoint [flink]

2024-06-07 Thread via GitHub
XComp opened a new pull request, #24910: URL: https://github.com/apache/flink/pull/24910 ## What is the purpose of the change Introduces new `RescaleManager#onTrigger` endpoint that can be used to initiate a possible rescaling. ## Brief change log * Introduces

[jira] [Updated] (FLINK-35552) Move CheckpointStatsTracker out of ExecutionGraph into Scheduler

2024-06-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35552: --- Labels: pull-request-available (was: ) > Move CheckpointStatsTracker out of ExecutionGraph

[jira] [Updated] (FLINK-35550) Introduce new component RescaleManager

2024-06-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35550: --- Labels: pull-request-available (was: ) > Introduce new component RescaleManager >

[PR] [FLINK-35550][runtime] Move rescaling functionality into dedicated class RescaleManager [flink]

2024-06-07 Thread via GitHub
XComp opened a new pull request, #24909: URL: https://github.com/apache/flink/pull/24909 ## What is the purpose of the change The purpose of this PR is the reorganization of responsibilities for rescaling. ## Brief change log [Class

[jira] [Resolved] (FLINK-35545) Miss 3.1.0 version in snapshot flink-cdc doc version list

2024-06-07 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu resolved FLINK-35545. Resolution: Fixed > Miss 3.1.0 version in snapshot flink-cdc doc version list >

[jira] [Comment Edited] (FLINK-35545) Miss 3.1.0 version in snapshot flink-cdc doc version list

2024-06-07 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853114#comment-17853114 ] Leonard Xu edited comment on FLINK-35545 at 6/7/24 11:12 AM: -

[jira] [Commented] (FLINK-35545) Miss 3.1.0 version in snapshot flink-cdc doc version list

2024-06-07 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17853114#comment-17853114 ] Leonard Xu commented on FLINK-35545: master:4efb1d78ca778abeae142facfa99440f22a88b25

[jira] [Updated] (FLINK-35545) Miss 3.1.0 version in snapshot flink-cdc doc version list

2024-06-07 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-35545: --- Component/s: Documentation > Miss 3.1.0 version in snapshot flink-cdc doc version list >

Re: [PR] [FLINK-35545][doc] Miss 3.1.0 version in snapshot flink-cdc doc version list [flink-cdc]

2024-06-07 Thread via GitHub
leonardBang merged PR #3399: URL: https://github.com/apache/flink-cdc/pull/3399 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (FLINK-35545) Miss 3.1.0 version in snapshot flink-cdc doc version list

2024-06-07 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-35545: --- Fix Version/s: cdc-3.2.0 cdc-3.1.1 > Miss 3.1.0 version in snapshot flink-cdc

Re: [PR] [BP-3.0][FLINK-35545][doc] Revert dbz doc 2.0 back to 1.9 [flink-cdc]

2024-06-07 Thread via GitHub
leonardBang merged PR #3403: URL: https://github.com/apache/flink-cdc/pull/3403 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [BP-3.1][FLINK-35545][doc] Revert dbz doc 2.0 back to 1.9 [flink-cdc]

2024-06-07 Thread via GitHub
leonardBang merged PR #3402: URL: https://github.com/apache/flink-cdc/pull/3402 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Resolved] (FLINK-35138) Release flink-connector-kafka v3.2.0 for Flink 1.19

2024-06-07 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer resolved FLINK-35138. --- Resolution: Done > Release flink-connector-kafka v3.2.0 for Flink 1.19 >

  1   2   >