Re: [PR] [FLINK-26940][table] Add the built-in function SUBSTRING_INDEX [flink]

2024-08-04 Thread via GitHub
dylanhz commented on code in PR #24972: URL: https://github.com/apache/flink/pull/24972#discussion_r1703604984 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/SubstringIndexFunction.java: ## @@ -0,0 +1,155 @@ +/* + * Licensed to t

Re: [PR] [FLINK-35143][cdc-connector][mysql] Expose newly added tables capture in mysql pipeline connector. [flink-cdc]

2024-08-04 Thread via GitHub
ruanhang1993 commented on PR #3411: URL: https://github.com/apache/flink-cdc/pull/3411#issuecomment-2268266128 @qg-lin Please rebase the master branch and let's pass the CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Resolved] (FLINK-35946) Finalize release 1.20.0

2024-08-04 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo resolved FLINK-35946. Resolution: Done > Finalize release 1.20.0 > --- > > Key: FLIN

[jira] [Resolved] (FLINK-35950) Publish the Dockerfiles for the new release

2024-08-04 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo resolved FLINK-35950. Resolution: Resolved > Publish the Dockerfiles for the new release > -

Re: [PR] [FLINK-35884][mysql-pipeline-connector] MySQL pipeline support snapshot chunk key-column [flink-cdc]

2024-08-04 Thread via GitHub
beryllw commented on PR #3490: URL: https://github.com/apache/flink-cdc/pull/3490#issuecomment-2268212018 @ruanhang1993 PTAL, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Closed] (FLINK-35975) MongoFilterPushDownVisitorTest fails

2024-08-04 Thread Jiabao Sun (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiabao Sun closed FLINK-35975. -- > MongoFilterPushDownVisitorTest fails > > > Key: FLI

[jira] [Comment Edited] (FLINK-32893) Make client.id configurable from KafkaSource

2024-08-04 Thread Rich (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17870914#comment-17870914 ] Rich edited comment on FLINK-32893 at 8/5/24 4:08 AM: -- I would vote

Re: [PR] [FLINK-32893][Connectors/Kafka] Allow the clientid to be fully configurable [flink-connector-kafka]

2024-08-04 Thread via GitHub
jychen7 commented on code in PR #45: URL: https://github.com/apache/flink-connector-kafka/pull/45#discussion_r1703512310 ## flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/KafkaSourceOptions.java: ## @@ -36,6 +36,14 @@ public class KafkaSourceOptions

Re: [PR] [FLINK-26940][table] Add the built-in function SUBSTRING_INDEX [flink]

2024-08-04 Thread via GitHub
dylanhz commented on code in PR #24972: URL: https://github.com/apache/flink/pull/24972#discussion_r1703511359 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/SubstringIndexFunction.java: ## @@ -0,0 +1,155 @@ +/* + * Licensed to t

Re: [PR] 练习: 过滤流(车程清理) [flink-training]

2024-08-04 Thread via GitHub
carpenterworm closed pull request #85: 练习: 过滤流(车程清理) URL: https://github.com/apache/flink-training/pull/85 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

[PR] 练习: 过滤流(车程清理) [flink-training]

2024-08-04 Thread via GitHub
carpenterworm opened a new pull request, #85: URL: https://github.com/apache/flink-training/pull/85 https://github.com/carpenterworm/flink-training/blob/release-1.14/ride-cleansing/README_zh.md -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Comment Edited] (FLINK-28842) Add client.id.prefix for the KafkaSink

2024-08-04 Thread Rich (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17870916#comment-17870916 ] Rich edited comment on FLINK-28842 at 8/5/24 3:57 AM: -- {quote}In ca

Re: [PR] [FLINK-28842][Connector/Kafka] Add client.id.prefix for the KafkaSink [flink]

2024-08-04 Thread via GitHub
jychen7 commented on PR #20475: URL: https://github.com/apache/flink/pull/20475#issuecomment-2268122869 Hi, I am willing to take on this as an alternative PR if no one else volunteers. More on my comment at https://issues.apache.org/jira/browse/FLINK-28842 -- This is an automated message

[jira] [Commented] (FLINK-28842) Add client.id.prefix for the KafkaSink

2024-08-04 Thread Rich (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17870916#comment-17870916 ] Rich commented on FLINK-28842: -- {quote}In case you experience a warning with a stack trace

[jira] [Comment Edited] (FLINK-32893) Make client.id configurable from KafkaSource

2024-08-04 Thread Rich (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17870914#comment-17870914 ] Rich edited comment on FLINK-32893 at 8/5/24 3:47 AM: -- I would vote

[jira] [Updated] (FLINK-35958) Update reference data for Migration Tests

2024-08-04 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-35958: --- Fix Version/s: (was: 1.19.1) > Update reference data for Migration Tests > -

Re: [PR] [FLINK-26940][table] Add the built-in function SUBSTRING_INDEX [flink]

2024-08-04 Thread via GitHub
dylanhz commented on code in PR #24972: URL: https://github.com/apache/flink/pull/24972#discussion_r1703502900 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/SubstringIndexFunction.java: ## @@ -0,0 +1,155 @@ +/* + * Licensed to t

[jira] [Updated] (FLINK-35961) Build 1.20 docs in GitHub Action and mark 1.20 as stable in docs

2024-08-04 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-35961: --- Fix Version/s: 2.0.0 > Build 1.20 docs in GitHub Action and mark 1.20 as stable in docs > --

[jira] [Resolved] (FLINK-35961) Build 1.20 docs in GitHub Action and mark 1.20 as stable in docs

2024-08-04 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo resolved FLINK-35961. Resolution: Done > Build 1.20 docs in GitHub Action and mark 1.20 as stable in docs >

[jira] [Updated] (FLINK-35961) Build 1.20 docs in GitHub Action and mark 1.20 as stable in docs

2024-08-04 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-35961: --- Affects Version/s: 2.0.0 > Build 1.20 docs in GitHub Action and mark 1.20 as stable in docs > --

[jira] [Commented] (FLINK-35961) Build 1.20 docs in GitHub Action and mark 1.20 as stable in docs

2024-08-04 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17870915#comment-17870915 ] Weijie Guo commented on FLINK-35961: master(2.0) via f4aee2a644bfafe733e31a9b67fcc4f

[jira] [Commented] (FLINK-32893) Make client.id configurable from KafkaSource

2024-08-04 Thread Rich (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17870914#comment-17870914 ] Rich commented on FLINK-32893: -- I would vote for supporting a static `client.id` for the Ka

Re: [PR] [FLINK-26940][table] Add the built-in function SUBSTRING_INDEX [flink]

2024-08-04 Thread via GitHub
dylanhz commented on code in PR #24972: URL: https://github.com/apache/flink/pull/24972#discussion_r1703500287 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/SubstringIndexFunction.java: ## @@ -0,0 +1,155 @@ +/* + * Licensed to t

[jira] [Resolved] (FLINK-35975) MongoFilterPushDownVisitorTest fails

2024-08-04 Thread Jiabao Sun (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiabao Sun resolved FLINK-35975. Resolution: Fixed main: 98ada669bef8bf43d7f33dce73d0a7a99ea6fbbe > MongoFilterPushDownVisitorTest

Re: [PR] [FLINK-35975][Connectors/MongoDB][test] Using reflection to resolve RexNodeToExpressionConverter constructor conflicts [flink-connector-mongodb]

2024-08-04 Thread via GitHub
Jiabao-Sun merged PR #38: URL: https://github.com/apache/flink-connector-mongodb/pull/38 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

Re: [PR] [FLINK-35975][Connectors/MongoDB][test] Using reflection to resolve RexNodeToExpressionConverter constructor conflicts [flink-connector-mongodb]

2024-08-04 Thread via GitHub
Jiabao-Sun commented on PR #38: URL: https://github.com/apache/flink-connector-mongodb/pull/38#issuecomment-2268108587 Thanks @whhe for the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] [FLINK-26940][table] Add the built-in function SUBSTRING_INDEX [flink]

2024-08-04 Thread via GitHub
dylanhz commented on code in PR #24972: URL: https://github.com/apache/flink/pull/24972#discussion_r1703496621 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/SubstringIndexFunction.java: ## @@ -0,0 +1,155 @@ +/* + * Licensed to t

[jira] [Updated] (FLINK-35975) MongoFilterPushDownVisitorTest fails

2024-08-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35975: --- Labels: pull-request-available (was: ) > MongoFilterPushDownVisitorTest fails > ---

[PR] [FLINK-35975][Connectors/MongoDB][test] Using reflection to resolve RexNodeToExpressionConverter constructor conflicts [flink-connector-mongodb]

2024-08-04 Thread via GitHub
Jiabao-Sun opened a new pull request, #38: URL: https://github.com/apache/flink-connector-mongodb/pull/38 This problem is similar as https://github.com/apache/flink-connector-jdbc/pull/134 Hi @whhe, can you help take a look? -- This is an automated message from the Apache Git Service.

[jira] [Created] (FLINK-35975) MongoFilterPushDownVisitorTest fails

2024-08-04 Thread Jiabao Sun (Jira)
Jiabao Sun created FLINK-35975: -- Summary: MongoFilterPushDownVisitorTest fails Key: FLINK-35975 URL: https://issues.apache.org/jira/browse/FLINK-35975 Project: Flink Issue Type: Bug Co

Re: [PR] [FLINK-35961][release] Build 1.20 docs in GitHub Action and mark 1.20 as stable in docs [flink]

2024-08-04 Thread via GitHub
reswqa merged PR #25141: URL: https://github.com/apache/flink/pull/25141 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

[jira] [Commented] (FLINK-35974) PyFlink YARN per-job on Docker test failed because docker-compose command not found

2024-08-04 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17870905#comment-17870905 ] Weijie Guo commented on FLINK-35974: https://dev.azure.com/apache-flink/apache-flink

[jira] [Commented] (FLINK-35974) PyFlink YARN per-job on Docker test failed because docker-compose command not found

2024-08-04 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17870908#comment-17870908 ] Weijie Guo commented on FLINK-35974: https://dev.azure.com/apache-flink/apache-flink

[jira] [Commented] (FLINK-35974) PyFlink YARN per-job on Docker test failed because docker-compose command not found

2024-08-04 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17870904#comment-17870904 ] Weijie Guo commented on FLINK-35974: https://dev.azure.com/apache-flink/apache-flink

[jira] [Updated] (FLINK-35974) PyFlink YARN per-job on Docker test failed because docker-compose command not found

2024-08-04 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-35974: --- Description: {code:java} Aug 02 09:20:55 ==

[jira] [Updated] (FLINK-35974) PyFlink YARN per-job on Docker test failed because docker-compose command not found

2024-08-04 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-35974: --- Affects Version/s: 2.0.0 > PyFlink YARN per-job on Docker test failed because docker-compose command

[jira] [Created] (FLINK-35974) PyFlink YARN per-job on Docker test failed because docker-compose command not found

2024-08-04 Thread Weijie Guo (Jira)
Weijie Guo created FLINK-35974: -- Summary: PyFlink YARN per-job on Docker test failed because docker-compose command not found Key: FLINK-35974 URL: https://issues.apache.org/jira/browse/FLINK-35974 Proje

[jira] [Updated] (FLINK-35974) PyFlink YARN per-job on Docker test failed because docker-compose command not found

2024-08-04 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-35974: --- Issue Type: Bug (was: Improvement) > PyFlink YARN per-job on Docker test failed because docker-comp

[jira] [Commented] (FLINK-33555) LocalRecoveryITCase.testRecoverLocallyFromProcessCrashWithWorkingDirectory:

2024-08-04 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17870903#comment-17870903 ] Weijie Guo commented on FLINK-33555: https://dev.azure.com/apache-flink/apache-flink

Re: [PR] [FLINK-34216][connectors/mongodb] FLIP-377: Support fine-grained configuration to control filter push down for MongoDB Connector [flink-connector-mongodb]

2024-08-04 Thread via GitHub
Jiabao-Sun commented on PR #23: URL: https://github.com/apache/flink-connector-mongodb/pull/23#issuecomment-2268071996 Hi @eskabetxe, @RocMarshal, can you help take a look as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] [FLINK-35912] SqlServer CDC doesn't chunk UUID-typed columns correctly [flink-cdc]

2024-08-04 Thread via GitHub
LiPL2017 commented on PR #3497: URL: https://github.com/apache/flink-cdc/pull/3497#issuecomment-2268058794 @GOODBOY008 Could you please review the code again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] [FLINK-26939][table] Add TRANSLATE supported in SQL & Table API [flink]

2024-08-04 Thread via GitHub
dylanhz commented on code in PR #25122: URL: https://github.com/apache/flink/pull/25122#discussion_r1703470383 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/StringFunctionsITCase.java: ## @@ -25,12 +25,17 @@ import static org.apache

[jira] [Commented] (FLINK-33555) LocalRecoveryITCase.testRecoverLocallyFromProcessCrashWithWorkingDirectory:

2024-08-04 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17870895#comment-17870895 ] Weijie Guo commented on FLINK-33555: https://dev.azure.com/apache-flink/apache-flink

[jira] [Commented] (FLINK-33555) LocalRecoveryITCase.testRecoverLocallyFromProcessCrashWithWorkingDirectory:

2024-08-04 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17870896#comment-17870896 ] Weijie Guo commented on FLINK-33555: https://dev.azure.com/apache-flink/apache-flink

[jira] [Commented] (FLINK-35810) AsyncWaitOperatorTest.testProcessingTimeRepeatedCompleteUnorderedWithRetry fails

2024-08-04 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17870894#comment-17870894 ] Weijie Guo commented on FLINK-35810: https://dev.azure.com/apache-flink/apache-flink

[jira] [Created] (FLINK-35973) HeartbeatManagerTest.testHeartbeatTimeout failed

2024-08-04 Thread Weijie Guo (Jira)
Weijie Guo created FLINK-35973: -- Summary: HeartbeatManagerTest.testHeartbeatTimeout failed Key: FLINK-35973 URL: https://issues.apache.org/jira/browse/FLINK-35973 Project: Flink Issue Type: Impr

[jira] [Updated] (FLINK-35973) HeartbeatManagerTest.testHeartbeatTimeout failed

2024-08-04 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-35973: --- Description: Jul 26 03:37:22 java.lang.AssertionError Jul 26 03:37:22 at org.junit.Assert.fa

Re: [PR] [FLINK-34545][cdc-pipeline-connector]Add OceanBase pipeline connector to Flink CDC [flink-cdc]

2024-08-04 Thread via GitHub
yuanoOo commented on PR #3360: URL: https://github.com/apache/flink-cdc/pull/3360#issuecomment-2268010834 @GOODBOY008 Please take a look here. Looking forward to your reply. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [FLINK-35912] SqlServer CDC doesn't chunk UUID-typed columns correctly [flink-cdc]

2024-08-04 Thread via GitHub
LiPL2017 closed pull request #3497: [FLINK-35912] SqlServer CDC doesn't chunk UUID-typed columns correctly URL: https://github.com/apache/flink-cdc/pull/3497 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] [FLINK-35934] Add CompiledPlan annotations to BatchExecValues (#1) [flink]

2024-08-04 Thread via GitHub
jnh5y commented on PR #25150: URL: https://github.com/apache/flink/pull/25150#issuecomment-2267663958 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] [FLINK-35815][Connector/Kinesis] Fix detection of recoverable exceptions for EFO operations [flink-connector-aws]

2024-08-04 Thread via GitHub
z3d1k opened a new pull request, #153: URL: https://github.com/apache/flink-connector-aws/pull/153 ## Purpose of the change Fixing retriable exception check - search both root exception and cause to determine if exception can be retried. ## Verifying this change - *Added

Re: [PR] [FLINK-27355][runtime] Unregister JobManagerRunner after it's closed [flink]

2024-08-04 Thread via GitHub
XComp commented on code in PR #25027: URL: https://github.com/apache/flink/pull/25027#discussion_r1703145088 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/cleanup/LocallyCleanableInMainThreadResource.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache S

[jira] [Created] (FLINK-35972) Directly specify key and process runnable in async state execution model

2024-08-04 Thread Zakelly Lan (Jira)
Zakelly Lan created FLINK-35972: --- Summary: Directly specify key and process runnable in async state execution model Key: FLINK-35972 URL: https://issues.apache.org/jira/browse/FLINK-35972 Project: Flink

Re: [PR] [FLINK-35885][table] Ignore advancing window processor by watermark in window agg based on proctime [flink]

2024-08-04 Thread via GitHub
lincoln-lil commented on code in PR #25119: URL: https://github.com/apache/flink/pull/25119#discussion_r1703254158 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/rank/window/WindowRankOperatorBuilder.java: ## @@ -116,11 +118,17 @@ publi

Re: [PR] [hotfix][doc] Fix typo in checkpointing docs [flink]

2024-08-04 Thread via GitHub
flinkbot commented on PR #25151: URL: https://github.com/apache/flink/pull/25151#issuecomment-2267568103 ## CI report: * f4fd7387859c9f03594476e41a04c313d1f0c29b UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [hotfix][doc] Fix typo in checkpointing docs [flink]

2024-08-04 Thread via GitHub
Zakelly opened a new pull request, #25151: URL: https://github.com/apache/flink/pull/25151 Typo here: https://nightlies.apache.org/flink/flink-docs-release-1.19/docs/dev/datastream/fault-tolerance/checkpointing/#related-config-options ![image](https://github.com/user-attachmen

Re: [PR] [FLINK-26940][Table SQL / API] Add SUBSTRING_INDEX supported in SQL & Table API [flink]

2024-08-04 Thread via GitHub
lsyldliu commented on code in PR #24972: URL: https://github.com/apache/flink/pull/24972#discussion_r1703139469 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/SubstringIndexFunction.java: ## @@ -0,0 +1,155 @@ +/* + * Licensed to

Re: [PR] [FLINK-35910][table] Add BTRIM function [flink]

2024-08-04 Thread via GitHub
lsyldliu commented on PR #25127: URL: https://github.com/apache/flink/pull/25127#issuecomment-2267459967 @dylanhz Can you help resolve the conflict and rebase the master branch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [FLINK-35910][table] Add BTRIM function [flink]

2024-08-04 Thread via GitHub
lsyldliu commented on code in PR #25127: URL: https://github.com/apache/flink/pull/25127#discussion_r1703130983 ## flink-python/pyflink/table/expression.py: ## @@ -1315,6 +1315,16 @@ def rtrim(self) -> 'Expression[str]': """ return _unary_op("rtrim")(self) +

[jira] [Assigned] (FLINK-35910) Add BTRIM function

2024-08-04 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dalongliu reassigned FLINK-35910: - Assignee: Dylan He > Add BTRIM function > -- > > Key: FLINK-359