Re: [PR] [hotfix] [API/DataStream]: Ensure the proper triggering functionality of ContinuousProcessingTimeTrigger [flink]

2025-05-07 Thread via GitHub
github-actions[bot] commented on PR #25205: URL: https://github.com/apache/flink/pull/25205#issuecomment-2861919485 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel fre

Re: [PR] [hotfix][doc] MT download link to filesystem-test-utils jar [flink]

2025-05-07 Thread via GitHub
github-actions[bot] commented on PR #25315: URL: https://github.com/apache/flink/pull/25315#issuecomment-2861920309 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel fre

Re: [PR] [FLINK-26944][table] Add the built-in function ADD_MONTHS [flink]

2025-05-07 Thread via GitHub
github-actions[bot] commented on PR #25252: URL: https://github.com/apache/flink/pull/25252#issuecomment-2861919890 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel fre

Re: [PR] [FLINK-33977][runtime] Adaptive scheduler may not minimize the number of TMs during downscaling [flink]

2025-05-07 Thread via GitHub
RocMarshal commented on PR #25218: URL: https://github.com/apache/flink/pull/25218#issuecomment-2861952838 pending in review & subsequent actions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [hotfix][docs] Fix typo in Hive connector overview Python example [flink]

2025-05-07 Thread via GitHub
github-actions[bot] closed pull request #25354: [hotfix][docs] Fix typo in Hive connector overview Python example URL: https://github.com/apache/flink/pull/25354 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] [FLINK-36399][table] Fix incorrect cast behavior. [flink]

2025-05-07 Thread via GitHub
github-actions[bot] commented on PR #25418: URL: https://github.com/apache/flink/pull/25418#issuecomment-2861920565 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel fre

[jira] [Commented] (FLINK-37747) GlobalCommitterOperator cannot commit after scaling writer/committer

2025-05-07 Thread Arvid Heise (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17950198#comment-17950198 ] Arvid Heise commented on FLINK-37747: - [~david2025] I just merged your PR. Can you p

[jira] [Resolved] (FLINK-37747) GlobalCommitterOperator cannot commit after scaling writer/committer

2025-05-07 Thread Arvid Heise (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arvid Heise resolved FLINK-37747. - Fix Version/s: 2.1.0 Release Note: Fixed global committer not proceeding during upscaling r

Re: [PR] Update canal.md [flink]

2025-05-07 Thread via GitHub
github-actions[bot] commented on PR #25330: URL: https://github.com/apache/flink/pull/25330#issuecomment-2861920375 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel fre

Re: [PR] [FLINK-36244] Remove queryable state [flink]

2025-05-07 Thread via GitHub
github-actions[bot] closed pull request #25303: [FLINK-36244] Remove queryable state URL: https://github.com/apache/flink/pull/25303 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] Detect base href dynamically [flink]

2025-05-07 Thread via GitHub
github-actions[bot] commented on PR #25411: URL: https://github.com/apache/flink/pull/25411#issuecomment-2861920497 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel fre

Re: [PR] Detect base href dynamically [flink]

2025-05-07 Thread via GitHub
github-actions[bot] closed pull request #25411: Detect base href dynamically URL: https://github.com/apache/flink/pull/25411 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Update state_backends.md [flink]

2025-05-07 Thread via GitHub
github-actions[bot] closed pull request #25271: Update state_backends.md URL: https://github.com/apache/flink/pull/25271 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [hotfix][doc] MT download link to filesystem-test-utils jar [flink]

2025-05-07 Thread via GitHub
github-actions[bot] closed pull request #25315: [hotfix][doc] MT download link to filesystem-test-utils jar URL: https://github.com/apache/flink/pull/25315 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [hotfix][docs] Fix typo in Hive connector overview Python example [flink]

2025-05-07 Thread via GitHub
github-actions[bot] commented on PR #25354: URL: https://github.com/apache/flink/pull/25354#issuecomment-2861920441 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel fre

Re: [PR] Update canal.md [flink]

2025-05-07 Thread via GitHub
github-actions[bot] closed pull request #25330: Update canal.md URL: https://github.com/apache/flink/pull/25330 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] Update state_backends.md [flink]

2025-05-07 Thread via GitHub
github-actions[bot] commented on PR #25271: URL: https://github.com/apache/flink/pull/25271#issuecomment-2861920097 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel fre

Re: [PR] [FLINK-36154][formats] Support deserialize json ignore key case [flink]

2025-05-07 Thread via GitHub
github-actions[bot] closed pull request #25255: [FLINK-36154][formats] Support deserialize json ignore key case URL: https://github.com/apache/flink/pull/25255 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [FLINK-35850][table] Add the built-in function DATEDIFF [flink]

2025-05-07 Thread via GitHub
github-actions[bot] commented on PR #25254: URL: https://github.com/apache/flink/pull/25254#issuecomment-2861919962 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel fre

Re: [PR] [FLINK-36090][Runtime / State Backends] Fix bug with IngestDB restore operation for priority queue state in backend. [flink]

2025-05-07 Thread via GitHub
github-actions[bot] commented on PR #25215: URL: https://github.com/apache/flink/pull/25215#issuecomment-2861919643 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel fre

Re: [PR] [FLINK-37747][runtime] Use old subtask count for restored committable objects [flink]

2025-05-07 Thread via GitHub
AHeise merged PR #26518: URL: https://github.com/apache/flink/pull/26518 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

Re: [PR] [FLINK-36152] Fix incorrect type extraction in case of cascaded inheritance when DataTypeHint is not configured [flink]

2025-05-07 Thread via GitHub
github-actions[bot] commented on PR #25251: URL: https://github.com/apache/flink/pull/25251#issuecomment-2861919829 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel fre

Re: [PR] [FLINK-36025][table] Add the built-in function TO_NUMBER [flink]

2025-05-07 Thread via GitHub
github-actions[bot] closed pull request #25216: [FLINK-36025][table] Add the built-in function TO_NUMBER URL: https://github.com/apache/flink/pull/25216 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [FLINK-36025][table] Add the built-in function TO_NUMBER [flink]

2025-05-07 Thread via GitHub
github-actions[bot] commented on PR #25216: URL: https://github.com/apache/flink/pull/25216#issuecomment-2861919708 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel fre

Re: [PR] [FLINK-36090][Runtime / State Backends] Fix bug with IngestDB restore operation for priority queue state in backend. [flink]

2025-05-07 Thread via GitHub
github-actions[bot] closed pull request #25215: [FLINK-36090][Runtime / State Backends] Fix bug with IngestDB restore operation for priority queue state in backend. URL: https://github.com/apache/flink/pull/25215 -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [FLINK-26081][docs] Update flink build document with maven wrapper [flink]

2025-05-07 Thread via GitHub
github-actions[bot] closed pull request #25212: [FLINK-26081][docs] Update flink build document with maven wrapper URL: https://github.com/apache/flink/pull/25212 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] [hotfix] [API/DataStream]: Ensure the proper triggering functionality of ContinuousProcessingTimeTrigger [flink]

2025-05-07 Thread via GitHub
github-actions[bot] closed pull request #25205: [hotfix] [API/DataStream]: Ensure the proper triggering functionality of ContinuousProcessingTimeTrigger URL: https://github.com/apache/flink/pull/25205 -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [PR] [FLINK-36046] Change the existing org.apache.flink.streaming.api.functions.sink#DiscardingSink and org.apache.flink.streaming.api.functions.sink#PrintSinkFunction to use the new interfaces [f

2025-05-07 Thread via GitHub
github-actions[bot] closed pull request #25199: [FLINK-36046] Change the existing org.apache.flink.streaming.api.functions.sink#DiscardingSink and org.apache.flink.streaming.api.functions.sink#PrintSinkFunction to use the new interfaces URL: https://github.com/apache/flink/pull/25199 -- Thi

Re: [PR] [FLINK-35202][table] Support the execution of alter materialized table set freshness [flink]

2025-05-07 Thread via GitHub
github-actions[bot] closed pull request #25437: [FLINK-35202][table] Support the execution of alter materialized table set freshness URL: https://github.com/apache/flink/pull/25437 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [FLINK-36399][table] Fix incorrect cast behavior. [flink]

2025-05-07 Thread via GitHub
github-actions[bot] closed pull request #25418: [FLINK-36399][table] Fix incorrect cast behavior. URL: https://github.com/apache/flink/pull/25418 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [FLINK-35202][table] Support the execution of alter materialized table set freshness [flink]

2025-05-07 Thread via GitHub
github-actions[bot] commented on PR #25437: URL: https://github.com/apache/flink/pull/25437#issuecomment-2861920630 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel fre

Re: [PR] [FLINK-36154][formats] Support deserialize json ignore key case [flink]

2025-05-07 Thread via GitHub
github-actions[bot] commented on PR #25255: URL: https://github.com/apache/flink/pull/25255#issuecomment-2861920026 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel fre

Re: [PR] [FLINK-36244] Remove queryable state [flink]

2025-05-07 Thread via GitHub
github-actions[bot] commented on PR #25303: URL: https://github.com/apache/flink/pull/25303#issuecomment-2861920231 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel fre

Re: [PR] Update datastream_api with latest API [flink]

2025-05-07 Thread via GitHub
github-actions[bot] closed pull request #25273: Update datastream_api with latest API URL: https://github.com/apache/flink/pull/25273 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] Update datastream_api with latest API [flink]

2025-05-07 Thread via GitHub
github-actions[bot] commented on PR #25273: URL: https://github.com/apache/flink/pull/25273#issuecomment-2861920176 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel fre

Re: [PR] [FLINK-35850][table] Add the built-in function DATEDIFF [flink]

2025-05-07 Thread via GitHub
github-actions[bot] closed pull request #25254: [FLINK-35850][table] Add the built-in function DATEDIFF URL: https://github.com/apache/flink/pull/25254 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] [FLINK-26944][table] Add the built-in function ADD_MONTHS [flink]

2025-05-07 Thread via GitHub
github-actions[bot] closed pull request #25252: [FLINK-26944][table] Add the built-in function ADD_MONTHS URL: https://github.com/apache/flink/pull/25252 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [FLINK-36152] Fix incorrect type extraction in case of cascaded inheritance when DataTypeHint is not configured [flink]

2025-05-07 Thread via GitHub
github-actions[bot] closed pull request #25251: [FLINK-36152] Fix incorrect type extraction in case of cascaded inheritance when DataTypeHint is not configured URL: https://github.com/apache/flink/pull/25251 -- This is an automated message from the Apache Git Service. To respond to the messa

Re: [PR] [FLINK-33977][runtime] Adaptive scheduler may not minimize the number of TMs during downscaling [flink]

2025-05-07 Thread via GitHub
github-actions[bot] commented on PR #25218: URL: https://github.com/apache/flink/pull/25218#issuecomment-2861919774 This PR is being marked as stale since it has not had any activity in the last 90 days. If you would like to keep this PR alive, please leave a comment asking for a review

Re: [PR] [FLINK-26081][docs] Update flink build document with maven wrapper [flink]

2025-05-07 Thread via GitHub
github-actions[bot] commented on PR #25212: URL: https://github.com/apache/flink/pull/25212#issuecomment-2861919587 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel fre

Re: [PR] [hotfix][docs] Fix typo in hive_read_write.md [flink]

2025-05-07 Thread via GitHub
github-actions[bot] closed pull request #25210: [hotfix][docs] Fix typo in hive_read_write.md URL: https://github.com/apache/flink/pull/25210 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] [hotfix][docs] Fix typo in hive_read_write.md [flink]

2025-05-07 Thread via GitHub
github-actions[bot] commented on PR #25210: URL: https://github.com/apache/flink/pull/25210#issuecomment-2861919529 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel fre

Re: [PR] [FLINK-36046] Change the existing org.apache.flink.streaming.api.functions.sink#DiscardingSink and org.apache.flink.streaming.api.functions.sink#PrintSinkFunction to use the new interfaces [f

2025-05-07 Thread via GitHub
github-actions[bot] commented on PR #25199: URL: https://github.com/apache/flink/pull/25199#issuecomment-2861919418 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel fre

Re: [PR] [FLINK-36045][flink connector formats]Add support for SharePlex JSON format [flink]

2025-05-07 Thread via GitHub
github-actions[bot] closed pull request #25198: [FLINK-36045][flink connector formats]Add support for SharePlex JSON format URL: https://github.com/apache/flink/pull/25198 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] [FLINK-36045][flink connector formats]Add support for SharePlex JSON format [flink]

2025-05-07 Thread via GitHub
github-actions[bot] commented on PR #25198: URL: https://github.com/apache/flink/pull/25198#issuecomment-2861919356 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel fre

Re: [PR] [FLINK-37676][cdc-common] Add caching mechanism to Selectors for improved performance [flink-cdc]

2025-05-07 Thread via GitHub
yuxiqian commented on code in PR #3994: URL: https://github.com/apache/flink-cdc/pull/3994#discussion_r2078949621 ## flink-cdc-common/src/main/java/org/apache/flink/cdc/common/schema/Selectors.java: ## @@ -71,8 +83,20 @@ public boolean isMatch(TableId tableId) { }

Re: [PR] [FLINK-37676][cdc-common] Add caching mechanism to Selectors for improved performance [flink-cdc]

2025-05-07 Thread via GitHub
yuxiqian commented on code in PR #3994: URL: https://github.com/apache/flink-cdc/pull/3994#discussion_r2078942442 ## flink-cdc-common/src/main/java/org/apache/flink/cdc/common/schema/Selectors.java: ## @@ -29,8 +33,16 @@ /** Selectors for filtering tables. */ public class Sele

Re: [PR] [FLINK-37676][cdc-common] Add caching mechanism to Selectors for improved performance [flink-cdc]

2025-05-07 Thread via GitHub
yuxiqian commented on code in PR #3994: URL: https://github.com/apache/flink-cdc/pull/3994#discussion_r2078940346 ## flink-cdc-common/src/main/java/org/apache/flink/cdc/common/schema/Selectors.java: ## @@ -29,8 +33,16 @@ /** Selectors for filtering tables. */ public class Sele

Re: [PR] [FLINK-37676][cdc-common] Add caching mechanism to Selectors for improved performance [flink-cdc]

2025-05-07 Thread via GitHub
yuxiqian commented on code in PR #3994: URL: https://github.com/apache/flink-cdc/pull/3994#discussion_r2078940346 ## flink-cdc-common/src/main/java/org/apache/flink/cdc/common/schema/Selectors.java: ## @@ -29,8 +33,16 @@ /** Selectors for filtering tables. */ public class Sele

[jira] [Closed] (FLINK-37760) Bump parquet version to 1.15.2

2025-05-07 Thread Ferenc Csaky (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ferenc Csaky closed FLINK-37760. Fix Version/s: 1.19.3 1.20.2 2.1.0 2.0.1

Re: [PR] [BP-1.20][FLINK-37760][format] Bump parquet from 1.15.1 to 1.15.2 [flink]

2025-05-07 Thread via GitHub
ferenc-csaky merged PR #26536: URL: https://github.com/apache/flink/pull/26536 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.

Re: [PR] [BP-1.19][FLINK-37760][format] Bump parquet from 1.15.1 to 1.15.2 [flink]

2025-05-07 Thread via GitHub
ferenc-csaky merged PR #26537: URL: https://github.com/apache/flink/pull/26537 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.

Re: [PR] [BP-2.0][FLINK-37760][format] Bump parquet from 1.15.1 to 1.15.2 [flink]

2025-05-07 Thread via GitHub
ferenc-csaky merged PR #26535: URL: https://github.com/apache/flink/pull/26535 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.

Re: [PR] [FLINK-37347][DOCS] Support any column as chunk key column (postgres, orcale, db2, sqlserver) [flink-cdc]

2025-05-07 Thread via GitHub
gtk96 commented on PR #3924: URL: https://github.com/apache/flink-cdc/pull/3924#issuecomment-2861574767 @leonardBang @lvyanquan PTAL The relevant code has been merged, and the corresponding documents should be merged in time -- This is an automated message from the Apache Git Service. To

[jira] [Commented] (FLINK-37747) GlobalCommitterOperator cannot commit after scaling writer/committer

2025-05-07 Thread David (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17950147#comment-17950147 ] David commented on FLINK-37747: --- Thanks [~arvid] for the review! Updated the PR :)  > Glo

Re: [PR] [FLINK-37515] Basic support for Blue/Green deployments [flink-kubernetes-operator]

2025-05-07 Thread via GitHub
gyfora commented on code in PR #969: URL: https://github.com/apache/flink-kubernetes-operator/pull/969#discussion_r2077413364 ## flink-kubernetes-operator-api/src/main/java/org/apache/flink/kubernetes/operator/api/bluegreen/DeploymentType.java: ## @@ -0,0 +1,38 @@ +/* + * Licen

Re: [PR] [BP-1.19][FLINK-37760][format] Bump parquet from 1.15.1 to 1.15.2 [flink]

2025-05-07 Thread via GitHub
ferenc-csaky commented on PR #26537: URL: https://github.com/apache/flink/pull/26537#issuecomment-2859908553 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] [FLINK-35019] support convert show create model sql to operation [flink]

2025-05-07 Thread via GitHub
lihaosky commented on code in PR #26528: URL: https://github.com/apache/flink/pull/26528#discussion_r2078311124 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/api/TableEnvironmentTest.scala: ## @@ -2957,6 +2957,177 @@ class TableEnvironmentTest { c

Re: [PR] [BP-1.20][FLINK-37760][format] Bump parquet from 1.15.1 to 1.15.2 [flink]

2025-05-07 Thread via GitHub
ferenc-csaky commented on PR #26536: URL: https://github.com/apache/flink/pull/26536#issuecomment-2859908776 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] [FLINK-35019] support convert show create model sql to operation [flink]

2025-05-07 Thread via GitHub
davidradl commented on code in PR #26528: URL: https://github.com/apache/flink/pull/26528#discussion_r2077909232 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/converters/SqlNodeConverters.java: ## @@ -53,6 +53,7 @@ public class SqlNod

Re: [PR] [FLIP-516][FLINK-37481] Add new multi way join operator [flink]

2025-05-07 Thread via GitHub
gustavodemorais commented on code in PR #26313: URL: https://github.com/apache/flink/pull/26313#discussion_r2078083677 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/join/stream/StreamingMultiJoinOperator.java: ## @@ -0,0 +1,806 @@ +/*

Re: [PR] [FLINK-37729][flink-formats] ResultTypeQueryable for Avro serialization schema [flink]

2025-05-07 Thread via GitHub
davidradl commented on code in PR #26507: URL: https://github.com/apache/flink/pull/26507#discussion_r2078014721 ## flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/AvroRowDataSerializationSchema.java: ## @@ -139,4 +143,14 @@ public boolean equals(Object o) {

Re: [PR] [FLINK-35019] support convert show create model sql to operation [flink]

2025-05-07 Thread via GitHub
davidradl commented on code in PR #26528: URL: https://github.com/apache/flink/pull/26528#discussion_r2077909232 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/converters/SqlNodeConverters.java: ## @@ -53,6 +53,7 @@ public class SqlNod

Re: [PR] [FLINK-37730][Job Manager] Expose JM exception as K8s exceptions [flink-kubernetes-operator]

2025-05-07 Thread via GitHub
gyfora commented on code in PR #978: URL: https://github.com/apache/flink-kubernetes-operator/pull/978#discussion_r2077934460 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/ApplicationReconciler.java: ## @@ -299,9 +303,92 @

Re: [PR] [FLINK-35019] support convert show create model sql to operation [flink]

2025-05-07 Thread via GitHub
lihaosky commented on code in PR #26528: URL: https://github.com/apache/flink/pull/26528#discussion_r2077932178 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/converters/SqlNodeConverters.java: ## @@ -53,6 +53,7 @@ public class SqlNode

Re: [PR] [FLINK-35019] support convert show create model sql to operation [flink]

2025-05-07 Thread via GitHub
davidradl commented on code in PR #26528: URL: https://github.com/apache/flink/pull/26528#discussion_r2077928618 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/api/TableEnvironmentTest.scala: ## @@ -2957,6 +2957,136 @@ class TableEnvironmentTest {

[jira] [Closed] (FLINK-37632) Add ChangelogFunction interface

2025-05-07 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther closed FLINK-37632. Fix Version/s: 2.1.0 Resolution: Fixed Fixed in master: ddd65bd03749b740ea978570509f2286cda

Re: [PR] [FLINK-37632][table] Add changelog support to PTFs [flink]

2025-05-07 Thread via GitHub
twalthr merged PR #26527: URL: https://github.com/apache/flink/pull/26527 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apach

Re: [PR] [FLINK-37730][Job Manager] Expose JM exception as K8s exceptions [flink-kubernetes-operator]

2025-05-07 Thread via GitHub
vsantwana commented on code in PR #978: URL: https://github.com/apache/flink-kubernetes-operator/pull/978#discussion_r2077852108 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/ApplicationReconciler.java: ## @@ -299,9 +303,9

Re: [PR] [FLINK-37515] Basic support for Blue/Green deployments [flink-kubernetes-operator]

2025-05-07 Thread via GitHub
davidradl commented on code in PR #969: URL: https://github.com/apache/flink-kubernetes-operator/pull/969#discussion_r2077824296 ## helm/flink-kubernetes-operator/templates/rbac.yaml: ## @@ -101,6 +103,7 @@ rules: - apiGroups: - flink.apache.org resources: +

Re: [PR] [FLINK-37515] Basic support for Blue/Green deployments [flink-kubernetes-operator]

2025-05-07 Thread via GitHub
davidradl commented on code in PR #969: URL: https://github.com/apache/flink-kubernetes-operator/pull/969#discussion_r2077809448 ## flink-kubernetes-operator-api/src/main/java/org/apache/flink/kubernetes/operator/api/utils/SpecUtils.java: ## @@ -99,6 +99,28 @@ public static Str

Re: [PR] [FLINK-37515] Basic support for Blue/Green deployments [flink-kubernetes-operator]

2025-05-07 Thread via GitHub
davidradl commented on code in PR #969: URL: https://github.com/apache/flink-kubernetes-operator/pull/969#discussion_r2077806156 ## flink-kubernetes-operator-api/src/main/java/org/apache/flink/kubernetes/operator/api/utils/SpecUtils.java: ## @@ -99,6 +99,28 @@ public static Str

Re: [PR] [FLINK-37515] Basic support for Blue/Green deployments [flink-kubernetes-operator]

2025-05-07 Thread via GitHub
davidradl commented on code in PR #969: URL: https://github.com/apache/flink-kubernetes-operator/pull/969#discussion_r206466 ## flink-kubernetes-operator-api/src/main/java/org/apache/flink/kubernetes/operator/api/status/FlinkBlueGreenDeploymentState.java: ## @@ -0,0 +1,40 @

Re: [PR] [FLINK-37515] Basic support for Blue/Green deployments [flink-kubernetes-operator]

2025-05-07 Thread via GitHub
davidradl commented on code in PR #969: URL: https://github.com/apache/flink-kubernetes-operator/pull/969#discussion_r204730 ## flink-kubernetes-operator-api/src/main/java/org/apache/flink/kubernetes/operator/api/status/FlinkBlueGreenDeploymentState.java: ## @@ -0,0 +1,26 @

[PR] [BP-1.20][FLINK-37760][format] Bump parquet from 1.15.1 to 1.15.2 [flink]

2025-05-07 Thread via GitHub
mbalassi opened a new pull request, #26536: URL: https://github.com/apache/flink/pull/26536 Backport of #26535. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

Re: [PR] [BP-1.19][FLINK-37760][format] Bump parquet from 1.15.1 to 1.15.2 [flink]

2025-05-07 Thread via GitHub
flinkbot commented on PR #26537: URL: https://github.com/apache/flink/pull/26537#issuecomment-2858730962 ## CI report: * 7e9231dfda996041d2ef72621db407ff23a98f55 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-37760][format] Bump parquet from 1.15.1 to 1.15.2 [flink]

2025-05-07 Thread via GitHub
mbalassi merged PR #26531: URL: https://github.com/apache/flink/pull/26531 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

[PR] [BP-1.19][FLINK-37760][format] Bump parquet from 1.15.1 to 1.15.2 [flink]

2025-05-07 Thread via GitHub
mbalassi opened a new pull request, #26537: URL: https://github.com/apache/flink/pull/26537 Backport of #26531. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

Re: [PR] [BP-1.20][FLINK-37760][format] Bump parquet from 1.15.1 to 1.15.2 [flink]

2025-05-07 Thread via GitHub
flinkbot commented on PR #26536: URL: https://github.com/apache/flink/pull/26536#issuecomment-2858710754 ## CI report: * ea909bf62ec13fc450c8ded2d60c0c0ad724499a UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [BP-2.0][FLINK-37760][format] Bump parquet from 1.15.1 to 1.15.2 [flink]

2025-05-07 Thread via GitHub
flinkbot commented on PR #26535: URL: https://github.com/apache/flink/pull/26535#issuecomment-2858692298 ## CI report: * 4c0fc85618b85fd724d439830e3d14f5937562fd UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [BP-2.0][FLINK-37760][format] Bump parquet from 1.15.1 to 1.15.2 [flink]

2025-05-07 Thread via GitHub
mbalassi opened a new pull request, #26535: URL: https://github.com/apache/flink/pull/26535 Backport of #26531. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

[jira] [Commented] (FLINK-34071) Deadlock in AWS Kinesis Data Streams AsyncSink connector

2025-05-07 Thread Ahmed Hamdy (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1795#comment-1795 ] Ahmed Hamdy commented on FLINK-34071: - [~nageshvh] Thanks for picking up this effort

Re: [PR] [FLINK-37674][state] Add generic type information handling for state SQL [flink]

2025-05-07 Thread via GitHub
gaborgsomogyi commented on code in PR #26521: URL: https://github.com/apache/flink/pull/26521#discussion_r2077496278 ## flink-libraries/flink-state-processing-api/src/main/java/org/apache/flink/state/table/SavepointConnectorOptions.java: ## @@ -132,8 +133,27 @@ public enum State

Re: [PR] [hotfix] Remove unnecessary StateBackend [flink]

2025-05-07 Thread via GitHub
beliefer commented on PR #26534: URL: https://github.com/apache/flink/pull/26534#issuecomment-2858482512 ping @curcur @rkhachatryan @masteryhx @Myasuka cc @1996fanrui @davidradl @GOODBOY008 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] [FLINK-37730][Job Manager] Expose JM exception as K8s exceptions [flink-kubernetes-operator]

2025-05-07 Thread via GitHub
gyfora commented on code in PR #978: URL: https://github.com/apache/flink-kubernetes-operator/pull/978#discussion_r2077560344 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/ApplicationReconciler.java: ## @@ -299,9 +303,92 @

Re: [PR] [FLINK-37730][Job Manager] Expose JM exception as K8s exceptions [flink-kubernetes-operator]

2025-05-07 Thread via GitHub
morhidi commented on PR #978: URL: https://github.com/apache/flink-kubernetes-operator/pull/978#issuecomment-2858379155 > > It'd be great to catch and turn every job exception into a k8s event, not just for terminal job failures. It'd simplify collecting historical diagnostic data before a

Re: [PR] [FLINK-37674][state] Add generic type information handling for state SQL [flink]

2025-05-07 Thread via GitHub
gaborgsomogyi commented on PR #26521: URL: https://github.com/apache/flink/pull/26521#issuecomment-2858407310 > > > @gaborgsomogyi I was reading the flip an was expecting a generic mechanism, but the Pr is Avro specific. Did I misunderstand ? I think it would be helpful to have Avro in the

Re: [PR] [FLINK-37674][state] Add generic type information handling for state SQL [flink]

2025-05-07 Thread via GitHub
gyfora commented on code in PR #26521: URL: https://github.com/apache/flink/pull/26521#discussion_r2077483510 ## flink-libraries/flink-state-processing-api/src/main/java/org/apache/flink/state/table/SavepointConnectorOptions.java: ## @@ -35,6 +35,7 @@ public class SavepointConne

Re: [PR] [FLINK-37674][state] Add generic type information handling for state SQL [flink]

2025-05-07 Thread via GitHub
gaborgsomogyi commented on code in PR #26521: URL: https://github.com/apache/flink/pull/26521#discussion_r2077499744 ## flink-libraries/flink-state-processing-api/src/main/java/org/apache/flink/state/table/SavepointConnectorOptions.java: ## @@ -35,6 +35,7 @@ public class Savepoi

Re: [PR] [FLINK-37730][Job Manager] Expose JM exception as K8s exceptions [flink-kubernetes-operator]

2025-05-07 Thread via GitHub
morhidi commented on code in PR #978: URL: https://github.com/apache/flink-kubernetes-operator/pull/978#discussion_r2077500754 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/EventRecorder.java: ## @@ -280,7 +280,8 @@ public KubernetesClien

Re: [PR] [FLINK-37674][state] Add generic type information handling for state SQL [flink]

2025-05-07 Thread via GitHub
gaborgsomogyi commented on code in PR #26521: URL: https://github.com/apache/flink/pull/26521#discussion_r2077500088 ## flink-libraries/flink-state-processing-api/src/main/java/org/apache/flink/state/table/SavepointConnectorOptions.java: ## @@ -35,6 +35,7 @@ public class Savepoi

[jira] [Closed] (FLINK-37564) Trigger warning event when job fails to provide visibility

2025-05-07 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-37564. -- Resolution: Duplicate > Trigger warning event when job fails to provide visibility > -

Re: [PR] [FLINK-37674][state] Add generic type information handling for state SQL [flink]

2025-05-07 Thread via GitHub
gaborgsomogyi commented on code in PR #26521: URL: https://github.com/apache/flink/pull/26521#discussion_r2077488514 ## flink-libraries/flink-state-processing-api/src/main/java/org/apache/flink/state/table/SavepointConnectorOptions.java: ## @@ -35,6 +35,7 @@ public class Savepoi

Re: [PR] [FLINK-37674][state] Add generic type information handling for state SQL [flink]

2025-05-07 Thread via GitHub
gyfora commented on code in PR #26521: URL: https://github.com/apache/flink/pull/26521#discussion_r2077484613 ## flink-libraries/flink-state-processing-api/src/main/java/org/apache/flink/state/table/SavepointConnectorOptions.java: ## @@ -35,6 +35,7 @@ public class SavepointConne

[jira] [Commented] (FLINK-37769) Include cause in event when Restarting unhealthy job

2025-05-07 Thread david radley (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17949976#comment-17949976 ] david radley commented on FLINK-37769: -- [~gyfora] ok no worries.  > Include cause

Re: [PR] [hotfix] Remove unnecessary java.io.Serializable [flink]

2025-05-07 Thread via GitHub
beliefer commented on PR #26532: URL: https://github.com/apache/flink/pull/26532#issuecomment-2858319212 ping @aljoscha @StephanEwen cc @1996fanrui @davidradl @GOODBOY008 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[jira] [Commented] (FLINK-37552) Made StateMetaInfo consistent for ForStKeyeStateBackend and ForStSyncKeyeStateBackend.

2025-05-07 Thread Yue Ma (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17949970#comment-17949970 ] Yue Ma commented on FLINK-37552: [~leiyanfei] ping ~ do you have time take a review this

Re: [PR] [FLINK-37730][Job Manager] Expose JM exception as K8s exceptions [flink-kubernetes-operator]

2025-05-07 Thread via GitHub
gyfora commented on code in PR #978: URL: https://github.com/apache/flink-kubernetes-operator/pull/978#discussion_r2077431334 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/ApplicationReconciler.java: ## @@ -299,9 +303,92 @

Re: [PR] [FLINK-37730][Job Manager] Expose JM exception as K8s exceptions [flink-kubernetes-operator]

2025-05-07 Thread via GitHub
rmetzger commented on code in PR #978: URL: https://github.com/apache/flink-kubernetes-operator/pull/978#discussion_r2077436211 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/ApplicationReconciler.java: ## @@ -299,9 +303,92

Re: [PR] [FLINK-37730][Job Manager] Expose JM exception as K8s exceptions [flink-kubernetes-operator]

2025-05-07 Thread via GitHub
gyfora commented on code in PR #978: URL: https://github.com/apache/flink-kubernetes-operator/pull/978#discussion_r2077428513 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/ApplicationReconciler.java: ## @@ -299,9 +303,92 @

  1   2   >