GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/5107
[FLINK-8176][flip6] Start SubmittedJobGraphStore in Dispatcher
## What is the purpose of the change
The FLIP-6 dispatcher never calls `start()` on its SubmittedJobGraphStore
instance. Hence
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5093#discussion_r153483875
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/json/ResourceIDSerializer.java
---
@@ -29,16 +30,16 @@
/**
* Json
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5093#discussion_r153483098
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/taskmanager/TaskManagerInfo.java
---
@@ -53,8 +53,8 @@
public static final
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5093#discussion_r153482920
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/taskmanager/TaskManagerDetailsInfo.java
---
@@ -43,7 +43,7
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5081#discussion_r153243460
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/metrics/TaskManagerMetricsHandler.java
---
@@ -0,0 +1,64
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/5084
[FLINK-7694][flip6] Migrate JobMetricsHandler to new RestServerEndpoint
## What is the purpose of the change
*FLIP-6 efforts: Migrating HTTP handlers*
## Brief change log
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/5083
[FLINK-7716][flip6] Migrate JobManagerMetricsHandler to new
RestServerEndpoint
## What is the purpose of the change
*FLIP-6 efforts: Migrating HTTP handlers*
## Brief change log
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/5082
[FLINK-8143][flip6] Migrate SubtaskMetricsHandler to new RestServerEndpoint
## What is the purpose of the change
*FLIP-6 efforts: Migrating HTTP handlers*
## Brief change log
Github user GJL closed the pull request at:
https://github.com/apache/flink/pull/5079
---
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/5079
My branch name is wrong. The commit messages are right. Let me know if this
is a problem.
---
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/5081
[FLINK-7530][flip6] Migrate TaskManagerMetricsHandler to new
RestServerEndpoint
## What is the purpose of the change
*FLIP-6 efforts: Migrating HTTP handlers*
## Brief change log
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/5079
[FLINK-7530][flip6] Migrate SubtaskMetricsHandler to new RestServerEndpoint
## What is the purpose of the change
*FLIP-6 efforts: Migrating HTTP handlers*
## Brief change log
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5055#discussion_r152951899
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/metrics/AbstractMetricsHandler.java
---
@@ -0,0 +1,141
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5055#discussion_r152837007
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/rest/messages/job/metrics/MetricsFilterParameterTest.java
---
@@ -0,0 +1,51
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/4757
@bowenli86 I am about to finish my work on
[FLINK-7718](https://issues.apache.org/jira/browse/FLINK-7718), which is quite
similar to your ticket. Unfortunately I missed that you are also migrating
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5055#discussion_r152817079
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/rest/messages/job/metrics/MetricsFilterParameterTest.java
---
@@ -0,0 +1,51
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5055#discussion_r152804507
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/metrics/AbstractMetricsHandler.java
---
@@ -0,0 +1,141
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/5055
[FLINK-7718] [flip6] Add JobVertexMetricsHandler to DispatcherRestEndpoint
## Brief change log
- *Migrate logic in
`org.apache.flink.runtime.rest.handler.legacy.metrics.JobVertexMetricsHandler
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/5004
ð
---
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/5004
ð
---
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/4995
[hotfix] [docs] Fix broken link to FLINK-7811
This fixes a broken hyperlink on page
https://ci.apache.org/projects/flink/flink-docs-release-1.4/start/building.html#scala-versions
![image
Github user GJL closed the pull request at:
https://github.com/apache/flink/pull/4980
---
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4980#discussion_r149985097
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskAsyncCallTest.java
---
@@ -277,8 +287,12 @@ public void invoke() throws
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4980#discussion_r149983878
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskAsyncCallTest.java
---
@@ -277,8 +287,12 @@ public void invoke() throws
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/4980
There is only one thread dispatching the calls:
```
executor = Executors.newSingleThreadExecutor(
new
DispatcherThreadFactory(TASK_THREADS_GROUP
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/4980
I addressed the comments. Let's wait for Travis and let me know if
something else needs to be changed.
@aljoscha @kl0u
---
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4980#discussion_r149955008
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskAsyncCallTest.java
---
@@ -254,12 +300,10 @@ else if (this.error == null
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4980#discussion_r149954849
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskAsyncCallTest.java
---
@@ -254,12 +300,10 @@ else if (this.error == null
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4980#discussion_r149954606
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/DispatcherThreadFactory.java
---
@@ -29,21 +31,41 @@
private final
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4980#discussion_r149954576
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskAsyncCallTest.java
---
@@ -58,99 +59,144 @@
import org.junit.Before
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4980#discussion_r149703888
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskAsyncCallTest.java
---
@@ -58,99 +59,144 @@
import org.junit.Before
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4980#discussion_r149703482
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskStopTest.java
---
@@ -1,157 +0,0 @@
-/*
- * Licensed to the Apache
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4980#discussion_r149703349
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskStopTest.java
---
@@ -1,157 +0,0 @@
-/*
- * Licensed to the Apache
GitHub user GJL reopened a pull request:
https://github.com/apache/flink/pull/4980
[FLINK-8005] [runtime] Set user code class loader before snapshot
## What is the purpose of the change
*During checkpointing, user code may dynamically load classes from the user
code
Github user GJL closed the pull request at:
https://github.com/apache/flink/pull/4980
---
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4980#discussion_r149637566
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskAsyncCallTest.java
---
@@ -58,99 +58,119 @@
import org.junit.Before
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/4980
[FLINK-8005] [runtime] Set user code class loader before snapshot
## What is the purpose of the change
*During checkpointing, user code may dynamically load classes from the user
code
jar
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4955#discussion_r149316761
--- Diff:
flink-connectors/flink-connector-kafka-0.11/src/test/java/org/apache/flink/streaming/connectors/kafka/internal/TransactionalIdsGeneratorTest.java
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4955#discussion_r149315106
--- Diff:
flink-connectors/flink-connector-kafka-0.11/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/TransactionalIdsGenerator.java
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/4933
LGTM ð
Tests didn't fail after ~1000 local executions.
---
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4933#discussion_r148498481
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java
---
@@ -844,7 +844,7 @@ else if (current == CANCELING || current
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/4933
While you are at it:
`ExecutionGraphTestUtils#switchToRunning`
```
public static void switchToRunning(ExecutionGraph eg) {
// check that all execution are in state
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4933#discussion_r148306365
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java
---
@@ -844,7 +844,7 @@ else if (current == CANCELING || current
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4933#discussion_r148305773
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/utils/SimpleAckingTaskManagerGateway.java
---
@@ -48,6 +48,8
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/4933
On your branch `testRestartWithEagerSchedulingAndSlotSharing` is failing
consistently
```
java.util.concurrent.TimeoutException
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4915#discussion_r148227364
--- Diff:
flink-connectors/flink-connector-kafka-0.11/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/FlinkKafkaProducer.java
---
@@ -226,13
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4915#discussion_r148226920
--- Diff:
flink-connectors/flink-connector-kafka-0.11/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer011Test.java
---
@@ -61,7
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4915#discussion_r147754468
--- Diff:
flink-connectors/flink-connector-kafka-0.11/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer011Test.java
---
@@ -61,7
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4915#discussion_r147754127
--- Diff:
flink-connectors/flink-connector-kafka-0.11/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/FlinkKafkaProducer.java
---
@@ -226,13
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4910#discussion_r147741136
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunctionTest.java
---
@@ -35,60 +42,101
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4910#discussion_r147739898
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunction.java
---
@@ -58,18 +61,37
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4910#discussion_r147736898
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunction.java
---
@@ -58,18 +61,37
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4910#discussion_r147735664
--- Diff:
flink-connectors/flink-connector-kafka-0.11/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer011Tests.java
---
@@ -83,49
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4910#discussion_r147717560
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunctionTest.java
---
@@ -35,60 +42,101
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4915#discussion_r147689963
--- Diff:
flink-connectors/flink-connector-kafka-0.11/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer011.java
---
@@ -483,11
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4910#discussion_r147687514
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunction.java
---
@@ -362,4 +483,39 @@ public void
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4910#discussion_r147687302
--- Diff:
flink-connectors/flink-connector-kafka-0.11/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer011.java
---
@@ -922,6
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4910#discussion_r147686546
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunctionTest.java
---
@@ -35,60 +42,101
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4910#discussion_r147681959
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunction.java
---
@@ -58,18 +61,37
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4910#discussion_r147681520
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunction.java
---
@@ -58,18 +61,37
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4910#discussion_r147680902
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunction.java
---
@@ -293,26 +330,110 @@ public
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4910#discussion_r147679890
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunction.java
---
@@ -293,26 +330,110 @@ public
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4910#discussion_r147679597
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunction.java
---
@@ -293,26 +330,110 @@ public
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4910#discussion_r147679516
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunction.java
---
@@ -58,18 +61,37
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4910#discussion_r147679162
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunction.java
---
@@ -58,18 +61,37
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4910#discussion_r147678943
--- Diff:
flink-connectors/flink-connector-kafka-0.11/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer011.java
---
@@ -442,13
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4910#discussion_r147678610
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunctionTest.java
---
@@ -194,29 +348,4 @@ public
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4910#discussion_r147677068
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunctionTest.java
---
@@ -35,60 +42,101
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4915#discussion_r147667457
--- Diff:
flink-connectors/flink-connector-kafka-0.11/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/FlinkKafkaProducer.java
---
@@ -226,13
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4915#discussion_r147656743
--- Diff:
flink-connectors/flink-connector-kafka-0.11/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/FlinkKafkaProducer.java
---
@@ -226,13
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/4915
ð
---
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4915#discussion_r147442314
--- Diff:
flink-connectors/flink-connector-kafka-0.11/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer011.java
---
@@ -563,7 +553,7
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4915#discussion_r147436687
--- Diff:
flink-connectors/flink-connector-kafka-0.11/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer011.java
---
@@ -483,11
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/4914
[hotfix] [docs] Fix typos in types serialization documentation
This fixes typos in the types serialization documentation.
You can merge this pull request into a Git repository by running:
$ git
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/4913
[hotfix] [javadoc] Fix typo in Javadoc of
ManagedSnapshotContext#getCheckpointId()
This fixes a typo in the Javadoc of
ManagedSnapshotContext#getCheckpointId().
You can merge this pull request
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/4912
[hotfix] [docs] Fix broken downloads page url
This fixes a broken *Downloads Page* url on the AWS page of the
documentation:
https://ci.apache.org/projects/flink/flink-docs-release-1.3/setup/aws.html
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/4910
@aljoscha
---
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/4910
[FLINK-7784] [kafka-producer] Don't fail TwoPhaseCommitSinkFunction when
failing to commit during job recovery
## What is the purpose of the change
This makes it possible to configure
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/4356
Thanks for your contribution. I have a few questions because the submitted
code does not match with what the ticket currently says:
From https://issues.apache.org/jira/browse/FLINK-5486
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/4856
[hotifx] [docs] Add required option -yn to example command
Example command to start the WordCount job via YARN does not work because
it is missing the `-yn` option, which specifies the number of YARN
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4803#discussion_r145122089
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistry.java
---
@@ -402,25 +401,4 @@ public void run
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/4803
ð
I reviewed the code and can confirm that the implementations are virtually
identical.
---
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/4777
If this is merged, #2192 can be probably closed.
---
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4807#discussion_r144245061
--- Diff: docs/start/building.md ---
@@ -115,19 +115,7 @@ The `-Pvendor-repos` activates a Maven [build
profile](http://maven.apache.org/g
Flink has
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/4791
[hotfix] [Javadoc] Fix typos
Fix typos in Javadoc for classes:
- `org.apache.flink.api.java.typeutils.InputTypeConfigurable`
- `org.apache.flink.core.fs.FileSystem`
You can merge this pull
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4764#discussion_r142490404
--- Diff: flink-core/src/main/java/org/apache/flink/util/ResourceGuard.java
---
@@ -0,0 +1,130 @@
+/*
+ * Licensed to the Apache Software Foundation
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/4755
[hotfix] [docs] Fix broken links
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/GJL/flink hotfix-broken-links
Alternatively you can review
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4187#discussion_r126283335
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java
---
@@ -184,6
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4187#discussion_r126283316
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java
---
@@ -104,7
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/4119
[docs] Fix typos (Souce -> Source)
This changes occurrences of *Souce* in the documentation to *Source*.
You can merge this pull request into a Git repository by running:
$ git pull ht
601 - 690 of 690 matches
Mail list logo
