[jira] [Updated] (FLINK-29114) TableSourceITCase#testTableHintWithLogicalTableScanReuse sometimes fails with result mismatch

2024-03-13 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-29114: --- Priority: Blocker (was: Major) > TableSourceITCase#testTableHintWithLogicalTableScanReuse

[jira] [Commented] (FLINK-33856) Add metrics to monitor the interaction performance between task and external storage system in the process of checkpoint making

2024-02-25 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820619#comment-17820619 ] Piotr Nowojski commented on FLINK-33856: Hey [~hejufang001]! The new processes hasn't been yet

[jira] [Commented] (FLINK-34430) Akka frame size exceeded with many ByteStreamStateHandle being used

2024-02-20 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818838#comment-17818838 ] Piotr Nowojski commented on FLINK-34430: [~roman] is already working on that under FLINK-26050

[jira] [Comment Edited] (FLINK-34386) Add RocksDB bloom filter metrics

2024-02-20 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818837#comment-17818837 ] Piotr Nowojski edited comment on FLINK-34386 at 2/20/24 2:42 PM: - merged

[jira] [Closed] (FLINK-34386) Add RocksDB bloom filter metrics

2024-02-20 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski closed FLINK-34386. -- Fix Version/s: 1.20.0 Resolution: Fixed merged commit 890a995 into apache:master now

[jira] [Assigned] (FLINK-34386) Add RocksDB bloom filter metrics

2024-02-20 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski reassigned FLINK-34386: -- Assignee: Jufang He > Add RocksDB bloom filter metrics >

[jira] [Comment Edited] (FLINK-34424) BoundedBlockingSubpartitionWriteReadTest#testRead10ConsumersConcurrent times out

2024-02-14 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817251#comment-17817251 ] Piotr Nowojski edited comment on FLINK-34424 at 2/14/24 8:39 AM: - :D

[jira] [Commented] (FLINK-34424) BoundedBlockingSubpartitionWriteReadTest#testRead10ConsumersConcurrent times out

2024-02-14 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817251#comment-17817251 ] Piotr Nowojski commented on FLINK-34424: :D [~mapohl] I haven't made any modifications to this

[jira] [Updated] (FLINK-34430) Akka frame size exceeded with many ByteStreamStateHandle being used

2024-02-12 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-34430: --- Description: The following error can happen {noformat} Discarding oversized payload sent to

[jira] [Updated] (FLINK-34430) Akka frame size exceeded with many ByteStreamStateHandle being used

2024-02-12 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-34430: --- Description: The following error can happen {noformat} Discarding oversized payload sent to

[jira] [Updated] (FLINK-34430) Akka frame size exceeded with many ByteStreamStateHandle being used

2024-02-12 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-34430: --- Description: The following error can happen {noformat} Discarding oversized payload sent to

[jira] [Commented] (FLINK-34430) Akka frame size exceeded with many ByteStreamStateHandle being used

2024-02-12 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816597#comment-17816597 ] Piotr Nowojski commented on FLINK-34430: Akka frame size can be exceeded as a result of RocksDB

[jira] [Created] (FLINK-34430) Akka frame size exceeded with many ByteStreamStateHandle being used

2024-02-12 Thread Piotr Nowojski (Jira)
Piotr Nowojski created FLINK-34430: -- Summary: Akka frame size exceeded with many ByteStreamStateHandle being used Key: FLINK-34430 URL: https://issues.apache.org/jira/browse/FLINK-34430 Project:

[jira] [Commented] (FLINK-26050) Too many small sst files in rocksdb state backend when using time window created in ascending order

2024-02-12 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816595#comment-17816595 ] Piotr Nowojski commented on FLINK-26050: I have encountered the same situation but with event

[jira] [Updated] (FLINK-26050) Too many small sst files in rocksdb state backend when using time window created in ascending order

2024-02-12 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-26050: --- Description: When using processing or event time windows, in some workloads, there will be

[jira] [Updated] (FLINK-26050) Too many small sst files in rocksdb state backend when using time window created in ascending order

2024-02-12 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-26050: --- Summary: Too many small sst files in rocksdb state backend when using time window created

[jira] [Commented] (FLINK-34289) Release Testing Instructions: Verify FLINK-33695 Introduce TraceReporter and use it to create checkpointing and recovery traces

2024-02-08 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815766#comment-17815766 ] Piotr Nowojski commented on FLINK-34289: That definitely would prevent my confusion :) >

[jira] [Commented] (FLINK-34403) VeryBigPbProtoToRowTest#testSimple cannot pass due to OOM

2024-02-08 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815685#comment-17815685 ] Piotr Nowojski commented on FLINK-34403:

[jira] [Updated] (FLINK-34403) VeryBigPbProtoToRowTest#testSimple cannot pass due to OOM

2024-02-08 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-34403: --- Priority: Critical (was: Major) > VeryBigPbProtoToRowTest#testSimple cannot pass due to

[jira] [Comment Edited] (FLINK-34289) Release Testing Instructions: Verify FLINK-33695 Introduce TraceReporter and use it to create checkpointing and recovery traces

2024-02-07 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815532#comment-17815532 ] Piotr Nowojski edited comment on FLINK-34289 at 2/8/24 6:33 AM:

[jira] [Commented] (FLINK-34289) Release Testing Instructions: Verify FLINK-33695 Introduce TraceReporter and use it to create checkpointing and recovery traces

2024-02-07 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815532#comment-17815532 ] Piotr Nowojski commented on FLINK-34289: !Screenshot 2024-02-08 at 07.22.19.png! This part

[jira] [Updated] (FLINK-34289) Release Testing Instructions: Verify FLINK-33695 Introduce TraceReporter and use it to create checkpointing and recovery traces

2024-02-07 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-34289: --- Attachment: Screenshot 2024-02-08 at 07.22.19.png > Release Testing Instructions: Verify

[jira] [Commented] (FLINK-34289) Release Testing Instructions: Verify FLINK-33695 Introduce TraceReporter and use it to create checkpointing and recovery traces

2024-02-06 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814807#comment-17814807 ] Piotr Nowojski commented on FLINK-34289: I wasn't complaining, just explaining myself :) Sorry

[jira] [Commented] (FLINK-34289) Release Testing Instructions: Verify FLINK-33695 Introduce TraceReporter and use it to create checkpointing and recovery traces

2024-02-06 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814787#comment-17814787 ] Piotr Nowojski commented on FLINK-34289: Thanks for cleaning this up. Indeed I was confused what

[jira] [Closed] (FLINK-34387) Release Testing: Verify FLINK-33695 Introduce TraceReporter and use it to create checkpointing and recovery traces

2024-02-06 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski closed FLINK-34387. -- Resolution: Won't Do After giving it a second thought I'm closing this ticket, as there is no

[jira] [Assigned] (FLINK-34289) Release Testing: Verify FLINK-33695 Introduce TraceReporter and use it to create checkpointing and recovery traces

2024-02-05 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski reassigned FLINK-34289: -- Assignee: (was: Piotr Nowojski) > Release Testing: Verify FLINK-33695 Introduce

[jira] [Closed] (FLINK-34290) Release Testing Instructions: Verify FLINK-33696 Add OpenTelemetryTraceReporter and OpenTelemetryMetricReporter

2024-02-05 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski closed FLINK-34290. -- Resolution: Won't Do Covered by https://issues.apache.org/jira/browse/FLINK-34289 > Release

[jira] [Updated] (FLINK-34289) Release Testing: Verify FLINK-33695 Introduce TraceReporter and use it to create checkpointing and recovery traces

2024-02-05 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-34289: --- Summary: Release Testing: Verify FLINK-33695 Introduce TraceReporter and use it to create

[jira] [Updated] (FLINK-34289) Release Testing Instructions: Verify FLINK-33695 Introduce TraceReporter and use it to create checkpointing and recovery traces

2024-02-05 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-34289: --- Description: This ticket covers testing three related features: FLINK-33695, FLINK-33735

[jira] [Commented] (FLINK-34289) Release Testing Instructions: Verify FLINK-33695 Introduce TraceReporter and use it to create checkpointing and recovery traces

2024-02-05 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814439#comment-17814439 ] Piotr Nowojski commented on FLINK-34289: Thanks! I will create a single ticket for release

[jira] [Commented] (FLINK-33819) Support setting CompressType in RocksDBStateBackend

2024-02-02 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17813740#comment-17813740 ] Piotr Nowojski commented on FLINK-33819: Thanks [~mayuehappy]. {quote} merged 4f7725aa into

[jira] [Comment Edited] (FLINK-33819) Support setting CompressType in RocksDBStateBackend

2024-02-02 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17813740#comment-17813740 ] Piotr Nowojski edited comment on FLINK-33819 at 2/2/24 3:52 PM: Thanks

[jira] [Reopened] (FLINK-33696) FLIP-385: Add OpenTelemetryTraceReporter and OpenTelemetryMetricReporter

2024-02-02 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski reopened FLINK-33696: No it's not yet done. I still have to open a PR adding OpenTelemetry reporters. 7db2ecad was

[jira] [Updated] (FLINK-34134) Add tracing for restored state size and locations

2024-01-18 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-34134: --- Fix Version/s: 1.19.0 > Add tracing for restored state size and locations >

[jira] [Closed] (FLINK-27756) Fix intermittently failing test in AsyncSinkWriterTest.checkLoggedSendTimesAreWithinBounds

2024-01-16 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski closed FLINK-27756. -- Resolution: Fixed Thanks [~chalixar] for fixing this! merged commit d92ab39 into

[jira] [Updated] (FLINK-27756) Fix intermittently failing test in AsyncSinkWriterTest.checkLoggedSendTimesAreWithinBounds

2024-01-16 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-27756: --- Fix Version/s: 1.17.3 1.18.2 > Fix intermittently failing test in >

[jira] [Updated] (FLINK-27756) Fix intermittently failing test in AsyncSinkWriterTest.checkLoggedSendTimesAreWithinBounds

2024-01-16 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-27756: --- Affects Version/s: 1.18.1 > Fix intermittently failing test in >

[jira] [Updated] (FLINK-27756) Fix intermittently failing test in AsyncSinkWriterTest.checkLoggedSendTimesAreWithinBounds

2024-01-15 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-27756: --- Priority: Blocker (was: Critical) > Fix intermittently failing test in >

[jira] [Commented] (FLINK-33338) Bump FRocksDB version

2024-01-15 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-8?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17806860#comment-17806860 ] Piotr Nowojski commented on FLINK-8: [~roman], let's make sure that this latest bug fix is

[jira] [Commented] (FLINK-33337) Expose IngestDB and ClipDB in the official RocksDB API

2024-01-15 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17806861#comment-17806861 ] Piotr Nowojski commented on FLINK-7: Thanks [~mayuehappy] for the update! > Expose IngestDB

[jira] [Comment Edited] (FLINK-33819) Support setting CompressType in RocksDBStateBackend

2024-01-15 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17806804#comment-17806804 ] Piotr Nowojski edited comment on FLINK-33819 at 1/15/24 1:09 PM: - Thanks

[jira] [Commented] (FLINK-33819) Support setting CompressType in RocksDBStateBackend

2024-01-15 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17806804#comment-17806804 ] Piotr Nowojski commented on FLINK-33819: +1 for making this option configurable. > Support

[jira] [Comment Edited] (FLINK-33819) Support setting CompressType in RocksDBStateBackend

2024-01-15 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17806804#comment-17806804 ] Piotr Nowojski edited comment on FLINK-33819 at 1/15/24 1:00 PM: - Thanks

[jira] [Comment Edited] (FLINK-34063) When snapshot compression is enabled, rescaling of a source operator leads to some splits getting lost

2024-01-12 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805934#comment-17805934 ] Piotr Nowojski edited comment on FLINK-34063 at 1/12/24 8:32 AM: -

[jira] [Commented] (FLINK-34063) When snapshot compression is enabled, rescaling of a source operator leads to some splits getting lost

2024-01-12 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805934#comment-17805934 ] Piotr Nowojski commented on FLINK-34063: Could this issue be discovered by our ITCases if

[jira] [Closed] (FLINK-33697) FLIP-386: Support adding custom metrics in Recovery Spans

2024-01-12 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski closed FLINK-33697. -- Release Note: A braking change has been introduced to the `StateBackend` interface. This is

[jira] [Commented] (FLINK-33856) Add metrics to monitor the interaction performance between task and external storage system in the process of checkpoint making

2024-01-11 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805739#comment-17805739 ] Piotr Nowojski commented on FLINK-33856: In that case [~hejufang001] it would be great if you

[jira] [Closed] (FLINK-33775) Report JobInitialization traces

2024-01-05 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski closed FLINK-33775. -- Fix Version/s: 1.19.0 Resolution: Fixed merged commit 793a66b into apache:master >

[jira] [Closed] (FLINK-33695) FLIP-384: Introduce TraceReporter and use it to create checkpointing and recovery traces

2024-01-05 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski closed FLINK-33695. -- Resolution: Fixed > FLIP-384: Introduce TraceReporter and use it to create checkpointing and

[jira] [Commented] (FLINK-33897) Allow triggering unaligned checkpoint via CLI

2024-01-05 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803535#comment-17803535 ] Piotr Nowojski commented on FLINK-33897: By real world motivation, I meant if that really is an

[jira] [Comment Edited] (FLINK-33856) Add metrics to monitor the interaction performance between task and external storage system in the process of checkpoint making

2024-01-05 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803478#comment-17803478 ] Piotr Nowojski edited comment on FLINK-33856 at 1/5/24 9:58 AM: {quote}

[jira] [Comment Edited] (FLINK-33856) Add metrics to monitor the interaction performance between task and external storage system in the process of checkpoint making

2024-01-05 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803478#comment-17803478 ] Piotr Nowojski edited comment on FLINK-33856 at 1/5/24 9:56 AM: {quote}

[jira] [Commented] (FLINK-33856) Add metrics to monitor the interaction performance between task and external storage system in the process of checkpoint making

2024-01-05 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803478#comment-17803478 ] Piotr Nowojski commented on FLINK-33856: {quote} Maybe a new flip that supports task-level trace

[jira] [Commented] (FLINK-33932) Support retry mechanism for rocksdb uploader

2024-01-04 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803237#comment-17803237 ] Piotr Nowojski commented on FLINK-33932: Yes, I don't think this should cause a correctness

[jira] [Updated] (FLINK-33932) Support retry mechanism for rocksdb uploader

2024-01-04 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-33932: --- Description: Rocksdb uploader will throw exception and decline the current checkpoint if

[jira] [Comment Edited] (FLINK-33856) Add metrics to monitor the interaction performance between task and external storage system in the process of checkpoint making

2024-01-04 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803201#comment-17803201 ] Piotr Nowojski edited comment on FLINK-33856 at 1/4/24 3:00 PM: Hi, I

[jira] [Commented] (FLINK-33856) Add metrics to monitor the interaction performance between task and external storage system in the process of checkpoint making

2024-01-04 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803201#comment-17803201 ] Piotr Nowojski commented on FLINK-33856: Hi, I second that implementing this as metrics doesn't

[jira] [Commented] (FLINK-33897) Allow triggering unaligned checkpoint via CLI

2024-01-04 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803185#comment-17803185 ] Piotr Nowojski commented on FLINK-33897: I have mixed feelings. Shouldn't the solution be to

[jira] [Updated] (FLINK-33897) Allow triggering unaligned checkpoint via CLI

2024-01-04 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-33897: --- Issue Type: New Feature (was: Improvement) > Allow triggering unaligned checkpoint via CLI

[jira] [Commented] (FLINK-27756) Fix intermittently failing test in AsyncSinkWriterTest.checkLoggedSendTimesAreWithinBounds

2024-01-04 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803176#comment-17803176 ] Piotr Nowojski commented on FLINK-27756:

[jira] [Commented] (FLINK-27681) Improve the availability of Flink when the RocksDB file is corrupted.

2023-12-14 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17796843#comment-17796843 ] Piotr Nowojski commented on FLINK-27681: I could help reviewing and generally speaking support

[jira] [Commented] (FLINK-33734) Merge unaligned checkpoint state handle

2023-12-13 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17796391#comment-17796391 ] Piotr Nowojski commented on FLINK-33734: {quote} Yes, since multiple subtasks will reuse

[jira] [Updated] (FLINK-33697) FLIP-386: Support adding custom metrics in Recovery Spans

2023-12-11 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-33697: --- Description: h1. Motivation [FLIP-386|https://cwiki.apache.org/confluence/x/VAuZE] is

[jira] [Assigned] (FLINK-33709) Report CheckpointStats as Spans

2023-12-11 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski reassigned FLINK-33709: -- Assignee: Piotr Nowojski > Report CheckpointStats as Spans >

[jira] [Comment Edited] (FLINK-33708) Add Span and TraceReporter concepts

2023-12-11 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17795364#comment-17795364 ] Piotr Nowojski edited comment on FLINK-33708 at 12/11/23 1:21 PM: --

[jira] [Closed] (FLINK-33709) Report CheckpointStats as Spans

2023-12-11 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski closed FLINK-33709. -- Fix Version/s: 1.19.0 Resolution: Fixed Merged f5039a8824e to master > Report

[jira] [Closed] (FLINK-33708) Add Span and TraceReporter concepts

2023-12-11 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski closed FLINK-33708. -- Fix Version/s: 1.19.0 Assignee: Piotr Nowojski Resolution: Fixed Merged

[jira] [Commented] (FLINK-33696) FLIP-385: Add OpenTelemetryTraceReporter and OpenTelemetryMetricReporter

2023-12-11 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17795363#comment-17795363 ] Piotr Nowojski commented on FLINK-33696: merged 7db2ecad165 to master > FLIP-385: Add

[jira] [Commented] (FLINK-27681) Improve the availability of Flink when the RocksDB file is corrupted.

2023-12-08 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17794622#comment-17794622 ] Piotr Nowojski commented on FLINK-27681: {quote} So I understand that we can do this manual

[jira] [Commented] (FLINK-33338) Bump FRocksDB version

2023-12-08 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-8?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17794618#comment-17794618 ] Piotr Nowojski commented on FLINK-8: >From what I've heard from an offline discussion, the

[jira] [Created] (FLINK-33775) Report JobInitialization traces

2023-12-07 Thread Piotr Nowojski (Jira)
Piotr Nowojski created FLINK-33775: -- Summary: Report JobInitialization traces Key: FLINK-33775 URL: https://issues.apache.org/jira/browse/FLINK-33775 Project: Flink Issue Type: Sub-task

[jira] [Commented] (FLINK-27681) Improve the availability of Flink when the RocksDB file is corrupted.

2023-12-07 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17794272#comment-17794272 ] Piotr Nowojski commented on FLINK-27681: [~masteryhx] , yes that would require a new FLIP, as

[jira] [Updated] (FLINK-33693) Force aligned barrier logic doesn't work when the aligned checkpoint timeout is enabled

2023-12-07 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-33693: --- Priority: Critical (was: Major) > Force aligned barrier logic doesn't work when the

[jira] [Commented] (FLINK-33734) Merge unaligned checkpoint state handle

2023-12-07 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17794090#comment-17794090 ] Piotr Nowojski commented on FLINK-33734: Recovery times are very often important. But yes,

[jira] [Comment Edited] (FLINK-33734) Merge unaligned checkpoint state handle

2023-12-06 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17793706#comment-17793706 ] Piotr Nowojski edited comment on FLINK-33734 at 12/6/23 1:16 PM: - That's

[jira] [Commented] (FLINK-33734) Merge unaligned checkpoint state handle

2023-12-06 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17793706#comment-17793706 ] Piotr Nowojski commented on FLINK-33734: That's a good question [~Zakelly]. Apart of that:

[jira] [Commented] (FLINK-27681) Improve the availability of Flink when the RocksDB file is corrupted.

2023-12-06 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17793626#comment-17793626 ] Piotr Nowojski commented on FLINK-27681: {quote} IIUC, checksum in SST level could guarantee

[jira] [Created] (FLINK-33709) Report CheckpointStats as Spans

2023-11-30 Thread Piotr Nowojski (Jira)
Piotr Nowojski created FLINK-33709: -- Summary: Report CheckpointStats as Spans Key: FLINK-33709 URL: https://issues.apache.org/jira/browse/FLINK-33709 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-33708) Add Span and TraceReporter concepts

2023-11-30 Thread Piotr Nowojski (Jira)
Piotr Nowojski created FLINK-33708: -- Summary: Add Span and TraceReporter concepts Key: FLINK-33708 URL: https://issues.apache.org/jira/browse/FLINK-33708 Project: Flink Issue Type: Sub-task

[jira] [Commented] (FLINK-27681) Improve the availability of Flink when the RocksDB file is corrupted.

2023-11-30 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17791599#comment-17791599 ] Piotr Nowojski commented on FLINK-27681: {quote} However,  the job must fail in the future(When

[jira] [Created] (FLINK-33697) FLIP-386: Support adding custom metrics in Recovery Spans

2023-11-29 Thread Piotr Nowojski (Jira)
Piotr Nowojski created FLINK-33697: -- Summary: FLIP-386: Support adding custom metrics in Recovery Spans Key: FLINK-33697 URL: https://issues.apache.org/jira/browse/FLINK-33697 Project: Flink

[jira] [Created] (FLINK-33696) FLIP-385: Add OpenTelemetryTraceReporter and OpenTelemetryMetricReporter

2023-11-29 Thread Piotr Nowojski (Jira)
Piotr Nowojski created FLINK-33696: -- Summary: FLIP-385: Add OpenTelemetryTraceReporter and OpenTelemetryMetricReporter Key: FLINK-33696 URL: https://issues.apache.org/jira/browse/FLINK-33696

[jira] [Closed] (FLINK-7894) Improve metrics around fine-grained recovery and associated checkpointing behaviors

2023-11-29 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-7894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski closed FLINK-7894. - Resolution: Duplicate > Improve metrics around fine-grained recovery and associated

[jira] [Updated] (FLINK-33695) FLIP-384: Introduce TraceReporter and use it to create checkpointing and recovery traces

2023-11-29 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-33695: --- Description: https://cwiki.apache.org/confluence/x/TguZE *Motivation* Currently Flink has

[jira] [Updated] (FLINK-33695) FLIP-384: Introduce TraceReporter and use it to create checkpointing and recovery traces

2023-11-29 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-33695: --- Description: https://cwiki.apache.org/confluence/x/TguZE *Motivation* Currently Flink has

[jira] [Closed] (FLINK-22390) Support for OpenTelemetry

2023-11-29 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski closed FLINK-22390. -- Resolution: Won't Do This ticket is most likely mostly superseded via FLINK-33695. >

[jira] [Closed] (FLINK-23411) Expose Flink checkpoint details metrics

2023-11-29 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski closed FLINK-23411. -- Resolution: Duplicate Closing as duplicate in favour of FLINK-33695 > Expose Flink

[jira] [Created] (FLINK-33695) FLIP-384: Introduce TraceReporter and use it to create checkpointing and recovery traces

2023-11-29 Thread Piotr Nowojski (Jira)
Piotr Nowojski created FLINK-33695: -- Summary: FLIP-384: Introduce TraceReporter and use it to create checkpointing and recovery traces Key: FLINK-33695 URL: https://issues.apache.org/jira/browse/FLINK-33695

[jira] [Closed] (FLINK-6755) Allow triggering Checkpoints through command line client

2023-11-29 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-6755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski closed FLINK-6755. - Fix Version/s: 1.19.0 Resolution: Fixed merged commit 7265438 into apache:master > Allow

[jira] [Commented] (FLINK-27681) Improve the availability of Flink when the RocksDB file is corrupted.

2023-11-24 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789447#comment-17789447 ] Piotr Nowojski commented on FLINK-27681: Ahh got it. In that case I would argue always failing

[jira] [Commented] (FLINK-27681) Improve the availability of Flink when the RocksDB file is corrupted.

2023-11-24 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789418#comment-17789418 ] Piotr Nowojski commented on FLINK-27681: Thanks [~fanrui] for pinging me, and double thanks to

[jira] [Commented] (FLINK-32444) Enable object reuse for Flink SQL jobs by default

2023-11-23 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789031#comment-17789031 ] Piotr Nowojski commented on FLINK-32444: Instead of checking for the configured state backend, I

[jira] [Closed] (FLINK-33337) Expose IngestDB and ClipDB in the official RocksDB API

2023-11-07 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-7?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski closed FLINK-7. -- Resolution: Fixed > Expose IngestDB and ClipDB in the official RocksDB API >

[jira] [Updated] (FLINK-33337) Expose IngestDB and ClipDB in the official RocksDB API

2023-11-07 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-7?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-7: --- Description: Remaining open PRs: None :) Already merged PRs:

[jira] [Commented] (FLINK-33337) Expose IngestDB and ClipDB in the official RocksDB API

2023-11-07 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783523#comment-17783523 ] Piotr Nowojski commented on FLINK-7: Thanks for the update [~mayuehappy]! Does it mean that

[jira] [Updated] (FLINK-33337) Expose IngestDB and ClipDB in the official RocksDB API

2023-11-06 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-7?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-7: --- Description: Remaining open PRs: https://github.com/facebook/rocksdb/pull/11646 Already

[jira] [Updated] (FLINK-33337) Expose IngestDB and ClipDB in the official RocksDB API

2023-11-06 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-7?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-7: --- Description: Remaining open PRs: https://github.com/facebook/rocksdb/pull/11646

[jira] [Updated] (FLINK-33337) Expose IngestDB and ClipDB in the official RocksDB API

2023-11-06 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-7?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-7: --- Description: Remaining open PRs: https://github.com/facebook/rocksdb/pull/11646

[jira] [Commented] (FLINK-32444) Enable object reuse for Flink SQL jobs by default

2023-11-03 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17782658#comment-17782658 ] Piotr Nowojski commented on FLINK-32444: {quote} Does it give us a performance benefits?

[jira] [Closed] (FLINK-33090) CheckpointsCleaner clean individual checkpoint states in parallel

2023-10-25 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski closed FLINK-33090. -- Fix Version/s: 1.19.0 Release Note: Now when disposing of no longer needed checkpoints,

<    1   2   3   4   5   6   7   8   9   10   >