[jira] [Commented] (FLINK-16503) Don't assign ScheduledExecutorService into variables of ExecutorService or Executor types

2020-03-09 Thread Roman Leventov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17054816#comment-17054816 ] Roman Leventov commented on FLINK-16503: No   > Don't assign ScheduledExecutorService into

[jira] [Commented] (FLINK-16503) Don't assign ScheduledExecutorService into variables of ExecutorService or Executor types

2020-03-09 Thread Roman Leventov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17054814#comment-17054814 ] Roman Leventov commented on FLINK-16503: FYI: I included ForkJoinPool earlier as an unnecessary

[jira] [Commented] (FLINK-16503) Don't assign ScheduledExecutorService into variables of ExecutorService or Executor types

2020-03-09 Thread Roman Leventov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17054811#comment-17054811 ] Roman Leventov commented on FLINK-16503: [~tison] yes, this is the sole change in Java code that

[jira] [Updated] (FLINK-16503) Don't assign ScheduledExecutorService into variables of ExecutorService or Executor types

2020-03-09 Thread Roman Leventov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roman Leventov updated FLINK-16503: --- Description: There is an unnecessary efficiency cost to assigning ScheduledExecutorService

[jira] [Comment Edited] (FLINK-16503) Don't assign ScheduledExecutorService into variables of ExecutorService or Executor types

2020-03-09 Thread Roman Leventov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17054800#comment-17054800 ] Roman Leventov edited comment on FLINK-16503 at 3/9/20, 9:40 AM: -

[jira] [Commented] (FLINK-16503) Don't assign ScheduledExecutorService into variables of ExecutorService or Executor types

2020-03-09 Thread Roman Leventov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17054804#comment-17054804 ] Roman Leventov commented on FLINK-16503: [~tison] ScheduledThreadPoolExecutor uses a priority

[jira] [Commented] (FLINK-16503) Don't assign ScheduledExecutorService into variables of ExecutorService or Executor types

2020-03-09 Thread Roman Leventov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17054800#comment-17054800 ] Roman Leventov commented on FLINK-16503: Another pattern that should be checked in CI static

[jira] [Updated] (FLINK-16503) Don't assign ScheduledExecutorService into variables of ExecutorService or Executor types

2020-03-09 Thread Roman Leventov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roman Leventov updated FLINK-16503: --- Description: There is an unnecessary efficiency cost to assigning ScheduledExecutorService

[jira] [Created] (FLINK-16503) Don't assign ScheduledExecutorService into variables of ExecutorService or Executor types

2020-03-09 Thread Roman Leventov (Jira)
Roman Leventov created FLINK-16503: -- Summary: Don't assign ScheduledExecutorService into variables of ExecutorService or Executor types Key: FLINK-16503 URL: https://issues.apache.org/jira/browse/FLINK-16503

[jira] [Commented] (FLINK-16365) awaitTermination() result is not checked

2020-03-01 Thread Roman Leventov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17048848#comment-17048848 ] Roman Leventov commented on FLINK-16365: To find all these places, one can use

[jira] [Created] (FLINK-16365) awaitTermination() result is not checked

2020-03-01 Thread Roman Leventov (Jira)
Roman Leventov created FLINK-16365: -- Summary: awaitTermination() result is not checked Key: FLINK-16365 URL: https://issues.apache.org/jira/browse/FLINK-16365 Project: Flink Issue Type:

[jira] [Commented] (FLINK-15838) Dangling CountDownLatch.await(timeout)

2020-02-03 Thread Roman Leventov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17029179#comment-17029179 ] Roman Leventov commented on FLINK-15838: No > Dangling CountDownLatch.await(timeout) >

[jira] [Commented] (FLINK-15838) Dangling CountDownLatch.await(timeout)

2020-02-02 Thread Roman Leventov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028463#comment-17028463 ] Roman Leventov commented on FLINK-15838: A typical outcome is a test not really testing

[jira] [Commented] (FLINK-15838) Dangling CountDownLatch.await(timeout)

2020-01-31 Thread Roman Leventov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027563#comment-17027563 ] Roman Leventov commented on FLINK-15838: See also 

[jira] [Created] (FLINK-15838) Dangling CountDownLatch.await(timeout)

2020-01-31 Thread Roman Leventov (Jira)
Roman Leventov created FLINK-15838: -- Summary: Dangling CountDownLatch.await(timeout) Key: FLINK-15838 URL: https://issues.apache.org/jira/browse/FLINK-15838 Project: Flink Issue Type: Bug