[GitHub] flink issue #2368: [FLINK-3899] Document window processing with Reduce/FoldF...

2016-08-24 Thread danielblazevski
Github user danielblazevski commented on the issue: https://github.com/apache/flink/pull/2368 Pushed the Scala example --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] flink pull request #2368: [FLINK-3899] Document window processing with Reduc...

2016-08-24 Thread danielblazevski
Github user danielblazevski commented on a diff in the pull request: https://github.com/apache/flink/pull/2368#discussion_r76120063 --- Diff: docs/apis/streaming/windows.md --- @@ -459,42 +459,106 @@ ready for processing. This allows to get the benefit of incremental window compu

[GitHub] flink pull request #2368: [FLINK-3899] Document window processing with Reduc...

2016-08-24 Thread danielblazevski
Github user danielblazevski commented on a diff in the pull request: https://github.com/apache/flink/pull/2368#discussion_r76102678 --- Diff: docs/apis/streaming/windows.md --- @@ -459,42 +459,106 @@ ready for processing. This allows to get the benefit of incremental window compu

[GitHub] flink pull request #2368: [FLINK-3899] Document window processing with Reduc...

2016-08-23 Thread danielblazevski
Github user danielblazevski commented on a diff in the pull request: https://github.com/apache/flink/pull/2368#discussion_r75973261 --- Diff: docs/apis/streaming/windows.md --- @@ -459,42 +459,106 @@ ready for processing. This allows to get the benefit of incremental window compu

[GitHub] flink pull request #2368: [FLINK-3899] Document window processing with Reduc...

2016-08-23 Thread danielblazevski
Github user danielblazevski commented on a diff in the pull request: https://github.com/apache/flink/pull/2368#discussion_r75961552 --- Diff: docs/apis/streaming/windows.md --- @@ -459,42 +459,106 @@ ready for processing. This allows to get the benefit of incremental window compu

[GitHub] flink issue #2368: [FLINK-3899] Document window processing with Reduce/FoldF...

2016-08-23 Thread danielblazevski
Github user danielblazevski commented on the issue: https://github.com/apache/flink/pull/2368 Sorry, indeed, added that when playing around that the open PR to add `FlinkCodyStyle.xml` --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] flink pull request #2368: [FLINK-3899] Document window processing with Reduc...

2016-08-23 Thread danielblazevski
Github user danielblazevski commented on a diff in the pull request: https://github.com/apache/flink/pull/2368#discussion_r75958831 --- Diff: docs/apis/streaming/windows.md --- @@ -459,42 +459,106 @@ ready for processing. This allows to get the benefit of incremental window compu

[GitHub] flink pull request #2368: [FLINK-3899] Document window processing with Reduc...

2016-08-23 Thread danielblazevski
Github user danielblazevski commented on a diff in the pull request: https://github.com/apache/flink/pull/2368#discussion_r75906795 --- Diff: docs/apis/streaming/windows.md --- @@ -459,42 +459,106 @@ ready for processing. This allows to get the benefit of incremental window compu

[GitHub] flink pull request #2368: [FLINK-3899] Document window processing with Reduc...

2016-08-23 Thread danielblazevski
Github user danielblazevski commented on a diff in the pull request: https://github.com/apache/flink/pull/2368#discussion_r75906787 --- Diff: docs/apis/streaming/windows.md --- @@ -459,42 +459,106 @@ ready for processing. This allows to get the benefit of incremental window compu

[GitHub] flink pull request #2368: [FLINK-3899] Document window processing with Reduc...

2016-08-13 Thread danielblazevski
GitHub user danielblazevski opened a pull request: https://github.com/apache/flink/pull/2368 [FLINK-3899] Document window processing with Reduce/FoldFunction + WindowFunction Added example of using Reduce/Fold + Window in docs. The examples were tested to run -- I used the sensor

[GitHub] flink pull request: [FLINK-3996] Add addition, subtraction and multiply by s...

2016-05-31 Thread danielblazevski
Github user danielblazevski commented on a diff in the pull request: https://github.com/apache/flink/pull/2052#discussion_r65170092 --- Diff: flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/SparseVector.scala --- @@ -175,10 +176,21 @@ case class SparseVector

[GitHub] flink pull request: [FLINK-3996] Add addition, subtraction and multiply by s...

2016-05-31 Thread danielblazevski
Github user danielblazevski commented on the pull request: https://github.com/apache/flink/pull/2052 @chiwanpark done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] flink pull request: Added addition, subtraction and multiply by sc...

2016-05-30 Thread danielblazevski
GitHub user danielblazevski opened a pull request: https://github.com/apache/flink/pull/2052 Added addition, subtraction and multiply by scalar to DenseVector.scala and SparseVector.scala Small change to add vector operations. With this small change, can now do things like

[GitHub] flink pull request: [FLINK-3870][docs] Added IntelliJ code style

2016-05-30 Thread danielblazevski
Github user danielblazevski commented on the pull request: https://github.com/apache/flink/pull/1963#issuecomment-222519099 I have IntelliJ IDEA 15.0.1 (community edition) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink pull request: [FLINK-3870][docs] Added IntelliJ code style

2016-05-30 Thread danielblazevski
Github user danielblazevski commented on the pull request: https://github.com/apache/flink/pull/1963#issuecomment-222507327 I tried to use this, but it didn't work for me, see [screenshot](https://www.dropbox.com/s/psrercxcikozjgd/Screenshot%202016-05-30%2010.38.48.png?dl=0)

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2016-05-30 Thread danielblazevski
Github user danielblazevski commented on the pull request: https://github.com/apache/flink/pull/1220#issuecomment-222507122 @chiwanpark the formatting did not work, see [screenshot](https://www.dropbox.com/s/psrercxcikozjgd/Screenshot%202016-05-30%2010.38.48.png?dl=0) in my community

[GitHub] flink pull request: [Flink-1934] Add approximative k-nearest-neigh...

2016-05-30 Thread danielblazevski
Github user danielblazevski commented on the pull request: https://github.com/apache/flink/pull/2050#issuecomment-222500339 @chiwanpark Now it looks good to review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink pull request: [Flink-1934] Add approximative k-nearest-neigh...

2016-05-30 Thread danielblazevski
Github user danielblazevski commented on the pull request: https://github.com/apache/flink/pull/2050#issuecomment-222489771 Not sure why QuadTree.scala and knn.md is added here. These should be identical to what is on apache/master now. --- If your project is set up for it, you can

[GitHub] flink pull request: [Flink-1934] Add approximative k-nearest-neigh...

2016-05-30 Thread danielblazevski
GitHub user danielblazevski opened a pull request: https://github.com/apache/flink/pull/2050 [Flink-1934] Add approximative k-nearest-neighbours (kNN) algorithm to machine learning library I added approximate knn algorithms. In another PR, there are two exact methods, one basic

[GitHub] flink pull request: [Flink-1934] Add approximative k-nearest-neigh...

2016-05-30 Thread danielblazevski
Github user danielblazevski commented on the pull request: https://github.com/apache/flink/pull/2048#issuecomment-222489226 Closing this and making a new PR to avoid conflicts. My guess is that the conflicts are there since I opened the PR initially before the exact KNN PR was

[GitHub] flink pull request: [Flink-1934] Add approximative k-nearest-neigh...

2016-05-30 Thread danielblazevski
Github user danielblazevski closed the pull request at: https://github.com/apache/flink/pull/2048 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] flink pull request: [Flink 1934] Add approximative k-nearest-neigh...

2016-05-30 Thread danielblazevski
GitHub user danielblazevski reopened a pull request: https://github.com/apache/flink/pull/2048 [Flink 1934] Add approximative k-nearest-neighbours (kNN) algorithm to machine learning library I added approximate knn algorithms. In another PR, there are two exact methods, one basic

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2016-05-30 Thread danielblazevski
Github user danielblazevski commented on the pull request: https://github.com/apache/flink/pull/1220#issuecomment-222481628 Thanks @chiwanpark ! I saw that you changed the formatting of the code. Did you automatically do this in IntelliJ? I've been using `cmd + alt + shift +

[GitHub] flink pull request: [Flink 1934] Add approximative k-nearest-neigh...

2016-05-29 Thread danielblazevski
Github user danielblazevski commented on the pull request: https://github.com/apache/flink/pull/2048#issuecomment-222398251 Sounds good, about to close --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink pull request: [Flink 1934] Add approximative k-nearest-neigh...

2016-05-29 Thread danielblazevski
Github user danielblazevski closed the pull request at: https://github.com/apache/flink/pull/2048 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] flink pull request: [Flink 1934] Add approximative k-nearest-neigh...

2016-05-29 Thread danielblazevski
Github user danielblazevski commented on the pull request: https://github.com/apache/flink/pull/2048#issuecomment-222397683 @chiwanpark happy to wait. Should I close and re-open a PR when that's done or just leave this open knowing that it will not begin being reviewed unti

[GitHub] flink pull request: [Flink 1934] Add approximative k-nearest-neigh...

2016-05-29 Thread danielblazevski
Github user danielblazevski commented on the pull request: https://github.com/apache/flink/pull/2048#issuecomment-222390974 btw, not sure what the standards are, should I squash all this into one commit before doing a PR? Or do you occasionally like to see many commits of a PR

[GitHub] flink pull request: [Flink 1934] Add approximative k-nearest-neigh...

2016-05-29 Thread danielblazevski
GitHub user danielblazevski opened a pull request: https://github.com/apache/flink/pull/2048 [Flink 1934] Add approximative k-nearest-neighbours (kNN) algorithm to machine learning library I added approximate knn algorithms. In another PR, there are two exact methods, one basic

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2016-05-19 Thread danielblazevski
Github user danielblazevski commented on a diff in the pull request: https://github.com/apache/flink/pull/1220#discussion_r63882747 --- Diff: flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/nn/KNN.scala --- @@ -0,0 +1,353 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1719] [ml] Add Multinomial Naive Bayes ...

2016-05-18 Thread danielblazevski
Github user danielblazevski commented on the pull request: https://github.com/apache/flink/pull/1156#issuecomment-220201194 Should the input be DataSets of Strings? The documentation, syntax are heavy on the side of dealing exclusively with text classification. Could just be me

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2016-05-18 Thread danielblazevski
Github user danielblazevski commented on the pull request: https://github.com/apache/flink/pull/1220#issuecomment-220047418 Thanks @tillrohrmann, made changes as per your suggestions. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2016-05-18 Thread danielblazevski
Github user danielblazevski commented on a diff in the pull request: https://github.com/apache/flink/pull/1220#discussion_r63714951 --- Diff: flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/nn/QuadTree.scala --- @@ -0,0 +1,352 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2016-05-18 Thread danielblazevski
Github user danielblazevski commented on a diff in the pull request: https://github.com/apache/flink/pull/1220#discussion_r63713235 --- Diff: flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/nn/KNN.scala --- @@ -0,0 +1,354 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2016-05-18 Thread danielblazevski
Github user danielblazevski commented on a diff in the pull request: https://github.com/apache/flink/pull/1220#discussion_r63712701 --- Diff: flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/nn/KNN.scala --- @@ -0,0 +1,354 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2016-05-18 Thread danielblazevski
Github user danielblazevski commented on a diff in the pull request: https://github.com/apache/flink/pull/1220#discussion_r63712405 --- Diff: flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/nn/QuadTree.scala --- @@ -0,0 +1,352 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2016-05-18 Thread danielblazevski
Github user danielblazevski commented on a diff in the pull request: https://github.com/apache/flink/pull/1220#discussion_r63712157 --- Diff: flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/nn/QuadTree.scala --- @@ -0,0 +1,352 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2016-05-18 Thread danielblazevski
Github user danielblazevski commented on a diff in the pull request: https://github.com/apache/flink/pull/1220#discussion_r63712033 --- Diff: flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/nn/QuadTree.scala --- @@ -0,0 +1,352 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2016-05-18 Thread danielblazevski
Github user danielblazevski commented on a diff in the pull request: https://github.com/apache/flink/pull/1220#discussion_r63711829 --- Diff: flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/nn/QuadTree.scala --- @@ -0,0 +1,352 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2016-05-18 Thread danielblazevski
Github user danielblazevski commented on a diff in the pull request: https://github.com/apache/flink/pull/1220#discussion_r63710693 --- Diff: flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/nn/KNN.scala --- @@ -0,0 +1,354 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2016-05-18 Thread danielblazevski
Github user danielblazevski commented on a diff in the pull request: https://github.com/apache/flink/pull/1220#discussion_r63710402 --- Diff: flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/nn/KNN.scala --- @@ -0,0 +1,354 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2016-05-18 Thread danielblazevski
Github user danielblazevski commented on a diff in the pull request: https://github.com/apache/flink/pull/1220#discussion_r63709829 --- Diff: flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/nn/KNN.scala --- @@ -0,0 +1,354 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2016-05-18 Thread danielblazevski
Github user danielblazevski commented on a diff in the pull request: https://github.com/apache/flink/pull/1220#discussion_r63709449 --- Diff: flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/nn/KNN.scala --- @@ -0,0 +1,354 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2016-05-18 Thread danielblazevski
Github user danielblazevski commented on a diff in the pull request: https://github.com/apache/flink/pull/1220#discussion_r63708494 --- Diff: docs/libs/ml/knn.md --- @@ -0,0 +1,145 @@ +--- +mathjax: include +htmlTitle: FlinkML - k-nearest neighbors +title: FlinkML

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2016-05-14 Thread danielblazevski
Github user danielblazevski commented on the pull request: https://github.com/apache/flink/pull/1220#issuecomment-219258096 @chiwanpark thanks! Putting the finishing touches on [approximate](https://github.com/danielblazevski/flink/blob/FLINK-1934/flink-staging/flink-ml/src/main

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2016-04-28 Thread danielblazevski
Github user danielblazevski commented on the pull request: https://github.com/apache/flink/pull/1220#issuecomment-215384494 @chiwanpark Thanks for the comments. I made all the changes except making `makeChildren` private since that is in the `Node` class and is called in the

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2016-04-15 Thread danielblazevski
Github user danielblazevski commented on the pull request: https://github.com/apache/flink/pull/1220#issuecomment-210527093 @tillrohrmann @chiwanpark does the re-basing look OK now? Some of the CI builds didn't go through, 2 passed, 2 failed and 1 timed out (it seems there is

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2016-04-14 Thread danielblazevski
Github user danielblazevski commented on the pull request: https://github.com/apache/flink/pull/1220#issuecomment-209974474 @chiwanpark I added those file, forgot to run a `git add` statement. A couple of other files were added to the `flink-staging` directory, perhaps as a result

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2016-04-08 Thread danielblazevski
Github user danielblazevski commented on the pull request: https://github.com/apache/flink/pull/1220#issuecomment-207685012 @hsaputra I added apache/flink as upstream, namely: `git remote add upstream https://github.com/apache/flink.git` Then I ran what Chiwan above

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2016-03-24 Thread danielblazevski
Github user danielblazevski commented on the pull request: https://github.com/apache/flink/pull/1220#issuecomment-200854252 @tillrohrmann @chiwanpark done, polished up KNN.scala and some minor changes -- e.g. expanding the description of the parameters in the beginning of KNN.scala

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2016-03-23 Thread danielblazevski
Github user danielblazevski commented on the pull request: https://github.com/apache/flink/pull/1220#issuecomment-200480609 @tillrohrmann thanks! I'll polish up knn.md soon --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2016-03-23 Thread danielblazevski
Github user danielblazevski commented on the pull request: https://github.com/apache/flink/pull/1220#issuecomment-200436234 @chiwanpark about the docs, when I look at docs/libs/ml/smv.md for instance (or als.md, etc.), the `parameters` section seems auto-generated, is that correct

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2016-03-15 Thread danielblazevski
Github user danielblazevski commented on the pull request: https://github.com/apache/flink/pull/1220#issuecomment-196879970 @chiwanpark for the docs, it looks like you use an auto-generated markdown file from the source code? i.e. looks like something analogous to `scaladoc

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2016-03-08 Thread danielblazevski
GitHub user danielblazevski reopened a pull request: https://github.com/apache/flink/pull/1220 [FLINK-1745] Add exact k-nearest-neighbours algorithm to machine learning library I added a quadtree data structure for the knn algorithm. @chiwanpark made originally made a pull

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2016-03-08 Thread danielblazevski
Github user danielblazevski closed the pull request at: https://github.com/apache/flink/pull/1220 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2016-03-08 Thread danielblazevski
Github user danielblazevski commented on the pull request: https://github.com/apache/flink/pull/1220#issuecomment-193964375 Hi @chiwanpark, I modified the tests and corrected the package + import statements, please have a look. I will add more details soon --- If your

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2016-02-16 Thread danielblazevski
Github user danielblazevski commented on the pull request: https://github.com/apache/flink/pull/1220#issuecomment-184853357 P.S. about rebasing, need to be careful, something went wrong the first time around. I actually just started working on a new laptop, and started the git repo

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2016-02-16 Thread danielblazevski
Github user danielblazevski commented on the pull request: https://github.com/apache/flink/pull/1220#issuecomment-184847163 Hi @chiwanpark sorry for the delay! I will now have more time to wrap this PR up. I added a check just before calling `knn`: ```scala

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2016-01-24 Thread danielblazevski
Github user danielblazevski commented on a diff in the pull request: https://github.com/apache/flink/pull/1220#discussion_r50647908 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/KNN.scala --- @@ -0,0 +1,340 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2016-01-24 Thread danielblazevski
Github user danielblazevski commented on a diff in the pull request: https://github.com/apache/flink/pull/1220#discussion_r50647792 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/KNN.scala --- @@ -0,0 +1,340 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2016-01-24 Thread danielblazevski
Github user danielblazevski commented on the pull request: https://github.com/apache/flink/pull/1220#issuecomment-174329818 @chiwanpark I see, I thought maybe there was a way to not even use a cross at all. I changed the code according to your suggestion and got an error

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2016-01-13 Thread danielblazevski
Github user danielblazevski commented on the pull request: https://github.com/apache/flink/pull/1220#issuecomment-171277446 Hi @chiwanpark , I agree `cross` is an expensive computation. That part of the code was adopted from your earlier version. Before I try to change it, do you

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2015-12-09 Thread danielblazevski
Github user danielblazevski commented on the pull request: https://github.com/apache/flink/pull/1220#issuecomment-163468550 Fixed the issue @zentol by doing a `git push ... --force`, now only the few files I changed are present (sigh of relief) --- If your project is set up for it

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2015-12-09 Thread danielblazevski
Github user danielblazevski commented on the pull request: https://github.com/apache/flink/pull/1220#issuecomment-163468164 In fact I think this was a bad mistake, and the best option I see is to close this PR and open a new one --- If your project is set up for it, you can

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2015-12-09 Thread danielblazevski
Github user danielblazevski commented on the pull request: https://github.com/apache/flink/pull/1220#issuecomment-163443011 I still have the old laptop, perhaps the best solution is, when I get a chance, to take the 2 files I modified back in that repo, kill this last commit and push

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2015-12-09 Thread danielblazevski
Github user danielblazevski commented on the pull request: https://github.com/apache/flink/pull/1220#issuecomment-163438805 @tillrohrmann and @chiwanpark made changes based on your comments. Also note that I recenly got a new laptop, and I decided to install IntelliJ and download

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2015-12-09 Thread danielblazevski
Github user danielblazevski commented on a diff in the pull request: https://github.com/apache/flink/pull/1220#discussion_r47169693 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/QuadTree.scala --- @@ -0,0 +1,340 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2015-12-09 Thread danielblazevski
Github user danielblazevski commented on a diff in the pull request: https://github.com/apache/flink/pull/1220#discussion_r47168630 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/QuadTree.scala --- @@ -0,0 +1,340 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2015-12-09 Thread danielblazevski
Github user danielblazevski commented on a diff in the pull request: https://github.com/apache/flink/pull/1220#discussion_r47168358 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/QuadTree.scala --- @@ -0,0 +1,340 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2015-12-09 Thread danielblazevski
Github user danielblazevski commented on a diff in the pull request: https://github.com/apache/flink/pull/1220#discussion_r47168128 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/KNN.scala --- @@ -0,0 +1,316 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2015-12-09 Thread danielblazevski
Github user danielblazevski commented on a diff in the pull request: https://github.com/apache/flink/pull/1220#discussion_r47168084 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/KNN.scala --- @@ -0,0 +1,316 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2015-12-09 Thread danielblazevski
Github user danielblazevski commented on a diff in the pull request: https://github.com/apache/flink/pull/1220#discussion_r47167957 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/QuadTree.scala --- @@ -0,0 +1,340 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2015-12-09 Thread danielblazevski
Github user danielblazevski commented on a diff in the pull request: https://github.com/apache/flink/pull/1220#discussion_r47168049 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/KNN.scala --- @@ -0,0 +1,316 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2015-12-09 Thread danielblazevski
Github user danielblazevski commented on a diff in the pull request: https://github.com/apache/flink/pull/1220#discussion_r47167755 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/QuadTree.scala --- @@ -0,0 +1,340 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2015-12-09 Thread danielblazevski
Github user danielblazevski commented on a diff in the pull request: https://github.com/apache/flink/pull/1220#discussion_r47166974 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/QuadTree.scala --- @@ -0,0 +1,340 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2015-12-09 Thread danielblazevski
Github user danielblazevski commented on a diff in the pull request: https://github.com/apache/flink/pull/1220#discussion_r47167003 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/QuadTree.scala --- @@ -0,0 +1,340 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2015-12-09 Thread danielblazevski
Github user danielblazevski commented on a diff in the pull request: https://github.com/apache/flink/pull/1220#discussion_r47166739 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/QuadTree.scala --- @@ -0,0 +1,340 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2015-12-09 Thread danielblazevski
Github user danielblazevski commented on a diff in the pull request: https://github.com/apache/flink/pull/1220#discussion_r47166315 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/QuadTree.scala --- @@ -0,0 +1,340 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2015-12-09 Thread danielblazevski
Github user danielblazevski commented on a diff in the pull request: https://github.com/apache/flink/pull/1220#discussion_r47166308 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/QuadTree.scala --- @@ -0,0 +1,340 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2015-12-09 Thread danielblazevski
Github user danielblazevski commented on a diff in the pull request: https://github.com/apache/flink/pull/1220#discussion_r47166296 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/QuadTree.scala --- @@ -0,0 +1,340 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2015-12-09 Thread danielblazevski
Github user danielblazevski commented on a diff in the pull request: https://github.com/apache/flink/pull/1220#discussion_r47166286 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/QuadTree.scala --- @@ -0,0 +1,340 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2015-12-09 Thread danielblazevski
Github user danielblazevski commented on a diff in the pull request: https://github.com/apache/flink/pull/1220#discussion_r47166252 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/QuadTree.scala --- @@ -0,0 +1,340 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2015-12-09 Thread danielblazevski
Github user danielblazevski commented on a diff in the pull request: https://github.com/apache/flink/pull/1220#discussion_r47166291 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/QuadTree.scala --- @@ -0,0 +1,340 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2015-12-09 Thread danielblazevski
Github user danielblazevski commented on a diff in the pull request: https://github.com/apache/flink/pull/1220#discussion_r47166275 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/KNN.scala --- @@ -0,0 +1,316 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2015-12-09 Thread danielblazevski
Github user danielblazevski commented on a diff in the pull request: https://github.com/apache/flink/pull/1220#discussion_r47166281 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/KNN.scala --- @@ -0,0 +1,316 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2015-12-09 Thread danielblazevski
Github user danielblazevski commented on a diff in the pull request: https://github.com/apache/flink/pull/1220#discussion_r47166215 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/QuadTree.scala --- @@ -0,0 +1,340 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2015-12-09 Thread danielblazevski
Github user danielblazevski commented on a diff in the pull request: https://github.com/apache/flink/pull/1220#discussion_r47166230 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/QuadTree.scala --- @@ -0,0 +1,340 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2015-12-09 Thread danielblazevski
Github user danielblazevski commented on a diff in the pull request: https://github.com/apache/flink/pull/1220#discussion_r47166223 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/QuadTree.scala --- @@ -0,0 +1,340 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2015-12-09 Thread danielblazevski
Github user danielblazevski commented on a diff in the pull request: https://github.com/apache/flink/pull/1220#discussion_r47166187 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/QuadTree.scala --- @@ -0,0 +1,340 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2015-12-09 Thread danielblazevski
Github user danielblazevski commented on a diff in the pull request: https://github.com/apache/flink/pull/1220#discussion_r47166247 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/QuadTree.scala --- @@ -0,0 +1,340 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2015-12-09 Thread danielblazevski
Github user danielblazevski commented on a diff in the pull request: https://github.com/apache/flink/pull/1220#discussion_r47166163 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/QuadTree.scala --- @@ -0,0 +1,340 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2015-12-09 Thread danielblazevski
Github user danielblazevski commented on a diff in the pull request: https://github.com/apache/flink/pull/1220#discussion_r47166203 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/QuadTree.scala --- @@ -0,0 +1,340 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2015-12-09 Thread danielblazevski
Github user danielblazevski commented on a diff in the pull request: https://github.com/apache/flink/pull/1220#discussion_r47166268 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/KNN.scala --- @@ -0,0 +1,316 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2015-12-09 Thread danielblazevski
Github user danielblazevski commented on a diff in the pull request: https://github.com/apache/flink/pull/1220#discussion_r47166181 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/QuadTree.scala --- @@ -0,0 +1,340 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2015-12-09 Thread danielblazevski
Github user danielblazevski commented on a diff in the pull request: https://github.com/apache/flink/pull/1220#discussion_r47166264 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/KNN.scala --- @@ -0,0 +1,316 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2015-12-09 Thread danielblazevski
Github user danielblazevski commented on a diff in the pull request: https://github.com/apache/flink/pull/1220#discussion_r47166220 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/QuadTree.scala --- @@ -0,0 +1,340 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2015-12-09 Thread danielblazevski
Github user danielblazevski commented on a diff in the pull request: https://github.com/apache/flink/pull/1220#discussion_r47166195 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/QuadTree.scala --- @@ -0,0 +1,340 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2015-12-09 Thread danielblazevski
Github user danielblazevski commented on a diff in the pull request: https://github.com/apache/flink/pull/1220#discussion_r47166241 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/QuadTree.scala --- @@ -0,0 +1,340 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2015-12-09 Thread danielblazevski
Github user danielblazevski commented on a diff in the pull request: https://github.com/apache/flink/pull/1220#discussion_r47166199 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/QuadTree.scala --- @@ -0,0 +1,340 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2015-12-09 Thread danielblazevski
Github user danielblazevski commented on a diff in the pull request: https://github.com/apache/flink/pull/1220#discussion_r47166211 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/QuadTree.scala --- @@ -0,0 +1,340 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2015-12-09 Thread danielblazevski
Github user danielblazevski commented on a diff in the pull request: https://github.com/apache/flink/pull/1220#discussion_r47166174 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/nn/QuadTree.scala --- @@ -0,0 +1,340 @@ +/* + * Licensed to the Apache

  1   2   >