[GitHub] flink issue #5346: [FLINK-8490] [mesos] Allow custom docker parameters for d...

2018-01-25 Thread joerg84
Github user joerg84 commented on the issue: https://github.com/apache/flink/pull/5346 @tillrohrmann Could you take a final look? ---

[GitHub] flink pull request #5346: [FLINK-8490] [mesos] Allow custom docker parameter...

2018-01-24 Thread joerg84
Github user joerg84 commented on a diff in the pull request: https://github.com/apache/flink/pull/5346#discussion_r163624908 --- Diff: flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosTaskManagerParameters.java --- @@ -365,6 +386,31 @@ public String

[GitHub] flink pull request #5346: [FLINK-8490] [mesos] Allow custom docker parameter...

2018-01-24 Thread joerg84
Github user joerg84 commented on a diff in the pull request: https://github.com/apache/flink/pull/5346#discussion_r163477722 --- Diff: docs/ops/deployment/mesos.md --- @@ -264,6 +264,8 @@ May be set to -1 to disable this feature

[GitHub] flink pull request #5346: [FLINK-8490] [mesos] Allow custom docker parameter...

2018-01-24 Thread joerg84
Github user joerg84 commented on a diff in the pull request: https://github.com/apache/flink/pull/5346#discussion_r163483150 --- Diff: flink-mesos/src/test/java/org/apache/flink/mesos/runtime/clusterframework/MesosTaskManagerParametersTest.java --- @@ -84,6 +84,35 @@ public void

[GitHub] flink pull request #5346: [FLINK-8490] [mesos] Allow custom docker parameter...

2018-01-24 Thread joerg84
Github user joerg84 commented on a diff in the pull request: https://github.com/apache/flink/pull/5346#discussion_r163477651 --- Diff: docs/ops/config.md --- @@ -508,6 +508,8 @@ May be set to -1 to disable this feature. - `mesos.resourcemanager.tasks.container.volumes

[GitHub] flink pull request #5346: [FLINK-8490] [mesos] Allow custom docker parameter...

2018-01-24 Thread joerg84
Github user joerg84 commented on a diff in the pull request: https://github.com/apache/flink/pull/5346#discussion_r163495632 --- Diff: flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosTaskManagerParameters.java --- @@ -365,6 +386,31 @@ public String

[GitHub] flink issue #5346: [FLINK-8490] [mesos] Allow custom docker parameters for d...

2018-01-23 Thread joerg84
Github user joerg84 commented on the issue: https://github.com/apache/flink/pull/5346 Looks great! I need to test that tomorrow in more detail. @tillrohrmann @EronWright ---

[GitHub] flink pull request #5157: [hotfix] [docs] Consistent capitalization in Mesos...

2017-12-12 Thread joerg84
GitHub user joerg84 opened a pull request: https://github.com/apache/flink/pull/5157 [hotfix] [docs] Consistent capitalization in Mesos documentation. *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community

[GitHub] flink pull request #5033: [FLINK-8102][docs] Fixed formatting issues in Meso...

2017-11-17 Thread joerg84
GitHub user joerg84 opened a pull request: https://github.com/apache/flink/pull/5033 [FLINK-8102][docs] Fixed formatting issues in Mesos documentation. This change fixes formatting issues occurring in the markdown rendering. It was tested was building the documentation locally

[GitHub] flink pull request #3349: Updated DC/OS setup instructions.

2017-02-17 Thread joerg84
GitHub user joerg84 opened a pull request: https://github.com/apache/flink/pull/3349 Updated DC/OS setup instructions. Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your changes take all

[GitHub] flink issue #3093: [FLINK-5444] Made Flink UI links relative.

2017-01-12 Thread joerg84
Github user joerg84 commented on the issue: https://github.com/apache/flink/pull/3093 @sachingoel0101 PTAL --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink pull request #3093: [FLINK-5444] Made Flink UI links relative.

2017-01-12 Thread joerg84
Github user joerg84 commented on a diff in the pull request: https://github.com/apache/flink/pull/3093#discussion_r95783168 --- Diff: flink-runtime-web/web-dashboard/app/scripts/modules/submit/submit.ctrl.coffee --- @@ -167,7 +167,7 @@ angular.module('flinkApp

[GitHub] flink issue #3100: [FLINK-5466] [webfrontend] Set environment to production ...

2017-01-12 Thread joerg84
Github user joerg84 commented on the issue: https://github.com/apache/flink/pull/3100 LGTM, thanks for fixing this! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] flink pull request #3093: [FLINK-5444] Made Flink UI links relative.

2017-01-12 Thread joerg84
Github user joerg84 commented on a diff in the pull request: https://github.com/apache/flink/pull/3093#discussion_r95741031 --- Diff: flink-runtime-web/web-dashboard/app/scripts/modules/submit/submit.ctrl.coffee --- @@ -167,7 +167,7 @@ angular.module('flinkApp

[GitHub] flink issue #3093: [FLINK-5444] Made Flink UI links relative.

2017-01-11 Thread joerg84
Github user joerg84 commented on the issue: https://github.com/apache/flink/pull/3093 Please retest! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink issue #3093: [FLINK-5444] Made Flink UI links relative.

2017-01-11 Thread joerg84
Github user joerg84 commented on the issue: https://github.com/apache/flink/pull/3093 @zentol thanks and yes I verified the expected behavior. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink issue #3093: [FLINK-5444] Made Flink UI links relative.

2017-01-11 Thread joerg84
Github user joerg84 commented on the issue: https://github.com/apache/flink/pull/3093 @zentol Thx! Could you check again? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] flink pull request #3093: [FLINK-5444] Made Flink UI links relative.

2017-01-11 Thread joerg84
GitHub user joerg84 opened a pull request: https://github.com/apache/flink/pull/3093 [FLINK-5444] Made Flink UI links relative. Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your changes