Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2518#discussion_r82215957
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/files/StaticFileServerHandler.java
---
@@ -304,8 +314,15 @@ private void
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2518#discussion_r82214189
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java ---
@@ -544,6 +552,11 @@
public static final String
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2518#discussion_r8650
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobClientSslTest.java
---
@@ -0,0 +1,284 @@
+/*
+ * Licensed to the Apache Software
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2518#discussion_r82214177
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java ---
@@ -178,6 +181,11 @@
public static final String
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2518#discussion_r82213335
--- Diff: docs/setup/security-ssl.md ---
@@ -0,0 +1,139 @@
+---
+title: "SSL Setup"
+nav-parent_id: setup
+
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2518#discussion_r82211062
--- Diff: docs/setup/config.md ---
@@ -181,6 +183,7 @@ The following parameters configure Flink's JobManager
and TaskManagers.
- `taskmanager.hostname`
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2518#discussion_r82211083
--- Diff: docs/setup/config.md ---
@@ -211,6 +214,19 @@ The following parameters configure Flink's JobManager
and TaskManagers.
- `akka.throughput`: N
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2518#discussion_r82230310
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobClientSslTest.java
---
@@ -0,0 +1,284 @@
+/*
+ * Licensed to the Apache Software
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2518#discussion_r82211018
--- Diff: docs/setup/config.md ---
@@ -140,6 +140,8 @@ will be used under the directory specified by
jobmanager.web.tmpdir.
- `blob.server.port`: Port
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2518#discussion_r82211248
--- Diff: docs/setup/config.md ---
@@ -222,6 +238,7 @@ The following parameters configure Flink's JobManager
and TaskMan
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2571
Rebased to latest `flip-6`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2571
Thanks for the comments @KurtYoung. I've updated the PR. No worries, four
eyes always see more than two and it is natural that ideas progress over time :)
---
If your project is set up for it, yo
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2571#discussion_r82157384
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManager.java
---
@@ -136,53 +127,34 @@ public
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2571#discussion_r82156547
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManager.java
---
@@ -416,15 +333,14 @@ private boolean
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2571#discussion_r82155691
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManager.java
---
@@ -205,46 +177,64 @@ public void
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2571#discussion_r82155453
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManager.java
---
@@ -118,9 +109,9 @@ public void
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2589
Thanks for the PR @vijikarthi. The changes look good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2593
Thanks! Merged. Could you close the PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2593#discussion_r82004204
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/StreamSource.java
---
@@ -214,14 +216,24 @@ public
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2571
As discussed in this PR, I've pushed the following changes:
1. Move the slot registration and allocation report to the registration
of the TaskExecutor
2. Let the TaskExe
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2593#discussion_r81947893
--- Diff:
flink-fs-tests/src/test/java/org/apache/flink/hdfstests/ContinuousFileMonitoringTest.java
---
@@ -106,6 +107,155 @@ public static void destroyHDFS
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2593#discussion_r81944208
--- Diff:
flink-fs-tests/src/test/java/org/apache/flink/hdfstests/ContinuousFileMonitoringTest.java
---
@@ -106,6 +107,155 @@ public static void destroyHDFS
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2593#discussion_r81947121
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/StreamSource.java
---
@@ -299,7 +319,7 @@ public void trigger(long
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2593#discussion_r81944138
--- Diff:
flink-fs-tests/src/test/java/org/apache/flink/hdfstests/ContinuousFileMonitoringTest.java
---
@@ -106,6 +107,155 @@ public static void destroyHDFS
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2593#discussion_r81944479
--- Diff:
flink-fs-tests/src/test/java/org/apache/flink/hdfstests/ContinuousFileMonitoringTest.java
---
@@ -106,6 +107,155 @@ public static void destroyHDFS
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2593#discussion_r81944268
--- Diff:
flink-fs-tests/src/test/java/org/apache/flink/hdfstests/ContinuousFileMonitoringTest.java
---
@@ -106,6 +107,155 @@ public static void destroyHDFS
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2593#discussion_r81944676
--- Diff:
flink-fs-tests/src/test/java/org/apache/flink/hdfstests/ContinuousFileMonitoringTest.java
---
@@ -106,6 +107,155 @@ public static void destroyHDFS
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2593#discussion_r81944308
--- Diff:
flink-fs-tests/src/test/java/org/apache/flink/hdfstests/ContinuousFileMonitoringTest.java
---
@@ -106,6 +107,155 @@ public static void destroyHDFS
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2593#discussion_r81944020
--- Diff:
flink-fs-tests/src/test/java/org/apache/flink/hdfstests/ContinuousFileMonitoringTest.java
---
@@ -106,6 +107,155 @@ public static void destroyHDFS
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2593#discussion_r81946646
--- Diff:
flink-fs-tests/src/test/java/org/apache/flink/hdfstests/ContinuousFileMonitoringTest.java
---
@@ -106,6 +107,155 @@ public static void destroyHDFS
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2593#discussion_r81945670
--- Diff:
flink-fs-tests/src/test/java/org/apache/flink/hdfstests/ContinuousFileMonitoringTest.java
---
@@ -106,6 +107,155 @@ public static void destroyHDFS
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2586
Merged to `master` and `release-1.1`.
@uce I also like the symbolic link. I contacted the maintainer of the
plugin because it wouldn't be hard to fix this nowadays with Java 7+ which
sup
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2586
Merging to both branches.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2571
@KurtYoung I see, that makes sense. When the TM looses connection to the
RM, it will eventually be detected by the heartbeating and the list of pending
slot allocation removal requests will be cleared
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/2586
[FLINK-4732] remove maven junction plugin
On Windows, the plugin may download code from the author's web
site. The downloaded file is not signed in the same way as Maven
artifacts from
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2586
CC @uce
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2571
Great to hear that we're on the same page :)
>I think it's no need to stick to the failed slot when the allocation fails
by rpc. Just put it back to the free pool, and give us
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2571
@KurtYoung It is guaranteed that the ResourceManager will receive an RPC
response of some sort. Either a reply from the TaskExecutor, or a timeout/error
which is returned by the future. If the request
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2435#discussion_r81314113
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotProtocolTest.java
---
@@ -43,12 +42,9 @@
import
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2435#discussion_r81313363
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/heartbeat/HeartbeatManagerImpl.java
---
@@ -0,0 +1,328 @@
+/*
+ * Licensed to the Apache
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2435#discussion_r81312934
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/heartbeat/HeartbeatManagerImpl.java
---
@@ -0,0 +1,328 @@
+/*
+ * Licensed to the Apache
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2435#discussion_r81309944
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotProtocolTest.java
---
@@ -43,12 +42,9 @@
import
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2435#discussion_r81310859
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/heartbeat/HeartbeatManagerImpl.java
---
@@ -0,0 +1,328 @@
+/*
+ * Licensed to the Apache
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2571
Thanks for the feedback, @beyond1920 and @KurtYoung.
You're right, the changes don't allow slots to be released by a
TaskExecutor. We can change that by explicitly reporting to the RM
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2571
CC @beyond1920 @KurtYoung
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/2571
[FLINK-4348] Simplify logic of SlotManager
This pull request is split up into two commits:
1. It removes some code from the `SlotManager` to make it simpler.
- It makes use of
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2565#discussion_r81134995
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java
---
@@ -457,14 +505,94 @@ public Acknowledge
updateTaskExecutionState
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2565#discussion_r81135329
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java
---
@@ -457,14 +505,94 @@ public Acknowledge
updateTaskExecutionState
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2435
Could you rebase this again? I think we should merge this soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2548
That's a good point @greghogan. We don't have a standard way to print a
usage message. A disadvantage of the approach in this PR is that we will
display an error message which might actuall
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2561
Merged to `flip-6`. Let me know if you have any comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mxm closed the pull request at:
https://github.com/apache/flink/pull/2561
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2540
This has been merged. Thank you. Could you close the PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/2561
[FLINK-4703] RpcCompletenessTest: Add support for type arguments and
subclasses
This is a prerequisite for merging #2540 which relies on the class
hierarchy features.
You can merge this pull request
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2540#discussion_r80663028
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
---
@@ -324,6 +337,158 @@ public void handleError(final
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2540#discussion_r80642652
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
---
@@ -66,15 +67,16 @@
* {@link #requestSlot
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2540
Thank you for your changes. I'm trying to incorporate them in `flip-6` now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2540#discussion_r80478098
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
---
@@ -66,15 +67,16 @@
* {@link #requestSlot
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2540#discussion_r80473835
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
---
@@ -66,15 +67,16 @@
* {@link #requestSlot
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2549#discussion_r80472617
--- Diff: pom.xml ---
@@ -1081,6 +1081,15 @@ under the License
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2549#discussion_r80472473
--- Diff: pom.xml ---
@@ -1081,6 +1081,15 @@ under the License
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2549
Looks good! +1 to merge when the tests have passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/2548
[FLINK-4677] fail if user jar contains no executions
If the user has an empty main method with no Flink executions, this will
print a nicer error message.
You can merge this pull request into a Git
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2524#discussion_r80441549
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobClient/JobClientUtils.java
---
@@ -0,0 +1,257 @@
+/*
+ * Licensed to the Apache
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2434
+1 Looks like a sensible change. Looking forward to fixing the
`ContinuousFileReaderOperator`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2499
Merging after tests pass.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2499
This needed another fix because in some tests we use the system class
loader instead of a class loader instantiated by the BlobLibraryCacheManager.
If we close that one, we cause tests to fail. The
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2451
This has been merged to `flip-6`. Could you please close the PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2479
This has been merged to `flip-6`. Could you please close the PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2479
Thank you for the pull request! I've rebased the changes and will merge
them to the master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2451
Thank you for the pull request! I've rebased the changes and will merge
them to the master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2531
+1 Looks good!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2524
Thanks for the PR @beyond1920. We just rebased the flip-6 branch. Could you
rebase the PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2472#discussion_r79656257
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/concurrent/Future.java ---
@@ -0,0 +1,156 @@
+/*
+ * Licensed to the Apache Software
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2514
Actually, I have written a much better test case for this some time ago,
see
https://github.com/apache/flink/blob/142912b031df42d2abe43b41e98be5596cb3a7f9/flink-runtime/src/test/java/org/apache/flink
Github user mxm closed the pull request at:
https://github.com/apache/flink/pull/640
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/640
While this may provide some help for future implementations, the code is
outdated and needs an overhaul. Closing for now.
---
If your project is set up for it, you can reply to this email and have your
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2472#discussion_r79597647
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/concurrent/Future.java ---
@@ -0,0 +1,156 @@
+/*
+ * Licensed to the Apache Software
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2472#discussion_r79599026
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/concurrent/Future.java ---
@@ -0,0 +1,156 @@
+/*
+ * Licensed to the Apache Software
Github user mxm closed the pull request at:
https://github.com/apache/flink/pull/2463
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2463
Merged to continue development in other places. Thanks for the comments!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2275
Tests seem to pass on my Travis. Running some more tests to ensure
everything is running smoothly. Thank you for bearing with me!
---
If your project is set up for it, you can reply to this email and
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/2514
[FLINK-4555] add test case to test Yarn cluster shutdown
In the first commit, it ensures that the cluster shutdown is working as
expected.
In a second commit, it gives the ResourceManager more
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r79355845
--- Diff:
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/SecureTestEnvironment.java
---
@@ -0,0 +1,249
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r79355618
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -460,9 +463,27 @@ public static void runInteractiveCli
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r79355653
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnTaskManagerRunner.java ---
@@ -75,34 +85,66 @@ public static void runYarnTaskManager(String[] args
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r79355820
--- Diff:
flink-streaming-connectors/flink-connector-filesystem/src/test/java/org/apache/flink/streaming/connectors/fs/RollingSinkSecuredITCase.java
---
@@ -0,0
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r79355908
--- Diff:
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/SecureTestEnvironment.java
---
@@ -0,0 +1,249
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r79355451
--- Diff: pom.xml ---
@@ -107,6 +107,13 @@ under the License.
2.7.4
3.1.0
4.11
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r79377160
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/security/SecurityContext.java
---
@@ -0,0 +1,313 @@
+/*
+ * Licensed to the Apache
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r79355282
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -523,6 +544,7 @@ public YarnClusterClient createCluster(String
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r79356049
--- Diff:
flink-yarn-tests/src/test/java/org/apache/flink/yarn/YarnTestBase.java ---
@@ -374,7 +409,39 @@ public static void startYARNWithConfig(Configuration
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2149#discussion_r79157764
--- Diff: docs/apis/cli.md ---
@@ -187,6 +187,8 @@ Action "run" compiles and runs
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2149#discussion_r79157293
--- Diff: docs/apis/cli.md ---
@@ -187,6 +187,8 @@ Action "run" compiles and runs
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2149#discussion_r79156877
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontendParser.java
---
@@ -241,8 +255,11 @@ private static Options
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r79153661
--- Diff:
flink-streaming-connectors/flink-connector-kafka-0.9/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestEnvironmentImpl.java
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r79155885
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/security/SecurityContext.java
---
@@ -158,22 +157,37 @@ public static void install
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r79153742
--- Diff:
flink-streaming-connectors/flink-connector-kafka-0.9/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestEnvironmentImpl.java
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r79153795
--- Diff:
flink-streaming-connectors/flink-connector-kafka-0.9/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestEnvironmentImpl.java
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r79152436
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/security/SecurityContext.java
---
@@ -79,9 +82,8 @@ public static void install
301 - 400 of 1927 matches
Mail list logo
