Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/5879#discussion_r183980094
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/leaderretrieval/ZooKeeperLeaderRetrievalService.java
---
@@ -100,6 +100,12 @@ public void
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/5879#discussion_r183979668
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/leaderretrieval/ZooKeeperLeaderRetrievalService.java
---
@@ -100,6 +100,12 @@ public void
Github user sihuazhou closed the pull request at:
https://github.com/apache/flink/pull/5854
---
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5854
@zentol thanks, closing.
---
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5881
+1 to wait for @tillrohrmann
---
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5881
@GJL I also noticed that this PR can only solve part of the problem...it
can only make sure that the `TM` is registered with ResourceManager properly,
but it can't make sure that the `TM`
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5899
Hi @bitsilly thanks for the works. I think maybe it better to describe your
purpose of this PR and link with the corresponding JIRA(if this is not a
hotfix). There is a guide template when you
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5879
Hi @zentol I updated the PR, it's already for another review.
---
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5879
@zentol Thanks for you reply, I prefer the way to introduce a
`ExpectedLifecycleException`, I think maybe it could be used in some other
places in the future. Addressing this...
---
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5881
Ah, failed on travis, but it is not related to this PR, it's a bug that
should be addressed and there is already a PR for it
https://github.com/apache/flink/pull/5886
---
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5886
another instance https://travis-ci.org/apache/flink/jobs/369925642...
---
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/5881#discussion_r183269424
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java ---
@@ -265,6 +272,29 @@ protected void initialize() throws
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5881
Hi @GJL! Thanks for your nice reviews, I will address the comments you left
ASAP, but some of them I could't catch up properly, looking forward your reply.
---
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/5881#discussion_r183267016
--- Diff:
flink-yarn/src/test/java/org/apache/flink/yarn/YarnResourceManagerTest.java ---
@@ -388,4 +390,108 @@ public void testStopWorker() throws
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/5881#discussion_r183265947
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java ---
@@ -356,17 +395,25 @@ public void onContainersAllocated(List
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/5881#discussion_r183265730
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java ---
@@ -265,6 +272,29 @@ protected void initialize() throws
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/5881#discussion_r183265708
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java ---
@@ -114,6 +118,9 @@
private final Map
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5886
cc @zentol
---
GitHub user sihuazhou opened a pull request:
https://github.com/apache/flink/pull/5886
[FLINK-9230][test] harden WebFrontendITCase#testStopYarn()
## What is the purpose of the change
This PR aim to harden `WebFrontendITCase#testStopYarn()`.
## Brief change log
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5854
Could anyone have a look at this?
---
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5880
+1, Will this PR also get into 1.4.x?
---
GitHub user sihuazhou opened a pull request:
https://github.com/apache/flink/pull/5881
[FLINK-9190][yarn] fix YarnResourceManager sometimes does not request new
Containers
## What is the purpose of the change
This PR fixes the problem that `YarnResourceManager` does not
GitHub user sihuazhou opened a pull request:
https://github.com/apache/flink/pull/5879
[FLINK-9215][resoucemanager] Only log the exception when log level is TRACE
to avoid confusing
## What is the purpose of the change
This PR fix the log in `SlotPool#releaseSlot()` to
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5825
closing this cause I think this maybe a no-issue.
---
Github user sihuazhou closed the pull request at:
https://github.com/apache/flink/pull/5825
---
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5854
CC: @tillrohrmann
---
GitHub user sihuazhou opened a pull request:
https://github.com/apache/flink/pull/5854
[FLINK-8793][REST] hidden key containing "secret" in web interface.
## What is the purpose of the change
Currently, we going in /jobmanager/config on the web interface, the val
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5847
Hi, @StephanEwen could you please have a look at this? If you think this is
a a non-issue, I'd like to close this. (sorry for pinging you here, it because
I saw your some comments
GitHub user sihuazhou opened a pull request:
https://github.com/apache/flink/pull/5847
[FLINK-9174][datastream]Fix the type of state created in
ProccessWindowFunction.proccess() is inconsistency
## What is the purpose of the change
This PR fixes the type of state created
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/5676#discussion_r181540905
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/TaskInfo.java ---
@@ -107,4 +131,12 @@ public int getAttemptNumber() {
public
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5839
CC: @tillrohrmann
---
GitHub user sihuazhou opened a pull request:
https://github.com/apache/flink/pull/5839
[FLINK-9158][Distributed Coordination] Set default
FixedRestartDelayStrategy delay to 0s.
## What is the purpose of the change
Set default FixedRestartDelayStrategy delay to 0s
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5825
I only fix the javadoc for `JobVertex#setMaxParallelism()`, because if we
validate `maxParallism` in that function we will break some current code, and
I'am not sure whether these code also
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5825
CC: @zentol
---
GitHub user sihuazhou opened a pull request:
https://github.com/apache/flink/pull/5825
[FLINK-9040][local runtime] check maxParallelism in
JobVertex#setMaxParallelism()
## What is the purpose of the change
this PR performs `maxParallelism` checking in
`JobVertex
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5705
Hi, @StefanRRichter thanks a lot.
---
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5783
CC: @tillrohrmann
---
GitHub user sihuazhou opened a pull request:
https://github.com/apache/flink/pull/5783
[FLINK-9081][test] Harden ResourceManagerTaskExecutorTest
## What is the purpose of the change
Currently, `heartbeatTimeout` is 5, it's too small, s
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5781
Thanks a lot for you reply, closing this PR since it's invalid.
---
Github user sihuazhou closed the pull request at:
https://github.com/apache/flink/pull/5781
---
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5705
Hi @tillrohrmann thanks for your reply, and god bless Stefan, hope he will
get well soon...
---
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5705
Could anyone have a look at this PR?
---
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5781
Hi @tillrohrmann , it's a bit sticky, do you have any idea for the current
situation? That is when we submit a job and it's parallelism exceeds the max
slots of the fixed cluster, we ha
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5781
Hi @tillrohrmann you are right that seems to be impossible...but I think
maybe we should at lest fail the job immediately when the job's parallelism
exceeds the max slots of the fixed cl
GitHub user sihuazhou opened a pull request:
https://github.com/apache/flink/pull/5781
[FLINK-9102][FLIP6] disable queued scheduling for JobGraph in
Flip6LocalStreamEnvironment
## What is the purpose of the change
When we start cluster locally with fixed TMS and build
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5781
CC: @tillrohrmann
---
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5751
Hi @kl0u ! I have changed the code, could you please have a look when you
have time?
---
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5751
@kl0u Got it! Addressing ...
---
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5751
Hi @kl0u , do you have any idea now? Or we can just buffer the keys in to a
`list` in `applyToAllKeys()`, I think it also seems not like a bad choice. :)
---
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5751
Hi @kl0u , I have changed the code to meet the comments on JIRA, but
unfortunately, I found some case that could make the situation a bit complex
with that architecture, that is maybe the
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5751
@kl0u Got it! Addressing...
---
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5751
Hi @kl0u I changed a bit of the implementation of JIRA, instead of
implement multi wrapper classes for different `State`, I introduce a
`StateInvocationHandler` which implemented
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5734
Hi @tillrohrmann could you please have a look at this PR?
---
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5751
CC: @aljoscha @StefanRRichter
---
GitHub user sihuazhou opened a pull request:
https://github.com/apache/flink/pull/5751
[FLINK-9060][state] Deleting state using KeyedStateBackend.getKeys() throws
Exception
## What is the purpose of the change
This PR fixes the problem when deleting state using
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5746
Thanks for your reply ;)
---
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5746
please just ignore my question...
---
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5746
Hi @tillrohrmann there is one question I want ask about this PR, is it
means that in HA mode we can't tolerant jobs partial broken?
---
Github user sihuazhou closed the pull request at:
https://github.com/apache/flink/pull/5696
---
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/5735#discussion_r176099599
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/state/FoldingStateDescriptor.java
---
@@ -72,7 +72,7 @@ public FoldingStateDescriptor
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/5735#discussion_r176099684
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/state/FoldingStateDescriptor.java
---
@@ -89,7 +89,7 @@ public FoldingStateDescriptor
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/5735#discussion_r176099489
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/state/FoldingStateDescriptor.java
---
@@ -55,7 +55,7 @@
* @param typeClass The
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5734
CC: @zentol I've addressed your comments and Travis given green light,
could you please have a look again?
---
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5705
Hi @tillrohrmann could you please have a look at this? This PR covers multi
bugs that should be addressed...I think maybe stefan is too busy with the
testing works on 1.5 currently...
---
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/5734#discussion_r176029020
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
---
@@ -292,6 +292,13 @@ public void start() throws
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5734
CC: @tillrohrmann
---
GitHub user sihuazhou opened a pull request:
https://github.com/apache/flink/pull/5734
[FLINK-9026][Metrics] Close the TaskManagerMetricGroup when the
TaskExecutor is shut down
## What is the purpose of the change
We should close the `TaskManagerMetricGroup` when the
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/5732#discussion_r175983599
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/state/StateDescriptor.java
---
@@ -77,18 +80,22 @@
/** The serializer for
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5716
Strange...the Travis failed and the failed is related to
`YarnClusterDescriptorTest`, but it seems not related to this PR...
---
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5726
...found a checkstyle bug in my local built, I made a fixup.
---
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5716
Hi @tillrohrmann I think maybe stefan is too busy with the testing work for
1.5 currently, could you please have a look at this? This is obvious bug that
need to be addressed.
---
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5726
@tillrohrmann I have addressed your comments, could you please review it
again.
---
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/5726#discussion_r175772251
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
---
@@ -409,6 +411,12 @@ public void terminateCluster
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5726
@tillrohrmann I made a fixup according to your comments, could you please
have a look again?
---
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/5726#discussion_r175715354
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -476,6 +477,11 @@ public ApplicationId getClusterId
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5726
CC: @tillrohrmann
---
GitHub user sihuazhou opened a pull request:
https://github.com/apache/flink/pull/5726
[FLINK-FLINK-9028][flip6] perform parameters checking before starting
cluster
## What is the purpose of the change
Perform parameters checking before starting cluster to prevent to setup
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/5691#discussion_r175640731
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/internal/InternalQueryableKvState.java
---
@@ -16,46 +16,42 @@
* limitations
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5716
@StefanRRichter Could you please have a look at this? I think this should
be fixed for 1.5.
---
GitHub user sihuazhou opened a pull request:
https://github.com/apache/flink/pull/5716
[FLINK-9022][state] fix resource release in
StreamTaskStateInitializerImpl.streamOperatorStateContext()
## What is the purpose of the change
This PR fixes the bug in
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5705
I made a fixup for some additional minor bug in
`RocksDBStateBackendConfigTest.java`.
---
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5705
@StefanRRichter I have updated the code, could you please have a look...
---
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5705
@StefanRRichter Sorry for pinging you again in this PR, but I found there
maybe be another issue for `full checkpoint`. It's about the
`kvStateInformation`, we should create a deep co
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5705
@StefanRRichter Could you please have a look at this?
---
GitHub user sihuazhou opened a pull request:
https://github.com/apache/flink/pull/5705
[FLINK-8968][state]Fix native resource leak caused by ReadOptions
## What is the purpose of the change
This PR fixes
(FLINK-8968)[https://issues.apache.org/jira/browse/FLINK-8968] Pull
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5696
@zentol Could you please have a look at this?
---
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5650
@bowenli86 Thanks a lot for you reviews, I've addressed all your comments,
I'm waiting the 1.5 to be released, after that maybe @StefanRRichter could also
have a look at this.
---
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/5650#discussion_r174479455
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBWriteBatchWrapperTest.java
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/5650#discussion_r174479415
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBWriteBatchWrapperTest.java
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/5650#discussion_r174479344
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBWriteBatchWrapperTest.java
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/5650#discussion_r174479322
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBWriteBatchWrapperTest.java
GitHub user sihuazhou opened a pull request:
https://github.com/apache/flink/pull/5696
[hotfix][flip6] fix doc of SlotProvider.allocateSlot()
## What is the purpose of the change
fix doc of SlotProvider.allocateSlot()
## Brief change log
- fix doc of
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/5676#discussion_r174338580
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/BackendRestorerProcedure.java
---
@@ -105,6 +105,8 @@ public T
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/5676#discussion_r174165460
--- Diff:
flink-end-to-end-tests/src/main/java/org/apache/flink/streaming/tests/StickyAllocationAndLocalRecoveryTestJob.java
---
@@ -0,0 +1,450
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/5676#discussion_r174175230
--- Diff:
flink-end-to-end-tests/src/main/java/org/apache/flink/streaming/tests/StickyAllocationAndLocalRecoveryTestJob.java
---
@@ -0,0 +1,450
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5682
@StefanRRichter Could you please have a look at this? It's not the reason
why `segfault` occur in `FLINK-8922`, but the `Checkpoint` created from RocksDB
is also a native resources need
GitHub user sihuazhou opened a pull request:
https://github.com/apache/flink/pull/5682
[FLINK-8927][state] Eagerly release the checkpoint object created from
RocksDB
## What is the purpose of the change
This PR addresses
[FLINK-8927](https://issues.apache.org/jira/browse
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/5650#discussion_r173049537
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBWriteBatchWrapper.java
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/5650#discussion_r173048763
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBWriteBatchWrapper.java
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/5650#discussion_r173048697
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBWriteBatchWrapper.java
301 - 400 of 536 matches
Mail list logo
