Github user uce commented on the issue:
https://github.com/apache/flink/pull/2113
Thanks! Looks good to merge. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2141
Thank you for this PR. I will try to look into it next week. I think we
should wait for the 1.1 release before we merge this though.
---
If your project is set up for it, you can reply to this email
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2113
Changes look good, but did you skip the `CombiningUnilateralSortMerger` on
purpose?
It's hard to tell, because the `handleLargeRecords` argument was existing
before your changes, but it wa
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2116
Looks very good! Thanks. The build failure is unrelated. I'll merge this
after you address the inline comments.
---
If your project is set up for it, you can reply to this email and have your
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2116#discussion_r67514718
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/javaApiOperators/CoGroupITCase.java
---
@@ -334,6 +335,124 @@ public void
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2116#discussion_r67514396
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/javaApiOperators/CoGroupITCase.java
---
@@ -334,6 +335,124 @@ public void
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2083
Full ack, but the problem is not just RocksDB, but also savepoints, which
reference a user class in the state descriptor, including FS snapshots. So if
you configure a file backend and use folding or
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2069
Thanks for the review Fabian. I've addressed all comments except the
ObjectMapper configuration. The EvenTimeTableSource makes sense. We can make
the Kafka source extend from that one later on. D
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2069#discussion_r66606860
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaJsonTableSource.java
---
@@ -0,0
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2069#discussion_r66606216
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaConsumerTestBase.java
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2069#discussion_r66606072
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSource.java
---
@@ -0,0
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2069#discussion_r66606127
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/util/serialization/JsonRowDeserializationSchema.java
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2087
Travis passed, I'm going to merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
en
GitHub user uce opened a pull request:
https://github.com/apache/flink/pull/2087
[hotfix] [streaming-java] Harden IterateTest
Adds retries and timeout scaling to all iteration tests, which rely on
iteration timeouts. The way the tests rely on these timoeuts is prone to races.
If
GitHub user uce opened a pull request:
https://github.com/apache/flink/pull/2083
[FLINK-3713] [clients, runtime] Use user code class loader when disposing
savepoints
Disposing savepoints via the JobManager fails for state handles or
descriptors, which contain user classes (for
Github user uce commented on the pull request:
https://github.com/apache/flink/commit/0cf04108f70375d41ebb7c39629db3a081bd2876#commitcomment-17784955
Just noticed that `SubtaskState` cleanup only catches and logs exceptions
(`TaskForState` before, too). Does anyone recall what the
GitHub user uce opened a pull request:
https://github.com/apache/flink/pull/2069
[FLINK-3872] [table, connector-kafka] Add KafkaJsonTableSource
Adds `StreamTableSource` variants for Kafka with syntactic sugar for
parsing JSON streams.
```java
KafkaJsonTableSource
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/2051#issuecomment-222625496
1. I think that you are very much looking at it with your specific use case
in mind, which is (I think) querying other operators from within your
operators. To me, that&#
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2040#discussion_r65138587
--- Diff: docs/build_docs.sh ---
@@ -54,7 +54,7 @@ JEKYLL_CMD="build"
while getopts ":p" opt; do
case $opt
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2040#discussion_r65107320
--- Diff: docs/build_docs.sh ---
@@ -54,7 +54,7 @@ JEKYLL_CMD="build"
while getopts ":p" opt; do
case $opt
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/2033#issuecomment-222557049
Just retried this. Works as expected. +1 to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/2051#issuecomment-222554801
Hey Gyula!
The `QueryableStateStream` is only for convenience. It's just a creating a
`AbstractQueryableStateOperator`, which takes care of setting up an ope
GitHub user uce opened a pull request:
https://github.com/apache/flink/pull/2051
[FLINK-3779] Add support for queryable state
First of all, thanks to @tillrohrmann, @aljoscha, and @StephanEwen for
discussions during and before implementing this first version. The initial
design
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/2033#issuecomment-222171685
`-p` didn't work, talked to Max offline. After the fix +1 to merge. Very
nice change!
---
If your project is set up for it, you can reply to this email and have your
GitHub user uce opened a pull request:
https://github.com/apache/flink/pull/1964
[FLINK-3860] [connector-wikiedits] Add retry loop to
WikipediaEditsSourceTest
Add a retry loop to `WikipediaEditsSourceTest` and checks connection to IRC
server before running the test. The test is
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1947#discussion_r61555221
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -924,6 +936,15 @@ class TaskManager(
else
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1947#discussion_r61555065
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -152,6 +154,9 @@ class TaskManager(
/** Registry of
Github user uce commented on the pull request:
https://github.com/apache/flink/commit/1ccc798914a2bd94157f2a86f7961bc1cc5de490#commitcomment-17256873
Can we add this to release-1.0 as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user uce commented on the pull request:
https://github.com/apache/flink/commit/879bb1bb029ed37e33adc7a655328940135cfcb3#commitcomment-17254739
Should we add this to `release-1.0` as well?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1883#issuecomment-214686210
Yes, it was introduced to give detailed error message, which were helpful
in the past. We can certainly consolidate this.
---
If your project is set up for it, you can
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1927#issuecomment-214665070
Test failures are unrelated and I have two successful runs in my local
Travis: https://travis-ci.org/uce/flink/builds/125561984,
https://travis-ci.org/uce/flink/builds
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1668#issuecomment-214339200
Sounds like a reasonable approach Paris! Just ping here after you addressed
1. and 2.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1890#issuecomment-214338353
I like this Chesnay. Definitely makes the tests more readable. Feel free to
merge it if more people think this is useful.
---
If your project is set up for it, you can
GitHub user uce opened a pull request:
https://github.com/apache/flink/pull/1927
[FLINK-3803] [runtime] Pass CheckpointStatsTracker to ExecutionGraph
`CheckpointStatsTracker` was instantiated in
`ExecutionGraph#enableSnapshotCheckpointing`, where the Flink configuration is
not
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1883#issuecomment-214293767
Very nice, Till! I like where this is going and am really looking forward
to the follow up changes.
As this is work in progress, the most important changes are in
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1883#discussion_r60903817
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/StateForTask.java
---
@@ -131,11 +108,13 @@ else if (o instanceof StateForTask
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1883#discussion_r60903617
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/PendingCheckpoint.java
---
@@ -130,7 +134,8 @@ public CompletedCheckpoint
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1883#discussion_r60903497
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CompletedCheckpoint.java
---
@@ -74,20 +77,56 @@ public long getDuration
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1883#discussion_r60903230
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
---
@@ -781,43 +803,69 @@ public boolean
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1883#discussion_r60903126
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
---
@@ -640,15 +650,27 @@ public boolean
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1914#issuecomment-214224340
Good catch! +1 to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1904#issuecomment-214224099
Changes look good! +1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1904#discussion_r60883547
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/RemoteEnvironment.java ---
@@ -133,26 +137,31 @@ public RemoteEnvironment(String host, int port
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1752#issuecomment-214213267
Thanks, Till! I think this is ready to finally be merged. I will go ahead
and do it.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1923#issuecomment-214211890
The build fails with timeouts while waiting for the TMs to connect again.
This is weird as the changes look unrelated to this. Do you have an idea what
this might be
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1923#issuecomment-213288408
Good fix, Till! Changes look good, +1 to merge soon for 1.0.3.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user uce commented on the pull request:
https://github.com/apache/flink/commit/7462a5bfd7cb2dafbbc9eb02a43d3db9f6add30e#commitcomment-17165776
Can you push this to `release-1.0` as well to have it in 1.0.3 or the next
1.0.2 RC?
---
If your project is set up for it, you can
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1910#discussion_r60224497
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducer.java
---
@@ -0,0
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1910#issuecomment-211847621
Great addition to have a producer to Kinesis. The changes look good
overall, I had some minor inline comments.
The main concern is that we can only test this with a
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1910#discussion_r60206929
--- Diff: docs/apis/streaming/connectors/kinesis.md ---
@@ -0,0 +1,92 @@
+---
+title: "Amazon AWS Kinesis Streams Connector"
+
+#
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1910#discussion_r60206857
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducer.java
---
@@ -0,0
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1910#discussion_r60206533
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducer.java
---
@@ -0,0
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1910#discussion_r60205881
--- Diff: flink-streaming-connectors/flink-connector-twitter/pom.xml ---
@@ -35,6 +35,11 @@ under the License.
jar
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1910#discussion_r60205778
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducer.java
---
@@ -0,0
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1910#discussion_r60205005
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducer.java
---
@@ -0,0
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1910#discussion_r60204721
--- Diff: flink-streaming-connectors/flink-connector-twitter/pom.xml ---
@@ -35,6 +35,11 @@ under the License.
jar
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1910#discussion_r60204401
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/examples/ProduceIntoKinesis.java
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1910#discussion_r60204277
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/KinesisSerializationSchema.java
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1910#discussion_r60203894
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducer.java
---
@@ -0,0
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1910#discussion_r60202074
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducer.java
---
@@ -0,0
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1905#issuecomment-211784417
Thank you for this great contributio! I think that CEP and a concise Scala
API go very well together. :-) I'm not a Scala expert, but I'll also have a
look later
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1906#issuecomment-211783962
Changes look good to me. +1 to merge (I did not try it out though).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1906#discussion_r60187361
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/RemoteStreamEnvironment.java
---
@@ -90,7 +90,7 @@ public
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1906#discussion_r60187290
--- Diff:
flink-scala-shell/src/main/scala/org/apache/flink/api/scala/FlinkILoop.scala ---
@@ -72,7 +72,12 @@ class FlinkILoop(
// create our
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1908#issuecomment-211782356
Thanks for the contribution! I had an inline comment. If that's fixed, this
looks good.
---
If your project is set up for it, you can reply to this email and have
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1908#discussion_r60186786
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobCache.java ---
@@ -200,10 +200,14 @@ public void delete(BlobKey key) throws IOException
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1884#issuecomment-209891907
I think you used the wrong JIRA issue ID.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1794#issuecomment-208381444
Thanks, Chesnay! Can you merge this to `master`? :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1858#issuecomment-208313033
Merging this together with #1817.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1794#discussion_r59193164
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinatorTest.java
---
@@ -1066,26 +1069,23 @@ public Void answer
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1794#discussion_r59193042
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinatorTest.java
---
@@ -1066,26 +1069,23 @@ public Void answer
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1854#issuecomment-208308210
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1863#issuecomment-208266436
Could you please merge this to `release-1.0` as well? (BTW you didn't close
the JIRA issue yet.)
---
If your project is set up for it, you can reply to this email and
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1853#issuecomment-206299884
+1.
I know of some other places where I've used Guava's Hasher or Cache, which
we can also remove in order to be able to remove our Guava dependency.
-
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1850#issuecomment-205402626
Would you mind triggering a few builds over night?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user uce commented on the pull request:
https://github.com/apache/flink/commit/76968c6360c17d5deb4e42727c16bc1b9a891b26#commitcomment-16955170
Can you please cherrypick this to `release-1.0` as well?
---
If your project is set up for it, you can reply to this email and have
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1850#issuecomment-205359909
Should we add this for `1.0.2` (or `1.0.1` if the RC gets cancelled)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1780#issuecomment-205319812
Just rebased. Waiting for Travis and then merging to `master` and
`release-1.0`.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1829#issuecomment-204931011
@smarthi I think it's not too specific at all since its part of
`DataSetUtils` and not `DataSet`. Let's merge the changes to master for `1.1`.
---
If your proj
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1837#issuecomment-204309933
Yes, I'm going to merge it later today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1842#issuecomment-203854053
+1 to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1837#discussion_r57955999
--- Diff: docs/setup/config.md ---
@@ -275,6 +275,10 @@ For example when running Flink on YARN on an
environment with a restrictive fire
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1841#issuecomment-203513525
Till's local Travis passed
(https://travis-ci.org/tillrohrmann/flink/builds/119528848) with one unrelated
failing build. I'm going to merge this.
---
If your
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1840#issuecomment-203494813
Till's local Travis passed
(https://travis-ci.org/tillrohrmann/flink/builds/119523927). I'm going to merge
this.
---
If your project is set up for it, you ca
Github user uce commented on the pull request:
https://github.com/apache/flink/commit/ce448cdbdd301585b0faea4fe4c920856ee37818#commitcomment-16897467
Did not add this to `master` yet as the ASF might support `rsync` for
`home.apache.org` again until `1.1`...
---
If your project is
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1837#discussion_r57900813
--- Diff: docs/setup/config.md ---
@@ -275,6 +275,10 @@ For example when running Flink on YARN on an
environment with a restrictive fire
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1840#issuecomment-203465710
Looks like a nice generalization of the iterable and collector cases. Good
that you did not introduce a `hasMap` ;-)
+1 to merge to `master` and `release-1.0` after
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1840#discussion_r57898915
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/TypeExtractor.java
---
@@ -291,12 +347,15 @@ protected TypeExtractor
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1841#issuecomment-203456547
Good catch! +1 to merge to `master` and `release-1.0`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1830#issuecomment-203004909
I'm going to merge this to `master` and `release-1.0`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1830#issuecomment-202794232
OK, depending on whether it is feasible to test this separately, I would go
ahead and merge it as is or add a test and merge then. :+1:
---
If your project is set up for
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1668#discussion_r57327419
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamIterationHead.java
---
@@ -17,43 +17,80 @@
package
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1668#discussion_r57321347
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
---
@@ -450,112 +450,121 @@ else if (operator != null
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1668#discussion_r57320231
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
---
@@ -450,112 +450,121 @@ else if (operator != null
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1668#discussion_r57319737
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
---
@@ -450,112 +450,121 @@ else if (operator != null
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1818#issuecomment-200830880
The other programs that are executed in `ClassLoaderITCase` are contained
in the `org.apache.flink.test.classloading.jar` package (search for
`KMeansForTest` for example
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1829#issuecomment-200803091
As a side note (I didn't look at the code changes): We can't rename the
method name for `1.0.1` as `DataSetUtils` is annotated with `PublicEvolving`,
meaning t
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1818#issuecomment-200802077
The changes look good and make parts where user code is serialized very
clear. :+1:
I've verified that the `ScalaShellITCase` with the change in this PR fails
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1830#issuecomment-200795802
Good catch! The changes look good to me.
I tried running the adjusted `RollingSinkFaultToleranceITCase` and
`RollingSinkFaultTolerance2ITCase` w/o the fix in
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1835#issuecomment-200787034
I'm merging this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
801 - 900 of 1607 matches
Mail list logo
