[GitHub] flink pull request: [FLINK-3639] add methods for registering datas...

2016-03-22 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/1827#discussion_r57069968 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/TranslationContext.scala --- @@ -59,29 +64,55 @@ object

[jira] [Created] (FLINK-3656) Rework TableAPI tests

2016-03-22 Thread Vasia Kalavri (JIRA)
Vasia Kalavri created FLINK-3656: Summary: Rework TableAPI tests Key: FLINK-3656 URL: https://issues.apache.org/jira/browse/FLINK-3656 Project: Flink Issue Type: Improvement

[GitHub] flink pull request: [FLINK-3547] add support for streaming filter,...

2016-03-22 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/1820#issuecomment-19747 I have updated the PR. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] flink pull request: [FLINK-3547] add support for streaming filter,...

2016-03-22 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/1820#issuecomment-199881323 Thanks for the review! I'll see how we can share the common parts between DataSet and DataStream translation. I will also open a JIRA for reworking the tests. -

[GitHub] flink pull request: [FLINK-3639] add methods for registering datas...

2016-03-22 Thread vasia
GitHub user vasia opened a pull request: https://github.com/apache/flink/pull/1827 [FLINK-3639] add methods for registering datasets and tables in the TableEnvironment This PR add methods for registering DataSets and Tables in the TableEnvironment to allow executing SQL queries in

[GitHub] flink pull request: FLINK-3579 Improve String concatenation (Ram)

2016-03-22 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/1821#issuecomment-199858172 @ramkrish86 it doesn't look like tests are failing. It's a checkstyle violation in `RexNodeTranslator`. --- If your project is set up for it, you can reply to

[jira] [Updated] (FLINK-3587) Bump Calcite version to 1.7.0

2016-03-21 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vasia Kalavri updated FLINK-3587: - Summary: Bump Calcite version to 1.7.0 (was: Bump Calcite version to 1.7.0-SNAPSHOT) > B

[jira] [Commented] (FLINK-3587) Bump Calcite version to 1.7.0-SNAPSHOT

2016-03-21 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15205032#comment-15205032 ] Vasia Kalavri commented on FLINK-3587: -- Yes, I saw it too! > Bump Calcite

[jira] [Resolved] (FLINK-3207) Add a Pregel iteration abstraction to Gelly

2016-03-21 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vasia Kalavri resolved FLINK-3207. -- Resolution: Implemented Fix Version/s: 1.1.0 > Add a Pregel iteration abstraction

[jira] [Assigned] (FLINK-3640) Add support for SQL queries in DataSet programs

2016-03-21 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vasia Kalavri reassigned FLINK-3640: Assignee: Vasia Kalavri > Add support for SQL queries in DataSet progr

[GitHub] flink pull request: [FLINK-3579] Improve String concatenation

2016-03-21 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/1808#issuecomment-199321446 `tableOnCalcite` was deleted on Friday, but it seems that this PR was closed yesterday, so I'm not sure if that's why. Sorry for the inconvenience @

[jira] [Assigned] (FLINK-3639) Add methods and utilities to register DataSets and Tables in the TableEnvironment

2016-03-21 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vasia Kalavri reassigned FLINK-3639: Assignee: Vasia Kalavri > Add methods and utilities to register DataSets and Tables in

[jira] [Created] (FLINK-3640) Add support for SQL queries in DataSet programs

2016-03-21 Thread Vasia Kalavri (JIRA)
Vasia Kalavri created FLINK-3640: Summary: Add support for SQL queries in DataSet programs Key: FLINK-3640 URL: https://issues.apache.org/jira/browse/FLINK-3640 Project: Flink Issue Type

[jira] [Created] (FLINK-3639) Add methods and utilities to register DataSets and Tables in the TableEnvironment

2016-03-21 Thread Vasia Kalavri (JIRA)
Vasia Kalavri created FLINK-3639: Summary: Add methods and utilities to register DataSets and Tables in the TableEnvironment Key: FLINK-3639 URL: https://issues.apache.org/jira/browse/FLINK-3639

[GitHub] flink pull request: [FLINK-3207] [gelly] adds the vertex-centric i...

2016-03-21 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/1575#issuecomment-199211011 I'll merge this today. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[jira] [Resolved] (FLINK-3609) Revisit selection of Calcite rules

2016-03-20 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vasia Kalavri resolved FLINK-3609. -- Resolution: Fixed Fix Version/s: 1.1.0 > Revisit selection of Calcite ru

[jira] [Commented] (FLINK-3630) Little mistake in documentation

2016-03-20 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15199322#comment-15199322 ] Vasia Kalavri commented on FLINK-3630: -- Great! I've assigned the issue to

[GitHub] flink pull request: [hotFix] [tableAPI] Improve naming of DataSetR...

2016-03-19 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/1799#issuecomment-197357481 merged :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Resolved] (FLINK-3503) ProjectJoinTransposeRule fails to push down project.

2016-03-19 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vasia Kalavri resolved FLINK-3503. -- Resolution: Fixed Fix Version/s: 1.1.0 > ProjectJoinTransposeRule fails to push d

[jira] [Updated] (FLINK-3630) Little mistake in documentation

2016-03-19 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vasia Kalavri updated FLINK-3630: - Assignee: Riccardo Diomedi > Little mistake in documentat

[GitHub] flink pull request: [hotFix] [tableAPI] Improve naming of DataSetR...

2016-03-19 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/1799#issuecomment-197320894 This looks good. I'll merge it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[jira] [Resolved] (FLINK-3221) Move Table API on top of Apache Calcite

2016-03-19 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vasia Kalavri resolved FLINK-3221. -- Resolution: Implemented Fix Version/s: 1.1.0 > Move Table API on top of Apache Calc

[jira] [Reopened] (FLINK-3632) Clean up Table API exceptions

2016-03-19 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vasia Kalavri reopened FLINK-3632: -- Assignee: (was: Fabian Hueske) > Clean up Table API excepti

[jira] [Resolved] (FLINK-3622) Improve error messages for invalid joins

2016-03-19 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vasia Kalavri resolved FLINK-3622. -- Resolution: Fixed Fix Version/s: 1.1.0 > Improve error messages for invalid jo

[GitHub] flink pull request: [FLINK-3503] [tableAPI] Add cost model for Dat...

2016-03-19 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/1798#issuecomment-197321103 Merging this one too. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] flink pull request: [FLINK-3547] add support for streaming filter,...

2016-03-19 Thread vasia
Github user vasia closed the pull request at: https://github.com/apache/flink/pull/1770 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: [FLINK-3547] add support for streaming filter,...

2016-03-19 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/1770#issuecomment-198384176 I'm closing this PR because it's made against `tableOnCalcite` and I'll open a new one against `master`. --- If your project is set up for it, you ca

[jira] [Commented] (FLINK-3630) Little mistake in documentation

2016-03-19 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15199315#comment-15199315 ] Vasia Kalavri commented on FLINK-3630: -- Thanks for opening the issue [~riccard

[GitHub] flink pull request: [FLINK-2909] [Gelly] Graph generators

2016-03-19 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/1807#issuecomment-197818798 Hi @greghogan, thank you for this PR! As this is quite a big addition, it will take some time to review :) Could you maybe add some documentation

[jira] [Resolved] (FLINK-3225) Optimize logical Table API plans in Calcite

2016-03-19 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vasia Kalavri resolved FLINK-3225. -- Resolution: Implemented Fix Version/s: 1.1.0 > Optimize logical Table API plans

[jira] [Updated] (FLINK-3503) ProjectJoinTransposeRule fails to push down project.

2016-03-19 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vasia Kalavri updated FLINK-3503: - Assignee: Fabian Hueske > ProjectJoinTransposeRule fails to push down proj

[GitHub] flink pull request: [FLINK-3609] [tableAPI] Reorganize selection o...

2016-03-19 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/1797#discussion_r56329989 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/rules/FlinkRuleSets.scala --- @@ -29,50 +29,45 @@ object FlinkRuleSets

[jira] [Commented] (FLINK-3618) Rename abstract UDF classes in Scatter-Gather implementation

2016-03-19 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15199310#comment-15199310 ] Vasia Kalavri commented on FLINK-3618: -- +1 I think this proposal makes s

[GitHub] flink pull request: [FLINK-3503] [tableAPI] Add cost model for Dat...

2016-03-19 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/1798#issuecomment-197357543 merged :)) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Resolved] (FLINK-3223) Translate Table API query into logical relational plans for Apache Calcite

2016-03-19 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vasia Kalavri resolved FLINK-3223. -- Resolution: Implemented Fix Version/s: 1.1.0 > Translate Table API query into logi

[jira] [Updated] (FLINK-3630) Little mistake in documentation

2016-03-19 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vasia Kalavri updated FLINK-3630: - Assignee: (was: Vasia Kalavri) > Little mistake in documentat

[jira] [Resolved] (FLINK-3226) Translate optimized logical Table API plans into physical plans representing DataSet programs

2016-03-18 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vasia Kalavri resolved FLINK-3226. -- Resolution: Implemented Fix Version/s: 1.1.0 > Translate optimized logical Table

[jira] [Resolved] (FLINK-3632) Clean up Table API exceptions

2016-03-18 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vasia Kalavri resolved FLINK-3632. -- Resolution: Fixed Assignee: Fabian Hueske Fix Version/s: 1.1.0 > Clean up Ta

[GitHub] flink pull request: [FLINK-3609] [tableAPI] Reorganize selection o...

2016-03-18 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/1797#issuecomment-197357617 and merged! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK-3547] add support for streaming filter,...

2016-03-18 Thread vasia
GitHub user vasia opened a pull request: https://github.com/apache/flink/pull/1820 [FLINK-3547] add support for streaming filter, project, and union in the Table API This PR adds: - Java and Scala stream translators - methods to convert a table to a DataStream and vice

[GitHub] flink pull request: [FLINK-2909] [Gelly] Graph generators

2016-03-18 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/1807#issuecomment-198336366 Yes, this sounds like a good idea. I would also have the library methods as a separate page. --- If your project is set up for it, you can reply to this email and have

[GitHub] flink pull request: [FLINK-3609] [tableAPI] Reorganize selection o...

2016-03-18 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/1797#issuecomment-197342267 Thanks, will merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[jira] [Assigned] (FLINK-3630) Little mistake in documentation

2016-03-18 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vasia Kalavri reassigned FLINK-3630: Assignee: Vasia Kalavri > Little mistake in documentat

[jira] [Resolved] (FLINK-3612) Fix/adjust Table API examples

2016-03-16 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vasia Kalavri resolved FLINK-3612. -- Resolution: Fixed Fix Version/s: 1.1.0 > Fix/adjust Table API examp

[GitHub] flink pull request: [FLINK-3612] Fix/adjust Table API examples

2016-03-16 Thread vasia
Github user vasia closed the pull request at: https://github.com/apache/flink/pull/1793 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: [FLINK-3612] Fix/adjust Table API examples

2016-03-16 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/1793#issuecomment-197248063 Thanks! Added the name and merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink pull request: [FLINK-3503] [tableAPI] Add cost model for Dat...

2016-03-16 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/1798#discussion_r56309062 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/DataSetCalc.scala --- @@ -66,8 +67,28 @@ class DataSetCalc

[GitHub] flink pull request: [FLINK-3609] [tableAPI] Reorganize selection o...

2016-03-16 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/1797#issuecomment-197229421 I have some doubts about the filter/project merge rules and the `FlinkJoinUnionTransposeRule`. Otherwise looks good! --- If your project is set up for it, you can reply

[GitHub] flink pull request: [FLINK-3609] [tableAPI] Reorganize selection o...

2016-03-16 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/1797#discussion_r56304469 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/rules/FlinkRuleSets.scala --- @@ -29,50 +29,45 @@ object FlinkRuleSets

[GitHub] flink pull request: [FLINK-3609] [tableAPI] Reorganize selection o...

2016-03-16 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/1797#discussion_r56304292 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/rules/FlinkRuleSets.scala --- @@ -29,50 +29,45 @@ object FlinkRuleSets

[GitHub] flink pull request: [FLINK-3609] [tableAPI] Reorganize selection o...

2016-03-16 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/1797#discussion_r56304129 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/rules/FlinkRuleSets.scala --- @@ -29,50 +29,45 @@ object FlinkRuleSets

[jira] [Resolved] (FLINK-3489) Refactor Table API before merging into master

2016-03-15 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vasia Kalavri resolved FLINK-3489. -- Resolution: Fixed Fix Version/s: 1.1.0 > Refactor Table API before merging into mas

[GitHub] flink pull request: [FLINK-3489] TableAPI refactoring and cleanup

2016-03-15 Thread vasia
Github user vasia closed the pull request at: https://github.com/apache/flink/pull/1789 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: [FLINK-3489] TableAPI refactoring and cleanup

2016-03-15 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/1789#issuecomment-196927263 I would like to merge this if no objections :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink pull request: [FLINK-3612] Fix/adjust Table API examples

2016-03-15 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/1793#issuecomment-196920792 I've updated the PR with a change in the `DataSetAggregate` to inject a type conversion mapper if the expected type is not a `Row`. The `WordCountTable

[jira] [Created] (FLINK-3615) Add support for non-native SQL types

2016-03-15 Thread Vasia Kalavri (JIRA)
Vasia Kalavri created FLINK-3615: Summary: Add support for non-native SQL types Key: FLINK-3615 URL: https://issues.apache.org/jira/browse/FLINK-3615 Project: Flink Issue Type: Improvement

[GitHub] flink pull request: [FLINK-3612] Fix/adjust Table API examples

2016-03-15 Thread vasia
GitHub user vasia opened a pull request: https://github.com/apache/flink/pull/1793 [FLINK-3612] Fix/adjust Table API examples This PR removes the `PageRankTable` example and changes the `WordCountTable` example to work with `Row` type. The `TPCHQuery3Table` example works fine

[jira] [Commented] (FLINK-3612) Fix/adjust Table API examples

2016-03-14 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15194004#comment-15194004 ] Vasia Kalavri commented on FLINK-3612: -- Thanks, I'li try to figure it out

[jira] [Assigned] (FLINK-3612) Fix/adjust Table API examples

2016-03-14 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vasia Kalavri reassigned FLINK-3612: Assignee: Vasia Kalavri > Fix/adjust Table API examp

[jira] [Resolved] (FLINK-3272) Generalize vertex value type in ConnectedComponents

2016-03-14 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vasia Kalavri resolved FLINK-3272. -- Resolution: Implemented Fix Version/s: 1.1.0 > Generalize vertex value type

[jira] [Commented] (FLINK-3612) Fix/adjust Table API examples

2016-03-14 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15193618#comment-15193618 ] Vasia Kalavri commented on FLINK-3612: -- {{JavaTableExample}} and {{WordCountT

[GitHub] flink pull request: [FLINK-3489] TableAPI refactoring and cleanup

2016-03-14 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/1789#issuecomment-196383687 You're right @twalthr, thanks! I've removed `typeInfo` and renamed `ExpressionException `. --- If your project is set up for it, you can reply to this emai

[jira] [Updated] (FLINK-3612) Fix/adjust Table API examples

2016-03-14 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vasia Kalavri updated FLINK-3612: - Issue Type: Sub-task (was: Bug) Parent: FLINK-3221 > Fix/adjust Table API examp

[jira] [Created] (FLINK-3612) Fix/adjust Table API examples

2016-03-14 Thread Vasia Kalavri (JIRA)
Vasia Kalavri created FLINK-3612: Summary: Fix/adjust Table API examples Key: FLINK-3612 URL: https://issues.apache.org/jira/browse/FLINK-3612 Project: Flink Issue Type: Bug

[GitHub] flink pull request: [FLINK-3489] TableAPI refactoring and cleanup

2016-03-14 Thread vasia
GitHub user vasia opened a pull request: https://github.com/apache/flink/pull/1789 [FLINK-3489] TableAPI refactoring and cleanup I applied the proposed changes, except from - remove `ExpressionException `: it is used in many places - remove `typeInfo()` of `Expression`: also

[jira] [Resolved] (FLINK-3604) Enable ignored Table API tests

2016-03-14 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vasia Kalavri resolved FLINK-3604. -- Resolution: Fixed Fix Version/s: 1.1.0 > Enable ignored Table API te

[jira] [Resolved] (FLINK-3603) Re-enable Table API explain

2016-03-14 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vasia Kalavri resolved FLINK-3603. -- Resolution: Fixed Fix Version/s: 1.1.0 > Re-enable Table API expl

[jira] [Resolved] (FLINK-3597) Table API operator names should reflect relational expression

2016-03-14 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vasia Kalavri resolved FLINK-3597. -- Resolution: Fixed Fix Version/s: 1.1.0 > Table API operator names should refl

[GitHub] flink pull request: Enable Table API explain and add descriptive o...

2016-03-14 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/1783#issuecomment-196300324 Merged! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] flink pull request: [FLINK-3272] [Gelly] Generic value in Connecte...

2016-03-14 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/1785#issuecomment-196283342 Thank you Martin! Changes look good. I'll merge this later. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] flink pull request: Enable Table API explain and add descriptive o...

2016-03-14 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/1783#issuecomment-196236729 Looks good to me, too. I'll merge it later. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] flink pull request: Enable Table API explain and add descriptive o...

2016-03-14 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/1783#discussion_r55978047 --- Diff: flink-libraries/flink-table/src/test/scala/resources/testFilter1.out --- @@ -47,8 +48,8 @@ Stage 3 : Data Source Avg. Output Record

[jira] [Assigned] (FLINK-3489) Refactor Table API before merging into master

2016-03-14 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vasia Kalavri reassigned FLINK-3489: Assignee: Vasia Kalavri > Refactor Table API before merging into mas

[GitHub] flink pull request: [FLINK-3207] [gelly] adds the vertex-centric i...

2016-03-11 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/1575#issuecomment-195477642 Anyone else wants to take a look at this PR or shall I go ahead and merge? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] flink pull request: Enable and fix ignored Table API tests

2016-03-11 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/1782#issuecomment-195396056 Merged. You can close it! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request: Enable and fix ignored Table API tests

2016-03-11 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/1782#issuecomment-195390029 Yes, on it! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: Enable and fix ignored Table API tests

2016-03-11 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/1782#issuecomment-195377212 Changes look good to me! I only found 2 unused imports, but I can remove them before merging :) --- If your project is set up for it, you can reply to this email and

[GitHub] flink pull request: [FLINK-3547] add support for streaming filter,...

2016-03-11 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/1770#issuecomment-195302939 Rebased on current `tableOnCalcite`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[jira] [Commented] (FLINK-3489) Refactor Table API before merging into master

2016-03-11 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15190716#comment-15190716 ] Vasia Kalavri commented on FLINK-3489: -- [~twalthr] have you started working on

[jira] [Resolved] (FLINK-3596) DataSet RelNode refactoring

2016-03-11 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vasia Kalavri resolved FLINK-3596. -- Resolution: Fixed Fix Version/s: 1.1.0 > DataSet RelNode refactor

[GitHub] flink pull request: [FLINK-3596] DataSet RelNode refactoring

2016-03-10 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/1777#issuecomment-195241544 Thanks for finalizing and merging :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink pull request: [FLINK-3596] DataSet RelNode refactoring

2016-03-10 Thread vasia
Github user vasia closed the pull request at: https://github.com/apache/flink/pull/1777 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: [FLINK-3207] [gelly] adds the vertex-centric i...

2016-03-10 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/1575#issuecomment-194981424 Hey @s1ck, thanks a lot for the valuable feedback. I've addressed your comments and rebased on the current master. Regarding the method renamings, I suggest we h

[GitHub] flink pull request: [FLINK-3596] DataSet RelNode refactoring

2016-03-10 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/1777#issuecomment-194833766 Thanks for the review @fhueske. I've addressed your comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] flink pull request: [FLINK-3596] DataSet RelNode refactoring

2016-03-09 Thread vasia
GitHub user vasia opened a pull request: https://github.com/apache/flink/pull/1777 [FLINK-3596] DataSet RelNode refactoring This PR refactors the current table API code so that - the intermediate flink relnode layer and the dataset rules are removed - code generation is

[jira] [Created] (FLINK-3596) DataSet RelNode refactoring

2016-03-09 Thread Vasia Kalavri (JIRA)
Vasia Kalavri created FLINK-3596: Summary: DataSet RelNode refactoring Key: FLINK-3596 URL: https://issues.apache.org/jira/browse/FLINK-3596 Project: Flink Issue Type: Improvement

[GitHub] flink pull request: [FLINK-3207] [gelly] adds the vertex-centric i...

2016-03-09 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/1575#issuecomment-194236417 Hey @s1ck, thanks a lot for the thorough review! I will address your comments in the following days. The PR is quite old and needs a rebase, too. For future

[jira] [Commented] (FLINK-1707) Add an Affinity Propagation Library Method

2016-03-08 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15186662#comment-15186662 ] Vasia Kalavri commented on FLINK-1707: -- Hi Josep, no problem! I'll look

[jira] [Updated] (FLINK-3593) DistinctITCase is failing

2016-03-08 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vasia Kalavri updated FLINK-3593: - Description: Failed tests: DistinctITCase.testDistinctAfterAggregate:70 Internal error: Error

[jira] [Created] (FLINK-3593) DistinctITCase is failing

2016-03-08 Thread Vasia Kalavri (JIRA)
Vasia Kalavri created FLINK-3593: Summary: DistinctITCase is failing Key: FLINK-3593 URL: https://issues.apache.org/jira/browse/FLINK-3593 Project: Flink Issue Type: Bug Components

[GitHub] flink pull request: [FLINK-3591] Replace Quickstart K-Means Exampl...

2016-03-08 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/1774#discussion_r55374388 --- Diff: docs/quickstart/run_example_quickstart.md --- @@ -27,116 +27,360 @@ under the License. * This will be replaced by the TOC {:toc

[GitHub] flink pull request: [FLINK-3591] Replace Quickstart K-Means Exampl...

2016-03-08 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/1774#issuecomment-193821304 Just a few misspellings. Otherwise looks great! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink pull request: [FLINK-3591] Replace Quickstart K-Means Exampl...

2016-03-08 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/1774#discussion_r55372164 --- Diff: docs/quickstart/run_example_quickstart.md --- @@ -27,116 +27,360 @@ under the License. * This will be replaced by the TOC {:toc

[GitHub] flink pull request: [FLINK-3591] Replace Quickstart K-Means Exampl...

2016-03-08 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/1774#discussion_r55371996 --- Diff: docs/quickstart/run_example_quickstart.md --- @@ -27,116 +27,360 @@ under the License. * This will be replaced by the TOC {:toc

[GitHub] flink pull request: [FLINK-3591] Replace Quickstart K-Means Exampl...

2016-03-08 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/1774#discussion_r55371429 --- Diff: docs/quickstart/run_example_quickstart.md --- @@ -27,116 +27,360 @@ under the License. * This will be replaced by the TOC {:toc

[GitHub] flink pull request: [FLINK-3591] Replace Quickstart K-Means Exampl...

2016-03-08 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/1774#discussion_r55371459 --- Diff: docs/quickstart/run_example_quickstart.md --- @@ -27,116 +27,360 @@ under the License. * This will be replaced by the TOC {:toc

[GitHub] flink pull request: [FLINK-3591] Replace Quickstart K-Means Exampl...

2016-03-08 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/1774#discussion_r55371362 --- Diff: docs/quickstart/run_example_quickstart.md --- @@ -27,116 +27,360 @@ under the License. * This will be replaced by the TOC {:toc

[GitHub] flink pull request: [FLINK-3591] Replace Quickstart K-Means Exampl...

2016-03-08 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/1774#discussion_r55371080 --- Diff: docs/quickstart/run_example_quickstart.md --- @@ -27,116 +27,360 @@ under the License. * This will be replaced by the TOC {:toc

[GitHub] flink pull request: [FLINK-3591] Replace Quickstart K-Means Exampl...

2016-03-08 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/1774#discussion_r55370936 --- Diff: docs/quickstart/run_example_quickstart.md --- @@ -27,116 +27,360 @@ under the License. * This will be replaced by the TOC {:toc

[GitHub] flink pull request: [FLINK-3591] Replace Quickstart K-Means Exampl...

2016-03-08 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/1774#discussion_r55370299 --- Diff: docs/quickstart/run_example_quickstart.md --- @@ -27,116 +27,360 @@ under the License. * This will be replaced by the TOC {:toc

<    1   2   3   4   5   6   7   8   9   10   >