[PR] [FLINK-35269] Log information about failed records as warnings instead of debug for Kinesis and Firehose sinks [flink-connector-aws]

2024-04-29 Thread via GitHub
z3d1k opened a new pull request, #139: URL: https://github.com/apache/flink-connector-aws/pull/139 ## Purpose of the change Change logging level for information about records failed to be written by Kinesis and Firehose sinks from `debug` to `warn`. Similar configuration is already

Re: [PR] [FLINK-35269] Log information about failed records as warnings instead of debug for Kinesis and Firehose sinks [flink-connector-aws]

2024-04-29 Thread via GitHub
hlteoh37 commented on code in PR #139: URL: https://github.com/apache/flink-connector-aws/pull/139#discussion_r1583398674 ## flink-connector-aws/flink-connector-aws-kinesis-firehose/src/main/java/org/apache/flink/connector/firehose/sink/KinesisFirehoseSinkWriter.java: ## @@ -22

Re: [PR] [FLINK-33211][table] support flink table lineage [flink]

2024-04-29 Thread via GitHub
HuangZhenQiu commented on code in PR #24618: URL: https://github.com/apache/flink/pull/24618#discussion_r1583447345 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/transformations/OneInputTransformation.java: ## @@ -42,7 +42,7 @@ * @param The type of the

Re: [PR] [FLINK-33211][table] support flink table lineage [flink]

2024-04-29 Thread via GitHub
HuangZhenQiu commented on code in PR #24618: URL: https://github.com/apache/flink/pull/24618#discussion_r1583446509 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/lineage/LineageGraph.java: ## @@ -20,13 +20,12 @@ package org.apache.flink.streaming.api.line

Re: [PR] [FLINK-33211][table] support flink table lineage [flink]

2024-04-29 Thread via GitHub
HuangZhenQiu commented on code in PR #24618: URL: https://github.com/apache/flink/pull/24618#discussion_r1583451354 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/lineage/TableColumnLineageEdge.java: ## @@ -0,0 +1,45 @@ +/* + * Licensed to the Ap

[PR] [FLINK-35270]Enrich information in logs, making it easier for debugging [flink]

2024-04-29 Thread via GitHub
HCTommy opened a new pull request, #24747: URL: https://github.com/apache/flink/pull/24747 ## What is the purpose of the change This pull request is to show more info in some logs, which helps a lot when debugging in production environment ## Does this pull request pote

Re: [PR] [FLINK-35270]Enrich information in logs, making it easier for debugging [flink]

2024-04-29 Thread via GitHub
HCTommy commented on PR #24747: URL: https://github.com/apache/flink/pull/24747#issuecomment-2083286683 Hi @zhuzhurk , I optimized some logs, which I think is helpful for people to debug in production environment. Could you please review in your available time. -- This is an automated mes

Re: [PR] [FLINK-35098][ORC] Fix incorrect results with literal first expressions [flink]

2024-04-29 Thread via GitHub
jeyhunkarimov commented on PR #24659: URL: https://github.com/apache/flink/pull/24659#issuecomment-2083288208 Hi @empathy87 sorry for the late reply. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [FLINK-35270]Enrich information in logs, making it easier for debugging [flink]

2024-04-29 Thread via GitHub
flinkbot commented on PR #24747: URL: https://github.com/apache/flink/pull/24747#issuecomment-2083291280 ## CI report: * 9a53729a7c3d968977bcbae010246a28269f9359 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-35098][ORC] Fix incorrect results with literal first expressions [flink]

2024-04-29 Thread via GitHub
jeyhunkarimov commented on code in PR #24659: URL: https://github.com/apache/flink/pull/24659#discussion_r1583468743 ## flink-formats/flink-orc/src/test/java/org/apache/flink/orc/OrcFileSystemITCase.java: ## @@ -208,6 +208,15 @@ void testOrcFilterPushDown() throws ExecutionExcep

Re: [PR] [FLINK-33211][table] support flink table lineage [flink]

2024-04-29 Thread via GitHub
HuangZhenQiu commented on code in PR #24618: URL: https://github.com/apache/flink/pull/24618#discussion_r1583475226 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/lineage/ModifyType.java: ## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Softwar

Re: [PR] [FLINK-33211][table] support flink table lineage [flink]

2024-04-29 Thread via GitHub
HuangZhenQiu commented on code in PR #24618: URL: https://github.com/apache/flink/pull/24618#discussion_r1583476719 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/connector/source/ValuesSource.java: ## @@ -52,7 +60,9 @@ * must be 1. RowData is not serializab

Re: [PR] [FLINK-33211][table] support flink table lineage [flink]

2024-04-29 Thread via GitHub
HuangZhenQiu commented on PR #24618: URL: https://github.com/apache/flink/pull/24618#issuecomment-2083346268 @davidradl Thanks for reviewing this PR. This PR is mainly to handle with source/sink level lineage, column level lineage will be need a further discussion in community. Resolved

Re: [PR] [FLINK-32002] Adjust autoscaler defaults for release [flink-kubernetes-operator]

2024-04-29 Thread via GitHub
trystanj commented on code in PR #586: URL: https://github.com/apache/flink-kubernetes-operator/pull/586#discussion_r1583828939 ## flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/config/AutoScalerOptions.java: ## @@ -68,15 +68,

Re: [PR] [FLINK-32002] Adjust autoscaler defaults for release [flink-kubernetes-operator]

2024-04-29 Thread via GitHub
trystanj commented on code in PR #586: URL: https://github.com/apache/flink-kubernetes-operator/pull/586#discussion_r1583828939 ## flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/config/AutoScalerOptions.java: ## @@ -68,15 +68,

Re: [PR] [FLINK-32002] Adjust autoscaler defaults for release [flink-kubernetes-operator]

2024-04-29 Thread via GitHub
trystanj commented on code in PR #586: URL: https://github.com/apache/flink-kubernetes-operator/pull/586#discussion_r1583828939 ## flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/config/AutoScalerOptions.java: ## @@ -68,15 +68,

Re: [PR] [FLINK-32002] Adjust autoscaler defaults for release [flink-kubernetes-operator]

2024-04-29 Thread via GitHub
trystanj commented on code in PR #586: URL: https://github.com/apache/flink-kubernetes-operator/pull/586#discussion_r1583828939 ## flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/config/AutoScalerOptions.java: ## @@ -68,15 +68,

Re: [PR] [FLINK-34549][API] Introduce config, context and processingTimerService for DataStream API V2 [flink]

2024-04-29 Thread via GitHub
jeyhunkarimov commented on code in PR #24541: URL: https://github.com/apache/flink/pull/24541#discussion_r1583695410 ## flink-core-api/src/main/java/org/apache/flink/api/common/operators/SlotSharingGroupDescriptor.java: ## @@ -0,0 +1,238 @@ +/* + * Licensed to the Apache Softwar

Re: [PR] [FLINK-35228][Connectors/Kafka] Fix: DynamicKafkaSource does not read re-added topic for the same cluster [flink-connector-kafka]

2024-04-29 Thread via GitHub
mas-chen merged PR #97: URL: https://github.com/apache/flink-connector-kafka/pull/97 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

Re: [PR] [FLINK-35228][Connectors/Kafka] Fix: DynamicKafkaSource does not read re-added topic for the same cluster [flink-connector-kafka]

2024-04-29 Thread via GitHub
boring-cyborg[bot] commented on PR #97: URL: https://github.com/apache/flink-connector-kafka/pull/97#issuecomment-2083840330 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] [FLINK-35194][table] Support describe job with job id [flink]

2024-04-29 Thread via GitHub
xuyangzhong commented on PR #24728: URL: https://github.com/apache/flink/pull/24728#issuecomment-2084076648 The doc jira is: https://issues.apache.org/jira/browse/FLINK-35271 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [FLINK-35191][table] Support alter materialized table related syntaxes: suspend, resume, refresh, set and reset [flink]

2024-04-29 Thread via GitHub
lsyldliu closed pull request #24737: [FLINK-35191][table] Support alter materialized table related syntaxes: suspend, resume, refresh, set and reset URL: https://github.com/apache/flink/pull/24737 -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] [FLINK-35191][table] Support alter materialized table related syntaxes: suspend, resume, refresh, set and reset [flink]

2024-04-29 Thread via GitHub
lsyldliu commented on PR #24737: URL: https://github.com/apache/flink/pull/24737#issuecomment-2084089129 Sorry for forgetting to approve, +1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] [FLINK-35184][table-runtime] fix minibatch join hash collision [flink]

2024-04-29 Thread via GitHub
lsyldliu closed pull request #24703: [FLINK-35184][table-runtime] fix minibatch join hash collision URL: https://github.com/apache/flink/pull/24703 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] [BP-1.19][FLINK-34379][table] Fix OutOfMemoryError with large queries [flink]

2024-04-29 Thread via GitHub
lsyldliu merged PR #24745: URL: https://github.com/apache/flink/pull/24745 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

Re: [PR] [BP-1.18][FLINK-34379][table] Fix OutOfMemoryError with large queries [flink]

2024-04-29 Thread via GitHub
lsyldliu commented on PR #24744: URL: https://github.com/apache/flink/pull/24744#issuecomment-2084205892 The CI is failed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] [BP-1.17][FLINK-34379][table] Fix OutOfMemoryError with large queries [flink]

2024-04-29 Thread via GitHub
lsyldliu commented on PR #24743: URL: https://github.com/apache/flink/pull/24743#issuecomment-2084206324 The CI is failed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [FLINK-35039][rest] Use PUT method supported by YARN web proxy instead of POST [flink]

2024-04-29 Thread via GitHub
yuchen-ecnu commented on PR #24689: URL: https://github.com/apache/flink/pull/24689#issuecomment-2084282176 Hi @yeezychao , sorry for the late response. It's not enough to just change the request type on the front end, you also need to modify the type of the corresponding REST interface o

[PR] [FLINK-35030][runtime] Introduce Epoch Manager for under async execution [flink]

2024-04-29 Thread via GitHub
fredia opened a new pull request, #24748: URL: https://github.com/apache/flink/pull/24748 ## What is the purpose of the change This PR introduces Epoch Manager to handle watermark and watermark status processing under async execution. Epoch manager segments inputs into dist

Re: [PR] [FLINK-35030][runtime] Introduce Epoch Manager for under async execution [flink]

2024-04-29 Thread via GitHub
flinkbot commented on PR #24748: URL: https://github.com/apache/flink/pull/24748#issuecomment-2084288856 ## CI report: * 9f3239c4bebe6a60ae8db7892e7df1a58fc868f0 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-35165][runtime/coordination] AdaptiveBatch Scheduler should not restrict the default source parall… [flink]

2024-04-29 Thread via GitHub
venkata91 commented on PR #24736: URL: https://github.com/apache/flink/pull/24736#issuecomment-2084313431 cc @SinBex and @JunRuiLee for reviews. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[PR] [FLINK-35184][table-runtime] fix minibatch join hash collision release-1.19 [flink]

2024-04-29 Thread via GitHub
rovboyko opened a new pull request, #24749: URL: https://github.com/apache/flink/pull/24749 ## What is the purpose of the change This change fixes the possible error because of hash collision in MiniBatchStreamingJoinOperator ## Brief change log Currently for

Re: [PR] [FLINK-35184][table-runtime] fix minibatch join hash collision release-1.19 [flink]

2024-04-29 Thread via GitHub
flinkbot commented on PR #24749: URL: https://github.com/apache/flink/pull/24749#issuecomment-2084336643 ## CI report: * cba2e44d01b250e2de4619ba40af17709feb4786 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [BP-1.19][FLINK-32622][table-planner] Optimize mini-batch assignment (#23470) [flink]

2024-04-29 Thread via GitHub
JingGe merged PR #24746: URL: https://github.com/apache/flink/pull/24746 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

Re: [PR] [FLINK-32002] Adjust autoscaler defaults for release [flink-kubernetes-operator]

2024-04-29 Thread via GitHub
gyfora commented on code in PR #586: URL: https://github.com/apache/flink-kubernetes-operator/pull/586#discussion_r1584144759 ## flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/config/AutoScalerOptions.java: ## @@ -68,15 +68,16

Re: [PR] [FLINK-35039][rest] Use PUT method supported by YARN web proxy instead of POST [flink]

2024-04-29 Thread via GitHub
yeezychao commented on PR #24689: URL: https://github.com/apache/flink/pull/24689#issuecomment-2084432438 Hi @yuchen-ecnu, I agreee with you,so I created issues [YARN-11691](https://issues.apache.org/jira/browse/YARN-11691) to the YARN community. -- This is an automated message from the

Re: [PR] [FLINK-35161][state] Implement StateExecutor for ForStStateBackend [flink]

2024-04-29 Thread via GitHub
fredia commented on code in PR #24739: URL: https://github.com/apache/flink/pull/24739#discussion_r1584188915 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/ForStStateExecutor.java: ## @@ -0,0 +1,123 @@ +/* + * Licensed to the Apache

Re: [PR] [FLINK-35194][table] Support describe job with job id [flink]

2024-04-29 Thread via GitHub
lsyldliu closed pull request #24728: [FLINK-35194][table] Support describe job with job id URL: https://github.com/apache/flink/pull/24728 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] [FLINK-35158][runtime] Error handling in StateFuture's callback [flink]

2024-04-30 Thread via GitHub
yunfengzhou-hub commented on code in PR #24698: URL: https://github.com/apache/flink/pull/24698#discussion_r1584175343 ## flink-core/src/main/java/org/apache/flink/core/state/StateFutureImpl.java: ## @@ -46,123 +46,169 @@ public class StateFutureImpl implements InternalStateFut

Re: [PR] [FLINK-35098][ORC] Fix incorrect results with literal first expressions [flink]

2024-04-30 Thread via GitHub
empathy87 commented on code in PR #24659: URL: https://github.com/apache/flink/pull/24659#discussion_r1584273004 ## flink-formats/flink-orc/src/test/java/org/apache/flink/orc/OrcFileSystemITCase.java: ## @@ -208,6 +208,15 @@ void testOrcFilterPushDown() throws ExecutionException

[PR] [FLINK-35192] Remove usage of deleteOnExit() to reduce the memory usage of the operator [flink-kubernetes-operator]

2024-04-30 Thread via GitHub
bgeng777 opened a new pull request, #822: URL: https://github.com/apache/flink-kubernetes-operator/pull/822 ## What is the purpose of the change According to [FLINK-35192](https://issues.apache.org/jira/browse/FLINK-35192), the usage of file.deleteOnExit() will register a hashmap

[PR] [FLINK-35195][table] Support the execution of create materialized table in continuous refresh mode [flink]

2024-04-30 Thread via GitHub
lsyldliu opened a new pull request, #24750: URL: https://github.com/apache/flink/pull/24750 ## What is the purpose of the change *Support the execution of create materialized table in continuous refresh mode* ## Brief change log - *Support the execution of create m

Re: [PR] [FLINK-32080][FLIP-306][checkpoint] Restoration of FileMergingSnapshotManager [flink]

2024-04-30 Thread via GitHub
ljz2051 commented on code in PR #24640: URL: https://github.com/apache/flink/pull/24640#discussion_r1584361582 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/FileMergingSnapshotManagerBase.java: ## @@ -575,8 +576,51 @@ private void createManagedDi

Re: [PR] [FLINK-35195][table] Support the execution of create materialized table in continuous refresh mode [flink]

2024-04-30 Thread via GitHub
flinkbot commented on PR #24750: URL: https://github.com/apache/flink/pull/24750#issuecomment-2084709081 ## CI report: * 9970141f26ce36804d528727728eb23648a1201f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-32080][FLIP-306][checkpoint] Restoration of FileMergingSnapshotManager [flink]

2024-04-30 Thread via GitHub
ljz2051 commented on code in PR #24640: URL: https://github.com/apache/flink/pull/24640#discussion_r1584364578 ## flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java: ## @@ -830,6 +832,8 @@ public CompletableFuture submitTask(

Re: [PR] [FLINK-32080][FLIP-306][checkpoint] Restoration of FileMergingSnapshotManager [flink]

2024-04-30 Thread via GitHub
ljz2051 commented on code in PR #24640: URL: https://github.com/apache/flink/pull/24640#discussion_r1584375937 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/FileMergingSnapshotManagerBase.java: ## @@ -575,8 +576,51 @@ private void createManagedDi

Re: [PR] [FLINK-32080][FLIP-306][checkpoint] Restoration of FileMergingSnapshotManager [flink]

2024-04-30 Thread via GitHub
ljz2051 commented on code in PR #24640: URL: https://github.com/apache/flink/pull/24640#discussion_r1584382431 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/FileMergingSnapshotManagerBase.java: ## @@ -575,8 +576,51 @@ private void createManagedDi

Re: [PR] [FLINK-34902][table] Fix IndexOutOfBoundsException for VALUES [flink]

2024-04-30 Thread via GitHub
twalthr merged PR #24724: URL: https://github.com/apache/flink/pull/24724 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apach

Re: [PR] [FLINK-35161][state] Implement StateExecutor for ForStStateBackend [flink]

2024-04-30 Thread via GitHub
ljz2051 commented on code in PR #24739: URL: https://github.com/apache/flink/pull/24739#discussion_r1584427802 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/ForStStateExecutor.java: ## @@ -0,0 +1,123 @@ +/* + * Licensed to the Apache

Re: [PR] [FLINK-35161][state] Implement StateExecutor for ForStStateBackend [flink]

2024-04-30 Thread via GitHub
ljz2051 commented on code in PR #24739: URL: https://github.com/apache/flink/pull/24739#discussion_r1584431128 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/ForStStateRequestClassifier.java: ## @@ -0,0 +1,101 @@ +/* + * Licensed to t

Re: [PR] [FLINK-34980] Translate overview document into Chinese [flink-kubernetes-operator]

2024-04-30 Thread via GitHub
caicancai commented on code in PR #810: URL: https://github.com/apache/flink-kubernetes-operator/pull/810#discussion_r1584443822 ## docs/content.zh/docs/concepts/overview.md: ## @@ -24,78 +24,96 @@ specific language governing permissions and limitations under the License. -->

Re: [PR] [FLINK-35161][state] Implement StateExecutor for ForStStateBackend [flink]

2024-04-30 Thread via GitHub
ljz2051 commented on code in PR #24739: URL: https://github.com/apache/flink/pull/24739#discussion_r158208 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/ForStValueState.java: ## @@ -95,4 +100,32 @@ public V deserializeValue(byte[

Re: [PR] [FLINK-34980] Translate overview document into Chinese [flink-kubernetes-operator]

2024-04-30 Thread via GitHub
caicancai commented on code in PR #810: URL: https://github.com/apache/flink-kubernetes-operator/pull/810#discussion_r1584445284 ## docs/content.zh/docs/concepts/overview.md: ## @@ -24,78 +24,96 @@ specific language governing permissions and limitations under the License. -->

Re: [PR] [FLINK-34980] Translate overview document into Chinese [flink-kubernetes-operator]

2024-04-30 Thread via GitHub
caicancai commented on code in PR #810: URL: https://github.com/apache/flink-kubernetes-operator/pull/810#discussion_r1584451630 ## docs/content.zh/docs/concepts/overview.md: ## @@ -24,78 +24,96 @@ specific language governing permissions and limitations under the License. -->

Re: [PR] [FLINK-34980] Translate overview document into Chinese [flink-kubernetes-operator]

2024-04-30 Thread via GitHub
caicancai commented on code in PR #810: URL: https://github.com/apache/flink-kubernetes-operator/pull/810#discussion_r1584453151 ## docs/content.zh/docs/concepts/overview.md: ## @@ -24,78 +24,96 @@ specific language governing permissions and limitations under the License. -->

Re: [PR] [FLINK-34980] Translate overview document into Chinese [flink-kubernetes-operator]

2024-04-30 Thread via GitHub
caicancai commented on code in PR #810: URL: https://github.com/apache/flink-kubernetes-operator/pull/810#discussion_r1584453635 ## docs/content.zh/docs/concepts/overview.md: ## @@ -24,78 +24,96 @@ specific language governing permissions and limitations under the License. -->

Re: [PR] [FLINK-27146] [Filesystem] Migrate to Junit5 [flink]

2024-04-30 Thread via GitHub
kottmann commented on PR #22789: URL: https://github.com/apache/flink/pull/22789#issuecomment-2084837876 This is fixed now as well, see new commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [FLINK-35262] Bridge between AsyncKeyedStateBackend and AsyncExecutionController [flink]

2024-04-30 Thread via GitHub
jectpro7 commented on code in PR #24740: URL: https://github.com/apache/flink/pull/24740#discussion_r1584465123 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/asyncprocessing/AbstractAsyncStateStreamOperator.java: ## @@ -74,15 +76,20 @@ public

Re: [PR] [FLINK-35161][state] Implement StateExecutor for ForStStateBackend [flink]

2024-04-30 Thread via GitHub
fredia commented on code in PR #24739: URL: https://github.com/apache/flink/pull/24739#discussion_r1584477969 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/ForStStateRequestClassifier.java: ## @@ -0,0 +1,101 @@ +/* + * Licensed to th

Re: [PR] [FLINK-35158][runtime] Error handling in StateFuture's callback [flink]

2024-04-30 Thread via GitHub
fredia commented on code in PR #24698: URL: https://github.com/apache/flink/pull/24698#discussion_r1584530942 ## flink-core-api/src/main/java/org/apache/flink/api/common/state/v2/StateFuture.java: ## @@ -49,7 +49,7 @@ public interface StateFuture { * @param action the acti

Re: [PR] [FLINK-33761][Connector/JDBC] Add Snowflake JDBC Dialect [flink-connector-jdbc]

2024-04-30 Thread via GitHub
boring-cyborg[bot] commented on PR #118: URL: https://github.com/apache/flink-connector-jdbc/pull/118#issuecomment-2084941773 Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) -- This is

[PR] [FLINK-35272][cdc][runtime] Transform projection & filter feature overhaul [flink-cdc]

2024-04-30 Thread via GitHub
yuxiqian opened a new pull request, #3285: URL: https://github.com/apache/flink-cdc/pull/3285 This closes [FLINK-35272](https://issues.apache.org/jira/browse/FLINK-35272). Currently, pipeline jobs with transform (including projection and filtering) are constructed with the following t

Re: [PR] [FLINK-35176][Connector/JDBC] Support property authentication connection for JDBC catalog & dynamic table [flink-connector-jdbc]

2024-04-30 Thread via GitHub
eskabetxe commented on code in PR #116: URL: https://github.com/apache/flink-connector-jdbc/pull/116#discussion_r1584601921 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/catalog/AbstractJdbcCatalog.java: ## @@ -88,32 +92,49 @@ public abstract class Abstr

Re: [PR] [FLINK-35274][cdc-connector][db2] Fix occasional failure issue with Flink CDC Db2 UT [flink-cdc]

2024-04-30 Thread via GitHub
gong commented on PR #3283: URL: https://github.com/apache/flink-cdc/pull/3283#issuecomment-2085021893 @PatrickRen PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] [FLINK-35274][cdc-connector][db2] Fix occasional failure issue with Flink CDC Db2 UT [flink-cdc]

2024-04-30 Thread via GitHub
gong commented on PR #3284: URL: https://github.com/apache/flink-cdc/pull/3284#issuecomment-2085022086 @PatrickRen PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] [FLINK-35217] Add missing fsync to #closeForCommit in some subclasses of RecoverableFsDataOutputStream. [flink]

2024-04-30 Thread via GitHub
StefanRRichter merged PR #24722: URL: https://github.com/apache/flink/pull/24722 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flin

Re: [PR] [FLINK-33761][Connector/JDBC] Add Snowflake JDBC Dialect [flink-connector-jdbc]

2024-04-30 Thread via GitHub
davidradl commented on code in PR #118: URL: https://github.com/apache/flink-connector-jdbc/pull/118#discussion_r1584685732 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/databases/snowflake/dialect/SnowflakeDialectFactory.java: ## @@ -0,0 +1,37 @@ +/* +

Re: [PR] [FLINK-33761][Connector/JDBC] Add Snowflake JDBC Dialect [flink-connector-jdbc]

2024-04-30 Thread via GitHub
davidradl commented on code in PR #118: URL: https://github.com/apache/flink-connector-jdbc/pull/118#discussion_r1584685732 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/databases/snowflake/dialect/SnowflakeDialectFactory.java: ## @@ -0,0 +1,37 @@ +/* +

Re: [PR] [FLINK-33761][Connector/JDBC] Add Snowflake JDBC Dialect [flink-connector-jdbc]

2024-04-30 Thread via GitHub
davidradl commented on code in PR #118: URL: https://github.com/apache/flink-connector-jdbc/pull/118#discussion_r1584710588 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/databases/snowflake/dialect/SnowflakeRowConverter.java: ## @@ -0,0 +1,45 @@ +/* + *

Re: [PR] [FLINK-33761][Connector/JDBC] Add Snowflake JDBC Dialect [flink-connector-jdbc]

2024-04-30 Thread via GitHub
davidradl commented on code in PR #118: URL: https://github.com/apache/flink-connector-jdbc/pull/118#discussion_r1584685732 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/databases/snowflake/dialect/SnowflakeDialectFactory.java: ## @@ -0,0 +1,37 @@ +/* +

Re: [PR] [FLINK-33761][Connector/JDBC] Add Snowflake JDBC Dialect [flink-connector-jdbc]

2024-04-30 Thread via GitHub
davidradl commented on code in PR #118: URL: https://github.com/apache/flink-connector-jdbc/pull/118#discussion_r1584710588 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/databases/snowflake/dialect/SnowflakeRowConverter.java: ## @@ -0,0 +1,45 @@ +/* + *

Re: [PR] [mysql] Mysql-cdc adapt mariadb. [flink-cdc]

2024-04-30 Thread via GitHub
ThisisWilli commented on PR #2494: URL: https://github.com/apache/flink-cdc/pull/2494#issuecomment-2085275760 > Hi @ThisisWilli, thanks for your great contribution! Could you please rebase this PR with latest `master` branch? You may need to rename some packages like from `com.ververica.cdc

Re: [PR] [FLINK-35183] MinorVersion metric for tracking applications [flink-kubernetes-operator]

2024-04-30 Thread via GitHub
gaborgsomogyi commented on code in PR #819: URL: https://github.com/apache/flink-kubernetes-operator/pull/819#discussion_r1584790463 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/metrics/FlinkDeploymentMetrics.java: ## @@ -165,13 +194,21 @@ pri

[PR] Backport: [FLINK-35217] Add missing fsync to #closeForCommit in some subclasses of RecoverableFsDataOutputStream. (#24722) [flink]

2024-04-30 Thread via GitHub
StefanRRichter opened a new pull request, #24751: URL: https://github.com/apache/flink/pull/24751 Backport of FLINK-35217 for 1.19 (cherry picked from commit 80af4d502318348ba15a8f75a2a622ce9dbdc968) -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] [FLINK-35183] MinorVersion metric for tracking applications [flink-kubernetes-operator]

2024-04-30 Thread via GitHub
mbalassi commented on code in PR #819: URL: https://github.com/apache/flink-kubernetes-operator/pull/819#discussion_r1584810870 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/metrics/FlinkDeploymentMetrics.java: ## @@ -165,13 +194,21 @@ private

Re: [PR] Backport: [FLINK-35217] Add missing fsync to #closeForCommit in some subclasses of RecoverableFsDataOutputStream. (#24722) [flink]

2024-04-30 Thread via GitHub
flinkbot commented on PR #24751: URL: https://github.com/apache/flink/pull/24751#issuecomment-2085320237 ## CI report: * e5d3c1296ac763d40175720c8fff58716ab1a3b1 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] Backport: [FLINK-35217] Add missing fsync to #closeForCommit in some subclasses of RecoverableFsDataOutputStream. (#24722) [flink]

2024-04-30 Thread via GitHub
flinkbot commented on PR #24752: URL: https://github.com/apache/flink/pull/24752#issuecomment-2085320637 ## CI report: * 0670f3aec8b7aaa6db1192a8cdead22d9c6b925b UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-35183] MinorVersion metric for tracking applications [flink-kubernetes-operator]

2024-04-30 Thread via GitHub
mbalassi commented on code in PR #819: URL: https://github.com/apache/flink-kubernetes-operator/pull/819#discussion_r1584812594 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/metrics/FlinkDeploymentMetrics.java: ## @@ -94,6 +101,22 @@ public voi

Re: [PR] [FLINK-27146] [Filesystem] Migrate to Junit5 [flink]

2024-04-30 Thread via GitHub
kottmann commented on PR #22789: URL: https://github.com/apache/flink/pull/22789#issuecomment-2085392466 @ferenc-csaky Thank you for reviewing my PR and for your helpful feedback! I really appreciate your support in improving it. -- This is an automated message from the Apache Git Service

Re: [PR] [FLINK-35277][cdc-connector][db2] Fix the error in the `asncdcaddremove.sql` script for the DB2 test container. [flink-cdc]

2024-04-30 Thread via GitHub
vinlee19 commented on PR #3286: URL: https://github.com/apache/flink-cdc/pull/3286#issuecomment-2085539643 @ruanhang1993 @gong PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] [FLINK-32002] Adjust autoscaler defaults for release [flink-kubernetes-operator]

2024-04-30 Thread via GitHub
trystanj commented on code in PR #586: URL: https://github.com/apache/flink-kubernetes-operator/pull/586#discussion_r1584990017 ## flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/config/AutoScalerOptions.java: ## @@ -68,15 +68,

Re: [PR] [FLINK-32002] Adjust autoscaler defaults for release [flink-kubernetes-operator]

2024-04-30 Thread via GitHub
trystanj commented on code in PR #586: URL: https://github.com/apache/flink-kubernetes-operator/pull/586#discussion_r1584990017 ## flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/config/AutoScalerOptions.java: ## @@ -68,15 +68,

Re: [PR] [FLINK-32002] Adjust autoscaler defaults for release [flink-kubernetes-operator]

2024-04-30 Thread via GitHub
trystanj commented on code in PR #586: URL: https://github.com/apache/flink-kubernetes-operator/pull/586#discussion_r1584990017 ## flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/config/AutoScalerOptions.java: ## @@ -68,15 +68,

Re: [PR] [FLINK-32002] Adjust autoscaler defaults for release [flink-kubernetes-operator]

2024-04-30 Thread via GitHub
trystanj commented on code in PR #586: URL: https://github.com/apache/flink-kubernetes-operator/pull/586#discussion_r1584990017 ## flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/config/AutoScalerOptions.java: ## @@ -68,15 +68,

Re: [PR] [FLINK-32002] Adjust autoscaler defaults for release [flink-kubernetes-operator]

2024-04-30 Thread via GitHub
gyfora commented on code in PR #586: URL: https://github.com/apache/flink-kubernetes-operator/pull/586#discussion_r1585008279 ## flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/config/AutoScalerOptions.java: ## @@ -68,15 +68,16

Re: [PR] [FLINK-32002] Adjust autoscaler defaults for release [flink-kubernetes-operator]

2024-04-30 Thread via GitHub
trystanj commented on code in PR #586: URL: https://github.com/apache/flink-kubernetes-operator/pull/586#discussion_r1585036601 ## flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/config/AutoScalerOptions.java: ## @@ -68,15 +68,

Re: [PR] [FLINK-32002] Adjust autoscaler defaults for release [flink-kubernetes-operator]

2024-04-30 Thread via GitHub
trystanj commented on code in PR #586: URL: https://github.com/apache/flink-kubernetes-operator/pull/586#discussion_r1585036601 ## flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/config/AutoScalerOptions.java: ## @@ -68,15 +68,

Re: [PR] [FLINK-32002] Adjust autoscaler defaults for release [flink-kubernetes-operator]

2024-04-30 Thread via GitHub
trystanj commented on code in PR #586: URL: https://github.com/apache/flink-kubernetes-operator/pull/586#discussion_r1585036601 ## flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/config/AutoScalerOptions.java: ## @@ -68,15 +68,

Re: [PR] [FLINK-32002] Adjust autoscaler defaults for release [flink-kubernetes-operator]

2024-04-30 Thread via GitHub
trystanj commented on code in PR #586: URL: https://github.com/apache/flink-kubernetes-operator/pull/586#discussion_r1585036601 ## flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/config/AutoScalerOptions.java: ## @@ -68,15 +68,

Re: [PR] [FLINK-32002] Adjust autoscaler defaults for release [flink-kubernetes-operator]

2024-04-30 Thread via GitHub
trystanj commented on code in PR #586: URL: https://github.com/apache/flink-kubernetes-operator/pull/586#discussion_r1585036601 ## flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/config/AutoScalerOptions.java: ## @@ -68,15 +68,

Re: [PR] [FLINK-32002] Adjust autoscaler defaults for release [flink-kubernetes-operator]

2024-04-30 Thread via GitHub
trystanj commented on code in PR #586: URL: https://github.com/apache/flink-kubernetes-operator/pull/586#discussion_r1585113359 ## flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/config/AutoScalerOptions.java: ## @@ -68,15 +68,

Re: [PR] [FLINK-33761][Connector/JDBC] Add Snowflake JDBC Dialect [flink-connector-jdbc]

2024-04-30 Thread via GitHub
borislitvak commented on code in PR #118: URL: https://github.com/apache/flink-connector-jdbc/pull/118#discussion_r1585423831 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/databases/snowflake/dialect/SnowflakeRowConverter.java: ## @@ -0,0 +1,45 @@ +/* +

Re: [PR] [FLINK-33761][Connector/JDBC] Add Snowflake JDBC Dialect [flink-connector-jdbc]

2024-04-30 Thread via GitHub
borislitvak commented on code in PR #118: URL: https://github.com/apache/flink-connector-jdbc/pull/118#discussion_r1585425522 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/databases/snowflake/dialect/SnowflakeDialectFactory.java: ## @@ -0,0 +1,37 @@ +/*

Re: [PR] Backport: [FLINK-35217] Add missing fsync to #closeForCommit in some subclasses of RecoverableFsDataOutputStream. (#24722) [flink]

2024-04-30 Thread via GitHub
StefanRRichter merged PR #24751: URL: https://github.com/apache/flink/pull/24751 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flin

Re: [PR] Backport: [FLINK-35217] Add missing fsync to #closeForCommit in some subclasses of RecoverableFsDataOutputStream. (#24722) [flink]

2024-04-30 Thread via GitHub
StefanRRichter merged PR #24752: URL: https://github.com/apache/flink/pull/24752 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flin

Re: [PR] [FLINK-35195][table] Support the execution of create materialized table in continuous refresh mode [flink]

2024-04-30 Thread via GitHub
h12567 commented on PR #24750: URL: https://github.com/apache/flink/pull/24750#issuecomment-2087873976 May I ask how to find the list of issues/requests I can contribute to? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[PR] [FLINK-35232] Add retry settings for GCS connector [flink]

2024-05-01 Thread via GitHub
JTaky opened a new pull request, #24753: URL: https://github.com/apache/flink/pull/24753 Provide a way to ingest retrier settings configuration to gcs-cloud-storage library in use. ## Brief change log - exposed `gs.retry.max-attempt`, `gs.retry.init-rpc-timeout`, `

Re: [PR] [FLINK-35232] Add retry settings for GCS connector [flink]

2024-05-01 Thread via GitHub
flinkbot commented on PR #24753: URL: https://github.com/apache/flink/pull/24753#issuecomment-2088082229 ## CI report: * 1fb740aaac47908e4162fb8cef213c965841288f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-31223][sqlgateway] Introduce getFlinkConfigurationOptions to [flink]

2024-05-01 Thread via GitHub
davidradl commented on PR #24741: URL: https://github.com/apache/flink/pull/24741#issuecomment-2088277865 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] [FLINK-31223][sqlgateway] Introduce getFlinkConfigurationOptions to [flink]

2024-05-01 Thread via GitHub
davidradl commented on PR #24741: URL: https://github.com/apache/flink/pull/24741#issuecomment-2088287202 @reswqa junit errors in the pr build - I will investigate -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

<    1   2   3   4   5   6   7   8   9   10   >