Re: [PR] [FLINK-35192] Remove usage of deleteOnExit() to reduce the memory usage of the operator [flink-kubernetes-operator]

2024-05-01 Thread via GitHub
gyfora merged PR #822: URL: https://github.com/apache/flink-kubernetes-operator/pull/822 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

Re: [PR] [FLINK-33761][Connector/JDBC] Add Snowflake JDBC Dialect [flink-connector-jdbc]

2024-05-01 Thread via GitHub
borislitvak commented on code in PR #118: URL: https://github.com/apache/flink-connector-jdbc/pull/118#discussion_r1586364059 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/databases/snowflake/dialect/SnowflakeDialectFactory.java: ## @@ -0,0 +1,37 @@ +/*

[PR] [FLINK-33212][runtime] add job status changed listener for lineage [flink]

2024-05-01 Thread via GitHub
HuangZhenQiu opened a new pull request, #24754: URL: https://github.com/apache/flink/pull/24754 ## What is the purpose of the change Add job status changed listener for lineage. Need to use this PR to discuss with community about whether to add lineage graph to JobGraph for web submissio

Re: [PR] [FLINK-33212][runtime] add job status changed listener for lineage [flink]

2024-05-01 Thread via GitHub
flinkbot commented on PR #24754: URL: https://github.com/apache/flink/pull/24754#issuecomment-2088785395 ## CI report: * 6b5b8889d2417c2510b1372a32c332bc3962cb99 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33761][Connector/JDBC] Add Snowflake JDBC Dialect [flink-connector-jdbc]

2024-05-01 Thread via GitHub
borislitvak commented on code in PR #118: URL: https://github.com/apache/flink-connector-jdbc/pull/118#discussion_r1586816863 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/databases/snowflake/dialect/SnowflakeDialectFactory.java: ## @@ -0,0 +1,37 @@ +/*

Re: [PR] [FLINK-35184][table-runtime] fix minibatch join hash collision release-1.19 [flink]

2024-05-01 Thread via GitHub
rovboyko commented on PR #24749: URL: https://github.com/apache/flink/pull/24749#issuecomment-2089488999 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-35184][table-runtime] fix minibatch join hash collision release-1.19 [flink]

2024-05-01 Thread via GitHub
rovboyko commented on PR #24749: URL: https://github.com/apache/flink/pull/24749#issuecomment-2089490837 rerun the azure pipeline because previous run faced the bug - https://issues.apache.org/jira/browse/FLINK-34405 -- This is an automated message from the Apache Git Service. To respond

Re: [PR] [FLINK-35149][cdc-composer] Fix DataSinkTranslator#sinkTo ignoring pre-write topology if not TwoPhaseCommittingSink [flink-cdc]

2024-05-01 Thread via GitHub
loserwang1024 commented on PR #3233: URL: https://github.com/apache/flink-cdc/pull/3233#issuecomment-2089709636 > Could you please add a test case to prevent later code changes to revert this fix? I'd like to, but it seems no pipeline sink which is WithPreWriteTopology but not TwoPha

[PR] PoC for supporting unique Kafka producer client ids [flink-connector-kafka]

2024-05-02 Thread via GitHub
francis-a opened a new pull request, #101: URL: https://github.com/apache/flink-connector-kafka/pull/101 This PR came out of debuging a warning we’re seeing in our Flink logs. We’re running Flink 1.18 and have an application that uses Kafka topics as a source and a sink. We’re running with

Re: [PR] PoC for supporting unique Kafka producer client ids [flink-connector-kafka]

2024-05-02 Thread via GitHub
boring-cyborg[bot] commented on PR #101: URL: https://github.com/apache/flink-connector-kafka/pull/101#issuecomment-2089910632 Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) -- This is

[PR] [hotfix] Mention mTLS in SSL documentation page [flink]

2024-05-02 Thread via GitHub
rmetzger opened a new pull request, #24755: URL: https://github.com/apache/flink/pull/24755 Make it more explicit that Flink supports mTLS. This term doesn't get mentioned in the docs, but is a common search term for this concept. -- This is an automated message from the Apache Git Servic

Re: [PR] [hotfix] Mention mTLS in SSL documentation page [flink]

2024-05-02 Thread via GitHub
flinkbot commented on PR #24755: URL: https://github.com/apache/flink/pull/24755#issuecomment-2090064080 ## CI report: * 78c85b8180d2c0e133eb7218c3f39aba81073003 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-35278] Fix occasional NPE on getting latest resource for status replace [flink-kubernetes-operator]

2024-05-02 Thread via GitHub
ferenc-csaky opened a new pull request, #823: URL: https://github.com/apache/flink-kubernetes-operator/pull/823 ## What is the purpose of the change Fix occasional NPE on getting latest resource for status replace. ## Brief change log - Added a `null`-check for `latest` a

Re: [PR] [FLINK-35278] Fix occasional NPE on getting latest resource for status replace [flink-kubernetes-operator]

2024-05-02 Thread via GitHub
ferenc-csaky commented on code in PR #823: URL: https://github.com/apache/flink-kubernetes-operator/pull/823#discussion_r1587630531 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/StatusRecorder.java: ## @@ -127,47 +128,65 @@ private void r

Re: [PR] [FLINK-21373] Add RabbitMQ SinkV2 Implementation, Port Flink version to Flink 1.19 [flink-connector-rabbitmq]

2024-05-02 Thread via GitHub
boring-cyborg[bot] commented on PR #29: URL: https://github.com/apache/flink-connector-rabbitmq/pull/29#issuecomment-2090628185 Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) -- This i

[PR] [FLINK-21373] Add RabbitMQ SinkV2 Implementation, Port Flink version to Flink 1.19 [flink-connector-rabbitmq]

2024-05-02 Thread via GitHub
vahmed-hamdy opened a new pull request, #29: URL: https://github.com/apache/flink-connector-rabbitmq/pull/29 ## Purpose of the change Add SinkV2 implemetation for RabbitMQ. ## Verifying this change Please make sure both new and modified tests in this PR follows th

Re: [PR] [FLINK-35149][cdc-composer] Fix DataSinkTranslator#sinkTo ignoring pre-write topology if not TwoPhaseCommittingSink [flink-cdc]

2024-05-02 Thread via GitHub
pvary commented on PR #3233: URL: https://github.com/apache/flink-cdc/pull/3233#issuecomment-2090855121 > > Could you please add a test case to prevent later code changes to revert this fix? > > I'd like to, but it seems no pipeline sink which is WithPreWriteTopology but not TwoPhase

Re: [PR] Add release announcement for Flink CDC 3.1.0 [flink-web]

2024-05-02 Thread via GitHub
morazow commented on code in PR #739: URL: https://github.com/apache/flink-web/pull/739#discussion_r1588306116 ## docs/content/posts/2024-MM-DD-release-cdc-3.1.0.md: ## @@ -0,0 +1,67 @@ +--- +title: "Apache Flink CDC 3.1.0 Release Announcement" +date: "2024-MM-DDT08:00:00.000Z"

Re: [PR] [FLINK-33306] Use observed source throughput as true processing rate [flink-kubernetes-operator]

2024-05-02 Thread via GitHub
trystanj commented on code in PR #686: URL: https://github.com/apache/flink-kubernetes-operator/pull/686#discussion_r1588463242 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingMetricEvaluator.java: ## @@ -154,6 +153,56 @@ private Map evaluateMetrics(

Re: [PR] [FLINK-33306] Use observed source throughput as true processing rate [flink-kubernetes-operator]

2024-05-02 Thread via GitHub
trystanj commented on code in PR #686: URL: https://github.com/apache/flink-kubernetes-operator/pull/686#discussion_r1588463242 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingMetricEvaluator.java: ## @@ -154,6 +153,56 @@ private Map evaluateMetrics(

Re: [PR] [FLINK-33306] Use observed source throughput as true processing rate [flink-kubernetes-operator]

2024-05-02 Thread via GitHub
trystanj commented on code in PR #686: URL: https://github.com/apache/flink-kubernetes-operator/pull/686#discussion_r1588463242 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingMetricEvaluator.java: ## @@ -154,6 +153,56 @@ private Map evaluateMetrics(

Re: [PR] [FLINK-33306] Use observed source throughput as true processing rate [flink-kubernetes-operator]

2024-05-02 Thread via GitHub
trystanj commented on code in PR #686: URL: https://github.com/apache/flink-kubernetes-operator/pull/686#discussion_r1588463242 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingMetricEvaluator.java: ## @@ -154,6 +153,56 @@ private Map evaluateMetrics(

Re: [PR] [FLINK-35176][Connector/JDBC] Support property authentication connection for JDBC catalog & dynamic table [flink-connector-jdbc]

2024-05-02 Thread via GitHub
RocMarshal commented on PR #116: URL: https://github.com/apache/flink-connector-jdbc/pull/116#issuecomment-2092246949 Thanks @eskabetxe for the comments. Updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [FLINK-34369][connectors/elasticsearch] Elasticsearch connector supports SSL context [flink-connector-elasticsearch]

2024-05-02 Thread via GitHub
liuml07 commented on PR #91: URL: https://github.com/apache/flink-connector-elasticsearch/pull/91#issuecomment-2092337019 Thanks for reviewing and your approval. Could you help merge this @reta? -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [PR] [FLINK-33306] Use observed source throughput as true processing rate [flink-kubernetes-operator]

2024-05-02 Thread via GitHub
gyfora commented on code in PR #686: URL: https://github.com/apache/flink-kubernetes-operator/pull/686#discussion_r1588809789 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingMetricEvaluator.java: ## @@ -154,6 +153,56 @@ private Map evaluateMetrics(

Re: [PR] Bump org.apache.commons:commons-compress from 1.24.0 to 1.26.0 [flink-connector-pulsar]

2024-05-03 Thread via GitHub
tisonkun commented on PR #83: URL: https://github.com/apache/flink-connector-pulsar/pull/83#issuecomment-2092419278 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] [FLINK-34629] Fix non-partition topic subscribe lost. [flink-connector-pulsar]

2024-05-03 Thread via GitHub
tisonkun closed pull request #84: [FLINK-34629] Fix non-partition topic subscribe lost. URL: https://github.com/apache/flink-connector-pulsar/pull/84 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [FLINK-35182] Bump org.apache.commons:commons-compress from 1.24.0 to 1.26.1 for Flink Pulsar connector [flink-connector-pulsar]

2024-05-03 Thread via GitHub
tisonkun merged PR #90: URL: https://github.com/apache/flink-connector-pulsar/pull/90 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

Re: [PR] Bump org.apache.commons:commons-compress from 1.24.0 to 1.26.0 [flink-connector-pulsar]

2024-05-03 Thread via GitHub
tisonkun closed pull request #83: Bump org.apache.commons:commons-compress from 1.24.0 to 1.26.0 URL: https://github.com/apache/flink-connector-pulsar/pull/83 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Bump org.apache.commons:commons-compress from 1.24.0 to 1.26.0 [flink-connector-pulsar]

2024-05-03 Thread via GitHub
dependabot[bot] commented on PR #83: URL: https://github.com/apache/flink-connector-pulsar/pull/83#issuecomment-2092425790 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor

Re: [PR] [FLINK-34369][connectors/elasticsearch] Elasticsearch connector supports SSL context [flink-connector-elasticsearch]

2024-05-03 Thread via GitHub
boring-cyborg[bot] commented on PR #91: URL: https://github.com/apache/flink-connector-elasticsearch/pull/91#issuecomment-2092439455 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] [FLINK-34369][connectors/elasticsearch] Elasticsearch connector supports SSL context [flink-connector-elasticsearch]

2024-05-03 Thread via GitHub
snuyanzin merged PR #91: URL: https://github.com/apache/flink-connector-elasticsearch/pull/91 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-uns

[PR] [FLINK-35287][connectors/elasticsearch] Build NetworkConfig for Elasticsearch connector 8 [flink-connector-elasticsearch]

2024-05-03 Thread via GitHub
liuml07 opened a new pull request, #100: URL: https://github.com/apache/flink-connector-elasticsearch/pull/100 https://issues.apache.org/jira/browse/FLINK-35287 > In [FLINK-26088](https://issues.apache.org/jira/browse/FLINK-26088) we added support for ElasticSearch 8.0. It is based on

Re: [PR] [FLINK-35287] Builder builds NetworkConfig for Elasticsearch connector 8 [flink-connector-elasticsearch]

2024-05-03 Thread via GitHub
liuml07 commented on code in PR #100: URL: https://github.com/apache/flink-connector-elasticsearch/pull/100#discussion_r1588846145 ## flink-connector-elasticsearch8/src/main/java/org/apache/flink/connector/elasticsearch/sink/Elasticsearch8AsyncSinkBuilder.java: ## @@ -94,7 +94,

Re: [PR] [FLINK-35287] Builder builds NetworkConfig for Elasticsearch connector 8 [flink-connector-elasticsearch]

2024-05-03 Thread via GitHub
liuml07 commented on code in PR #100: URL: https://github.com/apache/flink-connector-elasticsearch/pull/100#discussion_r1588846646 ## flink-connector-elasticsearch8/src/main/java/org/apache/flink/connector/elasticsearch/sink/Elasticsearch8AsyncSinkBuilder.java: ## @@ -108,7 +10

Re: [PR] [FLINK-21373] Add RabbitMQ SinkV2 Implementation, Port Flink version to Flink 1.19 [flink-connector-rabbitmq]

2024-05-03 Thread via GitHub
vahmed-hamdy commented on PR #29: URL: https://github.com/apache/flink-connector-rabbitmq/pull/29#issuecomment-2092561482 @MartijnVisser @zentol could you please review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] [FLINK-33212][runtime] add job status changed listener for lineage [flink]

2024-05-03 Thread via GitHub
davidradl commented on code in PR #24754: URL: https://github.com/apache/flink/pull/24754#discussion_r1588939108 ## flink-clients/src/main/java/org/apache/flink/client/program/ClusterClient.java: ## @@ -94,7 +95,18 @@ public interface ClusterClient extends AutoCloseable {

Re: [PR] [FLINK-33212][runtime] add job status changed listener for lineage [flink]

2024-05-03 Thread via GitHub
davidradl commented on code in PR #24754: URL: https://github.com/apache/flink/pull/24754#discussion_r1588938587 ## flink-clients/src/main/java/org/apache/flink/client/deployment/executors/AbstractSessionClusterExecutor.java: ## @@ -80,7 +80,7 @@ public CompletableFuture execute

Re: [PR] [FLINK-33212][runtime] add job status changed listener for lineage [flink]

2024-05-03 Thread via GitHub
davidradl commented on code in PR #24754: URL: https://github.com/apache/flink/pull/24754#discussion_r1588941192 ## flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java: ## @@ -454,6 +467,24 @@ public CompletableFuture submitJob(@Nonnull JobGr

Re: [PR] [FLINK-33212][runtime] add job status changed listener for lineage [flink]

2024-05-03 Thread via GitHub
davidradl commented on code in PR #24754: URL: https://github.com/apache/flink/pull/24754#discussion_r1588942354 ## flink-clients/src/test/java/org/apache/flink/client/program/rest/RestClusterClientTest.java: ## @@ -281,7 +281,7 @@ void testJobSubmitCancel() throws Exception {

Re: [PR] [FLINK-33212][runtime] add job status changed listener for lineage [flink]

2024-05-03 Thread via GitHub
davidradl commented on code in PR #24754: URL: https://github.com/apache/flink/pull/24754#discussion_r1588942354 ## flink-clients/src/test/java/org/apache/flink/client/program/rest/RestClusterClientTest.java: ## @@ -281,7 +281,7 @@ void testJobSubmitCancel() throws Exception {

Re: [PR] [FLINK-33306] Use observed source throughput as true processing rate [flink-kubernetes-operator]

2024-05-03 Thread via GitHub
trystanj commented on code in PR #686: URL: https://github.com/apache/flink-kubernetes-operator/pull/686#discussion_r1589140335 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingMetricEvaluator.java: ## @@ -154,6 +153,56 @@ private Map evaluateMetrics(

Re: [PR] [FLINK-33306] Use observed source throughput as true processing rate [flink-kubernetes-operator]

2024-05-03 Thread via GitHub
gyfora commented on code in PR #686: URL: https://github.com/apache/flink-kubernetes-operator/pull/686#discussion_r1589167127 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingMetricEvaluator.java: ## @@ -154,6 +153,56 @@ private Map evaluateMetrics(

Re: [PR] [FLINK-33306] Use observed source throughput as true processing rate [flink-kubernetes-operator]

2024-05-03 Thread via GitHub
gyfora commented on code in PR #686: URL: https://github.com/apache/flink-kubernetes-operator/pull/686#discussion_r1589168145 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingMetricEvaluator.java: ## @@ -154,6 +153,56 @@ private Map evaluateMetrics(

Re: [PR] [FLINK-20628] Port RabbitMQ Connector using unified Source & Sink API [flink-connector-rabbitmq]

2024-05-03 Thread via GitHub
MartijnVisser commented on PR #16: URL: https://github.com/apache/flink-connector-rabbitmq/pull/16#issuecomment-2092982954 @RocMarshal Without actually seeing a passing CI, it doesn't make much sense to review this one... -- This is an automated message from the Apache Git Service. To r

Re: [PR] [FLINK-33306] Use observed source throughput as true processing rate [flink-kubernetes-operator]

2024-05-03 Thread via GitHub
trystanj commented on code in PR #686: URL: https://github.com/apache/flink-kubernetes-operator/pull/686#discussion_r1589232955 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingMetricEvaluator.java: ## @@ -154,6 +153,56 @@ private Map evaluateMetrics(

Re: [PR] [FLINK-35287] Builder builds NetworkConfig for Elasticsearch connector 8 [flink-connector-elasticsearch]

2024-05-03 Thread via GitHub
liuml07 commented on PR #100: URL: https://github.com/apache/flink-connector-elasticsearch/pull/100#issuecomment-2093511191 @mtfelisb and @reswqa mind taking a look? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [FLINK-20628] RabbitMQ Connector using FLIP-27 Source API [flink-connector-rabbitmq]

2024-05-03 Thread via GitHub
RocMarshal commented on PR #1: URL: https://github.com/apache/flink-connector-rabbitmq/pull/1#issuecomment-2094003538 The new sink part https://github.com/apache/flink-connector-rabbitmq/pull/29 -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] [FLINK-20628] Port RabbitMQ Connector using unified Source & Sink API [flink-connector-rabbitmq]

2024-05-03 Thread via GitHub
RocMarshal commented on PR #16: URL: https://github.com/apache/flink-connector-rabbitmq/pull/16#issuecomment-2094003590 The new sink https://github.com/apache/flink-connector-rabbitmq/pull/29 -- This is an automated message from the Apache Git Service. To respond to the message, please lo

Re: [PR] [FLINK-20628] Port RabbitMQ Connector using unified Source & Sink API [flink-connector-rabbitmq]

2024-05-03 Thread via GitHub
RocMarshal commented on PR #16: URL: https://github.com/apache/flink-connector-rabbitmq/pull/16#issuecomment-2094004095 > @RocMarshal Without actually seeing a passing CI, it doesn't make much sense to review this one... Got it. I have re associated the corresponding PR informatio

Re: [PR] [FLINK-35278] Fix occasional NPE on getting latest resource for status replace [flink-kubernetes-operator]

2024-05-04 Thread via GitHub
mbalassi merged PR #823: URL: https://github.com/apache/flink-kubernetes-operator/pull/823 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubs

Re: [PR] [FLINK-35165][runtime/coordination] AdaptiveBatch Scheduler should not restrict the default source parall… [flink]

2024-05-04 Thread via GitHub
SinBex commented on code in PR #24736: URL: https://github.com/apache/flink/pull/24736#discussion_r1589991535 ## flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptivebatch/AdaptiveBatchSchedulerTest.java: ## Review Comment: We might need to verify the foll

Re: [PR] [FLINK-35240][Connectors][format]Disable FLUSH_AFTER_WRITE_VALUE to avoid flush per record for csv format [flink]

2024-05-05 Thread via GitHub
GOODBOY008 commented on PR #24730: URL: https://github.com/apache/flink/pull/24730#issuecomment-2094663611 @afedulov Would you help review this pr? Thank you~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] [FLINK-33132] Flink Connector Redshift TableSink Implementation [flink-connector-aws]

2024-05-05 Thread via GitHub
Samrat002 commented on code in PR #114: URL: https://github.com/apache/flink-connector-aws/pull/114#discussion_r1590269554 ## flink-connector-aws/flink-connector-redshift/src/main/java/org/apache/flink/connector/redshift/table/RedshiftDynamicTableFactory.java: ## @@ -0,0 +1,213

Re: [PR] [FLINK-33132] Flink Connector Redshift TableSink Implementation [flink-connector-aws]

2024-05-05 Thread via GitHub
Samrat002 commented on code in PR #114: URL: https://github.com/apache/flink-connector-aws/pull/114#discussion_r1590270090 ## flink-connector-aws/flink-connector-redshift/src/main/java/org/apache/flink/connector/redshift/table/RedshiftDynamicTableFactory.java: ## @@ -0,0 +1,213

Re: [PR] [FLINK-33132] Flink Connector Redshift TableSink Implementation [flink-connector-aws]

2024-05-05 Thread via GitHub
Samrat002 commented on PR #114: URL: https://github.com/apache/flink-connector-aws/pull/114#issuecomment-2094737962 > I have left some comments, I will continue the review later. I believe this PR is incomplete right? we still need to add tests. yes , tests were not added , since it

[PR] [FLINK-35112][Python] Fix membership for Row class PyFlink [flink]

2024-05-05 Thread via GitHub
wzorgdrager opened a new pull request, #24756: URL: https://github.com/apache/flink/pull/24756 ## What is the purpose of the change This pull request adds support for a membership check for field names in a Row in PyFlink. If field names are not defined, it will check membership i

Re: [PR] [FLINK-35112][python] Fix membership for Row class PyFlink [flink]

2024-05-05 Thread via GitHub
flinkbot commented on PR #24756: URL: https://github.com/apache/flink/pull/24756#issuecomment-2094773254 ## CI report: * ebca67d26c29e755aef515140ad2aacc6a6e6835 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-35270]Enrich information in logs, making it easier for debugging [flink]

2024-05-05 Thread via GitHub
HCTommy commented on PR #24747: URL: https://github.com/apache/flink/pull/24747#issuecomment-2094854809 Hi, @fredia . I optimized some logs, which I think is helpful for people to debug in production environment. Could you please review in your available time. -- This is an automated mess

Re: [PR] [BP-1.18][FLINK-34379][table] Fix OutOfMemoryError with large queries [flink]

2024-05-05 Thread via GitHub
jeyhunkarimov commented on PR #24744: URL: https://github.com/apache/flink/pull/24744#issuecomment-2094879998 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] [BP-1.17][FLINK-34379][table] Fix OutOfMemoryError with large queries [flink]

2024-05-05 Thread via GitHub
jeyhunkarimov commented on PR #24743: URL: https://github.com/apache/flink/pull/24743#issuecomment-2094931086 Hi @lsyldliu should be fixed now. Could you please check? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] [BP-1.18][FLINK-34379][table] Fix OutOfMemoryError with large queries [flink]

2024-05-05 Thread via GitHub
jeyhunkarimov commented on PR #24744: URL: https://github.com/apache/flink/pull/24744#issuecomment-2094931570 Hi @lsyldliu the failure was related to sth else IMO, I could not reproduce locally. In fact, retriggering the CI seems to green. -- This is an automated message from the Apache

Re: [PR] [BP-1.17][FLINK-34379][table] Fix OutOfMemoryError with large queries [flink]

2024-05-05 Thread via GitHub
lsyldliu merged PR #24743: URL: https://github.com/apache/flink/pull/24743 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

Re: [PR] [FLINK-32843][JUnit5 Migration] Migrate the jobmaster package of flink-runtime module to JUnit5 [flink]

2024-05-05 Thread via GitHub
Jiabao-Sun merged PR #24723: URL: https://github.com/apache/flink/pull/24723 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.ap

Re: [PR] [BP-1.18][FLINK-34379][table] Fix OutOfMemoryError with large queries [flink]

2024-05-05 Thread via GitHub
lsyldliu merged PR #24744: URL: https://github.com/apache/flink/pull/24744 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

Re: [PR] [BP-1.19][FLINK-34517][table]fix environment configs ignored when calling procedure operation [flink]

2024-05-05 Thread via GitHub
luoyuxia commented on PR #24656: URL: https://github.com/apache/flink/pull/24656#issuecomment-2095050182 @JustinLeesin Thanks for the pr! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] [BP-1.19][FLINK-34517][table]fix environment configs ignored when calling procedure operation [flink]

2024-05-05 Thread via GitHub
luoyuxia merged PR #24656: URL: https://github.com/apache/flink/pull/24656 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

Re: [PR] [FLINK-35244][cdc-connector][tidb] Move package for flink-connector-tidb-cdc test [flink-cdc]

2024-05-05 Thread via GitHub
Jiabao-Sun merged PR #3265: URL: https://github.com/apache/flink-cdc/pull/3265 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.

Re: [PR] [tidb] Add metrics for tidb connector [flink-cdc]

2024-05-05 Thread via GitHub
xieyi888 closed pull request #1974: [tidb] Add metrics for tidb connector URL: https://github.com/apache/flink-cdc/pull/1974 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix] repair a snapshot-split bug: [flink-cdc]

2024-05-05 Thread via GitHub
AidenPerce closed pull request #2968: [fix] repair a snapshot-split bug: URL: https://github.com/apache/flink-cdc/pull/2968 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] [FLINK-35245][cdc-connector][tidb] Add metrics for flink-connector-tidb-cdc [flink-cdc]

2024-05-05 Thread via GitHub
xieyi888 commented on code in PR #3266: URL: https://github.com/apache/flink-cdc/pull/3266#discussion_r1590486774 ## flink-cdc-connect/flink-cdc-source-connectors/flink-connector-tidb-cdc/src/test/java/org/apache/flink/cdc/connectors/tidb/metrics/TiDBSourceMetricsTest.java: ## @

Re: [PR] [FLINK-35262] Bridge between AsyncKeyedStateBackend and AsyncExecutionController [flink]

2024-05-05 Thread via GitHub
masteryhx commented on code in PR #24740: URL: https://github.com/apache/flink/pull/24740#discussion_r1590495309 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/asyncprocessing/AbstractAsyncStateStreamOperator.java: ## @@ -74,15 +76,20 @@ publi

Re: [PR] [fix] repair a snapshot-split bug: [flink-cdc]

2024-05-05 Thread via GitHub
AidenPerce commented on PR #2968: URL: https://github.com/apache/flink-cdc/pull/2968#issuecomment-2095121064 > Hi @AidenPerce, could you please rebase this PR with latest `master` branch before it could be merged? Renaming like `com.ververica.cdc` to `org.apache.flink.cdc` might be necessar

Re: [PR] [FLINK-35262] Bridge between AsyncKeyedStateBackend and AsyncExecutionController [flink]

2024-05-05 Thread via GitHub
fredia commented on code in PR #24740: URL: https://github.com/apache/flink/pull/24740#discussion_r1590503035 ## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/AsyncExecutionController.java: ## @@ -104,15 +105,21 @@ public class AsyncExecutionController imp

Re: [PR] [fix] repair a snapshot-split bug: [flink-cdc]

2024-05-05 Thread via GitHub
yuxiqian commented on PR #2968: URL: https://github.com/apache/flink-cdc/pull/2968#issuecomment-2095235515 Hi @AidenPerce, sorry about the inconvenience. I think it's related to a glitch in Db2 incremental connector and should be fixed by #3283. Will try to get it merged asap. -- This is

Re: [PR] [FLINK-35245][cdc-connector][tidb] Add metrics for flink-connector-tidb-cdc [flink-cdc]

2024-05-05 Thread via GitHub
xieyi888 commented on PR #3266: URL: https://github.com/apache/flink-cdc/pull/3266#issuecomment-2095236881 @yuxiqian @czy006 I had made changes, Please review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] [FLINK-35274][cdc-connector][db2] Fix occasional failure issue with Flink CDC Db2 UT [flink-cdc]

2024-05-05 Thread via GitHub
Jiabao-Sun merged PR #3284: URL: https://github.com/apache/flink-cdc/pull/3284 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.

Re: [PR] [FLINK-35274][cdc-connector][db2] Fix occasional failure issue with Flink CDC Db2 UT [flink-cdc]

2024-05-05 Thread via GitHub
Jiabao-Sun merged PR #3283: URL: https://github.com/apache/flink-cdc/pull/3283 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.

Re: [PR] [fix] repair a snapshot-split bug: [flink-cdc]

2024-05-05 Thread via GitHub
yuxiqian commented on PR #2968: URL: https://github.com/apache/flink-cdc/pull/2968#issuecomment-2095245702 Hi @AidenPerce, the Db2 CI fix has been merged into `master` branch, could you please rebase this PR and see if this problem persists? Thank you! -- This is an automated message from

Re: [PR] [FLINK-35161][state] Implement StateExecutor for ForStStateBackend [flink]

2024-05-05 Thread via GitHub
Zakelly commented on code in PR #24739: URL: https://github.com/apache/flink/pull/24739#discussion_r1590582493 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/ForStStateRequestClassifier.java: ## @@ -0,0 +1,103 @@ +/* + * Licensed to t

Re: [PR] [FLINK-35158][runtime] Error handling in StateFuture's callback [flink]

2024-05-05 Thread via GitHub
Zakelly commented on code in PR #24698: URL: https://github.com/apache/flink/pull/24698#discussion_r1590597054 ## flink-core/src/main/java/org/apache/flink/core/state/StateFutureImpl.java: ## @@ -61,23 +66,34 @@ public StateFuture thenApply(Function fn) { retur

Re: [PR] [FLINK-35262] Bridge between AsyncKeyedStateBackend and AsyncExecutionController [flink]

2024-05-05 Thread via GitHub
masteryhx commented on code in PR #24740: URL: https://github.com/apache/flink/pull/24740#discussion_r1590604525 ## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/AsyncExecutionController.java: ## @@ -104,15 +105,21 @@ public class AsyncExecutionController

Re: [PR] [FLINK-35262] Bridge between AsyncKeyedStateBackend and AsyncExecutionController [flink]

2024-05-05 Thread via GitHub
masteryhx commented on code in PR #24740: URL: https://github.com/apache/flink/pull/24740#discussion_r1590608598 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/StreamingRuntimeContext.java: ## @@ -242,6 +248,25 @@ private KeyedStateStore checkPre

Re: [PR] [FLINK-35262] Bridge between AsyncKeyedStateBackend and AsyncExecutionController [flink]

2024-05-05 Thread via GitHub
masteryhx commented on code in PR #24740: URL: https://github.com/apache/flink/pull/24740#discussion_r1590609918 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/ForStKeyedStateBackendBuilder.java: ## @@ -54,7 +59,14 @@ public class For

Re: [PR] [FLINK-35262] Bridge between AsyncKeyedStateBackend and AsyncExecutionController [flink]

2024-05-06 Thread via GitHub
fredia commented on code in PR #24740: URL: https://github.com/apache/flink/pull/24740#discussion_r1590611811 ## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/AsyncExecutionController.java: ## @@ -104,15 +105,21 @@ public class AsyncExecutionController imp

Re: [PR] [FLINK-35272][cdc][runtime] Transform projection & filter feature overhaul [flink-cdc]

2024-05-06 Thread via GitHub
yuxiqian commented on PR #3285: URL: https://github.com/apache/flink-cdc/pull/3285#issuecomment-2095341052 Updated based on previous comments, cc @aiwenmo -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] [FLINK-35161][state] Implement StateExecutor for ForStStateBackend [flink]

2024-05-06 Thread via GitHub
masteryhx commented on code in PR #24739: URL: https://github.com/apache/flink/pull/24739#discussion_r1590633134 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/ForStGeneralMultiGetOperation.java: ## @@ -31,75 +30,50 @@ /** * The ge

[PR] [FLINK-34212][autoscaler] Autoscaler Standalone cleans up stopped jobs to prevent memory leaks [flink-kubernetes-operator]

2024-05-06 Thread via GitHub
1996fanrui opened a new pull request, #824: URL: https://github.com/apache/flink-kubernetes-operator/pull/824 ## What is the purpose of the change Autoscaler Standalone will fetch job list, and scale them. In general, autoscaler has some cache in memory. Autoscaler Stan

Re: [PR] [FLINK-35262] Bridge between AsyncKeyedStateBackend and AsyncExecutionController [flink]

2024-05-06 Thread via GitHub
Zakelly commented on code in PR #24740: URL: https://github.com/apache/flink/pull/24740#discussion_r1590642587 ## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/AsyncExecutionController.java: ## @@ -104,15 +105,21 @@ public class AsyncExecutionController im

Re: [PR] [fix] repair a snapshot-split bug: [flink-cdc]

2024-05-06 Thread via GitHub
AidenPerce commented on PR #2968: URL: https://github.com/apache/flink-cdc/pull/2968#issuecomment-2095394855 > Hi @AidenPerce, the Db2 CI fix has been merged into `master` branch, could you please rebase this PR and see if this problem persists? Thank you! I have rebase this PR, the

Re: [PR] [fix] repair a snapshot-split bug: [flink-cdc]

2024-05-06 Thread via GitHub
AidenPerce commented on PR #2968: URL: https://github.com/apache/flink-cdc/pull/2968#issuecomment-2095403399 > Hi @AidenPerce, the Db2 CI fix has been merged into `master` branch, could you please rebase this PR and see if this problem persists? Thank you! I get a new problem, there i

Re: [PR] [FLINK-35158][runtime] Error handling in StateFuture's callback [flink]

2024-05-06 Thread via GitHub
fredia commented on code in PR #24698: URL: https://github.com/apache/flink/pull/24698#discussion_r1590672845 ## flink-core/src/main/java/org/apache/flink/core/state/StateFutureImpl.java: ## @@ -203,12 +249,29 @@ public void callbackFinished() { } @Override -publ

Re: [PR] [FLINK-35158][runtime] Error handling in StateFuture's callback [flink]

2024-05-06 Thread via GitHub
fredia commented on code in PR #24698: URL: https://github.com/apache/flink/pull/24698#discussion_r1590678974 ## flink-core/src/main/java/org/apache/flink/core/state/StateFutureImpl.java: ## @@ -46,123 +46,169 @@ public class StateFutureImpl implements InternalStateFuture {

Re: [PR] [FLINK-35158][runtime] Error handling in StateFuture's callback [flink]

2024-05-06 Thread via GitHub
fredia commented on code in PR #24698: URL: https://github.com/apache/flink/pull/24698#discussion_r1590679773 ## flink-core/src/test/java/org/apache/flink/core/state/StateFutureTest.java: ## @@ -37,19 +38,23 @@ /** Tests for {@link StateFuture} related implementations. */ pu

Re: [PR] [FLINK-35158][runtime] Error handling in StateFuture's callback [flink]

2024-05-06 Thread via GitHub
fredia commented on code in PR #24698: URL: https://github.com/apache/flink/pull/24698#discussion_r1590680460 ## flink-core/src/main/java/org/apache/flink/core/state/StateFutureImpl.java: ## @@ -46,123 +46,169 @@ public class StateFutureImpl implements InternalStateFuture {

Re: [PR] [FLINK-35158][runtime] Error handling in StateFuture's callback [flink]

2024-05-06 Thread via GitHub
fredia commented on code in PR #24698: URL: https://github.com/apache/flink/pull/24698#discussion_r1590687424 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/asyncprocessing/AbstractAsyncStateStreamOperator.java: ## @@ -78,13 +81,18 @@ public v

Re: [PR] [FLINK-32852][JUnit5 Migration] Migrate the scheduler package of flink-runtime module to JUnit5 [flink]

2024-05-06 Thread via GitHub
1996fanrui commented on PR #24732: URL: https://github.com/apache/flink/pull/24732#issuecomment-2095449772 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] Atlas changes [flink]

2024-05-06 Thread via GitHub
smileyboy2019 commented on PR #18415: URL: https://github.com/apache/flink/pull/18415#issuecomment-2095477732 Is this feature currently supported? How can I use it? Is there a Flink Atlas plugin available -- This is an automated message from the Apache Git Service. To respond to the messa

Re: [PR] [FLINK-35155] Introduce TableRuntimeException [flink]

2024-05-06 Thread via GitHub
dawidwys merged PR #24679: URL: https://github.com/apache/flink/pull/24679 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

Re: [PR] [FLINK-35112][python] Fix membership for Row class PyFlink [flink]

2024-05-06 Thread via GitHub
jectpro7 commented on code in PR #24756: URL: https://github.com/apache/flink/pull/24756#discussion_r1590740738 ## flink-python/pyflink/common/types.py: ## @@ -177,7 +177,10 @@ def of_kind(row_kind: RowKind, *args, **kwargs): return row def __contains__(self, ite

<    1   2   3   4   5   6   7   8   9   10   >