GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/4836
[FLINK-7849][hcatalog] Remove unnecessary gauva shading
see #4834.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 7849
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/4835
[FLINK-7847][avro] Fix typo in jackson shading pattern
## What is the purpose of the change
This PR fixes a funny typo in the jackson shading pattern of flink-avro.
You can merge this
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/4834
[FLINK-7846] [elasticsearch] Remove unnecessary guava shading
## What is the purpose of the change
This PR removes the guava shading from the ES2 connector. The shading is
pointless since
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4822
@aljoscha This PR can be closed since it was merged for 1.3 and master.
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4586#discussion_r144807031
--- Diff:
flink-metrics/flink-metrics-prometheus/src/main/java/org/apache/flink/metrics/prometheus/PrometheusReporter.java
---
@@ -194,66 +239,46 @@ private
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4586#discussion_r144807511
--- Diff:
flink-metrics/flink-metrics-prometheus/src/test/java/org/apache/flink/metrics/prometheus/PrometheusReporterTest.java
---
@@ -124,19 +133,6
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4586#discussion_r144805511
--- Diff:
flink-metrics/flink-metrics-prometheus/src/main/java/org/apache/flink/metrics/prometheus/PrometheusReporter.java
---
@@ -114,39 +120,78 @@ public
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4586#discussion_r144804293
--- Diff:
flink-metrics/flink-metrics-prometheus/src/main/java/org/apache/flink/metrics/prometheus/PrometheusReporter.java
---
@@ -114,39 +120,78 @@ public
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4586
Taking another look now.
---
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/4831
[FLINK-6314] [cassandra] Support user-defined Mapper options
## What is the purpose of the change
This PR allows setting MapperOptions for the cassandra POJO sink.
## Brief change
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4802
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4805
let's put iut under /jobs then for now.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4809
@razvan100 You can re-trigger the build by adding a new commit (even en
empty one). However, please don't do this for the sake of achieving a picture
perfect build (in particular for document
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4805
Often happens due to different dependency/build system versions of even OS
specific oddities. I typically just revert those changes.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4804
thanks for catching it, merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4721
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4783
merging.
---
Github user zentol closed the pull request at:
https://github.com/apache/flink/pull/4799
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4802
What do you mean when you say triggerSavepoint is not a command of the
ClusterClient? It does have a `triggerSavepoint` method.
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4802#discussion_r144027945
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -420,89 +420,72 @@ protected int list(String[] args
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4802
triggerSavepoint is also asynchronous. It is true that the list command
does not print waiting, but the savepoint commands do.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4802
I've modified the clients to return both running and finished jobs.
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4802#discussion_r144016836
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -420,89 +420,72 @@ protected int list(String[] args
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4802#discussion_r144011359
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java
---
@@ -192,6 +196,18 @@ public String cancelWithSavepoint
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4802#discussion_r144009864
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/program/ClusterClientTest.java
---
@@ -134,6 +140,25 @@ public void testClusterClientSavepoint
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4802
The reason why i went for the CompletableFuture route is to stay closes to
the current code. The CliFrontend is waiting the the response and prints
"Waiting...", which we can't do when
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/4803
[FLINK-7813] [metrics] Replace MetricRegistryThreadFactory
## What is the purpose of the change
This PR modifies the MetricRegistry to use the ExecutorThreadFactory
instead of its own
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4791
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4797
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4800
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4799
merging.
---
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/4802
[FLINK-7791] [REST][client] Integrate LIST command into RestClusterClient
## What is the purpose of the change
This PR integrates the LIST command into the RestClusterClient. This is a
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4791
+1
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4797
+1
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4698
merging.
---
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/4800
[FLINK-7808] [REST] JobDetails constructor checks size of tasksPerStaâ¦
â¦te argument
## What is the purpose of the change
This PR modifies the JobDetails constructor to verify that
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/4799
[FLINK-7807] [REST] Log exceptions in HandlerUtils methods
## What is the purpose of the change
This PR introduces a logger into the `HandlerUtils` class to log exceptions
that otherwise
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4789
merging.
---
Github user zentol closed the pull request at:
https://github.com/apache/flink/pull/4788
---
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/4792
[FLINK-7792] [tests][client] Only suppress stdout for CLI tests
## What is the purpose of the change
This PR modifies the CliFrontendTestUtils to only suppress stdout.
Previously we were
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4763
no objections, feel free to merge this.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4734
Actually, I'd like to throw out the entire handler and replace it with the
`CurrentJobsOverviewHandler`. The CurrentJobIdshandler handler is _not_ used by
the web UI as the listings of jobs in t
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4696
Looks really god now, merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4499
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4485
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4735
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4760
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4756
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4753
It appears this PR is subsumed by #4784.
---
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/4789
[FLINK-7780] [REST][Client] Define protocol for triggering savepoints
Based on #4788.
## What is the purpose of the change
This PR includes all the client-side changes necessary to
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/4788
[FLINK-7790] [REST] Unresolved query params not added to request URL
## What is the purpose of the change
This PR fixes a bug where unresolved optional parameters where still
included in
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3748
When importing guava you have to explicitly add an exclusion to
https://github.com/apache/flink/blob/master/tools/maven/suppressions.xml.
---
Github user zentol closed the pull request at:
https://github.com/apache/flink/pull/4773
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4763#discussion_r143502870
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/checkpoints/CheckpointStatistics.java
---
@@ -0,0 +1,534
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4763#discussion_r143489310
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/util/RestMapperUtils.java
---
@@ -33,8 +33,7 @@
objectMapper.enable
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4773
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4647
merging.
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4763#discussion_r143415369
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/checkpoints/CheckpointStatistics.java
---
@@ -0,0 +1,534
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4763#discussion_r143415293
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/checkpoints/CheckpointStatistics.java
---
@@ -0,0 +1,534
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4763#discussion_r143415402
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/checkpoints/CheckpointStatistics.java
---
@@ -0,0 +1,534
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4763#discussion_r143412982
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/checkpoints/CheckpointStatistics.java
---
@@ -0,0 +1,534
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4763#discussion_r143415816
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/util/RestMapperUtils.java
---
@@ -33,8 +33,7 @@
objectMapper.enable
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4763#discussion_r143413201
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/checkpoints/CheckpointStatistics.java
---
@@ -0,0 +1,534
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4763
I still have to look at the JSON generation in this PR.
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4784#discussion_r143407857
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/slot/TaskSlotTable.java
---
@@ -448,7 +448,7 @@ public boolean addTask(Task task
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4447
#4445 contains this PR, yes.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4742
@tillrohrmann We got some test-failures for the CLIFrontend caused by us
now using the ClusterClient for stop/cancel. This is purely a test construction
issue, and I'm currently fixing them.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4742
@tillrohrmann I rebased the branch (the travis failure actually occurred on
the branch after an auto-rebase by GitHub...) and now use the
ExecutorThreadFactory.
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4742#discussion_r143160231
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java
---
@@ -216,4 +219,25 @@ protected void finalizeCluster
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4742
@tillrohrmann I've addressed the second round of comments.
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4772#discussion_r142949904
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/checkpoints/TaskCheckpointStatisticDetailsHandler.java
---
@@ -0,0 +1,152
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4742#discussion_r142943570
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/JobTerminationMessageParameters.java
---
@@ -28,8 +28,8 @@
*/
public
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4742#discussion_r142933167
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/job/JobSubmitRequestBody.java
---
@@ -0,0 +1,80 @@
+/*
+ * Licensed to
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4742#discussion_r142930472
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/JobTerminationMessageParameters.java
---
@@ -28,8 +28,8 @@
*/
public
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4742#discussion_r142929069
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/program/rest/RestClusterClientTest.java
---
@@ -0,0 +1,192 @@
+/*
+ * Licensed to the
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4763
@tillrohrmann I wanted to try it out, primarily since i can mark individual
files as reviewed. For the remaining files I will once again write the comments
on github.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4774
Given that this caused instabilities shouldn't we introduce a runtime check
to make sure these options are configure correctly in relation to each other?
We should also properly document it i
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4771
maybe add a comment to the config file to not set this to debug, otherwise
+1.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4757
Do note that you don't _have_ to implement this using the
LegacyHandlerAdapter; you could also extend the AbstractRestHandler directly.
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4757#discussion_r142688438
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/JobMessageParameters.java
---
@@ -26,15 +26,16 @@
*/
public class
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4757#discussion_r142689891
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/metrics/JobMetricsHandler.java
---
@@ -18,38 +18,95 @@
package
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4757#discussion_r142689531
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/messages/JobMetricsOverview.java
---
@@ -0,0 +1,28
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4757#discussion_r142689501
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/messages/JobMetricsOverview.java
---
@@ -0,0 +1,28
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4757#discussion_r142688020
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/JobIDQueryParameter.java
---
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4757#discussion_r142689803
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/metrics/JobMetricsHandler.java
---
@@ -18,38 +18,95 @@
package
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4757#discussion_r142688520
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/JobMetricsHeaders.java
---
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4757#discussion_r142690660
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/messages/JobMetricId.java
---
@@ -0,0 +1,69 @@
+/*
+ * Licensed
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4757#discussion_r142689455
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/messages/JobMetricIdList.java
---
@@ -0,0 +1,44
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4757#discussion_r142690760
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/messages/JobMetricEntryList.java
---
@@ -0,0 +1,43
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4759
+1.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4762
You mixed up the PRs, #4761 is about the TaskEventDispatcher.
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4769#discussion_r142684336
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/AbstractFetcher.java
---
@@ -543,6
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4763
Reviewed 24 of 31 files at r1.
Review status: 21 of 26 files reviewed at latest revision, 2 unresolved
discussions, some commit checks failed.
---
*[flink
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/4773
[FLINK-7761] [examples] Include shaded guava dependency in Twitter exâ¦
With the introduction of flink-shaded the twitter connector no longer uses
the gauva dependency shipped with Flink. The build
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4518
@tillrohrmann Friendly reminder that you wanted to merge this PR.
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4767#discussion_r142637674
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/websocket/WebSocketListener.java
---
@@ -0,0 +1,27 @@
+/*
+ * Licensed to the
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4767#discussion_r142641670
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/websocket/WebSocket.java
---
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4767#discussion_r142640401
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestClient.java ---
@@ -275,4 +301,121 @@ public HttpResponseStatus getHttpResponseStatus
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4767#discussion_r142639095
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/websocket/WebSocket.java
---
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4767#discussion_r142634775
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/rest/RestEndpointITCase.java
---
@@ -325,6 +406,98 @@ public TestParameters
1901 - 2000 of 5315 matches
Mail list logo
