[GitHub] flink pull request #6245: [FLINK-9718][scala-shell]. Add enviroment variable...

2018-07-04 Thread zjffdu
Github user zjffdu commented on a diff in the pull request: https://github.com/apache/flink/pull/6245#discussion_r200060027 --- Diff: flink-scala-shell/start-script/start-scala-shell.sh --- @@ -19,6 +19,9 @@ # from scala-lang 2.10.4 +# Uncomment the following

[GitHub] flink issue #6140: [FLINK-9554] flink scala shell doesn't work in yarn mode

2018-07-04 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/flink/pull/6140 @zentol I have addressed the comments. Could you help take a look at it ? Thanks ---

[GitHub] flink pull request #6245: FLINK-9718. Add enviroment variable in start-scala...

2018-07-04 Thread zjffdu
Github user zjffdu commented on a diff in the pull request: https://github.com/apache/flink/pull/6245#discussion_r200040940 --- Diff: flink-scala-shell/start-script/start-scala-shell.sh --- @@ -19,6 +19,9 @@ # from scala-lang 2.10.4 +# Uncomment the following

[GitHub] flink pull request #6140: [FLINK-9554] flink scala shell doesn't work in yar...

2018-07-03 Thread zjffdu
Github user zjffdu commented on a diff in the pull request: https://github.com/apache/flink/pull/6140#discussion_r199817183 --- Diff: flink-scala-shell/start-script/start-scala-shell.sh --- @@ -19,6 +19,9 @@ # from scala-lang 2.10.4 +# Uncomment the following

[GitHub] flink pull request #6245: FLINK-9718. Add enviroment variable in start-scala...

2018-07-03 Thread zjffdu
GitHub user zjffdu opened a pull request: https://github.com/apache/flink/pull/6245 FLINK-9718. Add enviroment variable in start-scala-shell.sh to enable remote debug ## What is the purpose of the change Add enviroment variable `FLINK_SCALA_SHELL_JAVA_OPTS` in `start

[GitHub] flink pull request #6140: [FLINK-9554] flink scala shell doesn't work in yar...

2018-07-03 Thread zjffdu
Github user zjffdu commented on a diff in the pull request: https://github.com/apache/flink/pull/6140#discussion_r199813552 --- Diff: flink-scala-shell/start-script/start-scala-shell.sh --- @@ -19,6 +19,9 @@ # from scala-lang 2.10.4 +# Uncomment the following

[GitHub] flink pull request #6140: [FLINK-9554] flink scala shell doesn't work in yar...

2018-07-03 Thread zjffdu
Github user zjffdu commented on a diff in the pull request: https://github.com/apache/flink/pull/6140#discussion_r199750956 --- Diff: flink-scala-shell/src/main/scala/org/apache/flink/api/scala/FlinkShell.scala --- @@ -255,14 +257,25 @@ object FlinkShell

[GitHub] flink pull request #6236: [FLINK-9699]. Add api to replace registered table

2018-07-02 Thread zjffdu
GitHub user zjffdu opened a pull request: https://github.com/apache/flink/pull/6236 [FLINK-9699]. Add api to replace registered table *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your

[GitHub] flink issue #6140: [FLINK-9554] flink scala shell doesn't work in yarn mode

2018-06-12 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/flink/pull/6140 ping @tillrohrmann ---

[GitHub] flink issue #6140: [FLINK-9554] flink scala shell doesn't work in yarn mode

2018-06-07 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/flink/pull/6140 @tillrohrmann Could you help review it ? Thanks ---

[GitHub] flink pull request #6140: [FLINK-9554] flink scala shell doesn't work in yar...

2018-06-07 Thread zjffdu
GitHub user zjffdu opened a pull request: https://github.com/apache/flink/pull/6140 [FLINK-9554] flink scala shell doesn't work in yarn mode ## What is the purpose of the change This PR is trying to fix the issue of scala-shell unable to run in yarn

[GitHub] flink pull request #6131: [hotfix][docs] Fix Table API scala example code

2018-06-06 Thread zjffdu
GitHub user zjffdu opened a pull request: https://github.com/apache/flink/pull/6131 [hotfix][docs] Fix Table API scala example code This change only fix the documentation. This is a straightforward fix for the Table API of scala example code. You can merge this pull request into a