[GitHub] [flink] Myasuka commented on a change in pull request #8693: [FLINK-8871] Support to cancel checkpoing via notification

2020-05-19 Thread GitBox
Myasuka commented on a change in pull request #8693: URL: https://github.com/apache/flink/pull/8693#discussion_r427311721 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorImpl.java ## @@ -142,6 +187,13 @@ pub

[GitHub] [flink] Myasuka commented on a change in pull request #8693: [FLINK-8871] Support to cancel checkpoing via notification

2020-05-19 Thread GitBox
Myasuka commented on a change in pull request #8693: URL: https://github.com/apache/flink/pull/8693#discussion_r427308234 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorImpl.java ## @@ -126,6 +162,15 @@ pub

[GitHub] [flink] Myasuka commented on a change in pull request #8693: [FLINK-8871] Support to cancel checkpoing via notification

2020-05-19 Thread GitBox
Myasuka commented on a change in pull request #8693: URL: https://github.com/apache/flink/pull/8693#discussion_r427304005 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/AsyncCheckpointRunnables.java ## @@ -0,0 +1,85 @@ +/* + * License

[GitHub] [flink] Myasuka commented on a change in pull request #8693: [FLINK-8871] Support to cancel checkpoing via notification

2020-05-19 Thread GitBox
Myasuka commented on a change in pull request #8693: URL: https://github.com/apache/flink/pull/8693#discussion_r427242832 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorImpl.java ## @@ -328,6 +421,7 @@ priv

[GitHub] [flink] Myasuka commented on a change in pull request #8693: [FLINK-8871] Support to cancel checkpoing via notification

2020-05-19 Thread GitBox
Myasuka commented on a change in pull request #8693: URL: https://github.com/apache/flink/pull/8693#discussion_r427241868 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/AsyncCheckpointRunnables.java ## @@ -0,0 +1,85 @@ +/* + * License

[GitHub] [flink] Myasuka commented on a change in pull request #8693: [FLINK-8871] Support to cancel checkpoing via notification

2020-05-19 Thread GitBox
Myasuka commented on a change in pull request #8693: URL: https://github.com/apache/flink/pull/8693#discussion_r427241152 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/AsyncCheckpointRunnables.java ## @@ -0,0 +1,85 @@ +/* + * License

[GitHub] [flink] Myasuka commented on a change in pull request #8693: [FLINK-8871] Support to cancel checkpoing via notification

2020-05-19 Thread GitBox
Myasuka commented on a change in pull request #8693: URL: https://github.com/apache/flink/pull/8693#discussion_r427241152 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/AsyncCheckpointRunnables.java ## @@ -0,0 +1,85 @@ +/* + * License

[GitHub] [flink] Myasuka commented on a change in pull request #8693: [FLINK-8871] Support to cancel checkpoing via notification

2020-05-19 Thread GitBox
Myasuka commented on a change in pull request #8693: URL: https://github.com/apache/flink/pull/8693#discussion_r427237171 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorImpl.java ## @@ -126,6 +162,15 @@ pub

[GitHub] [flink] Myasuka commented on a change in pull request #8693: [FLINK-8871] Support to cancel checkpoing via notification

2020-05-19 Thread GitBox
Myasuka commented on a change in pull request #8693: URL: https://github.com/apache/flink/pull/8693#discussion_r427200197 ## File path: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/snapshot/RocksIncrementalSnapshotStrategy.java

[GitHub] [flink] Myasuka commented on a change in pull request #8693: [FLINK-8871] Support to cancel checkpoing via notification

2020-05-19 Thread GitBox
Myasuka commented on a change in pull request #8693: URL: https://github.com/apache/flink/pull/8693#discussion_r427199108 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorImpl.java ## @@ -384,4 +478,12 @@ pri

[GitHub] [flink] Myasuka commented on a change in pull request #8693: [FLINK-8871] Support to cancel checkpoing via notification

2020-05-19 Thread GitBox
Myasuka commented on a change in pull request #8693: URL: https://github.com/apache/flink/pull/8693#discussion_r427197535 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorImpl.java ## @@ -142,6 +187,13 @@ pub

[GitHub] [flink] Myasuka commented on a change in pull request #8693: [FLINK-8871] Support to cancel checkpoing via notification

2020-05-19 Thread GitBox
Myasuka commented on a change in pull request #8693: URL: https://github.com/apache/flink/pull/8693#discussion_r427189273 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorImpl.java ## @@ -126,6 +162,15 @@ pub

[GitHub] [flink] Myasuka commented on a change in pull request #8693: [FLINK-8871] Support to cancel checkpoing via notification

2020-05-19 Thread GitBox
Myasuka commented on a change in pull request #8693: URL: https://github.com/apache/flink/pull/8693#discussion_r427178134 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/AsyncCheckpointRunnables.java ## @@ -0,0 +1,85 @@ +/* + * License

[GitHub] [flink] Myasuka commented on a change in pull request #8693: [FLINK-8871] Support to cancel checkpoing via notification

2020-05-19 Thread GitBox
Myasuka commented on a change in pull request #8693: URL: https://github.com/apache/flink/pull/8693#discussion_r427169675 ## File path: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/snapshot/RocksIncrementalSnapshotStrategy.java

[GitHub] [flink] Myasuka commented on a change in pull request #8693: [FLINK-8871] Support to cancel checkpoing via notification

2020-05-17 Thread GitBox
Myasuka commented on a change in pull request #8693: URL: https://github.com/apache/flink/pull/8693#discussion_r426365219 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/CheckpointListener.java ## @@ -38,4 +38,12 @@ * @throws Exception

[GitHub] [flink] Myasuka commented on a change in pull request #8693: [FLINK-8871] Support to cancel checkpoing via notification

2020-05-17 Thread GitBox
Myasuka commented on a change in pull request #8693: URL: https://github.com/apache/flink/pull/8693#discussion_r426360979 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorImpl.java ## @@ -183,6 +235,42 @@ pub

[GitHub] [flink] Myasuka commented on a change in pull request #8693: [FLINK-8871] Support to cancel checkpoing via notification

2020-05-15 Thread GitBox
Myasuka commented on a change in pull request #8693: URL: https://github.com/apache/flink/pull/8693#discussion_r425831503 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java ## @@ -182,7 +181,7 @@ protected final Ti

[GitHub] [flink] Myasuka commented on a change in pull request #8693: [FLINK-8871] Support to cancel checkpoing via notification

2020-05-15 Thread GitBox
Myasuka commented on a change in pull request #8693: URL: https://github.com/apache/flink/pull/8693#discussion_r425831503 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java ## @@ -182,7 +181,7 @@ protected final Ti

[GitHub] [flink] Myasuka commented on a change in pull request #8693: [FLINK-8871] Support to cancel checkpoing via notification

2020-05-15 Thread GitBox
Myasuka commented on a change in pull request #8693: URL: https://github.com/apache/flink/pull/8693#discussion_r425713504 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorImpl.java ## @@ -183,6 +235,42 @@ pub

[GitHub] [flink] Myasuka commented on a change in pull request #8693: [FLINK-8871] Support to cancel checkpoing via notification

2020-05-15 Thread GitBox
Myasuka commented on a change in pull request #8693: URL: https://github.com/apache/flink/pull/8693#discussion_r425713933 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorImpl.java ## @@ -183,6 +235,42 @@ pub

[GitHub] [flink] Myasuka commented on a change in pull request #8693: [FLINK-8871] Support to cancel checkpoing via notification

2020-05-15 Thread GitBox
Myasuka commented on a change in pull request #8693: URL: https://github.com/apache/flink/pull/8693#discussion_r425713504 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorImpl.java ## @@ -183,6 +235,42 @@ pub

[GitHub] [flink] Myasuka commented on a change in pull request #8693: [FLINK-8871] Support to cancel checkpoing via notification

2020-05-15 Thread GitBox
Myasuka commented on a change in pull request #8693: URL: https://github.com/apache/flink/pull/8693#discussion_r425668412 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorImpl.java ## @@ -183,6 +235,42 @@ pub

[GitHub] [flink] Myasuka commented on a change in pull request #8693: [FLINK-8871] Support to cancel checkpoing via notification

2020-05-14 Thread GitBox
Myasuka commented on a change in pull request #8693: URL: https://github.com/apache/flink/pull/8693#discussion_r425549498 ## File path: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java ## @@ -4

[GitHub] [flink] Myasuka commented on a change in pull request #8693: [FLINK-8871] Support to cancel checkpoing via notification

2020-05-14 Thread GitBox
Myasuka commented on a change in pull request #8693: URL: https://github.com/apache/flink/pull/8693#discussion_r425361635 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapKeyedStateBackend.java ## @@ -311,6 +311,11 @@ public void notifyCheckpoi

[GitHub] [flink] Myasuka commented on a change in pull request #8693: [FLINK-8871] Support to cancel checkpoing via notification

2020-05-14 Thread GitBox
Myasuka commented on a change in pull request #8693: URL: https://github.com/apache/flink/pull/8693#discussion_r425359640 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorImpl.java ## @@ -60,17 +63,22 @@ cla

[GitHub] [flink] Myasuka commented on a change in pull request #8693: [FLINK-8871] Support to cancel checkpoing via notification

2020-05-13 Thread GitBox
Myasuka commented on a change in pull request #8693: URL: https://github.com/apache/flink/pull/8693#discussion_r424901092 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorImpl.java ## @@ -183,6 +209,41 @@ pub

[GitHub] [flink] Myasuka commented on a change in pull request #8693: [FLINK-8871] Support to cancel checkpoing via notification

2020-05-13 Thread GitBox
Myasuka commented on a change in pull request #8693: URL: https://github.com/apache/flink/pull/8693#discussion_r424899752 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java ## @@ -182,7 +181,7 @@ protected final Ti

[GitHub] [flink] Myasuka commented on a change in pull request #8693: [FLINK-8871] Support to cancel checkpoing via notification

2020-05-13 Thread GitBox
Myasuka commented on a change in pull request #8693: URL: https://github.com/apache/flink/pull/8693#discussion_r424875892 ## File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorTest.java ## @@ -58,4 +83,212 @@ publ

[GitHub] [flink] Myasuka commented on a change in pull request #8693: [FLINK-8871] Support to cancel checkpoing via notification

2020-05-13 Thread GitBox
Myasuka commented on a change in pull request #8693: URL: https://github.com/apache/flink/pull/8693#discussion_r424851251 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/state/TaskLocalStateStoreImplTest.java ## @@ -153,6 +153,21 @@ public void confirmCheckp