[GitHub] [flink] XComp commented on a change in pull request #18692: [FLINK-26015] Fixes object store bug

2022-02-15 Thread GitBox
XComp commented on a change in pull request #18692: URL: https://github.com/apache/flink/pull/18692#discussion_r806086781 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/FileSystemJobResultStore.java ## @@ -52,7 +52,18 @@ */ public class

[GitHub] [flink] XComp commented on a change in pull request #18692: [FLINK-26015] Fixes object store bug

2022-02-15 Thread GitBox
XComp commented on a change in pull request #18692: URL: https://github.com/apache/flink/pull/18692#discussion_r806857666 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/FileSystemJobResultStore.java ## @@ -155,18 +155,15 @@ public boolean

[GitHub] [flink] XComp commented on a change in pull request #18692: [FLINK-26015] Fixes object store bug

2022-02-15 Thread GitBox
XComp commented on a change in pull request #18692: URL: https://github.com/apache/flink/pull/18692#discussion_r804187457 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/FileSystemJobResultStore.java ## @@ -155,18 +155,15 @@ public boolean

[GitHub] [flink] XComp commented on a change in pull request #18692: [FLINK-26015] Fixes object store bug

2022-02-14 Thread GitBox
XComp commented on a change in pull request #18692: URL: https://github.com/apache/flink/pull/18692#discussion_r806121339 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/highavailability/AbstractHaJobRunITCase.java ## @@ -0,0 +1,133 @@ +/* + * Licensed to

[GitHub] [flink] XComp commented on a change in pull request #18692: [FLINK-26015] Fixes object store bug

2022-02-14 Thread GitBox
XComp commented on a change in pull request #18692: URL: https://github.com/apache/flink/pull/18692#discussion_r806086781 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/FileSystemJobResultStore.java ## @@ -52,7 +52,18 @@ */ public class

[GitHub] [flink] XComp commented on a change in pull request #18692: [FLINK-26015] Fixes object store bug

2022-02-14 Thread GitBox
XComp commented on a change in pull request #18692: URL: https://github.com/apache/flink/pull/18692#discussion_r805876545 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/highavailability/AbstractHaJobRunITCase.java ## @@ -0,0 +1,133 @@ +/* + * Licensed to

[GitHub] [flink] XComp commented on a change in pull request #18692: [FLINK-26015] Fixes object store bug

2022-02-14 Thread GitBox
XComp commented on a change in pull request #18692: URL: https://github.com/apache/flink/pull/18692#discussion_r805874471 ## File path: flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/util/DockerImageVersions.java ## @@ -45,4 +45,6 @@ public

[GitHub] [flink] XComp commented on a change in pull request #18692: [FLINK-26015] Fixes object store bug

2022-02-14 Thread GitBox
XComp commented on a change in pull request #18692: URL: https://github.com/apache/flink/pull/18692#discussion_r805792824 ## File path: flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/util/DockerImageVersions.java ## @@ -45,4 +45,6 @@ public

[GitHub] [flink] XComp commented on a change in pull request #18692: [FLINK-26015] Fixes object store bug

2022-02-14 Thread GitBox
XComp commented on a change in pull request #18692: URL: https://github.com/apache/flink/pull/18692#discussion_r805792824 ## File path: flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/util/DockerImageVersions.java ## @@ -45,4 +45,6 @@ public

[GitHub] [flink] XComp commented on a change in pull request #18692: [FLINK-26015] Fixes object store bug

2022-02-14 Thread GitBox
XComp commented on a change in pull request #18692: URL: https://github.com/apache/flink/pull/18692#discussion_r805781523 ## File path: flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/util/DockerImageVersions.java ## @@ -45,4 +45,6 @@ public

[GitHub] [flink] XComp commented on a change in pull request #18692: [FLINK-26015] Fixes object store bug

2022-02-14 Thread GitBox
XComp commented on a change in pull request #18692: URL: https://github.com/apache/flink/pull/18692#discussion_r805781523 ## File path: flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/util/DockerImageVersions.java ## @@ -45,4 +45,6 @@ public

[GitHub] [flink] XComp commented on a change in pull request #18692: [FLINK-26015] Fixes object store bug

2022-02-14 Thread GitBox
XComp commented on a change in pull request #18692: URL: https://github.com/apache/flink/pull/18692#discussion_r805781523 ## File path: flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/util/DockerImageVersions.java ## @@ -45,4 +45,6 @@ public

[GitHub] [flink] XComp commented on a change in pull request #18692: [FLINK-26015] Fixes object store bug

2022-02-14 Thread GitBox
XComp commented on a change in pull request #18692: URL: https://github.com/apache/flink/pull/18692#discussion_r805781523 ## File path: flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/util/DockerImageVersions.java ## @@ -45,4 +45,6 @@ public

[GitHub] [flink] XComp commented on a change in pull request #18692: [FLINK-26015] Fixes object store bug

2022-02-11 Thread GitBox
XComp commented on a change in pull request #18692: URL: https://github.com/apache/flink/pull/18692#discussion_r804570972 ## File path: flink-filesystems/flink-s3-fs-base/pom.xml ## @@ -235,6 +265,27 @@ under the License. true

[GitHub] [flink] XComp commented on a change in pull request #18692: [FLINK-26015] Fixes object store bug

2022-02-11 Thread GitBox
XComp commented on a change in pull request #18692: URL: https://github.com/apache/flink/pull/18692#discussion_r804518375 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/highavailability/AbstractHaJobRunITCase.java ## @@ -0,0 +1,127 @@ +/* + * Licensed to

[GitHub] [flink] XComp commented on a change in pull request #18692: [FLINK-26015] Fixes object store bug

2022-02-11 Thread GitBox
XComp commented on a change in pull request #18692: URL: https://github.com/apache/flink/pull/18692#discussion_r804498412 ## File path: flink-filesystems/flink-s3-fs-base/pom.xml ## @@ -221,6 +221,36 @@ under the License.

[GitHub] [flink] XComp commented on a change in pull request #18692: [FLINK-26015] Fixes object store bug

2022-02-11 Thread GitBox
XComp commented on a change in pull request #18692: URL: https://github.com/apache/flink/pull/18692#discussion_r804498412 ## File path: flink-filesystems/flink-s3-fs-base/pom.xml ## @@ -221,6 +221,36 @@ under the License.

[GitHub] [flink] XComp commented on a change in pull request #18692: [FLINK-26015] Fixes object store bug

2022-02-11 Thread GitBox
XComp commented on a change in pull request #18692: URL: https://github.com/apache/flink/pull/18692#discussion_r804187457 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/FileSystemJobResultStore.java ## @@ -155,18 +155,15 @@ public boolean

[GitHub] [flink] XComp commented on a change in pull request #18692: [FLINK-26015] Fixes object store bug

2022-02-10 Thread GitBox
XComp commented on a change in pull request #18692: URL: https://github.com/apache/flink/pull/18692#discussion_r804199654 ## File path: flink-core/src/main/java/org/apache/flink/core/fs/FileSystem.java ## @@ -588,8 +588,10 @@ public static URI getDefaultFsUri() { *

[GitHub] [flink] XComp commented on a change in pull request #18692: [FLINK-26015] Fixes object store bug

2022-02-10 Thread GitBox
XComp commented on a change in pull request #18692: URL: https://github.com/apache/flink/pull/18692#discussion_r804187457 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/FileSystemJobResultStore.java ## @@ -155,18 +155,15 @@ public boolean

[GitHub] [flink] XComp commented on a change in pull request #18692: [FLINK-26015] Fixes object store bug

2022-02-10 Thread GitBox
XComp commented on a change in pull request #18692: URL: https://github.com/apache/flink/pull/18692#discussion_r804187457 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/FileSystemJobResultStore.java ## @@ -155,18 +155,15 @@ public boolean

[GitHub] [flink] XComp commented on a change in pull request #18692: [FLINK-26015] Fixes object store bug

2022-02-10 Thread GitBox
XComp commented on a change in pull request #18692: URL: https://github.com/apache/flink/pull/18692#discussion_r804182029 ## File path: flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/util/DockerImageVersions.java ## @@ -45,4 +45,6 @@ public

[GitHub] [flink] XComp commented on a change in pull request #18692: [FLINK-26015] Fixes object store bug

2022-02-10 Thread GitBox
XComp commented on a change in pull request #18692: URL: https://github.com/apache/flink/pull/18692#discussion_r804179821 ## File path: flink-filesystems/flink-s3-fs-presto/src/test/java/org/apache/flink/fs/s3presto/MinioTestContainer.java ## @@ -0,0 +1,146 @@ +/* + *

[GitHub] [flink] XComp commented on a change in pull request #18692: [FLINK-26015] Fixes object store bug

2022-02-10 Thread GitBox
XComp commented on a change in pull request #18692: URL: https://github.com/apache/flink/pull/18692#discussion_r804177584 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/highavailability/AbstractHaJobRunITCase.java ## @@ -0,0 +1,133 @@ +/* + * Licensed to

[GitHub] [flink] XComp commented on a change in pull request #18692: [FLINK-26015] Fixes object store bug

2022-02-10 Thread GitBox
XComp commented on a change in pull request #18692: URL: https://github.com/apache/flink/pull/18692#discussion_r804176021 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/highavailability/AbstractHaJobRunITCase.java ## @@ -0,0 +1,133 @@ +/* + * Licensed to

[GitHub] [flink] XComp commented on a change in pull request #18692: [FLINK-26015] Fixes object store bug

2022-02-10 Thread GitBox
XComp commented on a change in pull request #18692: URL: https://github.com/apache/flink/pull/18692#discussion_r804175066 ## File path: flink-filesystems/flink-s3-fs-presto/src/test/java/org/apache/flink/fs/s3presto/MinioTestContainerTest.java ## @@ -0,0 +1,117 @@ +/* + *

[GitHub] [flink] XComp commented on a change in pull request #18692: [FLINK-26015] Fixes object store bug

2022-02-10 Thread GitBox
XComp commented on a change in pull request #18692: URL: https://github.com/apache/flink/pull/18692#discussion_r804168911 ## File path: flink-filesystems/flink-s3-fs-presto/src/test/java/org/apache/flink/fs/s3presto/MinioTestContainer.java ## @@ -0,0 +1,146 @@ +/* + *

[GitHub] [flink] XComp commented on a change in pull request #18692: [FLINK-26015] Fixes object store bug

2022-02-10 Thread GitBox
XComp commented on a change in pull request #18692: URL: https://github.com/apache/flink/pull/18692#discussion_r804166962 ## File path: flink-filesystems/flink-s3-fs-presto/src/test/java/org/apache/flink/fs/s3presto/MinioTestContainer.java ## @@ -0,0 +1,146 @@ +/* + *

[GitHub] [flink] XComp commented on a change in pull request #18692: [FLINK-26015] Fixes object store bug

2022-02-10 Thread GitBox
XComp commented on a change in pull request #18692: URL: https://github.com/apache/flink/pull/18692#discussion_r804161565 ## File path: flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/core/testutils/TestContainerExtension.java ## @@ -0,0 +1,72 @@

[GitHub] [flink] XComp commented on a change in pull request #18692: [FLINK-26015] Fixes object store bug

2022-02-10 Thread GitBox
XComp commented on a change in pull request #18692: URL: https://github.com/apache/flink/pull/18692#discussion_r804103917 ## File path: flink-filesystems/flink-s3-fs-presto/src/test/java/org/apache/flink/fs/s3presto/MinioTestContainer.java ## @@ -0,0 +1,146 @@ +/* + *

[GitHub] [flink] XComp commented on a change in pull request #18692: [FLINK-26015] Fixes object store bug

2022-02-10 Thread GitBox
XComp commented on a change in pull request #18692: URL: https://github.com/apache/flink/pull/18692#discussion_r803608001 ## File path: flink-filesystems/flink-s3-fs-presto/pom.xml ## @@ -46,6 +46,36 @@ under the License. provided +

[GitHub] [flink] XComp commented on a change in pull request #18692: [FLINK-26015] Fixes object store bug

2022-02-10 Thread GitBox
XComp commented on a change in pull request #18692: URL: https://github.com/apache/flink/pull/18692#discussion_r803484034 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/highavailability/AbstractHaJobRunITCase.java ## @@ -0,0 +1,133 @@ +/* + * Licensed to

[GitHub] [flink] XComp commented on a change in pull request #18692: [FLINK-26015] Fixes object store bug

2022-02-10 Thread GitBox
XComp commented on a change in pull request #18692: URL: https://github.com/apache/flink/pull/18692#discussion_r803481934 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/highavailability/AbstractHaJobRunITCase.java ## @@ -0,0 +1,133 @@ +/* + * Licensed to