curcur commented on pull request #15636:
URL: https://github.com/apache/flink/pull/15636#issuecomment-821800955
Hey, @rkhachatryan , I've done with the review.
1. Overall the logic is pretty clear, please refer to a few of my comments.
2. The exactly-once end2end test is too simple
curcur commented on pull request #15636:
URL: https://github.com/apache/flink/pull/15636#issuecomment-822598829
Thanks, @rkhachatryan for the fix. I am mostly fine with this PR with
one-or-two places not completely understand. Let's sync up offline tomorrow.
Besides that, I think
curcur commented on pull request #15636:
URL: https://github.com/apache/flink/pull/15636#issuecomment-822987125
I've done with the tests as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
curcur commented on pull request #15636:
URL: https://github.com/apache/flink/pull/15636#issuecomment-823218830
Thanks for fixing this @rkhachatryan !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g