[GitHub] [flink] dawidwys commented on a diff in pull request #22785: [FLINK-32259]-table-Add-ARRAY_JOIN-function

2023-06-28 Thread via GitHub
dawidwys commented on code in PR #22785: URL: https://github.com/apache/flink/pull/22785#discussion_r1245352800 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArrayJoinFunction.java: ## @@ -0,0 +1,104 @@ +/* + * Licensed to the A

[GitHub] [flink] dawidwys commented on a diff in pull request #22785: [FLINK-32259]-table-Add-ARRAY_JOIN-function

2023-06-28 Thread via GitHub
dawidwys commented on code in PR #22785: URL: https://github.com/apache/flink/pull/22785#discussion_r1245352800 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArrayJoinFunction.java: ## @@ -0,0 +1,104 @@ +/* + * Licensed to the A

[GitHub] [flink] dawidwys commented on a diff in pull request #22785: [FLINK-32259]-table-Add-ARRAY_JOIN-function

2023-06-28 Thread via GitHub
dawidwys commented on code in PR #22785: URL: https://github.com/apache/flink/pull/22785#discussion_r1245075496 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArrayJoinFunction.java: ## @@ -0,0 +1,104 @@ +/* + * Licensed to the A

[GitHub] [flink] dawidwys commented on a diff in pull request #22785: [FLINK-32259]-table-Add-ARRAY_JOIN-function

2023-06-28 Thread via GitHub
dawidwys commented on code in PR #22785: URL: https://github.com/apache/flink/pull/22785#discussion_r1245075496 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArrayJoinFunction.java: ## @@ -0,0 +1,104 @@ +/* + * Licensed to the A

[GitHub] [flink] dawidwys commented on a diff in pull request #22785: [FLINK-32259]-table-Add-ARRAY_JOIN-function

2023-06-28 Thread via GitHub
dawidwys commented on code in PR #22785: URL: https://github.com/apache/flink/pull/22785#discussion_r1245072806 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/ArrayOfStringArgumentTypeStrategy.java: ## @@ -0,0 +1,72 @@ +/* + * L

[GitHub] [flink] dawidwys commented on a diff in pull request #22785: [FLINK-32259]-table-Add-ARRAY_JOIN-function

2023-06-28 Thread via GitHub
dawidwys commented on code in PR #22785: URL: https://github.com/apache/flink/pull/22785#discussion_r1245071130 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CollectionFunctionsITCase.java: ## @@ -479,4 +481,309 @@ private Stream array

[GitHub] [flink] dawidwys commented on a diff in pull request #22785: [FLINK-32259]-table-Add-ARRAY_JOIN-function

2023-06-27 Thread via GitHub
dawidwys commented on code in PR #22785: URL: https://github.com/apache/flink/pull/22785#discussion_r1243696355 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArrayJoinFunction.java: ## @@ -0,0 +1,78 @@ +/* + * Licensed to the Ap

[GitHub] [flink] dawidwys commented on a diff in pull request #22785: [FLINK-32259]-table-Add-ARRAY_JOIN-function

2023-06-27 Thread via GitHub
dawidwys commented on code in PR #22785: URL: https://github.com/apache/flink/pull/22785#discussion_r1243647774 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArrayJoinFunction.java: ## @@ -0,0 +1,78 @@ +/* + * Licensed to the Ap

[GitHub] [flink] dawidwys commented on a diff in pull request #22785: [FLINK-32259]-table-Add-ARRAY_JOIN-function

2023-06-27 Thread via GitHub
dawidwys commented on code in PR #22785: URL: https://github.com/apache/flink/pull/22785#discussion_r1243613710 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/ArrayOfStringArgumentTypeStrategy.java: ## @@ -0,0 +1,94 @@ +/* + * L

[GitHub] [flink] dawidwys commented on a diff in pull request #22785: [FLINK-32259]-table-Add-ARRAY_JOIN-function

2023-06-26 Thread via GitHub
dawidwys commented on code in PR #22785: URL: https://github.com/apache/flink/pull/22785#discussion_r1242395208 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/BaseExpressions.java: ## @@ -1408,6 +1409,24 @@ public OutType arrayUnion(InType