[GitHub] [flink] fapaul commented on a change in pull request #18612: [FLINK-25573][kafka] Migrate KafkaSink to SinkV2

fapaul commented on a change in pull request #18612: URL: https://github.com/apache/flink/pull/18612#discussion_r799412717 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/connector/sink/SinkV2Provider.java ## @@ -0,0 +1,59 @@ +/* + * Licensed

[GitHub] [flink] fapaul commented on a change in pull request #18612: [FLINK-25573][kafka] Migrate KafkaSink to SinkV2

fapaul commented on a change in pull request #18612: URL: https://github.com/apache/flink/pull/18612#discussion_r798725902 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/sink/InitContextInitializationContextAdapter.java ## @@

[GitHub] [flink] fapaul commented on a change in pull request #18612: [FLINK-25573][kafka] Migrate KafkaSink to SinkV2

fapaul commented on a change in pull request #18612: URL: https://github.com/apache/flink/pull/18612#discussion_r798727583 ## File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaSink.java ## @@ -57,7 +54,9 @@ * @see

[GitHub] [flink] fapaul commented on a change in pull request #18612: [FLINK-25573][kafka] Migrate KafkaSink to SinkV2

fapaul commented on a change in pull request #18612: URL: https://github.com/apache/flink/pull/18612#discussion_r798725902 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/sink/InitContextInitializationContextAdapter.java ## @@

[GitHub] [flink] fapaul commented on a change in pull request #18612: [FLINK-25573][kafka] Migrate KafkaSink to SinkV2

fapaul commented on a change in pull request #18612: URL: https://github.com/apache/flink/pull/18612#discussion_r798723894 ## File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaWriter.java ## @@ -65,7 +69,9 @@ * *

[GitHub] [flink] fapaul commented on a change in pull request #18612: [FLINK-25573][kafka] Migrate KafkaSink to SinkV2

fapaul commented on a change in pull request #18612: URL: https://github.com/apache/flink/pull/18612#discussion_r798722058 ## File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaSink.java ## @@ -86,45 +85,48 @@

[GitHub] [flink] fapaul commented on a change in pull request #18612: [FLINK-25573][kafka] Migrate KafkaSink to SinkV2

fapaul commented on a change in pull request #18612: URL: https://github.com/apache/flink/pull/18612#discussion_r798722386 ## File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaSink.java ## @@ -86,45 +85,48 @@