[GitHub] [flink] guoweiM commented on a change in pull request #14734: [FLINK-21066][runtime][checkpoint] Refactor CheckpointCoordinator to compute tasks to trigger/ack/commit dynamically

2021-01-31 Thread GitBox
guoweiM commented on a change in pull request #14734: URL: https://github.com/apache/flink/pull/14734#discussion_r567541421 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java ## @@ -563,7 +554,7 @@ private void startTrigge

[GitHub] [flink] guoweiM commented on a change in pull request #14734: [FLINK-21066][runtime][checkpoint] Refactor CheckpointCoordinator to compute tasks to trigger/ack/commit dynamically

2021-01-31 Thread GitBox
guoweiM commented on a change in pull request #14734: URL: https://github.com/apache/flink/pull/14734#discussion_r567528797 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointBriefCalculator.java ## @@ -0,0 +1,127 @@ +/* + * Licensed to the

[GitHub] [flink] guoweiM commented on a change in pull request #14734: [FLINK-21066][runtime][checkpoint] Refactor CheckpointCoordinator to compute tasks to trigger/ack/commit dynamically

2021-01-27 Thread GitBox
guoweiM commented on a change in pull request #14734: URL: https://github.com/apache/flink/pull/14734#discussion_r565321454 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java ## @@ -1924,7 +1918,8 @@ private void abortPendi

[GitHub] [flink] guoweiM commented on a change in pull request #14734: [FLINK-21066][runtime][checkpoint] Refactor CheckpointCoordinator to compute tasks to trigger/ack/commit dynamically

2021-01-27 Thread GitBox
guoweiM commented on a change in pull request #14734: URL: https://github.com/apache/flink/pull/14734#discussion_r565321454 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java ## @@ -1924,7 +1918,8 @@ private void abortPendi

[GitHub] [flink] guoweiM commented on a change in pull request #14734: [FLINK-21066][runtime][checkpoint] Refactor CheckpointCoordinator to compute tasks to trigger/ack/commit dynamically

2021-01-27 Thread GitBox
guoweiM commented on a change in pull request #14734: URL: https://github.com/apache/flink/pull/14734#discussion_r565315896 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointBrief.java ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Sof

[GitHub] [flink] guoweiM commented on a change in pull request #14734: [FLINK-21066][runtime][checkpoint] Refactor CheckpointCoordinator to compute tasks to trigger/ack/commit dynamically

2021-01-27 Thread GitBox
guoweiM commented on a change in pull request #14734: URL: https://github.com/apache/flink/pull/14734#discussion_r565315896 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointBrief.java ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Sof

[GitHub] [flink] guoweiM commented on a change in pull request #14734: [FLINK-21066][runtime][checkpoint] Refactor CheckpointCoordinator to compute tasks to trigger/ack/commit dynamically

2021-01-27 Thread GitBox
guoweiM commented on a change in pull request #14734: URL: https://github.com/apache/flink/pull/14734#discussion_r565315896 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointBrief.java ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Sof

[GitHub] [flink] guoweiM commented on a change in pull request #14734: [FLINK-21066][runtime][checkpoint] Refactor CheckpointCoordinator to compute tasks to trigger/ack/commit dynamically

2021-01-27 Thread GitBox
guoweiM commented on a change in pull request #14734: URL: https://github.com/apache/flink/pull/14734#discussion_r565277280 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointBriefComputer.java ## @@ -0,0 +1,120 @@ +/* + * Licensed to the A

[GitHub] [flink] guoweiM commented on a change in pull request #14734: [FLINK-21066][runtime][checkpoint] Refactor CheckpointCoordinator to compute tasks to trigger/ack/commit dynamically

2021-01-27 Thread GitBox
guoweiM commented on a change in pull request #14734: URL: https://github.com/apache/flink/pull/14734#discussion_r565277280 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointBriefComputer.java ## @@ -0,0 +1,120 @@ +/* + * Licensed to the A

[GitHub] [flink] guoweiM commented on a change in pull request #14734: [FLINK-21066][runtime][checkpoint] Refactor CheckpointCoordinator to compute tasks to trigger/ack/commit dynamically

2021-01-27 Thread GitBox
guoweiM commented on a change in pull request #14734: URL: https://github.com/apache/flink/pull/14734#discussion_r565277280 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointBriefComputer.java ## @@ -0,0 +1,120 @@ +/* + * Licensed to the A

[GitHub] [flink] guoweiM commented on a change in pull request #14734: [FLINK-21066][runtime][checkpoint] Refactor CheckpointCoordinator to compute tasks to trigger/ack/commit dynamically

2021-01-27 Thread GitBox
guoweiM commented on a change in pull request #14734: URL: https://github.com/apache/flink/pull/14734#discussion_r565270255 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java ## @@ -448,14 +441,24 @@ public void failJobDueToTa

[GitHub] [flink] guoweiM commented on a change in pull request #14734: [FLINK-21066][runtime][checkpoint] Refactor CheckpointCoordinator to compute tasks to trigger/ack/commit dynamically

2021-01-27 Thread GitBox
guoweiM commented on a change in pull request #14734: URL: https://github.com/apache/flink/pull/14734#discussion_r565270255 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java ## @@ -448,14 +441,24 @@ public void failJobDueToTa

[GitHub] [flink] guoweiM commented on a change in pull request #14734: [FLINK-21066][runtime][checkpoint] Refactor CheckpointCoordinator to compute tasks to trigger/ack/commit dynamically

2021-01-27 Thread GitBox
guoweiM commented on a change in pull request #14734: URL: https://github.com/apache/flink/pull/14734#discussion_r565260718 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraphBuilder.java ## @@ -197,22 +197,13 @@ public static Execu