[GitHub] [flink] lindong28 commented on a diff in pull request #22670: [FLINK-28386][runtime] Trigger an immediate checkpoint after all sinks finished

2023-07-03 Thread via GitHub
lindong28 commented on code in PR #22670: URL: https://github.com/apache/flink/pull/22670#discussion_r1250940889 ## flink-runtime/src/main/java/org/apache/flink/runtime/sink/coordinator/SinkCoordinator.java: ## @@ -0,0 +1,158 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [flink] lindong28 commented on a diff in pull request #22670: [FLINK-28386][runtime] Trigger an immediate checkpoint after all sinks finished

2023-06-29 Thread via GitHub
lindong28 commented on code in PR #22670: URL: https://github.com/apache/flink/pull/22670#discussion_r1246843051 ## flink-runtime/src/main/java/org/apache/flink/runtime/sink/coordinator/SinkCoordinator.java: ## @@ -0,0 +1,158 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [flink] lindong28 commented on a diff in pull request #22670: [FLINK-28386][runtime] Trigger an immediate checkpoint after all sinks finished

2023-06-29 Thread via GitHub
lindong28 commented on code in PR #22670: URL: https://github.com/apache/flink/pull/22670#discussion_r1246792310 ## flink-runtime/src/main/java/org/apache/flink/runtime/sink/coordinator/SinkCoordinator.java: ## @@ -0,0 +1,158 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [flink] lindong28 commented on a diff in pull request #22670: [FLINK-28386][runtime] Trigger an immediate checkpoint after all sinks finished

2023-06-29 Thread via GitHub
lindong28 commented on code in PR #22670: URL: https://github.com/apache/flink/pull/22670#discussion_r1246792310 ## flink-runtime/src/main/java/org/apache/flink/runtime/sink/coordinator/SinkCoordinator.java: ## @@ -0,0 +1,158 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [flink] lindong28 commented on a diff in pull request #22670: [FLINK-28386][runtime] Trigger an immediate checkpoint after all sinks finished

2023-06-29 Thread via GitHub
lindong28 commented on code in PR #22670: URL: https://github.com/apache/flink/pull/22670#discussion_r1246557482 ## flink-runtime/src/main/java/org/apache/flink/runtime/sink/coordinator/SinkCoordinator.java: ## @@ -0,0 +1,158 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [flink] lindong28 commented on a diff in pull request #22670: [FLINK-28386][runtime] Trigger an immediate checkpoint after all sinks finished

2023-06-29 Thread via GitHub
lindong28 commented on code in PR #22670: URL: https://github.com/apache/flink/pull/22670#discussion_r1246559612 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SchedulerBase.java: ## @@ -165,6 +166,8 @@ public abstract class SchedulerBase implements SchedulerN

[GitHub] [flink] lindong28 commented on a diff in pull request #22670: [FLINK-28386][runtime] Trigger an immediate checkpoint after all sinks finished

2023-06-29 Thread via GitHub
lindong28 commented on code in PR #22670: URL: https://github.com/apache/flink/pull/22670#discussion_r1246557482 ## flink-runtime/src/main/java/org/apache/flink/runtime/sink/coordinator/SinkCoordinator.java: ## @@ -0,0 +1,158 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [flink] lindong28 commented on a diff in pull request #22670: [FLINK-28386][runtime] Trigger an immediate checkpoint after all sinks finished

2023-06-28 Thread via GitHub
lindong28 commented on code in PR #22670: URL: https://github.com/apache/flink/pull/22670#discussion_r1245094126 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/StateWithExecutionGraph.java: ## @@ -195,6 +200,18 @@ void declineCheckpoint(DeclineCheckpo

[GitHub] [flink] lindong28 commented on a diff in pull request #22670: [FLINK-28386][runtime] Trigger an immediate checkpoint after all sinks finished

2023-06-28 Thread via GitHub
lindong28 commented on code in PR #22670: URL: https://github.com/apache/flink/pull/22670#discussion_r1245086194 ## flink-tests/src/test/java/org/apache/flink/test/checkpointing/ImmediateCheckpointingAfterAllTasksFinishedITCase.java: ## @@ -0,0 +1,202 @@ +/* + * Licensed to the

[GitHub] [flink] lindong28 commented on a diff in pull request #22670: [FLINK-28386][runtime] Trigger an immediate checkpoint after all sinks finished

2023-06-28 Thread via GitHub
lindong28 commented on code in PR #22670: URL: https://github.com/apache/flink/pull/22670#discussion_r1245082814 ## flink-tests/src/test/java/org/apache/flink/test/checkpointing/ImmediateCheckpointingAfterAllTasksFinishedITCase.java: ## @@ -0,0 +1,202 @@ +/* + * Licensed to the

[GitHub] [flink] lindong28 commented on a diff in pull request #22670: [FLINK-28386][runtime] Trigger an immediate checkpoint after all sinks finished

2023-06-28 Thread via GitHub
lindong28 commented on code in PR #22670: URL: https://github.com/apache/flink/pull/22670#discussion_r1245079165 ## flink-tests/src/test/java/org/apache/flink/test/checkpointing/ImmediateCheckpointingAfterAllTasksFinishedITCase.java: ## @@ -0,0 +1,202 @@ +/* + * Licensed to the

[GitHub] [flink] lindong28 commented on a diff in pull request #22670: [FLINK-28386][runtime] Trigger an immediate checkpoint after all sinks finished

2023-06-28 Thread via GitHub
lindong28 commented on code in PR #22670: URL: https://github.com/apache/flink/pull/22670#discussion_r1245059200 ## flink-tests/src/test/java/org/apache/flink/test/checkpointing/ImmediateCheckpointingAfterAllTasksFinishedITCase.java: ## @@ -0,0 +1,202 @@ +/* + * Licensed to the

[GitHub] [flink] lindong28 commented on a diff in pull request #22670: [FLINK-28386][runtime] Trigger an immediate checkpoint after all sinks finished

2023-06-28 Thread via GitHub
lindong28 commented on code in PR #22670: URL: https://github.com/apache/flink/pull/22670#discussion_r1244852829 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SchedulerBase.java: ## @@ -236,6 +239,16 @@ public SchedulerBase( this.exceptionHistory =

[GitHub] [flink] lindong28 commented on a diff in pull request #22670: [FLINK-28386][runtime] Trigger an immediate checkpoint after all sinks finished

2023-06-28 Thread via GitHub
lindong28 commented on code in PR #22670: URL: https://github.com/apache/flink/pull/22670#discussion_r1244817411 ## flink-tests/src/test/java/org/apache/flink/test/checkpointing/ImmediateCheckpointingAfterAllTasksFinishedITCase.java: ## @@ -0,0 +1,202 @@ +/* + * Licensed to the

[GitHub] [flink] lindong28 commented on a diff in pull request #22670: [FLINK-28386][runtime] Trigger an immediate checkpoint after all sinks finished

2023-06-27 Thread via GitHub
lindong28 commented on code in PR #22670: URL: https://github.com/apache/flink/pull/22670#discussion_r1243250725 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SchedulerBase.java: ## @@ -236,6 +239,16 @@ public SchedulerBase( this.exceptionHistory =

[GitHub] [flink] lindong28 commented on a diff in pull request #22670: [FLINK-28386][runtime] Trigger an immediate checkpoint after all sinks finished

2023-06-27 Thread via GitHub
lindong28 commented on code in PR #22670: URL: https://github.com/apache/flink/pull/22670#discussion_r1243653679 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java: ## @@ -502,6 +503,20 @@ public CompletableFuture updateTaskExecutionState(

[GitHub] [flink] lindong28 commented on a diff in pull request #22670: [FLINK-28386][runtime] Trigger an immediate checkpoint after all sinks finished

2023-06-27 Thread via GitHub
lindong28 commented on code in PR #22670: URL: https://github.com/apache/flink/pull/22670#discussion_r1243651135 ## docs/content/docs/dev/datastream/fault-tolerance/checkpointing.md: ## @@ -277,11 +277,10 @@ task with the number of new subtasks equal to the number of running ta

[GitHub] [flink] lindong28 commented on a diff in pull request #22670: [FLINK-28386][runtime] Trigger an immediate checkpoint after all sinks finished

2023-06-27 Thread via GitHub
lindong28 commented on code in PR #22670: URL: https://github.com/apache/flink/pull/22670#discussion_r1243174207 ## flink-tests/src/test/java/org/apache/flink/test/checkpointing/ImmediateCheckpointingAfterAllTasksFinishedITCase.java: ## @@ -0,0 +1,147 @@ +/* + * Licensed to the

[GitHub] [flink] lindong28 commented on a diff in pull request #22670: [FLINK-28386][runtime] Trigger an immediate checkpoint after all sinks finished

2023-06-25 Thread via GitHub
lindong28 commented on code in PR #22670: URL: https://github.com/apache/flink/pull/22670#discussion_r1241122518 ## flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java: ## @@ -929,6 +929,10 @@ private void restoreAndInvoke(TaskInvokable finalInvokable) th