[GitHub] [flink] lirui-apache commented on a change in pull request #13434: [FLINK-19292][hive] HiveCatalog should support specifying Hadoop conf dir with configuration

2020-09-22 Thread GitBox
lirui-apache commented on a change in pull request #13434: URL: https://github.com/apache/flink/pull/13434#discussion_r492720329 ## File path: flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/table/catalog/hive/factories/HiveCatalogFactoryTest.java ## @@ -5

[GitHub] [flink] lirui-apache commented on a change in pull request #13434: [FLINK-19292][hive] HiveCatalog should support specifying Hadoop conf dir with configuration

2020-09-22 Thread GitBox
lirui-apache commented on a change in pull request #13434: URL: https://github.com/apache/flink/pull/13434#discussion_r492720329 ## File path: flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/table/catalog/hive/factories/HiveCatalogFactoryTest.java ## @@ -5

[GitHub] [flink] lirui-apache commented on a change in pull request #13434: [FLINK-19292][hive] HiveCatalog should support specifying Hadoop conf dir with configuration

2020-09-26 Thread GitBox
lirui-apache commented on a change in pull request #13434: URL: https://github.com/apache/flink/pull/13434#discussion_r495519793 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/util/HiveTableUtil.java ## @@ -421,6 +424,31 @

[GitHub] [flink] lirui-apache commented on a change in pull request #13434: [FLINK-19292][hive] HiveCatalog should support specifying Hadoop conf dir with configuration

2020-09-26 Thread GitBox
lirui-apache commented on a change in pull request #13434: URL: https://github.com/apache/flink/pull/13434#discussion_r495534590 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/util/HiveTableUtil.java ## @@ -431,22 +431,23

[GitHub] [flink] lirui-apache commented on a change in pull request #13434: [FLINK-19292][hive] HiveCatalog should support specifying Hadoop conf dir with configuration

2020-09-26 Thread GitBox
lirui-apache commented on a change in pull request #13434: URL: https://github.com/apache/flink/pull/13434#discussion_r495534885 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveCatalog.java ## @@ -195,18 +202,19 @@ priv