[GitHub] [flink] rkhachatryan commented on a change in pull request #18391: [FLINK-25478][chaneglog] Correct the state register logic of ChangelogStateBackendHandle

2022-02-12 Thread GitBox
rkhachatryan commented on a change in pull request #18391: URL: https://github.com/apache/flink/pull/18391#discussion_r805145681 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/changelog/ChangelogStateBackendHandle.java ## @@ -154,14 +177,51 @@ public

[GitHub] [flink] rkhachatryan commented on a change in pull request #18391: [FLINK-25478][chaneglog] Correct the state register logic of ChangelogStateBackendHandle

2022-02-10 Thread GitBox
rkhachatryan commented on a change in pull request #18391: URL: https://github.com/apache/flink/pull/18391#discussion_r803954550 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/metadata/MetadataV2V3SerializerBase.java ## @@ -415,7 +440,7 @@ KeyedS

[GitHub] [flink] rkhachatryan commented on a change in pull request #18391: [FLINK-25478][chaneglog] Correct the state register logic of ChangelogStateBackendHandle

2022-02-10 Thread GitBox
rkhachatryan commented on a change in pull request #18391: URL: https://github.com/apache/flink/pull/18391#discussion_r803781575 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/metadata/MetadataV2V3SerializerBase.java ## @@ -415,7 +440,7 @@ KeyedS

[GitHub] [flink] rkhachatryan commented on a change in pull request #18391: [FLINK-25478][chaneglog] Correct the state register logic of ChangelogStateBackendHandle

2022-02-10 Thread GitBox
rkhachatryan commented on a change in pull request #18391: URL: https://github.com/apache/flink/pull/18391#discussion_r803719499 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/metadata/MetadataV2V3SerializerBase.java ## @@ -415,7 +440,7 @@ KeyedS

[GitHub] [flink] rkhachatryan commented on a change in pull request #18391: [FLINK-25478][chaneglog] Correct the state register logic of ChangelogStateBackendHandle

2022-02-10 Thread GitBox
rkhachatryan commented on a change in pull request #18391: URL: https://github.com/apache/flink/pull/18391#discussion_r803675720 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/metadata/MetadataV2V3SerializerBase.java ## @@ -298,19 +306,24 @@ void

[GitHub] [flink] rkhachatryan commented on a change in pull request #18391: [FLINK-25478][chaneglog] Correct the state register logic of ChangelogStateBackendHandle

2022-02-10 Thread GitBox
rkhachatryan commented on a change in pull request #18391: URL: https://github.com/apache/flink/pull/18391#discussion_r803667329 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/changelog/ChangelogStateHandleStreamImpl.java ## @@ -44,23 +46,42 @@

[GitHub] [flink] rkhachatryan commented on a change in pull request #18391: [FLINK-25478][chaneglog] Correct the state register logic of ChangelogStateBackendHandle

2022-02-10 Thread GitBox
rkhachatryan commented on a change in pull request #18391: URL: https://github.com/apache/flink/pull/18391#discussion_r80321 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/changelog/ChangelogStateBackendHandle.java ## @@ -71,20 +76,30 @@ public Ch

[GitHub] [flink] rkhachatryan commented on a change in pull request #18391: [FLINK-25478][chaneglog] Correct the state register logic of ChangelogStateBackendHandle

2022-02-10 Thread GitBox
rkhachatryan commented on a change in pull request #18391: URL: https://github.com/apache/flink/pull/18391#discussion_r803659360 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/metadata/MetadataV2V3SerializerBase.java ## @@ -298,19 +306,24 @@ void

[GitHub] [flink] rkhachatryan commented on a change in pull request #18391: [FLINK-25478][chaneglog] Correct the state register logic of ChangelogStateBackendHandle

2022-02-10 Thread GitBox
rkhachatryan commented on a change in pull request #18391: URL: https://github.com/apache/flink/pull/18391#discussion_r803516082 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/metadata/MetadataV2V3SerializerBase.java ## @@ -322,19 +335,20 @@ void

[GitHub] [flink] rkhachatryan commented on a change in pull request #18391: [FLINK-25478][chaneglog] Correct the state register logic of ChangelogStateBackendHandle

2022-01-29 Thread GitBox
rkhachatryan commented on a change in pull request #18391: URL: https://github.com/apache/flink/pull/18391#discussion_r795030756 ## File path: flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/ChangelogStateBackend.java ## @@ -271

[GitHub] [flink] rkhachatryan commented on a change in pull request #18391: [FLINK-25478][chaneglog] Correct the state register logic of ChangelogStateBackendHandle

2022-01-29 Thread GitBox
rkhachatryan commented on a change in pull request #18391: URL: https://github.com/apache/flink/pull/18391#discussion_r795030756 ## File path: flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/ChangelogStateBackend.java ## @@ -271

[GitHub] [flink] rkhachatryan commented on a change in pull request #18391: [FLINK-25478][chaneglog] Correct the state register logic of ChangelogStateBackendHandle

2022-01-28 Thread GitBox
rkhachatryan commented on a change in pull request #18391: URL: https://github.com/apache/flink/pull/18391#discussion_r794749336 ## File path: flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/ChangelogStateBackend.java ## @@ -271

[GitHub] [flink] rkhachatryan commented on a change in pull request #18391: [FLINK-25478][chaneglog] Correct the state register logic of ChangelogStateBackendHandle

2022-01-28 Thread GitBox
rkhachatryan commented on a change in pull request #18391: URL: https://github.com/apache/flink/pull/18391#discussion_r794390136 ## File path: flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/ChangelogStateBackend.java ## @@ -271

[GitHub] [flink] rkhachatryan commented on a change in pull request #18391: [FLINK-25478][chaneglog] Correct the state register logic of ChangelogStateBackendHandle

2022-01-28 Thread GitBox
rkhachatryan commented on a change in pull request #18391: URL: https://github.com/apache/flink/pull/18391#discussion_r794396173 ## File path: flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/ChangelogStateBackend.java ## @@ -271

[GitHub] [flink] rkhachatryan commented on a change in pull request #18391: [FLINK-25478][chaneglog] Correct the state register logic of ChangelogStateBackendHandle

2022-01-28 Thread GitBox
rkhachatryan commented on a change in pull request #18391: URL: https://github.com/apache/flink/pull/18391#discussion_r794396173 ## File path: flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/ChangelogStateBackend.java ## @@ -271

[GitHub] [flink] rkhachatryan commented on a change in pull request #18391: [FLINK-25478][chaneglog] Correct the state register logic of ChangelogStateBackendHandle

2022-01-28 Thread GitBox
rkhachatryan commented on a change in pull request #18391: URL: https://github.com/apache/flink/pull/18391#discussion_r794374746 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/changelog/ChangelogStateBackendHandle.java ## @@ -130,14 +155,51 @@ public

[GitHub] [flink] rkhachatryan commented on a change in pull request #18391: [FLINK-25478][chaneglog] Correct the state register logic of ChangelogStateBackendHandle

2022-01-28 Thread GitBox
rkhachatryan commented on a change in pull request #18391: URL: https://github.com/apache/flink/pull/18391#discussion_r794289499 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/changelog/ChangelogStateBackendHandle.java ## @@ -130,14 +155,51 @@ public

[GitHub] [flink] rkhachatryan commented on a change in pull request #18391: [FLINK-25478][chaneglog] Correct the state register logic of ChangelogStateBackendHandle

2022-01-27 Thread GitBox
rkhachatryan commented on a change in pull request #18391: URL: https://github.com/apache/flink/pull/18391#discussion_r793549612 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/changelog/ChangelogStateBackendHandle.java ## @@ -66,16 +71,36 @@ public Ch

[GitHub] [flink] rkhachatryan commented on a change in pull request #18391: [FLINK-25478][chaneglog] Correct the state register logic of ChangelogStateBackendHandle

2022-01-27 Thread GitBox
rkhachatryan commented on a change in pull request #18391: URL: https://github.com/apache/flink/pull/18391#discussion_r793525258 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/state/SharedStateRegistryTest.java ## @@ -143,4 +222,87 @@ public boolean isDisca

[GitHub] [flink] rkhachatryan commented on a change in pull request #18391: [FLINK-25478][chaneglog] Correct the state register logic of ChangelogStateBackendHandle

2022-01-27 Thread GitBox
rkhachatryan commented on a change in pull request #18391: URL: https://github.com/apache/flink/pull/18391#discussion_r793519542 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/changelog/ChangelogStateBackendHandle.java ## @@ -130,14 +155,51 @@ public

[GitHub] [flink] rkhachatryan commented on a change in pull request #18391: [FLINK-25478][chaneglog] Correct the state register logic of ChangelogStateBackendHandle

2022-01-26 Thread GitBox
rkhachatryan commented on a change in pull request #18391: URL: https://github.com/apache/flink/pull/18391#discussion_r792649776 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/changelog/ChangelogStateBackendHandle.java ## @@ -130,14 +155,51 @@ public

[GitHub] [flink] rkhachatryan commented on a change in pull request #18391: [FLINK-25478][chaneglog] Correct the state register logic of ChangelogStateBackendHandle

2022-01-19 Thread GitBox
rkhachatryan commented on a change in pull request #18391: URL: https://github.com/apache/flink/pull/18391#discussion_r787684724 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/changelog/ChangelogStateBackendHandle.java ## @@ -66,16 +71,36 @@ public Ch

[GitHub] [flink] rkhachatryan commented on a change in pull request #18391: [FLINK-25478][chaneglog] Correct the state register logic of ChangelogStateBackendHandle

2022-01-19 Thread GitBox
rkhachatryan commented on a change in pull request #18391: URL: https://github.com/apache/flink/pull/18391#discussion_r787632101 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/state/SharedStateRegistryTest.java ## @@ -98,6 +106,77 @@ public void testUnregis

[GitHub] [flink] rkhachatryan commented on a change in pull request #18391: [FLINK-25478][chaneglog] Correct the state register logic of ChangelogStateBackendHandle

2022-01-19 Thread GitBox
rkhachatryan commented on a change in pull request #18391: URL: https://github.com/apache/flink/pull/18391#discussion_r787631347 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/changelog/ChangelogStateBackendHandle.java ## @@ -66,16 +71,36 @@ public Ch

[GitHub] [flink] rkhachatryan commented on a change in pull request #18391: [FLINK-25478][chaneglog] Correct the state register logic of ChangelogStateBackendHandle

2022-01-19 Thread GitBox
rkhachatryan commented on a change in pull request #18391: URL: https://github.com/apache/flink/pull/18391#discussion_r787623075 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/changelog/ChangelogStateBackendHandle.java ## @@ -66,16 +71,36 @@ public Ch

[GitHub] [flink] rkhachatryan commented on a change in pull request #18391: [FLINK-25478][chaneglog] Correct the state register logic of ChangelogStateBackendHandle

2022-01-18 Thread GitBox
rkhachatryan commented on a change in pull request #18391: URL: https://github.com/apache/flink/pull/18391#discussion_r786880573 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/state/SharedStateRegistryTest.java ## @@ -98,6 +106,77 @@ public void testUnregis

[GitHub] [flink] rkhachatryan commented on a change in pull request #18391: [FLINK-25478][chaneglog] Correct the state register logic of ChangelogStateBackendHandle

2022-01-18 Thread GitBox
rkhachatryan commented on a change in pull request #18391: URL: https://github.com/apache/flink/pull/18391#discussion_r786875320 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/changelog/ChangelogStateBackendHandle.java ## @@ -130,14 +155,51 @@ public