[GitHub] [flink] rmetzger commented on issue #8303: [FLINK-12343]add file replication config for yarn configuration

2019-05-08 Thread GitBox
rmetzger commented on issue #8303: [FLINK-12343]add file replication config for yarn configuration URL: https://github.com/apache/flink/pull/8303#issuecomment-490370551 @xintongsong Thanks a lot for taking a look at the PR. Isn't it a good thing (in this case), that the

[GitHub] [flink] rmetzger commented on issue #8303: [FLINK-12343]add file replication config for yarn configuration

2019-04-30 Thread GitBox
rmetzger commented on issue #8303: [FLINK-12343]add file replication config for yarn configuration URL: https://github.com/apache/flink/pull/8303#issuecomment-487922029 Having looked more at this, I agree with you. We need to go back to step 1 and discuss the overall approach in JIRA.

[GitHub] [flink] rmetzger commented on issue #8303: [FLINK-12343]add file replication config for yarn configuration

2019-04-29 Thread GitBox
rmetzger commented on issue #8303: [FLINK-12343]add file replication config for yarn configuration URL: https://github.com/apache/flink/pull/8303#issuecomment-487632182 I tend to disagree. I think the problem is well defined, the configuration parameter name is okay (not great) and the