[GitHub] [flink] snuyanzin commented on a diff in pull request #21203: [FLINK-21239][Table SQL/API] Upgrade Calcite to 1.28.0

2022-11-15 Thread GitBox
snuyanzin commented on code in PR #21203: URL: https://github.com/apache/flink/pull/21203#discussion_r1022488387 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/casting/AbstractCodeGeneratorCastRule.java: ## @@ -204,9 +204,10 @@ public

[GitHub] [flink] snuyanzin commented on a diff in pull request #21203: [FLINK-21239][Table SQL/API] Upgrade Calcite to 1.28.0

2022-11-14 Thread GitBox
snuyanzin commented on code in PR #21203: URL: https://github.com/apache/flink/pull/21203#discussion_r1021611239 ## flink-table/flink-table-planner/src/main/java/org/apache/calcite/tools/RelBuilder.java: ## @@ -0,0 +1,5161 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [flink] snuyanzin commented on a diff in pull request #21203: [FLINK-21239][Table SQL/API] Upgrade Calcite to 1.28.0

2022-11-07 Thread GitBox
snuyanzin commented on code in PR #21203: URL: https://github.com/apache/flink/pull/21203#discussion_r1016217693 ## flink-table/flink-table-planner/pom.xml: ## @@ -49,6 +49,18 @@ under the License. +

[GitHub] [flink] snuyanzin commented on a diff in pull request #21203: [FLINK-21239][Table SQL/API] Upgrade Calcite to 1.28.0

2022-11-07 Thread GitBox
snuyanzin commented on code in PR #21203: URL: https://github.com/apache/flink/pull/21203#discussion_r1015947724 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/casting/AbstractCodeGeneratorCastRule.java: ## @@ -204,9 +204,10 @@ public

[GitHub] [flink] snuyanzin commented on a diff in pull request #21203: [FLINK-21239][Table SQL/API] Upgrade Calcite to 1.28.0

2022-11-07 Thread GitBox
snuyanzin commented on code in PR #21203: URL: https://github.com/apache/flink/pull/21203#discussion_r1016031451 ## flink-table/flink-table-planner/pom.xml: ## @@ -49,6 +49,18 @@ under the License. +

[GitHub] [flink] snuyanzin commented on a diff in pull request #21203: [FLINK-21239][Table SQL/API] Upgrade Calcite to 1.28.0

2022-11-07 Thread GitBox
snuyanzin commented on code in PR #21203: URL: https://github.com/apache/flink/pull/21203#discussion_r1016031027 ## flink-table/flink-table-planner/pom.xml: ## @@ -49,6 +49,18 @@ under the License. +

[GitHub] [flink] snuyanzin commented on a diff in pull request #21203: [FLINK-21239][Table SQL/API] Upgrade Calcite to 1.28.0

2022-11-07 Thread GitBox
snuyanzin commented on code in PR #21203: URL: https://github.com/apache/flink/pull/21203#discussion_r1016025279 ## flink-table/flink-sql-parser-hive/pom.xml: ## @@ -63,11 +63,51 @@ under the License. +

[GitHub] [flink] snuyanzin commented on a diff in pull request #21203: [FLINK-21239][Table SQL/API] Upgrade Calcite to 1.28.0

2022-11-07 Thread GitBox
snuyanzin commented on code in PR #21203: URL: https://github.com/apache/flink/pull/21203#discussion_r1016024953 ## flink-core/src/main/java/org/apache/flink/core/classloading/ComponentClassLoader.java: ## @@ -189,6 +190,14 @@ public URL getResource(final String name) {

[GitHub] [flink] snuyanzin commented on a diff in pull request #21203: [FLINK-21239][Table SQL/API] Upgrade Calcite to 1.28.0

2022-11-07 Thread GitBox
snuyanzin commented on code in PR #21203: URL: https://github.com/apache/flink/pull/21203#discussion_r1016023426 ## flink-table/flink-table-planner/src/main/java/org/apache/calcite/tools/RelBuilder.java: ## @@ -0,0 +1,5161 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [flink] snuyanzin commented on a diff in pull request #21203: [FLINK-21239][Table SQL/API] Upgrade Calcite to 1.28.0

2022-11-07 Thread GitBox
snuyanzin commented on code in PR #21203: URL: https://github.com/apache/flink/pull/21203#discussion_r1015947724 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/casting/AbstractCodeGeneratorCastRule.java: ## @@ -204,9 +204,10 @@ public

[GitHub] [flink] snuyanzin commented on a diff in pull request #21203: [FLINK-21239][Table SQL/API] Upgrade Calcite to 1.28.0

2022-11-07 Thread GitBox
snuyanzin commented on code in PR #21203: URL: https://github.com/apache/flink/pull/21203#discussion_r1015947724 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/casting/AbstractCodeGeneratorCastRule.java: ## @@ -204,9 +204,10 @@ public

[GitHub] [flink] snuyanzin commented on a diff in pull request #21203: [FLINK-21239][Table SQL/API] Upgrade Calcite to 1.28.0

2022-11-07 Thread GitBox
snuyanzin commented on code in PR #21203: URL: https://github.com/apache/flink/pull/21203#discussion_r1015947724 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/casting/AbstractCodeGeneratorCastRule.java: ## @@ -204,9 +204,10 @@ public

[GitHub] [flink] snuyanzin commented on a diff in pull request #21203: [FLINK-21239][Table SQL/API] Upgrade Calcite to 1.28.0

2022-11-07 Thread GitBox
snuyanzin commented on code in PR #21203: URL: https://github.com/apache/flink/pull/21203#discussion_r1015947724 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/casting/AbstractCodeGeneratorCastRule.java: ## @@ -204,9 +204,10 @@ public

[GitHub] [flink] snuyanzin commented on a diff in pull request #21203: [FLINK-21239][Table SQL/API] Upgrade Calcite to 1.28.0

2022-10-31 Thread GitBox
snuyanzin commented on code in PR #21203: URL: https://github.com/apache/flink/pull/21203#discussion_r1009388476 ## flink-table/flink-table-planner/src/main/java/org/apache/calcite/sql2rel/RelDecorrelator.java: ## @@ -128,11 +129,9 @@ * Copied to fix calcite issues. FLINK

[GitHub] [flink] snuyanzin commented on a diff in pull request #21203: [FLINK-21239][Table SQL/API] Upgrade Calcite to 1.28.0

2022-10-31 Thread GitBox
snuyanzin commented on code in PR #21203: URL: https://github.com/apache/flink/pull/21203#discussion_r1009387699 ## flink-table/flink-sql-client/src/test/resources/sql/module.q: ## @@ -63,6 +63,7 @@ Was expecting one of: ... ... ... + ... Review Comment: