[GitHub] [flink] snuyanzin commented on a diff in pull request #22574: [FLINK-32060][test] Migrate subclasses of BatchAbstractTestBase in table and other modules to JUnit5

2023-05-15 Thread via GitHub
snuyanzin commented on code in PR #22574: URL: https://github.com/apache/flink/pull/22574#discussion_r1194200879 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/StreamFileSystemITCaseBase.scala: ## @@ -23,17 +23,20 @@ import

[GitHub] [flink] snuyanzin commented on a diff in pull request #22574: [FLINK-32060][test] Migrate subclasses of BatchAbstractTestBase in table and other modules to JUnit5

2023-05-15 Thread via GitHub
snuyanzin commented on code in PR #22574: URL: https://github.com/apache/flink/pull/22574#discussion_r1194178109 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/StreamFileSystemITCaseBase.scala: ## @@ -23,17 +23,20 @@ import

[GitHub] [flink] snuyanzin commented on a diff in pull request #22574: [FLINK-32060][test] Migrate subclasses of BatchAbstractTestBase in table and other modules to JUnit5

2023-05-15 Thread via GitHub
snuyanzin commented on code in PR #22574: URL: https://github.com/apache/flink/pull/22574#discussion_r1194163579 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/StreamFileSystemITCaseBase.scala: ## @@ -23,17 +23,20 @@ import

[GitHub] [flink] snuyanzin commented on a diff in pull request #22574: [FLINK-32060][test] Migrate subclasses of BatchAbstractTestBase in table and other modules to JUnit5

2023-05-15 Thread via GitHub
snuyanzin commented on code in PR #22574: URL: https://github.com/apache/flink/pull/22574#discussion_r1194131282 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/batch/sql/FileSystemTestCsvITCase.scala: ## @@ -32,12 +35,11 @@ class

[GitHub] [flink] snuyanzin commented on a diff in pull request #22574: [FLINK-32060][test] Migrate subclasses of BatchAbstractTestBase in table and other modules to JUnit5

2023-05-15 Thread via GitHub
snuyanzin commented on code in PR #22574: URL: https://github.com/apache/flink/pull/22574#discussion_r1194131282 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/batch/sql/FileSystemTestCsvITCase.scala: ## @@ -32,12 +35,11 @@ class

[GitHub] [flink] snuyanzin commented on a diff in pull request #22574: [FLINK-32060][test] Migrate subclasses of BatchAbstractTestBase in table and other modules to JUnit5

2023-05-15 Thread via GitHub
snuyanzin commented on code in PR #22574: URL: https://github.com/apache/flink/pull/22574#discussion_r1194131282 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/batch/sql/FileSystemTestCsvITCase.scala: ## @@ -32,12 +35,11 @@ class

[GitHub] [flink] snuyanzin commented on a diff in pull request #22574: [FLINK-32060][test] Migrate subclasses of BatchAbstractTestBase in table and other modules to JUnit5

2023-05-15 Thread via GitHub
snuyanzin commented on code in PR #22574: URL: https://github.com/apache/flink/pull/22574#discussion_r1193739834 ## flink-formats/flink-parquet/src/test/java/org/apache/flink/formats/parquet/ParquetFileSystemITCase.java: ## @@ -44,21 +47,18 @@ import static

[GitHub] [flink] snuyanzin commented on a diff in pull request #22574: [FLINK-32060][test] Migrate subclasses of BatchAbstractTestBase in table and other modules to JUnit5

2023-05-15 Thread via GitHub
snuyanzin commented on code in PR #22574: URL: https://github.com/apache/flink/pull/22574#discussion_r1193737483 ## flink-formats/flink-orc/src/test/java/org/apache/flink/orc/OrcFileSystemITCase.java: ## @@ -69,22 +72,18 @@ import static

[GitHub] [flink] snuyanzin commented on a diff in pull request #22574: [FLINK-32060][test] Migrate subclasses of BatchAbstractTestBase in table and other modules to JUnit5

2023-05-15 Thread via GitHub
snuyanzin commented on code in PR #22574: URL: https://github.com/apache/flink/pull/22574#discussion_r1193737483 ## flink-formats/flink-orc/src/test/java/org/apache/flink/orc/OrcFileSystemITCase.java: ## @@ -69,22 +72,18 @@ import static

[GitHub] [flink] snuyanzin commented on a diff in pull request #22574: [FLINK-32060][test] Migrate subclasses of BatchAbstractTestBase in table and other modules to JUnit5

2023-05-15 Thread via GitHub
snuyanzin commented on code in PR #22574: URL: https://github.com/apache/flink/pull/22574#discussion_r1193727520 ## flink-formats/flink-parquet/src/test/java/org/apache/flink/formats/parquet/ParquetFileSystemITCase.java: ## @@ -44,21 +47,18 @@ import static

[GitHub] [flink] snuyanzin commented on a diff in pull request #22574: [FLINK-32060][test] Migrate subclasses of BatchAbstractTestBase in table and other modules to JUnit5

2023-05-15 Thread via GitHub
snuyanzin commented on code in PR #22574: URL: https://github.com/apache/flink/pull/22574#discussion_r1193727112 ## flink-formats/flink-avro/src/test/java/org/apache/flink/formats/avro/AvroFilesystemITCase.java: ## @@ -31,20 +33,16 @@ import static