[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #165: [FLINK-26140] Support rollback strategies

gyfora commented on code in PR #165: URL: https://github.com/apache/flink-kubernetes-operator/pull/165#discussion_r851925226 ## flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/controller/RollbackTest.java: ## @@ -265,5 +265,28 @@ public void testRol

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #165: [FLINK-26140] Support rollback strategies

gyfora commented on code in PR #165: URL: https://github.com/apache/flink-kubernetes-operator/pull/165#discussion_r851913674 ## flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/controller/RollbackTest.java: ## @@ -265,5 +265,28 @@ public void testRol

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #165: [FLINK-26140] Support rollback strategies

gyfora commented on code in PR #165: URL: https://github.com/apache/flink-kubernetes-operator/pull/165#discussion_r851913388 ## flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/controller/RollbackTest.java: ## @@ -265,5 +265,28 @@ public void testRol

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #165: [FLINK-26140] Support rollback strategies

gyfora commented on code in PR #165: URL: https://github.com/apache/flink-kubernetes-operator/pull/165#discussion_r851912734 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/deployment/ApplicationObserver.java: ## @@ -70,23 +70,28 @@ prot

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #165: [FLINK-26140] Support rollback strategies

gyfora commented on code in PR #165: URL: https://github.com/apache/flink-kubernetes-operator/pull/165#discussion_r850444187 ## flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/controller/RollbackTest.java: ## @@ -0,0 +1,214 @@ +/* + * Licensed to th

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #165: [FLINK-26140] Support rollback strategies

gyfora commented on code in PR #165: URL: https://github.com/apache/flink-kubernetes-operator/pull/165#discussion_r850340937 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/ApplicationReconciler.java: ## @@ -102,36 +111,84 @

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #165: [FLINK-26140] Support rollback strategies

gyfora commented on code in PR #165: URL: https://github.com/apache/flink-kubernetes-operator/pull/165#discussion_r850340211 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/deployment/AbstractDeploymentObserver.java: ## @@ -159,16 +185,1

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #165: [FLINK-26140] Support rollback strategies

gyfora commented on code in PR #165: URL: https://github.com/apache/flink-kubernetes-operator/pull/165#discussion_r850315021 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/validation/DefaultValidator.java: ## @@ -261,7 +261,7 @@ private Optional

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #165: [FLINK-26140] Support rollback strategies

gyfora commented on code in PR #165: URL: https://github.com/apache/flink-kubernetes-operator/pull/165#discussion_r850314090 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/validation/DefaultValidator.java: ## @@ -261,7 +261,7 @@ private Optional

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #165: [FLINK-26140] Support rollback strategies

gyfora commented on code in PR #165: URL: https://github.com/apache/flink-kubernetes-operator/pull/165#discussion_r850308026 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/ApplicationReconciler.java: ## @@ -102,36 +111,84 @

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #165: [FLINK-26140] Support rollback strategies

gyfora commented on code in PR #165: URL: https://github.com/apache/flink-kubernetes-operator/pull/165#discussion_r850305005 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/ApplicationReconciler.java: ## @@ -102,36 +111,84 @

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #165: [FLINK-26140] Support rollback strategies

gyfora commented on code in PR #165: URL: https://github.com/apache/flink-kubernetes-operator/pull/165#discussion_r850301374 ## docs/content/docs/custom-resource/reference.md: ## @@ -226,9 +226,32 @@ This page serves as a full reference for FlinkDeployment custom resource defi

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #165: [FLINK-26140] Support rollback strategies

gyfora commented on code in PR #165: URL: https://github.com/apache/flink-kubernetes-operator/pull/165#discussion_r850109308 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/deployment/AbstractDeploymentObserver.java: ## @@ -159,16 +185,1

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #165: [FLINK-26140] Support rollback strategies

gyfora commented on code in PR #165: URL: https://github.com/apache/flink-kubernetes-operator/pull/165#discussion_r848156847 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/deployment/ApplicationObserver.java: ## @@ -144,4 +148,22 @@ pri

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #165: [FLINK-26140] Support rollback strategies

gyfora commented on code in PR #165: URL: https://github.com/apache/flink-kubernetes-operator/pull/165#discussion_r848038451 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/ApplicationReconciler.java: ## @@ -111,12 +114,34 @

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #165: [FLINK-26140] Support rollback strategies

gyfora commented on code in PR #165: URL: https://github.com/apache/flink-kubernetes-operator/pull/165#discussion_r848024085 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/ApplicationReconciler.java: ## @@ -111,12 +114,34 @

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #165: [FLINK-26140] Support rollback strategies

gyfora commented on code in PR #165: URL: https://github.com/apache/flink-kubernetes-operator/pull/165#discussion_r848015530 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/deployment/SessionObserver.java: ## @@ -50,4 +52,9 @@ public voi

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #165: [FLINK-26140] Support rollback strategies

gyfora commented on code in PR #165: URL: https://github.com/apache/flink-kubernetes-operator/pull/165#discussion_r848012796 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/ReconciliationUtils.java: ## @@ -62,40 +64,42 @@ public static

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #165: [FLINK-26140] Support rollback strategies

gyfora commented on code in PR #165: URL: https://github.com/apache/flink-kubernetes-operator/pull/165#discussion_r848012465 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/ApplicationReconciler.java: ## @@ -111,12 +114,34 @

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #165: [FLINK-26140] Support rollback strategies

gyfora commented on code in PR #165: URL: https://github.com/apache/flink-kubernetes-operator/pull/165#discussion_r848012019 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/ApplicationReconciler.java: ## @@ -111,12 +114,34 @