[GitHub] [flink-table-store] LadyForest commented on a diff in pull request #182: [FLINK-27708] Add background compaction task for append-only table when ingesting

LadyForest commented on code in PR #182: URL: https://github.com/apache/flink-table-store/pull/182#discussion_r916519475 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/data/AppendOnlyCompactManager.java: ## @@ -0,0 +1,131 @@ +/* + * Licensed to the Apa

[GitHub] [flink-table-store] LadyForest commented on a diff in pull request #182: [FLINK-27708] Add background compaction task for append-only table when ingesting

LadyForest commented on code in PR #182: URL: https://github.com/apache/flink-table-store/pull/182#discussion_r916513394 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/data/AppendOnlyWriter.java: ## @@ -92,22 +108,30 @@ public void write(RowData rowDat

[GitHub] [flink-table-store] LadyForest commented on a diff in pull request #182: [FLINK-27708] Add background compaction task for append-only table when ingesting

LadyForest commented on code in PR #182: URL: https://github.com/apache/flink-table-store/pull/182#discussion_r915536943 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/data/AppendOnlyWriter.java: ## @@ -88,6 +81,9 @@ public void write(RowData rowData)

[GitHub] [flink-table-store] LadyForest commented on a diff in pull request #182: [FLINK-27708] Add background compaction task for append-only table when ingesting

LadyForest commented on code in PR #182: URL: https://github.com/apache/flink-table-store/pull/182#discussion_r915516473 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/operation/AppendOnlyFileStoreWrite.java: ## @@ -82,9 +100,48 @@ public Callable crea

[GitHub] [flink-table-store] LadyForest commented on a diff in pull request #182: [FLINK-27708] Add background compaction task for append-only table when ingesting

LadyForest commented on code in PR #182: URL: https://github.com/apache/flink-table-store/pull/182#discussion_r915513633 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/data/AppendOnlyCompactManager.java: ## @@ -0,0 +1,128 @@ +/* + * Licensed to the Apa

[GitHub] [flink-table-store] LadyForest commented on a diff in pull request #182: [FLINK-27708] Add background compaction task for append-only table when ingesting

LadyForest commented on code in PR #182: URL: https://github.com/apache/flink-table-store/pull/182#discussion_r914344593 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/operation/AbstractFileStoreScan.java: ## @@ -272,4 +272,15 @@ private boolean filter

[GitHub] [flink-table-store] LadyForest commented on a diff in pull request #182: [FLINK-27708] Add background compaction task for append-only table when ingesting

LadyForest commented on code in PR #182: URL: https://github.com/apache/flink-table-store/pull/182#discussion_r911595201 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/compact/CompactManager.java: ## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Soft

[GitHub] [flink-table-store] LadyForest commented on a diff in pull request #182: [FLINK-27708] Add background compaction task for append-only table when ingesting

LadyForest commented on code in PR #182: URL: https://github.com/apache/flink-table-store/pull/182#discussion_r911595201 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/compact/CompactManager.java: ## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Soft