Github user nssalian commented on the issue:
https://github.com/apache/flink/pull/2299
Thanks @mbalassi and @zentol for the review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user mbalassi commented on the issue:
https://github.com/apache/flink/pull/2299
Thanks @nssalian, merging then.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user nssalian commented on the issue:
https://github.com/apache/flink/pull/2299
Hi @mbalassi and @zentol, I ran the builds twice and both instances the
PythonBinderTest passed.
The 2nd build ran with a failure on 2 with:
MVN exited with EXIT CODE: 1.
java.io.FileNotF
Github user nssalian commented on the issue:
https://github.com/apache/flink/pull/2299
Hi @zentol , thank you.I ran the build once locally and it went through.
Just kicked off another for sanity.
---
If your project is set up for it, you can reply to this email and have your
reply ap
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2299
I think it would be fine to merge it without a test; we merged plenty of
PR's like this without requiring a test.
The PythonPlanBinderTest failing is odd, but i would guess that it is
unrelat
Github user nssalian commented on the issue:
https://github.com/apache/flink/pull/2299
hi @mbalassim thank you for the review. I have kicked off a build for my
flink repo. Let me observe what happens.
With regards to a test, I was thinking something on the lines of
FileCacheDelet
Github user mbalassi commented on the issue:
https://github.com/apache/flink/pull/2299
The code change is very concise and looks right, the one issue that bugs me
is that there are no direct tests in place to verify it - and it is not
necessarily straight forward to test as it is a re
Github user nssalian commented on the issue:
https://github.com/apache/flink/pull/2299
Thanks @mbalassi
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user mbalassi commented on the issue:
https://github.com/apache/flink/pull/2299
@nssalian has just reached out to me in person. I will have a look at this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
