[GitHub] flink issue #4769: [FLINK-7758][kafka][hotfix] Fix bug Kafka09Fetcher add ka...

2017-11-02 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/4769 @tzulitai , confirm. because the `FlinkKafkaConsumer011` extend from `FlinkKafkaConsumer010` and `Kafka010Fetcher` extend from `Kafka09Fetcher`, for Kafka connector only need to fix

[GitHub] flink issue #4769: [FLINK-7758][kafka][hotfix] Fix bug Kafka09Fetcher add ka...

2017-11-01 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/4769 @yew1eb doesn't this also need to be fixed for Kafka connector versions 0.10 and 0.11? ---

[GitHub] flink issue #4769: [FLINK-7758][kafka][hotfix] Fix bug Kafka09Fetcher add ka...

2017-10-24 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/4769 @zentol ping. I have updated this PR. ---

[GitHub] flink issue #4769: [FLINK-7758][kafka][hotfix] Fix bug Kafka09Fetcher add ka...

2017-10-18 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4769 The current solution also straight up doesn't work: ``` java.lang.ClassCastException: java.lang.Object cannot be cast to org.apache.flink.metrics.MetricGroup at

[GitHub] flink issue #4769: [FLINK-7758][kafka][hotfix] Fix bug Kafka09Fetcher add ka...

2017-10-18 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4769 As I said, it is better to return an `UnregisteredMetricsGroup`. The current solution will blow up the moment the returned group is used, and can't be guarded against with null checks. ---