Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/5860
Merging
---
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/5860
Hi @glaksh100, thanks for the update!
---
Github user glaksh100 commented on the issue:
https://github.com/apache/flink/pull/5860
@fhueske I gave it some thought and your suggestion makes sense to me. I
have extended `checkForInactiveBuckets` to include the rollover check. I have
also updated Javadocs in a few places:
-
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/5860
Hi @glaksh100,
I just noticed that the bucket closing check is only done when a record is
written. Hence, inactive buckets might not get closed in time if a larger
inactive bucket interval
Github user glaksh100 commented on the issue:
https://github.com/apache/flink/pull/5860
Thanks for reviewing @fhueske @aljoscha and @kl0u ! I have addressed the
latest review comments. Can you PTAL (again) ?
---
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/5860
Thanks for the update @glaksh100! The changes look good to me.
What do you think @aljoscha?
---
Github user glaksh100 commented on the issue:
https://github.com/apache/flink/pull/5860
@fhueske Can you PTAL and merge this PR?
---
Github user narayaruna commented on the issue:
https://github.com/apache/flink/pull/5860
@glaksh100 If you are using BucketingSink with S3, you might be interested
in this [PR](https://github.com/apache/flink/pull/4607) as well.
---
Github user glaksh100 commented on the issue:
https://github.com/apache/flink/pull/5860
@fhueske Thank you for reviewing. I have incorporated the changes that
include update to the
Github user glaksh100 commented on the issue:
https://github.com/apache/flink/pull/5860
@aljoscha @fhueske Can you please take a look?
---
10 matches
Mail list logo
