Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/408
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/408#issuecomment-95868450
Hey Andra,
there are several issues we'll need to fix/add after this is merged. A
Pagerank example is one of them :) I have gathered and will open all related
JIRAs
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/408#issuecomment-95866092
I noticed that there is no GSAPageRank example in the latest version of the
code.
I'd like to take care of that once this PR gets merged, to get to
understand this
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/408#issuecomment-94606828
Hi @balidani!
I pulled your changes and made some improvements, mainly to the examples,
so that they are consistent with the rest of Gelly's examples. You can see my
Github user balidani commented on the pull request:
https://github.com/apache/flink/pull/408#issuecomment-94306580
Hi @vasia!
I fixed the problems, sorry about that. I had to resolve some merge
conflicts and it appears that I did not notice some things. Next time I'll
check t
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/408#issuecomment-94183509
Thanks @balidani for the update! I left some inline comments which should
be fairly easy to address.
I would like to merge this soon and then we should open separate issu
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/408#discussion_r28645615
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/gsa/RichEdge.java
---
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/408#discussion_r28645524
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/GSASingleSourceShortestPathsExample.java
---
@@ -0,0 +1,216 @@
+/*
+ *
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/408#discussion_r28645507
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/GSAConnectedComponentsExample.java
---
@@ -0,0 +1,190 @@
+/*
+ * Licens
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/408#discussion_r28645478
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/Graph.java ---
@@ -914,7 +919,7 @@ public long numberOfVertices() throws Exception {
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/408#discussion_r28645482
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/Graph.java ---
@@ -1011,6 +1016,13 @@ public void reduce(Iterable> values,
Collector> o
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/408#discussion_r28645462
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/Graph.java ---
@@ -79,7 +83,8 @@
private final DataSet> edges;
/**
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/408#discussion_r28645450
--- Diff: flink-staging/flink-gelly/pom.xml ---
@@ -57,4 +57,35 @@ under the License.
${guava.version}
+
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/408#issuecomment-94020543
Thanks @balidani! I'll try to review asap :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user balidani commented on the pull request:
https://github.com/apache/flink/pull/408#issuecomment-94015915
Okay, I updated the PR and Travis passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user balidani commented on the pull request:
https://github.com/apache/flink/pull/408#issuecomment-93977860
Hi @andralungu!
I just talked to Vasia, and I'll do a rebase today.
Cheers!
---
If your project is set up for it, you can reply to this email and have your
r
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/408#issuecomment-93975508
Hi @balidani :)
This PR has not been updated in a while now. Are you facing any issues? In
that case I would like to help. Otherwise, if you're busy maybe it ma
Github user balidani commented on the pull request:
https://github.com/apache/flink/pull/408#issuecomment-84033474
@vasia was completely right about the GGC algorithm, I misunderstood what
it was supposed to do. I implemented the correct version, but it turns out,
after reading the GA
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/408#issuecomment-82588861
Hi @balidani, thanks a lot for the changes! I'll try to run some tests on a
cluster soon and test the new version.
I have a question about the graph coloring example. As
Github user balidani commented on the pull request:
https://github.com/apache/flink/pull/408#issuecomment-82443079
Hi!
I pushed some changes. @vasia told me that she and @StephanEwen even
decided that iterating on triplets is unfeasible, so we should operate on
`` pairs inste
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/408#discussion_r26074204
--- Diff: flink-staging/flink-gelly/pom.xml ---
@@ -52,4 +52,35 @@ under the License.
test
+
+
+
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/408#discussion_r26066814
--- Diff: flink-staging/flink-gelly/pom.xml ---
@@ -52,4 +52,35 @@ under the License.
test
+
+
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/408#issuecomment-4618
- Regarding annotations, I actually tried as many I could find :)) [This is
the commit]
(https://github.com/vasia/flink/blob/653cb21981a80c5790ca29804e39e4c3642aee2d/flink-s
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/408#issuecomment-4317
Ona more thought: The triplet re-building in every iteration seems quite
expensive. Does it make sense to have the triplets (or quadruplets, with the
vertex value) as
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/408#issuecomment-4282
The vertex-centric iterations use semantic annotations a lot to save
sorting/partitioning where possible. This results in a plan for the
vertex-centric iterations that
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/408#issuecomment-4172
Regarding the rest of the comments:
- shall we change the SumFunction, ApplyFunction, etc. to have 2 versions,
i.e. single-abstract-interface and rich? If yes, it should
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/408#discussion_r26008902
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/gsa/ApplyFunction.java
---
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apach
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/408#discussion_r26008874
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/gsa/ApplyFunction.java
---
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Soft
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/408#discussion_r26008662
--- Diff: flink-staging/flink-gelly/pom.xml ---
@@ -52,4 +52,35 @@ under the License.
test
+
+
+
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/408#issuecomment-77750264
I am just dropping some more thoughts here ;-)
The interface seems a bit confusing. Right now, one has to first create the
iteration from the graph and then te
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/408#discussion_r26005198
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/gsa/ApplyFunction.java
---
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apach
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/408#discussion_r26005153
--- Diff: flink-staging/flink-gelly/pom.xml ---
@@ -52,4 +52,35 @@ under the License.
test
+
+
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/408#issuecomment-77749391
In the core API, we have started to define all functions (map, join, ... -
here it would be SumFunction, ApplyFunction) as single-abstract-method
interfaces. That allo
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/408#issuecomment-77749211
This adds a Guava dependency and does some Hadoop profile magic. We have to
be very careful when merging this to be consistent with changes in #454 by
@rmetzger
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/408#issuecomment-77341085
Not sure why the last Travis check failed because the pom.xml seems to be
the correct one.
But apart from that, this looks very nice and compliant with the vert
Github user andralungu commented on a diff in the pull request:
https://github.com/apache/flink/pull/408#discussion_r25853291
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/gsa/GatherSumApplyIteration.java
---
@@ -0,0 +1,374 @@
+/*
+ * Licensed to
Github user andralungu commented on a diff in the pull request:
https://github.com/apache/flink/pull/408#discussion_r25852832
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/GSAGreedyGraphColoringExample.java
---
@@ -0,0 +1,212 @@
+/*
+ * L
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/408#discussion_r25391723
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/GSASingleSourceShortestPathsExample.java
---
@@ -0,0 +1,216 @@
+/*
+ *
Github user balidani commented on a diff in the pull request:
https://github.com/apache/flink/pull/408#discussion_r25391476
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/GSASingleSourceShortestPathsExample.java
---
@@ -0,0 +1,216 @@
+/*
+
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/408#issuecomment-76083807
Thanks for the revision @balidani! I added some minor inline comments.
I'd like someone else to also review this before we merge.
In the meantime, I'll try to find som
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/408#discussion_r25390113
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/GSASingleSourceShortestPathsExample.java
---
@@ -0,0 +1,216 @@
+/*
+ *
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/408#discussion_r25389945
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/gsa/Triplet.java
---
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software F
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/408#discussion_r25389899
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/gsa/Triplet.java
---
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software F
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/408#discussion_r25389859
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/GSASingleSourceShortestPathsExample.java
---
@@ -0,0 +1,216 @@
+/*
+ *
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/408#issuecomment-75770438
This looks great already! We just need a few more changes:
- you can add the `Triplet` type inside the gsa package. This should just
be a simple wrapper around `Tuple3`.
Github user balidani commented on a diff in the pull request:
https://github.com/apache/flink/pull/408#discussion_r25256087
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/GSASingleSourceShortestPathsExample.java
---
@@ -0,0 +1,232 @@
+/*
+
Github user balidani commented on a diff in the pull request:
https://github.com/apache/flink/pull/408#discussion_r25255250
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/GSASingleSourceShortestPathsExample.java
---
@@ -0,0 +1,232 @@
+/*
+
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/408#discussion_r25255528
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/GSASingleSourceShortestPathsExample.java
---
@@ -0,0 +1,232 @@
+/*
+ *
Github user balidani commented on a diff in the pull request:
https://github.com/apache/flink/pull/408#discussion_r25255193
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/GSASingleSourceShortestPathsExample.java
---
@@ -0,0 +1,232 @@
+/*
+
Github user balidani commented on a diff in the pull request:
https://github.com/apache/flink/pull/408#discussion_r25255094
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/GSASingleSourceShortestPathsExample.java
---
@@ -0,0 +1,232 @@
+/*
+
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/408#discussion_r25255045
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/GSASingleSourceShortestPathsExample.java
---
@@ -0,0 +1,232 @@
+/*
+ *
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/408#discussion_r25254768
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/GSASingleSourceShortestPathsExample.java
---
@@ -0,0 +1,232 @@
+/*
+ *
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/408#discussion_r25254691
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/GSASingleSourceShortestPathsExample.java
---
@@ -0,0 +1,232 @@
+/*
+ *
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/408#discussion_r25254212
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/GSASingleSourceShortestPathsExample.java
---
@@ -0,0 +1,232 @@
+/*
+ *
Github user balidani commented on the pull request:
https://github.com/apache/flink/pull/408#issuecomment-75755326
Hi @vasia, all!
So I implemented the changes that @vasia suggested. I also added a commit
that adds the Hadoop profiles to the `flink-gelly` project in `pom.xml`,
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/408#issuecomment-75557616
I had an offline discussion with @balidani and we figured that the
exception was actually coming from the test, not the GatherSumApplyIteration.
So, no issue here.
Github user balidani commented on the pull request:
https://github.com/apache/flink/pull/408#issuecomment-75546102
Hi @vasia!
Thanks for the review! I started making the changed, but I got stuck. I get
an exception about `GatherUdf` not being Serializable. I tried copying from
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/408#issuecomment-75249793
Hi @balidani! Thanks a lot for this PR! Gather-Sum-Apply will be an awesome
addition to Gelly ^^
Here come my comments:
- There's no need for Gather, Sum and App
Github user balidani commented on a diff in the pull request:
https://github.com/apache/flink/pull/408#discussion_r24763748
--- Diff:
flink-staging/flink-gelly/src/test/java/org/apache/flink/graph/test/GatherSumApplyITCase.java
---
@@ -0,0 +1,212 @@
+/*
+ * Licensed to the
GitHub user balidani opened a pull request:
https://github.com/apache/flink/pull/408
[FLINK-1514][Gelly] Add a Gather-Sum-Apply iteration method
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/balidani/flink gelly-gsa
Alternativ
60 matches
Mail list logo
