Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/876
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/876#issuecomment-117663964
:+1: Thanks :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enab
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/876#issuecomment-117662372
Which comment? I added a test also for the short variant.
Merging this ...
---
If your project is set up for it, you can reply to this email and have your
reply
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/876#issuecomment-117630964
Looks good except for the test case comment I made.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/876#discussion_r33671148
--- Diff:
flink-yarn-tests/src/main/java/org/apache/flink/yarn/YARNSessionFIFOITCase.java
---
@@ -121,6 +121,7 @@ public void testDetachedMode() {
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/876#issuecomment-117613418
Thx for the good PR, Robert :)
+1 LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/876#issuecomment-117581828
I've addressed your concerns and updated the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/876#discussion_r33662529
--- Diff: docs/setup/yarn_setup.md ---
@@ -100,11 +100,13 @@ Usage:
-D Dynamic properties
-d,--detached
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/876#discussion_r33662338
--- Diff: docs/setup/yarn_setup.md ---
@@ -100,11 +100,13 @@ Usage:
-D Dynamic properties
-d,--detached
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/876#discussion_r33657185
--- Diff:
flink-yarn-tests/src/main/java/org/apache/flink/yarn/YARNSessionFIFOITCase.java
---
@@ -121,6 +121,7 @@ public void testDetachedMode() {
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/876#discussion_r33657128
--- Diff: docs/setup/yarn_setup.md ---
@@ -100,11 +100,13 @@ Usage:
-D Dynamic properties
-d,--detached
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/flink/pull/876#discussion_r33604736
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/FlinkYarnClient.java ---
@@ -591,14 +592,17 @@ protected AbstractFlinkYarnCluster
deployInternal(Str
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/flink/pull/876#discussion_r33604696
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/FlinkYarnClient.java ---
@@ -341,7 +342,7 @@ public AbstractFlinkYarnCluster run() throws Exception {
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/876
[FLINK-2298] Allow setting a custom application name on YARN
With this change, users can pass a "--name" argument to the YARN session to
give the YARN application a custom name.
I've covere
14 matches
Mail list logo
